From nobody Mon Feb 9 22:41:15 2026 Received: from fhigh-b7-smtp.messagingengine.com (fhigh-b7-smtp.messagingengine.com [202.12.124.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63414215F42 for ; Fri, 14 Nov 2025 14:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131468; cv=none; b=gTPnemHBJkZqtdxs2RmaL+4+wd7m3oIeJercb6fa+tgoYq/BaF0d+RJTLhzumdjnIfeIJ7qovB0M6fkIvleqmd7aUtbryeMaZwO/cJTLUQz7wi3cemONGHw9snUmR28kzCbYC3tunMCVWJW0FR7Ifylw3ZXTqqZDMMZs6CU9Ylk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131468; c=relaxed/simple; bh=+H/v74wAsjxZdGp+pqGaeVy80WE5gEPxVVA1g5sL3Tk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bJofkVaMwST66X5kSGHZg9HCt86wgYsKcC+RWmjvLEV4FVjwgjcuSQaj5YsWZg9q/kzhFeSLl3M0ZCGxGMeDqJCf7AVEylHtuTtmvgi8IDE+tU/AChTjqg88OVN75HVH6/WLSFFTciFHliYC27K5obIZ5G3Wk7+BKMO6EuCbIUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=MnQJLS33; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=0NuRVpU3; arc=none smtp.client-ip=202.12.124.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="MnQJLS33"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="0NuRVpU3" Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 6E4CB7A0126; Fri, 14 Nov 2025 09:44:24 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Fri, 14 Nov 2025 09:44:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm3; t=1763131464; x=1763217864; bh=gFZPavq6jI sqPGzCpycNZAV1mIC2qgkd2lLvpZGU71E=; b=MnQJLS33GcGVQlCuOY9R9QZxj4 UXTxnhKKeXZovcmlTuRJ/qgWBuVnrme9GdrJ6YuXwcpVkqksEbkcNKF07lsCzJ7+ U5Y3W3iR83FgoC2EZXZAsbghG6ZBg01Cz6f0EDPIDFsoQ0ceWq1vhsjUBTyLlcda zWpMn3XQ4pMfO8ZnMhJeaBXPplKpvd2I9xOvylrtNiim0F5rnpeM6G0do9HO5LCl YaGkXc6eEkszAkHHTRFP4+W4ftYh9dzseVRxDdd5cBMUcNOOLxJ3u4UAVObk6qRo xfc4raXMWHgg3MbozP29X9bteVHKbUSgm6VR3HChb9NPln3EfBRCvPCWaJNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1763131464; x=1763217864; bh=gFZPavq6jIsqPGzCpycNZAV1mIC2qgkd2lL vpZGU71E=; b=0NuRVpU3SUJ4nD3pS8LWojv5BZASc7KquRxf4mxQs8DB80JbvhV tZO1dJsbhFUZMwonEt7PDt9NhNWqWJsiwaeUr/BtAw38dyhxIMIoWf58JXw2CWWO GRteE0XRKRZmHEPlNt7jW0NCye35MX6vZCTH9iTedyOXl6tW29SJOEYb3WbhTtIl m/8jw/mtFyzsK8oYwK8br5w2wDwsEdGVCCYbk0ENVpRzkgD2WD+7YxKSBqbVk2ol L1eAAeYhCwiuHJZrgXpf6fGm/hAkn6lFRFPcv/R4O+VxbT7RRC/X9Nzcfn26Jl5Y s0us3j7Pi5Xte1G/sYw4MXceT9fG+BAdVBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvuddttdelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhi sehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeffvdeuleffveekud fhteejudffgefhtedtgfeutdfgvdfgueefudehveehveekkeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrghkrg hmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdp rhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurhgtvg hfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdr khgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Nov 2025 09:44:23 -0500 (EST) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH] firewire: core: fix to update generation field in topology map Date: Fri, 14 Nov 2025 23:44:21 +0900 Message-ID: <20251114144421.415278-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The generation field of topology map is updated after initialized by zero. The updated value of generation field is always zero, and is against specification. This commit fixes the bug. Fixes: 7d138cb269db ("firewire: core: use spin lock specific to topology ma= p") Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topol= ogy.c index 2f73bcd5696f..ed3ae8cdb0cd 100644 --- a/drivers/firewire/core-topology.c +++ b/drivers/firewire/core-topology.c @@ -441,12 +441,13 @@ static void update_topology_map(__be32 *buffer, size_= t buffer_size, int root_nod const u32 *self_ids, int self_id_count) { __be32 *map =3D buffer; + u32 next_generation =3D be32_to_cpu(buffer[1]) + 1; int node_count =3D (root_node_id & 0x3f) + 1; =20 memset(map, 0, buffer_size); =20 *map++ =3D cpu_to_be32((self_id_count + 2) << 16); - *map++ =3D cpu_to_be32(be32_to_cpu(buffer[1]) + 1); + *map++ =3D cpu_to_be32(next_generation); *map++ =3D cpu_to_be32((node_count << 16) | self_id_count); =20 while (self_id_count--) --=20 2.51.0