From nobody Sat Feb 7 18:20:50 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BC38326D5F for ; Fri, 14 Nov 2025 14:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131486; cv=none; b=hOzxuG3hmRHwHLfVZsUxstcOBEVuumNpdpp5tKzoRsfoSpvY9UNWDydtYtIME5k89n91iNDpUpVpScW8JSOQkVfWF/nExq/TGBCSrR5eok06a1gGopIVtZBts7JMq/oVlpI7xN4OPhpzuSxW/+0QT/+hsFRN/bI3gURtSbt78+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131486; c=relaxed/simple; bh=ri3Ab/w8ylepNYDhS7++udAmqB7j+tQzODtC2zg91p8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YWt+m2RA4OcEnu+3xMgk5NV0JswaQkyVIv95QOFyRGeLI+UMLtw1+vBTlFC1vAk1bOZ3eu3noMh9Hi+aSu45k5L5o6zbViAX0leJL7VR31w2Envl+270j1q7+XHR5rhUy8lMongpsu94pQnoms1bU8MNpc5Eq/TJ2UfOwBlpHss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E9B9K/ha; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9B9K/ha" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8b23b6d9f11so198445285a.3 for ; Fri, 14 Nov 2025 06:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763131483; x=1763736283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aWteGZHapM/ld2g8RPEQnKVKieUk3L8Us0utHpeCavw=; b=E9B9K/ha46D26PJezHpYj1Qq37r9xf9hnuH4vrf7MR6iHdRON8DCOZ7v2H+2GUZ9uL tw5riJIB4bPh0iRxPAzvc2gcHFxLV7fd4SOviyu92nRkFKOj3flpKGs0WbcJ1kcm9tRS hlYv9+xT0wBFbJK1vvyiHJxphi3NrgxbmxsODU4f3sy+R8AqTtF6uTadUVQeUPQtOaEK 16PZ/RcYDCyO7FMHIg6manGj28bv+d87em3RiygF8oOJIKT4oR6UqkNN+OPaYOdPXhPD m+PbKw/Q/uQ4iZK8mHcBC+kGcEk4VcwN2JebYBo1q+8Qh3cdHIntee2UloRw4FJpV1GG r0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763131483; x=1763736283; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aWteGZHapM/ld2g8RPEQnKVKieUk3L8Us0utHpeCavw=; b=AJg6pmxP+Jqz4L2GyI0TxZ2xJhqRT+m/yF7hoyQz4iU5Zs97e+l2aVwD6lN0CbIUn1 EGTsMTE2FDsqCsKn2KOfWtVxLXuutgfBU0F0ubKtCkcUahHn3ic6MhJ2jw4PPBuVW8CC lrg11T7X1F9xePITR9LQYijBGQWYHqNtD9OuD+Gf1NwUEyZZztBSVsLTYSLsZglWxmgM NlEYR9sETb+oQalIB+RUWCO5Hu9Wkt55/4dfpDUIKmjjdaEXZKsLMPPJ2xQwBzsbQ8XD U3yQ5xGl3iMcc+5JBWKm/o4Jd3Gh+qDbngB9Km9IFYdBYoQFMuwwvh83sEfW+V/p+0QG EQdw== X-Forwarded-Encrypted: i=1; AJvYcCUSnI2xirf3jYo3KEiCMWXkEoL+fU7W8AN/B/FvnmyrQzTOmaa/vgQ+x3ZyTWIFqcNUbh3n+StAqixm/3M=@vger.kernel.org X-Gm-Message-State: AOJu0YwfKwxS1V1NiBoxGgVsgA727EUUHxF/IzOrUIN4vU0ihreU3nC/ QtXQ82VrtAEBkK//Q0fRrKnljYcM0i7Rr8YvXxeOlFv1p1KzMl251ZaT X-Gm-Gg: ASbGncuRnJTxTaZ3N/Y6YCONaVKeH1+4II4KG/dUdV2lo7B2bG3d860UsuU+g9i+TwP RSWwWtznvGIh95t2RFiDMsi/5MfBmrPtW3cSCGJ9C7xvYQi/7AU/B6oQNhGJ+NnS7lvqJVd9WA9 Bwza7HzDGoM95tsgUKQ7M+NFkiZyHSXDB5O/vLd659bDGeBot8oDaUYX6+kbiydq7HBDaJSEfEB e5UmUZFNFSu9oiOLuwNiZz+23cY+gYWJSXrsy3Y1HrOB03CieDFv5R1rsWJh3kJkeyQNl1wEUro 1dLh2UhAhGiLrMSe97dNInQg46GJ+955C45HZhf0igeMiUbWNHZ3lkbwiLMHVFd2Sp5c6qsxAqx i3poGhq/xdvjEsTT1A0QSPqFdVMxcyzB46pP4hTG2Vq+GJwjMbt0ItuXs5+gjORk4H7paxFhy5F RXi2FdbzKRdL6NrMq0DWpptwRpkDUM6pI= X-Google-Smtp-Source: AGHT+IFPjQlSqC/ss4lwRCrHnzgS910DC//wiBOCNwnW0xCnYqx8uCQ1I2xzaPFYMjeaq4Ndw+mQCQ== X-Received: by 2002:a05:620a:f15:b0:8b2:7726:c7cd with SMTP id af79cd13be357-8b2c31a622amr400786885a.49.1763131483265; Fri, 14 Nov 2025 06:44:43 -0800 (PST) Received: from rpthibeault-XPS-13-9305.. ([23.233.177.113]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2af048749sm344232285a.49.2025.11.14.06.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 06:44:42 -0800 (PST) From: Raphael Pinsonneault-Thibeault To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz, cascardo@igalia.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, syzbot+3ee481e21fd75e14c397@syzkaller.appspotmail.com, Raphael Pinsonneault-Thibeault Subject: [PATCH] loop: don't change loop device under exclusive opener in loop_set_status Date: Fri, 14 Nov 2025 09:42:05 -0500 Message-ID: <20251114144204.2402336-2-rpthibeault@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" loop_set_status() is allowed to change the loop device while there are other openers of the device, even exclusive ones. In this case, it causes a KASAN: slab-out-of-bounds Read in ext4_search_dir(), since when looking for an entry in an inlined directory, e_value_offs is changed underneath the filesystem by loop_set_status(). Fix the problem by forbidding loop_set_status() from modifying the loop device while there are exclusive openers of the device. This is similar to the fix in loop_configure() by commit 33ec3e53e7b1 ("loop: Don't change loop device under exclusive opener") alongside commit ecbe6bc0003b ("block: use bd_prepare_to_claim directly in the loop driver"). Reported-by: syzbot+3ee481e21fd75e14c397@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D3ee481e21fd75e14c397 Tested-by: syzbot+3ee481e21fd75e14c397@syzkaller.appspotmail.com Signed-off-by: Raphael Pinsonneault-Thibeault Reviewed-by: Jan Kara Tested-by: Yongpeng Yang --- ML thread for previous, misguided patch idea: https://lore.kernel.org/all/20251112185712.2031993-2-rpthibeault@gmail.com/= t/ drivers/block/loop.c | 41 ++++++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 053a086d547e..756ee682e767 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1222,13 +1222,24 @@ static int loop_clr_fd(struct loop_device *lo) } =20 static int -loop_set_status(struct loop_device *lo, const struct loop_info64 *info) +loop_set_status(struct loop_device *lo, blk_mode_t mode, + struct block_device *bdev, const struct loop_info64 *info) { int err; bool partscan =3D false; bool size_changed =3D false; unsigned int memflags; =20 + /* + * If we don't hold exclusive handle for the device, upgrade to it + * here to avoid changing device under exclusive owner. + */ + if (!(mode & BLK_OPEN_EXCL)) { + err =3D bd_prepare_to_claim(bdev, loop_set_status, NULL); + if (err) + goto out_reread_partitions; + } + err =3D mutex_lock_killable(&lo->lo_mutex); if (err) return err; @@ -1270,6 +1281,9 @@ loop_set_status(struct loop_device *lo, const struct = loop_info64 *info) } out_unlock: mutex_unlock(&lo->lo_mutex); + if (!(mode & BLK_OPEN_EXCL)) + bd_abort_claiming(bdev, loop_set_status); +out_reread_partitions: if (partscan) loop_reread_partitions(lo); =20 @@ -1349,7 +1363,9 @@ loop_info64_to_old(const struct loop_info64 *info64, = struct loop_info *info) } =20 static int -loop_set_status_old(struct loop_device *lo, const struct loop_info __user = *arg) +loop_set_status_old(struct loop_device *lo, blk_mode_t mode, + struct block_device *bdev, + const struct loop_info __user *arg) { struct loop_info info; struct loop_info64 info64; @@ -1357,17 +1373,19 @@ loop_set_status_old(struct loop_device *lo, const s= truct loop_info __user *arg) if (copy_from_user(&info, arg, sizeof (struct loop_info))) return -EFAULT; loop_info64_from_old(&info, &info64); - return loop_set_status(lo, &info64); + return loop_set_status(lo, mode, bdev, &info64); } =20 static int -loop_set_status64(struct loop_device *lo, const struct loop_info64 __user = *arg) +loop_set_status64(struct loop_device *lo, blk_mode_t mode, + struct block_device *bdev, + const struct loop_info64 __user *arg) { struct loop_info64 info64; =20 if (copy_from_user(&info64, arg, sizeof (struct loop_info64))) return -EFAULT; - return loop_set_status(lo, &info64); + return loop_set_status(lo, mode, bdev, &info64); } =20 static int @@ -1546,14 +1564,14 @@ static int lo_ioctl(struct block_device *bdev, blk_= mode_t mode, case LOOP_SET_STATUS: err =3D -EPERM; if ((mode & BLK_OPEN_WRITE) || capable(CAP_SYS_ADMIN)) - err =3D loop_set_status_old(lo, argp); + err =3D loop_set_status_old(lo, mode, bdev, argp); break; case LOOP_GET_STATUS: return loop_get_status_old(lo, argp); case LOOP_SET_STATUS64: err =3D -EPERM; if ((mode & BLK_OPEN_WRITE) || capable(CAP_SYS_ADMIN)) - err =3D loop_set_status64(lo, argp); + err =3D loop_set_status64(lo, mode, bdev, argp); break; case LOOP_GET_STATUS64: return loop_get_status64(lo, argp); @@ -1647,8 +1665,9 @@ loop_info64_to_compat(const struct loop_info64 *info6= 4, } =20 static int -loop_set_status_compat(struct loop_device *lo, - const struct compat_loop_info __user *arg) +loop_set_status_compat(struct loop_device *lo, blk_mode_t mode, + struct block_device *bdev, + const struct compat_loop_info __user *arg) { struct loop_info64 info64; int ret; @@ -1656,7 +1675,7 @@ loop_set_status_compat(struct loop_device *lo, ret =3D loop_info64_from_compat(arg, &info64); if (ret < 0) return ret; - return loop_set_status(lo, &info64); + return loop_set_status(lo, mode, bdev, &info64); } =20 static int @@ -1682,7 +1701,7 @@ static int lo_compat_ioctl(struct block_device *bdev,= blk_mode_t mode, =20 switch(cmd) { case LOOP_SET_STATUS: - err =3D loop_set_status_compat(lo, + err =3D loop_set_status_compat(lo, mode, bdev, (const struct compat_loop_info __user *)arg); break; case LOOP_GET_STATUS: --=20 2.43.0