From nobody Sun Feb 8 10:49:09 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7F8827F017 for ; Fri, 14 Nov 2025 14:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131010; cv=none; b=E56T7fg9BinBrYptLRsqXAVI+ZklNiCTa5h0beaWFVIDUEUdnzXIghIYZ24/YV/07QK6U2a4Z+WY3gszU6BP4mlqja/0+TtPKhqMYoaM62D+lVoszz0rDWZsrUnDNXdgm52tbSBjRnzbMfRIlSxJkwl6VoUnKSJS+3fx3nKDjmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763131010; c=relaxed/simple; bh=5oiwv6mEhesXwM+Lol5TKk+wjZkheHlbxNNSNOrecpg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HfVbs1SSy9o0Je4IqTvfHn4i1tVXWyvx4bPVXc59eMLehglNubXr3mVNIg+SkILZeO4ArKgxUH6Yqy4ml8MOnN28Iqaw2Gtss/HDtWEPWhDLqVuA6fk9+HPLUBt50MzL7UKXIlh2iA1rLH1R5173Y4VPi3oSUzd6VmZbSEoQmF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dMWJyhds; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dMWJyhds" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297ec50477aso15097565ad.1 for ; Fri, 14 Nov 2025 06:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763131008; x=1763735808; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nSIls/3M4TGLauUnBJ5m3zl3fUniDuatmjiolK/RIlA=; b=dMWJyhdsqXZq4nrqjr6Utf1CKU2jUbCWzlBY0lI5Bo0MmNacnB24kjucu8TWtgNQcN zoe1ti0prMEnIx6aw1v7YI8q34ucnsywUh8qPRyiIHoOi57cPc9vBecIf5cZjNE6LwAk f1Bd48lnWPgj/W4ZwGe/VdJ2tnAuK4ZWRCawqj6b0pGovvAfbQvmF25dsAYZ569bhdCP JM8KgbuI3dY6btscyD91+ktk7ba1gxBZW7hOF/CpRnHnAGUpg1YcYyHr2XXLO3S2TUEt n0KMkbGZludn7VQp+hQMNMWYhDRLd9vX7puKqHNu+L3hwtj0U20e3bj/MPIXn5P6BG8b VyCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763131008; x=1763735808; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nSIls/3M4TGLauUnBJ5m3zl3fUniDuatmjiolK/RIlA=; b=LnpLqo/OaNWu8mcmexsa/4zGAx6Fbr3HvjVNHeQZ4Yh5S4umTvnDYWb0dPXcZLFTLj qVVKg0IgzeYeUhv2+c8ZXZU/+DR6oGexfuoK0f6PJCDes7fu5JPHVD8fiqc1bRkYr2Xt b/XASaNNup2QNo/FGbHrtuZQXCxD9T0xhNx+MHnTT8bfLfPwjevK4ScL5qCAlUh3t62s jra9D+1EUVglbSHpaPVHhh3W4D0p1s5GibaNkSKLD9G8qlRjr+YvDyZBvpisP5/C8KAT UnBdxRYUEGIFdTNItEhc3zM+czaOP/8jjyNF48TH8U4yJ4o05T/bj4c9gYMdcWC5zU1E iIuA== X-Forwarded-Encrypted: i=1; AJvYcCUT86aW5NonPdCMfpS3EFeVunU1vyFTTvePrU9Nfxb/YgjmFVPbGDjvjI5gjKYoGBu9eGCbsmPoVyooNOA=@vger.kernel.org X-Gm-Message-State: AOJu0YyNnC5AVmVQxxV/rkA85JHM1eIoXFfIdGzfKr6/3dbvuufriD4D 4hQCD2rncm6NITYdCeFITgcURz4XkTjpZauOttJTr0blI7kt9ABXzLFk X-Gm-Gg: ASbGnculPVPiINs1J7yMV+CEzZZmdusJrqEEV1dNYS6ntkLLzofTCqbNCZjgogSZtoY WtSBBGwP5mEUBw+oeJwHxw222gYL45ey+9K+zbr0aDtE3Yl8eenIymHYg51EQ5NikziR3/xErsW vs8M9et2IdqhLya2F4A2dApqn+da5C9luW8rb6XSRw7pnZIvEJJvckWteUpA9OQm2dXr/61lhM7 HPpZote78/2l3xoZ+JkLUwWPmZ+Lj6ltVWOwKEA6JH3VwumruX4lOdEBFeOHekuVa/FCohUDuIv QTmYH3jSuYu7S8PN0rjKDD4p9lC55ECJD6IQmIok4FF9Z50dPc6H+tBE9fuQPtEyJ/vG7XNxV9G AjcvPjnLuHD5ZQKgAKfg+hbKK0RYfKCTDr/ikfOwNVLuEMP1S/cJFNc+ZUBP0n9IQVohdzVxJ9B I2G7GCJVIMYMz3MWS2uTuouHSB X-Google-Smtp-Source: AGHT+IFUOGj7TJVl2OCdFbicu59hvK0bO9kwvvs9SY9g8DkfUCcDnSMPschk57hnTF261AwCNWmJ3Q== X-Received: by 2002:a17:902:e54c:b0:297:df84:bd18 with SMTP id d9443c01a7336-298680346c1mr44257275ad.30.1763131007988; Fri, 14 Nov 2025 06:36:47 -0800 (PST) Received: from rahul-mintos.ban-spse ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2b106bsm57015555ad.58.2025.11.14.06.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 06:36:47 -0800 (PST) From: Rahul Kumar To: liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rk0006818@gmail.com Subject: [PATCH] drm/komeda: Convert logging in d71_dev.c to drm_* with drm_device parameter Date: Fri, 14 Nov 2025 20:06:27 +0530 Message-ID: <20251114143627.3981217-1-rk0006818@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace DRM_DEBUG() and DRM_ERROR() calls in drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c with the drm_dbg() and drm_err() helpers in functions where a drm_device parameter is available. The drm_*() logging macros require a struct drm_device * parameter, which allows the DRM core to prefix log messages with the device instance. This improves debugging clarity when multiple Komeda or other DRM devices are present. Logging in early hardware probing functions such as d71_identify() is intentionally left unchanged because they do not have access to a drm_device pointer at that stage of initialization. This conversion follows the DRM TODO entry: "Convert logging to drm_* functions with drm_device parameter". Signed-off-by: Rahul Kumar --- .../gpu/drm/arm/display/komeda/d71/d71_dev.c | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu= /drm/arm/display/komeda/d71/d71_dev.c index 80973975bfdb..4305354badc8 100644 --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c @@ -9,6 +9,7 @@ #include #include "d71_dev.h" #include "malidp_io.h" +#include "komeda_kms.h" =20 static u64 get_lpu_event(struct d71_pipeline *d71_pipeline) { @@ -348,6 +349,8 @@ static void d71_cleanup(struct komeda_dev *mdev) =20 static int d71_enum_resources(struct komeda_dev *mdev) { + struct komeda_kms_dev *kms =3D dev_get_drvdata(mdev->dev); + struct drm_device *drm =3D &kms->base; struct d71_dev *d71; struct komeda_pipeline *pipe; struct block_header blk; @@ -366,7 +369,7 @@ static int d71_enum_resources(struct komeda_dev *mdev) =20 err =3D d71_reset(d71); if (err) { - DRM_ERROR("Fail to reset d71 device.\n"); + drm_err(drm, "Fail to reset d71 device.\n"); goto err_cleanup; } =20 @@ -376,8 +379,8 @@ static int d71_enum_resources(struct komeda_dev *mdev) d71->num_pipelines =3D (value >> 8) & 0x7; =20 if (d71->num_pipelines > D71_MAX_PIPELINE) { - DRM_ERROR("d71 supports %d pipelines, but got: %d.\n", - D71_MAX_PIPELINE, d71->num_pipelines); + drm_err(drm, "d71 supports %d pipelines, but got: %d.\n", + D71_MAX_PIPELINE, d71->num_pipelines); err =3D -EINVAL; goto err_cleanup; } @@ -455,8 +458,8 @@ static int d71_enum_resources(struct komeda_dev *mdev) offset +=3D D71_BLOCK_SIZE; } =20 - DRM_DEBUG("total %d (out of %d) blocks are found.\n", - i, d71->num_blocks); + drm_dbg(drm, "total %d (out of %d) blocks are found.\n", + i, d71->num_blocks); =20 return 0; =20 @@ -555,6 +558,8 @@ static void d71_init_fmt_tbl(struct komeda_dev *mdev) =20 static int d71_connect_iommu(struct komeda_dev *mdev) { + struct komeda_kms_dev *kms =3D dev_get_drvdata(mdev->dev); + struct drm_device *drm =3D &kms->base; struct d71_dev *d71 =3D mdev->chip_data; u32 __iomem *reg =3D d71->gcu_addr; u32 check_bits =3D (d71->num_pipelines =3D=3D 2) ? @@ -569,7 +574,7 @@ static int d71_connect_iommu(struct komeda_dev *mdev) ret =3D dp_wait_cond(has_bits(check_bits, malidp_read32(reg, BLK_STATUS)), 100, 1000, 1000); if (ret < 0) { - DRM_ERROR("timed out connecting to TCU!\n"); + drm_err(drm, "timed out connecting to TCU!\n"); malidp_write32_mask(reg, BLK_CONTROL, 0x7, INACTIVE_MODE); return ret; } @@ -582,6 +587,8 @@ static int d71_connect_iommu(struct komeda_dev *mdev) =20 static int d71_disconnect_iommu(struct komeda_dev *mdev) { + struct komeda_kms_dev *kms =3D dev_get_drvdata(mdev->dev); + struct drm_device *drm =3D &kms->base; struct d71_dev *d71 =3D mdev->chip_data; u32 __iomem *reg =3D d71->gcu_addr; u32 check_bits =3D (d71->num_pipelines =3D=3D 2) ? @@ -593,7 +600,7 @@ static int d71_disconnect_iommu(struct komeda_dev *mdev) ret =3D dp_wait_cond(((malidp_read32(reg, BLK_STATUS) & check_bits) =3D= =3D 0), 100, 1000, 1000); if (ret < 0) { - DRM_ERROR("timed out disconnecting from TCU!\n"); + drm_err(drm, "timed out disconnecting from TCU!\n"); malidp_write32_mask(reg, BLK_CONTROL, 0x7, INACTIVE_MODE); } =20 --=20 2.43.0