From nobody Mon Feb 9 23:42:48 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79ACE31A578 for ; Fri, 14 Nov 2025 13:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127503; cv=none; b=Tyy0HlyvSqZhAaTLRTjLwJlCCOHDv+xxQws9fR/pnqwWphmymIcwNYNy9Smr7mxYc4bb2GYg+nND0MIE7kNmhLISXFZQ+xnUrHm/bgqKKskXIDJH+OGUx+ljA14MXAK+KwuSGyBEVerjz29ikE7KQA4AWZjPs4UDUb3vE5QyYLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127503; c=relaxed/simple; bh=foEwrfkVJlHKAY4hAyD7v8BZiF7HCnetDgamuS4Q2n8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yq84qnwaRqVmCULU7mDBZQnp8nia+dlygtbrHtuvOwZcOMup65HnKqL2TMfyYimP8andIALJV05V42ACnEJsmuAO1jb9uwNarEJcC62N+33DbWUbtMr5FwxRjgmaUHYw6GggmHzZz76RNScBXLvILFeZuEe1C44vMc5xCifyQxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ITdHdQ2G; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ITdHdQ2G" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b735b89501fso176317266b.0 for ; Fri, 14 Nov 2025 05:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127499; x=1763732299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XSTuk6bpUxNwcbGpcQuPugEknybGUY3HH6kETf+pWJA=; b=ITdHdQ2GZ5tgsOjkoeF8QpU6bxBhrxbl6idiv7iI52gSY4nI1xuEGNx0VoDPokXENz 2XT3MKBi7EVL7HeSAhntz6S0LB/aja7zZzOZmJ1UwFgkjNT9iuqJH0t218l4/bKACJtE rLvaBCAnDxHwXTiPLvhBIKh8l7tcdiAdx6ca2Z69MvbOPQVDq5OtO77HgkEDF8r5t414 EehhSO4WCWbszr3WqFgCqraJqL35z1Ws9qVJ+5SpqM08mNljadpvpp/E1r57ysGcEBTk rspscty/Z1M3TRKZGf8KqxwnfpBxONf1F6r26zxe+y1xlfyscpFfVXt/SnWUq4Gg7LFi bZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127499; x=1763732299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XSTuk6bpUxNwcbGpcQuPugEknybGUY3HH6kETf+pWJA=; b=rY/BWecfRFsJO+dGQoEmaBR5nTXtZb4Mc5dufnVTCmXvOxUHCrqDxhoruoTHph7JUh XjeRDmxbe+Vj84eqd6MKD+hpzier2jG7T2jTyeOWbh3XpfnYEG27FIgXBr+I3nYdxe1v 4EB2ZRFVDHVlt/zNEE3Rj3uPH5cAKmAfWmNe1TpOA4Z2assoP82mD3/SCBgyghyzMWl9 qoviHpMNdCYiycMYcQsi5/nqX/eLWoVph+e4GSyS5r4EPcZooEy+AEMsuffp4temtG4U CzR1IxUIH668TFzTsNtlCgOIqg02eX95hnvszXZDeIdckvypkAnMWGfVbyVsevuXax7p 5JuA== X-Forwarded-Encrypted: i=1; AJvYcCXp5NB4ubveSiKD2HmnEy4GMHyHVkY0WPrjXxZRzdZ5H5DZmIl7GY0FXNN8lVp3KJ7y0Gus0G4mha8kd2g=@vger.kernel.org X-Gm-Message-State: AOJu0YwRd7RhROv9QCe42o+muGj5b3kNc+Jbm2TuuzoSN57/6AgX9v6J TT4lR7t8i0DKwRerREymGDZCFTYWYRStxyrk5hXxq96zGCEsdlePlHaf X-Gm-Gg: ASbGncsz+N1YyMubOPTqD39jeU6eER3JaIlFtQXhD1stnTTLixX6fUVuddDjSwKUUwO MYpgPwuEpdqaD4R5ZoB0u+qXpnda4KT3dU3puSxRcsEmnHZPkuH5gBRgHt20ZCfxnRhUagLRBj3 tD8Qq7O6O1uGBG5eZLy/ks4Ov000O5u7lFHeRA8wsLfry2048D+R9ymnjQjyfOM73TThojmABwd zxY+DKNBD7SJ60ISgAqhTkb96s72AlNsf1J3X7Ypisf2ieHfcdtLBqkmC+BoHEms0a2UAWvzUAc n0DioAklSSSzhnTaaKpP4SMwCVTGnXr+/MMEJ64gbke54txa1L981fBg6//3AC3c4WUonf3XtYg bvmB1w5/CjdQBgprN25Vr2ak3RMMl8+tfdaofyuEOyGZEKpZREYqQhFRhEDgZq1J5CuRSdMNEFw Lntjoy8puyGEdyMgJdwaNhb/5AlaA= X-Google-Smtp-Source: AGHT+IFvKA1+gNZSHXPhDg9R10UrD3Zf0H4eUhPkX/HS+B9nFWrGe5Hu0zKQ0XEyBpiDpJBP1vknUg== X-Received: by 2002:a17:906:fe05:b0:b72:de4f:cea6 with SMTP id a640c23a62f3a-b736793de61mr322529466b.48.1763127498389; Fri, 14 Nov 2025 05:38:18 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:18 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros Date: Fri, 14 Nov 2025 05:37:33 -0800 Message-ID: <20251114133738.1762-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea The macros defining the mask values for the EARC, EARC PHY resets, and the DSP RUN_STALL signal can be dropped as they are not and will not be used anywhere else except to set the value of the "mask" field from "struct imx8mp_reset_map". In this particular case, based on the name of the "mask" field, you can already deduce what these values are for, which is why defining macros for them doesn't offer any new information, nor does it help with the code readability. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel --- drivers/reset/reset-imx8mp-audiomix.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index eceb37ff5dc5..acfa92b15329 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -6,6 +6,7 @@ #include =20 #include +#include #include #include #include @@ -14,11 +15,7 @@ #include =20 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0) -#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1) - #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 -#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5) =20 struct imx8mp_reset_map { unsigned int offset; @@ -29,17 +26,17 @@ struct imx8mp_reset_map { static const struct imx8mp_reset_map reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_RESET_MASK, + .mask =3D BIT(0), .active_low =3D true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + .mask =3D BIT(1), .active_low =3D true, }, [IMX8MP_AUDIOMIX_DSP_RUNSTALL] =3D { .offset =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK, + .mask =3D BIT(5), .active_low =3D false, }, }; --=20 2.43.0