From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79ACE31A578 for ; Fri, 14 Nov 2025 13:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127503; cv=none; b=Tyy0HlyvSqZhAaTLRTjLwJlCCOHDv+xxQws9fR/pnqwWphmymIcwNYNy9Smr7mxYc4bb2GYg+nND0MIE7kNmhLISXFZQ+xnUrHm/bgqKKskXIDJH+OGUx+ljA14MXAK+KwuSGyBEVerjz29ikE7KQA4AWZjPs4UDUb3vE5QyYLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127503; c=relaxed/simple; bh=foEwrfkVJlHKAY4hAyD7v8BZiF7HCnetDgamuS4Q2n8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yq84qnwaRqVmCULU7mDBZQnp8nia+dlygtbrHtuvOwZcOMup65HnKqL2TMfyYimP8andIALJV05V42ACnEJsmuAO1jb9uwNarEJcC62N+33DbWUbtMr5FwxRjgmaUHYw6GggmHzZz76RNScBXLvILFeZuEe1C44vMc5xCifyQxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ITdHdQ2G; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ITdHdQ2G" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b735b89501fso176317266b.0 for ; Fri, 14 Nov 2025 05:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127499; x=1763732299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XSTuk6bpUxNwcbGpcQuPugEknybGUY3HH6kETf+pWJA=; b=ITdHdQ2GZ5tgsOjkoeF8QpU6bxBhrxbl6idiv7iI52gSY4nI1xuEGNx0VoDPokXENz 2XT3MKBi7EVL7HeSAhntz6S0LB/aja7zZzOZmJ1UwFgkjNT9iuqJH0t218l4/bKACJtE rLvaBCAnDxHwXTiPLvhBIKh8l7tcdiAdx6ca2Z69MvbOPQVDq5OtO77HgkEDF8r5t414 EehhSO4WCWbszr3WqFgCqraJqL35z1Ws9qVJ+5SpqM08mNljadpvpp/E1r57ysGcEBTk rspscty/Z1M3TRKZGf8KqxwnfpBxONf1F6r26zxe+y1xlfyscpFfVXt/SnWUq4Gg7LFi bZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127499; x=1763732299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XSTuk6bpUxNwcbGpcQuPugEknybGUY3HH6kETf+pWJA=; b=rY/BWecfRFsJO+dGQoEmaBR5nTXtZb4Mc5dufnVTCmXvOxUHCrqDxhoruoTHph7JUh XjeRDmxbe+Vj84eqd6MKD+hpzier2jG7T2jTyeOWbh3XpfnYEG27FIgXBr+I3nYdxe1v 4EB2ZRFVDHVlt/zNEE3Rj3uPH5cAKmAfWmNe1TpOA4Z2assoP82mD3/SCBgyghyzMWl9 qoviHpMNdCYiycMYcQsi5/nqX/eLWoVph+e4GSyS5r4EPcZooEy+AEMsuffp4temtG4U CzR1IxUIH668TFzTsNtlCgOIqg02eX95hnvszXZDeIdckvypkAnMWGfVbyVsevuXax7p 5JuA== X-Forwarded-Encrypted: i=1; AJvYcCXp5NB4ubveSiKD2HmnEy4GMHyHVkY0WPrjXxZRzdZ5H5DZmIl7GY0FXNN8lVp3KJ7y0Gus0G4mha8kd2g=@vger.kernel.org X-Gm-Message-State: AOJu0YwRd7RhROv9QCe42o+muGj5b3kNc+Jbm2TuuzoSN57/6AgX9v6J TT4lR7t8i0DKwRerREymGDZCFTYWYRStxyrk5hXxq96zGCEsdlePlHaf X-Gm-Gg: ASbGncsz+N1YyMubOPTqD39jeU6eER3JaIlFtQXhD1stnTTLixX6fUVuddDjSwKUUwO MYpgPwuEpdqaD4R5ZoB0u+qXpnda4KT3dU3puSxRcsEmnHZPkuH5gBRgHt20ZCfxnRhUagLRBj3 tD8Qq7O6O1uGBG5eZLy/ks4Ov000O5u7lFHeRA8wsLfry2048D+R9ymnjQjyfOM73TThojmABwd zxY+DKNBD7SJ60ISgAqhTkb96s72AlNsf1J3X7Ypisf2ieHfcdtLBqkmC+BoHEms0a2UAWvzUAc n0DioAklSSSzhnTaaKpP4SMwCVTGnXr+/MMEJ64gbke54txa1L981fBg6//3AC3c4WUonf3XtYg bvmB1w5/CjdQBgprN25Vr2ak3RMMl8+tfdaofyuEOyGZEKpZREYqQhFRhEDgZq1J5CuRSdMNEFw Lntjoy8puyGEdyMgJdwaNhb/5AlaA= X-Google-Smtp-Source: AGHT+IFvKA1+gNZSHXPhDg9R10UrD3Zf0H4eUhPkX/HS+B9nFWrGe5Hu0zKQ0XEyBpiDpJBP1vknUg== X-Received: by 2002:a17:906:fe05:b0:b72:de4f:cea6 with SMTP id a640c23a62f3a-b736793de61mr322529466b.48.1763127498389; Fri, 14 Nov 2025 05:38:18 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:18 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros Date: Fri, 14 Nov 2025 05:37:33 -0800 Message-ID: <20251114133738.1762-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea The macros defining the mask values for the EARC, EARC PHY resets, and the DSP RUN_STALL signal can be dropped as they are not and will not be used anywhere else except to set the value of the "mask" field from "struct imx8mp_reset_map". In this particular case, based on the name of the "mask" field, you can already deduce what these values are for, which is why defining macros for them doesn't offer any new information, nor does it help with the code readability. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel --- drivers/reset/reset-imx8mp-audiomix.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index eceb37ff5dc5..acfa92b15329 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -6,6 +6,7 @@ #include =20 #include +#include #include #include #include @@ -14,11 +15,7 @@ #include =20 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0) -#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1) - #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 -#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5) =20 struct imx8mp_reset_map { unsigned int offset; @@ -29,17 +26,17 @@ struct imx8mp_reset_map { static const struct imx8mp_reset_map reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_RESET_MASK, + .mask =3D BIT(0), .active_low =3D true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + .mask =3D BIT(1), .active_low =3D true, }, [IMX8MP_AUDIOMIX_DSP_RUNSTALL] =3D { .offset =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, - .mask =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK, + .mask =3D BIT(5), .active_low =3D false, }, }; --=20 2.43.0 From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF23831AF2D for ; Fri, 14 Nov 2025 13:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127505; cv=none; b=j5gGUMkMHq0Ik+rBf+2DU2kf1zO7GaHmBUk7XknhNknNclFlpUzQmrFdfK9hAtUVcg9hZ/w+6OjR8dbK42Q88bnppso33kLLRVcmNqHeTnc+HxsykPkVo0jAHsKF/mH1ZH26XDLxpIvvU9UVxNC1JP1P9jg2UgBFfZa6Fyax3e4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127505; c=relaxed/simple; bh=26I9GTLb874hLw2vCdWMdaChtt9DDDr/+PTVQhi4eJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dRKkDU8DydoQ2BQzAfkr14CU4g2hyW7bkZSIMFgBrD3Y51wdr4eVqaVrb+gixDVwlUI1G1lvFeZNcKnpLXf9RSwogi4rsbP7pziF+n4NTDpM+zbPm/kVqYrNKCPEppAxFRgma1mXHz/ujGDu9xyv2giYIjrB+CEhhdv0qtP5sIo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W/clKp4F; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W/clKp4F" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b70bee93dc4so274009366b.3 for ; Fri, 14 Nov 2025 05:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127502; x=1763732302; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VWdQjfJEv17Sa7ZPlM69WVgkJ4xrrn+SVmA6eSQkM3w=; b=W/clKp4FREdTVv1gbKsglCI8QRCk/ud4o4OmFJZdgTz9XBEsHJgk4tkSfwn8BBwtRa RZkQzc2331XaKe5S9dI/fp2BWTP/D9WTmlc3YGsRRwn3vt7HhDcD2dfRSCdwvMfgGMu+ 3cJqCWtvTpP1ZMWwkJ23WUQokCvBpNCcFw2Wwdzp4U//V5tJ1UHLiU1E3KaGeBneMMNX Dk2TlVKgQnYRtR2Bl7hjn7xy0mGIBkhZ8KAcAfQFSDlA0Yqan1dCptNlPhoudKseCu2S 6NnO43H4y0rXXEFw2nElv0OnPpBqEyghfX7HXjr1rZ6khWqzejDTlHO3FpHRuMfPiPHt LNJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127502; x=1763732302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VWdQjfJEv17Sa7ZPlM69WVgkJ4xrrn+SVmA6eSQkM3w=; b=DwFH6tWQ0qD0qKj/eghuZ2OKv4W9ger7F9qPU3gyXWML2rfT919TwYrZUdJt8EIJga YjOBviVehR31Gd43JjdQPOMprfqyiVx1VZ34g6dFSHEylOfKoVnTzJjsxaHC1NB5phN6 JiA5NOv5iQrttZ25kn+aniToXLOy9ChHpE2mVMhiv3pmSDEsdtAmYR537bgHrvIn1q2p gk/0EnjOkF8eZk6mLkvG5YWtl2gokz4L8BmnruIPPBipOCLaPd7U1cjeOzY3RIi5du2V ZosbsjxUcen6xDKutRvzrrKPpvbeLNj/FMhUYWZrxvW2H9HUYLexSn7Sn9zpeII7I8T6 qIfw== X-Forwarded-Encrypted: i=1; AJvYcCVySFH5+iEqkUgAW2p6VroNNpTzPfVZzaV1hNUZcX3Hw1wSlEHCjkt9JjG/ZS6scErCXW/cKt9T0mgBhIw=@vger.kernel.org X-Gm-Message-State: AOJu0YwWGUgS47X6k+MaQ9BJsLpWqEUlwk69J26+DW0wG4x6JXk6posW Ian4LEua2ChmInVTbxZgC0TP44ZkngaFOdeTzvQxAGJvr/yO+p8rGVQt X-Gm-Gg: ASbGncvN2MMhDogD6j/O9Fedr+di2gd1lE+REp057KdHrxJDfLk8dkWXXRIjA2rx2yE pLhGR27rTztNuPiGOQFZBsAuaNFZhiANlAd9dWInxQ3FAggAO77olrh8UbTijo9zSptou+TVQ+j s+3/OV+83I2fuYhwXztOFB372NSykt2YmZUw5qKPIIN9Urlnt8nJmgPAKqcHbwLfTeqsrczqL9z 2bk1mlkXokfjZXml4j5Iz/nQW7RiYUQ608bROGxo/h71w1t8JYPXQ8uWQ9zNHiIMFTqwojzjWlP Y00jW56qxDsGttwKp2+ntk7AZghuarnYDJi3sc4ey1dkma8Gu/Jve50fvPFtAvRvqjba+tIENfK EtoDC6zw9ikDadtzfcbJkOnBVaNXBUgTsym9+VVqfQlC6UEd3EG8F1g0dYOM4xPK+y7GS3NyM+6 caHeabJRJBtCxg/y2AJL2f/rP0IKZPl7IRC5LmxA== X-Google-Smtp-Source: AGHT+IHL8SCZliSxbU3IoQx/aVhNRnS5pIg2oX9HCryB27tJyt6t44B6IxSN0UhqL2jYg3FBXXfTZg== X-Received: by 2002:a17:907:1c81:b0:b73:42e5:a59e with SMTP id a640c23a62f3a-b73677edb7bmr274842566b.12.1763127502138; Fri, 14 Nov 2025 05:38:22 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:21 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index Date: Fri, 14 Nov 2025 05:37:34 -0800 Message-ID: <20251114133738.1762-3-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea Replace the reset map mask with the bit index to make it clear that all reset lines are managed by exactly 1 bit. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel --- drivers/reset/reset-imx8mp-audiomix.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index acfa92b15329..d993c294c548 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -19,24 +19,24 @@ =20 struct imx8mp_reset_map { unsigned int offset; - unsigned int mask; + unsigned int bit; bool active_low; }; =20 static const struct imx8mp_reset_map reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D BIT(0), + .bit =3D 0, .active_low =3D true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, - .mask =3D BIT(1), + .bit =3D 1, .active_low =3D true, }, [IMX8MP_AUDIOMIX_DSP_RUNSTALL] =3D { .offset =3D IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, - .mask =3D BIT(5), + .bit =3D 5, .active_low =3D false, }, }; @@ -60,7 +60,7 @@ static int imx8mp_audiomix_update(struct reset_controller= _dev *rcdev, unsigned int mask, offset, active_low; unsigned long reg, flags; =20 - mask =3D reset_map[id].mask; + mask =3D BIT(reset_map[id].bit); offset =3D reset_map[id].offset; active_low =3D reset_map[id].active_low; =20 --=20 2.43.0 From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5480B31BC80 for ; Fri, 14 Nov 2025 13:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127508; cv=none; b=Cs2Ylv9mJgobWqzsNT+6I+gXCeC6WUoA4RXvZ0FFByrs0/faBlrkk1EeiYug+9PBsLAHs5jcD24YahqW3musL0WZWcvh4KmTobf03epMtH4mYRiONavSk/WOw5f6A8KvIyFrUmLR5Z7raTkG/WKKuWYqlIRR3ppgPaY3pQUZ96Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127508; c=relaxed/simple; bh=aIZmZ8Bit7ZQP6+E51qlwqHqkVtTGhNdOByH2z3GuCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LXgX4FyKgrq5zeQHKcF2iJW/0w/oypf5stxU0gMoTCGfodh9cbJWuYpenc4mIhzoCURM4HS9vp04GXr7dWiU+Yj2H0RNnsliz9aJeUZ++WyIa4U+bvd6RjRkm5T6pHnYO8OcDmQt8Vch1Fy9PSsOcns0NNGJXxrpo6sEl0o7+Sk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DfzWJnVW; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfzWJnVW" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b714b1290aeso298015266b.2 for ; Fri, 14 Nov 2025 05:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127505; x=1763732305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tunUdZ+Uo3TFHtZ2y2DxEuFXtR8sw55m1IPZhLEhl+o=; b=DfzWJnVWp+QSyd5DlUN9yKhtS7bLzHf4N6OWVhipIl9EiyG1nXg/toeoF2Y3zRuSp7 /6Ad1hko6WvB5mQBpPEnI+gAdD4N/uka94afadyjkFN0e6jYrRfUUWgl5kxduNrdmFxU ag65EWMI1PZFshvDYzXkXs2i04E1cKiATpCs9zo7Zxz16f239BOZidoP71OVixfUYj+P Wi1fV4vGAs2eR1apeYyZqhwADaxSFNinbKn1dvTxkIopg0adpX++eftEv00IVkt+dNiN s8WYOFKe7QkIZd4q6137VLxsuUttzyhB3ZxJmjOIvYMSOBzDqGtekTdRwxme1O1s7fU/ qczw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127505; x=1763732305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tunUdZ+Uo3TFHtZ2y2DxEuFXtR8sw55m1IPZhLEhl+o=; b=RDFlFvwRhjvvekOIfJMQP0Lo5bA+TWWxTFE9+IpDJwkIWnl4e97O4fKwPjVbmnj78o vm8O/q8OnrEUwDoMIhibCjdPZqGccfzwNk4kZFToVF9Rphrz6s/0Foh+xqpo0fqC0lyg Bd3GvR9v4geyfJvO5IeMbA2wj3k3IKNuhMgROjt/lJyEm778jfcw7BCSsGUYN8ymjGRR 2snWDrdqU1XFqLKmSYYi8LkpyLZ48FHyn6LUfQzS0EXiU0ncD6Bp3LHPw1jQD4OtxPrD AAIR13qNUGNLjLCwyRFayCgjOAGj3GN1/flmz2ZM2Z21hq2pVsP288coF7eomyPUV5kZ QQCQ== X-Forwarded-Encrypted: i=1; AJvYcCUYsrTbbi7EC8RVPGdtJERKGisTYtYNUK7/EBIsTeOmyPjcJVF4HU3KGa1nLpAg7hxAD9A8IoahRh5wktk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz23HXhdRrZq9ynf4J9NBh+D5mOOB6Q4Z5C3D37Ze0ATFZ7MuTc jcYUsLYmZAHygkVzgJvP584xlAO/1WRyJqJpEx0INthxPxvTuVb6e6e/ X-Gm-Gg: ASbGncu3JzCE7Ua99ZoVylTfvOSh0PLmbdXYgpis8nzJMeTmS3KBPYaE/ujdf2d/JgZ 7ptyY+Bs9b7j0AyubbczN32enq+Zp4uo2lI0kOlS60Jg6B8/hI8tNQuB9Kvp29Ob7sNHyr+EgNc bwEJ42PKBnpzCmSNaA6sch7a5p9Yv0AWyKAQNOOiOjSsnrqAzNjQguRVFA3j3916BAt5AgeQ5h+ g0rfn1dnQCIIR9Z4S8G1gzGEMgoEsiPjIr6Z4z5oUx2uVKexeSmfyZFlSkj95dlEsQFvCEaRSF3 xWXnBrzojgdSPcs5R1vmrqROv5X/r/8m6veiLGvdR/qJfSCkgAIdIR/+cqj08N9MECmyos0GCUz qHIflIwPjYeGCuoW/eHS6a0JHUXW/jelgT9o62/yhEzTLYLExe0wWTi2WQ6WuWwGOoPyTgH4mw+ nflKlV6hGNyqBw97TitnkzWhprOds= X-Google-Smtp-Source: AGHT+IFL+db8xrLuL7QGFf6oOiM4PGKjgJRPl7rpZxY6Gpc3+rpth3N0E++6rvqNnt7UZ+YGTI57Qg== X-Received: by 2002:a17:906:7307:b0:b73:5146:8b7b with SMTP id a640c23a62f3a-b73678e9981mr238611666b.36.1763127504345; Fri, 14 Nov 2025 05:38:24 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:24 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 3/6] reset: imx8mp-audiomix: Switch to using regmap API Date: Fri, 14 Nov 2025 05:37:35 -0800 Message-ID: <20251114133738.1762-4-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea Switch to using the regmap API to allow performing register operations under the same lock. This is needed for cases such as i.MX8ULP's SIM LPAV where clock gating, reset control and MUX-ing is performed via the same register (i.e. SYSCTRL0) and different subsystem APIs. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Frank Li Reviewed-by: Philipp Zabel --- drivers/reset/reset-imx8mp-audiomix.c | 92 +++++++++++++++++---------- 1 file changed, 57 insertions(+), 35 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index d993c294c548..35df9bd5f71a 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -12,6 +12,7 @@ #include #include #include +#include #include =20 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 @@ -43,8 +44,7 @@ static const struct imx8mp_reset_map reset_map[] =3D { =20 struct imx8mp_audiomix_reset { struct reset_controller_dev rcdev; - spinlock_t lock; /* protect register read-modify-write cycle */ - void __iomem *base; + struct regmap *regmap; }; =20 static struct imx8mp_audiomix_reset *to_imx8mp_audiomix_reset(struct reset= _controller_dev *rcdev) @@ -56,26 +56,14 @@ static int imx8mp_audiomix_update(struct reset_controll= er_dev *rcdev, unsigned long id, bool assert) { struct imx8mp_audiomix_reset *priv =3D to_imx8mp_audiomix_reset(rcdev); - void __iomem *reg_addr =3D priv->base; - unsigned int mask, offset, active_low; - unsigned long reg, flags; + unsigned int mask, offset, active_low, val; =20 mask =3D BIT(reset_map[id].bit); offset =3D reset_map[id].offset; active_low =3D reset_map[id].active_low; + val =3D (active_low ^ assert) << reset_map[id].bit; =20 - spin_lock_irqsave(&priv->lock, flags); - - reg =3D readl(reg_addr + offset); - if (active_low ^ assert) - reg |=3D mask; - else - reg &=3D ~mask; - writel(reg, reg_addr + offset); - - spin_unlock_irqrestore(&priv->lock, flags); - - return 0; + return regmap_update_bits(priv->regmap, offset, mask, val); } =20 static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev, @@ -95,6 +83,52 @@ static const struct reset_control_ops imx8mp_audiomix_re= set_ops =3D { .deassert =3D imx8mp_audiomix_reset_deassert, }; =20 +static const struct regmap_config regmap_config =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, +}; + +/* assumption: registered only if not using parent regmap */ +static void imx8mp_audiomix_reset_iounmap(void *data) +{ + void __iomem *base =3D (void __iomem *)data; + + iounmap(base); +} + +static int imx8mp_audiomix_reset_get_regmap(struct imx8mp_audiomix_reset *= priv) +{ + void __iomem *base; + struct device *dev; + int ret; + + dev =3D priv->rcdev.dev; + + /* try to use the parent's regmap */ + priv->regmap =3D dev_get_regmap(dev->parent, NULL); + if (priv->regmap) + return 0; + + /* ... if that's not possible then initialize the regmap right now */ + base =3D of_iomap(dev->parent->of_node, 0); + if (!base) + return dev_err_probe(dev, -ENOMEM, "failed to iomap address space\n"); + + ret =3D devm_add_action_or_reset(dev, + imx8mp_audiomix_reset_iounmap, + (void __force *)base); + if (ret) + return dev_err_probe(dev, ret, "failed to register action\n"); + + priv->regmap =3D devm_regmap_init_mmio(dev, base, ®map_config); + if (IS_ERR(priv->regmap)) + return dev_err_probe(dev, PTR_ERR(priv->regmap), + "failed to initialize regmap\n"); + + return 0; +} + static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { @@ -106,36 +140,25 @@ static int imx8mp_audiomix_reset_probe(struct auxilia= ry_device *adev, if (!priv) return -ENOMEM; =20 - spin_lock_init(&priv->lock); - priv->rcdev.owner =3D THIS_MODULE; priv->rcdev.nr_resets =3D ARRAY_SIZE(reset_map); priv->rcdev.ops =3D &imx8mp_audiomix_reset_ops; priv->rcdev.of_node =3D dev->parent->of_node; priv->rcdev.dev =3D dev; priv->rcdev.of_reset_n_cells =3D 1; - priv->base =3D of_iomap(dev->parent->of_node, 0); - if (!priv->base) - return -ENOMEM; =20 dev_set_drvdata(dev, priv); =20 + ret =3D imx8mp_audiomix_reset_get_regmap(priv); + if (ret) + return dev_err_probe(dev, ret, "failed to get regmap\n"); + ret =3D devm_reset_controller_register(dev, &priv->rcdev); if (ret) - goto out_unmap; + return dev_err_probe(dev, ret, + "failed to register reset controller\n"); =20 return 0; - -out_unmap: - iounmap(priv->base); - return ret; -} - -static void imx8mp_audiomix_reset_remove(struct auxiliary_device *adev) -{ - struct imx8mp_audiomix_reset *priv =3D dev_get_drvdata(&adev->dev); - - iounmap(priv->base); } =20 static const struct auxiliary_device_id imx8mp_audiomix_reset_ids[] =3D { @@ -148,7 +171,6 @@ MODULE_DEVICE_TABLE(auxiliary, imx8mp_audiomix_reset_id= s); =20 static struct auxiliary_driver imx8mp_audiomix_reset_driver =3D { .probe =3D imx8mp_audiomix_reset_probe, - .remove =3D imx8mp_audiomix_reset_remove, .id_table =3D imx8mp_audiomix_reset_ids, }; =20 --=20 2.43.0 From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F8B31CA7D for ; Fri, 14 Nov 2025 13:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127512; cv=none; b=EfW0m0hJpRmstZgF4jwEwj5fX61aOZ6KW9niRJjp/4SipwjXXWHYS5G/5RSHoOSqc3+wS+DJzqDRR+krWw1kVUTFZ+r0a+OWi+4U0GXCTE5cgm+h3jmcUfeKRWrXMypYCYIgdmIkvJVzauEMeEpZupJ/Bhbo+SLtx1RT8m4Itr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127512; c=relaxed/simple; bh=A0S5kP4AYnuMNEvsPn5dOXTGuDZ7ZyT/JuCLEXl0ePs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jA4wNDq8eH3F0NeNagYBssFJnQY8fKq0vZCMsw+ifBNwHd1zA1Nz7qVWrYWgjmjFmYYfVMglsa3hZ+tMnFfNUaF4acLMEfxzt2Dnl3mkQ1dBQmWp1bM4dWWhYFhdcfac4MduVAhS5RZ55gGJwDw1ZNTLuZNCVoSBNjMK/B4s7dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XTa5YeJF; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTa5YeJF" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6419aaced59so3049414a12.0 for ; Fri, 14 Nov 2025 05:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127506; x=1763732306; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hdYV/UUUzK+g0y1e4n+KXhL1vj4mnn1p47TPyDwiegM=; b=XTa5YeJFXX1aHj+6xvJ7naUlTk1aSfOBHL+uKYxF3EhvpfwqIe4RodQTv6OrG3niGu gkWtrm11DQPranJrovC05DKWZVh0dSmOa2yJ0cntAXEwqpVF3LvVMmjAs7OVBQpryWLb 1zVU9XzBdgUd4qu6L5kuCF8VovX4PVm0evmky26FiengXAh9xqzfpElXybEFlPm6klq/ AhYchfFil1JfJz4Va4Y1hR9o6aMyK/XMCHez0bsnyKChxrwCl9fPLGkE+PxMMl2jCg/4 QLOQLZIRoAplx7Kr/7stMRYFaHrDENT/lBcgum5eB4xD0VMB800GRO8oYFxorzOwNLs+ dbdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127506; x=1763732306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hdYV/UUUzK+g0y1e4n+KXhL1vj4mnn1p47TPyDwiegM=; b=UMBe8eujqiVdmkScgwi1796vjFvuH2z+PqUOZvFKN0WmIod9uZpprvxglF1j1/xkq1 lKGBdd6B5x8potV5qrnJuV3gHeRJ9/63zUUpM+imRyGAJ4v6e+Q0kmd6EIB8fdrs1oBN Riu2F0ezNSjCTVqthGGXtAmuJQ/91ZVAMIDfhEZlVcYhohSsE35SeW43j32B58e0SPzw kH+aekmLJhae3BjwpJntjgdTig5Wei5a0nRXMPh15nRWSEnY256CXFE8T3qb7noNtB3B bDmvz88wb0A/qqIq36HHwGL4vQRtP4Vrkg0ycfJ6q+eVFEx1eINyZywkmTntdCkVsuRr ON9g== X-Forwarded-Encrypted: i=1; AJvYcCUa28nwhSkITPxQKcYN2IPlQwNyuUcoBcu5jKAFh/F/n7HK0Pl2TUBkiLrJIcfu+PyNOyLJgPRgNUkwGNI=@vger.kernel.org X-Gm-Message-State: AOJu0YyAbC99x04f27gvsAH0rtPgviPstRPPwTE+c1j3C3XC+EaO6XrA TucHWe/yiegt6KquLPQrrU5yVAnwGwh1qrZzi3aakPjGIqrT1mXWlc/L X-Gm-Gg: ASbGncs4AZgUAZrTL4fQspJQzsnaYwqeN4bzAk1bGdyPSdfSFq47Eu+XwwdINJmHgHS tBngU64Cd91OEQU/jkeR5OvYStgJoe0Fqn1qP9WbkTQR1ODhVvplPsTxkBGB0jvGs6FA16yrPIx vLiF089o9IApRSnpZQem7mN2ohtGfA4+VtLq1zOAT3Elj5X6k73DPDxr/L7asvGUl4eCc50K719 16uXQNymUgj8lLpgvhw0RcqL1rq6y06YeCL2DD8fh/v9PbEElKgPNzoiaoVP5LI1gJyiM3VVkn6 4j4smO2Z6zU5XZboE3UvpZY1pgFVoN85/FYa25VvO1/skk/j1BBJnTJG9ePrnLGIUf1f9RO94no 70jggvJ3tPxL+JHFwdSyfeeMgNRBBhLP+D6WHCDM7Av0weL32wpv0OUXYOvGji/xhxvanWbuIy+ ntKIuQ855GABokXzdTOXoLB8Jrpy7/Q5q/ymMuOg== X-Google-Smtp-Source: AGHT+IG+QplD5QTjYb8S9SqW056mSz7f0h/qlDXbebG1yGANMyx/wdTBv6PJc0hq4+iNYLCBHhHJcA== X-Received: by 2002:a17:907:86a2:b0:b73:56a7:a36e with SMTP id a640c23a62f3a-b7367949692mr311064866b.50.1763127506289; Fri, 14 Nov 2025 05:38:26 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:25 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 4/6] reset: imx8mp-audiomix: Extend the driver usage Date: Fri, 14 Nov 2025 05:37:36 -0800 Message-ID: <20251114133738.1762-5-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea Switch to per-device reset map to allow reusing the driver for other NXP block control IPs. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Signed-off-by: Laurentiu Mihalcea --- drivers/reset/reset-imx8mp-audiomix.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index 35df9bd5f71a..d3396f37d1ff 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -24,7 +24,12 @@ struct imx8mp_reset_map { bool active_low; }; =20 -static const struct imx8mp_reset_map reset_map[] =3D { +struct imx8mp_reset_info { + const struct imx8mp_reset_map *map; + int num_lines; +}; + +static const struct imx8mp_reset_map imx8mp_reset_map[] =3D { [IMX8MP_AUDIOMIX_EARC_RESET] =3D { .offset =3D IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, .bit =3D 0, @@ -42,9 +47,15 @@ static const struct imx8mp_reset_map reset_map[] =3D { }, }; =20 +static const struct imx8mp_reset_info imx8mp_reset_info =3D { + .map =3D imx8mp_reset_map, + .num_lines =3D ARRAY_SIZE(imx8mp_reset_map), +}; + struct imx8mp_audiomix_reset { struct reset_controller_dev rcdev; struct regmap *regmap; + const struct imx8mp_reset_info *rinfo; }; =20 static struct imx8mp_audiomix_reset *to_imx8mp_audiomix_reset(struct reset= _controller_dev *rcdev) @@ -56,6 +67,7 @@ static int imx8mp_audiomix_update(struct reset_controller= _dev *rcdev, unsigned long id, bool assert) { struct imx8mp_audiomix_reset *priv =3D to_imx8mp_audiomix_reset(rcdev); + const struct imx8mp_reset_map *reset_map =3D priv->rinfo->map; unsigned int mask, offset, active_low, val; =20 mask =3D BIT(reset_map[id].bit); @@ -141,7 +153,8 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary= _device *adev, return -ENOMEM; =20 priv->rcdev.owner =3D THIS_MODULE; - priv->rcdev.nr_resets =3D ARRAY_SIZE(reset_map); + priv->rinfo =3D (void *)id->driver_data; + priv->rcdev.nr_resets =3D priv->rinfo->num_lines; priv->rcdev.ops =3D &imx8mp_audiomix_reset_ops; priv->rcdev.of_node =3D dev->parent->of_node; priv->rcdev.dev =3D dev; @@ -164,6 +177,7 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary= _device *adev, static const struct auxiliary_device_id imx8mp_audiomix_reset_ids[] =3D { { .name =3D "clk_imx8mp_audiomix.reset", + .driver_data =3D (kernel_ulong_t)&imx8mp_reset_info, }, { } }; --=20 2.43.0 From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E11D31DDA4 for ; Fri, 14 Nov 2025 13:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127511; cv=none; b=eZnihTuPPPGgPiyRleh4KLk8KyMkvW+pP+a1ZrcDyaRD7dkL7pcV8bU4iG2waKPFJgthMwj0STWVBZEZ/Sstx/Qhden973LcXb17u0pw2De2J9z4MOAonfibUS83YPuyD8WPaV0MHDagvnwXxmW0/qaUzRPjvoqJs6CsTZKejsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127511; c=relaxed/simple; bh=WDONt8lsWsVHQ3PYPlqLEoaUzwOTi24id4NOGYRQRbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WCmACB/ZSuKRIwG+B0tHFJJHRS6QYiScWOMfI/ahMlW9Jnu5Z//i/m//OcHP5rRGxKWAVkvThhrdB4lDumehUY9aUt96oWLcJjBb6rYGFRuF0TIATe3o4gryEwUp9YyIDWYtEvIZ+dsQxJyI396Gh8Bhi1hCX/Bn2ir6yOnBvzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mNe/xE4V; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mNe/xE4V" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-64162c04f90so3355059a12.0 for ; Fri, 14 Nov 2025 05:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127508; x=1763732308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wjEK4P3dbzSXwnv9p+7adMjs6IATWQpdCincKxuWQP4=; b=mNe/xE4VwfKd9F435UInjkt3wDuiWnzIjR6OeANY8tiic1uzlkxHqQkWvBPvyjVBo1 ri9g0LSgiFn3l2JRmL07wu3fiAcAin0kPYMd4UIliuVgIb04Bz/dGVTvSqruSIP7U4zj fpj+NjnMatzO8fPrJyV0kqZFg++la2E0lrICXyH/einacQ9vJVUnijHdKp495vFzXTkX /iC5gvov18JPDWXbytf+AM3pOPaS4U9Sh74DYpa9A+nu+cV/jXz62UI4+oaYcnqyc0U3 llPNyK1PAg03l5RJ6jTlYYepBtVhVOsbijMU0sduyDVLiayimNDK9Nd5nowXXra05+G2 VpqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127508; x=1763732308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wjEK4P3dbzSXwnv9p+7adMjs6IATWQpdCincKxuWQP4=; b=Sav3UIBpcX4yAKbVEzWiIBxwQI3mP9imQ7KC1HZPD7wmgC0cky1BjJ/OVHDWoemZ8B nceeNV9KzMryyO2VnHdu+jPP6WbJ6At6RKFEKlo1ZXLPVH4OvBY+PRPywWj61zKQU4S0 AkXUCTCu/ykNLlPSAgjSnqfyNBm8+EildWIfRRlY34SdE6JjQspvpOkNXnqX+UtalHhO DPHmKn8X5Z9HnxGCXhhrz4CsUQZZ0+d77yfPVG2ZPa72LM1OOB5fvoREfYIaT3dLpHOc Qv4dK5gsXiqtr21L3sQ9bI8LSDQ5HcVEiOX5LksV2SEm545NmGniV25oL2ruOgltvI1F bkOg== X-Forwarded-Encrypted: i=1; AJvYcCUtOrPInqWVbN20R3SaEnqwvVb2lvgh0235q39/U3/GxjzY0bnDJset88BX+CQom4iv7eqDDEBg3cjcHDw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf1cQGfoV1R767kmBh8Szzjm6TdU9JHUZaBVm4QBbQRlvPblif Uzqcm5jSgWhCu/92kzmfRZILWz/U6efekybxY0+t6Wgdczs1bSqB7jDV X-Gm-Gg: ASbGncvbvfNj68w5PYUcW77FAcgjA/Og/Nrw/ow5V2GEuyQ0JOkqvoFidHKdr05pViL AjQ0vP2TfLkYitrFAx1Fit9ggjQo0neCjQMw+4yHiLluP5ZerPXALJ6UDKHwdSvzaOntG64vKpE ls93OPlo0Wmt7rLeA7WxuSFoyRZwc9CIxgdKoKCcWkUsUFU8Zmp+VydbzO6OQprQZ36cj3UujB/ ropyi4ownvehiqpzB//sQfzRNSDsNX6fzYYLrOmeEe0PRfaaRLGXtwW0ag2zVXjuKaKqNMtZOUm 4RdwSR8k7sEMkx70ha2YXf+vyiBDAobhpIJXNS0HHdsGoeVD5V6tUtJmLZBx2IDSJcssXfk1aYR vMb0VSKg71IOiZRExoZovIof0BEBZSAvZntaRy5mbQUF3tRsQohqPpC5d63rLLHmoE3ZRdK0FW4 l2SMoZsBVs7UhsNRRAys4CJz1i+G/p2tFWwwKXiQ== X-Google-Smtp-Source: AGHT+IG/Eta9H7LYA39y2DTXjRpl0eAQHOhH3wq89aCFtUYEwpNsngjLk7o4A0zETlY/YY2uNySFTg== X-Received: by 2002:a17:907:a0b:b0:b72:5e2c:9e97 with SMTP id a640c23a62f3a-b7367b8b6bfmr226704866b.36.1763127507961; Fri, 14 Nov 2025 05:38:27 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:27 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 5/6] reset: imx8mp-audiomix: Support i.MX8ULP SIM LPAV Date: Fri, 14 Nov 2025 05:37:37 -0800 Message-ID: <20251114133738.1762-6-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea Support i.MX8ULP's SIM LPAV by adding its reset map definition. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel --- drivers/reset/reset-imx8mp-audiomix.c | 45 +++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-im= x8mp-audiomix.c index d3396f37d1ff..83fc8bcf80ab 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -3,6 +3,7 @@ * Copyright 2024 NXP */ =20 +#include #include =20 #include @@ -18,6 +19,8 @@ #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 =20 +#define IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET 0x8 + struct imx8mp_reset_map { unsigned int offset; unsigned int bit; @@ -52,6 +55,44 @@ static const struct imx8mp_reset_info imx8mp_reset_info = =3D { .num_lines =3D ARRAY_SIZE(imx8mp_reset_map), }; =20 +static const struct imx8mp_reset_map imx8ulp_reset_map[] =3D { + [IMX8ULP_SIM_LPAV_HIFI4_DSP_DBG_RST] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 25, + .active_low =3D false, + }, + [IMX8ULP_SIM_LPAV_HIFI4_DSP_RST] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 16, + .active_low =3D false, + }, + [IMX8ULP_SIM_LPAV_HIFI4_DSP_STALL] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 13, + .active_low =3D false, + }, + [IMX8ULP_SIM_LPAV_DSI_RST_BYTE_N] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 5, + .active_low =3D true, + }, + [IMX8ULP_SIM_LPAV_DSI_RST_ESC_N] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 4, + .active_low =3D true, + }, + [IMX8ULP_SIM_LPAV_DSI_RST_DPI_N] =3D { + .offset =3D IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET, + .bit =3D 3, + .active_low =3D true, + }, +}; + +static const struct imx8mp_reset_info imx8ulp_reset_info =3D { + .map =3D imx8ulp_reset_map, + .num_lines =3D ARRAY_SIZE(imx8ulp_reset_map), +}; + struct imx8mp_audiomix_reset { struct reset_controller_dev rcdev; struct regmap *regmap; @@ -179,6 +220,10 @@ static const struct auxiliary_device_id imx8mp_audiomi= x_reset_ids[] =3D { .name =3D "clk_imx8mp_audiomix.reset", .driver_data =3D (kernel_ulong_t)&imx8mp_reset_info, }, + { + .name =3D "clk_imx8ulp_sim_lpav.reset", + .driver_data =3D (kernel_ulong_t)&imx8ulp_reset_info, + }, { } }; MODULE_DEVICE_TABLE(auxiliary, imx8mp_audiomix_reset_ids); --=20 2.43.0 From nobody Sun Feb 8 11:40:40 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C7C320A02 for ; Fri, 14 Nov 2025 13:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127513; cv=none; b=fppZqF9UOe5yRnedKIkVdZYnfMi1oWN8gpY8+upXHxiadgo4hkX07Ss5fPNHl3pF8QwRSJd6lnUgv7ovmQyUJ0zV6gVnLhNFv59rIkJzApKhbg3YVA35sF6u7eLqeHdmKEQxAReGAE3S+p+/bRbqgnTOcum4dRNPrOCpCEzQgi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763127513; c=relaxed/simple; bh=v9PIaHoOGqn87lRlESH/AuFgCy5K1+8Bo9hGHBVSeHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bwD8HgIAdBXpuc0XinMZ8ef5rg3BKvWHqNqBSA5ZSU8w0Uj/kq/xUHvcKU3gvllDJ4qfqrCtMLP5g/rBvBoXJDmz/+lis3bnS4ES/xguvLE2Qev4V/ScK+uyYH9E5SJic+C7hWDOhBvpaE8GLknhAfYEJAgX1pgtrtJ9fbEDzWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nzg6AjxU; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nzg6AjxU" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b7291af7190so295848666b.3 for ; Fri, 14 Nov 2025 05:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763127510; x=1763732310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xHtOrvUe+VoHbx7eNPs1dlQDZqVpXM8AHRrOkF3QMQM=; b=Nzg6AjxUBqpCFV/maypliDagi3X0n2Hh3qXbRIdwss3SUjmgv+NLL9ok/nPaEN/q3p D6IPtT72yaJsTdMp9+qarT4u3LHQ+S7KTg+geqdhNZUOEzonLKTCl5KLqubSHNVhxx1O wfI/EYSRoDaTDThLCyn4a4mVQELIuq5OlO4boWMWQANeBmNHccH69kEYhkIoSTS1FK4P D4n6qcwrzyFh+nr4be69Q8jPFF3Npk1V1zlXfR1kkoen4qFCabQFVTaAXYdlXZLBMwcB l8ZOebKSTZnmwI76dfOQSysBkVnKDuPF0/mhWnShm+8FGQyeh1yv3Ux2agHsaT9ixDDj 5aMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763127510; x=1763732310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xHtOrvUe+VoHbx7eNPs1dlQDZqVpXM8AHRrOkF3QMQM=; b=tbGtkPTroMakWps5OM+Z4w0+6HhUMxylS1rx9/BT1mE7dZEEacyPOgvTZUBTUB8nsz LLwPzlHObxR0ufr+hsztKktlc4whZS8F/J4+yTGdazqldFc+IgaO2bCwM2YgK3zAwV2G Uv7UFpMfTCfKLDxx2kOPv0J2q11G1BFto/Zi92SlWt1CE8DhvyKyZZ6wrWvSQUt4HrCx t54nFoUkPFBNWlSD7/vQjYv/5efmVECDbIezghl8hIB8v2MHy1aVyQWBQWvNGSpNBWaE rvZ52OPkxBfywZnQZaGiyQvrgiAaQVfI6CqcQ1SXwct6YSdFHPLapEI7CHp8RJ0shA+p +uwQ== X-Forwarded-Encrypted: i=1; AJvYcCUZ2VBg8uvnvwS0Lmm/h3WXESksTuhUJ3XcmuBbxGesGCTeC/TOgJ+POnDQ2UaxGrzn7gkZ7KbZw26169U=@vger.kernel.org X-Gm-Message-State: AOJu0YyWgOQkU1hEMo++oElzMJWWDuC42Cb5ZDGbNaTf1osP9eeEgnCZ YqO127JsRs5u9pDTR3JJFIliteU9c4TyDoVsp2x7/qVq0M4V52rgJX3G X-Gm-Gg: ASbGncv04cHk4iBjTIR6XQTKqe5+ckrFlOZ2LUttsGhWPm49AyUSS79KYCbzjVD2l38 GP+SE1vPt+2FI2tM/aDLtGxSlnYS581Ak7jumdPba7CYisJ4CBycNfA/7eyq3SHHqDrexvoE0JQ /Oo+hQY10+/IWvsV97zh8wW+Ro/CMykSFTgDEceUFa/2HT4ji0asjNDjZrcShqb32KGb+5J/tER RDv7o6kIH6ke7Q5ah48+0s4RUFNZpumG5tmdPw7uLuyZ87bBSRAtVObdR2LQSDMC3b9NFq4IAPk 9v19J18NgyKNs7ZKhldWj3vzu5i6pPcq5atnkdIpU6kn790rPXSvTq5yY2oBiqp1cw0jHwYe3ov nn/R3C+6t6kMk9cVb04+ZMCVY8kr48QZ5NF4HWksVx2ReuLHzzeOy5riNOTTRv0Mlrvwm76bcUR HFfWX5qwhCKiBjk0pqe/gXP6Aw6tA= X-Google-Smtp-Source: AGHT+IH8dRTU8oBtJVQfEpqvTrilhZpOv3fQsxhq77CfNcpisTXOvodnBkppi6eij0qssBp+fixOiw== X-Received: by 2002:a17:907:9405:b0:b73:75ea:febf with SMTP id a640c23a62f3a-b7375eb040cmr72289266b.55.1763127509603; Fri, 14 Nov 2025 05:38:29 -0800 (PST) Received: from SMW024614.wbi.nxp.com ([128.77.115.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fedb2cfsm385330666b.71.2025.11.14.05.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 05:38:29 -0800 (PST) From: Laurentiu Mihalcea To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: [PATCH v5 6/6] arm64: dts: imx8ulp: add sim lpav node Date: Fri, 14 Nov 2025 05:37:38 -0800 Message-ID: <20251114133738.1762-7-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurentiu Mihalcea Add DT node for the SIM LPAV module. Reviewed-by: Daniel Baluta Reviewed-by: Frank Li Signed-off-by: Laurentiu Mihalcea --- arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/d= ts/freescale/imx8ulp.dtsi index 13b01f3aa2a4..9b5d98766512 100644 --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi @@ -776,6 +776,23 @@ edma2: dma-controller@2d800000 { "ch28", "ch29", "ch30", "ch31"; }; =20 + sim_lpav: clock-controller@2da50000 { + compatible =3D "fsl,imx8ulp-sim-lpav"; + reg =3D <0x2da50000 0x10000>; + clocks =3D <&cgc2 IMX8ULP_CLK_LPAV_BUS_DIV>, + <&cgc2 IMX8ULP_CLK_HIFI_DIVCORE>, + <&cgc2 IMX8ULP_CLK_HIFI_DIVPLAT>; + clock-names =3D "bus", "core", "plat"; + #clock-cells =3D <1>; + #reset-cells =3D <1>; + + sim_lpav_mux: mux-controller { + compatible =3D "reg-mux"; + #mux-control-cells =3D <1>; + mux-reg-masks =3D <0x8 0x00000200>; + }; + }; + cgc2: clock-controller@2da60000 { compatible =3D "fsl,imx8ulp-cgc2"; reg =3D <0x2da60000 0x10000>; --=20 2.43.0