From nobody Sun Feb 8 14:34:59 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D86330E854 for ; Fri, 14 Nov 2025 10:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116692; cv=none; b=pE+CzIUX/jEyPznRKjIauHGPv4luL+k7KnZZe03TJLqeSKrDJuelBmX3UYVLYNYeKWGygg5Z3KasZKkSziMTgacwtOMp3+NR8B7hNX8DWSiuWYcrKI+h/9MAYBKnZ6BHS8aaXHpoTkRiVVLfnY0vZXMYTWlEIkx8qW7CHa/qr2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116692; c=relaxed/simple; bh=5N0QWIM855WrbNzIgR9y9CFEsZ3+HDi4+UUYklbwiXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jREhPobijRLK3oqb487AfgR8x5wm7FmDvnhiU6z4GfLNYE7Ey1PS2IpSuAfDp/8Dgpui82GoLWM/v0TijskaPkuA+iBv/Pjn/qvL0y54oATkcP+hPGR/UUgpJ9OITCda+HwmqiFNavBV39wzI6mmUqV8OCk37BrF/ZpbGiWb9Ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=A1tWvzPh; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="A1tWvzPh" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b6d402422c2so282376166b.2 for ; Fri, 14 Nov 2025 02:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763116688; x=1763721488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YZQeO4tCAoTTOVTIamMOILGNRgViJn2iCP7o6r9P+OQ=; b=A1tWvzPhA9itSr4vu+dB0F7TABsdWWxk3c2efMYBeGtivyPb6JVyTDw7uEqHxcYChf jc5z+skcvmwLzLUEL/YM9GAYS7VqCGaW4hILsZ/12BjowwKcidJEy1u/pit9Qz/AzJMW fcYe624Zj0+t4LxEHFRraFFAp3wN7/2B6+qvryLnUr7dXqoOxkGxpcY09xWA2WBWn+Ba CWTy1tL70rLaYdMaLupBpbgY9WmI9I9JwRKkmhzrh98zk6Xo6FAF269yDxrU9BJmY7NP oX7FiIkxlzkOU/+Yp8J1mWgCvr280QVcvMjemmykqUGxUQB4XkywP/mHNxnQBsyuOyZL 9LZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763116688; x=1763721488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YZQeO4tCAoTTOVTIamMOILGNRgViJn2iCP7o6r9P+OQ=; b=ZvRqmrNHBIem99lL2IslrZv/apt3ukhXTqwi4U/+3j1dn3KuIVr2f6Ot8aqnzwhOk9 F2GqBiVpCkQP7Z/dG8Qs1iicga0RqqPBqu0ib4LqTg5fMkgshkXjDIzJtcY0MPbdU8M9 SBFFu4azRN5NQhOcnnu6SEZCRqNkOm0Y4NnWLGMQbbXjqTlwaLaDRbd3Bik642hO6Iz5 e/47sJyqNWR+GTCUDiqGm3JQ+C0kZm+siAbrJ1BAw5MR2FJCguKrE+K8eok7vNpciSEd uvndkwxKM50QjSc8dE8lKCfOAcdUoAnx3GI1BJxy67Oy9lMRQstFTVV1fe+bgueSKHmX 82xQ== X-Gm-Message-State: AOJu0YwG11iWFAZGFS1kL3FZTGHVr3LJf8CHHrGx02D2MvAL6qMst533 imbG1u3mDXtVHQdo1l9w8B82WJy8aRlbhMZoGMYl1I01F+LdvqILIFCDSrxcmginnp9lTEGrpRp NgPNi X-Gm-Gg: ASbGncshLVw0ZZ27ltaad5ynFuRSDwHUg9lk8Oj6ClPgjtvr9SBDDKaD+bktNuKajVN 9Ab8hjParRM7Xl6fhp8L8+BqSjKxc22DZhW92OWVRvu1cJFxjXq/n7T7qWH5uGcSUxR7CgjvnE4 yCpUBGdm5z0vvp5YfQeHAwzQGLV8c0dWnRRhvDpbp55bHSBfaqwfUVvJqB40//7+S91B0/AawVT yQkJ1ocVHzulEav9o9i09LqGLYumd0+EZRk+yQD1eknP/NX0oEmzTnw41oTNAgRB1InvSba+fdz Ksk53egA1IUtbFenS720NzoFRoG+fzXEUTaVQ57bAX7KATB9kYHPD0GctpkGin5ro9tv8/Ftggl KGfMXHU4KhejFOu85zRGT/7swPsFMoRLKUB5SChlvaISRs2Dnd+rEYH6iE3eenAwX2mkD1kCf0j Pk3N4= X-Google-Smtp-Source: AGHT+IFYKPqmITf/TNs8l5G58wFo9RnbBALHIHEhL9F/8pJF50PgLI/r5y09hTRdiyFf6G/b1aiJmQ== X-Received: by 2002:a17:907:d09:b0:b3f:cc6d:e0a8 with SMTP id a640c23a62f3a-b736786e693mr196119066b.17.1763116688579; Fri, 14 Nov 2025 02:38:08 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd80a3asm360276766b.37.2025.11.14.02.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 02:38:08 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Miri Korenblit Subject: [PATCH 1/3] wifi: iwlwifi: replace use of system_unbound_wq with system_dfl_wq Date: Fri, 14 Nov 2025 11:37:55 +0100 Message-ID: <20251114103757.111652-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251114103757.111652-1-marco.crivellari@suse.com> References: <20251114103757.111652-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") Switch to using system_dfl_wq because system_unbound_wq is going away as part of a workqueue restructuring. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h b/drivers/net/w= ireless/intel/iwlwifi/iwl-trans.h index a0cc5d7745e8..7e84074e1a3c 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.h @@ -1092,7 +1092,7 @@ static inline void iwl_trans_schedule_reset(struct iw= l_trans *trans, */ trans->restart.during_reset =3D test_bit(STATUS_IN_SW_RESET, &trans->status); - queue_delayed_work(system_unbound_wq, &trans->restart.wk, 0); + queue_delayed_work(system_dfl_wq, &trans->restart.wk, 0); } =20 static inline void iwl_trans_fw_error(struct iwl_trans *trans, --=20 2.51.1 From nobody Sun Feb 8 14:34:59 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8625B3128DC for ; Fri, 14 Nov 2025 10:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116694; cv=none; b=Fbb+jM9w20021YiA0c68HPHXM1q8ddKuSqQ7YDRcYGjYnrs09YwFUhtWlV1YhmmnuV6dULWrCzy+QdBrfK8+abwYK/lXyyYTpSsSMr4Kh64dj3r8b+lvpa100V+R0p3Z2I1/Q5TFxj0bzQT8KZlShI/ooic+WT+3Wb3yb3hXDlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116694; c=relaxed/simple; bh=9MCZFQdIdpPoPVRYxQ4ee4NJjMXh0QukZRSBL2NMN2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JSjthZGu9FTWOp6bMm30pJHpe3H2rOADSa0aPM7K9ylwr58dWKNE1AwE+A2B/SIM3+dC5kelLdtvIBd3naBq74DH4mOtvUanO0vYQMWBRcnqSFy/BRfFJprxAUxPwPssVRIwtsx92gYX30QPU7c7exhouJdJEoWWp+CX3XPa2kQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KQEnSPv+; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KQEnSPv+" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b736fca06ceso47327166b.1 for ; Fri, 14 Nov 2025 02:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763116691; x=1763721491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c5ZP6OcD4+SPY9iT09PIyYrTMYvEjHAazYaW78zQpYg=; b=KQEnSPv+LNa1dh+YwmKedRxtEal22N0SEKUg/fd0yEkCGS9YdmS0yNSy7y3raqg1jG xg1UhF7GGNwjCPDm+CYbYi2l6MMM28hlQmvt+LfciaW5alNIsU5AD6CazCz4Bt1TkkM6 FFZQHmaDyyM5LWkahdLwWAALZsV9n0NxOH6uLaPkrneFdWUvqJFZiuuTKBmaTa9yjIQs Mve8aMU8FwKG9Q3NxWKp5dt5Pf9JSTfjPB1Xi/UYo4TAqOcPrK8EDm5aJ8ZQClqFHHmn dTSw/k1p+yfRh1Wd04t+goi2wcnpIXmjVxqNi+Elssl+Kc2l4QgHKOdvc+TcOsNXrn/g 19AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763116691; x=1763721491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c5ZP6OcD4+SPY9iT09PIyYrTMYvEjHAazYaW78zQpYg=; b=va2RVpzFCj9cBdJacIExrAzWBkAx5+mRUDP85J2qh6I8kl6L3YPherS3/kJmE+43xE yQxz2Fcq/+7Rm9rXLEJYWFsFKNRLZlV+Wg36T9z5nqHJCYlDXsqULzYgr3YrS2VF0EBt TJvxLWUknnwBBIXwOVYKRrvttKhJTCJX8+E0bSReq6OjhzA94m1Pw/mA8qiiWUQimsS9 oX+5ta4dYnHgQ3cseConNE42FxUFgR7qliwRCp1faNwD3VU1V9+JknG21a2u02Ybl02j 85HUNqv3OzOthCN+cmnAdCMECbiJvAyvj/PG8s3lU7Ac1qLQLX50WHuMbv1bf9P+dbM+ IuUA== X-Gm-Message-State: AOJu0YyJGoe2XFodsKbuxaTv0HVPXDvE9v2XfBTB6xe1I2IE5acwdZ0d VMlWygjkhrJtKtFoL1LxrVE94Czmxwvkvtpzc1r2ycHcy5qpVX6YYIV+fikPP5XsITxDEBOICh2 gi6ft X-Gm-Gg: ASbGncsdBrKks81t5AVIK31pbC8DnA/wlZQ5Nrw2eeiTCiT6LeQZoF8M7x/tRrL/Bd5 NuPmg72Em9O1zTTr6JHTOJ8Otfjix/c+Xh+Nawbmzx/GMib2sVGKILfM+H7A2eF3FQcNA1iUML7 SGopUqW6yXMuGBi8okMfwfbIOQ+NiY8W5Y4NudAagQ4GFpYVx5hu7vxbH0/hiSEjCPSlni+RuAJ b5UeNfkI7YxIT0n27nD/E4MuZvuygb0NhPYVP9W5ynIK98Ta635JH3B7ZCTLZoj7fN3d7iqGMLb t+Wh+i7kZSyjQR70uF6aL8H1pkE4YE3xteRLS2pHqCrJnVy8A3iSkuoprRrheCr39daxJRvOQL7 Lsmg1a4aXtkIYdT4kW9lnpyrriu6o/gQHnaXafhu7rmMEJEQ8tquM8X5xtgUk5zX7ZWiHzL6c76 A/PM0= X-Google-Smtp-Source: AGHT+IFRdjqyvXJVH5Taiz7ujNsJphBunp3Hl9PQ3wpAGwRX4d7m4/fO5u7UoCzhlm8hkgbwp6Ls5A== X-Received: by 2002:a17:907:7207:b0:b73:7325:112d with SMTP id a640c23a62f3a-b73732513dbmr63891366b.35.1763116689415; Fri, 14 Nov 2025 02:38:09 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd80a3asm360276766b.37.2025.11.14.02.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 02:38:09 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Miri Korenblit Subject: [PATCH 2/3] wifi: iwlwifi: fw: replace use of system_unbound_wq with system_dfl_wq Date: Fri, 14 Nov 2025 11:37:56 +0100 Message-ID: <20251114103757.111652-3-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251114103757.111652-1-marco.crivellari@suse.com> References: <20251114103757.111652-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") Switch to using system_dfl_wq because system_unbound_wq is going away as part of a workqueue restructuring. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wire= less/intel/iwlwifi/fw/dbg.c index 2ce55859641c..e5f31b82339a 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -2933,7 +2933,7 @@ int iwl_fw_dbg_collect_desc(struct iwl_fw_runtime *fw= rt, IWL_WARN(fwrt, "Collecting data: trigger %d fired.\n", le32_to_cpu(desc->trig_desc.type)); =20 - queue_delayed_work(system_unbound_wq, &wk_data->wk, + queue_delayed_work(system_dfl_wq, &wk_data->wk, usecs_to_jiffies(delay)); =20 return 0; @@ -3237,7 +3237,7 @@ int iwl_fw_dbg_ini_collect(struct iwl_fw_runtime *fwr= t, if (sync) iwl_fw_dbg_collect_sync(fwrt, idx); else - queue_delayed_work(system_unbound_wq, + queue_delayed_work(system_dfl_wq, &fwrt->dump.wks[idx].wk, usecs_to_jiffies(delay)); =20 --=20 2.51.1 From nobody Sun Feb 8 14:34:59 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63FB0313521 for ; Fri, 14 Nov 2025 10:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116695; cv=none; b=q609Kz7kt8tgfOTU+StdcmxRs5IL+2a2P9NIEnnGvcoQY4i/WDlX9VkjbR1qZgacnsQeSe5ojSK6Q3lxMqTwx9o75bL9SoZCA+fXBqs6HugyJXAmcxfThoEdB5c9jwMr7XpFQQTfkpgorz21MuX7585hulqMBzt1qMFovg8XzMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763116695; c=relaxed/simple; bh=Omv8cFP4mpHW6K2oGUX0F0bCz6EyewF5K/eBoLp0jT8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fP5P4pKIl1mHWjsk2mr5fWZU2iXBus/nCFM0rQMa0g2/fMDcN2LWfhw+40652+P1bcAUMJTcRveY7FfWh1eZ4oVjrccGUHsXsKCE8AtGmyUDfA5c3RfUiPfJWBSyqBUEy7CHim5SiilLzw4ClCu7xbG5blpT7ZfK66D+TijUQq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=eh857Imx; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="eh857Imx" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6419b7b4b80so2639730a12.2 for ; Fri, 14 Nov 2025 02:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763116691; x=1763721491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+hwkF84KT6SY9+0UvheCyAefRzQC9daOKw7dQCB2jUo=; b=eh857Imx6MKvD33iI4uzjCcbA+pe9x3updc98UUQNhcnTf4TyCjffqVRAy+4+3H5QR VngluHJLRdMHfjs78HYu2D3uxkkmf2b2WymFvxA6tKtRPoIj2CPByd8Xyxrx8Dxkqh37 U2tHij3UQZIjmEZdyMViEEolpfx7YuVIWvGILStgFg7+Eipg9dCrVMCxHVUIlqQn1KQ/ dsug/OuuDbh4iE2id/4h8gdC6WDVBZASiBXCKOQL8bydqDBdcHmEAu68WGO/deYD2f0r UE0cf+P0XbMRMNxrFnQM3DtjQPTht0FIpHQh3Y2wG+gaKbq3CwIuFKsA6k4eOcfw+mrD v/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763116691; x=1763721491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+hwkF84KT6SY9+0UvheCyAefRzQC9daOKw7dQCB2jUo=; b=rzBU5tHzp30kjsmTfneaV4onKjTlSCuk89qHIp8moLE0oOjVveJSMgAwW1Wqy2AXPI Tq9l8IAjdx0Zbf0YvSaKXEnThl0BpHOXy6ti4w5ocwzvG/eGo3K7Hkt6bRf5+oYnNIMX qCOk0FJUqTxVzoqxdN/CzCXTzxqchBcttLnqzSTYlBI9ihCF5Yz4VqB1K8thOZVYwg4z q03VianwVj5s6Huq37yY5NsJhE+NB4mfP/5s7g/1YN9hGAns4m57VTiejUlS6vgxHL32 VFBEolXQxTI9PhpX+ts+l580w8rwgYMWB1lsIW3LjZGh1VLbzWvDkvz0rc9sy1n6nKFx fazA== X-Gm-Message-State: AOJu0Yws4wVRtrW81lZSk18IXK2qeqcysgsymfND5samBI1mEdUlkKma GvW6APw69OoQ5OJZYD/oN8zq71h1/RYKlioSpdw6dBZ3v4EuR8fX9C+ZGW/SOoX42aEFd2BXD+8 1o00+ X-Gm-Gg: ASbGncvogIEQehGUF0gqcxOQ8v4Z/eDFLKAHeGEArm0MEbITknHrV0dInHhGjl4GJfO 1+iu0dhMejGiHYuiPC8WRTpS3zl72NGynaG2KcibgOLK05CGgcygMn9T/xMYSk1SDQXm16I3kc5 o1fsngQh4xaeDKvNekkUUubrxDwtabIed6afPGdBm81PvRJZbbndySukU/hAbmUmdKRQZos6lJm N1G7Of8rFQIZcYV2b3vTXYeu0k6+ajBb6hMQb4BwjsmfgW4CJ64YTmQqwHvqo2dCQ4Z72msqNSv QHxgRcRW1PY/i//2eHMPUq69dTrtvlqi0b16QCBXDmNnO4aySONVUDNFRl/7YNbkbjz2+wSqK2y wY8NbCL/j8Fa3+rkFulE6NhhUw4yOa64ixIOKOMR+Msaeq0CzJSmn3MN+0Vm3bBnYvS1UV8UeSv 6r0Eo= X-Google-Smtp-Source: AGHT+IEQ4X5N/34ADNzJOud5XLBIlRdsUu7pIF8k5Vj560EHHofIwcFbpni7zYGLrK63oHkEmpHxMA== X-Received: by 2002:a17:906:f59c:b0:b73:53ab:cfa1 with SMTP id a640c23a62f3a-b736780c005mr250356766b.17.1763116691438; Fri, 14 Nov 2025 02:38:11 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd80a3asm360276766b.37.2025.11.14.02.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 02:38:11 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Miri Korenblit Subject: [PATCH 3/3] wifi: iwlwifi: nvm: replace use of system_unbound_wq with system_dfl_wq Date: Fri, 14 Nov 2025 11:37:57 +0100 Message-ID: <20251114103757.111652-4-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251114103757.111652-1-marco.crivellari@suse.com> References: <20251114103757.111652-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") Switch to using system_dfl_wq because system_unbound_wq is going away as part of a workqueue restructuring. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/net/wireless/intel/iwlwifi/mvm/tdls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c b/drivers/net/wi= reless/intel/iwlwifi/mvm/tdls.c index 36379b738de1..0df31639fa5e 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tdls.c @@ -234,7 +234,7 @@ void iwl_mvm_rx_tdls_notif(struct iwl_mvm *mvm, struct = iwl_rx_cmd_buffer *rxb) * Also convert TU to msec. */ delay =3D TU_TO_MS(vif->bss_conf.dtim_period * vif->bss_conf.beacon_int); - mod_delayed_work(system_wq, &mvm->tdls_cs.dwork, + mod_delayed_work(system_percpu_wq, &mvm->tdls_cs.dwork, msecs_to_jiffies(delay)); =20 iwl_mvm_tdls_update_cs_state(mvm, IWL_MVM_TDLS_SW_ACTIVE); @@ -548,7 +548,7 @@ iwl_mvm_tdls_channel_switch(struct ieee80211_hw *hw, */ delay =3D 2 * TU_TO_MS(vif->bss_conf.dtim_period * vif->bss_conf.beacon_int); - mod_delayed_work(system_wq, &mvm->tdls_cs.dwork, + mod_delayed_work(system_percpu_wq, &mvm->tdls_cs.dwork, msecs_to_jiffies(delay)); return 0; } @@ -659,6 +659,6 @@ iwl_mvm_tdls_recv_channel_switch(struct ieee80211_hw *h= w, /* register a timeout in case we don't succeed in switching */ delay =3D vif->bss_conf.dtim_period * vif->bss_conf.beacon_int * 1024 / 1000; - mod_delayed_work(system_wq, &mvm->tdls_cs.dwork, + mod_delayed_work(system_percpu_wq, &mvm->tdls_cs.dwork, msecs_to_jiffies(delay)); } --=20 2.51.1