From nobody Mon Feb 9 08:55:24 2026 Received: from TWMBX01.aspeed.com (mail.aspeedtech.com [211.20.114.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E7F30FC13; Fri, 14 Nov 2025 10:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.20.114.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763115062; cv=none; b=OKBn3WRmOkYAgw+Fjdt+WXPQTzIGEieKSiw+3dmIbFILzLX6ZRudU/GopEfTlnPBkDA1Zn9vct/XRRdLEn+Lu7GCP+aNm1KQOemL8YQmcohDCy9B4xIv6hvIBCcTrM/w23Z8OvrHBZuJECg/PtzUP8FxzDL1NBEHJcisU4aSYyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763115062; c=relaxed/simple; bh=5bzOt057KZZjQZzpwJKi5mVUZc8SdPBEz5J7qEOwi/o=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sx/MOnz58oW3Ezte7HVQRiKAL/VsgDJ3fi6/C8TMzhTdSFHzDgu8Ia2NsRHZrdIqt9CbuNjvPrRsdyKoNG/h8WpwDSq3tYkcOvgH6glKs+tH34x+w3Qv7RAEi/DvyxBUGWtBKAg4luvlwPxFWXkCrdJufoOoVpt8rVar6VxWQsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com; spf=pass smtp.mailfrom=aspeedtech.com; arc=none smtp.client-ip=211.20.114.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aspeedtech.com Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 14 Nov 2025 18:10:43 +0800 Received: from aspeedtech.com (192.168.10.13) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Fri, 14 Nov 2025 18:10:43 +0800 From: Chin-Ting Kuo To: , , , , , , , , , , , , , , Subject: [PATCH v2 4/4] spi: aspeed: Add support for the AST2700 SPI controller Date: Fri, 14 Nov 2025 18:10:42 +0800 Message-ID: <20251114101042.1520997-5-chin-ting_kuo@aspeedtech.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251114101042.1520997-1-chin-ting_kuo@aspeedtech.com> References: <20251114101042.1520997-1-chin-ting_kuo@aspeedtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the driver to support the AST2700 SPI controller. Compared to AST2600, AST2700 has the following characteristics: - A 64-bit memory address space. - A 64KB address decoding unit. - Segment registers now use (start <=3D range < end) semantics, which differs slightly from (start <=3D range <=3D end) in AST2600. - Known issues related to address decoding range registers have been resolved, and the decoding range is now 1GB, which is sufficient. Therefore, the adjust_window callback is no longer required on AST2700 for range adjustment and bug fixes. - The SPI clock divider method and timing calibration logic remain unchanged from AST2600. Signed-off-by: Chin-Ting Kuo --- drivers/spi/spi-aspeed-smc.c | 71 ++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index d1a8bdf6d540..db3e096f2eb0 100644 --- a/drivers/spi/spi-aspeed-smc.c +++ b/drivers/spi/spi-aspeed-smc.c @@ -985,6 +985,41 @@ static u32 aspeed_spi_segment_ast2600_reg(struct aspee= d_spi *aspi, ((end - 1) & AST2600_SEG_ADDR_MASK); } =20 +/* The Segment Registers of the AST2700 use a 64KB unit. */ +#define AST2700_SEG_ADDR_MASK 0x7fff0000 + +static phys_addr_t aspeed_spi_segment_ast2700_start(struct aspeed_spi *asp= i, + u32 reg) +{ + u64 start_offset =3D (reg << 16) & AST2700_SEG_ADDR_MASK; + + if (!start_offset) + return aspi->ahb_base_phy; + + return aspi->ahb_base_phy + start_offset; +} + +static phys_addr_t aspeed_spi_segment_ast2700_end(struct aspeed_spi *aspi, + u32 reg) +{ + u64 end_offset =3D reg & AST2700_SEG_ADDR_MASK; + + if (!end_offset) + return aspi->ahb_base_phy; + + return aspi->ahb_base_phy + end_offset; +} + +static u32 aspeed_spi_segment_ast2700_reg(struct aspeed_spi *aspi, + phys_addr_t start, phys_addr_t end) +{ + if (start =3D=3D end) + return 0; + + return (u32)(((start & AST2700_SEG_ADDR_MASK) >> 16) | + (end & AST2700_SEG_ADDR_MASK)); +} + /* * Read timing compensation sequences */ @@ -1511,6 +1546,40 @@ static const struct aspeed_spi_data ast2600_spi_data= =3D { .adjust_window =3D aspeed_adjust_window_ast2600, }; =20 +static const struct aspeed_spi_data ast2700_fmc_data =3D { + .max_cs =3D 3, + .hastype =3D false, + .mode_bits =3D SPI_RX_QUAD | SPI_TX_QUAD, + .we0 =3D 16, + .ctl0 =3D CE0_CTRL_REG, + .timing =3D CE0_TIMING_COMPENSATION_REG, + .hclk_mask =3D 0xf0fff0ff, + .hdiv_max =3D 2, + .min_window_size =3D 0x10000, + .get_clk_div =3D aspeed_get_clk_div_ast2600, + .calibrate =3D aspeed_spi_ast2600_calibrate, + .segment_start =3D aspeed_spi_segment_ast2700_start, + .segment_end =3D aspeed_spi_segment_ast2700_end, + .segment_reg =3D aspeed_spi_segment_ast2700_reg, +}; + +static const struct aspeed_spi_data ast2700_spi_data =3D { + .max_cs =3D 2, + .hastype =3D false, + .mode_bits =3D SPI_RX_QUAD | SPI_TX_QUAD, + .we0 =3D 16, + .ctl0 =3D CE0_CTRL_REG, + .timing =3D CE0_TIMING_COMPENSATION_REG, + .hclk_mask =3D 0xf0fff0ff, + .hdiv_max =3D 2, + .min_window_size =3D 0x10000, + .get_clk_div =3D aspeed_get_clk_div_ast2600, + .calibrate =3D aspeed_spi_ast2600_calibrate, + .segment_start =3D aspeed_spi_segment_ast2700_start, + .segment_end =3D aspeed_spi_segment_ast2700_end, + .segment_reg =3D aspeed_spi_segment_ast2700_reg, +}; + static const struct of_device_id aspeed_spi_matches[] =3D { { .compatible =3D "aspeed,ast2400-fmc", .data =3D &ast2400_fmc_data }, { .compatible =3D "aspeed,ast2400-spi", .data =3D &ast2400_spi_data }, @@ -1518,6 +1587,8 @@ static const struct of_device_id aspeed_spi_matches[]= =3D { { .compatible =3D "aspeed,ast2500-spi", .data =3D &ast2500_spi_data }, { .compatible =3D "aspeed,ast2600-fmc", .data =3D &ast2600_fmc_data }, { .compatible =3D "aspeed,ast2600-spi", .data =3D &ast2600_spi_data }, + { .compatible =3D "aspeed,ast2700-fmc", .data =3D &ast2700_fmc_data }, + { .compatible =3D "aspeed,ast2700-spi", .data =3D &ast2700_spi_data }, { } }; MODULE_DEVICE_TABLE(of, aspeed_spi_matches); --=20 2.34.1