From nobody Mon Feb 9 05:19:33 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3392F6939 for ; Fri, 14 Nov 2025 07:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107143; cv=none; b=Zmp50awCYofRYKp8mPbrqxrLGAgHJmPt24mYIDqkScug455lNK4SGOoyc1NGmbYgd+1u2cWw2I977ZtmXx9bXXbTVR91d/roiCQq4ARYxyaZuHvlw1HhnaXCkDNN5ryuMiTdyx+zVltF228oJXttO1IeTMGQNKruzJtsS/lpwjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107143; c=relaxed/simple; bh=qr/JTApNIt8LvdfHSv2pUFL122dI4OtNbZig3GzIZcw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QNcmZue64liA1Y8FGcLWJUmDeHW7pWBdvTJzU1WPT2Q2150B9gxIuk++gZMwfHXNWqfrcaPsrAKQJBIgYZUYR6Ls8Fo8Ls079roGwHaGB1o6TLqsK1XdV/29xqCpWG+6ULfRUXLFGgJN45Je/wKSfFI8fe0ycp/bBXYJuI1/BII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jBYUma44; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jBYUma44" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477632d9326so11856935e9.1 for ; Thu, 13 Nov 2025 23:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763107140; x=1763711940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qVdLYT+QZMSS2Y59bwaoXmWf+//7PAt1P2cIuP1Tb5U=; b=jBYUma44HpWTIg7Ro0T9KsC1MOibmE+A6YLvfiPYqiYfYG6XAcqYCOrKLF9YFNJkVa 1OzbF+VX8u82tpFurgnPO3FIJHHIuXkbJCxu/+Q1c5MujoIm2Jys2aidIf0Lus0shGqX yo7RAaEly7gzEL/D9EwTf6yjNTAxV/iUn5NCyTRRBX/vuxB6xuQ6ncylZQYv6pc3EfIH /hwq72EaOjl6xorTMPsfoo933eMW4rBkMOKW1XLboPV/QC7rTWYbC0p9x3rrSCfmXiJr HT1zD8h5nemuVtMwtaJfT7XYFys3LjeRGqvT5dLe74pqXPV2o4BohZzxJfVjKhXEdH9j ICcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763107140; x=1763711940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qVdLYT+QZMSS2Y59bwaoXmWf+//7PAt1P2cIuP1Tb5U=; b=H9enw/Ye+XLBoTrrS8y53ArFtL7fVSnnI+0bkVWOGBCc2ZZWdhtpWwsj5OqbHqJnpw OxtfeZDmGOXAOYJ+F/hl8fR7FaabbA8T7mvJqE5GvyK/bo+law1eGLtB2WRm8GntTtFe pckOjJWwht0ZEnlaYxjLbPqqoiDYn5wdfYaIBJifcj1fk253wsIt0JS0xVj+PzwmrxB1 KYF2FpYAY8qnJ+JeSCFN6JQyDJuA0nCIkFnwkLclyVxQbFbHqd6trLO1qHLgqpMyJNtT W1ZwcQroXIVqGx86B+mmyHQ37zDMXP9//vCJl39XmSODrFnNBOo+TxlbAl8ce+BWkYNO kIsA== X-Forwarded-Encrypted: i=1; AJvYcCW5U/Fsn/dF5BpRsGwlDpbk7F1zORyfI9J8W0Vfwchcu3i7j0OTLtLBWOPGpMsvFqBvDjU7NM0zveEJVv0=@vger.kernel.org X-Gm-Message-State: AOJu0YxOI60Fq1ILzJ4Xcgd6xA3J5sNbXg348aKzuxj1sYrDuHmHpS7U 722cslk7bEZ0osikvPu6IPTQYUercrJAWPJVZX97nhyadFuXzeR0KA3L X-Gm-Gg: ASbGncshjTtgV/9pBpsg5dx2n7Exvldg2uXSPKxck4vf03g8GZ82GMFcISRcEJPZBU0 1M+yoz9m3oZt1v0O5hrI9b6a6Uao0W+rdkqJVKiA6nLvpTTttX5w3vwEnm8bVK0GosMMxKEQLdv cZWYKFN00Sm8AcEyIalTh1vDNLuKX+JRz8W73XuoLeVkrINHNIHONZyzWCZ1GCFJQXvIBVBlTn2 bQIBJ/2TZfiAF6RjzyeVXocTqyCWIqw2lUZQh5/pgqGKcSlRru/syIMe2xQWz3LDBSfy/D1xMDl 56X5rNJCmDptTY2AFcO4vV52L6U7iRdAaG2vpvf5va6rMrsStjpRjYw5QlMEeAFKz/INKNKeI1C 73LTnrchwGfyG/pKomMBsQsxWRfZ6MtDXatgLe2sIn+hhEEmAp1Da+PIGr51j4Mi+Uj/D1vBjew VQS1Gx/8oYplDR13MMtsuDNBVuQVhr8N/73J8Ib1nax+RFCsXTv5hijMrQvKw4PXKtkL+PhZzuh 6G4yNLxYZVti9qT X-Google-Smtp-Source: AGHT+IHobo6oewAWiFwXHme2VtDD9BtCqGhcYtLVmrnit6G4r0D6gR9euAVscGX0uxhM9kixd1ab+w== X-Received: by 2002:a05:600c:a05:b0:475:da1a:5418 with SMTP id 5b1f17b1804b1-4778fe55465mr21359635e9.1.1763107139410; Thu, 13 Nov 2025 23:58:59 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c847bbasm76347895e9.1.2025.11.13.23.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 23:58:59 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Biju Das , Lad Prabhakar , Kuninori Morimoto , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Biju Das Subject: [PATCH v2 1/5] ASoC: renesas: rz-ssi: Use dev variable in probe() Date: Fri, 14 Nov 2025 07:58:48 +0000 Message-ID: <20251114075856.4751-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> References: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Replace '&pdev->dev' by 'dev' in probe(), this makes few error paths shorter. Reviewed-by: Kuninori Morimoto Signed-off-by: Biju Das --- v1->v2: * Updated commit message by replacing '&pdev->dev' by 'dev'. * Collected Rb tag from Morimoto-san. --- sound/soc/renesas/rz-ssi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index f4dc2f68dead..845a55250d70 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1119,19 +1119,16 @@ static int rz_ssi_probe(struct platform_device *pde= v) =20 audio_clk =3D devm_clk_get(dev, "audio_clk1"); if (IS_ERR(audio_clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(audio_clk), - "no audio clk1"); + return dev_err_probe(dev, PTR_ERR(audio_clk), "no audio clk1"); =20 ssi->audio_clk_1 =3D clk_get_rate(audio_clk); audio_clk =3D devm_clk_get(dev, "audio_clk2"); if (IS_ERR(audio_clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(audio_clk), - "no audio clk2"); + return dev_err_probe(dev, PTR_ERR(audio_clk), "no audio clk2"); =20 ssi->audio_clk_2 =3D clk_get_rate(audio_clk); if (!(ssi->audio_clk_1 || ssi->audio_clk_2)) - return dev_err_probe(&pdev->dev, -EINVAL, - "no audio clk1 or audio clk2"); + return dev_err_probe(dev, -EINVAL, "no audio clk1 or audio clk2"); =20 ssi->audio_mck =3D ssi->audio_clk_1 ? ssi->audio_clk_1 : ssi->audio_clk_2; =20 --=20 2.43.0 From nobody Mon Feb 9 05:19:33 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52C52F83BB for ; Fri, 14 Nov 2025 07:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107143; cv=none; b=QXR1yFSCvSApEvhvWEk/mApIPEgaNLZhYz2GPXCXg4nBLww7JpBaYhhzRBsO0jtQPcFM4F97xnVva7qUdlEYDrFcvBGdpB/XvuUrHnvTY9Z3Y3AryJEx772Tz1HTArZSAeqB/9/7LuEJyGmShEvs2PQrTlC2Jf0n47WzHW5NJyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107143; c=relaxed/simple; bh=o1rnBfocrHJzjDC8V9OlpRup+6s1WoIhBZarRlOb6TA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WNDxlDIKbsPVy1wsaVg03gWjdS++nrP8IKpBMjQFUw5U1jExSUIkvOhnxw9XggOiF4wy1Hoi6TkdW+2XhylFz4l9FW1t8GLl9pEM9dHe6Zx+6l5w13E9AguR2QElsrj+ve19rvYEJmDUYh3r2U2gKF1Pa03+2yH6jpTFE9kfHiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cdb/zCRj; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cdb/zCRj" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so12067065e9.0 for ; Thu, 13 Nov 2025 23:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763107140; x=1763711940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gtugt5POyRPdPZEOkeBhc/9SShTfFcU1Fk57+kN7z3M=; b=cdb/zCRjsD24bqxUh08aF9sfItGGOqtrbm/5yvEmQLuxctnJSdR4cdFqup4fdE7+NY 86CwI+TqiqWeEvHC0/0dwTJHCpXHE9X+ExTzXpPLHksFkRnN18FnwbGZUrAO/iQVMZqW bKAbH0jFG0n8nB//d3m1rolPZXqVn1Uqv9OWyUapFcFFzFy9QirFUPa7/hhR7l5JSgLC iIMNc3vPdC62nYiIdTd5gX/ObPbC7QLekK9ZqO3iHMrtTJKcgEmyvv5ETo17XvG8hcKl 9RFasIGqe42V/QX5fNTpU+2NLg/VSCEgv6qNs8O9dKXHISkDeSo2+NlpsfiaKhp8UAo5 1OSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763107140; x=1763711940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gtugt5POyRPdPZEOkeBhc/9SShTfFcU1Fk57+kN7z3M=; b=CZRKwena9f9whDRy4BV0OfWw9tgkYubeEK75/pC+lkDc477BWmg4s6+a2VRdRMtuPy MV9PE/0pu9ScrTtFRfoipHagpvlC6tBwKHmOgiZcTnp/E6tuEIDlag9dosUlK0Nwn/o1 4BNoM301/2Yv3wUu0IkHWQ1KnztasCrw+fv8cmtCOfZ9t0YFOEhh0IrYjK/67DJiXng0 iGRBa1yXW4Sz8HSzq1f3hYB14ZmicgGsv4eTWm+1GrSztw2rgO0VSe+2K/h0P3zQfLrO akY5mdbNNwGpDgXMd8SMEaAkBBw9vKNVTzRsKnlG+HHrQt+v8s0GC2QuZvs2ATKbd1x7 Vq8Q== X-Forwarded-Encrypted: i=1; AJvYcCV4fEsRKvn61/lqsN4X4SSgzWZ7ffSuPBGWTrWsT/M2uErWHyD0O3fhIYiFrqMorcNhzNA0ycW4o8etRo8=@vger.kernel.org X-Gm-Message-State: AOJu0YxGVGMyvnxIS95+eLs82Ach6xi/pH5a0JsQy0FGBGzXivenrU4X mHpX4+ieG9LwwYBmlrk5X8prD5q8SikqEJmw438OizPRcNaK+Hnb3Hj1 X-Gm-Gg: ASbGncs2/AAxpVgotaL0eZDR6R9BQNhNbjCKOHE7WP+iWnOoq75RVz9PvAaIqmi8k+d 7HYmJ29kpQTy4VBqR9m893IJtWrUT5JE3jXBm5qn2IDoiw2wSCze7IfnnjblvhQXjkfptSYeo/p MzJTANHWxxIM0MQY6eVZQe0BUnhVINM5CpQo4zKI+oNO2zZX/RrYBR8UOT0YuNy+pNFzoz+Y3e2 ZcaWaZzl2MAAmt3iwXGe2KK44Gx7mNaU5LqMmdsf71H1MshsBMdoxLbk220gKzphkB8Vd7hrnf4 UzD69aMV8p+7w7xitQmMB6/XhJtvGoP612LjTAKE+NqgNugWaioeLHvnXJPtYiLbHt4bismoTUL Vm+R/IFeHI69djU0URkBCVJG48VtNsgc/nlpH+2dh1nbmuF73EbCDB0mME0+63BZnG9Wk642ytu miNil12ZOY1ZjK7ws+7xSbRdbJZwpX8Twv4w4yjaAub2Chunag6YEMoqgl4ZYIabi/OJPSR+q9i mtqNoim+4YGqxsZGj18JF6mTA8= X-Google-Smtp-Source: AGHT+IF8ErsAkrTbvPtKk5YAcrD03Pxq+e86LCosiwT1QeFSy/EBdABo2BfsSDRYxYXL8vWvLJIKhA== X-Received: by 2002:a05:600c:4f07:b0:477:63b5:6f3a with SMTP id 5b1f17b1804b1-4778fead9a4mr17077075e9.27.1763107139927; Thu, 13 Nov 2025 23:58:59 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c847bbasm76347895e9.1.2025.11.13.23.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 23:58:59 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Biju Das , Lad Prabhakar , Kuninori Morimoto , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Biju Das Subject: [PATCH v2 2/5] ASoC: renesas: rz-ssi: Remove trailing comma in the terminator entry Date: Fri, 14 Nov 2025 07:58:49 +0000 Message-ID: <20251114075856.4751-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> References: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Remove trailing comma in the terminator entry for OF table. While at it, add a space between the braces and comment block. Reviewed-by: Kuninori Morimoto Signed-off-by: Biju Das --- v1->v2: * Collected Rb tag from Morimoto-san. --- sound/soc/renesas/rz-ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 845a55250d70..21f7d7c7c009 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1244,7 +1244,7 @@ static void rz_ssi_remove(struct platform_device *pde= v) =20 static const struct of_device_id rz_ssi_of_match[] =3D { { .compatible =3D "renesas,rz-ssi", }, - {/* Sentinel */}, + { /* Sentinel */ } }; MODULE_DEVICE_TABLE(of, rz_ssi_of_match); =20 --=20 2.43.0 From nobody Mon Feb 9 05:19:33 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A31B2F90D5 for ; Fri, 14 Nov 2025 07:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107144; cv=none; b=j9R7iFcwSJkOuhjlgDQxcbTtukfI4cPIrAvFSkrURMDt9mxnPE7AdIW5SBQxuGl82c4OENlY3P1HLJElQSQesrPHIQRVBSiEnqGcAlo4unjcaA5WQtTmY3oxljbCuotLVMVIvFiAT8qTlcpSU+MQjcM2Bey/Tn/NoMedh0f0HN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107144; c=relaxed/simple; bh=1oB6ejVOQiSslI+YY6o6RVr+qL2UsPs4X0pdDi9q1yw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DlgkEgkmQtvtlxnBKtb48a8ydC76pqnT4WOkFt6Ay+z9cNg3rKCHQqDiq6VIKuSCqOVRP5VSi2E52Ntr7JDPdnQoO/9UlaG++2n3J3MPKIkb+BUTThZ2FHEbh5A2IUXbK7wNVfMHzC6cGk752nPl/Ix6lHWds0fGZuLofp4zqx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CE2vRygB; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CE2vRygB" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477563e28a3so10902675e9.1 for ; Thu, 13 Nov 2025 23:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763107140; x=1763711940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3CmbAWmpu4IIfMH0eqanYAoW/4AiPlJTrOkq2LeJ2C4=; b=CE2vRygB/KzLgAHaR5Om/wkWOXzXtXEumQqgsZMz3bhAp07NYGidekzChouQuihi1a FH9UCaJOaIX0fqW9aopaep6VubefngAuc9UeyT/24Pk26uMLwnsuVl78UqBCPo/nTNLN aUCMXxS0HI+Bimm0F7El6qnyUFyyphaBu6nXxZskAnDbYhUQcYTm071a8pQh+Nd2IHRG UbBC05Amk47qXSg6L395P7Sn5OK25FueXZa7D80XpzZb5hvBvjcSfZ3N0CZ+z76oA1EJ oSONagvt/9dYudfiVKu78m1lZOuQo9PPvLQYE2fITGLjNtzQEAhrplwpVWnmGO89Ifw2 vKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763107140; x=1763711940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3CmbAWmpu4IIfMH0eqanYAoW/4AiPlJTrOkq2LeJ2C4=; b=fqi70Vx//Gsbo0HyNbk6OFOonDMaT0HHlIQj1kdkArPy//NGA9JoalGQbwT53/Kepc bdZ2mv41yf5yJ9dycORTFSUNOUJbGeTsSLm795feRkBxCPfwFggQAY8ys1D3KokFwhH+ NjJWFXHT4Q4o+cGqcXAnElrGFfva6RuhYkAC6FIgwxn/kP3MfaI7AjvqQSosKRgc9EHf 6oFKYDvmBU8rbLUwD17fbqIkX57YOdqFINZPqh77oSYOeaAH1umTH57t51TWRERA0OgN /88MnL8qtLmP1QugWfR1DHFhpL4KJ2avzSkAu4abRXujPpqSya1lr2TRk3k+/StOA/EV 5SuA== X-Forwarded-Encrypted: i=1; AJvYcCVDZWE7l2PlmcEa4BBgfGiYz6UI+7PiodVsl9WCDfaE4vDqer9nTvMMM4+5ZH8h1fo54G3eatJ6aSvhSwo=@vger.kernel.org X-Gm-Message-State: AOJu0YyeRbakDEcZHTgcAAnR6pDlBgux9O5uAzvb7S1PwYKKur85iVGF uNtKsWOs62Qn6MV2hVh8T468FE/6WiuPdOwJX66cRT0ObTbfT9UeO9Ul X-Gm-Gg: ASbGncsi75cAiIKF4RJF/0CWR/BWIDxsffWSy1aA4g7eanhDUhRkUeSoOQzAJVXV+65 QYm+1USl60kS9rrb1Ka7JkPqZGasiFz7ymQwpPWbunVrIK5Ha783JIs49mBRP55RLoI0c/qHn4s DTdop2vMAcdmU+iRR4bYANWJAZ46ckv3P9zA9kKatCiXBnigbywhVr8m5RiyVjkVsjOBmWewjmO Wc/JGr/M2y2D0Loj7DK4EKu1iqia57rsk9qsGFCJpMkPQwOdRa+ZMRoSUDfuJvf0nfjSmup4nA+ EdMqJGfUmQE3ors5IdoZO8SfdSHo4cQFkVj80rPUiuI3O0hGxLzM20HNfrylzgecgRUjAc6Z5QS 6wgzBunPW8kBsf9ahFDjElWggjE2BSAzppcNkFXp/ZzKY+n5h2Z7irjkBiYTyNzGppeBSr9z29Y iTsxeQ/34psafLT+jlWhU/EAfM4SfBBUhrWGc3V9Y2OKQkmB+vbrlc+VvkjwnLDLqvKBmG7jWuY 3rIBYN7cjrwalb2 X-Google-Smtp-Source: AGHT+IHyUrHUtSoN6qunQKG/oS0uHt3Xb7PwuZ/jNdLTEYwTgxmXjTTrQls0Yrm3bKue/k1AuP95Uw== X-Received: by 2002:a05:600c:3586:b0:477:7d94:9cf0 with SMTP id 5b1f17b1804b1-4778fdb36d5mr21891195e9.12.1763107140419; Thu, 13 Nov 2025 23:59:00 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c847bbasm76347895e9.1.2025.11.13.23.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 23:59:00 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Biju Das , Lad Prabhakar , Kuninori Morimoto , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Biju Das Subject: [PATCH v2 3/5] ASoC: renesas: rz-ssi: Move DMA configuration Date: Fri, 14 Nov 2025 07:58:50 +0000 Message-ID: <20251114075856.4751-4-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> References: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Move DMA configuration from rz_ssi_dma_request() to rz_ssi_dai_trigger() for supporting sample widths higher than 16. Signed-off-by: Biju Das --- v1->v2: * No change --- sound/soc/renesas/rz-ssi.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 21f7d7c7c009..55aefff8857d 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -774,14 +774,6 @@ static int rz_ssi_dma_request(struct rz_ssi_priv *ssi,= struct device *dev) if (!rz_ssi_is_dma_enabled(ssi)) goto no_dma; =20 - if (ssi->playback.dma_ch && - (rz_ssi_dma_slave_config(ssi, ssi->playback.dma_ch, true) < 0)) - goto no_dma; - - if (ssi->capture.dma_ch && - (rz_ssi_dma_slave_config(ssi, ssi->capture.dma_ch, false) < 0)) - goto no_dma; - return 0; =20 no_dma: @@ -829,24 +821,27 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substrea= m *substream, int cmd, if (cmd =3D=3D SNDRV_PCM_TRIGGER_START) rz_ssi_stream_init(strm, substream); =20 - if (ssi->dma_rt) { - bool is_playback; + if (rz_ssi_is_dma_enabled(ssi)) { + bool is_playback =3D rz_ssi_stream_is_play(substream); + + if (ssi->dma_rt) + ret =3D rz_ssi_dma_slave_config(ssi, ssi->playback.dma_ch, + is_playback); + else + ret =3D rz_ssi_dma_slave_config(ssi, strm->dma_ch, + is_playback); =20 - is_playback =3D rz_ssi_stream_is_play(substream); - ret =3D rz_ssi_dma_slave_config(ssi, ssi->playback.dma_ch, - is_playback); /* Fallback to pio */ if (ret < 0) { ssi->playback.transfer =3D rz_ssi_pio_send; ssi->capture.transfer =3D rz_ssi_pio_recv; rz_ssi_release_dma_channels(ssi); + } else { + /* For DMA, queue up multiple DMA descriptors */ + num_transfer =3D 4; } } =20 - /* For DMA, queue up multiple DMA descriptors */ - if (rz_ssi_is_dma_enabled(ssi)) - num_transfer =3D 4; - for (i =3D 0; i < num_transfer; i++) { ret =3D strm->transfer(ssi, strm); if (ret) --=20 2.43.0 From nobody Mon Feb 9 05:19:33 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF3312F4A1B for ; Fri, 14 Nov 2025 07:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107145; cv=none; b=rCPPWx4pAY81ybhhFPecbCIpLH+87YN7RlEUC0/LwBqz/+tJGPFYQODa8E0GryVs6+6lE1NlbmbwZGp7CZgQDnpZnHVUv9psfQQgLVHOgWK8I7E5ruZHx7OAEW0P2zsMAbtdUAFMHbkdYqIA4EzbETqePYmOuhzogC4Ob5p4Foo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107145; c=relaxed/simple; bh=cFLV533h4O3rO3j2a2nEJRzLpD/2ov1h5vOs874CNdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h/xx7ikp32FtMQxiI4WW8VNke89MJf0lk61MDvMlNkaVlcSy1yxHHcekcFCsVpkxhxaUlW/tW+39ZXBZQOKO4gvqpR2FSmFm2vsevtd7fvlUktueUUPfdEB3MADNvY1xnJ+XIZfzQOhGfzwbq9Cm2VwsK+kLSkAjH4yrzakwOvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UbY4UR20; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UbY4UR20" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso8555635e9.1 for ; Thu, 13 Nov 2025 23:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763107141; x=1763711941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CkzCeEb3navO40uJNEmomf2mfxM1QxS5KFNp5J+6KA4=; b=UbY4UR20BV5UEFH5beN+v58ejsl7IQrKY6Eq8OAIpGPJSDv1ZBrXleVOvWRSqARQ0v BQukVnxSOISmtME4RuecwXIvlBlUmRstWmOOhW/H6CEkNxFNmy4oB+fXK6hwdoCUISAW 8zaBxXKfsKQUh0RnGfCHGNBdEOdT3oqILqMavQ96NxCtbujAqp1DMbSBA9aGp90Be3sQ NHPhxI2d0MLAJDp1TeRWvrg8qiqkWcNzIiQiX5/T/6VCKXumcS0gAP7rwJhPsvPPSkqP hU9wQyAVHTZr3ETH1FjUjAKn7wjRTxFLaDK8kzYVYrR+a8P2jNgbu3R+bdCycYGKpE4e oxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763107141; x=1763711941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CkzCeEb3navO40uJNEmomf2mfxM1QxS5KFNp5J+6KA4=; b=B+mrop9fSMDu2LIe5UuziF1yt/CR1hZxJ/9WqHVKgwm7PJWUKMIimiaO/vSTCsXDVx geDZ4krC9NJQOoDhaanm8tsVlfPkGwRqx7hFgtU+YQH6ZTwmzMYAkJDVWAq40oyUXP/B 8m/vF3qDz3MGqfVU0Zqqx+2qD3bJBUMesX0lIGKRqAd17ZQ2wF8VlhTCgf6Kpsb04rn/ H5FklBE3+la7J8lTdJzpTQ+ADutV3+Bux5vJCfMNRDBQWA0BeUIp6atbFqRwV50EvKuX 6AkkK4TqfXFGbiUnraXyco0pzx0yl/U71Uhqb5P4PXjStlUVlFXRCBmts8JNU07pj3dU PT7w== X-Forwarded-Encrypted: i=1; AJvYcCWgUXDG3zFDWQK4q60iwCdJbx2ar2QYmwdl5i/zJV+CMUkKYldQTMGxfrVF6W4VBggQP4BrxsDstNS8pGM=@vger.kernel.org X-Gm-Message-State: AOJu0YwYfVfPkwtbded3CfjO+MWrMkXoMc8X++I3Wgx94yeQV/mk/9n4 CdZLWuL5IGLLcwYhhTOWQuETNX3YnjdCmSPp2hpNJTXBuIcS3SeU0a69hAPoKA== X-Gm-Gg: ASbGnctfzcxWk9UcS0ZN+I/ulMv4laAeVd7obiCq/902HLfMxGqyn/WzryWySIfPmGT GukoDm5uyerhu0y2IBrLD4iifqNjsPbNLVFMOqKBIwapl3J0+Uhd7LO9y2ATG0Tq/FYy4ZkZUfC HHQdmcHCpK6AippQTifplrqKlK3P3wQfI8p/oWcvkgcOf6go+im4T/uY3tVJmh3GFa6Oeab9ygW eJxAIh92DqAVhEF47Db1K2mjx8t1VW6h3n4gRQrm25LEiGq/3ehT/0nGnXTTTMnB7U7kCqE6r5d H2YkIoHlwStK3gnYQnweAF0KlHFOgdbpRywNCN7aJZQCfScHPj3mwRc3nE+JGItT6HiDNWKO7O9 YdSKUP6ixwApQPSWSa8KqEO1keJUo2l0KkxhplEPdKkXyAk/YfEN8kUqnN+wnJwBpWtjTxOkoaz G/gQ4WTotWhqplIsc5AUQ1siGoaPUi/QZKG/bykHt1GqxsXlTf58Mb6QLuT303ZuqET5aOuSwDa 9PhPuXPtD7ia5xW X-Google-Smtp-Source: AGHT+IEVkGZ6INx5GNdqNHodG0mme/hMs8mtdPy04E7Q4DZtbZ697iy8gTURwupoXOgMmgDqFRcb6Q== X-Received: by 2002:a05:600c:a04:b0:46e:4a13:e6c6 with SMTP id 5b1f17b1804b1-4778fe9b384mr19462065e9.19.1763107141038; Thu, 13 Nov 2025 23:59:01 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c847bbasm76347895e9.1.2025.11.13.23.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 23:59:00 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Biju Das , Lad Prabhakar , Kuninori Morimoto , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Biju Das Subject: [PATCH v2 4/5] ASoC: renesas: rz-ssi: Add support for 24 bits sample width Date: Fri, 14 Nov 2025 07:58:51 +0000 Message-ID: <20251114075856.4751-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> References: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Add support for 24 bits sample format width for RZ/G2L SoCs. Signed-off-by: Biju Das --- v1->v2: * Updated rz_ssi_clk_setup() to make ssicr assignment in single line for 24-bit sample width. * Updated rz_ssi_dma_slave_config() to check for 16-bit sample width, that will allow us to support 32-bit smaple width later without any code change. --- sound/soc/renesas/rz-ssi.c | 75 +++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 18 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 55aefff8857d..3ec7c9875b43 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -38,6 +38,7 @@ #define SSICR_MST BIT(14) #define SSICR_BCKP BIT(13) #define SSICR_LRCKP BIT(12) +#define SSICR_PDTA BIT(9) #define SSICR_CKDV(x) (((x) & 0xf) << 4) #define SSICR_TEN BIT(1) #define SSICR_REN BIT(0) @@ -74,7 +75,7 @@ #define PREALLOC_BUFFER_MAX (SZ_32K) =20 #define SSI_RATES SNDRV_PCM_RATE_8000_48000 /* 8k-48kHz */ -#define SSI_FMTS SNDRV_PCM_FMTBIT_S16_LE +#define SSI_FMTS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) #define SSI_CHAN_MIN 2 #define SSI_CHAN_MAX 2 #define SSI_FIFO_DEPTH 32 @@ -294,11 +295,24 @@ static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, = unsigned int rate, } =20 /* - * DWL: Data Word Length =3D 16 bits + * DWL: Data Word Length =3D {16, 24} bits * SWL: System Word Length =3D 32 bits */ ssicr |=3D SSICR_CKDV(clk_ckdv); - ssicr |=3D SSICR_DWL(1) | SSICR_SWL(3); + switch (ssi->hw_params_cache.sample_width) { + case 16: + ssicr |=3D SSICR_DWL(1); + break; + case 24: + ssicr |=3D SSICR_DWL(5) | SSICR_PDTA; + break; + default: + dev_err(ssi->dev, "Not support %u data width", + ssi->hw_params_cache.sample_width); + return -EINVAL; + } + + ssicr |=3D SSICR_SWL(3); rz_ssi_reg_writel(ssi, SSICR, ssicr); rz_ssi_reg_writel(ssi, SSIFCR, SSIFCR_AUCKE | SSIFCR_FIFO_RST); =20 @@ -455,7 +469,6 @@ static int rz_ssi_pio_recv(struct rz_ssi_priv *ssi, str= uct rz_ssi_stream *strm) { struct snd_pcm_substream *substream =3D strm->substream; struct snd_pcm_runtime *runtime; - u16 *buf; int fifo_samples; int frames_left; int samples; @@ -490,12 +503,23 @@ static int rz_ssi_pio_recv(struct rz_ssi_priv *ssi, s= truct rz_ssi_stream *strm) break; =20 /* calculate new buffer index */ - buf =3D (u16 *)runtime->dma_area; - buf +=3D strm->buffer_pos * runtime->channels; + if (ssi->hw_params_cache.sample_width =3D=3D 16) { + u16 *buf; =20 - /* Note, only supports 16-bit samples */ - for (i =3D 0; i < samples; i++) - *buf++ =3D (u16)(rz_ssi_reg_readl(ssi, SSIFRDR) >> 16); + buf =3D (u16 *)runtime->dma_area; + buf +=3D strm->buffer_pos * runtime->channels; + + for (i =3D 0; i < samples; i++) + *buf++ =3D (u16)(rz_ssi_reg_readl(ssi, SSIFRDR) >> 16); + } else { + u32 *buf; + + buf =3D (u32 *)runtime->dma_area; + buf +=3D strm->buffer_pos * runtime->channels; + + for (i =3D 0; i < samples; i++) + *buf++ =3D rz_ssi_reg_readl(ssi, SSIFRDR); + } =20 rz_ssi_reg_mask_setl(ssi, SSIFSR, SSIFSR_RDF, 0); rz_ssi_pointer_update(strm, samples / runtime->channels); @@ -513,7 +537,6 @@ static int rz_ssi_pio_send(struct rz_ssi_priv *ssi, str= uct rz_ssi_stream *strm) int frames_left; int i; u32 ssifsr; - u16 *buf; =20 if (!rz_ssi_stream_is_valid(ssi, strm)) return -EINVAL; @@ -542,12 +565,23 @@ static int rz_ssi_pio_send(struct rz_ssi_priv *ssi, s= truct rz_ssi_stream *strm) return 0; =20 /* calculate new buffer index */ - buf =3D (u16 *)(runtime->dma_area); - buf +=3D strm->buffer_pos * runtime->channels; + if (ssi->hw_params_cache.sample_width =3D=3D 16) { + u16 *buf; + + buf =3D (u16 *)(runtime->dma_area); + buf +=3D strm->buffer_pos * runtime->channels; + + for (i =3D 0; i < samples; i++) + rz_ssi_reg_writel(ssi, SSIFTDR, ((u32)(*buf++) << 16)); + } else { + u32 *buf; =20 - /* Note, only supports 16-bit samples */ - for (i =3D 0; i < samples; i++) - rz_ssi_reg_writel(ssi, SSIFTDR, ((u32)(*buf++) << 16)); + buf =3D (u32 *)(runtime->dma_area); + buf +=3D strm->buffer_pos * runtime->channels; + + for (i =3D 0; i < samples; i++) + rz_ssi_reg_writel(ssi, SSIFTDR, *buf++); + } =20 rz_ssi_reg_mask_setl(ssi, SSIFSR, SSIFSR_TDE, 0); rz_ssi_pointer_update(strm, samples / runtime->channels); @@ -658,8 +692,13 @@ static int rz_ssi_dma_slave_config(struct rz_ssi_priv = *ssi, cfg.direction =3D is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM; cfg.dst_addr =3D ssi->phys + SSIFTDR; cfg.src_addr =3D ssi->phys + SSIFRDR; - cfg.src_addr_width =3D DMA_SLAVE_BUSWIDTH_2_BYTES; - cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_2_BYTES; + if (ssi->hw_params_cache.sample_width =3D=3D 16) { + cfg.src_addr_width =3D DMA_SLAVE_BUSWIDTH_2_BYTES; + cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_2_BYTES; + } else { + cfg.src_addr_width =3D DMA_SLAVE_BUSWIDTH_4_BYTES; + cfg.dst_addr_width =3D DMA_SLAVE_BUSWIDTH_4_BYTES; + } =20 return dmaengine_slave_config(dma_ch, &cfg); } @@ -977,7 +1016,7 @@ static int rz_ssi_dai_hw_params(struct snd_pcm_substre= am *substream, unsigned int rate =3D params_rate(params); int ret; =20 - if (sample_bits !=3D 16) { + if (!(sample_bits =3D=3D 16 || sample_bits =3D=3D 24)) { dev_err(ssi->dev, "Unsupported sample width: %d\n", sample_bits); return -EINVAL; --=20 2.43.0 From nobody Mon Feb 9 05:19:33 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F3962FAC16 for ; Fri, 14 Nov 2025 07:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107145; cv=none; b=ml6iQ7dvWeX/IevwrQ4oepnCkS2AKro4mGagekP/BCwLPBgpT7XsULhbvG3/VEQBGysGXxi7IKt9GRAFzZnfHWNzbmTNVkrKBvGu+DzNp2ujF8fGF3lEsYOmsvBGlC7fSlkSyBFwOjwVWf5eAIxhjl5rJYJNKjLY7lgVeO3Wxkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107145; c=relaxed/simple; bh=9qhHAfmSmgZdMYGPPdj9m4G0frUb8TVsMzQFMztnhwA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rzplZzswrzeY3G54J3o+1EAMcLxXr2UZ/iJOSjZDuXgBHCmUdWfDCbT+jonU5Te1t9zqn30yT62bUG74ntaWR30STEV9emd4l9Z0DpvsCN2amFahyat5TRF1R2liqeFyHS38CbcSz0QD80Pm3+NxuPBkiy778jdpETKjR9QQDYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SF2G4tEs; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SF2G4tEs" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477775d3728so16758935e9.2 for ; Thu, 13 Nov 2025 23:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763107142; x=1763711942; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dno4fYyihe/RYznSluqpdOt6mZrIDZ0jrnHu7E3GcE0=; b=SF2G4tEsUoa56R8GeVecXqZEZuKlRHAQl6fCTN1RmAVNk5hsuRsEIJ5EQNHxFB/SDQ CTa/arSW/r54UFvF1sK3HKyUPRO+DjSZT20oRNSAixPCVKsQFdqtbrQPUOY6upk+JKqd HOX1wt2oNiFjEV2f3UgxcTITxubXL/xhqAkucIQTsaoiOPtlW/B4blat4BoYbdqEd8tY oPfmdTJYNpYpDfc525VUFi8Fl1dw78R0aRgAOd7NJoNQrJqMCPlj2UapI+oBfq5go09u cdMFAIzgSHlDb1oXgLbqKKhkZJzMFegLpuzUb4FUvGMiWd+EVBMp3yxE8h0/c4tJpVk9 e25w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763107142; x=1763711942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Dno4fYyihe/RYznSluqpdOt6mZrIDZ0jrnHu7E3GcE0=; b=RefQVqx3WZtoeRxtvkkLzo8b//K/ZcU/emEAiAslldnqoJcDxcEfqckSmpH6dg69NN RqyD3tQm/vN8hU9gxik6dYTvfPajFPXL48OqP6Dr6VP8//XNiG5Q8wLfc9/ASFhzZINg myvZYBMXdhKLHB/VdzKUBEyv3HKL+dCKaykv0KeByiSwERzLy6H1dY2hW1kgyv+4g/3h bnQkSZz2hvVw9NfnDtqbqnPAhljCnaeprTSLVsjFVClEOAjZuJrTiSupR2TpPQ+lvK/g 0mDEMjPq7GDVf3GV9hH4DtI+cb0LyqqLsn8sQuh0EJcUE6vwkeTkBuJaJSYVs+iotpMG e+jA== X-Forwarded-Encrypted: i=1; AJvYcCVHSOLk/ODUKFJUANgEqR6T3MqdgaP4sDgOiok27H7wxOEQglBMxGkEFsjosX5iGyKwS1SeaFQUXM+HJzg=@vger.kernel.org X-Gm-Message-State: AOJu0YwCWvnfIXmfrpNNwriy7075IJv+PJj/dkI0OJKxTzf5lIeYdPQM N8hpjEyu8jGM2h9NJR4WX5YOUr3uuyaSulvBZB7xUFql1SYWh4qPvoFM X-Gm-Gg: ASbGncv6dTc+yhjzql2EIKTTc2ekXG3Jeg9KW+N0+vRLpGi7OuDEZhmf20Wr+fLlJR6 M5TDAIRALWI5KbX6mCnauEWEHYNfoeMfN/XJNzUecODrKENUMtSTRzZ5/H/W0AbwDvI75xuAncd CEvqekBn+RscpyfD76PoYn5RekuaEzIGammrgUtw4DDpEnD8AH4cgydqgANvm8xmRkrjQ9309DF jIr9x6lBCcLBNZ90wcBLeUfgPaoznc0ZzTpLOzdrU+qQzNl6TedaLZ4jRSQ1SKajiPoPanbYO+p Nq3icZG/CGgRF14y9YCQMLF1S3znzSowsV5jojGz0SLTO5bfVebe1W/GAoaa8eD+ghU43JiSGgG oO6acLALeZBYP7Fz5GrIuc9u5NIjbC2Yhqs9x/17FInqWXbPI4HJgCIZY04rp165zN7t6Zv4Sar HdlKKCjlgyer2KiCCQdyQp5pseTxZPKdpDSgYoZl6N9s3OHG0a9C4uiQz1Mbz0jXS3jSZCcoWEW pz2+rJbnm2q9/Rk X-Google-Smtp-Source: AGHT+IHSwU4mhyT8rLvuHxiA7sp7Ubk0n2kRWcbYTp78Fbo4XVCzyG5XlKzDo2VIzKhdrSQgxELv0w== X-Received: by 2002:a05:600c:350d:b0:46e:32a5:bd8d with SMTP id 5b1f17b1804b1-4778fe553famr21894475e9.3.1763107141541; Thu, 13 Nov 2025 23:59:01 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c847bbasm76347895e9.1.2025.11.13.23.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 23:59:01 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Biju Das , Lad Prabhakar , Kuninori Morimoto , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Biju Das Subject: [PATCH v2 5/5] ASoC: renesas: rz-ssi: Add support for 32 bits sample width Date: Fri, 14 Nov 2025 07:58:52 +0000 Message-ID: <20251114075856.4751-6-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> References: <20251114075856.4751-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Add support for 32 bits sample format width for RZ/G2L SoCs. Signed-off-by: Biju Das --- v1->v2: * Dropped checking 32-bit sample width in rz_ssi_dma_slave_config() as it is taken care by restructuring the test. --- sound/soc/renesas/rz-ssi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 3ec7c9875b43..5909778a6a70 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -75,7 +75,8 @@ #define PREALLOC_BUFFER_MAX (SZ_32K) =20 #define SSI_RATES SNDRV_PCM_RATE_8000_48000 /* 8k-48kHz */ -#define SSI_FMTS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE) +#define SSI_FMTS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE | \ + SNDRV_PCM_FMTBIT_S32_LE) #define SSI_CHAN_MIN 2 #define SSI_CHAN_MAX 2 #define SSI_FIFO_DEPTH 32 @@ -295,7 +296,7 @@ static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, un= signed int rate, } =20 /* - * DWL: Data Word Length =3D {16, 24} bits + * DWL: Data Word Length =3D {16, 24, 32} bits * SWL: System Word Length =3D 32 bits */ ssicr |=3D SSICR_CKDV(clk_ckdv); @@ -306,6 +307,9 @@ static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, un= signed int rate, case 24: ssicr |=3D SSICR_DWL(5) | SSICR_PDTA; break; + case 32: + ssicr |=3D SSICR_DWL(6); + break; default: dev_err(ssi->dev, "Not support %u data width", ssi->hw_params_cache.sample_width); @@ -1016,7 +1020,7 @@ static int rz_ssi_dai_hw_params(struct snd_pcm_substr= eam *substream, unsigned int rate =3D params_rate(params); int ret; =20 - if (!(sample_bits =3D=3D 16 || sample_bits =3D=3D 24)) { + if (!(sample_bits =3D=3D 16 || sample_bits =3D=3D 24 || sample_bits =3D= =3D 32)) { dev_err(ssi->dev, "Unsupported sample width: %d\n", sample_bits); return -EINVAL; --=20 2.43.0