From nobody Sun Feb 8 12:57:35 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACEF2D595D for ; Fri, 14 Nov 2025 05:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763096795; cv=none; b=DUTnnIxWS3B0cSge/AEDZn9645IwbPgvwgTZuwYnwPEOHADffih/CI3ozJiErgaBsFOxyaQCsuZKCI7Ibi4PRSrymsEHKMndmLExy7mBoTEBEFe0DhCxYL+RBRm9Bo70xsG07mlN26oB5HSRPTp2HSiD84YiiA/T8lZlsKrMTrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763096795; c=relaxed/simple; bh=pM5S73m700jtqGwvXm/0FCPAJKJB8CEarHf48b4LvaU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bvWH81FjSVyTy/j4ImsJWOla2h05b9wIvzHyy5g2oJ+5WgHurq4KcqD0uz23n8WoA+m3lTbwAGK2uXr7FxNwMSTuOycYcGg/jMU9/2fPN1Qe7GZNiVjyNtswjFM7fwsgWZiJcwdZGI25/ghMQRW7/Cpv+zi3ApHjFTjMI6OyImo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A3WlC2Ic; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3WlC2Ic" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so11120215e9.0 for ; Thu, 13 Nov 2025 21:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763096792; x=1763701592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=blgHIYLf6PCzD+Ez9AnxfBSumqELLMBUHE68IZnKmYw=; b=A3WlC2IctZK52G+bXCf+HmNbwX5bdTZFakikM3q1B2PfLd76SYehzJf6EoTDfQL9gX Wwkzl3f3rOG9jZPDLQhl+7sLjrlXGyR7Mb2FOzwwr4lehX1rwmdGkomDhvWY/j03/k5F uYXabE6+g6gUAP90USaYMsWscIDvzaD4+MTTXEOzBMpuRODTIOgBR5tcRpYowOC+Tu7N tF1kR6uy3jYubFNLOwLssdCgQhJuqazPuVUdTEAvhxJshU/AbJDzgs3otB2gBdXpENbE mDRwgMMv5DHpEfouIl4h/FplyuTIsA4eUsGHQR+Q41uIrtJwF6yHJPBt/oXHefrxNeSg 9vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763096792; x=1763701592; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=blgHIYLf6PCzD+Ez9AnxfBSumqELLMBUHE68IZnKmYw=; b=avnE5l69Mu922Akax9qjKHrW75NtK4DfDZmxH5ZeM9SNpKxh74iPqEv9qqYI7dw7Mo omy58SMkqqbB8nX4k/Vfn2Kp33toUS7OJrs2pfWLN1SvMS6FQS+3BybYGRq6E74Rx/Bg 2s1svP5CDzxHqverXOotGPmMFEII+78+4Q7KeqyXXBwE4S9BVPJPKC3us+voy0kuL6xo sC1eXHV1WDKt69ZPB8STAlO9X9Pg09q/QUBOxWKhUsgC+bSZv7YhQ5Q8dloDL7WdbnXJ kiMWTZutU4phn5JGqaHL/+9Y0rssAfIRVFgntbHx3WTWaTSSGZ4SkC5ACNISHDgfN4gF z82A== X-Forwarded-Encrypted: i=1; AJvYcCU1zaF772GzUXf/WCkjY18vZKzI27M8sD0unKdkTEfzRWymsrXoEvsa0azxRCB/QSClbF85cvSpAfLZxZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwITprK29UtI26RXgOvShsPZdn/jhNT2HrDovqMs0Gh0SvkhTGC P4ShPcI7K+zv8V5Pr4LOxnWcy0SYLNVad4gVcq88Vfa2/2zD7z0uf/e8 X-Gm-Gg: ASbGncvmWlp5HuuM8oJbqwXTUO10qrLAAVZgtoj+de4B+LGDopj18xmB2ONePpm2MLc E03YXDUaLG1oY2B9RxUiJkzUJXEuFe44OplJSCLElp3KqIzpJcjcDjdI1SSXs6bQdTylhCXpWqe QMchjzi5l8LqqHAGpKrlQKzSam8RuwjyDvLjLTRIArMvbExZY2M3oYJSnbQeTtwS2OuvNI3m/Sz MWdq1w4ComEJ14PSzdo9QcQw5NSB+LyUaxauYQVYLZrYwjNfNLzHZSwJjf0rEnnz2S+PN4CP8rU gSLq0wF6JYVrCR8Wh15oFOTBSMRVSsB9LpHuYFeKRdclpCtz2c8FdDIfHHPtK5r8qAQ8uUJhUcQ pZugoZvQVvDlhDRJCXxQYVaZN2ONBxPhsSBZYMp1bgopbXsk9XJ2+eydHyhK0qkJH+I9Q0+yNEK FxkbKfczKLfpv12rbseUwMrP8SCrub0Y2mQrxHdyo= X-Google-Smtp-Source: AGHT+IEf6mzpUpNup+IgA/Z5vnr37fCX91zrQy8VDnsWIXMSNGb3WBsnwiYYSyWGNr/v2Uw3Ime2ww== X-Received: by 2002:a05:600c:3b25:b0:477:7925:f7f3 with SMTP id 5b1f17b1804b1-4778fe62d4emr11532805e9.14.1763096791856; Thu, 13 Nov 2025 21:06:31 -0800 (PST) Received: from ekhafagy-ROG-Strix.. ([197.46.78.60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778f247821sm44219935e9.5.2025.11.13.21.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 21:06:31 -0800 (PST) From: Eslam Khafagy To: anna-maria@linutronix.de, frederic@kernel.org, tglx@linutronix.de, gorcunov@gmail.com Cc: eslam.medhat1993@gmail.com, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, syzbot+9c47ad18f978d4394986@syzkaller.appspotmail.com Subject: [PATCH] posix-timers: Fix potential memory leak in do_timer_create() Date: Fri, 14 Nov 2025 07:06:21 +0200 Message-ID: <20251114050621.875131-1-eslam.medhat1993@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" potential memory leak may happen if user space pointer created_timer_id is invallid. or the value it points to is invalid. the call will prematurely return. However it doesn't free the memory it allocates with alloc_posix_timer(). This patch attemps to fix that. Reported-and-tested-by: syzbot+9c47ad18f978d4394986@syzkaller.appspotmail.c= om Closes: https://lore.kernel.org/all/69155df4.a70a0220.3124cb.0017.GAE@googl= e.com/T/ Fixes: ec2d0c04624b3c8a7eb1682e006717fa20cfbe24 ("posix-timers: Provide a m= echanism to allocate a given timer ID") Signed-off-by: Eslam Khafagy --- kernel/time/posix-timers.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index aa3120104a51..46ee10551c63 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -483,11 +483,15 @@ static int do_timer_create(clockid_t which_clock, str= uct sigevent *event, =20 /* Special case for CRIU to restore timers with a given timer ID. */ if (unlikely(current->signal->timer_create_restore_ids)) { - if (copy_from_user(&req_id, created_timer_id, sizeof(req_id))) + if (copy_from_user(&req_id, created_timer_id, sizeof(req_id))) { + posixtimer_free_timer(new_timer); return -EFAULT; + } /* Valid IDs are 0..INT_MAX */ - if ((unsigned int)req_id > INT_MAX) + if ((unsigned int)req_id > INT_MAX) { + posixtimer_free_timer(new_timer); return -EINVAL; + } } =20 /* --=20 2.43.0