From nobody Fri Dec 19 21:51:47 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1BD3074B0 for ; Fri, 14 Nov 2025 09:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763112679; cv=none; b=GMFBuRBiOdmoNHneWXn+71PVxA43Y/+E5gjmMawIm0euFPpBAAUAyH/O57vBXdvGTWfW1Gn5023FvpO0pyKqxzSdkuhfpZ8W0Tsc4rXxpkJVTV90bMfOwSkH9UDGtmekF2Oz3TTv3Yceiyywumu0WfwWlAjThw6MDy/l9AYjF7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763112679; c=relaxed/simple; bh=q0tdVNOipK0Zpcd1nOMTcB1YUnAJWRHGAYSLJd0+tUw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oSS3RB45OPiZM8SI/8E1b50GtJlqGNMFfGZoEwrlshr1vZlx1Mt+mRZKsrGI6IYTn06d7oAZlYkPi/hg2jnY5OJ6bNJqWkzJ4XXTiGb+gKvGk4IvEQPo5RSvt4jtmC1fe9Wah0pZBr0WVFBJAq3oLeOjeS3re4S4Uiz5ZH1LOjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=gR1zIbKF; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="gR1zIbKF" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b73545723ebso279279766b.1 for ; Fri, 14 Nov 2025 01:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1763112674; x=1763717474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X8JMr12gzEjNmdYRXSFO9HGUKWRef+CBtmkwn83lm74=; b=gR1zIbKFr1KabG/XKfdccpKKfRFNJifMWvqmFXIV3ZEyufzgwaU7Ise51Xkyy3X6g9 Zm9Uc6pMtIP2sUanbr8ubnYuVIA1CC5pUWKDOtcDQZXBmDUhYI6WYRCFYe/tePmW+KbX 5j1BWQfNpIVT6Dmio90Vv6hlnaxbOH73WkGZDSUyynIyRe3ibsPO9Zxs4O+gUiCEx+zH ngNrf+NEhTPU+pCRBadJP18IRrZa4XJpVOE7M5Vqg3JM227S2UlvyaK1UQxZsp4Ulcq7 n1UWAYWzxUGL+PtN63Asj8rJlll03aTdRsf/7gds+Rp9h1qY9zm833wu8lL90EdQWGzo erbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763112674; x=1763717474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X8JMr12gzEjNmdYRXSFO9HGUKWRef+CBtmkwn83lm74=; b=Kxcz2BVImngw3uhRJh1c1gx1sDONEAi849XLj6ssi9++cUINNug+8oet/Mab9aEiGT ZVLjhnlueKoPNPR9nZnM9+HVoAQrsh69K5wpGTymm4k9PQE/usKvhu3bh5OszZXDy4Vy Haf0hYqfC+Qg2uLRL5PCyQKsynqkq0gPIGO7EzZs6OLHsa+l54EsW4Mb/IRvMps8E5eU MzTE/4oHRXmaLJHzAU3YxnTyxXefginoiM7KpZbPB7K5QdLr0YQGqBrWRYaWumhc+eeg paH0K4gyyL+eUgpTzoezG4Gm0oYWXR4zw9PksMJUlBc47a2xOK/b7A63wDkROWCCh/tl 7IlQ== X-Forwarded-Encrypted: i=1; AJvYcCUbuVrDPC7+sZGUTRPl67XOCF63oTl2/usONqma4asIcADJfiWw82aDOsQTTfuDJnFjBcC+j7f1AsaVYIE=@vger.kernel.org X-Gm-Message-State: AOJu0YzrE8+LfuiWBIG5dFjoDU3a5niyj0FrUBbbx6P5CUbclMTcM58n QupX8VNEk02+dubGg56f1lJEkv1U8xlVbZ3J/XzTFbNnYSu3SiHxl30oWGLJz2I9uQA= X-Gm-Gg: ASbGncsRh4YLrT+hR3RHex510T7jPu5BTpl7gohoDhjFwM3nBRMN5EcmC6GUj91CSRK S4q5gqnVg4fnbhLGPVetevOBf+0nTbTYd6SUxTgSLCQkKUgEtLVhcM5nRp1rTZiRLxtasJUVktW 0cSv55jSHVZQD4mESS/V2tL6TDGZgSXfvmXiPac0Kf0r/npz00woJ1USe5qT0Zjjy1AXGbv1DIq 9X41/8NMOrAjJbbBb4grrDJX0MlB47VJfLsMUgtXMfn8vE7nTKmd8FE5MEHRksJEnCkrzHXrEPR RMO22TS6jFBko16boXR0JX1iegZCX11ot+zsIgmHzuUbPPCmWXiIy3xDhrq3AjMHWMMfqnaY9zK 8LTjxR9LEnzOoiwoNh8hZB4GyDvfbjKDEwCkpmgZNMBI6Dz2S9kNZiMLihcHXBWYijIE/EUbtMf QW3ZXkXAUbQBMQWRDeI0MfTj5NpA3Kg6SSv7lHuvVQ+/ZyoNWkjbHKphy0xRljQGKhHl7Pt4OY2 iZbuoRHOhGe48DtkIZZXrBJQYPOtQbQ4Q== X-Google-Smtp-Source: AGHT+IFVw6W18ObaGtKJ10Xcu6/Wv8WS6lJaqKvbaiYmoVzwfv2DfFS03nbiscfYrjzyMjgufvOJfQ== X-Received: by 2002:a17:906:794b:b0:b6d:9bab:a7ba with SMTP id a640c23a62f3a-b7367983f21mr198473566b.42.1763112674394; Fri, 14 Nov 2025 01:31:14 -0800 (PST) Received: from [192.168.101.179] (2001-1c04-0509-ec01-156d-fa6e-7f19-0b67.cable.dynamic.v6.ziggo.nl. [2001:1c04:509:ec01:156d:fa6e:7f19:b67]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd80841sm352104366b.41.2025.11.14.01.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 01:31:13 -0800 (PST) From: Luca Weiss Date: Fri, 14 Nov 2025 10:31:09 +0100 Subject: [PATCH v2 1/5] dt-bindings: interconnect: qcom,sm6350-rpmh: Add clocks for QoS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-sm6350-icc-qos-v2-1-6af348cb9c69@fairphone.com> References: <20251114-sm6350-icc-qos-v2-0-6af348cb9c69@fairphone.com> In-Reply-To: <20251114-sm6350-icc-qos-v2-0-6af348cb9c69@fairphone.com> To: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763112672; l=3585; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=q0tdVNOipK0Zpcd1nOMTcB1YUnAJWRHGAYSLJd0+tUw=; b=FAC/10Tl8wr016SZ4IcHv4CK42tFzSJwEkm8di1F3bIXqCBdcMAPpX8vgYbP1x+OpJTVeyIQL wYRjI9Mf+M2Cq785SPpuAuPbLGIfZNanyu0KKe2VDC7KeR5gqXvFHK3 X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Add the clocks for some interconnects to the bindings that are required to set up the QoS correctly. Update one of the examples to aggre2_noc to have an example with clocks. Also while we're at it, remove #interconnect-cells: true as that's already provided from qcom,rpmh-common.yaml. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../bindings/interconnect/qcom,sm6350-rpmh.yaml | 65 ++++++++++++++++++= ---- 1 file changed, 54 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpm= h.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.ya= ml index 49eb156b08e0..2dc16e4293a9 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml @@ -12,9 +12,6 @@ maintainers: description: Qualcomm RPMh-based interconnect provider on SM6350. =20 -allOf: - - $ref: qcom,rpmh-common.yaml# - properties: compatible: enum: @@ -30,7 +27,9 @@ properties: reg: maxItems: 1 =20 - '#interconnect-cells': true + clocks: + minItems: 1 + maxItems: 2 =20 patternProperties: '^interconnect-[a-z0-9\-]+$': @@ -46,8 +45,6 @@ patternProperties: - qcom,sm6350-clk-virt - qcom,sm6350-compute-noc =20 - '#interconnect-cells': true - required: - compatible =20 @@ -57,10 +54,54 @@ required: - compatible - reg =20 +allOf: + - $ref: qcom,rpmh-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre1-noc + then: + properties: + clocks: + items: + - description: aggre UFS PHY AXI clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre2-noc + then: + properties: + clocks: + items: + - description: aggre USB3 PRIM AXI clock + - description: RPMH CC IPA clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre1-noc + - qcom,sm6350-aggre2-noc + then: + required: + - clocks + else: + properties: + clocks: false + unevaluatedProperties: false =20 examples: - | + #include + #include + config_noc: interconnect@1500000 { compatible =3D "qcom,sm6350-config-noc"; reg =3D <0x01500000 0x28000>; @@ -68,14 +109,16 @@ examples: qcom,bcm-voters =3D <&apps_bcm_voter>; }; =20 - system_noc: interconnect@1620000 { - compatible =3D "qcom,sm6350-system-noc"; - reg =3D <0x01620000 0x17080>; + aggre2_noc: interconnect@1700000 { + compatible =3D "qcom,sm6350-aggre2-noc"; + reg =3D <0x01700000 0x1f880>; #interconnect-cells =3D <2>; qcom,bcm-voters =3D <&apps_bcm_voter>; + clocks =3D <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>, + <&rpmhcc RPMH_IPA_CLK>; =20 - clk_virt: interconnect-clk-virt { - compatible =3D "qcom,sm6350-clk-virt"; + compute_noc: interconnect-compute-noc { + compatible =3D "qcom,sm6350-compute-noc"; #interconnect-cells =3D <2>; qcom,bcm-voters =3D <&apps_bcm_voter>; }; --=20 2.51.2