From nobody Tue Feb 10 02:30:25 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB08E3148C6 for ; Fri, 14 Nov 2025 11:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; cv=none; b=UR2K2jMFM9s+LXOJzBUa47IPgNJ05pJtOGA/A0XJ3F2yAM2dd+DzQvn9kw188S9EIWhIv0eTvZW1UigB5CG5i3AtNfQjih9F7P/BW2ESVfRtzhj77ccOyzyY03vFHemJ1dCbDbqMdol4ZO/RclPSWCEzBpZ8X5PiFK7frTLDhdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; c=relaxed/simple; bh=yIx1/2/tttizwM9cUxKlUJvNvvJijTCkS/Ch+ARlNjM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B/nPmLx93uYm/JKIMZZuhgRrV57BOn6ZhmkjlsQ5KNnpN1pgqgvQYlrXcU7cBfW7TAP1wg+oEJs9Z/zaCFd01Hv76mRBFlMn5ocR7/ihCwt/+X5vje6MMi4RRwFJ0pWTMBOEsnzkAIQYlipCjQcA6CBa1aCoUcXf2WOlZakR8Bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=suCaNJe+; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="suCaNJe+" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-64166a57f3bso3011426a12.1 for ; Fri, 14 Nov 2025 03:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763120845; x=1763725645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GC2LO4E6Ag3mJVSI7KVkmGsqAOI0LYR1zjRab2wprm8=; b=suCaNJe+82sVqF5MUnUWTr+C8+0pyNnaRdrYcxM5tXfe47qj9GR5cv9OBZHavrbKh5 V86qZQ085t69O5hybVksVdK5tPf24NSwyIJH2wcTdFG1SfjLSK9uTR5tlOc4bpEFN6UD Y9fcYYp0H3tfPm2WR42Unbw4l0ctMEhl/NzbMpAtWlI/NOyiQrkbRWScT2DwOg/lCuXz YD0OKyVLlme2La5TsAmnB1PmTSnYcUKpLOzX4q4xNGetiW6eXGBrApo/MEuLPuoBHEF2 443W8Jr9pUdIYCCZwgqEJL6vp02+U5XMOtFh4bU2qkYP+OC2ab6/rBcEfNQrARQk+vQS Y1KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763120845; x=1763725645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GC2LO4E6Ag3mJVSI7KVkmGsqAOI0LYR1zjRab2wprm8=; b=WlPZCeNGX/YempLd9C3bPYW4ABFlIpQO6DLZtfxM68oreQDZSvgCaw0TV269Mfg+K0 I0Na0H5VyNyf/tCOwk8KaEQ5TzctDhzEfMYL9UQ+YVP9ALCF296r+VEJ6MLlugE70Zow wIzPOM9tFl8bDowDFpT2JjJNrJzb1F/TdSQzfI+K8um1fQIoxqL3oKdgc2lqep9x8xHj m9TPLxGSqYW+odMpM2Q+72hWYbF6XS96riDKF54RPtiRuRD0h3LoewwKNTJ5C3HPfBXn DUk6CNNxhLUH7N2J4rsLiK1lpUs1s1yNcuMpqHGqymU5vC5BR9dtpVheybmsHXyj+rIh J2aw== X-Forwarded-Encrypted: i=1; AJvYcCXBdwy/yg8qtcS4g1599qk64/6zQL1uj3B8v3iS9LRshIWBy/dOlW6n1x0hLMXiwNQ/IC17g3H5NZZICzw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw47v8mmsFgE1dMRRE/l9cIvczH6I1/T8LtPC4V34Pw/t0FxNpo yO3rhVaZA8hcPF6p7uBRVrzvDTV8Mm9qOIBqaI0kSFsjIdtfL/Vq0bevgEJ3ysvVeC0= X-Gm-Gg: ASbGncsECYQ57mvhXn+WqSuiVWkq3JiqL9cvI2of0GgmMQRx9QuwzirGqydhf5HOxpm UqIHLFQ3uj6BYwcxEy4p97R+WVpJPBlgGK7BsdcxRzxsdacL6VbMNB9Lk0APGk8EjmV6cLhWkSd l4ajQZ5OPEUKP4d4lT1wW8v7bKRhuaNZ8KBRPkKpS5zillbd+S0O8IiZH/3Bqi9FgJNVbBEPO+s HaWx/VG6vLzZSiJ4hV0ehJDOqwmDDh28oiwbvlrHMfHylMn1k228POFel841aJS+IqLGu9fyekH su6k8NusZ86l1Jn6NYTylOUkryRKzEIuoegonZ3gVkjNxAeYnTZpVxUW7hWrwVnMuRqtpoe+5CM bcqtMb1y6J5qhfqeq5om3G/bzc9bdFq7ITpjeP5jG9hOYz4/5fUIbTYVUTW8Alqf5i0fa3gUreG wT/52Gkbsu0qEYYpg1G9o5bct7oVSXJGr8DiMnTqq8fi0xg+3F4cmYu0WtnPcuRYHEoyg= X-Google-Smtp-Source: AGHT+IERx/gqNIuM/Dn5OIg4s10Il0uVrXiSyfX0ztaAPKunstiUftXQBuF4ITb25vKoBq+sjWueDA== X-Received: by 2002:a17:907:3f97:b0:b73:36df:fe7 with SMTP id a640c23a62f3a-b7367829b93mr265910266b.28.1763120844913; Fri, 14 Nov 2025 03:47:24 -0800 (PST) Received: from puffmais2.c.googlers.com (180.192.141.34.bc.googleusercontent.com. [34.141.192.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb11d94sm372950166b.30.2025.11.14.03.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 03:47:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 14 Nov 2025 11:47:23 +0000 Subject: [PATCH 3/3] mfd: sec: drop now unused struct sec_pmic_dev::irq_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s5m-alarm-v1-3-c9b3bebae65f@linaro.org> References: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> In-Reply-To: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This was used only to allow the s5m RTC driver to deal with the alarm IRQ. That driver now uses a different approach to acquire that IRQ, and ::irq_data doesn't need to be kept around anymore. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 5 +++-- drivers/mfd/sec-core.h | 2 +- drivers/mfd/sec-irq.c | 10 ++-------- include/linux/mfd/samsung/core.h | 1 - 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 77370db52a7ba81234136b29f85892f4b197f429..794c4e5398e7dd1a816aff9a655= 9a6c19fec75a5 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -163,6 +163,7 @@ sec_pmic_parse_dt_pdata(struct device *dev) int sec_pmic_probe(struct device *dev, int device_type, unsigned int irq, struct regmap *regmap, struct i2c_client *client) { + struct regmap_irq_chip_data *irq_data; struct sec_platform_data *pdata; const struct mfd_cell *sec_devs; struct sec_pmic_dev *sec_pmic; @@ -187,7 +188,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, =20 sec_pmic->pdata =3D pdata; =20 - ret =3D sec_irq_init(sec_pmic); + ret =3D sec_irq_init(sec_pmic, &irq_data); if (ret) return ret; =20 @@ -240,7 +241,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); + NULL, 0, regmap_irq_get_domain(irq_data)); if (ret) return ret; =20 diff --git a/drivers/mfd/sec-core.h b/drivers/mfd/sec-core.h index 92c7558ab8b0de44a52e028eeb7998e38358cb4c..c639180ea686f4308af3f872cb1= d2209d201b2e7 100644 --- a/drivers/mfd/sec-core.h +++ b/drivers/mfd/sec-core.h @@ -18,6 +18,6 @@ int sec_pmic_probe(struct device *dev, int device_type, u= nsigned int irq, struct regmap *regmap, struct i2c_client *client); void sec_pmic_shutdown(struct device *dev); =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic); +int sec_irq_init(struct sec_pmic_dev *sec_pmic, struct regmap_irq_chip_dat= a **irq_data); =20 #endif /* __SEC_CORE_INT_H */ diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index c5c80b1ba104e6c5a55b442d2f10a8554201a961..05d4cc350a351d994e00ba08f5c= e966d0d5c6a0b 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -253,7 +253,7 @@ static const struct regmap_irq_chip s5m8767_irq_chip = =3D { .ack_base =3D S5M8767_REG_INT1, }; =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic) +int sec_irq_init(struct sec_pmic_dev *sec_pmic, struct regmap_irq_chip_dat= a **irq_data) { const struct regmap_irq_chip *sec_irq_chip; int ret; @@ -302,17 +302,11 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, sec_pmic->irq, IRQF_ONESHOT, - 0, sec_irq_chip, &sec_pmic->irq_data); + 0, sec_irq_chip, irq_data); if (ret) return dev_err_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\n", sec_irq_chip->name); =20 - /* - * The rtc-s5m driver requests S2MPS14_IRQ_RTCA0 also for S2MPS11 - * so the interrupt number must be consistent. - */ - BUILD_BUG_ON(((enum s2mps14_irq)S2MPS11_IRQ_RTCA0) !=3D S2MPS14_IRQ_RTCA0= ); - return 0; } diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index d785e101fe795a5d8f9cccf4ccc4232437e89416..c7c3c8cd8d5f99ef0cc3188e1c3= b49031f4750f2 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -69,7 +69,6 @@ struct sec_pmic_dev { =20 int device_type; int irq; - struct regmap_irq_chip_data *irq_data; }; =20 struct sec_platform_data { --=20 2.52.0.rc1.455.g30608eb744-goog