From nobody Mon Feb 9 03:00:20 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65EE3112DC for ; Fri, 14 Nov 2025 11:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120847; cv=none; b=IjO6lA0STD/V3sPVnpu5b2qI5LixuJ5wYChvWv6z7spGFQAi0czRUdyNeyfp9e3scTjIKmVZ57C77cO9h11R6SGM/+vKDfhbibGrG0aneDqOM3K/wYDkhRp5j5gNiHFvNf0zr0OxHCtD7F/YQfqTvupZ8gv8/0xhGPL560bmf4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120847; c=relaxed/simple; bh=1kTUYewu4Qf6eaZM79yswFLJrKWEOAk1UN22HB6JO80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=abHmyfBEY9al6RKfv4yunJgmgwRRJJKGj+Kz2pdj0igxaj6jk48zRNiSQyTDgGN8njE8qG80xBuoMNHIDBNRKs5dn1v1jr9B3dW3fJXq1u4clOsxMfd+vTHwkD8IAeMTbf6CbyafcIZwxW9HI9TJoPGujUp8Wrbk37IZnfNVhyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G1fk0Mxn; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G1fk0Mxn" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b736ffc531fso65584066b.1 for ; Fri, 14 Nov 2025 03:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763120844; x=1763725644; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=soaPD2TslKdn5T93ESkr8AaM8d+EcG4AUD/8dOpzu/4=; b=G1fk0MxnWo5OkVA15w5p/tW556BXP34u2WNmwRlPT4DJ7deVFTtLx+jIvSNZMNOIbS 9uwAdME1Qqis7RN6BWzamP+SfBAnk+/DBY6CB23zvUIf8hqbJUDrzABbFaBrJ5Nvbfjo yO/ItxBqGUbC4pT0Rzc5hD2Y47s4KEekkFRiCwya1GIvd/xAFJn001Gb/S7M6ZkkQ/mv uytE9vstug57+pQrRZ/id9RXXkHhhNGEszcai1zjKi7m8PnCmEmoAgN91Tc4MiWvI1H6 yQoSyI8EJJnbpbNLZo7LGjej0P20wZCkEOhjecbWp/XB1dsZdK/RfC+HrNyp4gUVt+a/ g/4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763120844; x=1763725644; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=soaPD2TslKdn5T93ESkr8AaM8d+EcG4AUD/8dOpzu/4=; b=nx6jwFCCkUnvZPvwssjHAsbXMDnXWS71rQeKzBO77YN4Rx09+T20cN8MCYQ4F3wVqQ /TjVT2IW9OL7CsTAT7utIp6UXOlziJAJQPTeUlg1fa8jBZKYSNh81/6pF8ox0u4tK+A6 mSC7MegGA/WwM5KEj2DemYAjMVIoczpFaBHV3I1UUn0QHK5Y6ESqIdfAtzB7gCqSl1QS kPkt8utaD99qFTaWrhDByJks2AMGdW8dQZB1yKFo/RxEEOsnbpTfn2v0bLa4diB24f3u zqVyv50AhQc8abE2vUIYoWiR5RqA1qqe2LydTBHKm02K0I3cudPbObTfwiLzGsJwpgxi ZTmA== X-Forwarded-Encrypted: i=1; AJvYcCUgOC35LguNAYCo5xNUPp6R7QtR5wrb7B1h50K5nXSKr9KGByA/9D+r5kuG6jfiM8GSdYwaS4AlYuQH9sA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1p3TBHyvqSvbZvYWb4UAXfNqRKeOO2CkW1z7klUbgc06k76W8 IX/iWbQnijsuC7WtU3NI4DDy5Nt7i7buEm06r9RDTo6j9Y07f+jQNvQ+826zAPCMqq4= X-Gm-Gg: ASbGncuvcao68bQ3auJZzGQcX+Bpj2NfcgE/qeDx6UTGQZ6FiXEBIlOi3kz5aRe5wzd tCuhYD2jNgsvuzT7Hd0PkZLYvwSHWCdCV+sDiOwLnxffp5Fr2WpnC5lJdx2aQJPYvYiRGQIA3qt WVDQoblHBjZLJ0+wU+nJqB7kFPPa7EOKC+A2UdPyuY1QC0Upnk5vWyeDvMZ27m3o31zXppfX49j Cp6DGrMDawfbnp6I5Xoj8QNAtg29PPUmezonbqnB8hkY6YuticVOlqkDBxtB8HX+jlBe5dUvrk+ bLc1lOrtONte8lRLG3hrGRn1e/myiUmQshhysgM4rlOyoqd5cc+JFDW1ApRUVHtqefZN5Z3K0Vo 70/tvupZ2+0VPLousbCZapbtvVTiBYy9SujfN6E01IcidARCf+Wl8xFs8GErpg5z1w4UCh4+Ps3 +hSPyUetDuYYvRmePGpXif5wHIZHtUhB6RLkJfLtT31KBhlrjpGEuR+Zqt8xi9TLMdjrsktjkAM KBCsA== X-Google-Smtp-Source: AGHT+IFJrb5t+LjIPBx5pG10Xi0I9odWXxiMcRtHD1RF7OmqbxPtCtyv5Q78m29q5m+XfKIs1IpaPg== X-Received: by 2002:a17:907:f818:b0:b72:5bdf:6074 with SMTP id a640c23a62f3a-b736780d4ebmr219404666b.20.1763120843860; Fri, 14 Nov 2025 03:47:23 -0800 (PST) Received: from puffmais2.c.googlers.com (180.192.141.34.bc.googleusercontent.com. [34.141.192.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb11d94sm372950166b.30.2025.11.14.03.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 03:47:23 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 14 Nov 2025 11:47:21 +0000 Subject: [PATCH 1/3] mfd: sec: add rtc alarm IRQ as platform device resource Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s5m-alarm-v1-1-c9b3bebae65f@linaro.org> References: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> In-Reply-To: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 By adding the RTC alarm IRQ to the MFD cell as a resource, the child driver (rtc) can simply query that IRQ, instead of having a lookup table itself. This change therefore allows the child driver to be simplified with regards to determining the alarm IRQ. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 42d55e70e34c8d7cd68cddaecc88017e259365b4..77370db52a7ba81234136b29f85= 892f4b197f429 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -23,9 +23,13 @@ #include #include "sec-core.h" =20 +static const struct resource s5m8767_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S5M8767_IRQ_RTCA1, "alarm"), +}; + static const struct mfd_cell s5m8767_devs[] =3D { MFD_CELL_NAME("s5m8767-pmic"), - MFD_CELL_NAME("s5m-rtc"), + MFD_CELL_RES("s5m-rtc", s5m8767_rtc_resources), MFD_CELL_OF("s5m8767-clk", NULL, NULL, 0, 0, "samsung,s5m8767-clk"), }; =20 @@ -33,50 +37,66 @@ static const struct mfd_cell s2dos05_devs[] =3D { MFD_CELL_NAME("s2dos05-regulator"), }; =20 +static const struct resource s2mpg10_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPG10_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpg10_devs[] =3D { MFD_CELL_NAME("s2mpg10-meter"), MFD_CELL_NAME("s2mpg10-regulator"), - MFD_CELL_NAME("s2mpg10-rtc"), + MFD_CELL_RES("s2mpg10-rtc", s2mpg10_rtc_resources), MFD_CELL_OF("s2mpg10-clk", NULL, NULL, 0, 0, "samsung,s2mpg10-clk"), MFD_CELL_OF("s2mpg10-gpio", NULL, NULL, 0, 0, "samsung,s2mpg10-gpio"), }; =20 +static const struct resource s2mps11_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS11_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps11_devs[] =3D { MFD_CELL_NAME("s2mps11-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps11_rtc_resources), MFD_CELL_OF("s2mps11-clk", NULL, NULL, 0, 0, "samsung,s2mps11-clk"), }; =20 +static const struct resource s2mps14_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS14_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps13_devs[] =3D { MFD_CELL_NAME("s2mps13-regulator"), - MFD_CELL_NAME("s2mps13-rtc"), + MFD_CELL_RES("s2mps13-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mps14_devs[] =3D { MFD_CELL_NAME("s2mps14-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps14-clk", NULL, NULL, 0, 0, "samsung,s2mps14-clk"), }; =20 static const struct mfd_cell s2mps15_devs[] =3D { MFD_CELL_NAME("s2mps15-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mpa01_devs[] =3D { MFD_CELL_NAME("s2mpa01-pmic"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), }; =20 static const struct mfd_cell s2mpu02_devs[] =3D { MFD_CELL_NAME("s2mpu02-regulator"), }; =20 +static const struct resource s2mpu05_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPU05_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpu05_devs[] =3D { MFD_CELL_NAME("s2mpu05-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mpu05_rtc_resources), }; =20 static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) @@ -220,7 +240,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, NULL); + NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); if (ret) return ret; =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Mon Feb 9 03:00:20 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A170313526 for ; Fri, 14 Nov 2025 11:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; cv=none; b=ZuQwJQI+qITieltSvwtmh3Gc2jNC4CDRLetIRBNPMJF4pxzVd7j8Of/X8XyiE8HX29CEUi1d6GLVn3FkS5lyPJ9IQyqZJyOsqWu+RmSWY+Zi6p4TGp3lt9Rwl8A1CsOFT1IadkxEbdtkHMIpGsZV87Qq93UHxPI8jvy70dHIPrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; c=relaxed/simple; bh=epAZ4I9cYfPQx/rUTryoD/OTj8bRWME5BL2aIftN33w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NDCxFlXVxLk2YF8uJ+GpeylTjj3JK3KikI5B8z+nJ5h3imazW74rn7uf4fKXuMiyOXpHDupHI34g2sEZWvoxoUzD9DaAdIzvV1FuvmWwmfBTN0wgURZ++nVTamszf7gR4mTuOwZ/vy0SLtKnZC84u2AhwMlj3fDEqA06SmLOkdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pW0YhpL1; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pW0YhpL1" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b728a43e410so293557266b.1 for ; Fri, 14 Nov 2025 03:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763120844; x=1763725644; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c6vZLQTlhnGkC3V5b/JVRIOiHJLrOs5aXHUloOcvWJw=; b=pW0YhpL103/o2GR7CS0MMNel2ctMES/eyIabp0I/4ngyH2tOPc0tBJs0mpb8whmDg4 sCFtij8SYc4Lkyw1MTCYGwl8jlqeZd4G9V78tPO2MCOIXyuD3sZwfLtVVy944OPSdLl+ a2sFpgnHrOaG8623gqvl2UbnWfTU/F/SzZbdd0hgCWwg3f9tTkywBrGS2TMTgJp1TLSD Fot05zonij7pfQDPU/DC07WBoceHj4TunKNL5AnRcf1ielK4g9CpBuyh7u5z8wZ0t+Nc 2Tb/9iDGgN9W8t7nYM2uBH4K0Dx//97sQauRpwVyLGSXXP3nv6MRIvRoqtgp8Fh00A+B vwoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763120844; x=1763725644; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=c6vZLQTlhnGkC3V5b/JVRIOiHJLrOs5aXHUloOcvWJw=; b=VrojWmtsxV6cNWNfXQXX+dkTQeN+xyMq9NztdP+s+2UDJ+ZdrGFqyor+YdTId4J4Ih UAkw84nJjxWgIU8wdOoFxGDu6v/K4B+7YFvRYK1FxJsmQRyMngpjRqR3mpXLFf38Wwsd IFvOEW7atPAmv/awaNxbVBlMgrs6TVbNNqo1VZfdolvzld1fNRo7Cv70cXblfsT/VvNX a+a9sBDTqeSdjUsQs2NSvtnKVJbM1670VJ6QKkmql+dk/cno/O59RNqkzVoSCGgXT1af bQkghcK9C/IxkcXl8qzDIyskiZyaO9fM4hcILNLst7TLshXrcKZXNA0w+b6gr3BI6FPU 5cmQ== X-Forwarded-Encrypted: i=1; AJvYcCVY5NlKN/SJX9+slA1y4GYgJ5ZgFotzLCGaWV3kBXjDwh/eLgf6sLTQqnD6ONxYUOGFtn9e8yK+PiH/wqk=@vger.kernel.org X-Gm-Message-State: AOJu0YzwYUQJ9Jec1n8JUoTyChWtapknlPgIlNi9ncdQMOXxFLpUK/Dl BKnu2/u+FsajZFYkliP7bBk4H43WFh8fWsbtQYTvrV7GWjAEdGEFdCl0dLdnSqd/wXk= X-Gm-Gg: ASbGncuLwSvKp1rj0c9iHpRl2nmIsTxi/Y9mGWuLQ4AFknga2qdeKUqZYYeGbWWvG1e NU90o+UYRt65Xp3ZKKY0A2+wE8O1ugmH3IAHmHhjzwjnD59Ve+K31EI0JaGL1lVyVKTCNZo0lLp rd4IErWd/uFxdQh6VX0MbxLJ+D1IKfCJwiMUmrlvJxvRV8KKWFJN1V4vCTJbhDUadvmFYqzKQmD t9TcIvUUAEl9y/WVa3L950rjKO8GLRGNnMOcvWFa2vN/qpFg2AJGrFP+6c9O5pITCs6enkO2zZX HUf5RDmmk0X3XvzTEx69HjZfH+/QDTd/ROhk9dwBEk9iTOEvEUavmnLNP9+kI0/RcjRaJ+wiCDB DV3ypORf/Def/0xQOY0UvwVokI+0xO5lTa/5HuDUyc6nBlYizfAjuSSOW7+0m/Daixrk7Jka3Jp EFr/lZ48GDkbzT8/mtbjD0FPwkoeaICdtWkbtYnJE2JTvFF6b7KrySsWSZ6iJ4s/40MvErOFHpW 1kJ1Q== X-Google-Smtp-Source: AGHT+IGWfcAafPJXf+nOG04FI28a638seYLqw5MKkweFunN5D3tFLgI80+YDjWlRRIldJ7pB8qo+LA== X-Received: by 2002:a17:907:1c82:b0:b73:4006:1884 with SMTP id a640c23a62f3a-b7367b8d999mr301251266b.37.1763120844396; Fri, 14 Nov 2025 03:47:24 -0800 (PST) Received: from puffmais2.c.googlers.com (180.192.141.34.bc.googleusercontent.com. [34.141.192.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb11d94sm372950166b.30.2025.11.14.03.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 03:47:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 14 Nov 2025 11:47:22 +0000 Subject: [PATCH 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s5m-alarm-v1-2-c9b3bebae65f@linaro.org> References: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> In-Reply-To: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Signed-off-by: Andr=C3=A9 Draszik Acked-by: Alexandre Belloni --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Mon Feb 9 03:00:20 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB08E3148C6 for ; Fri, 14 Nov 2025 11:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; cv=none; b=UR2K2jMFM9s+LXOJzBUa47IPgNJ05pJtOGA/A0XJ3F2yAM2dd+DzQvn9kw188S9EIWhIv0eTvZW1UigB5CG5i3AtNfQjih9F7P/BW2ESVfRtzhj77ccOyzyY03vFHemJ1dCbDbqMdol4ZO/RclPSWCEzBpZ8X5PiFK7frTLDhdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120848; c=relaxed/simple; bh=yIx1/2/tttizwM9cUxKlUJvNvvJijTCkS/Ch+ARlNjM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B/nPmLx93uYm/JKIMZZuhgRrV57BOn6ZhmkjlsQ5KNnpN1pgqgvQYlrXcU7cBfW7TAP1wg+oEJs9Z/zaCFd01Hv76mRBFlMn5ocR7/ihCwt/+X5vje6MMi4RRwFJ0pWTMBOEsnzkAIQYlipCjQcA6CBa1aCoUcXf2WOlZakR8Bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=suCaNJe+; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="suCaNJe+" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-64166a57f3bso3011426a12.1 for ; Fri, 14 Nov 2025 03:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763120845; x=1763725645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GC2LO4E6Ag3mJVSI7KVkmGsqAOI0LYR1zjRab2wprm8=; b=suCaNJe+82sVqF5MUnUWTr+C8+0pyNnaRdrYcxM5tXfe47qj9GR5cv9OBZHavrbKh5 V86qZQ085t69O5hybVksVdK5tPf24NSwyIJH2wcTdFG1SfjLSK9uTR5tlOc4bpEFN6UD Y9fcYYp0H3tfPm2WR42Unbw4l0ctMEhl/NzbMpAtWlI/NOyiQrkbRWScT2DwOg/lCuXz YD0OKyVLlme2La5TsAmnB1PmTSnYcUKpLOzX4q4xNGetiW6eXGBrApo/MEuLPuoBHEF2 443W8Jr9pUdIYCCZwgqEJL6vp02+U5XMOtFh4bU2qkYP+OC2ab6/rBcEfNQrARQk+vQS Y1KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763120845; x=1763725645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GC2LO4E6Ag3mJVSI7KVkmGsqAOI0LYR1zjRab2wprm8=; b=WlPZCeNGX/YempLd9C3bPYW4ABFlIpQO6DLZtfxM68oreQDZSvgCaw0TV269Mfg+K0 I0Na0H5VyNyf/tCOwk8KaEQ5TzctDhzEfMYL9UQ+YVP9ALCF296r+VEJ6MLlugE70Zow wIzPOM9tFl8bDowDFpT2JjJNrJzb1F/TdSQzfI+K8um1fQIoxqL3oKdgc2lqep9x8xHj m9TPLxGSqYW+odMpM2Q+72hWYbF6XS96riDKF54RPtiRuRD0h3LoewwKNTJ5C3HPfBXn DUk6CNNxhLUH7N2J4rsLiK1lpUs1s1yNcuMpqHGqymU5vC5BR9dtpVheybmsHXyj+rIh J2aw== X-Forwarded-Encrypted: i=1; AJvYcCXBdwy/yg8qtcS4g1599qk64/6zQL1uj3B8v3iS9LRshIWBy/dOlW6n1x0hLMXiwNQ/IC17g3H5NZZICzw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw47v8mmsFgE1dMRRE/l9cIvczH6I1/T8LtPC4V34Pw/t0FxNpo yO3rhVaZA8hcPF6p7uBRVrzvDTV8Mm9qOIBqaI0kSFsjIdtfL/Vq0bevgEJ3ysvVeC0= X-Gm-Gg: ASbGncsECYQ57mvhXn+WqSuiVWkq3JiqL9cvI2of0GgmMQRx9QuwzirGqydhf5HOxpm UqIHLFQ3uj6BYwcxEy4p97R+WVpJPBlgGK7BsdcxRzxsdacL6VbMNB9Lk0APGk8EjmV6cLhWkSd l4ajQZ5OPEUKP4d4lT1wW8v7bKRhuaNZ8KBRPkKpS5zillbd+S0O8IiZH/3Bqi9FgJNVbBEPO+s HaWx/VG6vLzZSiJ4hV0ehJDOqwmDDh28oiwbvlrHMfHylMn1k228POFel841aJS+IqLGu9fyekH su6k8NusZ86l1Jn6NYTylOUkryRKzEIuoegonZ3gVkjNxAeYnTZpVxUW7hWrwVnMuRqtpoe+5CM bcqtMb1y6J5qhfqeq5om3G/bzc9bdFq7ITpjeP5jG9hOYz4/5fUIbTYVUTW8Alqf5i0fa3gUreG wT/52Gkbsu0qEYYpg1G9o5bct7oVSXJGr8DiMnTqq8fi0xg+3F4cmYu0WtnPcuRYHEoyg= X-Google-Smtp-Source: AGHT+IERx/gqNIuM/Dn5OIg4s10Il0uVrXiSyfX0ztaAPKunstiUftXQBuF4ITb25vKoBq+sjWueDA== X-Received: by 2002:a17:907:3f97:b0:b73:36df:fe7 with SMTP id a640c23a62f3a-b7367829b93mr265910266b.28.1763120844913; Fri, 14 Nov 2025 03:47:24 -0800 (PST) Received: from puffmais2.c.googlers.com (180.192.141.34.bc.googleusercontent.com. [34.141.192.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb11d94sm372950166b.30.2025.11.14.03.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 03:47:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 14 Nov 2025 11:47:23 +0000 Subject: [PATCH 3/3] mfd: sec: drop now unused struct sec_pmic_dev::irq_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s5m-alarm-v1-3-c9b3bebae65f@linaro.org> References: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> In-Reply-To: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This was used only to allow the s5m RTC driver to deal with the alarm IRQ. That driver now uses a different approach to acquire that IRQ, and ::irq_data doesn't need to be kept around anymore. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 5 +++-- drivers/mfd/sec-core.h | 2 +- drivers/mfd/sec-irq.c | 10 ++-------- include/linux/mfd/samsung/core.h | 1 - 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 77370db52a7ba81234136b29f85892f4b197f429..794c4e5398e7dd1a816aff9a655= 9a6c19fec75a5 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -163,6 +163,7 @@ sec_pmic_parse_dt_pdata(struct device *dev) int sec_pmic_probe(struct device *dev, int device_type, unsigned int irq, struct regmap *regmap, struct i2c_client *client) { + struct regmap_irq_chip_data *irq_data; struct sec_platform_data *pdata; const struct mfd_cell *sec_devs; struct sec_pmic_dev *sec_pmic; @@ -187,7 +188,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, =20 sec_pmic->pdata =3D pdata; =20 - ret =3D sec_irq_init(sec_pmic); + ret =3D sec_irq_init(sec_pmic, &irq_data); if (ret) return ret; =20 @@ -240,7 +241,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); + NULL, 0, regmap_irq_get_domain(irq_data)); if (ret) return ret; =20 diff --git a/drivers/mfd/sec-core.h b/drivers/mfd/sec-core.h index 92c7558ab8b0de44a52e028eeb7998e38358cb4c..c639180ea686f4308af3f872cb1= d2209d201b2e7 100644 --- a/drivers/mfd/sec-core.h +++ b/drivers/mfd/sec-core.h @@ -18,6 +18,6 @@ int sec_pmic_probe(struct device *dev, int device_type, u= nsigned int irq, struct regmap *regmap, struct i2c_client *client); void sec_pmic_shutdown(struct device *dev); =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic); +int sec_irq_init(struct sec_pmic_dev *sec_pmic, struct regmap_irq_chip_dat= a **irq_data); =20 #endif /* __SEC_CORE_INT_H */ diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index c5c80b1ba104e6c5a55b442d2f10a8554201a961..05d4cc350a351d994e00ba08f5c= e966d0d5c6a0b 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -253,7 +253,7 @@ static const struct regmap_irq_chip s5m8767_irq_chip = =3D { .ack_base =3D S5M8767_REG_INT1, }; =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic) +int sec_irq_init(struct sec_pmic_dev *sec_pmic, struct regmap_irq_chip_dat= a **irq_data) { const struct regmap_irq_chip *sec_irq_chip; int ret; @@ -302,17 +302,11 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, sec_pmic->irq, IRQF_ONESHOT, - 0, sec_irq_chip, &sec_pmic->irq_data); + 0, sec_irq_chip, irq_data); if (ret) return dev_err_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\n", sec_irq_chip->name); =20 - /* - * The rtc-s5m driver requests S2MPS14_IRQ_RTCA0 also for S2MPS11 - * so the interrupt number must be consistent. - */ - BUILD_BUG_ON(((enum s2mps14_irq)S2MPS11_IRQ_RTCA0) !=3D S2MPS14_IRQ_RTCA0= ); - return 0; } diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index d785e101fe795a5d8f9cccf4ccc4232437e89416..c7c3c8cd8d5f99ef0cc3188e1c3= b49031f4750f2 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -69,7 +69,6 @@ struct sec_pmic_dev { =20 int device_type; int irq; - struct regmap_irq_chip_data *irq_data; }; =20 struct sec_platform_data { --=20 2.52.0.rc1.455.g30608eb744-goog