From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8D4722A7F1; Thu, 13 Nov 2025 19:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060744; cv=none; b=BA6Q/XpJ+pXV3qcck1wLaTXSR1rh/hKXNdRwwj4Tyi8VpFpxhPYS790skZzL3zCwO9G0tgR3TzPzLNjry88RCNT+q2KFyWgER6IPewM/RLaARALpdXSuEODYHz2abOlRs3fUTnHf+t37mQZpSaXsEpGOu8R28viweycMmpH4+10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060744; c=relaxed/simple; bh=p35Wpg53HadVAf/y3gORD2Wvr0ntA3gYZifzBDsKZRc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GEg3stG5Lw8OjvVukagaj0l4dmmpuCUc1cDfNjGzwlxdtCdiWcDlPujVtZBWQcZsR3PEy7vig1CuLB10B587vABTLl8JmGM60pxBsObYf1AwHp1dKvYxQlNZ0zj27sEOt0XRXenXYRvqWO5AgFQzeC7ActizJEvxZ8qa6Mcr7Og= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=RKNIdMQv; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="RKNIdMQv" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1756925F29; Thu, 13 Nov 2025 20:05:41 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tdMi48DZ0KF8; Thu, 13 Nov 2025 20:05:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060740; bh=p35Wpg53HadVAf/y3gORD2Wvr0ntA3gYZifzBDsKZRc=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=RKNIdMQvhtURGElGtYn+QIQGaxcx0bfR5moiL4+dC6QE0ZpnqWLil8W4s5WCyozz3 /7XXl27TLQmQ9nNUfWZVsWhp/YO7z/1doX8ZJSPiuOfZw4nxlVwJzsSW/zdMNDyUZY e7CiH6GMd46UnIWO2yoCU0wL8ZDAEZUAhfd6X+6UCtQNcdQoRTqxt6C7C2NULC054c RMQ1FUVeu8qeDQnsoze2uYTu0fGb478Uv4vBYs55pB898zcFM5BhEVCy01UTAZ7ybT KiZn7D71KhR9MhdsN/4O55S5Nf6VmeUcg/dVBKAjigjP7CJgRBHizwaMir5RKFBgQ0 yCtF+HhWd5sOg== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:02 +0530 Subject: [PATCH 01/13] dt-bindings: leds: document Samsung S2M series PMIC flash LED device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-1-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=1995; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=p35Wpg53HadVAf/y3gORD2Wvr0ntA3gYZifzBDsKZRc=; b=1duKGgGqKcJx6gWqR+AJaF02HwFjpvL9yDs1tQn+cuXFNxjBYbsbvlDtYSVU+vuwVMoHvUJy3 jrerHm1z1XLAIFrG638FiGviyyKWTAtHo5S4SVgj/i2wtCOlw108cWJ X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Certain Samsung S2M series PMICs have a flash LED controller with two LED channels, and with torch and flash control modes. Document the devicetree schema for the device. The initial driver introduced has support for S2MU005, add its compatible as well. Signed-off-by: Kaustabh Chakraborty Acked-by: Conor Dooley --- .../bindings/leds/samsung,s2mu005-flash.yaml | 52 ++++++++++++++++++= ++++ 1 file changed, 52 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/samsung,s2mu005-flash.y= aml b/Documentation/devicetree/bindings/leds/samsung,s2mu005-flash.yaml new file mode 100644 index 000000000000..496385003a03 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/samsung,s2mu005-flash.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/samsung,s2mu005-flash.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Flash and Torch LED Driver for Samsung S2M series PMICs + +maintainers: + - Kaustabh Chakraborty + +description: | + The Samsung S2M series PMIC flash LED has two led channels (typically + as back and front camera flashes), with support for both torch and + flash modes. + + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +properties: + compatible: + enum: + - samsung,s2mu005-flash + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-1]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + enum: [0, 1] + + required: + - reg + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6346B7262D; Thu, 13 Nov 2025 19:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060754; cv=none; b=SlGib0J+HPXb/OCe3oB3VopCi7nxP5IGmqmL6w1OyOiYhD9CvrsOniiXPg5F/ht/SjCAEVieOMBzYcXYtPWMIzklD6Iz8tqtXTmhsR0Q+LcQl9Vwb9cjOjioJeKYitnFTfEA7KrKhWWAx/8Zc77WlieyookWg0paBg8QBDvP5F8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060754; c=relaxed/simple; bh=ffOLkRZ/7cBjGhLuCW214Ny9asZLrXHQNlgnuSxjMlo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e5jDUPlPFEb19ejBF+/d9LL2ycz7HaRngM+stgvWxt0PBaFesl6tE9IBHdquP7E2yXZRyVfi2aJEJVif/EHoVlkCf6h879/HLKERzXVbOL0OFOEuEq1Ui2FGEwmW/ehHvC0fGbkWrlUAD6tjWXkBCWsxOP541XIaj4F9kIY7FBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=OBvj3r/f; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="OBvj3r/f" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B8AF526746; Thu, 13 Nov 2025 20:05:51 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4ZPF9h_X-kO2; Thu, 13 Nov 2025 20:05:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060750; bh=ffOLkRZ/7cBjGhLuCW214Ny9asZLrXHQNlgnuSxjMlo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=OBvj3r/fDZ5EaCfelzXeavzDRersu5GlRjMZEcWCrT8C6e7f0SRgEoiAOQBB1Ry4A TWS1pbBM6fjFBEnatYpRGCqKsBVpOF4qqS0U3a2d9qXvrxgAdQZrguF2LWqweJyZCn 1JzJ0M2XgubK9o8OO7LMScL03mqScX3DZ5ZbwNq/uoyO4Zg07UON4mhAhSG8NTWKOa TI3kUWgjDTmCwt56kNNBK0qiY9W/+7HcuL2SMR+1QSwaKMP/vFmvsJgHJAQ04GZgJA FmNSc2hpBLqVdGi1UsuJ91uTmhuwkbA9+iclGS6boD8VBUkPSUiM8g2pRkM+tIYY1h n80EJrN0JhDSg== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:03 +0530 Subject: [PATCH 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-2-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=1749; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=ffOLkRZ/7cBjGhLuCW214Ny9asZLrXHQNlgnuSxjMlo=; b=m+avgylS0Nhr4hfYEuWiKa1iNJQ6hvPlfRnRGB8PsaA/MhjWpksbtv3DXqmt6Jx52fHn8OmtX F8YTmVl/TV0A2wU2Ntyh6Gt5d6/O3LNJ8/qoyP5gZGfl7y2L0Fo1yAM X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Certain Samsung S2M series PMICs have a three-channel LED device with independent brightness control for each channel, typically used as status indicators in mobile phones. Document the devicetree schema from this driver. The initial driver introduced has support for S2MU005, add its compatible as well. Signed-off-by: Kaustabh Chakraborty --- .../bindings/leds/samsung,s2mu005-rgb.yaml | 34 ++++++++++++++++++= ++++ 1 file changed, 34 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yam= l b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml new file mode 100644 index 000000000000..bad7080ff8f5 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml @@ -0,0 +1,34 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/samsung,s2mu005-rgb.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RGB LED Driver for Samsung S2M series PMICs + +maintainers: + - Kaustabh Chakraborty + +description: | + The Samsung S2M series PMIC RGB LED is a three-channel LED device with + 8-bit brightness control for each channel, typically used as status + indicators in mobile phones. + + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + enum: + - samsung,s2mu005-rgb + +required: + - compatible + +unevaluatedProperties: false --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86EA4318131; Thu, 13 Nov 2025 19:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060768; cv=none; b=n9G47VMFLzMFjSObaPAECwvxtRlkIlRD2T0z2SxwkkiLQkraWrQUD4UjtVgRTyvuRqho2mi80NgikG5hesWHZRNCnRflpvCs8LdfeKS3x6oI5u7b8LQFHWGvOzonTS3CpNhsNSRSXc22OlJ7S35qQD0eXWEry0jw6M3+PR13Nyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060768; c=relaxed/simple; bh=2A0vaYHCECUQ8MIA/pdIwcaIxh6KIsr0+Y/dQwxtdiQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hh8Eu6mXDnuYDYpgq6wGKgtjmZdDzMjOV5VLeQ9xtGqQ7WCnlgCeUff+/2dGrL9Pp8azCCKeDK37+csmCeOvOmA/o7mKJk6TK2fDTIRvlOU94W4thEVzLiYz+htxYUFddS26DpFvRG1eLbaDfaZ9AC8EXfO22wNpNxhIs41SOzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=ISqtjWYc; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="ISqtjWYc" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id F093926774; Thu, 13 Nov 2025 20:06:04 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id c989Gpoc3-Mv; Thu, 13 Nov 2025 20:06:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060764; bh=2A0vaYHCECUQ8MIA/pdIwcaIxh6KIsr0+Y/dQwxtdiQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=ISqtjWYcW5uA6iqahaqIwog/2uqJve+G8WgjVrYwTy2kCbARG+XK8x4pcwx4gy3Yq qLh6tUeDhReY9He6wbkVGA8ng6+WUp6Uao78xX+xKVesU1UZ1tYJvLbgwKxfdYnFMg PunRmIRU2bAsW3Bn0OVnDic313xbvtsfnn1jxZT5vuUdBERknQ+3ron2rLCBunWOUW Cm0n7Wc+MXXtZ2aaWIt2++pdLtBG6aVZFnXFupHiFT8CLP8FX6eD9dP8KHLhQli1qd vqhbSBtwUu3C4z8NY+wSciolchZa+EEeotAONS6DF+Fh2pI6GnRqtO2ulIDJlQkc8x 6JfvxBsyf0Kdg== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:04 +0530 Subject: [PATCH 03/13] dt-bindings: extcon: document Samsung S2M series PMIC extcon device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-3-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=1764; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=2A0vaYHCECUQ8MIA/pdIwcaIxh6KIsr0+Y/dQwxtdiQ=; b=7vxIfbS2a86BEBcXUa8Q40B6lntie/YP9dyd6uLHB9SUBtSvOApAVyxC0kn0L350hUhQQpv9a clU35Nm9mL/DT/mETKMqYrFUJBzxU2XGgYmS8ENZ2+Zl+jpDtVKVNqD X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Certain Samsung S2M series PMICs have a MUIC device which reports various cable states by measuring the ID-GND resistance with an internal ADC. Document the devicetree schema for this device. The initial driver introduced has support for S2MU005, add its compatible as well. Signed-off-by: Kaustabh Chakraborty --- .../bindings/extcon/samsung,s2mu005-muic.yaml | 35 ++++++++++++++++++= ++++ 1 file changed, 35 insertions(+) diff --git a/Documentation/devicetree/bindings/extcon/samsung,s2mu005-muic.= yaml b/Documentation/devicetree/bindings/extcon/samsung,s2mu005-muic.yaml new file mode 100644 index 000000000000..8511bb96b47a --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/samsung,s2mu005-muic.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/extcon/samsung,s2mu005-muic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Extcon Driver for Samsung S2M series PMICs + +maintainers: + - Kaustabh Chakraborty + +description: | + The Samsung S2M series PMIC extcon device is a USB port accessory + detector. It reports multiple states depending on the ID-GND + resistance measured by an internal ADC. + + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +properties: + compatible: + enum: + - samsung,s2mu005-muic + + port: + $ref: /schemas/graph.yaml#/properties/port + +required: + - compatible + - port + +additionalProperties: false --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C8BF318131; Thu, 13 Nov 2025 19:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060777; cv=none; b=Ln6BnU7gLSFxZdKm5ZzuWp8riadpSuM0nTlBYgzXulc75c04SUiTEnVLSuUvO3DFECJnwpzeN6fNGqFjn6AYM25P8CPLaZiCYdek0pJCS4Q0UBw1X/2N+Kq4rhRU+U/UmQCwaQB0aiH7yQTiKx0jGGWSdKLZqqgYQX2+KTe9cNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060777; c=relaxed/simple; bh=5FNwlUMck66ibENDTF/wvOSl606brZH0+kglqdmd2yA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d/g7W+7uePLHPlmb54h6rTaJhJJSQD8SwhS2cBlEhQlFyzJid7j1FKQb8rUwh89hhprhQS2e28W+yFfzfcLPaPl2mpYs6nxkyS1mn8wj/IeMlxN/0CPGRnJmZGzTDDgwpkxhtvLVvqjHCeyhYpX82iMAZSuFkEc69i2A9LBquKQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=j3FOhaFn; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="j3FOhaFn" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B2CBE26715; Thu, 13 Nov 2025 20:06:14 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OYT87sDU0UDO; Thu, 13 Nov 2025 20:06:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060773; bh=5FNwlUMck66ibENDTF/wvOSl606brZH0+kglqdmd2yA=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=j3FOhaFnd7kUuP+A/L8E9sTa0/h9lYUUoHB09oLDatUTMiBWzvQxrv9HWshAgaZY3 sJ3yux4UJmrzvjx+Hzr6KWSKkIAqJ4IH6LKKZ+K/Q0pfWBkGS77fCo9SOdc3F7J8h0 ghEjDtqaCqD/p0UO4waztjGgRwEIr9l6cQwMf74ynUHXYGj5lSzxdzfF3ghmGHLtoi d/l3D0YCyAl+7jDg/Uml7QPr7F1ZcqnM+GiJvHBMCkkYgA96nVt7en8QsucXRquqs+ HRQEhahNTsC6bn5r0AQK9v7imz4un1AOoITBgtTMLgGn5NQrkQrdHJ11dMrsGyeouy xpH/RsPmOJssw== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:05 +0530 Subject: [PATCH 04/13] dt-bindings: power: supply: document Samsung S2M series PMIC charger device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-4-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=1991; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=5FNwlUMck66ibENDTF/wvOSl606brZH0+kglqdmd2yA=; b=/rgPRmJbUWtoTa+xBitTvM7xRSzqUo4FD2voBD6lgnY1G9qD9+nlRGRuCqqcrVpbn+lIGIBio ISj27oCVGqIANZ35U6VCzSXldIGg+avmwqYXP1ggWPOkU2jpATTzk2Z X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Certain Samsung S2M series PMICs have a battery charger device which, among other things, manages power interfacing of the USB port. It may supply power, as done in USB OTG operation mode, or it may accept power and redirect it to the battery fuelgauge for charging. This driver depends on the MUIC device present in the same PMIC block. The initial driver introduced has support for S2MU005, add its compatible as well. Signed-off-by: Kaustabh Chakraborty --- .../power/supply/samsung,s2mu005-charger.yaml | 35 ++++++++++++++++++= ++++ 1 file changed, 35 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/samsung,s2mu005= -charger.yaml b/Documentation/devicetree/bindings/power/supply/samsung,s2mu= 005-charger.yaml new file mode 100644 index 000000000000..80292d6e2562 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/samsung,s2mu005-charge= r.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/samsung,s2mu005-charger.ya= ml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Battery Charger Driver for Samsung S2M series PMICs + +maintainers: + - Kaustabh Chakraborty + +description: | + The Samsung S2M series PMIC battery charger manages power interfacing + of the USB port. It may supply power, as done in USB OTG operation + mode, or it may accept power and redirect it to the battery fuelgauge + for charging. + + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +allOf: + - $ref: power-supply.yaml# + +properties: + compatible: + enum: + - samsung,s2mu005-charger + +required: + - compatible + +unevaluatedProperties: false --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F9E3195E7; Thu, 13 Nov 2025 19:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060789; cv=none; b=Zqw0JTVKgGD2SukOyMeE2o/Bb4UiXq910JjSWaoy8NPMEvkoIzFCrMZ/e96+ku+uiczFQeqlqz08MT7pfONzxMarG22g2N0ycMMgt3XyVkTPoBQ7HHGqrYnGShIH4dRxoIs/AgB9SJl3Oi1qFZkwJKHcGEj1NcGlfk9pEsdSkZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060789; c=relaxed/simple; bh=EJ/+SlcFBg6eyfXaWGPrB6FJ2pXIZRWt1+9hWtofYIo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ffIOG2SkjD1ySeswaRJbaun8aUS/z4cmlPcmwRHHh+6YpwwPmWr+NytBgiz7lEJm+BoAGTeOQ1m2uEK0P1dFInmx0Isput1Uzr+Esz13SpWnGUHxk79n4/TrrY9zv6pOcXq5Y58Ly14pyMwy6iUzhC7GQNmiVgrUtVaqbtnWTg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=A7kde7cw; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="A7kde7cw" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 546C72674D; Thu, 13 Nov 2025 20:06:26 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id p0J_MNiE_R_g; Thu, 13 Nov 2025 20:06:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060785; bh=EJ/+SlcFBg6eyfXaWGPrB6FJ2pXIZRWt1+9hWtofYIo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=A7kde7cwyPuSm0upZMlmzgi0J6+xQ8jeKODbPzzcjDS0bl69x3Z+G3kfFiJXA7fhf Np7mhkBgcqfru7CDuLYH6ZUO3AgqwclhoGjRZ6mzWTFnEQhM6q8qbqlutM1UlE8h2k PueoF2usqvRKCmyUQVj8LNWSifiTw5sWjGcwzcNkmrpTMbJnaJe/YYak4vCVbNdHsy decltP0oTE1YKVzs2yFLfZP4LkOjYlF5yhJcVaBrc28Jj9nQHPiE88kqYCWykfdAwY Z1jk6uWBXLcSCRLO/KVZa2oo9wkwobMIawqSI3s3g7h1TFId6dt0BVW60+bhnE8ZgV Vec223S8Hk9dQ== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:06 +0530 Subject: [PATCH 05/13] dt-bindings: mfd: s2mps11: add documentation for S2MU005 PMIC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-5-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=5753; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=EJ/+SlcFBg6eyfXaWGPrB6FJ2pXIZRWt1+9hWtofYIo=; b=WduHYbWTepjUPsCxB38vQmxEE9ggCzi15TEDxWsURB/GcxQ6ZjzXOeV/WXbeiccbemNej1LUd JricGDBHpSlBMOPUGKZYwdeJCoOsogeTpVK/j6E6iGDfNJ1bkn+DGtw X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro USB Interface Controller), and flash and RGB LED controllers. Since regulators are not supported by this device, unmark this property as required and instead set this in a per-device basis for ones which need it. Add the compatible and documentation for the S2MU005 PMIC. Also, add an example for nodes for supported sub-devices, i.e. charger, extcon, flash, and rgb. Signed-off-by: Kaustabh Chakraborty --- .../devicetree/bindings/mfd/samsung,s2mps11.yaml | 103 +++++++++++++++++= +++- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml b/D= ocumentation/devicetree/bindings/mfd/samsung,s2mps11.yaml index 31d544a9c05c..aef634ca2e36 100644 --- a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml @@ -27,12 +27,28 @@ properties: - samsung,s2mps15-pmic - samsung,s2mpu02-pmic - samsung,s2mpu05-pmic + - samsung,s2mu005-pmic =20 clocks: $ref: /schemas/clock/samsung,s2mps11.yaml description: Child node describing clock provider. =20 + charger: + $ref: /schemas/power/supply/samsung,s2m-charger.yaml + description: + Child node describing battery charger device. + + extcon: + $ref: /schemas/extcon/samsung,s2m-muic.yaml + description: + Child node describing extcon device. + + flash: + $ref: /schemas/leds/samsung,s2m-flash.yaml + description: + Child node describing flash LEDs. + interrupts: maxItems: 1 =20 @@ -44,6 +60,11 @@ properties: description: List of child nodes that specify the regulators. =20 + rgb: + $ref: /schemas/leds/samsung,s2m-rgb.yaml + description: + Child node describing RGB LEDs. + samsung,s2mps11-acokb-ground: description: | Indicates that ACOKB pin of S2MPS11 PMIC is connected to the ground = so @@ -65,7 +86,6 @@ properties: =20 required: - compatible - - regulators =20 additionalProperties: false =20 @@ -105,6 +125,8 @@ allOf: regulators: $ref: /schemas/regulator/samsung,s2mps11.yaml samsung,s2mps11-wrstbi-ground: false + required: + - regulators =20 - if: properties: @@ -116,6 +138,8 @@ allOf: regulators: $ref: /schemas/regulator/samsung,s2mps13.yaml samsung,s2mps11-acokb-ground: false + required: + - regulators =20 - if: properties: @@ -128,6 +152,8 @@ allOf: $ref: /schemas/regulator/samsung,s2mps14.yaml samsung,s2mps11-acokb-ground: false samsung,s2mps11-wrstbi-ground: false + required: + - regulators =20 - if: properties: @@ -140,6 +166,8 @@ allOf: $ref: /schemas/regulator/samsung,s2mps15.yaml samsung,s2mps11-acokb-ground: false samsung,s2mps11-wrstbi-ground: false + required: + - regulators =20 - if: properties: @@ -152,6 +180,8 @@ allOf: $ref: /schemas/regulator/samsung,s2mpu02.yaml samsung,s2mps11-acokb-ground: false samsung,s2mps11-wrstbi-ground: false + required: + - regulators =20 - if: properties: @@ -164,6 +194,18 @@ allOf: $ref: /schemas/regulator/samsung,s2mpu05.yaml samsung,s2mps11-acokb-ground: false samsung,s2mps11-wrstbi-ground: false + required: + - regulators + + - if: + properties: + compatible: + contains: + const: samsung,s2mu005-pmic + then: + properties: + samsung,s2mps11-acokb-ground: false + samsung,s2mps11-wrstbi-ground: false =20 examples: - | @@ -305,3 +347,62 @@ examples: }; }; }; + + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + pmic@3d { + compatible =3D "samsung,s2mu005-pmic"; + reg =3D <0x3d>; + interrupt-parent =3D <&gpa2>; + interrupts =3D <7 IRQ_TYPE_LEVEL_LOW>; + + charger { + compatible =3D "samsung,s2mu005-charger"; + monitored-battery =3D <&battery>; + }; + + extcon { + compatible =3D "samsung,s2mu005-muic"; + + port { + muic_to_usb: endpoint { + remote-endpoint =3D <&usb_to_muic>; + }; + }; + }; + + flash { + compatible =3D "samsung,s2mu005-flash"; + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@0 { + reg =3D <0>; + label =3D "back-cam:white:flash"; + color =3D ; + function =3D LED_FUNCTION_FLASH; + }; + + led@1 { + reg =3D <1>; + label =3D "front-cam:white:flash"; + color =3D ; + function =3D LED_FUNCTION_FLASH; + }; + }; + + rgb { + compatible =3D "samsung,s2mu005-rgb"; + label =3D "notification:rgb:indicator"; + color =3D ; + function =3D LED_FUNCTION_INDICATOR; + linux,default-trigger =3D "pattern"; + }; + }; + }; --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B3D331961F; Thu, 13 Nov 2025 19:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060805; cv=none; b=MXCkkbsXxdeFc/Y3fVREBrPsR5xpnMk2jR5yBAIAu57FycODbigH2iCMMJ98tlXsFEnnVMbcgZil3uKppYDXGc3vr9RUO7UlMPgVDivyKi7sFoKHkWL849AdLZ3kF8+T/X/KZv639gNMGOIKGQ6w+xo5JmiA0f0OmVj6Sj2pQtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060805; c=relaxed/simple; bh=U4EhmV2PN5Yp0pSdaEb4ukrPp7hCwT8GdTlgZ0mf/nU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YXF+6HxSMGhkKFjkrbNd11S5NzZgWthtDmhB9FJFzGImp6nMduaEwj12b7bTVEmRoQIZuxBm9tFWIeeBdikrM/R6qQrr+BnBFEAwmd5OueHqtfHzJ3gF5VaC9aqVYCXM+R1hHlmf181eUBzmWA7khMcUmqUeXSPpErYGxRYWhIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=Yac05re/; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="Yac05re/" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6751926712; Thu, 13 Nov 2025 20:06:41 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HaOQiSiThHid; Thu, 13 Nov 2025 20:06:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060800; bh=U4EhmV2PN5Yp0pSdaEb4ukrPp7hCwT8GdTlgZ0mf/nU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Yac05re/PnMSti66cgs4vw6VUIE1QXY00XoXyIKEgkivdbUaanI4Jd479+P5WNJ8D lZ1rnEUNrO05lQ4jV9B98e83wVEO/eW/K2RPTPcUHOwZ8dmJVAHxVQO20R3HClt1Yo sI1VJ69a3nEgCVa5iMHFgv3j3pCqprjSWUfqq5csNu7IBje8RngM7668cJWXgkWWCO k87dLrNmSVH0wEPtQnim0/BdCBq4BVDlF9enBa4d9OSxTajAYONP2oaLHMlSrrLudW nfF7Q2FzFbVLuHYqAj5y3tKM/UbUpGoMXtA49wrdSBMFXu/vSntSpUMP2zVmAsUVK7 6JeOwyuha1GpQ== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:07 +0530 Subject: [PATCH 06/13] mfd: sec-irq: add support for creating multiple IRQ chips Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-6-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=12500; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=U4EhmV2PN5Yp0pSdaEb4ukrPp7hCwT8GdTlgZ0mf/nU=; b=7Z86uSdtT+4G9Y+0nAMDqJsSWX+sPiRTNtQtE9Cfjp70vqv3ni56UwDi/LutMe9hQdFi6ppfq CciBXf5AskwDgVHUNJrZhWjeTxRg+406Mu0ptj+kuHrJ+UEzUaPVjFt X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The current state of the driver only allows creating only one IRQ chip per PMIC. On some PMICs, such as Samsung's S2MU005, there are multiple interrupt blocks, for which the current implementation stands insufficient. Add support for creating multiple IRQ chips for a PMIC. Every IRQ chip is given it's own index, which is used by sub-device drivers to request IRQs. A macro is defined which states the maximum number of chips supported. It's set to 1 as currently, no PMIC requires more than one IRQ chip. The value must be changed accordingly on adding new PMICs requiring multiple IRQ chips. Moreover, adjust the s5m RTC driver to initialize IRQs with the appropriate IRQ chip index. Signed-off-by: Kaustabh Chakraborty Acked-by: Alexandre Belloni --- drivers/mfd/sec-irq.c | 163 +++++++++++++++++++++++------------= ---- drivers/rtc/rtc-s5m.c | 15 +++- include/linux/mfd/samsung/core.h | 5 +- include/linux/mfd/samsung/irq.h | 14 ++++ 4 files changed, 127 insertions(+), 70 deletions(-) diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index c5c80b1ba104..053c28f31ec9 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -181,25 +181,31 @@ static const struct regmap_irq s5m8767_irqs[] =3D { }; =20 /* All S2MPG10 interrupt sources are read-only and don't require clearing = */ -static const struct regmap_irq_chip s2mpg10_irq_chip =3D { - .name =3D "s2mpg10", - .irqs =3D s2mpg10_irqs, - .num_irqs =3D ARRAY_SIZE(s2mpg10_irqs), - .num_regs =3D 6, - .status_base =3D S2MPG10_PMIC_INT1, - .mask_base =3D S2MPG10_PMIC_INT1M, +static const struct regmap_irq_chip s2mpg10_irq_chip[] =3D { + [S2MPG10_IRQ_CHIP] =3D { + .name =3D "s2mpg10", + .irqs =3D s2mpg10_irqs, + .num_irqs =3D ARRAY_SIZE(s2mpg10_irqs), + .num_regs =3D 6, + .status_base =3D S2MPG10_PMIC_INT1, + .mask_base =3D S2MPG10_PMIC_INT1M, + }, }; =20 -static const struct regmap_irq_chip s2mps11_irq_chip =3D { - .name =3D "s2mps11", - .irqs =3D s2mps11_irqs, - .num_irqs =3D ARRAY_SIZE(s2mps11_irqs), - .num_regs =3D 3, - .status_base =3D S2MPS11_REG_INT1, - .mask_base =3D S2MPS11_REG_INT1M, - .ack_base =3D S2MPS11_REG_INT1, +static const struct regmap_irq_chip s2mps11_irq_chip[] =3D { + [S2MPS11_IRQ_CHIP] =3D { + .name =3D "s2mps11", + .irqs =3D s2mps11_irqs, + .num_irqs =3D ARRAY_SIZE(s2mps11_irqs), + .num_regs =3D 3, + .status_base =3D S2MPS11_REG_INT1, + .mask_base =3D S2MPS11_REG_INT1M, + .ack_base =3D S2MPS11_REG_INT1, + }, }; =20 +#define S2MPS1X_IRQ_CHIP S2MPS14_IRQ_CHIP + #define S2MPS1X_IRQ_CHIP_COMMON_DATA \ .irqs =3D s2mps14_irqs, \ .num_irqs =3D ARRAY_SIZE(s2mps14_irqs), \ @@ -208,85 +214,106 @@ static const struct regmap_irq_chip s2mps11_irq_chip= =3D { .mask_base =3D S2MPS14_REG_INT1M, \ .ack_base =3D S2MPS14_REG_INT1 \ =20 -static const struct regmap_irq_chip s2mps13_irq_chip =3D { - .name =3D "s2mps13", - S2MPS1X_IRQ_CHIP_COMMON_DATA, +static const struct regmap_irq_chip s2mps13_irq_chip[] =3D { + [S2MPS1X_IRQ_CHIP] =3D { + .name =3D "s2mps13", + S2MPS1X_IRQ_CHIP_COMMON_DATA, + }, }; =20 -static const struct regmap_irq_chip s2mps14_irq_chip =3D { - .name =3D "s2mps14", - S2MPS1X_IRQ_CHIP_COMMON_DATA, +static const struct regmap_irq_chip s2mps14_irq_chip[] =3D { + [S2MPS1X_IRQ_CHIP] =3D { + .name =3D "s2mps14", + S2MPS1X_IRQ_CHIP_COMMON_DATA, + }, }; =20 -static const struct regmap_irq_chip s2mps15_irq_chip =3D { - .name =3D "s2mps15", - S2MPS1X_IRQ_CHIP_COMMON_DATA, +static const struct regmap_irq_chip s2mps15_irq_chip[] =3D { + [S2MPS1X_IRQ_CHIP] =3D { + .name =3D "s2mps15", + S2MPS1X_IRQ_CHIP_COMMON_DATA, + }, }; =20 -static const struct regmap_irq_chip s2mpu02_irq_chip =3D { - .name =3D "s2mpu02", - .irqs =3D s2mpu02_irqs, - .num_irqs =3D ARRAY_SIZE(s2mpu02_irqs), - .num_regs =3D 3, - .status_base =3D S2MPU02_REG_INT1, - .mask_base =3D S2MPU02_REG_INT1M, - .ack_base =3D S2MPU02_REG_INT1, +static const struct regmap_irq_chip s2mpu02_irq_chip[] =3D { + [S2MPU02_IRQ_CHIP] =3D { + .name =3D "s2mpu02", + .irqs =3D s2mpu02_irqs, + .num_irqs =3D ARRAY_SIZE(s2mpu02_irqs), + .num_regs =3D 3, + .status_base =3D S2MPU02_REG_INT1, + .mask_base =3D S2MPU02_REG_INT1M, + .ack_base =3D S2MPU02_REG_INT1, + }, }; =20 -static const struct regmap_irq_chip s2mpu05_irq_chip =3D { - .name =3D "s2mpu05", - .irqs =3D s2mpu05_irqs, - .num_irqs =3D ARRAY_SIZE(s2mpu05_irqs), - .num_regs =3D 3, - .status_base =3D S2MPU05_REG_INT1, - .mask_base =3D S2MPU05_REG_INT1M, - .ack_base =3D S2MPU05_REG_INT1, +static const struct regmap_irq_chip s2mpu05_irq_chip[] =3D { + [S2MPU05_IRQ_CHIP] =3D { + .name =3D "s2mpu05", + .irqs =3D s2mpu05_irqs, + .num_irqs =3D ARRAY_SIZE(s2mpu05_irqs), + .num_regs =3D 3, + .status_base =3D S2MPU05_REG_INT1, + .mask_base =3D S2MPU05_REG_INT1M, + .ack_base =3D S2MPU05_REG_INT1, + }, }; =20 -static const struct regmap_irq_chip s5m8767_irq_chip =3D { - .name =3D "s5m8767", - .irqs =3D s5m8767_irqs, - .num_irqs =3D ARRAY_SIZE(s5m8767_irqs), - .num_regs =3D 3, - .status_base =3D S5M8767_REG_INT1, - .mask_base =3D S5M8767_REG_INT1M, - .ack_base =3D S5M8767_REG_INT1, +static const struct regmap_irq_chip s5m8767_irq_chip[] =3D { + [S5M8767_IRQ_CHIP] =3D { + .name =3D "s5m8767", + .irqs =3D s5m8767_irqs, + .num_irqs =3D ARRAY_SIZE(s5m8767_irqs), + .num_regs =3D 3, + .status_base =3D S5M8767_REG_INT1, + .mask_base =3D S5M8767_REG_INT1M, + .ack_base =3D S5M8767_REG_INT1, + }, }; =20 int sec_irq_init(struct sec_pmic_dev *sec_pmic) { const struct regmap_irq_chip *sec_irq_chip; - int ret; + int sec_irq_chip_num, i, ret; =20 switch (sec_pmic->device_type) { case S5M8767X: - sec_irq_chip =3D &s5m8767_irq_chip; + sec_irq_chip =3D s5m8767_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s5m8767_irq_chip); break; case S2DOS05: return 0; case S2MPA01: - sec_irq_chip =3D &s2mps14_irq_chip; + sec_irq_chip =3D s2mps14_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mps14_irq_chip); break; case S2MPG10: - sec_irq_chip =3D &s2mpg10_irq_chip; + sec_irq_chip =3D s2mpg10_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mpg10_irq_chip); break; case S2MPS11X: - sec_irq_chip =3D &s2mps11_irq_chip; + sec_irq_chip =3D s2mps11_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mps11_irq_chip); break; case S2MPS13X: - sec_irq_chip =3D &s2mps13_irq_chip; + sec_irq_chip =3D s2mps13_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mps13_irq_chip); break; case S2MPS14X: - sec_irq_chip =3D &s2mps14_irq_chip; + sec_irq_chip =3D s2mps14_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mps14_irq_chip); break; case S2MPS15X: - sec_irq_chip =3D &s2mps15_irq_chip; + sec_irq_chip =3D s2mps15_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mps15_irq_chip); break; case S2MPU02: - sec_irq_chip =3D &s2mpu02_irq_chip; + sec_irq_chip =3D s2mpu02_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mpu02_irq_chip); break; case S2MPU05: - sec_irq_chip =3D &s2mpu05_irq_chip; + sec_irq_chip =3D s2mpu05_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mpu05_irq_chip); break; default: return dev_err_probe(sec_pmic->dev, -EINVAL, @@ -300,13 +327,19 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) return 0; } =20 - ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, - sec_pmic->irq, IRQF_ONESHOT, - 0, sec_irq_chip, &sec_pmic->irq_data); - if (ret) - return dev_err_probe(sec_pmic->dev, ret, - "Failed to add %s IRQ chip\n", - sec_irq_chip->name); + for (i =3D 0; i < sec_irq_chip_num; i++) { + ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, + sec_pmic->regmap_pmic, + sec_pmic->irq, + IRQF_ONESHOT | IRQF_SHARED, 0, + sec_irq_chip + i, + sec_pmic->irq_data + i); + if (ret) { + return dev_err_probe(sec_pmic->dev, ret, + "Failed to add %s IRQ chip\n", + sec_irq_chip->name); + } + } =20 /* * The rtc-s5m driver requests S2MPS14_IRQ_RTCA0 also for S2MPS11 diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8d..726915deff7a 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -668,7 +668,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) enum sec_device_type device_type =3D platform_get_device_id(pdev)->driver_data; struct s5m_rtc_info *info; - int ret, alarm_irq; + int ret, alarm_irq, irq_chip; =20 info =3D devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (!info) @@ -684,21 +684,25 @@ static int s5m_rtc_probe(struct platform_device *pdev) regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; alarm_irq =3D S2MPS14_IRQ_RTCA0; + irq_chip =3D S2MPS11_IRQ_CHIP; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; alarm_irq =3D S2MPS14_IRQ_RTCA0; + irq_chip =3D S2MPS14_IRQ_CHIP; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; alarm_irq =3D S2MPS14_IRQ_RTCA0; + irq_chip =3D S2MPS14_IRQ_CHIP; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; alarm_irq =3D S5M8767_IRQ_RTCA1; + irq_chip =3D S5M8767_IRQ_CHIP; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -720,6 +724,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; alarm_irq =3D S2MPG10_IRQ_RTCA0; + irq_chip =3D S2MPG10_IRQ_CHIP; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,12 +735,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) + if (s5m87xx->irq_data[irq_chip]) { + info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data[irq_chip], + alarm_irq); + if (info->irq <=3D 0) { return dev_err_probe(&pdev->dev, -EINVAL, "Failed to get virtual IRQ %d\n", alarm_irq); + } } =20 platform_set_drvdata(pdev, info); diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index d785e101fe79..dcd741c4f0d6 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -33,6 +33,9 @@ #define STEP_12_5_MV 12500 #define STEP_6_25_MV 6250 =20 +/* Maximum number of IRQ chips in a PMIC */ +#define MAX_IRQ_CHIPS 1 + struct gpio_desc; =20 enum sec_device_type { @@ -69,7 +72,7 @@ struct sec_pmic_dev { =20 int device_type; int irq; - struct regmap_irq_chip_data *irq_data; + struct regmap_irq_chip_data *irq_data[MAX_IRQ_CHIPS]; }; =20 struct sec_platform_data { diff --git a/include/linux/mfd/samsung/irq.h b/include/linux/mfd/samsung/ir= q.h index b4805cbd949b..78eb894e350e 100644 --- a/include/linux/mfd/samsung/irq.h +++ b/include/linux/mfd/samsung/irq.h @@ -34,6 +34,8 @@ enum s2mpa01_irq { S2MPA01_IRQ_NR, }; =20 +#define S2MPA01_IRQ_CHIP 0 + #define S2MPA01_IRQ_PWRONF_MASK (1 << 0) #define S2MPA01_IRQ_PWRONR_MASK (1 << 1) #define S2MPA01_IRQ_JIGONBF_MASK (1 << 2) @@ -58,6 +60,8 @@ enum s2mpa01_irq { #define S2MPA01_IRQ_B35_TSD_MASK (1 << 5) =20 enum s2mpg10_irq { +#define S2MPG10_IRQ_CHIP 0 + /* PMIC */ S2MPG10_IRQ_PWRONF, S2MPG10_IRQ_PWRONR, @@ -183,6 +187,8 @@ enum s2mps11_irq { S2MPS11_IRQ_NR, }; =20 +#define S2MPS11_IRQ_CHIP 0 + #define S2MPS11_IRQ_PWRONF_MASK (1 << 0) #define S2MPS11_IRQ_PWRONR_MASK (1 << 1) #define S2MPS11_IRQ_JIGONBF_MASK (1 << 2) @@ -226,6 +232,8 @@ enum s2mps14_irq { S2MPS14_IRQ_NR, }; =20 +#define S2MPS14_IRQ_CHIP 0 + enum s2mpu02_irq { S2MPU02_IRQ_PWRONF, S2MPU02_IRQ_PWRONR, @@ -250,6 +258,8 @@ enum s2mpu02_irq { S2MPU02_IRQ_NR, }; =20 +#define S2MPU02_IRQ_CHIP 0 + /* Masks for interrupts are the same as in s2mps11 */ #define S2MPS14_IRQ_TSD_MASK (1 << 2) =20 @@ -277,6 +287,8 @@ enum s2mpu05_irq { S2MPU05_IRQ_NR, }; =20 +#define S2MPU05_IRQ_CHIP 0 + #define S2MPU05_IRQ_PWRONF_MASK BIT(0) #define S2MPU05_IRQ_PWRONR_MASK BIT(1) #define S2MPU05_IRQ_JIGONBF_MASK BIT(2) @@ -321,6 +333,8 @@ enum s5m8767_irq { S5M8767_IRQ_NR, }; =20 +#define S5M8767_IRQ_CHIP 0 + #define S5M8767_IRQ_PWRR_MASK (1 << 0) #define S5M8767_IRQ_PWRF_MASK (1 << 1) #define S5M8767_IRQ_PWR1S_MASK (1 << 3) --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28DDC315D44; Thu, 13 Nov 2025 19:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060822; cv=none; b=LZvancoVoOpn/uaZAHwKtXDXylHt478OaHA6OvR29KtovAsMyTsUCR+kqI1trYGAimtIbc4Ce1dsfVHkj5vh065NJpSXcpdcCP7ih2cTo8P7S+CxGMe698PReNdaM9DZ1zR+K2NJc33+/pc8iIak21iH//P0Hk/9k9NIpnSgX8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060822; c=relaxed/simple; bh=SpIdSb31KB8gZ86Fb3llMRwCTikHg2PXz/Esd/uLdtQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l1ceS/cA7Ck3ktEH8R+qQ3+5HJJ732EdvjTotuUFytg3i3QzT0ZedEkb31QyXCIXm+8xRPJY0YIvb9c8PakMvTC7W3pSKi1JVLxXrAR7oGEZ78czxbWBYcNCuY4D+jiV3xgVySdXj1GNE3rkpqv9xdmFFjDdPqk7hM7DMSa95Gk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=YkNpc+IS; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="YkNpc+IS" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 860AC2657E; Thu, 13 Nov 2025 20:06:58 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VTfkuvGQPuTq; Thu, 13 Nov 2025 20:06:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060816; bh=SpIdSb31KB8gZ86Fb3llMRwCTikHg2PXz/Esd/uLdtQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=YkNpc+ISmXg/A0bI0lFck2w7aqK8QuRFVa5FW8btlixBKhY/A/2ghK4vQgPfXHscj anrpwHoQk3ReR3ybfjHUPM/0/HaKu6wehmDN2h2w53KPaKOBIQ7lJPR+Ln20sBGBXq nAewewfN7IjGKWKmgQFnt9n/j5oHs5qK8w/KOQAoQNN9jQoJWDp7gDUqcJQixU8NdB 1qB7NYgZtHieWFb4gHdDCUoI+t/H8pcVmqmuJnWakVs+rWoiAVjOV8kMtpw9orhfJs Qg/EJTpbAJCIuslaeplphuaucT1m5rtDtz1mNzuTpxy0fAU2GiW7WCBkxqAvD2Z42T PZla6lT2usYEw== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:08 +0530 Subject: [PATCH 07/13] mfd: sec: add support for S2MU005 PMIC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-7-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=22904; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=SpIdSb31KB8gZ86Fb3llMRwCTikHg2PXz/Esd/uLdtQ=; b=SfJ+QKZIfkcg6H/vxisR0Mmu4cNyxsEJWO8JzxxChR+aYOiMGI8KUOVlE/DEXZkrMcWDRguTh /upxrd+Nm7+Das5DKg4soNjYyVDcs00oE4ZcflUogQc3YeeyuaBz1Xh X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro USB Interface Controller), and flash and RGB LED controllers. S2MU005's interrupt registers can be properly divided into three regmap IRQ chips, one each for the charger, flash LEDs, and the MUIC. Add initial support for S2MU005 in the PMIC driver, along with it's three interrupt chips. Signed-off-by: Kaustabh Chakraborty --- drivers/mfd/sec-common.c | 11 ++ drivers/mfd/sec-i2c.c | 29 ++++ drivers/mfd/sec-irq.c | 71 ++++++++ include/linux/mfd/samsung/core.h | 3 +- include/linux/mfd/samsung/irq.h | 80 +++++++++ include/linux/mfd/samsung/s2mu005.h | 328 ++++++++++++++++++++++++++++++++= ++++ 6 files changed, 521 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 42d55e70e34c..4c5f4dc2905b 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -79,6 +79,13 @@ static const struct mfd_cell s2mpu05_devs[] =3D { MFD_CELL_NAME("s2mps15-rtc"), }; =20 +static const struct mfd_cell s2mu005_devs[] =3D { + MFD_CELL_OF("s2mu005-charger", NULL, NULL, 0, 0, "samsung,s2mu005-charger= "), + MFD_CELL_OF("s2mu005-flash", NULL, NULL, 0, 0, "samsung,s2mu005-flash"), + MFD_CELL_OF("s2mu005-muic", NULL, NULL, 0, 0, "samsung,s2mu005-muic"), + MFD_CELL_OF("s2mu005-rgb", NULL, NULL, 0, 0, "samsung,s2mu005-rgb"), +}; + static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) { unsigned int val; @@ -214,6 +221,10 @@ int sec_pmic_probe(struct device *dev, int device_type= , unsigned int irq, sec_devs =3D s2mpu05_devs; num_sec_devs =3D ARRAY_SIZE(s2mpu05_devs); break; + case S2MU005: + sec_devs =3D s2mu005_devs; + num_sec_devs =3D ARRAY_SIZE(s2mu005_devs); + break; default: return dev_err_probe(sec_pmic->dev, -EINVAL, "Unsupported device type %d\n", diff --git a/drivers/mfd/sec-i2c.c b/drivers/mfd/sec-i2c.c index 3132b849b4bc..bc5ad8b1c432 100644 --- a/drivers/mfd/sec-i2c.c +++ b/drivers/mfd/sec-i2c.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -66,6 +67,19 @@ static bool s2mpu02_volatile(struct device *dev, unsigne= d int reg) } } =20 +static bool s2mu005_volatile(struct device *dev, unsigned int reg) +{ + switch (reg) { + case S2MU005_REG_CHGR_INT1M: + case S2MU005_REG_FLED_INT1M: + case S2MU005_REG_MUIC_INT1M: + case S2MU005_REG_MUIC_INT2M: + return false; + default: + return true; + } +} + static const struct regmap_config s2dos05_regmap_config =3D { .reg_bits =3D 8, .val_bits =3D 8, @@ -130,6 +144,15 @@ static const struct regmap_config s2mpu05_regmap_confi= g =3D { .val_bits =3D 8, }; =20 +static const struct regmap_config s2mu005_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + + .max_register =3D S2MU005_REG_MUIC_LDOADC_H, + .volatile_reg =3D s2mu005_volatile, + .cache_type =3D REGCACHE_FLAT, +}; + static const struct regmap_config s5m8767_regmap_config =3D { .reg_bits =3D 8, .val_bits =3D 8, @@ -203,6 +226,11 @@ static const struct sec_pmic_i2c_platform_data s2mpu05= _data =3D { .device_type =3D S2MPU05, }; =20 +static const struct sec_pmic_i2c_platform_data s2mu005_data =3D { + .regmap_cfg =3D &s2mu005_regmap_config, + .device_type =3D S2MU005, +}; + static const struct sec_pmic_i2c_platform_data s5m8767_data =3D { .regmap_cfg =3D &s5m8767_regmap_config, .device_type =3D S5M8767X, @@ -217,6 +245,7 @@ static const struct of_device_id sec_pmic_i2c_of_match[= ] =3D { { .compatible =3D "samsung,s2mps15-pmic", .data =3D &s2mps15_data, }, { .compatible =3D "samsung,s2mpu02-pmic", .data =3D &s2mpu02_data, }, { .compatible =3D "samsung,s2mpu05-pmic", .data =3D &s2mpu05_data, }, + { .compatible =3D "samsung,s2mu005-pmic", .data =3D &s2mu005_data, }, { .compatible =3D "samsung,s5m8767-pmic", .data =3D &s5m8767_data, }, { }, }; diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index 053c28f31ec9..fc82893fe6b7 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include "sec-core.h" @@ -158,6 +159,42 @@ static const struct regmap_irq s2mpu05_irqs[] =3D { REGMAP_IRQ_REG(S2MPU05_IRQ_TSD, 2, S2MPU05_IRQ_TSD_MASK), }; =20 +static const struct regmap_irq s2mu005_chgr_irqs[] =3D { + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_DETBAT, 0, S2MU005_CHGR_IRQ_DETBAT_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_BAT, 0, S2MU005_CHGR_IRQ_BAT_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_IVR, 0, S2MU005_CHGR_IRQ_IVR_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_EVENT, 0, S2MU005_CHGR_IRQ_EVENT_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_CHG, 0, S2MU005_CHGR_IRQ_CHG_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_VMID, 0, S2MU005_CHGR_IRQ_VMID_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_WCIN, 0, S2MU005_CHGR_IRQ_WCIN_MASK), + REGMAP_IRQ_REG(S2MU005_CHGR_IRQ_VBUS, 0, S2MU005_CHGR_IRQ_VBUS_MASK), +}; + +static const struct regmap_irq s2mu005_fled_irqs[] =3D { + REGMAP_IRQ_REG(S2MU005_FLED_IRQ_LBPROT, 0, S2MU005_FLED_IRQ_LBPROT_MASK), + REGMAP_IRQ_REG(S2MU005_FLED_IRQ_OPENCH2, 0, S2MU005_FLED_IRQ_OPENCH2_MASK= ), + REGMAP_IRQ_REG(S2MU005_FLED_IRQ_OPENCH1, 0, S2MU005_FLED_IRQ_OPENCH1_MASK= ), + REGMAP_IRQ_REG(S2MU005_FLED_IRQ_SHORTCH2, 0, S2MU005_FLED_IRQ_SHORTCH2_MA= SK), + REGMAP_IRQ_REG(S2MU005_FLED_IRQ_SHORTCH1, 0, S2MU005_FLED_IRQ_SHORTCH1_MA= SK), +}; + +static const struct regmap_irq s2mu005_muic_irqs[] =3D { + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_ATTACH, 0, S2MU005_MUIC_IRQ_ATTACH_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_DETACH, 0, S2MU005_MUIC_IRQ_DETACH_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_KP, 0, S2MU005_MUIC_IRQ_KP_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_LKP, 0, S2MU005_MUIC_IRQ_LKP_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_LKR, 0, S2MU005_MUIC_IRQ_LKR_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_RIDCHG, 0, S2MU005_MUIC_IRQ_RIDCHG_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_VBUSON, 1, S2MU005_MUIC_IRQ_VBUSON_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_RSVD, 1, S2MU005_MUIC_IRQ_RSVD_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_ADC, 1, S2MU005_MUIC_IRQ_ADC_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_STUCK, 1, S2MU005_MUIC_IRQ_STUCK_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_STUCKRCV, 1, S2MU005_MUIC_IRQ_STUCKRCV_MA= SK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_MHDL, 1, S2MU005_MUIC_IRQ_MHDL_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_AVCHG, 1, S2MU005_MUIC_IRQ_AVCHG_MASK), + REGMAP_IRQ_REG(S2MU005_MUIC_IRQ_VBUSOFF, 1, S2MU005_MUIC_IRQ_VBUSOFF_MASK= ), +}; + static const struct regmap_irq s5m8767_irqs[] =3D { REGMAP_IRQ_REG(S5M8767_IRQ_PWRR, 0, S5M8767_IRQ_PWRR_MASK), REGMAP_IRQ_REG(S5M8767_IRQ_PWRF, 0, S5M8767_IRQ_PWRF_MASK), @@ -259,6 +296,36 @@ static const struct regmap_irq_chip s2mpu05_irq_chip[]= =3D { }, }; =20 +static const struct regmap_irq_chip s2mu005_irq_chip[] =3D { + [S2MU005_CHGR_IRQ_CHIP] =3D { + .name =3D "s2mu005-chgr", + .irqs =3D s2mu005_chgr_irqs, + .num_irqs =3D ARRAY_SIZE(s2mu005_chgr_irqs), + .num_regs =3D 1, + .status_base =3D S2MU005_REG_CHGR_INT1, + .mask_base =3D S2MU005_REG_CHGR_INT1M, + .ack_base =3D S2MU005_REG_CHGR_INT1, + }, + [S2MU005_FLED_IRQ_CHIP] =3D { + .name =3D "s2mu005-fled", + .irqs =3D s2mu005_fled_irqs, + .num_irqs =3D ARRAY_SIZE(s2mu005_fled_irqs), + .num_regs =3D 1, + .status_base =3D S2MU005_REG_FLED_INT1, + .mask_base =3D S2MU005_REG_FLED_INT1M, + .ack_base =3D S2MU005_REG_FLED_INT1, + }, + [S2MU005_MUIC_IRQ_CHIP] =3D { + .name =3D "s2mu005-muic", + .irqs =3D s2mu005_muic_irqs, + .num_irqs =3D ARRAY_SIZE(s2mu005_muic_irqs), + .num_regs =3D 2, + .status_base =3D S2MU005_REG_MUIC_INT1, + .mask_base =3D S2MU005_REG_MUIC_INT1M, + .ack_base =3D S2MU005_REG_MUIC_INT1, + }, +}; + static const struct regmap_irq_chip s5m8767_irq_chip[] =3D { [S5M8767_IRQ_CHIP] =3D { .name =3D "s5m8767", @@ -315,6 +382,10 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) sec_irq_chip =3D s2mpu05_irq_chip; sec_irq_chip_num =3D ARRAY_SIZE(s2mpu05_irq_chip); break; + case S2MU005: + sec_irq_chip =3D s2mu005_irq_chip; + sec_irq_chip_num =3D ARRAY_SIZE(s2mu005_irq_chip); + break; default: return dev_err_probe(sec_pmic->dev, -EINVAL, "Unsupported device type %d\n", diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index dcd741c4f0d6..fc07f7944dcd 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -34,7 +34,7 @@ #define STEP_6_25_MV 6250 =20 /* Maximum number of IRQ chips in a PMIC */ -#define MAX_IRQ_CHIPS 1 +#define MAX_IRQ_CHIPS 3 =20 struct gpio_desc; =20 @@ -49,6 +49,7 @@ enum sec_device_type { S2MPS15X, S2MPU02, S2MPU05, + S2MU005, }; =20 /** diff --git a/include/linux/mfd/samsung/irq.h b/include/linux/mfd/samsung/ir= q.h index 78eb894e350e..b3a51b74aa59 100644 --- a/include/linux/mfd/samsung/irq.h +++ b/include/linux/mfd/samsung/irq.h @@ -309,6 +309,86 @@ enum s2mpu05_irq { #define S2MPU05_IRQ_INT140C_MASK BIT(1) #define S2MPU05_IRQ_TSD_MASK BIT(2) =20 +enum s2mu005_chgr_irq { + S2MU005_CHGR_IRQ_DETBAT, + S2MU005_CHGR_IRQ_BAT, + S2MU005_CHGR_IRQ_IVR, + S2MU005_CHGR_IRQ_EVENT, + S2MU005_CHGR_IRQ_CHG, + S2MU005_CHGR_IRQ_VMID, + S2MU005_CHGR_IRQ_WCIN, + S2MU005_CHGR_IRQ_VBUS, + + S2MU005_CHGR_IRQ_NR, +}; + +#define S2MU005_CHGR_IRQ_CHIP 0 + +#define S2MU005_CHGR_IRQ_DETBAT_MASK BIT(0) +#define S2MU005_CHGR_IRQ_BAT_MASK BIT(1) +#define S2MU005_CHGR_IRQ_IVR_MASK BIT(2) +#define S2MU005_CHGR_IRQ_EVENT_MASK BIT(3) +#define S2MU005_CHGR_IRQ_CHG_MASK BIT(4) +#define S2MU005_CHGR_IRQ_VMID_MASK BIT(5) +#define S2MU005_CHGR_IRQ_WCIN_MASK BIT(6) +#define S2MU005_CHGR_IRQ_VBUS_MASK BIT(7) + +enum s2mu005_fled_irq { + S2MU005_FLED_IRQ_LBPROT, + S2MU005_FLED_IRQ_OPENCH2, + S2MU005_FLED_IRQ_OPENCH1, + S2MU005_FLED_IRQ_SHORTCH2, + S2MU005_FLED_IRQ_SHORTCH1, + + S2MU005_FLED_IRQ_NR, +}; + +#define S2MU005_FLED_IRQ_CHIP 1 + +#define S2MU005_FLED_IRQ_LBPROT_MASK BIT(2) +#define S2MU005_FLED_IRQ_OPENCH2_MASK BIT(4) +#define S2MU005_FLED_IRQ_OPENCH1_MASK BIT(5) +#define S2MU005_FLED_IRQ_SHORTCH2_MASK BIT(6) +#define S2MU005_FLED_IRQ_SHORTCH1_MASK BIT(7) + +enum s2mu005_muic_irq { + S2MU005_MUIC_IRQ_ATTACH, + S2MU005_MUIC_IRQ_DETACH, + S2MU005_MUIC_IRQ_KP, + S2MU005_MUIC_IRQ_LKP, + S2MU005_MUIC_IRQ_LKR, + S2MU005_MUIC_IRQ_RIDCHG, + + S2MU005_MUIC_IRQ_VBUSON, + S2MU005_MUIC_IRQ_RSVD, + S2MU005_MUIC_IRQ_ADC, + S2MU005_MUIC_IRQ_STUCK, + S2MU005_MUIC_IRQ_STUCKRCV, + S2MU005_MUIC_IRQ_MHDL, + S2MU005_MUIC_IRQ_AVCHG, + S2MU005_MUIC_IRQ_VBUSOFF, + + S2MU005_IRQ_NR, +}; + +#define S2MU005_MUIC_IRQ_CHIP 2 + +#define S2MU005_MUIC_IRQ_ATTACH_MASK BIT(0) +#define S2MU005_MUIC_IRQ_DETACH_MASK BIT(1) +#define S2MU005_MUIC_IRQ_KP_MASK BIT(2) +#define S2MU005_MUIC_IRQ_LKP_MASK BIT(3) +#define S2MU005_MUIC_IRQ_LKR_MASK BIT(4) +#define S2MU005_MUIC_IRQ_RIDCHG_MASK BIT(5) + +#define S2MU005_MUIC_IRQ_VBUSON_MASK BIT(0) +#define S2MU005_MUIC_IRQ_RSVD_MASK BIT(1) +#define S2MU005_MUIC_IRQ_ADC_MASK BIT(2) +#define S2MU005_MUIC_IRQ_STUCK_MASK BIT(3) +#define S2MU005_MUIC_IRQ_STUCKRCV_MASK BIT(4) +#define S2MU005_MUIC_IRQ_MHDL_MASK BIT(5) +#define S2MU005_MUIC_IRQ_AVCHG_MASK BIT(6) +#define S2MU005_MUIC_IRQ_VBUSOFF_MASK BIT(7) + enum s5m8767_irq { S5M8767_IRQ_PWRR, S5M8767_IRQ_PWRF, diff --git a/include/linux/mfd/samsung/s2mu005.h b/include/linux/mfd/samsun= g/s2mu005.h new file mode 100644 index 000000000000..32ad35dda661 --- /dev/null +++ b/include/linux/mfd/samsung/s2mu005.h @@ -0,0 +1,328 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (c) 2015 Samsung Electronics Co., Ltd + * Copyright (c) 2025 Kaustabh Chakraborty + */ + +#ifndef __LINUX_MFD_S2MU005_H +#define __LINUX_MFD_S2MU005_H + +#include +#include + +/* S2MU005 registers */ +enum s2mu005_reg { + S2MU005_REG_CHGR_INT1, + S2MU005_REG_CHGR_INT1M, + + S2MU005_REG_FLED_INT1, + S2MU005_REG_FLED_INT1M, + + S2MU005_REG_MUIC_INT1, + S2MU005_REG_MUIC_INT2, + S2MU005_REG_MUIC_INT1M, + S2MU005_REG_MUIC_INT2M, + + S2MU005_REG_CHGR_STATUS0, + S2MU005_REG_CHGR_STATUS1, + S2MU005_REG_CHGR_STATUS2, + S2MU005_REG_CHGR_STATUS3, + S2MU005_REG_CHGR_STATUS4, + S2MU005_REG_CHGR_STATUS5, + S2MU005_REG_CHGR_CTRL0, + S2MU005_REG_CHGR_CTRL1, + S2MU005_REG_CHGR_CTRL2, + S2MU005_REG_CHGR_CTRL3, + S2MU005_REG_CHGR_CTRL4, + S2MU005_REG_CHGR_CTRL5, + S2MU005_REG_CHGR_CTRL6, + S2MU005_REG_CHGR_CTRL7, + S2MU005_REG_CHGR_CTRL8, + S2MU005_REG_CHGR_CTRL9, + S2MU005_REG_CHGR_CTRL10, + S2MU005_REG_CHGR_CTRL11, + S2MU005_REG_CHGR_CTRL12, + S2MU005_REG_CHGR_CTRL13, + S2MU005_REG_CHGR_CTRL14, + S2MU005_REG_CHGR_CTRL15, + S2MU005_REG_CHGR_CTRL16, + S2MU005_REG_CHGR_CTRL17, + S2MU005_REG_CHGR_CTRL18, + S2MU005_REG_CHGR_CTRL19, + S2MU005_REG_CHGR_TEST0, + S2MU005_REG_CHGR_TEST1, + S2MU005_REG_CHGR_TEST2, + S2MU005_REG_CHGR_TEST3, + S2MU005_REG_CHGR_TEST4, + S2MU005_REG_CHGR_TEST5, + S2MU005_REG_CHGR_TEST6, + S2MU005_REG_CHGR_TEST7, + S2MU005_REG_CHGR_TEST8, + S2MU005_REG_CHGR_TEST9, + S2MU005_REG_CHGR_TEST10, + + S2MU005_REG_FLED_STATUS, + S2MU005_REG_FLED_CH0_CTRL0, + S2MU005_REG_FLED_CH0_CTRL1, + S2MU005_REG_FLED_CH0_CTRL2, + S2MU005_REG_FLED_CH0_CTRL3, + S2MU005_REG_FLED_CH1_CTRL0, + S2MU005_REG_FLED_CH1_CTRL1, + S2MU005_REG_FLED_CH1_CTRL2, + S2MU005_REG_FLED_CH1_CTRL3, + S2MU005_REG_FLED_CTRL0, + S2MU005_REG_FLED_CTRL1, + S2MU005_REG_FLED_CTRL2, + S2MU005_REG_FLED_CTRL3, + S2MU005_REG_FLED_CTRL4, + S2MU005_REG_FLED_CTRL5, + S2MU005_REG_FLED_CTRL6, + + S2MU005_REG_RGB_EN, + S2MU005_REG_RGB_CH0_CTRL, + S2MU005_REG_RGB_CH1_CTRL, + S2MU005_REG_RGB_CH2_CTRL, + S2MU005_REG_RGB_CH0_RAMP, + S2MU005_REG_RGB_CH0_STAY, + S2MU005_REG_RGB_CH1_RAMP, + S2MU005_REG_RGB_CH1_STAY, + S2MU005_REG_RGB_CH2_RAMP, + S2MU005_REG_RGB_CH2_STAY, + S2MU005_REG_RGB_TEST0, + S2MU005_REG_RGB_CTRL0, + + S2MU005_REG_MUIC_ADC, + S2MU005_REG_MUIC_DEV1, + S2MU005_REG_MUIC_DEV2, + S2MU005_REG_MUIC_DEV3, + S2MU005_REG_MUIC_BUTTON1, + S2MU005_REG_MUIC_BUTTON2, + S2MU005_REG_MUIC_RESET, + S2MU005_REG_MUIC_CHGTYPE, + S2MU005_REG_MUIC_DEVAPPLE, + S2MU005_REG_MUIC_BCDRESCAN, + S2MU005_REG_MUIC_TEST1, + S2MU005_REG_MUIC_TEST2, + S2MU005_REG_MUIC_TEST3, + + S2MU005_REG_ID =3D 0x73, + + S2MU005_REG_MUIC_CTRL1 =3D 0xb2, + S2MU005_REG_MUIC_TIMERSET1, + S2MU005_REG_MUIC_TIMERSET2, + S2MU005_REG_MUIC_SWCTRL, + S2MU005_REG_MUIC_TIMERSET3, + S2MU005_REG_MUIC_CTRL2, + S2MU005_REG_MUIC_CTRL3, + + S2MU005_REG_MUIC_LDOADC_L =3D 0xbf, + S2MU005_REG_MUIC_LDOADC_H, +}; + +#define S2MU005_REG_FLED_CH_CTRL0(x) (S2MU005_REG_FLED_CH0_CTRL0 + 4 * (x)) +#define S2MU005_REG_FLED_CH_CTRL1(x) (S2MU005_REG_FLED_CH0_CTRL1 + 4 * (x)) +#define S2MU005_REG_FLED_CH_CTRL2(x) (S2MU005_REG_FLED_CH0_CTRL2 + 4 * (x)) +#define S2MU005_REG_FLED_CH_CTRL3(x) (S2MU005_REG_FLED_CH0_CTRL3 + 4 * (x)) + +#define S2MU005_REG_RGB_CH_CTRL(x) (S2MU005_REG_RGB_CH0_CTRL + 1 * (x)) +#define S2MU005_REG_RGB_CH_RAMP(x) (S2MU005_REG_RGB_CH0_RAMP + 2 * (x)) +#define S2MU005_REG_RGB_CH_STAY(x) (S2MU005_REG_RGB_CH0_STAY + 2 * (x)) + +/* S2MU005_REG_CHGR_STATUS0 */ +#define S2MU005_CHGR_VBUS BIT(7) +#define S2MU005_CHGR_WCIN BIT(6) +#define S2MU005_CHGR_VMID BIT(5) +#define S2MU005_CHGR_CHG BIT(4) +#define S2MU005_CHGR_STAT GENMASK(3, 0) + +#define S2MU005_CHGR_STAT_DONE FIELD_PREP(S2MU005_CHGR_STAT, 8) +#define S2MU005_CHGR_STAT_TOPOFF FIELD_PREP(S2MU005_CHGR_STAT, 7) +#define S2MU005_CHGR_STAT_DONE_FLAG FIELD_PREP(S2MU005_CHGR_STAT, 6) +#define S2MU005_CHGR_STAT_CV FIELD_PREP(S2MU005_CHGR_STAT, 5) +#define S2MU005_CHGR_STAT_CC FIELD_PREP(S2MU005_CHGR_STAT, 4) +#define S2MU005_CHGR_STAT_COOL_CHG FIELD_PREP(S2MU005_CHGR_STAT, 3) +#define S2MU005_CHGR_STAT_PRE_CHG FIELD_PREP(S2MU005_CHGR_STAT, 2) + +/* S2MU005_REG_CHGR_STATUS1 */ +#define S2MU005_CHGR_DETBAT BIT(7) +#define S2MU005_CHGR_VBUSOVP GENMASK(6, 4) + +#define S2MU005_CHGR_VBUS_OVP_OVERVOLT FIELD_PREP(S2MU005_CHGR_OVP, 2) + +/* S2MU005_REG_CHGR_STATUS2 */ +#define S2MU005_CHGR_BAT GENMASK(6, 4) + +#define S2MU005_CHGR_BAT_VOLT_DET FIELD_PREP(S2MU005_CHGR_BAT, 7) +#define S2MU005_CHGR_BAT_FAST_CHG_DET FIELD_PREP(S2MU005_CHGR_BAT, 6) +#define S2MU005_CHGR_BAT_COOL_CHG_DET FIELD_PREP(S2MU005_CHGR_BAT, 5) +#define S2MU005_CHGR_BAT_LOW_CHG FIELD_PREP(S2MU005_CHGR_BAT, 2) +#define S2MU005_CHGR_BAT_SELF_DISCHG FIELD_PREP(S2MU005_CHGR_BAT, 1) +#define S2MU005_CHGR_BAT_OVP_DET FIELD_PREP(S2MU005_CHGR_BAT, 0) + +/* S2MU005_REG_CHGR_STATUS3 */ +#define S2MU005_CHGR_EVT GENMASK(3, 0) + +#define S2MU005_CHGR_EVT_WDT_RST FIELD_PREP(S2MU005_CHGR_EVT, 6) +#define S2MU005_CHGR_EVT_WDT_SUSP FIELD_PREP(S2MU005_CHGR_EVT, 5) +#define S2MU005_CHGR_EVT_VSYS_VUVLO FIELD_PREP(S2MU005_CHGR_EVT, 4) +#define S2MU005_CHGR_EVT_VSYS_VOVP FIELD_PREP(S2MU005_CHGR_EVT, 3) +#define S2MU005_CHGR_EVT_THERM_FOLDBACK FIELD_PREP(S2MU005_CHGR_EVT, 2) +#define S2MU005_CHGR_EVT_THERM_SHUTDOWN FIELD_PREP(S2MU005_CHGR_EVT, 1) + +/* S2MU005_REG_CHGR_CTRL0 */ +#define S2MU005_CHGR_CHG_EN BIT(4) +#define S2MU005_CHGR_OP_MODE GENMASK(2, 0) + +#define S2MU005_CHGR_OP_MODE_OTG FIELD_PREP(S2MU005_CHGR_OP_MODE, BIT(2)) +#define S2MU005_CHGR_OP_MODE_CHG FIELD_PREP(S2MU005_CHGR_OP_MODE, BIT(1)) + +/* S2MU005_REG_CHGR_CTRL1 */ +#define S2MU005_CHGR_VIN_DROP GENMASK(6, 4) + +/* S2MU005_REG_CHGR_CTRL2 */ +#define S2MU005_CHGR_IN_CURR_LIM GENMASK(5, 0) + +/* S2MU005_REG_CHGR_CTRL4 */ +#define S2MU005_CHGR_OTG_OCP_ON BIT(5) +#define S2MU005_CHGR_OTG_OCP_OFF BIT(4) +#define S2MU005_CHGR_OTG_OCP GENMASK(3, 2) + +/* S2MU005_REG_CHGR_CTRL5 */ +#define S2MU005_CHGR_VMID_BOOST GENMASK(4, 0) + +/* S2MU005_REG_CHGR_CTRL6 */ +#define S2MU005_CHGR_COOL_CHG_CURR GENMASK(5, 0) + +/* S2MU005_REG_CHGR_CTRL7 */ +#define S2MU005_CHGR_FAST_CHG_CURR GENMASK(5, 0) + +/* S2MU005_REG_CHGR_CTRL8 */ +#define S2MU005_CHGR_VF_VBAT GENMASK(6, 1) + +/* S2MU005_REG_CHGR_CTRL10 */ +#define S2MU005_CHGR_TOPOFF_CURR(x) (GENMASK(3, 0) << 4 * (x)) + +/* S2MU005_REG_CHGR_CTRL11 */ +#define S2MU005_CHGR_OSC_BOOST GENMASK(6, 5) +#define S2MU005_CHGR_OSC_BUCK GENMASK(4, 3) + +/* S2MU005_REG_CHGR_CTRL12 */ +#define S2MU005_CHGR_WDT GENMASK(2, 0) + +#define S2MU005_CHGR_WDT_ON FIELD_PREP(S2MU005_CHGR_WDT, BIT(2)) +#define S2MU005_CHGR_WDT_OFF FIELD_PREP(S2MU005_CHGR_WDT, BIT(1)) + +/* S2MU005_REG_CHGR_CTRL15 */ +#define S2MU005_CHGR_OTG_EN GENMASK(3, 2) + +/* S2MU005_REG_FLED_STATUS */ +#define S2MU005_FLED_FLASH_STATUS(x) (BIT(7) >> 2 * (x)) +#define S2MU005_FLED_TORCH_STATUS(x) (BIT(6) >> 2 * (x)) + +/* S2MU005_REG_FLED_CHx_CTRL0 */ +#define S2MU005_FLED_FLASH_IOUT GENMASK(3, 0) + +/* S2MU005_REG_FLED_CHx_CTRL1 */ +#define S2MU005_FLED_TORCH_IOUT GENMASK(3, 0) + +/* S2MU005_REG_FLED_CHx_CTRL2 */ +#define S2MU005_FLED_TORCH_TIMEOUT GENMASK(3, 0) + +/* S2MU005_REG_FLED_CHx_CTRL3 */ +#define S2MU005_FLED_FLASH_TIMEOUT GENMASK(3, 0) + +/* S2MU005_REG_FLED_CTRL1 */ +#define S2MU005_FLED_CH_EN BIT(7) + +/* + * S2MU005_REG_FLED_CTRL4 - Rev. EVT0 + * S2MU005_REG_FLED_CTRL6 - Rev. EVT1 and later + */ +#define S2MU005_FLED_FLASH_EN(x) (GENMASK(7, 6) >> 4 * (x)) +#define S2MU005_FLED_TORCH_EN(x) (GENMASK(5, 4) >> 4 * (x)) + +/* S2MU005_REG_RGB_EN */ +#define S2MU005_RGB_RESET BIT(6) +#define S2MU005_RGB_SLOPE GENMASK(5, 0) + +#define S2MU005_RGB_SLOPE_CONST (BIT(4) | BIT(2) | BIT(0)) +#define S2MU005_RGB_SLOPE_SMOOTH (BIT(5) | BIT(3) | BIT(1)) + +/* S2MU005_REG_RGB_CHx_RAMP */ +#define S2MU005_RGB_CH_RAMP_UP GENMASK(7, 4) +#define S2MU005_RGB_CH_RAMP_DN GENMASK(3, 0) + +/* S2MU005_REG_RGB_CHx_STAY */ +#define S2MU005_RGB_CH_STAY_HI GENMASK(7, 4) +#define S2MU005_RGB_CH_STAY_LO GENMASK(3, 0) + +/* S2MU005_REG_MUIC_DEV1 */ +#define S2MU005_MUIC_OTG BIT(7) +#define S2MU005_MUIC_DCP BIT(6) +#define S2MU005_MUIC_CDP BIT(5) +#define S2MU005_MUIC_T1_T2_CHG BIT(4) +#define S2MU005_MUIC_UART BIT(3) +#define S2MU005_MUIC_SDP BIT(2) +#define S2MU005_MUIC_LANHUB BIT(1) +#define S2MU005_MUIC_AUDIO BIT(0) + +/* S2MU005_REG_MUIC_DEV2 */ +#define S2MU005_MUIC_SDP_1P8S BIT(7) +#define S2MU005_MUIC_AV BIT(6) +#define S2MU005_MUIC_TTY BIT(5) +#define S2MU005_MUIC_PPD BIT(4) +#define S2MU005_MUIC_JIG_UART_OFF BIT(3) +#define S2MU005_MUIC_JIG_UART_ON BIT(2) +#define S2MU005_MUIC_JIG_USB_OFF BIT(1) +#define S2MU005_MUIC_JIG_USB_ON BIT(0) + +/* S2MU005_REG_MUIC_DEV3 */ +#define S2MU005_MUIC_U200_CHG BIT(7) +#define S2MU005_MUIC_VBUS_AV BIT(4) +#define S2MU005_MUIC_VBUS_R255 BIT(1) +#define S2MU005_MUIC_MHL BIT(0) + +/* S2MU005_REG_MUIC_DEVAPPLE */ +#define S2MU005_MUIC_APPLE_CHG_0P5A BIT(7) +#define S2MU005_MUIC_APPLE_CHG_1P0A BIT(6) +#define S2MU005_MUIC_APPLE_CHG_2P0A BIT(5) +#define S2MU005_MUIC_APPLE_CHG_2P4A BIT(4) +#define S2MU005_MUIC_SDP_DCD_OUT BIT(3) +#define S2MU005_MUIC_RID_WAKEUP BIT(2) +#define S2MU005_MUIC_VBUS_WAKEUP BIT(1) +#define S2MU005_MUIC_BCV1P2_OR_OPEN BIT(0) + +/* S2MU005_REG_ID */ +#define S2MU005_ID_MASK GENMASK(3, 0) +#define S2MU005_ID_SHIFT 0 + +/* S2MU005_REG_MUIC_SWCTRL */ +#define S2MU005_MUIC_DM_DP GENMASK(7, 2) +#define S2MU005_MUIC_JIG BIT(0) + +#define S2MU005_MUIC_DM_DP_UART FIELD_PREP(S2MU005_MUIC_DM_DP, 0x12) +#define S2MU005_MUIC_DM_DP_USB FIELD_PREP(S2MU005_MUIC_DM_DP, 0x09) + +/* S2MU005_REG_MUIC_CTRL1 */ +#define S2MU005_MUIC_OPEN BIT(4) +#define S2MU005_MUIC_RAW_DATA BIT(3) +#define S2MU005_MUIC_MAN_SW BIT(2) +#define S2MU005_MUIC_WAIT BIT(1) +#define S2MU005_MUIC_IRQ BIT(0) + +/* S2MU005_REG_MUIC_CTRL3 */ +#define S2MU005_MUIC_ONESHOT_ADC BIT(2) + +/* S2MU005_REG_MUIC_LDOADC_L and S2MU005_REG_MUIC_LDOADC_H */ +#define S2MU005_MUIC_VSET GENMASK(4, 0) + +#define S2MU005_MUIC_VSET_3P0V FIELD_PREP(S2MU005_MUIC_VSET, 0x1f) +#define S2MU005_MUIC_VSET_2P6V FIELD_PREP(S2MU005_MUIC_VSET, 0x0e) +#define S2MU005_MUIC_VSET_2P4V FIELD_PREP(S2MU005_MUIC_VSET, 0x0c) +#define S2MU005_MUIC_VSET_2P2V FIELD_PREP(S2MU005_MUIC_VSET, 0x0a) +#define S2MU005_MUIC_VSET_2P0V FIELD_PREP(S2MU005_MUIC_VSET, 0x08) +#define S2MU005_MUIC_VSET_1P5V FIELD_PREP(S2MU005_MUIC_VSET, 0x03) +#define S2MU005_MUIC_VSET_1P4V FIELD_PREP(S2MU005_MUIC_VSET, 0x02) +#define S2MU005_MUIC_VSET_1P2V FIELD_PREP(S2MU005_MUIC_VSET, 0x00) + +#endif /* __LINUX_MFD_S2MU005_H */ --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C9D31B100; Thu, 13 Nov 2025 19:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060833; cv=none; b=rQgARVtymm3g0rK3Q/sMW2/X7Q2ftCSaneFLAcj+qiAm0AKU3NkR1ry98Vx8K8PRAJ3LAYedNW/vIQii49VX0Mloijl46gdSMwu9cUxnfCP4huUKDLBfsEpRq/2jNg/fkZHEOG6bIVDXaEvCAYMT7Ae5T9BKgSsc7HeWSVyVLRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060833; c=relaxed/simple; bh=LWX7GkimFoy35tTCAVN375evxoUHiYMParoV5iSHup0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GKW82v75RGl7CEPZAXpG1XuEtIG/QPPGzLdlxICm3qdqA0Y7mMDK9E5MATGt70bUkvt/fJ1LH1CFfc4cEt6PBf3adoCLei+22RQJ9gXNg8YHSIOEJ+A3QmCV1woGCcPjgLe6B+XfeyuAGqqhfCNmvnJf1JW2wQUuw5eLuH2IWRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=OhHPgEZI; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="OhHPgEZI" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2974F25EDC; Thu, 13 Nov 2025 20:07:10 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8yQAZqCJSbdI; Thu, 13 Nov 2025 20:07:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060829; bh=LWX7GkimFoy35tTCAVN375evxoUHiYMParoV5iSHup0=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=OhHPgEZI5Hc87mCWuQgovlTU2oEKjGmmgMtuHC01n2GNwqjrfkyFs8DdM4xeYdDCU u33UUPAVsyrGycygK1lbo6/aitdIg5AhZqm1rwUcGHOXa5wW0YbsN2k0lgrY2znlF1 DMrqTuln6J1Z4ejHdlmQOOeWdMI72Oa0F6csBUTLsjdafWS5tKj0VVAWkt4vtIIvlX 4nTmfXMeevd2KqP8SDh4+cCtvc3z8Y+mX3UCAwth3V0r7TcnLrYkNGnpRMXw/jyobz 9owrrK4XnvAfHhBc5CHK2HnYmd7EfTdb8A6/fKg+L2k08U49GkFFq3zU0hKed74IC9 U0fR2U7VBww2A== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:09 +0530 Subject: [PATCH 08/13] mfd: sec: store hardware revision in sec_pmic_dev and add S2MU005 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-8-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=3228; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=LWX7GkimFoy35tTCAVN375evxoUHiYMParoV5iSHup0=; b=bRpngdA7TgTIKE+t9saHEIyI0x6s+mH+8sGFu1P7k4ySWz+PkoTJv3cbdNH40RqVdV7JC54M1 8VZ7JaXBxKsDc14MrzSfpX9RiEmPAFBIh2gZZ75/wcnMqDKAqz7C7Yo X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= The device revision matters in cases when in some PMICs, the correct register offsets very in different revisions. Instead of just debug printing the value, store it in the driver data struct. Unlike other devices, S2MU005 has its hardware revision ID in register offset 0x73. Allow handling different devices and add support for S2MU005. Signed-off-by: Kaustabh Chakraborty --- drivers/mfd/sec-common.c | 30 ++++++++++++++++++++++++------ include/linux/mfd/samsung/core.h | 3 +++ 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 4c5f4dc2905b..f51c53e7a164 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -86,17 +87,34 @@ static const struct mfd_cell s2mu005_devs[] =3D { MFD_CELL_OF("s2mu005-rgb", NULL, NULL, 0, 0, "samsung,s2mu005-rgb"), }; =20 -static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) +static void sec_pmic_store_rev(struct sec_pmic_dev *sec_pmic) { - unsigned int val; + unsigned int reg, mask, shift; =20 /* For s2mpg1x, the revision is in a different regmap */ if (sec_pmic->device_type =3D=3D S2MPG10) return; =20 - /* For each device type, the REG_ID is always the first register */ - if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val)) - dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val); + switch (sec_pmic->device_type) { + case S2MU005: + reg =3D S2MU005_REG_ID; + mask =3D S2MU005_ID_MASK; + shift =3D S2MU005_ID_SHIFT; + break; + default: + /* For other device types, the REG_ID is always the first register. */ + reg =3D S2MPS11_REG_ID; + mask =3D ~0; + shift =3D 0; + } + + if (!regmap_read(sec_pmic->regmap_pmic, reg, &sec_pmic->revision)) + return; + + sec_pmic->revision &=3D mask; + sec_pmic->revision >>=3D shift; + + dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", sec_pmic->revision); } =20 static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic) @@ -236,7 +254,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, return ret; =20 sec_pmic_configure(sec_pmic); - sec_pmic_dump_rev(sec_pmic); + sec_pmic_store_rev(sec_pmic); =20 return ret; } diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index fc07f7944dcd..ccd1bfa15b85 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -63,6 +63,7 @@ enum sec_device_type { * @irq_base: Base IRQ number for device, required for IRQs * @irq: Generic IRQ number for device * @irq_data: Runtime data structure for IRQ controller + * @revision: Revision number of the device * @wakeup: Whether or not this is a wakeup device */ struct sec_pmic_dev { @@ -74,6 +75,8 @@ struct sec_pmic_dev { int device_type; int irq; struct regmap_irq_chip_data *irq_data[MAX_IRQ_CHIPS]; + + unsigned int revision; }; =20 struct sec_platform_data { --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A344631771B; Thu, 13 Nov 2025 19:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060847; cv=none; b=kwvNtZ2CBmDNApS03yto5KEJ5auHlb8USF+FN7npmVyoDU+AJG8QqPSTvKkAgJ08hNXlcEPYr6lLmJzi/cY04LhEyrPfAt49LBeLtRx/p4oKIBHJeJRjne6oFfh7rM0rXEniGkIJY8YhTGLJeXxSRbI91/NDoCT9ht53RNs0OTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060847; c=relaxed/simple; bh=nv67wrlfTtpEt8muDUPeDzA9Ss5epmezzhocRJlIO3c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iQqi1TnKuhI/ihVyYhzUKaztGI2N/0wpZBwsjRQ8u0XiZYtxdicnM+5nZ/HxRo2ucpYGsI6eXOUnGhoOSztZgFvW5jmUMzr5Bqa4KvfUFn+10Xl+zZMg6yWnbq8zqK1MYl6FDMgB3VeoFuKeIuEPvDxXdxnf9xIONCxTsN3f4sc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=jynbY1bl; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="jynbY1bl" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1079C26783; Thu, 13 Nov 2025 20:07:24 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id r0gJgWxdTwZk; Thu, 13 Nov 2025 20:07:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060842; bh=nv67wrlfTtpEt8muDUPeDzA9Ss5epmezzhocRJlIO3c=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=jynbY1blh/cM4iDRguJbZm+emTl7rXfpTAMJx20LkG2+ch63KIxRtDrA1ySkG/bg8 VQySj87fDrPg6i6btKcrC/+CL9uHbUPVBe03PBECJA80RAzhRNMBFEVyAR8se4nh8i 9wUghSvIJQ/11R1ogqTWQaRDKNtz9Gz1qxjipGqv/zYx6bEAW7x1DFSVfOqAS2tzXD 40iSz0BW1L2Go9eO5Xn0QUWwt0wqH8VbXoBF2B6uaw6dZpLQWmYgyxx4hWXZ7XQSZR nTOzLc50kYsBymqohDxP9hZkoZ6DDqjjh26BeDcSpqsuLp6tyV9A0YeCpDGmZgJG+g 7GHSVlmc1vQOg== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:10 +0530 Subject: [PATCH 09/13] leds: flash: add support for Samsung S2M series PMIC flash LED device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-9-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=14501; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=nv67wrlfTtpEt8muDUPeDzA9Ss5epmezzhocRJlIO3c=; b=IGfhTa9mVlolpn8zeK3unpq7g5eziFg2H+BCzlKrJ0GWmrFsKIED8sBIgwQy5d6V4aEnP+l7Y fq2+9FtqP6UDNvhUwl+qTHJIU43M9DShewCtPBBlY+TTHrGm3T6+py6 X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Add support for flash LEDs found in certain Samsung S2M series PMICs. The device has two channels for LEDs, typically for the back and front cameras in mobile devices. Both channels can be independently controlled, and can be operated in torch or flash modes. The driver includes initial support for the S2MU005 PMIC flash LEDs. Signed-off-by: Kaustabh Chakraborty --- drivers/leds/flash/Kconfig | 12 ++ drivers/leds/flash/Makefile | 1 + drivers/leds/flash/leds-s2m-flash.c | 413 ++++++++++++++++++++++++++++++++= ++++ 3 files changed, 426 insertions(+) diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig index 5e08102a6784..be62e0527742 100644 --- a/drivers/leds/flash/Kconfig +++ b/drivers/leds/flash/Kconfig @@ -114,6 +114,18 @@ config LEDS_RT8515 To compile this driver as a module, choose M here: the module will be called leds-rt8515. =20 +config LEDS_S2M_FLASH + tristate "Samsung S2M series PMICs flash/torch LED support" + depends on LEDS_CLASS + depends on MFD_SEC_CORE + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS + select REGMAP_IRQ + help + This option enables support for the flash/torch LEDs found in + certain Samsung S2M series PMICs, such as the S2MU005. It has + a LED channel dedicated for every physical LED. The LEDs can + be controlled in flash and torch modes. + config LEDS_SGM3140 tristate "LED support for the SGM3140" depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS diff --git a/drivers/leds/flash/Makefile b/drivers/leds/flash/Makefile index 712fb737a428..44e6c1b4beb3 100644 --- a/drivers/leds/flash/Makefile +++ b/drivers/leds/flash/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_LEDS_MAX77693) +=3D leds-max77693.o obj-$(CONFIG_LEDS_QCOM_FLASH) +=3D leds-qcom-flash.o obj-$(CONFIG_LEDS_RT4505) +=3D leds-rt4505.o obj-$(CONFIG_LEDS_RT8515) +=3D leds-rt8515.o +obj-$(CONFIG_LEDS_S2M_FLASH) +=3D leds-s2m-flash.o obj-$(CONFIG_LEDS_SGM3140) +=3D leds-sgm3140.o obj-$(CONFIG_LEDS_SY7802) +=3D leds-sy7802.o obj-$(CONFIG_LEDS_TPS6131X) +=3D leds-tps6131x.o diff --git a/drivers/leds/flash/leds-s2m-flash.c b/drivers/leds/flash/leds-= s2m-flash.c new file mode 100644 index 000000000000..7ea033403b43 --- /dev/null +++ b/drivers/leds/flash/leds-s2m-flash.c @@ -0,0 +1,413 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Flash and Torch LED Driver for Samsung S2M series PMICs. + * + * Copyright (c) 2015 Samsung Electronics Co., Ltd + * Copyright (c) 2025 Kaustabh Chakraborty + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MAX_CHANNELS 2 + +struct s2m_fled { + struct device *dev; + struct regmap *regmap; + struct led_classdev_flash cdev; + struct v4l2_flash *v4l2_flash; + struct mutex lock; + const struct s2m_fled_spec *spec; + unsigned int pmic_revision; + u8 channel; + u8 flash_brightness; + u8 flash_timeout; +}; + +struct s2m_fled_spec { + u8 num_channels; + u32 torch_max_brightness; + u32 flash_min_current_ua; + u32 flash_max_current_ua; + u32 flash_min_timeout_us; + u32 flash_max_timeout_us; + int (*torch_brightness_set_blocking)(struct led_classdev *led_cdev, + enum led_brightness brightness); + const struct led_flash_ops *flash_ops; +}; + +static struct led_classdev_flash *to_cdev_flash(struct led_classdev *cdev) +{ + return container_of(cdev, struct led_classdev_flash, led_cdev); +} + +static struct s2m_fled *to_led_priv(struct led_classdev_flash *cdev) +{ + return container_of(cdev, struct s2m_fled, cdev); +} + +static int s2m_fled_flash_brightness_set(struct led_classdev_flash *cdev, + u32 brightness) +{ + struct s2m_fled *priv =3D to_led_priv(cdev); + struct led_flash_setting *setting =3D &cdev->brightness; + + priv->flash_brightness =3D (brightness - setting->min) / setting->step; + + return 0; +} + +static int s2m_fled_flash_timeout_set(struct led_classdev_flash *cdev, + u32 timeout) +{ + struct s2m_fled *priv =3D to_led_priv(cdev); + struct led_flash_setting *setting =3D &cdev->timeout; + + priv->flash_timeout =3D (timeout - setting->min) / setting->step; + + return 0; +} + +#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS) +static int s2m_fled_flash_external_strobe_set(struct v4l2_flash *v4l2_flas= h, + bool enable) +{ + struct s2m_fled *priv =3D to_led_priv(v4l2_flash->fled_cdev); + + mutex_lock(&priv->lock); + + priv->cdev.ops->strobe_set(&priv->cdev, enable); + + mutex_unlock(&priv->lock); + + return 0; +} + +static const struct v4l2_flash_ops s2m_fled_v4l2_flash_ops =3D { + .external_strobe_set =3D s2m_fled_flash_external_strobe_set, +}; +#else +static const struct v4l2_flash_ops s2m_fled_v4l2_flash_ops; +#endif + +static int s2mu005_fled_torch_brightness_set(struct led_classdev *cdev, + enum led_brightness value) +{ + struct s2m_fled *priv =3D to_led_priv(to_cdev_flash(cdev)); + struct regmap *regmap =3D priv->regmap; + u8 channel =3D priv->channel; + unsigned int reg_enable; + int ret; + + mutex_lock(&priv->lock); + + /* + * Get the LED enable register address. Revision EVT0 has the + * register at CTRL4, while EVT1 and higher have it at CTRL6. + */ + if (priv->pmic_revision =3D=3D 0) + reg_enable =3D S2MU005_REG_FLED_CTRL4; + else + reg_enable =3D S2MU005_REG_FLED_CTRL6; + + if (value =3D=3D LED_OFF) { + ret =3D regmap_clear_bits(regmap, reg_enable, + S2MU005_FLED_TORCH_EN(channel)); + if (ret < 0) + dev_err(priv->dev, "failed to disable torch LED\n"); + goto unlock; + } + + ret =3D regmap_update_bits(regmap, S2MU005_REG_FLED_CH_CTRL1(channel), + S2MU005_FLED_TORCH_IOUT, + FIELD_PREP(S2MU005_FLED_TORCH_IOUT, value - 1)); + if (ret < 0) { + dev_err(priv->dev, "failed to set torch current\n"); + goto unlock; + } + + ret =3D regmap_set_bits(regmap, reg_enable, S2MU005_FLED_TORCH_EN(channel= )); + if (ret < 0) { + dev_err(priv->dev, "failed to enable torch LED\n"); + goto unlock; + } + +unlock: + mutex_unlock(&priv->lock); + + return ret; +} + +static int s2mu005_fled_flash_strobe_set(struct led_classdev_flash *cdev, + bool state) +{ + struct s2m_fled *priv =3D to_led_priv(cdev); + struct regmap *regmap =3D priv->regmap; + u8 channel =3D priv->channel; + unsigned int reg_enable; + int ret; + + mutex_lock(&priv->lock); + + /* + * Get the LED enable register address. Revision EVT0 has the + * register at CTRL4, while EVT1 and higher have it at CTRL6. + */ + if (priv->pmic_revision =3D=3D 0) + reg_enable =3D S2MU005_REG_FLED_CTRL4; + else + reg_enable =3D S2MU005_REG_FLED_CTRL6; + + ret =3D regmap_clear_bits(regmap, reg_enable, S2MU005_FLED_FLASH_EN(chann= el)); + if (ret < 0) { + dev_err(priv->dev, "failed to disable flash LED\n"); + goto unlock; + } + + if (!state) + goto unlock; + + ret =3D regmap_update_bits(regmap, S2MU005_REG_FLED_CH_CTRL0(channel), + S2MU005_FLED_FLASH_IOUT, + FIELD_PREP(S2MU005_FLED_FLASH_IOUT, + priv->flash_brightness)); + if (ret < 0) { + dev_err(priv->dev, "failed to set flash brightness\n"); + goto unlock; + } + + ret =3D regmap_update_bits(regmap, S2MU005_REG_FLED_CH_CTRL3(channel), + S2MU005_FLED_FLASH_TIMEOUT, + FIELD_PREP(S2MU005_FLED_FLASH_TIMEOUT, + priv->flash_timeout)); + if (ret < 0) { + dev_err(priv->dev, "failed to set flash timeout\n"); + goto unlock; + } + + ret =3D regmap_set_bits(regmap, reg_enable, S2MU005_FLED_FLASH_EN(channel= )); + if (ret < 0) { + dev_err(priv->dev, "failed to enable flash LED\n"); + goto unlock; + } + +unlock: + mutex_unlock(&priv->lock); + + return 0; +} + +static int s2mu005_fled_flash_strobe_get(struct led_classdev_flash *cdev, + bool *state) +{ + struct s2m_fled *priv =3D to_led_priv(cdev); + struct regmap *regmap =3D priv->regmap; + u8 channel =3D priv->channel; + u32 val; + int ret; + + mutex_lock(&priv->lock); + + ret =3D regmap_read(regmap, S2MU005_REG_FLED_STATUS, &val); + if (ret < 0) { + dev_err(priv->dev, "failed to fetch LED status"); + goto unlock; + } + + *state =3D !!(val & S2MU005_FLED_FLASH_STATUS(channel)); + +unlock: + mutex_unlock(&priv->lock); + + return ret; +} + +static const struct led_flash_ops s2mu005_fled_flash_ops =3D { + .flash_brightness_set =3D s2m_fled_flash_brightness_set, + .timeout_set =3D s2m_fled_flash_timeout_set, + .strobe_set =3D s2mu005_fled_flash_strobe_set, + .strobe_get =3D s2mu005_fled_flash_strobe_get, +}; + +static const struct s2m_fled_spec s2mu005_fled_spec =3D { + .num_channels =3D 2, + .torch_max_brightness =3D 16, + .flash_min_current_ua =3D 25000, + .flash_max_current_ua =3D 375000, /* 400000 causes flickering */ + .flash_min_timeout_us =3D 62000, + .flash_max_timeout_us =3D 992000, + .torch_brightness_set_blocking =3D s2mu005_fled_torch_brightness_set, + .flash_ops =3D &s2mu005_fled_flash_ops, +}; + +static int s2m_fled_init_channel(struct device *dev, struct fwnode_handle = *fwnp, + struct s2m_fled *priv) +{ + struct led_classdev *led =3D &priv->cdev.led_cdev; + struct led_init_data init_data =3D {}; + struct v4l2_flash_config v4l2_cfg =3D {}; + int ret; + + led->max_brightness =3D priv->spec->torch_max_brightness; + led->brightness_set_blocking =3D priv->spec->torch_brightness_set_blockin= g; + led->flags |=3D LED_DEV_CAP_FLASH; + + priv->cdev.timeout.min =3D priv->spec->flash_min_timeout_us; + priv->cdev.timeout.step =3D priv->spec->flash_min_timeout_us; + priv->cdev.timeout.max =3D priv->spec->flash_max_timeout_us; + priv->cdev.timeout.val =3D priv->spec->flash_max_timeout_us; + + priv->cdev.brightness.min =3D priv->spec->flash_min_current_ua; + priv->cdev.brightness.step =3D priv->spec->flash_min_current_ua; + priv->cdev.brightness.max =3D priv->spec->flash_max_current_ua; + priv->cdev.brightness.val =3D priv->spec->flash_max_current_ua; + + s2m_fled_flash_timeout_set(&priv->cdev, priv->cdev.timeout.val); + s2m_fled_flash_brightness_set(&priv->cdev, priv->cdev.brightness.val); + + priv->cdev.ops =3D priv->spec->flash_ops; + + init_data.fwnode =3D fwnp; + ret =3D devm_led_classdev_flash_register_ext(dev, &priv->cdev, &init_data= ); + if (ret < 0) { + dev_err(dev, "failed to create LED flash device\n"); + return ret; + } + + v4l2_cfg.intensity.min =3D priv->spec->flash_min_current_ua; + v4l2_cfg.intensity.step =3D priv->spec->flash_min_current_ua; + v4l2_cfg.intensity.max =3D priv->spec->flash_max_current_ua; + v4l2_cfg.intensity.val =3D priv->spec->flash_max_current_ua; + + v4l2_cfg.has_external_strobe =3D true; + + priv->v4l2_flash =3D v4l2_flash_init(dev, fwnp, &priv->cdev, + &s2m_fled_v4l2_flash_ops, &v4l2_cfg); + if (IS_ERR(priv->v4l2_flash)) { + dev_err(dev, "failed to create V4L2 flash device\n"); + v4l2_flash_release(priv->v4l2_flash); + return PTR_ERR(priv->v4l2_flash); + } + + return devm_add_action_or_reset(dev, (void *)v4l2_flash_release, + priv->v4l2_flash); +} + +static int s2m_fled_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sec_pmic_dev *pmic_drvdata =3D dev_get_drvdata(dev->parent); + struct s2m_fled *priv; + struct fwnode_handle *child; + struct regmap *regmap; + const struct s2m_fled_spec *spec; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv) * MAX_CHANNELS, GFP_KERNEL); + if (!priv) + return dev_err_probe(dev, -ENOMEM, "failed to allocate driver private\n"= ); + + platform_set_drvdata(pdev, priv); + regmap =3D pmic_drvdata->regmap_pmic; + + switch (platform_get_device_id(pdev)->driver_data) { + case S2MU005: + spec =3D &s2mu005_fled_spec; + /* Enable the LED channels. */ + ret =3D regmap_set_bits(regmap, S2MU005_REG_FLED_CTRL1, + S2MU005_FLED_CH_EN); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to enable LED channels\n"); + break; + default: + return dev_err_probe(dev, -ENODEV, + "device type %d is not supported by driver\n", + pmic_drvdata->device_type); + } + + device_for_each_child_node(dev, child) { + u32 reg; + + if (fwnode_property_read_u32(child, "reg", ®)) + goto next_child; + + if (reg >=3D spec->num_channels) { + dev_warn(dev, "channel %d is non-existent\n", reg); + goto next_child; + } + + if (priv[reg].dev) { + dev_warn(dev, "duplicate node for channel %d\n", reg); + goto next_child; + } + + priv[reg].dev =3D dev; + priv[reg].regmap =3D regmap; + priv[reg].channel =3D (u8)reg; + priv[reg].spec =3D spec; + priv[reg].pmic_revision =3D pmic_drvdata->revision; + + ret =3D devm_mutex_init(dev, &priv[reg].lock); + if (ret) + return dev_err_probe(dev, ret, "failed to create mutex lock\n"); + + ret =3D s2m_fled_init_channel(dev, child, &priv[reg]); + if (ret < 0) + dev_warn(dev, "channel init failed (%d)\n", ret); + +next_child: + fwnode_handle_put(child); + } + + return 0; +} + +static const struct platform_device_id s2m_fled_id_table[] =3D { + { "s2mu005-flash", S2MU005 }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(platform, s2m_fled_id_table); + +#ifdef CONFIG_OF +/* + * Device is instantiated through parent MFD device and device matching + * is done through platform_device_id. + * + * However if device's DT node contains proper compatible and driver is + * built as a module, then the *module* matching will be done through DT + * aliases. This requires of_device_id table. In the same time this will + * not change the actual *device* matching so do not add .of_match_table. + */ +static const struct of_device_id s2m_fled_of_match_table[] =3D { + { + .compatible =3D "samsung,s2mu005-flash", + .data =3D (void *)S2MU005, + }, { + /* sentinel */ + }, +}; +MODULE_DEVICE_TABLE(of, s2m_fled_of_match_table); +#endif + +static struct platform_driver s2m_fled_driver =3D { + .driver =3D { + .name =3D "s2m-flash", + }, + .probe =3D s2m_fled_probe, + .id_table =3D s2m_fled_id_table, +}; +module_platform_driver(s2m_fled_driver); + +MODULE_DESCRIPTION("Flash/Torch LED Driver For Samsung S2M Series PMICs"); +MODULE_AUTHOR("Kaustabh Chakraborty "); +MODULE_LICENSE("GPL"); --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE34D31960F; Thu, 13 Nov 2025 19:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060862; cv=none; b=rgoMn4tq4VZv43A+F3AN59q0e8ecztNHFGrNW8zJVFEIfyxdKte96XhOHDC7ZTljFv+EOdGQ3K0OLLXrBuflPgIcRszsTX3hQnKerwd9CU+5hHwZ2/dCVG4t4Cz1rrICGPu6Szy0Ey+S3tC/JoSmb0ZLF5/ffO1pVmjkxOWiNcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060862; c=relaxed/simple; bh=6ecvTegFyMzxsAnk+4AU+jFqoEFaRKF/eu46kzs9gz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ulMNuG4lbb1YV471AQ63MownFyO60bSVW1QlD+Dsu+xrdt7bd0sPsxlWuvxKyWLFWuyMprO1JBYT6KB+DQFEBdQb0M6HMhhH4LSCjo+hpkSO/nopllcitNBy62kSkmvSfC3SdtCzNbwRJuVdkVtpocIPT9Dt9UoLj3DpJ5gcKKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=OhEnhLJl; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="OhEnhLJl" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5FF3F26746; Thu, 13 Nov 2025 20:07:38 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id J14krhTy79eI; Thu, 13 Nov 2025 20:07:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060857; bh=6ecvTegFyMzxsAnk+4AU+jFqoEFaRKF/eu46kzs9gz4=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=OhEnhLJlVMlWXRkP/g//C6jAjUiq7Hr4AAF8t500Ur6p7ebjmR2p0BEMneWkTw4mQ Rtb/OIpaY0+Zly5g6Hqslh/eFjfKYyB5VIDb2K++IEcuD+O9vGSoOnr+w47v4gWwAU WAF7xDWvkmwnf/bPtQrxiXvsoYUen7PX9m88AC4YSjd6BiE1nEdOMoaOVfPqz1d2qk IOdrQdhR++ssG5nmc9jVpY1RJnCTee6OTj6eOA0ndDznyPDZk9CYVwolp5zr93oPrT OyCs9/pqBS7Ow51xlA7mNJLaqf8EY1dJ4fnqZDzRHk7ykkXT26dy0POm7zn7i8BNDs zvC2182jUFX3g== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:11 +0530 Subject: [PATCH 10/13] leds: rgb: add support for Samsung S2M series PMIC RGB LED device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-10-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=15255; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=6ecvTegFyMzxsAnk+4AU+jFqoEFaRKF/eu46kzs9gz4=; b=+D/jAR5AApsTwKtOgKc5YKZDOozSGrXPxepplNlaCP3SKIb0A+kClCafjdr8FNuXKFUi0TJ9Q h9wRWbGqkuLCaU8dHQL5xJ9sTkyYmuOja75eGPqAHv3JyrkotQicLmh X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Add support for the RGB LEDs found in certain Samsung S2M series PMICs. The device has three LED channels, controlled as a single device. These LEDs are typically used as status indicators in mobile phones. The driver includes initial support for the S2MU005 PMIC RGB LEDs. Signed-off-by: Kaustabh Chakraborty --- drivers/leds/rgb/Kconfig | 11 + drivers/leds/rgb/Makefile | 1 + drivers/leds/rgb/leds-s2m-rgb.c | 462 ++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 474 insertions(+) diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig index 222d943d826a..e38ba1bd434e 100644 --- a/drivers/leds/rgb/Kconfig +++ b/drivers/leds/rgb/Kconfig @@ -62,6 +62,17 @@ config LEDS_QCOM_LPG =20 If compiled as a module, the module will be named leds-qcom-lpg. =20 +config LEDS_S2M_RGB + tristate "Samsung S2M series PMICs RGB LED support" + depends on LEDS_CLASS + depends on MFD_SEC_CORE + select REGMAP_IRQ + help + This option enables support for the S2MU005 RGB LEDs. These + devices have three LED channels, with 8-bit brightness control + for each channel. It's usually found in mobile phones as + status indicators. + config LEDS_MT6370_RGB tristate "LED Support for MediaTek MT6370 PMIC" depends on MFD_MT6370 diff --git a/drivers/leds/rgb/Makefile b/drivers/leds/rgb/Makefile index a501fd27f179..fc9d38fa60e1 100644 --- a/drivers/leds/rgb/Makefile +++ b/drivers/leds/rgb/Makefile @@ -5,4 +5,5 @@ obj-$(CONFIG_LEDS_KTD202X) +=3D leds-ktd202x.o obj-$(CONFIG_LEDS_NCP5623) +=3D leds-ncp5623.o obj-$(CONFIG_LEDS_PWM_MULTICOLOR) +=3D leds-pwm-multicolor.o obj-$(CONFIG_LEDS_QCOM_LPG) +=3D leds-qcom-lpg.o +obj-$(CONFIG_LEDS_S2M_RGB) +=3D leds-s2m-rgb.o obj-$(CONFIG_LEDS_MT6370_RGB) +=3D leds-mt6370-rgb.o diff --git a/drivers/leds/rgb/leds-s2m-rgb.c b/drivers/leds/rgb/leds-s2m-rg= b.c new file mode 100644 index 000000000000..2184ae0aec16 --- /dev/null +++ b/drivers/leds/rgb/leds-s2m-rgb.c @@ -0,0 +1,462 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * RGB LED Driver for Samsung S2M series PMICs. + * + * Copyright (c) 2015 Samsung Electronics Co., Ltd + * Copyright (c) 2025 Kaustabh Chakraborty + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct s2m_rgb { + struct device *dev; + struct regmap *regmap; + struct led_classdev_mc cdev; + struct mutex lock; + const struct s2m_rgb_spec *spec; + u8 ramp_up; + u8 ramp_dn; + u8 stay_hi; + u8 stay_lo; +}; + +struct s2m_rgb_spec { + int (*params_apply)(struct s2m_rgb *priv); + int (*params_reset)(struct s2m_rgb *priv); + const u32 *lut_ramp_up; + const size_t lut_ramp_up_len; + const u32 *lut_ramp_dn; + const size_t lut_ramp_dn_len; + const u32 *lut_stay_hi; + const size_t lut_stay_hi_len; + const u32 *lut_stay_lo; + const size_t lut_stay_lo_len; + const unsigned int max_brightness; +}; + +static struct led_classdev_mc *to_cdev_mc(struct led_classdev *cdev) +{ + return container_of(cdev, struct led_classdev_mc, led_cdev); +} + +static struct s2m_rgb *to_rgb_priv(struct led_classdev_mc *cdev) +{ + return container_of(cdev, struct s2m_rgb, cdev); +} + +static int s2m_rgb_lut_calc_timing(const u32 *lut, const size_t len, + const u32 req_time, u8 *idx) +{ + int lo =3D 0; + int hi =3D len - 2; + + /* Bounds checking */ + if (req_time < lut[0] || req_time > lut[len - 1]) + return -EINVAL; + + /* + * Perform a binary search to pick the best timing from the LUT. + * + * The search algorithm picks two consecutive elements of the + * LUT and tries to search the pair between which the requested + * time lies. + */ + while (lo <=3D hi) { + *idx =3D (lo + hi) / 2; + + if ((lut[*idx] <=3D req_time) && (req_time <=3D lut[*idx + 1])) + break; + + if ((req_time < lut[*idx]) && (req_time < lut[*idx + 1])) + hi =3D *idx - 1; + else + lo =3D *idx + 1; + } + + /* + * The searched timing is always less than the requested time. At + * times, the succeeding timing in the LUT is closer thus more + * accurate. Adjust the resulting value if that's the case. + */ + if (abs(req_time - lut[*idx]) > abs(lut[*idx + 1] - req_time)) + (*idx)++; + + return 0; +} + +static int s2m_rgb_brightness_set(struct led_classdev *cdev, + enum led_brightness value) +{ + struct s2m_rgb *priv =3D to_rgb_priv(to_cdev_mc(cdev)); + int ret; + + mutex_lock(&priv->lock); + + led_mc_calc_color_components(&priv->cdev, value); + + if (value =3D=3D LED_OFF) + ret =3D priv->spec->params_reset(priv); + else + ret =3D priv->spec->params_apply(priv); + + mutex_unlock(&priv->lock); + + return ret; +} + +static int s2m_rgb_pattern_set(struct led_classdev *cdev, + struct led_pattern *pattern, u32 len, int repeat) +{ + struct s2m_rgb *priv =3D to_rgb_priv(to_cdev_mc(cdev)); + int brightness_peak =3D 0; + u32 time_hi =3D 0; + u32 time_lo =3D 0; + bool ramp_up_en; + bool ramp_dn_en; + int ret; + int i; + + /* + * The typical pattern supported by this device can be + * represented with the following graph: + * + * 255 T ''''''-. .-'''''''-. + * | '. .' '. + * | \ / \ + * | '. .' '. + * | '-...........-' '- + * 0 +----------------------------------------------------> time (s) + * + * <---- HIGH ----><-- LOW --><-------- HIGH ---------> + * <-----><-------><---------><-------><-----><-------> + * stay_hi ramp_dn stay_lo ramp_up stay_hi ramp_dn + * + * There are two states, named HIGH and LOW. HIGH has a non-zero + * brightness level, while LOW is of zero brightness. The + * pattern provided should mention only one zero and non-zero + * brightness level. The hardware always starts the pattern from + * the HIGH state, as shown in the graph. + * + * The HIGH state can be divided in three somewhat equal timings: + * ramp_up, stay_hi, and ramp_dn. The LOW state has only one + * timing: stay_lo. + */ + + /* Only indefinitely looping patterns are supported. */ + if (repeat !=3D -1) + return -EINVAL; + + /* Pattern should consist of at least two tuples. */ + if (len < 2) + return -EINVAL; + + for (i =3D 0; i < len; i++) { + int brightness =3D pattern[i].brightness; + u32 delta_t =3D pattern[i].delta_t; + + if (brightness) { + /* + * The pattern shold define only one non-zero + * brightness in the HIGH state. The device + * doesn't have any provisions to handle + * multiple peak brightness levels. + */ + if (brightness_peak && brightness_peak !=3D brightness) + return -EINVAL; + + brightness_peak =3D brightness; + time_hi +=3D delta_t; + ramp_dn_en =3D !!delta_t; + } else { + time_lo +=3D delta_t; + ramp_up_en =3D !!delta_t; + } + } + + mutex_lock(&priv->lock); + + /* + * The timings ramp_up, stay_hi, and ramp_dn of the HIGH state + * are roughly equal. Firstly, calculate and set timings for + * ramp_up and ramp_dn (making sure they're exactly equal). + */ + priv->ramp_up =3D 0; + priv->ramp_dn =3D 0; + + if (ramp_up_en) { + ret =3D s2m_rgb_lut_calc_timing(priv->spec->lut_ramp_up, + priv->spec->lut_ramp_up_len, + time_hi / 3, &priv->ramp_up); + if (ret < 0) + goto param_fail; + } + + if (ramp_dn_en) { + ret =3D s2m_rgb_lut_calc_timing(priv->spec->lut_ramp_dn, + priv->spec->lut_ramp_dn_len, + time_hi / 3, &priv->ramp_dn); + if (ret < 0) + goto param_fail; + } + + /* + * Subtract the allocated ramp timings from time_hi (and also + * making sure it doesn't underflow!). The remaining time is + * allocated to stay_hi. + */ + time_hi -=3D min(time_hi, priv->spec->lut_ramp_up[priv->ramp_up]); + time_hi -=3D min(time_hi, priv->spec->lut_ramp_dn[priv->ramp_dn]); + + ret =3D s2m_rgb_lut_calc_timing(priv->spec->lut_stay_hi, + priv->spec->lut_stay_hi_len, time_hi, + &priv->stay_hi); + if (ret < 0) + goto param_fail; + + ret =3D s2m_rgb_lut_calc_timing(priv->spec->lut_stay_lo, + priv->spec->lut_stay_lo_len, time_lo, + &priv->stay_lo); + if (ret < 0) + goto param_fail; + + led_mc_calc_color_components(&priv->cdev, brightness_peak); + ret =3D priv->spec->params_apply(priv); + if (ret < 0) + goto param_fail; + + mutex_unlock(&priv->lock); + + return 0; + +param_fail: + mutex_unlock(&priv->lock); + priv->ramp_up =3D 0; + priv->ramp_dn =3D 0; + priv->stay_hi =3D 0; + priv->stay_lo =3D 0; + + return ret; +} + +static int s2m_rgb_pattern_clear(struct led_classdev *cdev) +{ + struct s2m_rgb *priv =3D to_rgb_priv(to_cdev_mc(cdev)); + int ret; + + mutex_lock(&priv->lock); + + ret =3D priv->spec->params_reset(priv); + + mutex_unlock(&priv->lock); + + return ret; +} + +static int s2mu005_rgb_apply_params(struct s2m_rgb *priv) +{ + struct regmap *regmap =3D priv->regmap; + unsigned int ramp_val =3D 0; + unsigned int stay_val =3D 0; + int ret; + int i; + + ramp_val |=3D FIELD_PREP(S2MU005_RGB_CH_RAMP_UP, priv->ramp_up); + ramp_val |=3D FIELD_PREP(S2MU005_RGB_CH_RAMP_DN, priv->ramp_dn); + + stay_val |=3D FIELD_PREP(S2MU005_RGB_CH_STAY_HI, priv->stay_hi); + stay_val |=3D FIELD_PREP(S2MU005_RGB_CH_STAY_LO, priv->stay_lo); + + ret =3D regmap_write(regmap, S2MU005_REG_RGB_EN, S2MU005_RGB_RESET); + if (ret < 0) { + dev_err(priv->dev, "failed to reset RGB LEDs\n"); + return ret; + } + + for (i =3D 0; i < priv->cdev.num_colors; i++) { + ret =3D regmap_write(regmap, S2MU005_REG_RGB_CH_CTRL(i), + priv->cdev.subled_info[i].brightness); + if (ret < 0) { + dev_err(priv->dev, "failed to set LED brightness\n"); + return ret; + } + + ret =3D regmap_write(regmap, S2MU005_REG_RGB_CH_RAMP(i), ramp_val); + if (ret < 0) { + dev_err(priv->dev, "failed to set ramp timings\n"); + return ret; + } + + ret =3D regmap_write(regmap, S2MU005_REG_RGB_CH_STAY(i), stay_val); + if (ret < 0) { + dev_err(priv->dev, "failed to set stay timings\n"); + return ret; + } + } + + ret =3D regmap_update_bits(regmap, S2MU005_REG_RGB_EN, S2MU005_RGB_SLOPE, + S2MU005_RGB_SLOPE_SMOOTH); + if (ret < 0) { + dev_err(priv->dev, "failed to set ramp slope\n"); + return ret; + } + + return 0; +} + +static int s2mu005_rgb_reset_params(struct s2m_rgb *priv) +{ + struct regmap *regmap =3D priv->regmap; + int ret; + + ret =3D regmap_write(regmap, S2MU005_REG_RGB_EN, S2MU005_RGB_RESET); + if (ret < 0) { + dev_err(priv->dev, "failed to reset RGB LEDs\n"); + return ret; + } + + priv->ramp_up =3D 0; + priv->ramp_dn =3D 0; + priv->stay_hi =3D 0; + priv->stay_lo =3D 0; + + return 0; +} + +static const u32 s2mu005_rgb_lut_ramp[] =3D { + 0, 100, 200, 300, 400, 500, 600, 700, + 800, 1000, 1200, 1400, 1600, 1800, 2000, 2200, +}; + +static const u32 s2mu005_rgb_lut_stay_hi[] =3D { + 100, 200, 300, 400, 500, 750, 1000, 1250, + 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3250, +}; + +static const u32 s2mu005_rgb_lut_stay_lo[] =3D { + 0, 500, 1000, 1500, 2000, 2500, 3000, 3500, + 4000, 4500, 5000, 6000, 7000, 8000, 10000, 12000, +}; + +static const struct s2m_rgb_spec s2mu005_rgb_spec =3D { + .params_apply =3D s2mu005_rgb_apply_params, + .params_reset =3D s2mu005_rgb_reset_params, + .lut_ramp_up =3D s2mu005_rgb_lut_ramp, + .lut_ramp_up_len =3D ARRAY_SIZE(s2mu005_rgb_lut_ramp), + .lut_ramp_dn =3D s2mu005_rgb_lut_ramp, + .lut_ramp_dn_len =3D ARRAY_SIZE(s2mu005_rgb_lut_ramp), + .lut_stay_hi =3D s2mu005_rgb_lut_stay_hi, + .lut_stay_hi_len =3D ARRAY_SIZE(s2mu005_rgb_lut_stay_hi), + .lut_stay_lo =3D s2mu005_rgb_lut_stay_lo, + .lut_stay_lo_len =3D ARRAY_SIZE(s2mu005_rgb_lut_stay_lo), + .max_brightness =3D 255, +}; + +static struct mc_subled s2mu005_rgb_subled_info[] =3D { + { + .channel =3D 0, + .color_index =3D LED_COLOR_ID_BLUE, + }, { + .channel =3D 1, + .color_index =3D LED_COLOR_ID_GREEN, + }, { + .channel =3D 2, + .color_index =3D LED_COLOR_ID_RED, + }, +}; + +static int s2m_rgb_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sec_pmic_dev *pmic_drvdata =3D dev_get_drvdata(dev->parent); + struct s2m_rgb *priv; + struct led_init_data init_data =3D {}; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return dev_err_probe(dev, -ENOMEM, "failed to allocate driver private\n"= ); + + platform_set_drvdata(pdev, priv); + priv->dev =3D dev; + priv->regmap =3D pmic_drvdata->regmap_pmic; + + switch (platform_get_device_id(pdev)->driver_data) { + case S2MU005: + priv->spec =3D &s2mu005_rgb_spec; + priv->cdev.subled_info =3D s2mu005_rgb_subled_info; + priv->cdev.num_colors =3D ARRAY_SIZE(s2mu005_rgb_subled_info); + break; + default: + return dev_err_probe(dev, -ENODEV, + "device type %d is not supported by driver\n", + pmic_drvdata->device_type); + } + + priv->cdev.led_cdev.max_brightness =3D priv->spec->max_brightness; + priv->cdev.led_cdev.brightness_set_blocking =3D s2m_rgb_brightness_set; + priv->cdev.led_cdev.pattern_set =3D s2m_rgb_pattern_set; + priv->cdev.led_cdev.pattern_clear =3D s2m_rgb_pattern_clear; + + ret =3D devm_mutex_init(dev, &priv->lock); + if (ret) + return dev_err_probe(dev, ret, "failed to create mutex lock\n"); + + init_data.fwnode =3D of_fwnode_handle(dev->of_node); + ret =3D devm_led_classdev_multicolor_register_ext(dev, &priv->cdev, + &init_data); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to create LED device\n"); + + return 0; +} + +static const struct platform_device_id s2m_rgb_id_table[] =3D { + { "s2mu005-rgb", S2MU005 }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(platform, s2m_rgb_id_table); + +#ifdef CONFIG_OF +/* + * Device is instantiated through parent MFD device and device matching + * is done through platform_device_id. + * + * However if device's DT node contains proper compatible and driver is + * built as a module, then the *module* matching will be done through DT + * aliases. This requires of_device_id table. In the same time this will + * not change the actual *device* matching so do not add .of_match_table. + */ +static const struct of_device_id s2m_rgb_of_match_table[] =3D { + { + .compatible =3D "samsung,s2mu005-rgb", + .data =3D (void *)S2MU005, + }, { + /* sentinel */ + }, +}; +MODULE_DEVICE_TABLE(of, s2m_rgb_of_match_table); +#endif + +static struct platform_driver s2m_rgb_driver =3D { + .driver =3D { + .name =3D "s2m-rgb", + }, + .probe =3D s2m_rgb_probe, + .id_table =3D s2m_rgb_id_table, +}; +module_platform_driver(s2m_rgb_driver); + +MODULE_DESCRIPTION("RGB LED Driver For Samsung S2M Series PMICs"); +MODULE_AUTHOR("Kaustabh Chakraborty "); +MODULE_LICENSE("GPL"); --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DAA31A041; Thu, 13 Nov 2025 19:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060874; cv=none; b=Ma/zzlELxpd1qo9iKF/S07HN6GsaHQUnGBhPgb0WVyUH8gbSD8GUCqQw0opVRX10I1wsvWqd+KKB9G9E8zhaxk/sv2ip8wVZsqoKY9bXQtKvAj/SUstGTAawiALt2l6gx2k0ZzXUramOi9INkwBHaHNkNjLLKBsn94C7GYiORHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060874; c=relaxed/simple; bh=zxRedWwjE9b/E44vMq9L4VTLOedMXWqZjIhevLHmhjY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CiklEtpKGC2Qv5Q81yU3NeR4G6IrdTuXVIIiB/s6BQCpiO25yH633smupJiACfIRCnumaDpBPd2NB008tjfCXdFFsl1yWakuo8pSjM0L0dKrJ+ZflwwXixT77Qe6jyCcHBFmRcDwGnMsrVu9xRcrAFTnPOQDGwKVASycNYW+UBc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=gojeYeR3; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="gojeYeR3" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 39B382666C; Thu, 13 Nov 2025 20:07:51 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SybkkiTBVzdK; Thu, 13 Nov 2025 20:07:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060870; bh=zxRedWwjE9b/E44vMq9L4VTLOedMXWqZjIhevLHmhjY=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=gojeYeR32NZDirTx6OYm6pLvjGXw5A0ZpJvGSQsU3wXQl+U67/6noUQASz0z5Ez1J PsKPcjwjAQJbzmRZ5+QYdTKOI0qLgEWBWdEJ21NYMs2UOPMHl4vzjTc3Acl/5RkVxf T70igAtqn/WXCAx6UxW8BF9cALXFsPZIJUmOqjxKNpm1FWIBHQ8OEFCIR7EFfANday tq0pXFPRA96tM3VMhb6+lr1MO8ZqbH9CuBMKasGNSryo2Jp3MUe2MFrqjFAXgrz8/f KIWk2e1Z6pu3BVcl6WW6fYdEb0wTf2JRDgk/bUFtIuSSnvm9kALA25+Kq1IXnpNHiJ OU8hbIvTJxfRg== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:12 +0530 Subject: [PATCH 11/13] Documentation: leds: document pattern behavior of Samsung S2M series PMIC RGB LEDs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-11-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=3290; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=zxRedWwjE9b/E44vMq9L4VTLOedMXWqZjIhevLHmhjY=; b=vofBNSa6jIuiouTtAJL+K+XlnmfcS4Q2YxqiOlofVrzFgxhT30nk8atXEx1tsRQLjjSBNMpue hGN2BlTNNUiDfDjrMfzvBact965CnrBKFPPmSNUmR/2YGHHxGsQLPek X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Add documentation to describe how hardware patterns (as defined by the documentation of led-class-multicolor) are parsed and implemented by the Samsung S2M series PMIC RGB LED driver. Signed-off-by: Kaustabh Chakraborty --- Documentation/leds/index.rst | 1 + Documentation/leds/leds-s2m-rgb.rst | 60 +++++++++++++++++++++++++++++++++= ++++ 2 files changed, 61 insertions(+) diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst index 76fae171039c..05d8e8517a80 100644 --- a/Documentation/leds/index.rst +++ b/Documentation/leds/index.rst @@ -27,6 +27,7 @@ LEDs leds-lp55xx leds-mlxcpld leds-mt6370-rgb + leds-s2m-rgb leds-sc27xx leds-st1202 leds-qcom-lpg diff --git a/Documentation/leds/leds-s2m-rgb.rst b/Documentation/leds/leds-= s2m-rgb.rst new file mode 100644 index 000000000000..cf91f0238093 --- /dev/null +++ b/Documentation/leds/leds-s2m-rgb.rst @@ -0,0 +1,60 @@ +.. SPDX-License-Identifier: GPL-2.0 + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D +Samsung S2M Series PMIC RGB LED Driver +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Description +----------- + +The RGB LED on the S2M series PMIC hardware features a three-channel LED t= hat is +grouped together as a single device. Furthermore, the it supports 8-bit +brightness control for each channel. This LED is typically used as a status +indicator in mobile devices. It also supports various parameters for hardw= are +patterns. + +The hardware pattern can be programmed using the "pattern" trigger, using = the +hw_pattern attribute. + +/sys/class/leds//repeat +---------------------------- + +The hardware supports only indefinitely repeating patterns. The repeat +attribute must be set to -1 for hardware patterns to function. + +/sys/class/leds//hw_pattern +-------------------------------- + +Specify a hardware pattern for the RGB LEDs. + +The pattern is a series of brightness levels and durations in milliseconds. +There should be only one non-zero brightness level. Unlike the results +described in leds-trigger-pattern, the transitions between on and off stat= es +are smoothed out by the hardware. + +Simple pattern:: + + "255 3000 0 1000" + + 255 -+ ''''''-. .-'''''''-. + | '. .' '. + | \ / \ + | '. .' '. + | '-.......-' '- + 0 -+-------+-------+-------+-------+-------+-------+--> time (s) + 0 1 2 3 4 5 6 + +As described in leds-trigger-pattern, it is also possible to use zero-leng= th +entries to disable the ramping mechanism. + +On-Off pattern:: + + "255 1000 255 0 0 1000 0 0" + + 255 -+ ------+ +-------+ +-------+ + | | | | | | + | | | | | | + | | | | | | + | +-------+ +-------+ +------- + 0 -+-------+-------+-------+-------+-------+-------+--> time (s) + 0 1 2 3 4 5 6 --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39A431A7FF; Thu, 13 Nov 2025 19:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060900; cv=none; b=V4GHZKmXnUKRpF96xocc85ON4T8xLe0xBBJOBm6QvPtb8uhZGoMG8Cnc89EHhRu6Sr670s1SpRdB38cnl0eMqNy+I8O8IOFZl4+jS2Z8ph8Uy0ziLvLm9SX6COwPIlHk5yFvRF/8lJXRJKL4gv9I1VZlN9ROrODCbHFLKjmkE/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060900; c=relaxed/simple; bh=TpT1IKFG1YYJ6rXNq74OVbWAud79/Inf1eMbHTQeemk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s8ELaB0Ui6j5EGRhVC9AgMK7qH12o57y8Ob8OmKIt3DrKGmnJwqYprHFxF9mQ7oD/SuEJ99srFC/SfmEteeDK8S8oaO6t5a4oTQUSFZ6x3tWYN6UY2rzskj3mYOLg21qg2AXEgHWOqLZN+8EqmQ/QOclJi4a/H5Vv3Ivckim66A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=R7CP+25g; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="R7CP+25g" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4A16126723; Thu, 13 Nov 2025 20:08:15 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kLkA_Opwh9vF; Thu, 13 Nov 2025 20:08:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060894; bh=TpT1IKFG1YYJ6rXNq74OVbWAud79/Inf1eMbHTQeemk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=R7CP+25gqfecXbbQ0+VDPTuSw5huEYlEVpMNeBHs5A2Z3RPdJcqzBOEvUb69PFRtn Y7zWhalZ9Bu/A4lw3Z4/QDrijo+sBGRAtyjmLW+MgtOiuJc3P6eN1ePIw3RDd+x46/ zukPkdruSrfurd83s04Bx3c3ulqWIRZE+EL1M/+YFk7Lz2oggivyp3d71dAjn5d0p9 HrM7zW7qJjFzx7taiNeJm4mxY9YeG6KdVTmqpufwJ7UwF04PygVo6yJr70kDBLTtb3 zfbetmM5DK1XmCWEFKD32/LJEUzvyHV0A1/28ECXQNIC5nD5+JUWYaWr09vmveDtYe 7azQLaZIB2L8g== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:13 +0530 Subject: [PATCH 12/13] extcon: add support for Samsung S2M series PMIC extcon devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-12-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=12449; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=TpT1IKFG1YYJ6rXNq74OVbWAud79/Inf1eMbHTQeemk=; b=9RAtfupnnemdrIOOualRnhVRkMTkMB/MqMtGR2bWnU/Upw7TaCWtE55BBVgLzifsJs4KWYjOn VkBwBq4sd3OBo5rN2yobgURcIEVWdUJ3APrnMPLupwasP2WXxansECl X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Add a driver for MUIC devices found in certain Samsung S2M series PMICs These are USB port accessory detectors. These devices report multiple cable states depending on the ID-GND resistance measured by an internal ADC. The driver includes initial support for the S2MU005 PMIC extcon. Signed-off-by: Kaustabh Chakraborty --- drivers/extcon/Kconfig | 10 ++ drivers/extcon/Makefile | 1 + drivers/extcon/extcon-s2m.c | 355 ++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 366 insertions(+) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index aec46bf03302..89b3427175f7 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -182,6 +182,16 @@ config EXTCON_RT8973A and switch that is optimized to protect low voltage system from abnormal high input voltage (up to 28V). =20 +config EXTCON_S2M + tristate "Samsung S2M series PMIC EXTCON support" + depends on MFD_SEC_CORE + select REGMAP_IRQ + help + This option enables support for MUIC devices found in certain + Samsung S2M series PMICs, such as the S2MU005. These devices + have internal ADCs measuring the ID-GND resistance, thereby + can be used as a USB port accessory detector. + config EXTCON_SM5502 tristate "Silicon Mitus SM5502/SM5504/SM5703 EXTCON support" depends on I2C diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile index 6482f2bfd661..e3939786f347 100644 --- a/drivers/extcon/Makefile +++ b/drivers/extcon/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_EXTCON_PALMAS) +=3D extcon-palmas.o obj-$(CONFIG_EXTCON_PTN5150) +=3D extcon-ptn5150.o obj-$(CONFIG_EXTCON_QCOM_SPMI_MISC) +=3D extcon-qcom-spmi-misc.o obj-$(CONFIG_EXTCON_RT8973A) +=3D extcon-rt8973a.o +obj-$(CONFIG_EXTCON_S2M) +=3D extcon-s2m.o obj-$(CONFIG_EXTCON_SM5502) +=3D extcon-sm5502.o obj-$(CONFIG_EXTCON_USB_GPIO) +=3D extcon-usb-gpio.o obj-$(CONFIG_EXTCON_USBC_CROS_EC) +=3D extcon-usbc-cros-ec.o diff --git a/drivers/extcon/extcon-s2m.c b/drivers/extcon/extcon-s2m.c new file mode 100644 index 000000000000..b27ee9e79bb6 --- /dev/null +++ b/drivers/extcon/extcon-s2m.c @@ -0,0 +1,355 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Extcon Driver for Samsung S2M series PMICs. + * + * Copyright (c) 2015 Samsung Electronics Co., Ltd + * Copyright (C) 2025 Kaustabh Chakraborty + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct s2m_muic { + struct device *dev; + struct regmap *regmap; + struct extcon_dev *extcon; + struct s2m_muic_irq_data *irq_data; + const unsigned int *extcon_cable; + bool attached; +}; + +struct s2m_muic_irq_data { + const enum s2mu005_muic_irq irq; + const char *name; + int (* const handler)(struct s2m_muic *); + int virq; +}; + +static int s2mu005_muic_detach(struct s2m_muic *priv) +{ + int ret; + int i; + + ret =3D regmap_set_bits(priv->regmap, S2MU005_REG_MUIC_CTRL1, + S2MU005_MUIC_MAN_SW); + if (ret < 0) { + dev_err(priv->dev, "failed to disable manual switching\n"); + return ret; + } + + ret =3D regmap_set_bits(priv->regmap, S2MU005_REG_MUIC_CTRL3, + S2MU005_MUIC_ONESHOT_ADC); + if (ret < 0) { + dev_err(priv->dev, "failed to enable ADC oneshot mode\n"); + return ret; + } + + ret =3D regmap_clear_bits(priv->regmap, S2MU005_REG_MUIC_SWCTRL, ~0); + if (ret < 0) { + dev_err(priv->dev, "failed to clear switch control register\n"); + return ret; + } + + /* Find all set states and clear them */ + for (i =3D 0; priv->extcon_cable[i]; i++) { + unsigned int state =3D priv->extcon_cable[i]; + + if (extcon_get_state(priv->extcon, state) =3D=3D true) + extcon_set_state_sync(priv->extcon, state, false); + } + + priv->attached =3D false; + + return 0; +} + +static int s2mu005_muic_attach(struct s2m_muic *priv) +{ + unsigned int type; + int ret; + + /* If any device is already attached, detach it */ + if (priv->attached) { + s2mu005_muic_detach(priv); + msleep(100); + } + + ret =3D regmap_read(priv->regmap, S2MU005_REG_MUIC_DEV1, &type); + if (ret < 0) { + dev_err(priv->dev, "failed to read DEV1 register\n"); + return ret; + } + + /* + * All USB connections which require communication via its D+ + * and D- wires need it. + */ + if (type & (S2MU005_MUIC_OTG | S2MU005_MUIC_DCP | S2MU005_MUIC_SDP)) { + ret =3D regmap_update_bits(priv->regmap, S2MU005_REG_MUIC_SWCTRL, + S2MU005_MUIC_DM_DP, + S2MU005_MUIC_DM_DP_USB); + if (ret < 0) { + dev_err(priv->dev, "failed to configure DM/DP pins\n"); + return ret; + } + } + + /* + * For OTG connections, enable manual switching and ADC oneshot + * mode. Since the port will now be supplying power, the + * internal ADC (measuring the ID-GND resistance) is made to + * poll periodically for any changes, so as to prevent any + * damages due to power. + */ + if (type & S2MU005_MUIC_OTG) { + ret =3D regmap_clear_bits(priv->regmap, S2MU005_REG_MUIC_CTRL1, + S2MU005_MUIC_MAN_SW); + if (ret < 0) { + dev_err(priv->dev, "failed to enable manual switching\n"); + return ret; + } + + ret =3D regmap_clear_bits(priv->regmap, S2MU005_REG_MUIC_CTRL3, + S2MU005_MUIC_ONESHOT_ADC); + if (ret < 0) { + dev_err(priv->dev, "failed to disable ADC oneshot mode\n"); + return ret; + } + } + + switch (type) { + case S2MU005_MUIC_OTG: + dev_dbg(priv->dev, "USB OTG connection detected\n"); + extcon_set_state_sync(priv->extcon, EXTCON_USB_HOST, true); + priv->attached =3D true; + break; + case S2MU005_MUIC_CDP: + dev_dbg(priv->dev, "USB CDP connection detected\n"); + extcon_set_state_sync(priv->extcon, EXTCON_USB, true); + extcon_set_state_sync(priv->extcon, EXTCON_CHG_USB_CDP, true); + priv->attached =3D true; + break; + case S2MU005_MUIC_SDP: + dev_dbg(priv->dev, "USB SDP connection detected\n"); + extcon_set_state_sync(priv->extcon, EXTCON_USB, true); + extcon_set_state_sync(priv->extcon, EXTCON_CHG_USB_SDP, true); + priv->attached =3D true; + break; + case S2MU005_MUIC_DCP: + dev_dbg(priv->dev, "USB DCP connection detected\n"); + extcon_set_state_sync(priv->extcon, EXTCON_USB, true); + extcon_set_state_sync(priv->extcon, EXTCON_CHG_USB_DCP, true); + priv->attached =3D true; + break; + case S2MU005_MUIC_UART: + dev_dbg(priv->dev, "UART connection detected\n"); + extcon_set_state_sync(priv->extcon, EXTCON_JIG, true); + priv->attached =3D true; + break; + } + + if (!priv->attached) + dev_warn(priv->dev, "failed to recognize the device attached\n"); + + return ret; +} + +static int s2mu005_muic_init(struct s2m_muic *priv) +{ + int ret =3D 0; + + ret =3D regmap_update_bits(priv->regmap, S2MU005_REG_MUIC_LDOADC_L, + S2MU005_MUIC_VSET, S2MU005_MUIC_VSET_3P0V); + if (ret < 0) { + dev_err(priv->dev, "failed to set internal ADC voltage regulator\n"); + return ret; + } + + ret =3D regmap_update_bits(priv->regmap, S2MU005_REG_MUIC_LDOADC_H, + S2MU005_MUIC_VSET, S2MU005_MUIC_VSET_3P0V); + if (ret < 0) { + dev_err(priv->dev, "failed to set internal ADC voltage regulator\n"); + return ret; + } + + ret =3D regmap_clear_bits(priv->regmap, S2MU005_REG_MUIC_CTRL1, + S2MU005_MUIC_IRQ); + if (ret < 0) { + dev_err(priv->dev, "failed to enable MUIC interrupts\n"); + return ret; + } + + return s2mu005_muic_attach(priv); +} + +static const unsigned int s2mu005_muic_extcon_cable[] =3D { + EXTCON_USB, + EXTCON_USB_HOST, + EXTCON_CHG_USB_SDP, + EXTCON_CHG_USB_DCP, + EXTCON_CHG_USB_CDP, + EXTCON_JIG, + EXTCON_NONE, +}; + +static struct s2m_muic_irq_data s2mu005_muic_irq_data[] =3D { + { + .irq =3D S2MU005_MUIC_IRQ_ATTACH, + .name =3D "s2mu005-muic-attach", + .handler =3D s2mu005_muic_attach + }, { + .irq =3D S2MU005_MUIC_IRQ_DETACH, + .name =3D "s2mu005-muic-detach", + .handler =3D s2mu005_muic_detach + }, { + /* sentinel */ + } +}; + +static irqreturn_t s2m_muic_irq_func(int virq, void *data) +{ + struct s2m_muic *priv =3D data; + const struct s2m_muic_irq_data *irq_data =3D priv->irq_data; + int ret; + int i; + + for (i =3D 0; irq_data[i].handler; i++) { + if (virq !=3D irq_data[i].virq) + continue; + + ret =3D irq_data[i].handler(priv); + if (ret < 0) + dev_err(priv->dev, "failed to handle interrupt for %s (%d)\n", + irq_data[i].name, ret); + break; + } + + return IRQ_HANDLED; +} + +static int s2m_muic_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sec_pmic_dev *pmic_drvdata =3D dev_get_drvdata(dev->parent); + struct s2m_muic *priv; + struct regmap_irq_chip_data *irq_chip_data; + int ret; + int i; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return dev_err_probe(dev, -ENOMEM, "failed to allocate driver private\n"= ); + + platform_set_drvdata(pdev, priv); + priv->dev =3D dev; + priv->regmap =3D pmic_drvdata->regmap_pmic; + + switch (platform_get_device_id(pdev)->driver_data) { + case S2MU005: + irq_chip_data =3D pmic_drvdata->irq_data[S2MU005_MUIC_IRQ_CHIP]; + priv->irq_data =3D s2mu005_muic_irq_data; + priv->extcon_cable =3D s2mu005_muic_extcon_cable; + /* Initialize MUIC */ + ret =3D s2mu005_muic_init(priv); + break; + default: + return dev_err_probe(dev, -ENODEV, + "device type %d is not supported by driver\n", + pmic_drvdata->device_type); + } + if (ret < 0) + return dev_err_probe(dev, ret, "failed to initialize MUIC\n"); + + priv->extcon =3D devm_extcon_dev_allocate(&pdev->dev, priv->extcon_cable); + if (IS_ERR(priv->extcon)) + return dev_err_probe(dev, PTR_ERR(priv->extcon), + "failed to allocate memory for extcon\n"); + + ret =3D devm_extcon_dev_register(dev, priv->extcon); + if (ret) + return dev_err_probe(dev, ret, "failed to register extcon device\n"); + + for (i =3D 0; priv->irq_data[i].handler; i++) { + int virq =3D regmap_irq_get_virq(irq_chip_data, + priv->irq_data[i].irq); + if (virq <=3D 0) + return dev_err_probe(dev, -EINVAL, "failed to get virtual IRQ\n"); + + priv->irq_data[i].virq =3D virq; + ret =3D devm_request_threaded_irq(dev, virq, NULL, + s2m_muic_irq_func, IRQF_ONESHOT, + priv->irq_data[i].name, priv); + if (ret) + dev_err_probe(dev, ret, "failed to request IRQ\n"); + } + + return 0; +} + +static void s2m_muic_remove(struct platform_device *pdev) +{ + struct s2m_muic *priv =3D dev_get_drvdata(&pdev->dev); + + /* + * Disabling the MUIC device is important as it disables manual + * switching mode, thereby enabling auto switching mode. + * + * This is to ensure that when the board is powered off, it + * goes into LPM charging mode when a USB charger is connected. + */ + switch (platform_get_device_id(pdev)->driver_data) { + case S2MU005: + s2mu005_muic_detach(priv); + break; + } +} + +static const struct platform_device_id s2m_muic_id_table[] =3D { + { "s2mu005-muic", S2MU005 }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(platform, s2m_muic_id_table); + +#ifdef CONFIG_OF +/* + * Device is instantiated through parent MFD device and device matching + * is done through platform_device_id. + * + * However if device's DT node contains proper compatible and driver is + * built as a module, then the *module* matching will be done through DT + * aliases. This requires of_device_id table. In the same time this will + * not change the actual *device* matching so do not add .of_match_table. + */ +static const struct of_device_id s2m_muic_of_match_table[] =3D { + { + .compatible =3D "samsung,s2mu005-muic", + .data =3D (void *)S2MU005, + }, { + /* sentinel */ + }, +}; +MODULE_DEVICE_TABLE(of, s2m_muic_of_match_table); +#endif + +static struct platform_driver s2m_muic_driver =3D { + .driver =3D { + .name =3D "s2m-muic", + }, + .probe =3D s2m_muic_probe, + .remove =3D s2m_muic_remove, + .id_table =3D s2m_muic_id_table, +}; +module_platform_driver(s2m_muic_driver); + +MODULE_DESCRIPTION("Extcon Driver For Samsung S2M Series PMICs"); +MODULE_AUTHOR("Kaustabh Chakraborty "); +MODULE_LICENSE("GPL"); --=20 2.51.2 From nobody Sun Feb 8 20:17:39 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 780983195E7; Thu, 13 Nov 2025 19:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060915; cv=none; b=JQa76KJRELk/XcZO6eqU7Hn5BIBEiwS6iv3TKKpDlUdxcFcWt1SIzdZj2Bmr7Zxvk7NoteUIupLvN8qXWCv1qmF133zE7iQfBiWaELJA/kkL4cvySDX3niOHsIP0c1GELM7pnaS39xDnWmf7wHVOCO+Y1BnKDbqNtXIaFx+HmMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763060915; c=relaxed/simple; bh=FLUqwjUCzmLu5oGO+Zln3eWxgqYETZl/0W/pVfo5VbU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sCDxy475gEkkh0l0HN5BcDsjzxhhxiDKQqsXX0jV781zlY4rLP9vjY0sjXWs32juMS0A9YzHx/N/cJj1SbvcjmrN5sIrCc1i1febDtKayPhgPpbI1iDzWUBXORVV6AdkG31qqfFNxeBB6SfNV5WNCfq+rdwWtiSDN5qJcwpLseY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=L3UHOli0; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="L3UHOli0" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A128D25DAC; Thu, 13 Nov 2025 20:08:30 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BZ2ghCEt9r8E; Thu, 13 Nov 2025 20:08:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763060909; bh=FLUqwjUCzmLu5oGO+Zln3eWxgqYETZl/0W/pVfo5VbU=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=L3UHOli0X9kOQO8IOzyxRyVHn0b6xvIny5YUPI/wT7fEDyhYDbeQL2gNBugRp/u7E jME/OkBgB9ApfdjgK1f+Zmq7eHJJaCTtVHozD5QkLVRPx+l0C8lkPnjU7CojeE3mHn +7aTWu9tfCAftY8z1IKrlOQ8bge0n69oBP3ShKg0xCad3cAGgTrTIeyg2nB/s+91rd rMRs0B3LcPK+82UNrYbDC0kVwYKvFdahME0Mod1FQdCora3JEBDfgDmvkqhtg5fjA9 7Tjd57pDOgkCQUqnMnPveE4CzvTZVIr9e77PCVSL1aJl2jOltFZ0XDUDI9nkVUXdOv 4X+RvHR6dlnBQ== From: Kaustabh Chakraborty Date: Fri, 14 Nov 2025 00:35:14 +0530 Subject: [PATCH 13/13] power: supply: add support for Samsung S2M series PMIC charger device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-s2mu005-pmic-v1-13-9e3184d3a0c9@disroot.org> References: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> In-Reply-To: <20251114-s2mu005-pmic-v1-0-9e3184d3a0c9@disroot.org> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?utf-8?q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1763060713; l=9216; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=FLUqwjUCzmLu5oGO+Zln3eWxgqYETZl/0W/pVfo5VbU=; b=oDFpzVZXIoA/aDmvgPLb4M6oS8YnxJb5J0nzPT2JvboX5y5TlS4ysC2wZ0sgzr+28kYUWeOwl 7A/7Wc+a5p0DfmACtI1kkD0GdWDKFt5PvDbn5tuKYhuP1lEjfPNWNhC X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= Add a driver for charger controllers found in certain Samsung S2M series PMICs. The driver has very basic support for the device, with only charger online reporting working. The driver includes initial support for the S2MU005 PMIC charger. Signed-off-by: Kaustabh Chakraborty --- drivers/extcon/extcon-s2m.c | 2 +- drivers/power/supply/Kconfig | 11 ++ drivers/power/supply/Makefile | 1 + drivers/power/supply/s2m-charger.c | 216 +++++++++++++++++++++++++++++++++= ++++ 4 files changed, 229 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-s2m.c b/drivers/extcon/extcon-s2m.c index b27ee9e79bb6..268ad1f65ffd 100644 --- a/drivers/extcon/extcon-s2m.c +++ b/drivers/extcon/extcon-s2m.c @@ -289,7 +289,7 @@ static int s2m_muic_probe(struct platform_device *pdev) s2m_muic_irq_func, IRQF_ONESHOT, priv->irq_data[i].name, priv); if (ret) - dev_err_probe(dev, ret, "failed to request IRQ\n"); + return dev_err_probe(dev, ret, "failed to request IRQ\n"); } =20 return 0; diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 03c8525b480f..f8742d35a288 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -229,6 +229,17 @@ config BATTERY_SAMSUNG_SDI Say Y to enable support for Samsung SDI battery data. These batteries are used in Samsung mobile phones. =20 +config CHARGER_S2M + tristate "Samsung S2M series PMIC battery charger support" + depends on EXTCON_S2M + depends on MFD_SEC_CORE + select REGMAP_IRQ + help + This option enables support for charger devices found in + certain Samsung S2M series PMICs, such as the S2MU005. These + devices provide USB power supply information and also required + for USB OTG role switching. + config BATTERY_COLLIE tristate "Sharp SL-5500 (collie) battery" depends on SA1100_COLLIE && MCP_UCB1200 diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 6e37a3edf7e3..dcfae32d1216 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -40,6 +40,7 @@ obj-$(CONFIG_BATTERY_PMU) +=3D pmu_battery.o obj-$(CONFIG_BATTERY_QCOM_BATTMGR) +=3D qcom_battmgr.o obj-$(CONFIG_BATTERY_OLPC) +=3D olpc_battery.o obj-$(CONFIG_BATTERY_SAMSUNG_SDI) +=3D samsung-sdi-battery.o +obj-$(CONFIG_CHARGER_S2M) +=3D s2m-charger.o obj-$(CONFIG_BATTERY_COLLIE) +=3D collie_battery.o obj-$(CONFIG_BATTERY_INGENIC) +=3D ingenic-battery.o obj-$(CONFIG_BATTERY_INTEL_DC_TI) +=3D intel_dc_ti_battery.o diff --git a/drivers/power/supply/s2m-charger.c b/drivers/power/supply/s2m-= charger.c new file mode 100644 index 000000000000..0a3216a2b545 --- /dev/null +++ b/drivers/power/supply/s2m-charger.c @@ -0,0 +1,216 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Battery Charger Driver for Samsung S2M series PMICs. + * + * Copyright (c) 2015 Samsung Electronics Co., Ltd + * Copyright (c) 2025 Kaustabh Chakraborty + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct s2m_chgr { + struct device *dev; + struct regmap *regmap; + struct power_supply *psy; + struct extcon_dev *extcon; + struct work_struct extcon_work; + struct notifier_block extcon_nb; +}; + +static int s2mu005_chgr_get_online(struct s2m_chgr *priv, int *value) +{ + u32 val; + int ret =3D 0; + + ret =3D regmap_read(priv->regmap, S2MU005_REG_CHGR_STATUS0, &val); + if (ret < 0) { + dev_err(priv->dev, "failed to read register (%d)\n", ret); + return ret; + } + + *value =3D !!(val & S2MU005_CHGR_CHG); + + return ret; +} + +static int s2mu005_chgr_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct s2m_chgr *priv =3D power_supply_get_drvdata(psy); + int ret =3D 0; + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + ret =3D s2mu005_chgr_get_online(priv, &val->intval); + break; + default: + return -EINVAL; + } + + return ret; +} + +static void s2mu005_chgr_extcon_work(struct work_struct *work) +{ + struct s2m_chgr *priv =3D container_of(work, struct s2m_chgr, + extcon_work); + int ret; + + if (extcon_get_state(priv->extcon, EXTCON_USB_HOST) =3D=3D true) { + ret =3D regmap_update_bits(priv->regmap, S2MU005_REG_CHGR_CTRL0, + S2MU005_CHGR_OP_MODE, + S2MU005_CHGR_OP_MODE_OTG); + if (ret < 0) + dev_err(priv->dev, "failed to set operation mode to OTG (%d)\n", + ret); + + goto psy_update; + } + + if (extcon_get_state(priv->extcon, EXTCON_USB) =3D=3D true) { + ret =3D regmap_update_bits(priv->regmap, S2MU005_REG_CHGR_CTRL0, + S2MU005_CHGR_OP_MODE, + S2MU005_CHGR_OP_MODE_CHG); + if (ret < 0) + dev_err(priv->dev, "failed to set operation mode to charging (%d)\n", + ret); + + goto psy_update; + } + + ret =3D regmap_clear_bits(priv->regmap, S2MU005_REG_CHGR_CTRL0, + S2MU005_CHGR_OP_MODE); + if (ret < 0) + dev_err(priv->dev, "failed to clear operation mode (%d)\n", ret); + +psy_update: + power_supply_changed(priv->psy); +} + +static const enum power_supply_property s2mu005_chgr_properties[] =3D { + POWER_SUPPLY_PROP_ONLINE, +}; + +static const struct power_supply_desc s2mu005_chgr_psy_desc =3D { + .name =3D "s2mu005-charger", + .type =3D POWER_SUPPLY_TYPE_USB, + .properties =3D s2mu005_chgr_properties, + .num_properties =3D ARRAY_SIZE(s2mu005_chgr_properties), + .get_property =3D s2mu005_chgr_get_property, +}; + +static int s2m_chgr_extcon_notifier(struct notifier_block *nb, + unsigned long event, void *param) +{ + struct s2m_chgr *priv =3D container_of(nb, struct s2m_chgr, extcon_nb); + + schedule_work(&priv->extcon_work); + + return NOTIFY_OK; +} + +static int s2m_chgr_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sec_pmic_dev *pmic_drvdata =3D dev_get_drvdata(dev->parent); + struct s2m_chgr *priv; + struct device_node *extcon_node; + struct power_supply_config psy_cfg =3D {}; + const struct power_supply_desc *psy_desc; + work_func_t extcon_work_func; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return dev_err_probe(dev, -ENOMEM, "failed to allocate driver private\n"= ); + + platform_set_drvdata(pdev, priv); + priv->dev =3D dev; + priv->regmap =3D pmic_drvdata->regmap_pmic; + + switch (platform_get_device_id(pdev)->driver_data) { + case S2MU005: + psy_desc =3D &s2mu005_chgr_psy_desc; + extcon_work_func =3D s2mu005_chgr_extcon_work; + break; + default: + return dev_err_probe(dev, -ENODEV, + "device type %d is not supported by driver\n", + pmic_drvdata->device_type); + } + + psy_cfg.drv_data =3D priv; + priv->psy =3D devm_power_supply_register(dev, psy_desc, &psy_cfg); + if (IS_ERR(priv->psy)) + return dev_err_probe(dev, PTR_ERR(priv->psy), + "failed to register power supply subsystem\n"); + + /* MUIC is mandatory. If unavailable, request probe deferral */ + extcon_node =3D of_get_child_by_name(dev->parent->of_node, "extcon"); + priv->extcon =3D extcon_find_edev_by_node(extcon_node); + if (IS_ERR(priv->extcon)) + return -EPROBE_DEFER; + + ret =3D devm_work_autocancel(dev, &priv->extcon_work, extcon_work_func); + if (ret) + return dev_err_probe(dev, ret, "failed to initialize extcon work\n"); + + priv->extcon_nb.notifier_call =3D s2m_chgr_extcon_notifier; + ret =3D devm_extcon_register_notifier_all(dev, priv->extcon, &priv->extco= n_nb); + if (ret) + dev_err_probe(dev, ret, "failed to register extcon notifier\n"); + + return 0; +} + +static const struct platform_device_id s2m_chgr_id_table[] =3D { + { "s2mu005-charger", S2MU005 }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(platform, s2m_chgr_id_table); + +#ifdef CONFIG_OF +/* + * Device is instantiated through parent MFD device and device matching + * is done through platform_device_id. + * + * However if device's DT node contains proper compatible and driver is + * built as a module, then the *module* matching will be done through DT + * aliases. This requires of_device_id table. In the same time this will + * not change the actual *device* matching so do not add .of_match_table. + */ +static const struct of_device_id s2m_chgr_of_match_table[] =3D { + { + .compatible =3D "samsung,s2mu005-charger", + .data =3D (void *)S2MU005, + }, { + /* sentinel */ + }, +}; +MODULE_DEVICE_TABLE(of, s2m_chgr_of_match_table); +#endif + +static struct platform_driver s2m_chgr_driver =3D { + .driver =3D { + .name =3D "s2m-charger", + }, + .probe =3D s2m_chgr_probe, + .id_table =3D s2m_chgr_id_table, +}; +module_platform_driver(s2m_chgr_driver); + +MODULE_DESCRIPTION("Battery Charger Driver For Samsung S2M Series PMICs"); +MODULE_AUTHOR("Kaustabh Chakraborty "); +MODULE_LICENSE("GPL"); --=20 2.51.2