From nobody Mon Feb 9 16:54:37 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35B6B330B21; Fri, 14 Nov 2025 16:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763139309; cv=pass; b=PS26AN14AAU4YskbwBeIGTNz+icfXle9mvPv3iyPbt+jNhMxzpKD3geOfjzZ7rWbRKFcjz0IjpDW/fKZSG20HbgEzkAMDc5yXGAUGpYtrPKQWy42zes0VnA8hdXtsCB8AQ5IplKI6NquO23n1iIPhDGLjPYT1R2Bkzdh6O77GYQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763139309; c=relaxed/simple; bh=pZtlSMNay4opDuCp0jbNHr651X36qem8tqw6XKlCtpM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dbIyNkRKBH6CQegUn8ZR9Z9qCCOaLpyctHWd9J/Tb97b7zp8khHjPgTek+tPg0vnrKODQlhypkrc+KjGmrbzrFZKeZ2Q9206o8fJOdctwm4RXn3Mc/HEkvof5c9iT7UN0hi9oNAADd2LYIjm23G+inzQVe3xp6XjhS1RgssElT8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=UM0PiNL8; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="UM0PiNL8" ARC-Seal: i=1; a=rsa-sha256; t=1763139292; cv=none; d=zohomail.com; s=zohoarc; b=ZoO7WWhNV2Xk7S4KdxmF9ECHmclrJ28xzmp8wlkJm2P8bemhS5W2aP4h/DX5KQ33+5q0ptbQkpYgwhNt4OLQPPGQVxokfrJO8/opqpncHFigZeZoRCscxwE6ek+poDJTC+5fLyFYIv4rHExwB5X96JzzVWaOIf9VSVY+wScv/ew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763139292; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8Z2RX45PQe3+e23Hg+S1cxa096rmc7JX0/zbuja37Rw=; b=C5RiRrSxozyaK1VjSA0HHtnRxEQcaD43zY2wiOYkgNQufcBWm2VN+4uoN9nwgGoT38rLc55d3yA0H0ti/hJFfBTxPGwfBFPhDd3CxWmEI8iwdbpLq/hwjmnk/cc7ChSXxpttQXgvkKlpCKhBx/TYjaVGPUACMSl1kwKluOcGm/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763139292; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=8Z2RX45PQe3+e23Hg+S1cxa096rmc7JX0/zbuja37Rw=; b=UM0PiNL8Ytsb/hBYG1boWEA6By2aQAxsQ8dWuQaSoR/65dBdS/q2uWy1653C0hyM d4sHiTZgYAZVrpzCMsB/0eyvrzPzH6JKEFbqJq4Bwyqdrwfv9L11b3yRe4RdEVb9XBC aJmDgEKhq9QtLBeG4KDr7Lnuo8QoVjbQyFrLYW3c= Received: by mx.zohomail.com with SMTPS id 1763139290645993.1597495532519; Fri, 14 Nov 2025 08:54:50 -0800 (PST) From: Nicolas Frattaroli Date: Fri, 14 Nov 2025 17:54:06 +0100 Subject: [PATCH 12/13] interconnect: mediatek: Don't hijack parent device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-mt8196-dvfsrc-v1-12-b956d4631468@collabora.com> References: <20251114-mt8196-dvfsrc-v1-0-b956d4631468@collabora.com> In-Reply-To: <20251114-mt8196-dvfsrc-v1-0-b956d4631468@collabora.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Henry Chen , Georgi Djakov Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 If the intention is that users of the interconnect declare their relationship to the child icc_emi node of the dvfsrc controller, then this code never worked. That's because it uses the parent dvfsrc device as the device it passes to the interconnect core framework, which means all the OF parsing is broken. Use the actual device instead, and pass the dvfsrc parent into the dvfsrc calls. Fixes: b45293799f75 ("interconnect: mediatek: Add MediaTek MT8183/8195 EMI = Interconnect driver") Signed-off-by: Nicolas Frattaroli Reviewed-by: AngeloGioacchino Del Regno --- drivers/interconnect/mediatek/icc-emi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/interconnect/mediatek/icc-emi.c b/drivers/interconnect= /mediatek/icc-emi.c index 7da740b5fa8d..182aa2b0623a 100644 --- a/drivers/interconnect/mediatek/icc-emi.c +++ b/drivers/interconnect/mediatek/icc-emi.c @@ -40,7 +40,7 @@ static int mtk_emi_icc_set(struct icc_node *src, struct i= cc_node *dst) if (unlikely(!src->provider)) return -EINVAL; =20 - dev =3D src->provider->dev; + dev =3D src->provider->dev->parent; =20 switch (node->ep) { case 0: @@ -97,7 +97,7 @@ int mtk_emi_icc_probe(struct platform_device *pdev) if (!data) return -ENOMEM; =20 - provider->dev =3D pdev->dev.parent; + provider->dev =3D dev; provider->set =3D mtk_emi_icc_set; provider->aggregate =3D mtk_emi_icc_aggregate; provider->xlate =3D of_icc_xlate_onecell; --=20 2.51.2