From nobody Mon Feb 9 13:36:35 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF552EDD7D for ; Fri, 14 Nov 2025 07:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763104840; cv=none; b=a/WhcX7hkAWxmKITSpNoT4w3pvdmTZhyoc6Xbb/NgCaKDAsn5/4P2LdgHTetYETqJhjnUJW1o7V/cXu6pzW1hK6Dx+72hLMiCWV0XU/YUp9rqOjdCTEUP/WGe6G12UqrgYOHDpMZhqbUEWO5gFPlOW+oxCRVfxFwbW4UjGFkH9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763104840; c=relaxed/simple; bh=Jl90UdEr8NC9NQJHRyLWV6kpPFz4gyUYS0h9z2g368U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J3Aw2xnd3uZ7eE/F0IpiVtLlu1K596wF5s1eqCjY4lxxTITFZQWa7tfBOU4stBsq+eYG3aDhWq73POqPsNL7G6OchwHl/3HyvF3H74Gqxpmx5TrKLWXtOB0cs4JVggu+IHTgCFpGAzg8PKgkOZUT5pvKpQYTe5prvJzki7NGSc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dVnGOGwc; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dVnGOGwc" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id B2A36C10F5E; Fri, 14 Nov 2025 07:20:08 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7DFD16060E; Fri, 14 Nov 2025 07:20:30 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 45D2F102F291C; Fri, 14 Nov 2025 08:20:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763104829; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RTnapVv6Kq237V0+NqTV4P/zgR2L1d18jSkpYpEllMQ=; b=dVnGOGwcwe4M9KEGgf15/UOcqd1SPIo96q37GYcbRYtmy0B2ccfF/RdtZvcoumyWoPfCfd OS69ACjkAZwiCkLZ58uGj5qXi/IhXSnAd9cTu1Ub20jH0KsTLrB3cBwdItBtfRBqFqxGNE XXZk6qXMWi17PLha5ypKe+liMVnl1cgFSpaXr9fLnnxnCmjxJgquhrK+8cRdgcdJPk8u7Y JhCeQ8I3pHnEqQUit3O4IQEv6h4+JXevwb18G6WCYARXw0UyAQLIjO4lfsvwBFLkLn4kE0 XsTHw7fo0CHzCe964iO7F5fdXpmlVw1es0XV1kME6eTdIKEZJN/623UuHsWCpQ== From: "Bastien Curutchet (Schneider Electric)" Date: Fri, 14 Nov 2025 08:20:21 +0100 Subject: [PATCH net v3 2/4] net: dsa: microchip: ptp: Fix checks on irq_find_mapping() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251114-ksz-fix-v3-2-acbb3b9cc32f@bootlin.com> References: <20251114-ksz-fix-v3-0-acbb3b9cc32f@bootlin.com> In-Reply-To: <20251114-ksz-fix-v3-0-acbb3b9cc32f@bootlin.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Arun Ramadoss Cc: Pascal Eberhard , =?utf-8?q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Bastien Curutchet (Schneider Electric)" X-Mailer: b4 0.14.2 X-Last-TLS-Session-Version: TLSv1.3 irq_find_mapping() returns a positive IRQ number or 0 if no IRQ is found but it never returns a negative value. However, during the PTP IRQ setup, we verify that its returned value isn't negative. Fix the irq_find_mapping() check to enter the error path when 0 is returned. Return -EINVAL in such case. Fixes: cc13ab18b201 ("net: dsa: microchip: ptp: enable interrupt for timest= amping") Signed-off-by: Bastien Curutchet (Schneider Electric) Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz_ptp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_ptp.c b/drivers/net/dsa/microchi= p/ksz_ptp.c index 35fc21b1ee48a47daa278573bfe8749c7b42c731..c8bfbe5e2157323ecf29149d190= 7b77e689aa221 100644 --- a/drivers/net/dsa/microchip/ksz_ptp.c +++ b/drivers/net/dsa/microchip/ksz_ptp.c @@ -1139,8 +1139,8 @@ int ksz_ptp_irq_setup(struct dsa_switch *ds, u8 p) irq_create_mapping(ptpirq->domain, irq); =20 ptpirq->irq_num =3D irq_find_mapping(port->pirq.domain, PORT_SRC_PTP_INT); - if (ptpirq->irq_num < 0) { - ret =3D ptpirq->irq_num; + if (!ptpirq->irq_num) { + ret =3D -EINVAL; goto out; } =20 --=20 2.51.1