From nobody Sun Feb 8 14:10:53 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2524930EF6E for ; Thu, 13 Nov 2025 20:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066262; cv=none; b=ASv8QG2i7823G3+ogy3+lVKhsukpKDerU2kC8ZnNs1hlPC0aXN6CPfCYhVswWV6ZKyq+LYkKk3bAjRFDK3uLoghOpl72E1YT/66RnXgUF3BdYUVtUfV193uTdEwvqyx1kBDOgaCiy+n/jH5qYa92ElcVHAUFB7GMzD3KZbECPs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066262; c=relaxed/simple; bh=IhyYAvJB32HKe5lsW0NW8SiaWTvB2JLJ65qK635EKYg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r3kdDXLKPEQCgCVlFzGRKYadXK2cv/CUOvdN7YuB03FQdOChQSAXAUG0+wT49a7dHuIgN6DV+HDxLKZ/DEDiqCHiID2aXgezr3Au16coE+6y0yFXYCyaq7Vudpx5shEXUNJ0+7YGobn4NUT3ue1R/u/HRzbcSpPu6Ym7FzMHA+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Nw+bCFei; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Nw+bCFei" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763066258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h7IYL1pgjM3KN4/LrZAIitgGAICVxDY/o/Vd5ldE/rY=; b=Nw+bCFei5gtwCkmjhI1568AvJE36lyE7Ma5ND4beUS8rq3TCsZ8vVYJg4p+X+6A34JyE8D mcCa33NwIUP3Pm+aZGPB71KanfyzjtvXTkqpWkDgjoBHjqSHd3FzogdmKuafcCYHNpX4rY BsNicK/O220MIMu3kGQWWPbgVvh7edA= From: Sean Anderson To: Laurent Pinchart , Tomi Valkeinen , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Mike Looijmans , David Airlie , Thomas Zimmermann , Maarten Lankhorst , Anatoliy Klymenko , Maxime Ripard , linux-arm-kernel@lists.infradead.org, Simona Vetter , Michal Simek , Sean Anderson Subject: [PATCH 1/3] drm: zynqmp: Check property creation status Date: Thu, 13 Nov 2025 15:37:12 -0500 Message-Id: <20251113203715.2768107-2-sean.anderson@linux.dev> In-Reply-To: <20251113203715.2768107-1-sean.anderson@linux.dev> References: <20251113203715.2768107-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Make sure to return an error in the event that we can't create our properties. Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support") Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to use= rspace") Signed-off-by: Sean Anderson Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqm= p_kms.c index 2bee0a2275ed..c80a2d4034f3 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -174,9 +174,15 @@ static int zynqmp_dpsub_create_planes(struct zynqmp_dp= sub *dpsub) =20 drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs); =20 - drm_plane_create_zpos_immutable_property(plane, i); - if (i =3D=3D ZYNQMP_DPSUB_LAYER_GFX) - drm_plane_create_alpha_property(plane); + ret =3D drm_plane_create_zpos_immutable_property(plane, i); + if (ret) + return ret; + + if (i =3D=3D ZYNQMP_DPSUB_LAYER_GFX) { + ret =3D drm_plane_create_alpha_property(plane); + if (ret) + return ret; + } } =20 return 0; --=20 2.35.1.1320.gc452695387.dirty