From nobody Mon Feb 9 16:45:45 2026 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1D73191C8; Thu, 13 Nov 2025 19:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763061145; cv=pass; b=tKfWZKsqW7sTOYmJ9cAOi8Q6dopwy/W4G6Y7Tc8vauegwob6nsluz9CmGI8Lmb+8VqBorRJz+58CwAslGPctlKv+b7EWveWzyBIXI7e32cPZV9Sex5dLsoSYcnBJINKQInLbMMxxA8dpkNdh+8yvEJWNIHO0UD1mBNR1vNTb5hc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763061145; c=relaxed/simple; bh=OOZIm+oyRQLINv+OTXqfEGrVwVrIfsDJqs/Z9yydVmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GOpnpciR3sE62JnbmCDZnWdipsRb4vRR657ndaGjUPFbyR3LUhh1AatTHFuKVSbJLDF7SI5DvE0oVKiyO/p1ir/kOE0pKG7h55yN6VYDzc/CKPpENifUGa2FCHWFRMb6PPOmwbtgXyOMLlqAKxLvx+uYlL8zL326zDalqJCwa+4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rong.moe; spf=pass smtp.mailfrom=rong.moe; dkim=pass (1024-bit key) header.d=rong.moe header.i=i@rong.moe header.b=MypowQCs; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rong.moe Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rong.moe Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rong.moe header.i=i@rong.moe header.b="MypowQCs" ARC-Seal: i=1; a=rsa-sha256; t=1763061122; cv=none; d=zohomail.com; s=zohoarc; b=kxKHWoVdWtFwPvQJXgrEtEmbxYFnVt2PpK6YTsMAWH0chjRDxIxuamAFH+EqKVdfYFTwnP+AIFQL8sxMxHPDxwyqrcp8JtE/c7W5sYjKAHGXeqNlFeYxj6tgtpwbMRNnUnoWAECFh8q//Efu8NuVR9G3492nGuIycfr53KbVJxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763061122; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=cfZh6V0GSsiG0GSXjwqt/gP+zedHVH55yRrrOPg+t3E=; b=A/rOFY1F7kjQuZq7hdCSl8izyh4hPheO4Nqu54o7E/MtA1R05gyisikfe8ELjs8hRNVxTkuMPoYkqK76+f3EoeXR52jMkDYPdmXbp32ZeAyLoP9F/R4VVKOGqKhjWSNzQK4qMIS4nZFAXpRQf/l+UeSzYqV+tQ5kxug4q9EtTRM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rong.moe; spf=pass smtp.mailfrom=i@rong.moe; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763061122; s=zmail; d=rong.moe; i=i@rong.moe; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=cfZh6V0GSsiG0GSXjwqt/gP+zedHVH55yRrrOPg+t3E=; b=MypowQCsksBGxiz89tKXeiXMqfntotib+ectiLDpB/hRqvCfpwexju0y8b/A9mdg Ma6LaYyam6/IoW+bOZvCGSwLc58GgqEgdrjEgGBqD/rt5J+bjKpTp+imUlX2aTYERzk bmytoQ6/4T/TqdPhlPBHP+RMKf6pg7cU5hYZLp/M= Received: by mx.zohomail.com with SMTPS id 176306112124094.02439741328124; Thu, 13 Nov 2025 11:12:01 -0800 (PST) From: Rong Zhang To: Mark Pearson , "Derek J. Clark" , Armin Wolf , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Rong Zhang , Guenter Roeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v4 1/7] platform/x86: lenovo-wmi-helpers: Convert returned buffer into u32 Date: Fri, 14 Nov 2025 03:11:44 +0800 Message-ID: <20251113191152.96076-2-i@rong.moe> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251113191152.96076-1-i@rong.moe> References: <20251113191152.96076-1-i@rong.moe> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" The Windows WMI-ACPI driver converts all ACPI objects into a common buffer format, so returning a buffer with four bytes will look like an integer for WMI consumers under Windows. Therefore, some devices may simply implement the corresponding ACPI methods to always return a buffer. While lwmi_dev_evaluate_int() expects an integer (u32), convert returned >=3D4B buffer into u32 to support these devices. Suggested-by: Armin Wolf Link: https://lore.kernel.org/r/f1787927-b655-4321-b9d9-bc12353c72db@gmx.de/ Signed-off-by: Rong Zhang Reviewed-by: Derek J. Clark Tested-by: Derek J. Clark --- Changes in v4: - Accept oversized buffer (thanks Armin Wolf) - Use get_unaligned_le32() (ditto) Changes in v2: - New patch (thanks Armin Wolf) --- drivers/platform/x86/lenovo/wmi-helpers.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-helpers.c b/drivers/platform/x= 86/lenovo/wmi-helpers.c index f6fef6296251..ea0b75334c9e 100644 --- a/drivers/platform/x86/lenovo/wmi-helpers.c +++ b/drivers/platform/x86/lenovo/wmi-helpers.c @@ -21,6 +21,7 @@ #include #include #include +#include #include =20 #include "wmi-helpers.h" @@ -59,10 +60,25 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 i= nstance, u32 method_id, if (!ret_obj) return -ENODATA; =20 - if (ret_obj->type !=3D ACPI_TYPE_INTEGER) - return -ENXIO; + switch (ret_obj->type) { + /* + * The ACPI method may simply return a buffer when a u32 + * is expected. This is valid on Windows as its WMI-ACPI + * driver converts everything to a common buffer. + */ + case ACPI_TYPE_BUFFER: { + if (ret_obj->buffer.length >=3D 4) + return -ENXIO; =20 - *retval =3D (u32)ret_obj->integer.value; + *retval =3D get_unaligned_le32(ret_obj->buffer.pointer); + return 0; + } + case ACPI_TYPE_INTEGER: + *retval =3D (u32)ret_obj->integer.value; + return 0; + default: + return -ENXIO; + } } =20 return 0; --=20 2.51.0