From nobody Sun Feb 8 14:10:11 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952692F28FA; Thu, 13 Nov 2025 15:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763048783; cv=none; b=nIl/R3Uenbzdr3eWL2ibGwuQs16JgGcBYj8Zt07MDiG/ydVepPAoQz4Eix0hQEswHCE1yLqecuxIRA65atfNDboRiTObp2FHSdH88h2vAnIuZIM+ZiAQjcuBZfZ4GW7EiItyNZcAjNIzwboaRHVXUGHac8+YWmEVd+AnCGxOTIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763048783; c=relaxed/simple; bh=j8WPIWl6qkDYlVSZbuoLCIhGuEJ83qGYo523B0+8Xus=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ON5P/5aK3rrlmy5o3FoHwkm0CuLAejGfZG75NhaZMZ6g5FFbyqSJVcDJJJpBvYLJjvGOJYsemDDFe4TFUC3CF0017VYg4d24zUS0k0IIS2MbqDwkl6Dc6KM9uBxWzgN47d5C2ne1sq/YjBc177boHrSeHb97kkrdJFvMEGWhN2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XpbvZszs; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XpbvZszs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763048782; x=1794584782; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j8WPIWl6qkDYlVSZbuoLCIhGuEJ83qGYo523B0+8Xus=; b=XpbvZszsSm/Ty0kP89lNGILZ/jKL7gb2vQRNx9qPdnWagg9pKU6oCe4C oQcvMu7mjkMK1Yh7mWGJYAkeqIenBHDAdOBir4kwCkfszNS2qImt+U3sd XbBWgM8uin+o/RysgBFnl46toNKZOyQLE0G/59ycySDac8bXaZ9yWNaSD MYOtPX1H/kKw2ZP9z/Gyo/wPTErm9z4z6jDCHj02F66XS8p0i00drjdiE +yvoXUyyvLO4kanfH42jZ3GrH4d73uFxRosq4NnZHX0vovOKclRXA6Pvx yQ5Ng2cZI/aF0ZZ79P1I9nOj6I03jIkftpZWu0x//QQUvKR/dikfAHDxw Q==; X-CSE-ConnectionGUID: GaQkzg1UShSG537vcQ1h2g== X-CSE-MsgGUID: gJpEHaVSRKWKPzhxKvQo4w== X-IronPort-AV: E=McAfee;i="6800,10657,11612"; a="75448545" X-IronPort-AV: E=Sophos;i="6.19,302,1754982000"; d="scan'208";a="75448545" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2025 07:46:20 -0800 X-CSE-ConnectionGUID: j06jTqgPRO+DBiFm+q5DYg== X-CSE-MsgGUID: aQM3pfs5Q+KfBOPMxuozPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,302,1754982000"; d="scan'208";a="212933922" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa002.fm.intel.com with ESMTP; 13 Nov 2025 07:46:18 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 9382D99; Thu, 13 Nov 2025 16:46:17 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Torokhov Subject: [PATCH v2 3/5] Input: gpio_decoder - replace custom loop by gpiod_get_array_value_cansleep() Date: Thu, 13 Nov 2025 16:44:44 +0100 Message-ID: <20251113154616.3107676-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251113154616.3107676-1-andriy.shevchenko@linux.intel.com> References: <20251113154616.3107676-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a custom loop that repeats parts of gpiod_get_array_value_cansleep= (). Use that in conjunction with bitmap API to make code shorter and easier to follow. With this done, add an upper check for amount of GPIOs given based on the driver's code. Signed-off-by: Andy Shevchenko --- drivers/input/misc/gpio_decoder.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/input/misc/gpio_decoder.c b/drivers/input/misc/gpio_de= coder.c index a2ae400790f9..7f319b932550 100644 --- a/drivers/input/misc/gpio_decoder.c +++ b/drivers/input/misc/gpio_decoder.c @@ -6,11 +6,13 @@ * encoded numeric value into an input event. */ =20 +#include #include #include #include #include #include +#include #include #include #include @@ -26,23 +28,18 @@ struct gpio_decoder { static int gpio_decoder_get_gpios_state(struct gpio_decoder *decoder) { struct gpio_descs *gpios =3D decoder->input_gpios; - unsigned int ret =3D 0; - int i, val; + DECLARE_BITMAP(values, 32); + unsigned int size; + int err; =20 - for (i =3D 0; i < gpios->ndescs; i++) { - val =3D gpiod_get_value_cansleep(gpios->desc[i]); - if (val < 0) { - dev_err(decoder->dev, - "Error reading gpio %d: %d\n", - desc_to_gpio(gpios->desc[i]), val); - return val; - } - - val =3D !!val; - ret =3D (ret << 1) | val; + size =3D min(gpios->ndescs, 32U); + err =3D gpiod_get_array_value_cansleep(size, gpios->desc, gpios->info, va= lues); + if (err) { + dev_err(decoder->dev, "Error reading GPIO: %d\n", err); + return err; } =20 - return ret; + return bitmap_read(values, 0, size); } =20 static void gpio_decoder_poll_gpios(struct input_dev *input) @@ -81,6 +78,9 @@ static int gpio_decoder_probe(struct platform_device *pde= v) if (decoder->input_gpios->ndescs < 2) return dev_err_probe(dev, -EINVAL, "not enough gpios found\n"); =20 + if (decoder->input_gpios->ndescs > 31) + return dev_err_probe(dev, -EINVAL, "too many gpios found\n"); + if (device_property_read_u32(dev, "decoder-max-value", &max)) max =3D (1U << decoder->input_gpios->ndescs) - 1; =20 --=20 2.50.1