From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 834F430AAB3; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; cv=none; b=E6XXl6l4t3oQHIRPkgfruR6rb/vAIlIQkwYg+b2quiJZDxKOpjj2htLrPf2k5EPCc2+q/psrbhmJ5ag6k+RLYdJBcpqsFSTMZx/z71sJuliNWV3wofYvce0JCa5I4ClgL0Cz+IELKVP9bynaGfz+fGkLmYFG7muJBxnmyqLsVpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; c=relaxed/simple; bh=uFbPXmbMEAHhJ0wYQFNs6fH4az3w5KpMD/1oKdF7a8A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=omVu6Kl2T3aXTiQbpFj5wPmdY6zoSIxTNv0UpuEgCIITFCmIQLvbe5436lcDcDSE8tBrJ6YyXEqKwR8jn3IhgHha/JL61cz6tnXhbiHyxEt7lVy+T6nyueBhxM7mDWenmQSewyLDyfmK6WkP4izInjYN9EJtEr4qbr9Xyo5mxTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eu+t67Wn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eu+t67Wn" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3169BC19421; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=uFbPXmbMEAHhJ0wYQFNs6fH4az3w5KpMD/1oKdF7a8A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=eu+t67WntrJXQkscPhCKuC6tKwngm6Pl1jQ4b1UmpxZxVUOuM43tWwCKJg6nt13E4 GutY1R0gSvBEWyh2rpuKrP9NXitwK987rKRvMugjTfj9qqCpQhUygnt7PWWwiyfiDg Dvym27+PjYmJsPci+Qoiuo8R+pJVbRJ9jhLVSPRQlZlgndQRW2Pf1h1sIG4ypqjXL6 vh4ZQILZN/kVcnNTl0LlAp1LOGALsHTOtUg6exChWDHt5GoNL2g4FtBH/8mG0+Wdbj phFonxROug+xYyQO5gWx25Z+1ABJKQ2kLKahvvMm1F/JePDhSl9Gro7pi74EtK0daw L43tQFBnnezpA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A42CD8CB1; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:35 +0100 Subject: [PATCH v2 01/12] dt-bindings: panel: Convert Samsung SOFEF00 DDIC into standalone yaml Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-1-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5223; i=david@ixit.cz; h=from:subject:message-id; bh=KcvZ6HH3tv4tYyjsZH5js8KMkizn6EnBiH2Cf4wtXuE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUIFmfIxRvdM9zgz/7D86ElPcYaUzPd3949 gfKJmAYVBiJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg cqyTD/47zUozqhH/hFT3EcH52HUFMGlDxpvDvOYYtVSYV8TZ7ORcrn5PmBU1+xHSXjouZ40mDj6 +9hVI4Ew6wbFgXamNhBGs39eutr2SehuGuBjZ6C7ccSNIfso+cIhOM/VCfrGS2uXatsCK33cgkO VzFq6Ll481hz1bZ0PkO34nm5vQ1NB3CtkcszxWJzQAG/q9PN6oNM4C+f9H51+ZOpCq14BGMbrxl AGpWmMn1MVtHPtdQajjMNfT2XlTUtgxcjycUWVPHtUWaxNPwTw1+22iiIEuasxrpR/MAboBk02b bRU76FTJXolXFbonwdZCdA1lQ9hLY8iLHUudJ7dV5JsvGlX/ccLztosYnO4i+Qp3i/0rRfoaqWZ 3qUQr8ZeW8yu2f8etP7TBazfda4wTLjXip9pRjcGziRcOtgdys1TW3M8kWqtXz02PPtZBqNyN0K HU9fyWCRQtJZYFFE90ZOdtcIjiofDmZ7+4gVfOEfNxTXmufhvT/hGsiIhr2OdUGDMTFo3zNMZQI dhOADGx92x0D/5/QKcWLGPTAj6ZGuA2yolxToiFJeXs0m9fHJvZoZLtmXJJx+c8IV+2oS57IMMY koKm6lQhEotGRqwCz6uufs08K/iW7TG3m3fYa8cEbsp2GmhsEu5gGqGRLxAS3hB/uwb8OXHMvmD 2dORrwKNRv+pBbw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Reason for moving from simple panel is this DDIC has three supplies, while panel-simple-dsi is limited to one. Previous compatible only described the DDIC, but didn't include panel connected to it. Let's fix it, and offer bindings authors two compatibles to distinguish the connected panel. Basic description for SOFEF00 DDIC with attached panels - Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio - Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio There is only one user which uses samsung,sofef00 and it's updated to comply within this patch series. Signed-off-by: David Heidelberg Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/panel/panel-simple-dsi.yaml | 25 ++----- .../bindings/display/panel/samsung,sofef00.yaml | 79 ++++++++++++++++++= ++++ MAINTAINERS | 6 ++ 3 files changed, 89 insertions(+), 21 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-d= si.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.= yaml index ac2db8cf5eb76..464d7c8a7665e 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml @@ -19,6 +19,9 @@ description: | =20 If the panel is more advanced a dedicated binding file is required. =20 +allOf: + - $ref: panel-common.yaml# + properties: =20 compatible: @@ -56,8 +59,6 @@ properties: - panasonic,vvx10f034n00 # Samsung s6e3fa7 1080x2220 based AMS559NK06 AMOLED panel - samsung,s6e3fa7-ams559nk06 - # Samsung sofef00 1080x2280 AMOLED panel - - samsung,sofef00 # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT L= CD panel - tdo,tl070wsh30 =20 @@ -70,30 +71,12 @@ properties: reset-gpios: true port: true power-supply: true - vddio-supply: true - -allOf: - - $ref: panel-common.yaml# - - if: - properties: - compatible: - enum: - - samsung,sofef00 - then: - properties: - power-supply: false - required: - - vddio-supply - else: - properties: - vddio-supply: false - required: - - power-supply =20 additionalProperties: false =20 required: - compatible + - power-supply - reg =20 examples: diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef0= 0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.ya= ml new file mode 100644 index 0000000000000..eeee3cac72e31 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,sofef00.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SOFEF00 AMOLED DDIC + +description: The SOFEF00 is display driver IC with connected panel. + +maintainers: + - David Heidelberg + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + # Samsung 6.01 inch, 1080x2160 pixels, 18:9 ratio + - samsung,sofef00-ams601nt22 + # Samsung 6.28 inch, 1080x2280 pixels, 19:9 ratio + - samsung,sofef00-ams628nw01 + - const: samsung,sofef00 + + reg: + maxItems: 1 + + poc-supply: + description: POC regulator + + vci-supply: + description: VCI regulator + + vddio-supply: + description: VDD regulator + +required: + - compatible + - reset-gpios + - poc-supply + - vci-supply + - vddio-supply + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + panel@0 { + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; + reg =3D <0>; + + vddio-supply =3D <&vreg_l14a_1p88>; + vci-supply =3D <&s2dos05_buck1>; + poc-supply =3D <&s2dos05_ldo1>; + + te-gpios =3D <&tlmm 10 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; + + pinctrl-0 =3D <&panel_active>; + pinctrl-1 =3D <&panel_suspend>; + pinctrl-names =3D "default", "sleep"; + + port { + panel_in: endpoint { + remote-endpoint =3D <&mdss_dsi0_out>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 7e015dcbac732..a4b16812d5a0c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8117,6 +8117,12 @@ S: Maintained F: Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c =20 +DRM DRIVER FOR SAMSUNG SOFEF00 DDIC +M: David Heidelberg +S: Maintained +F: Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml +F: drivers/gpu/drm/panel/panel-samsung-sofef00.c + DRM DRIVER FOR SHARP MEMORY LCD M: Alex Lanzano S: Maintained --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C673590D2; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; cv=none; b=u2o/cQqFM+agqpCz0uk+XlBAfbdFfCtHFNmYj6wzBG6yrMQbvfw+SiqBF5+YTwhN6eEA8hpyuVGQ+6ckoB75lizcXggH7lz5R6TIYDZ0w9XNMEyV647nhQYjfYAiVOJQXb7GajvWpn5P+1QfCcWvE2G4nwg0SGQvHNHttosznvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; c=relaxed/simple; bh=RCFsjUix1XQ76jxISlR0S+cS2leVOmgzdskYmMSCvic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TuS2U5MmasaIQMjPwqcrrx9CkufGBgkyQ6rPIH2apXwk406Ml8MLB6exc+bMoOb7ET0S/3sJMbX7oSf4Jcx5+T/17hNrrvgGvVF5TnmbWrDYHkdPf2NkkFvZEa+qf2wxaDr76gHpE/4Eqo5r/W6u4sjEfOlAWbr2ERp/uaPG4uU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sqBgScq2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sqBgScq2" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3ED12C113D0; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=RCFsjUix1XQ76jxISlR0S+cS2leVOmgzdskYmMSCvic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=sqBgScq29bnowgvQ38/PLeX6P2J3e7wicY1LCMI5OXYjPFa3I7X6z3xugLkXLvz+S rYXWhFd3dV+Dn8EqfyE50RWl/1S9RoSXs7nuGHOaHaSgzlYcJJeObU4BCOainSy9yR 6lv09kIeQT3ERrmr4Q4RTwVy5NtsckfqvVzi3hWcTJewfFAu2IyzHsooSpXi9KkLtv aCXnDr1oLvQNU35WiZ0reV/XaS6zdrAlD/UTuq0K5l6YjEbwylPSVwYM9KuVQ1lXub M8WgZFHOVAK5mO7hh7TJu6MMdwxzYxVYm652bfFjhV4VMkM/ZsRzBQWLIQ5VqW048B dMSGXtvm+ngPg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3271FCD8CAF; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:36 +0100 Subject: [PATCH v2 02/12] arch: arm64: qcom: sdm845-enchilada: Specify panel name within the compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-2-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=978; i=david@ixit.cz; h=from:subject:message-id; bh=XdEJMzUlqHmVFvRkb119Ya6neFS+DHA5Y7GV7B5h8w4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUx5fxhZW3ru/k/CW3PaGg7zjqBNcd1dxuy WwS+gVUg/6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg ciOeD/94fR70j8mcyMtewNc7kRaVyQ+Uf9kvO5pfU7PAvyoGj6eaIMNgCZmw5d3CuDkjm1LlqRN KANBySbzAKuH3t+0rayZBiMjWPV72E2PuqMRYKk1/JnD6W9+GGaX0boMH+WbgdQjOTIxfgwMAcT VNXfgmsksZcsX+UM4XJXXFb3HHvd8r0gR7U1Fvz+gzT7fDlAE790cSJOnQ2YC4xHNQbqLSED1te 5aac+sYU2kkbfbLJ3IsTGqRuxhltvmzE8daMEkekpyBqnFJnvc1FWTdjz/mg7c8aPGOyYyyMv3N 4D7HDbVEuZ1b8m3De/F9WT/p9LO2Tx7k2YmTQZZ8QvIO+mu0QydnW6BsWxoJpIXb2cUOvD2r442 T1KeNz2tJaTIN2e5jDeJ9ci8OVIStlFtY2m0HY3N4Tir/zZsu9NNxamFO9OHjjVu25EdZU/HWEw f6fE81aL2NV7HJ/8hAuAzqacp5NXMij3PwWUk2RnzBVixtSsiux181tt4R0HTZhVozMLeX7165/ 3IYWscFVeLGMY3QOoDCm9YzGfUE1K03YcJMCOyQZAe29mVkIw8HkhMa/GdbEQW/V5vCfwaRqCAe 6ZmfmZgsuUzmWaAS6k8qrrEJh0PszMU1CL19KmfjgmpaPbUR3V/h5ORHylvpOXki0dZqD5zKYvO IyDko+cwq5UXTvQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg sofef00 is name of the DDIC, it doesn't contain name of the panel used. The DDIC is also paired with other panels, so make clear which panel is used. New device-tree will work with old driver as expected, due to secondary compatible. cosmetic: sort the node. Signed-off-by: David Heidelberg --- arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/a= rm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts index a259eb9d45ae0..8aead6dc25e00 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts @@ -31,9 +31,9 @@ battery: battery { }; =20 &display_panel { - status =3D "okay"; + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; =20 - compatible =3D "samsung,sofef00"; + status =3D "okay"; }; =20 &bq27441_fg { --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2BDD3590CE; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; cv=none; b=OPOFlfMWHOJ75ElFWJ3u2RTFqqzt7tj+51JLs5/1C7vNj4Okm+VYq0FMeX8QSbu6ob9ioKyCLbm1U1+VEfgXhMx4+up4aDLGU4cffLFV6SX4mXiwTnCOuNnAv0KgBtFhgn+HbsKpkHDftaZkoPJCFW3kDBYA6GLOOraPZU5XRvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056663; c=relaxed/simple; bh=GVLBLculdCKnhAiFJ2ef4yLpdlinMTlal7/JRCLg0f0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dA6i6wAAUDNGr7ba3zPBuKM6ZOvN/xZMt1CD2owz6MyrWh6176FVs6XTH4sTwTi/ROKifFNQ/N/8dk4PQ5WdK4MmYFgo0MtHeAEOvLISquc/lPw3ZeD9Y+qlNbvptD8IxVBrfQRYuiN5MlpKOhpXCSNHt9WBOsFv5Zr4aTKeObE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LUyTtw2r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LUyTtw2r" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4A72CC19423; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=GVLBLculdCKnhAiFJ2ef4yLpdlinMTlal7/JRCLg0f0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LUyTtw2rmME8Jz8lhPxijBZgVwqcWVLEbyx9HoHTTEI+SSqbOg+6xB/WlwUZ6T3Mj O7jY78xhqVR7PZ/r6h13FibQokgSeaDsKinnrGYX7MUD2slZvFOJxHQLSXvJqYxid1 7THfXCqMkkGTWUnxpS5W2vyrfY3MiUVU9glaxmXBpQfeFDRHm1gdOwGFw++VRc1hst wSnJ2RjGx2E3RizbxOHjLo4CeQbnoBt4Rplk0/9QSdMv6Zvl7hVKvWrtucPuRXGoGz zY7DG2HVuvtKS7sMNd9y22alHemdJNTKdrv2ZQdnM7tHJrjMIdSDwgRfT5TsMlPtw0 5ITaoAzSEHeRw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41079CD8CB9; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:37 +0100 Subject: [PATCH v2 03/12] drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-3-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2398; i=david@ixit.cz; h=from:subject:message-id; bh=bCUObjPE6sND+pIgM/wutRNG+EBQRl07BHTzasDZhH4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUwr2wir4U7ZIpBZumdeQhzmdrM5CQ0pfPU JhiNpj4bW6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg cmi3D/0bTHoMJmN/Qo9o/LvNKjVSwqXrRUWf+hKCXWN71h4CU/p0Ch1ymDLvZBeRzt8a4OhWCen O4Oj5GulsPt9EiOZyD0VdMbnida8rKnO2/AhKjjTXel/PSH6uGcFmK3jneUEe8vXea4/pBJk+XF izmgXvIg9KBz+qVfzzQF2jlUNpZr0FMydljZKshetQl0pPn0nRgmHOKZ7jwrHUFI3c7njZmij2T 2W7+V9NFhpSmqDuRk7oj0nCLs0twtuqZrpZbhRmGlsad1W8PxM1WkLFUmAZLM4sPo/Mgnpje+Di j8oqoTOJxhC+NEKtV03vXkVQqHx/9tpas3jQRKZNBIJVe7qLVjq3RYj3ETQnfO2e6kLMwbZh1ZO UsDLhStxOPRpboxawEhygeLR4uW/prsnxcoM9UIMLhWRQeLO9wFo6bysMkpf9keFNy6vTz1Kh31 sqPonL1f4Wnfpy2uCFz+xJuh8XaaqB4G+8FkZDmhPyluXdwZGzgyWO5OC1B0U+Ja0ltLO4FU6ji Svq/B1ge+nO+f0KCDZxcR0GA+QCjushTYotwhVZx9AX9KmLOsvYGgVySqf3TOega737zOqszSt9 HnKlF4UCODAKiM8+GH5sDJRQALP1qQCElDie9oTUCVNywpmxbwnMgRroHsjavY9xUIQHANulsp9 1PRC7gwC9ZKvsOQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Remove leftover from s6e3fc2x01 support drop and clarify supported panel. The Samsung SOFEF00 DDIC is used in multiple phones, so describe it properly and generalize. Fixes: e1eb7293ab41 ("drm/panel: samsung-sofef00: Drop s6e3fc2x01 support") Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/Kconfig | 7 ++++--- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index ad54537d914a4..4a0b4da0fea46 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -881,16 +881,17 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01 DSI protocol with 4 lanes. =20 config DRM_PANEL_SAMSUNG_SOFEF00 - tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" + tristate "Samsung SOFEF00 DSI panel controller" depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE select VIDEOMODE_HELPERS help Say Y or M here if you want to enable support for the Samsung AMOLED - command mode panels found in the OnePlus 6/6T smartphones. + panel SOFEF00 DDIC and connected panel. + Currently supported panels: =20 - The panels are 2280x1080@60Hz and 2340x1080@60Hz respectively + Samsung AMS628NW01 (found in OnePlus 6, 1080x2280@60Hz) =20 config DRM_PANEL_SEIKO_43WVF1G tristate "Seiko 43WVF1G panel" diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 064258217d50a..c88574ea66e1c 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -252,7 +252,7 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { .probe =3D sofef00_panel_probe, .remove =3D sofef00_panel_remove, .driver =3D { - .name =3D "panel-oneplus6", + .name =3D "panel-samsung-sofef00", .of_match_table =3D sofef00_panel_of_match, }, }; @@ -260,5 +260,5 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { module_mipi_dsi_driver(sofef00_panel_driver); =20 MODULE_AUTHOR("Casey Connolly "); -MODULE_DESCRIPTION("DRM driver for Samsung AMOLED DSI panels found in OneP= lus 6/6T phones"); +MODULE_DESCRIPTION("DRM driver for Samsung SOFEF00 DDIC"); MODULE_LICENSE("GPL v2"); --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE718359719; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=EEjQkSOp73mjHzoWbEiUsoJglBivg8un/WcGQ9VkZORShHy7hMFIckyIGRnSzgqkd9KhAsNEafZbCJ/OHXEzy9sFJR6cSrSGKVs6tU1GP4k0ckQhJlOH/VNs7IyVo6mTTXaRobWH3JpTck3j0y10EzEGMlTLm0PIokzfA4DjiuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qe1U+UMYmKjaD/m8d++96u4q0r0/2ak8ryyrWNgNAbfal+nlfD7G1JyM5Zz83iSfVSkPbgaYkbgswSYEUfJmYExWJoANFsrcASsOCuTc5j547I/Ie4jBp9wf8y48VUqIo4nR9T0YSu7ECf/PYIBiktaL6hrZWmSzalxF/e4T0lM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n747TH58; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n747TH58" Received: by smtp.kernel.org (Postfix) with ESMTPS id 67F97C4CEFB; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=n747TH585rRf+bD7610Oub4FWouf2az5JmCv/aDz1pt/oYhlM0r9ehplTp4KVsqJM 5+eWJTVgBUb/+mWr4ObPHyA/Ew1Ldhv1wbmVTFmINDliORbAWl/31OmEms9VEwUEqP I57bIWSo0dU4HJuDPLr+hntQru2O8VqaI1gITIxOwtVVN63MN7jV7Ysbk+t1kuT1VE GPILX2std6nqUqHMESCCzAoz9+iH17tU3lR+auBCgckwOXcubZjol4dwzvbtJPhKVY moaClI+B42ZC5KwkyfQAvdFe6AwkcVndoW5nHCTRgoO4tn2jnQREX7eutovKF/CuEd WRxUnJpVpHkjg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB9ECD8CB2; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:38 +0100 Subject: [PATCH v2 04/12] drm/panel: sofef00: Handle all regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-4-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2667; i=david@ixit.cz; h=from:subject:message-id; bh=mwo54CYnw7MO3Xycn85wubPyOShFMxI9iCM2JhaFHcY=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwU/i5TRLIYYU3ANHTvpFIdyLpFU8Xx19TIX nVDhA2jWqaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg cgZ0D/0V1/PLjvSKzMRgKLRV28Ya1Uxmo4zbM/mZVaw6WJmrRpAZECmRyDaiYatgkWlGZW0IkOq kNAnvUHcHzNoAK7qyWfscQMIdNl3Ki+VEIWattnMQ9tuzqWPWMgggLGJ+VsYX8GOh0uF0nP9p7e LqSGxVXC/JdcpUZdZpttF0dsoaK9A8uQbrhCi9bcr8KDjAY9jcsvvghLjo6wRn5I/oz1RlDLMJM eZDNVBiJkSA0C/dqnLtrthEwGHsEvbiZSVeUgX4h3vC48R2fVFAQeOf2Tyq1EwntVTqnWIoNDLk CqdEOq7ciSRBO/1WMUnOZUsaJlWjhJ5dzdyknTrY9Rc7jJ2DoWbdxxZubPlD1oaS/Mremq01R4x DyOSa+RdzgpuFCglItzlK1wY/Qz22rjsuCJT9D+/cJ23bIUCftY/8tBHx/uqXXDWmhBW8f5niJk PFPSnPQP1xWbnuQOLo3bK9ERpiOQKlfZC79enX9RYfUsPpEPR84OzQ458DaZibHcVL0gQX3nxdU v1p8P0AwheScKgjU/sn66m7lnzCV3dYXIBizLKl0/HvcqQN7/aNZzA82dszU5focAIl6EiUHCnK MZQ7NRtk4yON+W0lyABx6Ncfv4B97tkBqutdBUaF60WHs1t7g5LmkYyqhMSeOYFXsU5/eghBDN/ Uo5ZUxRTHcX3y/Q== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Recently we documented, there is more than vddio regulator, adapt the driver to work with VCI and POC regulator. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 28 ++++++++++++++++-------= ---- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index c88574ea66e1c..3097040e6bfa0 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -20,10 +20,16 @@ struct sofef00_panel { struct drm_panel panel; struct mipi_dsi_device *dsi; - struct regulator *supply; + struct regulator_bulk_data *supplies; struct gpio_desc *reset_gpio; }; =20 +static const struct regulator_bulk_data sofef00_supplies[] =3D { + { .supply =3D "vddio" }, + { .supply =3D "vci" }, + { .supply =3D "poc" }, +}; + static inline struct sofef00_panel *to_sofef00_panel(struct drm_panel *panel) { @@ -86,20 +92,18 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) static int sofef00_panel_prepare(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); - struct device *dev =3D &ctx->dsi->dev; int ret; =20 - ret =3D regulator_enable(ctx->supply); - if (ret < 0) { - dev_err(dev, "Failed to enable regulator: %d\n", ret); + ret =3D regulator_bulk_enable(ARRAY_SIZE(sofef00_supplies), ctx->supplies= ); + if (ret < 0) return ret; - } =20 sofef00_panel_reset(ctx); =20 ret =3D sofef00_panel_on(ctx); if (ret < 0) { gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); return ret; } =20 @@ -111,7 +115,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); - regulator_disable(ctx->supply); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; } @@ -197,10 +201,12 @@ static int sofef00_panel_probe(struct mipi_dsi_device= *dsi) if (IS_ERR(ctx)) return PTR_ERR(ctx); =20 - ctx->supply =3D devm_regulator_get(dev, "vddio"); - if (IS_ERR(ctx->supply)) - return dev_err_probe(dev, PTR_ERR(ctx->supply), - "Failed to get vddio regulator\n"); + ret =3D devm_regulator_bulk_get_const(dev, + ARRAY_SIZE(sofef00_supplies), + sofef00_supplies, + &ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 ctx->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ctx->reset_gpio)) --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E7E359F86; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=WfD+oef/Jo5RqSSF5+5sAioc5mN9djRgm8rdtBBNKyOfJ0CLkdSNdmGxKT6J1S0n4Zg3zKIOA3MsrvsbD1Rkpf9O7+aM0BXDcsxpd5TLo7caxzj5kad8H9IqPtUkaxVhGzzhm+DSxNaJbMcXhk2W/O/TdfXET9LJPbEUT9TEG50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SAxXV6Jo0or5h56PggGs9iFNlTv57QIXhQhggHBTlyAKBU/Avc0CtoYhur0Hd89j7wrsSUAt9keSImSP2WHSmNZqGgszyd/B6GAC4zfs8h3Ebg9Okc4G398mwRPR69WCKDYPUMPV0eZpnyIefSGDYpCGntMkNrJ5Kc6VSCgIg7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ResWzcV0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ResWzcV0" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6FD69C2BCB3; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ResWzcV0c4lOaCtc5fsRNaFWl02Z/Is+ArDESCvRnHP2VRMtN34NXbeQiWyfRvjKo uFu5/DaZNESCkeBdLIrWseHbEfLR4+OdV4IDOt3dEIORtn3UNnmx768cssbMBbbb8d JEcCufG/AGq4q6GWY0ig0b1Mv0ziWPvcSLGricA2r7a/mH30emwpKY24oixVtrqJxC aNO9vhsxaqDEdCXrgizXuzGO+iwvy2dywd3YurzGj/nkwDv8g5f46Zb3/te6FeYrQA QOcR5KJBIJnKZVplSkrkbaI19AEJvrm+vcEv+ufg1ylVjgkcGhTNqzQ6tuIrUE1pVY 4C1avwUp1OL8g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D917CD8CBD; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:39 +0100 Subject: [PATCH v2 05/12] drm/panel: sofef00: Split sending commands to the enable/disable functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-5-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2045; i=david@ixit.cz; h=from:subject:message-id; bh=xfG4W9ai59WdRLt2V9HKjqKsc6sEspLbINOP0a9yxjE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUGXzAbG17sDfyaOHuZB00UB1Hm4CErEAIN 6Z3Kq5G3CaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg cld0D/0Rh7WmQyKsgOmdspslAxL2eWJFo56eMotujOSOk73SpZ7S3Z9tYFLnejQv2WnGFoLcoD9 aFTQsUKg6P/aZ96VU2tbhFVzhRTWzc5ohiFZf+yWRa9H3asWK2Csee+jwLUPkKjWm164kvCponv Ro7+OfuQcYd9E1cNYLPJC5F0uVbLjE7zwFtCn42NqLu8iTvr4GhCNJfUv2lOfABCooriRpMqPCm AwoXBGG2wx285rsIP9PIIY/5ilqLzy3q1R15wjptriauqZO3Puotdo/ir9UvEYjmzY3AqwQqNXV Z7+DW93ThTEQUjEW8B+k1ZXZY88NJJvVH+7lmMyQLrBmjNWsFXh+vHVKpx/4hldVVqC1skrHMNV hWCNKDsu1IL8+jpSyndYVMXj4CkJYU2civuOharkx8QU2C5RmQ/W8PyPBevAlkscHu8ietJbQR5 e+kKuuhD8WUjNMtV1gelO6Mcz+aEBbu3rIxxXHozfJpJJMgSYZGKdOHCYVdvel85iMu1odM75G/ A6EYi+AYzaEG8wB4tEQME0IvmKhBwhnYNfsKkwNOVaEMjYw5uqVrTsMkLGg7SX6Z1W/HjG66KnQ UFGV6HT2yuId7jIuSBXbcQftn9NcaryiyxPgrKD5rkhc2Kl1LnvAxFgKqOeD9evFAZ5NvMbuoFv IP1ynH5dl5bhuVw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg It's not possible to send DSI panel commands in the .unprepare. Move it to .disable and do similar for prepare, where we move the display on to the .enable. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 3097040e6bfa0..a3651f0060bde 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -68,6 +68,14 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 + return dsi_ctx.accum_err; +} + +static int sofef00_enable(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 return dsi_ctx.accum_err; @@ -110,11 +118,19 @@ static int sofef00_panel_prepare(struct drm_panel *pa= nel) return 0; } =20 -static int sofef00_panel_unprepare(struct drm_panel *panel) +static int sofef00_disable(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); + + return 0; +} + +static int sofef00_panel_unprepare(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; @@ -154,6 +170,8 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { .prepare =3D sofef00_panel_prepare, + .enable =3D sofef00_enable, + .disable =3D sofef00_disable, .unprepare =3D sofef00_panel_unprepare, .get_modes =3D sofef00_panel_get_modes, }; --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F71359F87; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=Izu5EgZMciyfNMXHw4cR3yC/CSe7uu5P1HrusXOg8lg1dNRRRdSPxJaT8XRWNhnytKRi+u/hQrXl7XaA+JjgCZ1cxWzdEsXl84Kpe3Ce5MXgpL7pASm37ZkjF8fSkFIeX2oBvfRwrJxQsXv9Vlstp2azJujwu3iZzf/sDkw7wSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I1IOQdWkxkNQvV3/qE8kslB5b9n5TyPpCxXZsthOfc3eRAg9hNh8PKnfw1KZsBktw1fIiPqJSjSDXk2fAR9IYwJYEek95mZSlEIjueH6oUIy7L66tBe8UvDjuF6a71gSS/yhulyLdnnOiZ4nDcCzxQyCw35mpv8Xjn9hj8x/F1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AaXFNtPz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AaXFNtPz" Received: by smtp.kernel.org (Postfix) with ESMTPS id 83144C2BCB8; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=AaXFNtPzjRqS0cxi6VDUtR+vuQ31hCOSvbmw0zMTgfKTDSNWnqr4KOwH8g2pmyxAE UGjy02Cj2OCq3U/I+qGeUEwPJ4bfx3gP1C1SrGLzUhqoZ7TcAwOQMuOlv++tABr1De 3hDoUUTTddrYipgOMgsZ/Ky6Ri7wTtHKb3ZtN3Uu9/E3GRx/FCHdTv4B9YiIaaPbhn 0DS3S+nzdrLMvZoeWEfmjbsUesSdPzox4zfWQITcZhDSpnN6FUDa4BQ+qbc5tZCV5e Q4SDPbr+Ga2TNlOTasrrVDlK4lNXClWuSCPxvKArlHsSWj4HzHl2FVndUZ7HOzkRJQ Tb/QzccI7xp+Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B78ACD8CAF; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:40 +0100 Subject: [PATCH v2 06/12] drm/panel: sofef00: Introduce page macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-6-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2024; i=david@ixit.cz; h=from:subject:message-id; bh=KFWwy/+TPv3o+Pr2om1zoaTzQ1nmZjY1fcOyZY+O5S8=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUCmAOASb2D9sDkONbkm8n44ZkOV25X9leB YYg57le8QGJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg ciEyEACHuDcOWDQrulCiLG2H//bMfSYhxVLsYaj0YYJ/ameYOo6w/oGJ7ACVG+UK/GAP7KcTjI+ /UTLfZfsih5a1d773cCB+u0z+s3bVqGdgFAk/Px4lI3dwnsfAzEuFn4z8+ANBdWC83YERoOoQ31 uTW7JPFmBD3lpDpc2n3oAuC8Yzp0absqpcUTNLqYzJg1jOLaPT40YYHhMaLlZjDfcqICbbAqIFg FwHMSvLwv5SpmaEn6CIR58kFi2uyC6nDx6p0dIXPU5CfjhEw8dQaz/B8YQ3jnO3s1JJaWiqnw7u aDaKrIVwD//cY4KVlxS0YzcPzPZV84OGtivU2+Upl7Ih1SqGy3AeGceyFj56k7ORTzuMfzP6jW3 wrcPz7vRe9PIjnALDSwUElwhyBuHNK6fBOPVxibqga3NMCZx8bUDGzCVf3U9VKRIEK/3rfWqzV4 lXmzpUvn8gtUntCUgZOdr0hFZwwKNuLc9HJToz3wGusDyBKbLaYuYqxzX4Og+Nn2FEQnXbrV7ON 5DeJIiNV8YZuuh96/VEBAeurIPAocFSA6pgeBX6FUs3Mnv4HfCWV+l9qsHCLwma1bXnv5isBz+n ZnHochmfl5W3i2IpmUIGvq+l1d0wva2LxBD/A23e0NKq2iwxwhc8o/Jc9UthV7CZcWyq1+vOd5o SFi0FBbqJjFdq/A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Introducing the macro make the code a bit clearer. Looking at other Samsung drivers, I assume it's lvl2, thou due to not available documentation it's only educated guess. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index a3651f0060bde..97122ec8872a1 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -36,6 +36,11 @@ struct sofef00_panel *to_sofef00_panel(struct drm_panel = *panel) return container_of(panel, struct sofef00_panel, panel); } =20 +#define sofef00_test_key_on_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a) +#define sofef00_test_key_off_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5) + static void sofef00_panel_reset(struct sofef00_panel *ctx) { gpiod_set_value_cansleep(ctx->reset_gpio, 0); @@ -56,15 +61,15 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); - + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK); + sofef00_test_key_off_lvl2(&dsi_ctx); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0x07); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0x12); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); + sofef00_test_key_off_lvl2(&dsi_ctx); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A5635A126; Thu, 13 Nov 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=keP/z8Gzs5M82xLMYy6VZ0yWMcEQxEenFM7rqwXV8qWkKLIppkMO819+pSAZS745ftZ5rHTMhTwfM6HWlwMcuvv2BcTstXP5lksMhbZaOaIoI8VMOkAmBsLGwOkYN/d4laRu/O2r/CaB0kGPOkk5IGt7fkVjHt4XoAroZPx/x5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gwS44tRO3bL/8YhZt5NzCIVIE1OItg0EHep+RCcPnrJSS2EAhV6jcWmufiitKynRmGGPcvS9J7NE1DBIIAAn/kHDThY7Wbnua0A3RwEdshAjxsfDp1AKIzjiPwi45dZaFeC+iLN/v/mCtKcqSHde8BnTUaIf21zY6NRvlMh+o5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q/KQ27u4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q/KQ27u4" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9BC60C4AF17; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Q/KQ27u4zTv29m+MjdXPAhf9lJ7mo56Y1KNWGUZ1sgEUplZw5YefEy5xlO+W1a0mP 1VbwwqJhH0mgkLteNOM4dkZCob1578VS9UZ6O7IEZ9cAdvLyxNoGoO1s/Acka6bjQm CuuBMf+AX+WLJkMJkWHf+0A+DuVjVvNhoc+PsyXfx/E9mUxJ/gaY49RsFE+wJvGE6X uj6QlQDHysv88ZUe8l5vnrJc8c8qR10M1/uHUxVHI2oQrtAkkBSRNX80urrrslUxYu we9ura+z492bJ0/9qNnlRjzH4iMCPdAxtVIO84D1tNTgYDUwJxs4vArZ/CJemGnZ4U 4uFOaq/OvVsnQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CA9CD8CBF; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:41 +0100 Subject: [PATCH v2 07/12] drm/panel: sofef00: Add prepare_prev_first flag to drm_panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-7-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=918; i=david@ixit.cz; h=from:subject:message-id; bh=4SM9hcft9HxR/OcdKpSF5Ee1W0Jyu8dLyBp//WZCcbk=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwUfInDpnot2Lif7w3ILqlTPGJJ3Br0iShCu 3feEgt+KOeJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFAAKCRBgAj/E00kg cnYBEACQAwA9BeyyljPq7HJOHrhvZh9FYpzIvYsmzMx3dCPmLQ/Uuw3LgrnfNRZkC+Pw3exppn8 jzW7JJE8SQTfdIpZ9KegVyMdvSGzayBPe/vya5/rpDatH1qHs2LDN1lWS1V2ZC64dqQjue/33nG Dupj+36uT2MTYklpig2tboB0osJHbvpPNPRLKkE3avGtHppiH7mVkA//heK4AEKvpFmAITJc0Qg D3vFzVAe5efNs2HDairb2vJSrMHPG9oevbvRhREYdQ7Iy1StCr6qaL/6lzkIDr/Boh1JdKb0zEg RDh3RTAHI4x7CrvIPy5MEHVx36S0ZDY90NDxQoOOW4QVNho2HUkrsT8lMImL/yUP7xz6hiCIdiD 9SIgjrNey5IpWRhMOjKArSiwlVxxOB2t4QHqc64/cdNAf+6WYQSwBHnmox2t71YR4Ydhc0Yydy7 wbCi6RffWzZOOK8fsLd9Q31rvBKAhzsk2RaSo4cX0EOwlY32dCQXqefs1uMh20IrUJWfHLEoGLh N3HWjT+TwPCtVeO/SBd1DZkef9+Utm+ks75ibtQ99W83nr3yyT3qfnZrILqV6n+tCUJgFEfRzNL QNYr2U7UuKm0a7SWVZaeYmPUEK1nAPoVUzrvOmiW/kn9LUPwUChXDnoccGnvvkCE8E5B98VFI+h CYW5lWzbe6JxS7w== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly This corrects the host initialisation sequence so that we can send DSI/DCS commands in prepare(). Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 97122ec8872a1..0d3ae0689a19b 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -242,6 +242,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; =20 + ctx->panel.prepare_prev_first =3D true; + ctx->panel.backlight =3D sofef00_create_backlight(dsi); if (IS_ERR(ctx->panel.backlight)) return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3446359F82; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=hTcfm3rp+g2vlGVE6ggUVzNVqX/fR1rEZyvBOVLTa+EuEkrXL2JCS9CCL9W2Kdi/hDAzOyujf9GKYgAU96eZ6FJyHnrNuLisGtNOBEOA/cyha+OCgZhU5Ts333sHyGGRADqMnN8JPdYIJRHLK++oHRRZkuAp2zQdAOkrWSc6CCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RxDNxZ6iE/tGhO01qi102fLLaKAk+9gZiKekLLy0qZkaOKmjfXqfVERVk6EOqZP5g1sXBhqBbUV+dq7yfFQ7/0cak4SOKSaxgMEEvTtlpl1dXNP515BRc6GeNO9mx5HSqkCSnjbrl5XI0APn02nOShpi5g1u4INGs+s55oHAvQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MInRELD7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MInRELD7" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9AAB7C4AF14; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=MInRELD7LIy23rFZYlbCoTVor6zkVGh7n5+g0pOdq+VlpnXQdL+hOjsIeYpg0OaIB ALd7B+W+j5QMZNAaewTqdB6aWUDekzH/TbhFQ96LhcR+BToCeTSXypgD7SgsVPHnbr XieLXcA/IGEJB9JXItGfAW6R+D6MCg4MAFtwhsa7yjxhoVDd/6wTfMKLZb7mqxPVBz mqTGkch1lKf215XD0IxlpSgI/Bu8H7BoBJo8ZBAMeX3MsYXixClWB5D8tmwAfykl/S By4iWFPALLvvPJ+NTxc8vxrAfAmdZSr5w6eW7aBa/INInLYTrgDDst13No7uAa9L08 X1elJGr4n+EJA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874CCCD8CBE; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:42 +0100 Subject: [PATCH v2 08/12] drm/panel: sofef00: Initialise at 50% brightness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-8-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=858; i=david@ixit.cz; h=from:subject:message-id; bh=vjrHJH4EY6FJhDpprnzSkcksIGyeb+RoENa3mCki5mI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwVq+Kvp/Q4ZFwd7BdYq9nz4hZ0VZGi+hHN7 6pvliM5AyuJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFQAKCRBgAj/E00kg cgr+D/0TxPbmtYkFeycn3efdBGre+Z0Wbh3+TXY0BxAqq5KwwK3M1JjLIlHoi2ttO1ravPKzlbt y/BUiEFPIHIbZlAAkbdgVbanwRgSxaO/eLh2UmPnL/g2JRKEEUVit1IPvd6iw7NfN1w+9IuDqzc LD1C27DWYH9bB5bs9pKQKJWkuCOHuUXv6dZkBrL1qG76ApUxOUaveHoyvCz2jzWWAzDvLL6ejfu YcZWQpuHnWZP+gEge+VXy7mpdiZjKq0t7JhQwtdk6eaTJcQLfpCrL6RMdwO5tPembd6zxNwlktl 7fpccxsE3ws6HeUw85SyDOGd9W2Mvjk3/HqRvuukFXGydsgQJApsw8dEtfvY9PZQg1r1EkmmvxT jHeOJ4skoweazWxvLyF4WGAjELkmcRZFLNcdT+Ra7x+NWID8rOEI+UWcJdB/wXxVMsURKQON8vf 0vF3hVdCdYl48HYWs1G6ODFBi7DvnOAYL6L8OPqmBFfhMifff7aX95DXGtaDGvw7i8EUNpsbp8A CLRkmsXDaYOgrneEdEEHt9pgS/Ei8oNBbJAbfXXMuwMOjF0sVXyQsjfFVfy2zTVX/rnd52C00WG +CKQpWiyoqdcKX9pgh2Xxs46LMsh0+lIJqbGqC53xXXSms8NDTWyHzE2VYG20MiTsRViHzEZKR/ pnSKjk8LQWdJWxQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly Initialising at max brightness is not necessary. Half brightness is much more comfortable. Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 0d3ae0689a19b..d1e5340d7e337 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -204,7 +204,7 @@ sofef00_create_backlight(struct mipi_dsi_device *dsi) struct device *dev =3D &dsi->dev; const struct backlight_properties props =3D { .type =3D BACKLIGHT_PLATFORM, - .brightness =3D 1023, + .brightness =3D 512, .max_brightness =3D 1023, }; =20 --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA7535A127; Thu, 13 Nov 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=gTO2tZyGgK2+/5ImpmZ925aTDQQl+v8bVsRq6f1xNnThEPyUB3OQF9+kt6Hnhpenf8IDeGyHqN7/mhzjBGB3p8zUjxtxOfU+pmAuQh5EGla/W1spXTNvUydSjgPRCDYlCA53D5LQv3sL7izkHPraPZ3+ZAe0rQofIv0pSx7yH7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=xUj1dYlPEPYwm2kV3Z6N6ZbHCHuvd0TDb6H/1rnGsts=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KjwZjjTAHCFnldTJjuu8y12hlVDv1532O8mTbAqchsw1w8ETWzhfBIDqxMbGW09lUzfkjHGGKqzTYHZRhmwJqPjUfdZQrDbrkrs9zIB5My1j9dpNtpq1hfNfmPaWZMDxBVa8LkWpyA2tMdPQ2Tdh3JIPWhwcdeMNpYSmjNLekyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QqEKKmzf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QqEKKmzf" Received: by smtp.kernel.org (Postfix) with ESMTPS id A5D0BC4AF0B; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=xUj1dYlPEPYwm2kV3Z6N6ZbHCHuvd0TDb6H/1rnGsts=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=QqEKKmzf8l8no1n+OwzDo2VCY+m/2y3beLwyGdsvutzRrRtLj79Hp+yAKIG+lC71T Bidy2+cl9ZKc10L6q+nT6zSLHLm4ioiK4OCGReOybfINpFaDEKFujPe2rpoOeF107M wWp5Fr4Tdh9z05dIU2RsVOFYRfZ4qF8n5Kq7fe1EJrsIUMdLoBz984INRXnW1SUOqe 3iGlFRpFT3/t6r0TcM3d3k9AsnBVwOWzhomN6EkChXnpxNDz5UWbGN9/B6ia0LqFbk 7FE6HJSAhneKYzyY8Wyk2BW/7Jd6GuGiDmQ01D1Wqjy+5q1HXxJUIlMrQeiYzSPMk3 MLYvXVR8Ng/JQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B60CD8CB9; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:43 +0100 Subject: [PATCH v2 09/12] drm/panel: sofef00: Introduce compatible which includes the panel name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-9-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1727; i=david@ixit.cz; h=from:subject:message-id; bh=M9STxFOLgg4Zium2zG4uC3SLMrSpuJlpn7X6CzXpmTc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwVQ/8nXWi6K7GnvwZyzFNJteNMpJQtpCVU2 4O8dGk/9yKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFQAKCRBgAj/E00kg ctibEACJRajzKlRPa0TDMeJPxo3qOg7JXlDXrnKIE6HPhSkTpARjokYkkgkM1X45ZNx1LCgWsoy fecDxr73NUD3BhRQfQ24aWmDO+F97mBgoMAARIDHHzGDezmX8eBnlZNPs7Rwbrxzv2m+AFnoOSp X9qgXLk14Prvw96FBvUQoJC0D/YnjSR2eRzarCqP5cgKrBDmw30hC1yKSiDRf1LfEEAZsxq3/X2 WgZaNBIyk3FyYtlb0f+Q8CUGd68sTYlOmfsBf0wKyCBcM836A2tRLizvZhLZECqEDCKCatdCc44 I3EOGHWgG8k8lE58nWgXUTKqJntwaLMWesx7S/8eEBlLT9F0J3tOsZFnxFgwK2xLk0u0s6e9E/H 8kmiJU9t8orrRE6u9zFp/jp2OJ/H5TilbssmBF68csa2wRgjzmcB3PFxZWGCgrbNT6JxAUk+/TQ AfMUewJFrhCvpAq+jgKifyt8MiJBdn9nUDRFYfwmV666qxhrvk16Cgeo/+Fd4J4xpRYz683sigj p0JbKRqYucomwDnMyeyRiYeGQnZQI5D8aaWU6aKvM2EB6H8CUCR38DUDWFSIRU6ZlIZnCL0M/uK SpfMYdG9Qut4jHSF5Rcqz21Ycfdq8DhLWBvErInYSztWel3YfocCZmxPrXvbLU72Syes3+J8UeA 62fXbBeOFYubHdw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Compatible should correspond to the panel used and the driver currently supports only AMS628NW01 panel. Adapt the internal driver structures to reflect the name. Original, not very descriptive, compatible is kept to ensure compatibility with older device-trees. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index d1e5340d7e337..7947adf908772 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -141,7 +141,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) return 0; } =20 -static const struct drm_display_mode enchilada_panel_mode =3D { +static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, @@ -159,7 +159,7 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector { struct drm_display_mode *mode; =20 - mode =3D drm_mode_duplicate(connector->dev, &enchilada_panel_mode); + mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); if (!mode) return -ENOMEM; =20 @@ -274,7 +274,9 @@ static void sofef00_panel_remove(struct mipi_dsi_device= *dsi) } =20 static const struct of_device_id sofef00_panel_of_match[] =3D { + /* legacy compatible */ { .compatible =3D "samsung,sofef00" }, + { .compatible =3D "samsung,sofef00-ams628nw01" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, sofef00_panel_of_match); --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFE4359FBF; Thu, 13 Nov 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=orIm/lA66a0i64izuw9U1SQXIRIA0smXAA3AoJBZipU+Ur58S7EIQz385lwl/87Obg4PNWuI2mEpkDfBhd1EZGwNU2izF5e5vdJl4aW2NB1OLd/XMuwW3DlJkwlzjRcONE0cFHJxHgPtw1pFESiFrtJ3wbiKX9xwYcro10pQP6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=7kVUuFepyL1nqefy7/RVz/fzVOVxrSJ4iaI+ek8pJSU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uragp+9zybPv5fQwgNiUxk/0Lbfat0GD8xalGEerBOZI0nGU0ud9XCAC4KBlLvd11fZAGgmdRMuCrcVWRnTDmwrQxmm2WLsDnSZNTahxJGVymOr4/XW3MrPzrjc6yUdF1dyABmdveIgFks5SpXlgGb9DtFDt3zSORg2hKrf7rOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q6x7AKAd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q6x7AKAd" Received: by smtp.kernel.org (Postfix) with ESMTPS id B76D5C19424; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=7kVUuFepyL1nqefy7/RVz/fzVOVxrSJ4iaI+ek8pJSU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Q6x7AKAdtOyerUx7QPcOs7cWBRLgc+nkQD/i35oCokn5BbmSiPMaXt3Q4/pPWGYga R+uWUqJm09XhOJ0eeqvESJCDETBzdNClTrY5hrXLy3wGDpn/iSZrh0bgAc5bHyQ8sj YNQbQ32Mt+Ne81pj2S4GBwv0MIIuaMHAtAjEVVkUGI1sgZY7cetIFaJ4pmnArGQMZC eDmQNPMxILrkgUvLycNz29vxzyb6eFgbRUH6g+AN3VoaS4itHRrYxCXXAGDa8FHi7P 61IN7uJXqH//8c0Js6PW8xW0Zb36BJJ5yW/8Qzzj1y/6OC/csz7CP/BwhuHE5X62TJ RREvjv0cMKgZw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42DECD8CB2; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:44 +0100 Subject: [PATCH v2 10/12] drm/panel: sofef00: Simplify get_modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-10-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1958; i=david@ixit.cz; h=from:subject:message-id; bh=8diXpj4flXvL6PBJCymDKTVmS7jlHjaf2gFdGCxh2WA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwVKIRpFqk9VNuj0DzQ/MME2NFt0dVorHkqM TzTQ+QjZL2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFQAKCRBgAj/E00kg ckEDD/9lSX6mTKnL3nHiq4n7s39OdBTvTG0m5j7WJtVgpLXBL1TCRnBNvI1WVbHKleLmB45A2JR FeefsU/bfld7LSTz6+QzApBnegBsLiWFPh3LA5RqSWBXsXoaVgBnox89xEiVGE8oOd+I++acFfb APTTKlCVARJJ5pfLAKPiA/wNtD1W+ogE+MYbQ+JascO/fcPvagjlRZRzfN61eZWyOL0He5d9A4J nL4B0nuGfhGUXutQGwkm4mWS4Ke9vyF2j0kE2ibtKGhWQbrwKzKieBCXvASM9Q1FAPNVFvGgxJO RlEaGWo/KgSZBQv4HQkGfAgm0sK7jZ2Z4cRpX/AzAbX7xeMqNnos5PSPwiRSubMQkw6wbOfckq6 3PfEEHVqx/PyAbUA8fNrcVVwbaKE1mIxRqGjRWVGhB0C7Hb63HR5kK9gFdKfDXsfhNeWX8GRHAP t3Nb0zPYxrLa5kFoidvShTVBPUV7m+Eele6MigA6RweflH8+LteT+WYpu7UQ9sFU7j+CUY+hV7e Qk8g+RTBRdF6IzJPedvHoRU+KspCLQ4f7e1cC72l774vqd1DEz6M4ynw2nv0xHI4CUHZJ0pPV2y 7OGoHPvoQjJOE+7ED5dct9tU0qoga6PREhYchDoN5ttHJLiy4Jb3LAObtdjxotxd1Jta0okE0Bt UfyfgIp7bCu+fXw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Levearage drm_connector_helper_get_modes_fixed helper function. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 7947adf908772..e69a28628b656 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 struct sofef00_panel { struct drm_panel panel; @@ -143,34 +144,26 @@ static int sofef00_panel_unprepare(struct drm_panel *= panel) =20 static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, + .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, .hsync_end =3D 1080 + 112 + 16, .htotal =3D 1080 + 112 + 16 + 36, + .vdisplay =3D 2280, .vsync_start =3D 2280 + 36, .vsync_end =3D 2280 + 36 + 8, .vtotal =3D 2280 + 36 + 8 + 12, + .width_mm =3D 68, .height_mm =3D 145, + + .type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, }; =20 static int sofef00_panel_get_modes(struct drm_panel *panel, struct drm_con= nector *connector) { - struct drm_display_mode *mode; - - mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); - if (!mode) - return -ENOMEM; - - drm_mode_set_name(mode); - - mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; - connector->display_info.width_mm =3D mode->width_mm; - connector->display_info.height_mm =3D mode->height_mm; - drm_mode_probed_add(connector, mode); - - return 1; + return drm_connector_helper_get_modes_fixed(connector, &ams628nw01_panel_= mode); } =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B1935A125; Thu, 13 Nov 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=pL6+gAYm6WqsygJojOqXE4oFPSCA3g2LNwvR6yDUvQcDEg0mrcO+BH8wte6Y68leklo5kEzGkfu1gjnMt5e92zP3mzd+4PVStrbdvFCW8JDfeiX/F7TaTb2oMPPy2pSE3HAFFhQ6BkG5zkgO6LgWcfgCj3bXCW8xTbk+EUf6244= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=10XNWDQ1dULf+P9kZ2dHmDwf8V4xwRtNb2eTtETPwsg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wa8gA0tcoIHcbEMYlYTTCfVbLxGcgz0hlFWz6MeX/x7oi7BUxXhJBKdLFi27v0HPVeVNldQO5gibBMo61GYNnP82T2IeqiRo99HbyykmxBku8t5KA4DmwA5pCawnaY5ZY1C33JpRcZRoHJahvm9wNXOMWiywx84B9hYIj7ZSFXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lD4gdqjN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lD4gdqjN" Received: by smtp.kernel.org (Postfix) with ESMTPS id BE4E8C2BCB5; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=10XNWDQ1dULf+P9kZ2dHmDwf8V4xwRtNb2eTtETPwsg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lD4gdqjNewhyihAZYlTrRCj35GOYfToGv+06B1OPySAFTM0Jx82a4M++RGURm45bF 05f75x69UnJzHdYlu8SpX113s/bwSViAaivmdBkNaVrenJslPY6XOcJDZ2iu4eaiOw HVUw0OKIOiCAoJH7xhRdpUg8l89/dtDzBELvERmaHkiA+ME3GwXAJF26qXhjboYCPB nf2HD5QPbx8hxjWrSzbKVdWuh90IeE6zDvc5oWvpBe/R22Ryyw4ExfinoCgcBBo30P 9Oq5PPZa/aDW/m13M0DC+M5OZe1d0RdViFuBiFHa6WDW7Rfy2wdDi5OltDDFqxpMqV bl5KHNZEiqiAA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DE1CD8CBD; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:45 +0100 Subject: [PATCH v2 11/12] drm/panel: sofef00: Mark the LPM mode always-on Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-11-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1446; i=david@ixit.cz; h=from:subject:message-id; bh=dv4mgLKU6V9KA5Q8a78znnVTuWL2bX0IVKAwUPXHk8E=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwVWR0DhH3x/QekF3rJ8kiBp445Bbqdsqmu0 DdyTzmWe7yJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFQAKCRBgAj/E00kg cpEdD/9kDTBHwwsLMzCluvZCQG+MVWx7VHsDr/2TaORCXi68pKGY8svhOAB48NGv5nUCWkQbEHc Kep8Qx+rf3Ht1JHdpUoDJ5FwNbeYlPaXJhsQv967lwvTt5sAloZk8j4FYxxCP+HqbZ0oXVDmqNp ErPs5Y8tbiFkgUVjFiQ41LrPc8Shl7R9aIw0DKrmTQFSkfpRurb36KC4I8cE3bVD38+k/cEhuy7 JHq0mH/1PKntoxIm+T7XPQ1tQSwlRCSuXlrnIRcwjvs3/T052qaJXNC1RkM8a51WIGLiHZR7cvK de0wjvU35VOGe97oA0JoqYgpQhLRkDjvbO5Wgah2pijoPq1l5pWezoxDTOU91TpC6bdQFRyCLtP rLISelPF7lCoUmiJeImxd5y9eEXMDMYLQcJ4Uz1aBuJbha+ki4bW0hR2jwcEdJ8BPTCobiHt24I PYR3XAF+4oKRyNz5ciwXz1RVH5drEQpzwOqFuFOENyc9HQ/9GtYriexYuNhrNfnhbxwCyigaIfs d+gbrJslaKwhbOEEp6dFOuN1oEkM1FJGBygGVTdI1GBUH+5UFae1d1Tk5R3g2HwWvJ3XIZnQO1P /IqDJz9Hq5/fYK5kqOz33UkK9zUidF1ewOpnoJTRfiKcAinFz3bN21ZbcqYmaN72MDgPHZMsJ9M /BTsijqnJE+U7QA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel operated in low-power mode, with exception of changing the brightness levels. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index e69a28628b656..8286cad385738 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -92,8 +92,6 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 - dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; - mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 40); =20 @@ -180,10 +178,14 @@ static int sofef00_panel_bl_update_status(struct back= light_device *bl) int err; u16 brightness =3D (u16)backlight_get_brightness(bl); =20 + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + err =3D mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); if (err < 0) return err; =20 + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + return 0; } =20 @@ -234,6 +236,7 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; + dsi->mode_flags =3D MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0 From nobody Sat Feb 7 23:34:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D93835A12D; Thu, 13 Nov 2025 17:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; cv=none; b=CNqB0qakhfaHQimP73EX3jzMI1SE4L30dBiebJZgC/SdfSSEwptl/GKd3chYdBK7EJBUuIpEsCAmhQRMMuPGRaR0UKXwAq47eKOfIoJDHS7V3ZIS4Y39b1a10JVeEQxT/6OKT8YHHZeaEttj92O6/lYJngrmQ4vgsJhPhtT0GQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763056664; c=relaxed/simple; bh=sx3FdITHyUsho2TuXz9tyb+nFy6gs9cRfJfgUm1fuoE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iLs3Bm2FJsKU7kFxTIDVwul8CJ7+7IEJO1MJBOk3JfNfygGmh9sduZkZCYzT2EigOtVyS9OdEpkZOKAebtZads8zHXwGypPgpzteF0pE8/iKe7pRqkPS54Mb8PD9ZNPzwct3iOSfEd5xMsro0RWc14QkyNpI4m4jLWjp/aEJlYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F6BbOrdq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F6BbOrdq" Received: by smtp.kernel.org (Postfix) with ESMTPS id C65ADC2BCB4; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763056663; bh=sx3FdITHyUsho2TuXz9tyb+nFy6gs9cRfJfgUm1fuoE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=F6BbOrdqfcx3UNwYBBT7zJ5VVW/geZS3gxKpVsJ4GPbamufhvf9/6hJwH+vAkDJxn G0xY7whTbF4Ev9510Ujil5bjtYtpLYjHtmhEvk6f9vENNmswrKVrENYbBPhs7zoClS hoCpX8gYqry+XDZcCWam5iGn4Xw4tB9r7vsoDhc4htkAC3kDTaRfHKx9RAnw8LnhEN xCuHEg2fPlZUVV2yH/2wmZ2AfDUB8TJ8weStmgBsekwFpK69IjAEMy5OtLrsWt0f7z fKGBi/i5mgDMoB5bGitXqFpkFmxv0qpmD6TeqbxEtJIrWvjukgqMh87dV6Yf4csgmI xDFVhQ1M8G5bA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF595CD98C4; Thu, 13 Nov 2025 17:57:43 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 13 Nov 2025 18:57:46 +0100 Subject: [PATCH v2 12/12] drm/panel: sofef00: Non-continuous mode and video burst are supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-sofef00-rebuild-v2-12-e175053061ec@ixit.cz> References: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> In-Reply-To: <20251113-sofef00-rebuild-v2-0-e175053061ec@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=802; i=david@ixit.cz; h=from:subject:message-id; bh=OE1UAGoiypb8yw70x3xMaGL61XZlHwmG/9vzbFRjYK8=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpFhwVlzxcTH43qFIgD1KeqqVc+hIM0YBZcnxct +/4Os9eYZuJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaRYcFQAKCRBgAj/E00kg cpu6EADNb3oMH/dyM3eFqfmZwlMVEwrACCIRZysVcIzs9Exj+pK1EtPklFvQtPe51Zy8cq6+BoV I/VWjBWU61WgHNTRk3u+pPMnJPM1iEBs6NbhH7XiGNHR5nZqQu7HTmMDDyU7q4PoNeXz74m5MaT j8GF8GhLkQodcCQ3VMKSzbNMQij8xJu8ZmxOMF3J9rbN1qQjlGnioxlKS5Qi7IJnhSJFxkYFdhC hVbnvErRCiap/Lf+r3AQ9JujZiYRhtE78vDaRcGkwVdFMCiQ1UJfApoh9r2pZ3//E4T5H9S0Wbk xIDN17ni2z58jGF00iFOOetDX2BhA0/9agxUUL3Yo6hQiizXX/lujDNf0FLDLEU6FTIiFPp4JZT VaVeWi4nzJkEfRC9awIxeKWdFtbdO7Yl5cIfnEh1TTlZ+yI9tzHEmeDxO/2fh4TZSSkMY8Lg3TV BKXBal4GfW/C/oniamNbZRmLp9P0bzOOjBFGGcqrUtS7uYXNlpsQfmBlmcU/Qq76etBkhkI1kI4 aj6SjOCd4ncoaE131T8vGCmgyKGhRbPzTT0Sh7Mj/GjrzmKjZD9ZVsdYktAQpmixQMZKDHPtyLw K28YEkBQaNwODnumgKKmDl9YwYD0rmvJqE/y/Gs0DtdBbLk+ffzMOsH+yhmGZ8pPqWxcTdaHVUe qwQUmeS+ZPhuq6w== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel supports both modes. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 8286cad385738..b330c4a1ad19d 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -236,7 +236,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; - dsi->mode_flags =3D MIPI_DSI_MODE_LPM; + dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0