From nobody Mon Feb 9 21:37:32 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C43364E9B for ; Thu, 13 Nov 2025 16:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763052157; cv=none; b=Q/6pmlXh50j7rYeVJqVasW2YHX4hoAOlMzBUt7/IqCEOORTeYKcVUvRdvWHjDDzQ/mHIrqZj4KMIcSbSw84ptJU49italYP9/ev3wbT+fRJLlT7/hSzQhwlgNh8EG8KLklhUZw2qifJJZFbaattRj+diGT9Lx8tAgMlUVhTN2u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763052157; c=relaxed/simple; bh=AZDhgFsJHk/7/ccWHmuKjRVzzDMIUsT8B2xszzmjcS4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T+RjydmQmWyDie3qi83OeAP2BjnZtxdlsbhwJFjh9UAwxc1n90NJ/RHrSPgCbCvzLuXzMIGB9nkPzLnyIvR/Z/tgNUXAVQ0o+TjMl8r1w6A7XDzuKcvsl2JRo4R0r6tt6UZnPmtGbU1Y0FP/2SAetRSHaDJJ1xjC7fkVwamEEIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IuJ4IYJX; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IuJ4IYJX" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42b2dd19681so187261f8f.3 for ; Thu, 13 Nov 2025 08:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763052154; x=1763656954; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Tnv5GvLZO90fssK5mBO/V2ejb0VVnidgq+QHki0NiLw=; b=IuJ4IYJXLJ2V5+7Y5+mRDTUTL2yzgqfIK7tEPsOTetMWojJb6Y1g9LSVir2GIvKVRf Yv+a1pGGPiP6Gfxk16B/uaFurp0SkXbX+hphQNp07ksmvhtcOWOV7mjdOuI0BqjvYYKU zDONzb9C2el/O/eHTD6PIjHk62BdfujD1UdFvbAhW0UuvYcywIzbmM9w7oUWYdX62qrk DFBCpTUbKm+UhP7HXJ7dusVMcE2FsBbdwYrOUlcKBjsaVC2379pTisGc+099x7tO//2V e/1QdPmECdMRPGnOfCRPRTJO4BLRv+D3Hbpl4s0fCD/vFymEydKWRfbkioWs0E5X+Hzt glvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763052154; x=1763656954; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Tnv5GvLZO90fssK5mBO/V2ejb0VVnidgq+QHki0NiLw=; b=uXUqPz4jLQMzP6iGIZkN8ozQxj0A/LrUD20Hem7hAkMwRB65IFJ8zQYC/kj+Lriom2 6qWIYBlD4Hu/TJyw8YZAx+F1gAxaZNS1gl9BiiEhrU8TpKZ3yfFXfApRFmC/b13gjrbC gTWsBCwo1zzFzO7IjbrM8g8zDcGIS2lggPACgSsUDTNbeUi4lOawAbW5/cyXBWoI2EM/ 2EFPlG+aBOXJHrOKh/RwulNj903QQ93I7LaU+bull+iQAwWhkOyMWKahZQNl1wbJIf8t uIPlWUdHjX47zI/Nl4+RYOV5IwnZXyCgUPfhKVflUY9SpLmdWjQoL1/dFmaJwWc0fda5 2/3A== X-Forwarded-Encrypted: i=1; AJvYcCWv3justqjOxolUjcdKOEkwSoiN53pi3D4JPktQ/Fs3l/Scqq5s2OjnMecJXEWyYF6h4QQfFdDPgBkHibs=@vger.kernel.org X-Gm-Message-State: AOJu0YzI/4TahYHDGOkvFnpG5Bsm40WGIsV5VemjFampRj5cOWZn7orF l4JSROLc7vAJTqL87hiE7egLXTGqf+gBtudELDbS5pL8zpa5EuSyj+i3 X-Gm-Gg: ASbGnct4pp9l5IlSumtuM0vc2W14Lws9yzzoelxeOOI/w3J4+QpZJ4WEB+pg0LzPt9s ZHZ7Gr5Ulr41DDZg6sM/4eA9LijQw4gijR5mXFYPUmsrd7+UuknWi4RpyUXKbh/WIlaWIc/GMkl w9RUCZVlzOk0+2GBQXEK5IPHuN6f0rv0L2R6RMIollRVw/r4ot8a8AQbaakG92sCdH5+m5MUE+x bPwceIRNIPLnDbPL36YvC/oZ2IarSe/+oEriHi8G6D4oGj+h4fIFodz/wqMTBxGesrtOP/HZYyq veLsG7pN9aZDtvJ17ct0cXR4o3/MPRzvLYNd0Ol6E/VcaiE3r7+PJQxDZ5SWWHFu+oyHgP5cSiY semJ5k1hBbFNiAnuLCUGYAr3BiaIAcAmVCzILoH1kOCweXbVy/HKHpEqgQql+es0vMK3YtuQFAH F3UddrG8VAulfzahY= X-Google-Smtp-Source: AGHT+IFlJhZQHRbGLobb3YLbAsBiS2Koyw/Ec1i06oLS8N0XCLnx1tPyDdy1oAHB/rz71WT4cMX8YQ== X-Received: by 2002:a05:600c:c4b8:b0:477:5b01:7d42 with SMTP id 5b1f17b1804b1-4778fee8183mr614895e9.5.1763052153366; Thu, 13 Nov 2025 08:42:33 -0800 (PST) Received: from localhost ([2a03:2880:31ff:50::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f21948sm4877254f8f.43.2025.11.13.08.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 08:42:32 -0800 (PST) From: Gustavo Luiz Duarte Date: Thu, 13 Nov 2025 08:42:21 -0800 Subject: [PATCH net-next v2 4/4] netconsole: Increase MAX_USERDATA_ITEMS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-netconsole_dynamic_extradata-v2-4-18cf7fed1026@meta.com> References: <20251113-netconsole_dynamic_extradata-v2-0-18cf7fed1026@meta.com> In-Reply-To: <20251113-netconsole_dynamic_extradata-v2-0-18cf7fed1026@meta.com> To: Breno Leitao , Andre Carvalho , Simon Horman , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Increase MAX_USERDATA_ITEMS from 16 to 256 entries now that the userdata buffer is allocated dynamically. The previous limit of 16 was necessary because the buffer was statically allocated for all targets. With dynamic allocation, we can support more entries without wasting memory on targets that don't use userdata. This allows users to attach more metadata to their netconsole messages, which is useful for complex debugging and logging scenarios. Also update the testcase accordingly. Signed-off-by: Gustavo Luiz Duarte Reviewed-by: Breno Leitao --- drivers/net/netconsole.c | 2 +- tools/testing/selftests/drivers/net/netcons_overflow.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 12fbc303a8240..36ce19936fa39 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -50,7 +50,7 @@ MODULE_LICENSE("GPL"); /* The number 3 comes from userdata entry format characters (' ', '=3D', '= \n') */ #define MAX_EXTRADATA_NAME_LEN (MAX_EXTRADATA_ENTRY_LEN - \ MAX_EXTRADATA_VALUE_LEN - 3) -#define MAX_USERDATA_ITEMS 16 +#define MAX_USERDATA_ITEMS 256 #define MAX_PRINT_CHUNK 1000 =20 static char config[MAX_PARAM_LENGTH]; diff --git a/tools/testing/selftests/drivers/net/netcons_overflow.sh b/tool= s/testing/selftests/drivers/net/netcons_overflow.sh index 29bad56448a24..06089643b7716 100755 --- a/tools/testing/selftests/drivers/net/netcons_overflow.sh +++ b/tools/testing/selftests/drivers/net/netcons_overflow.sh @@ -15,7 +15,7 @@ SCRIPTDIR=3D$(dirname "$(readlink -e "${BASH_SOURCE[0]}")= ") =20 source "${SCRIPTDIR}"/lib/sh/lib_netcons.sh # This is coming from netconsole code. Check for it in drivers/net/netcons= ole.c -MAX_USERDATA_ITEMS=3D16 +MAX_USERDATA_ITEMS=3D256 =20 # Function to create userdata entries function create_userdata_max_entries() { --=20 2.47.3