From nobody Sun Feb 8 12:42:47 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6AD6314D01 for ; Thu, 13 Nov 2025 20:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066457; cv=none; b=brpnVl+5GwNiQa48Po/E4YvuPF1kc/qjBQ6IHMz9M13+dOodflfQqk2xFvL/wjvJskt/gMFwXX+IXZih0w7aX8+suBjdv8dEsLVGFNaJ+KyMR0pLR50isaP/3YstZjlMgoqAK9v24KPJek5sqTIVSumSLfEjav5QPj4p4F7VZjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763066457; c=relaxed/simple; bh=tj7tl1xY75QhAePiZ/+a/AlI7VgVWoD4r4G5vQ12TvE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Dhsm4jd2LFeYbhHzJlLNtv0wf0MwjEt97YqpPlSVUIr/h6UcJYfpEMVjxeshlej/Nl9QdhBCF9BD5gp4jhQn7dsRouKu2R2PhK8h/qqEaSV1Ic3Mnf8YR7WJtWQMdTOrUZCn37NADssVOOsaSlt2oUHC4VcbDswPq8TgiKBOENk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lTHVYmX4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XvvNx9/l; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lTHVYmX4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XvvNx9/l" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ADIMarp1172391 for ; Thu, 13 Nov 2025 20:40:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=un1sbvC4EIJ4U5h2uAEeAY 8i8VLppsg5RBzR6nEWK7s=; b=lTHVYmX4MIZIUUx/+AS+ENIcMw86Zs4P1N8w19 pJi/0I9ziwFEpEqoR4hBcdhL91/7ypQ7G9RORfSj8Z/pANHgY8zcCQaEkb5yNVOB k9qMXlMn0VuVSzxPy/UWABQsK+AbXZ7EPRaEOAtQdQglxN4iYZIBG4cnab4y3O4x couksKNHZSIMaejjcg4r3oRvC+a+oZ/WturNENb2SVvEy34npeXdypXpgeLHuzwE sUKB88PEnyAF6nHvdkmO/ViVMNyIKQkVArruoSgS7owsVBEZf+JQrD+sAIUShpSw 8CK8az/kMVYQ3CmbXAqlF1ENcq5brr3/hSUfABysYCcGq+FQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4admj8gcaf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Nov 2025 20:40:53 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b2194e266aso427011885a.3 for ; Thu, 13 Nov 2025 12:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763066453; x=1763671253; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=un1sbvC4EIJ4U5h2uAEeAY8i8VLppsg5RBzR6nEWK7s=; b=XvvNx9/le4Ou2CGPcYtfjDUvMQU7KRVjGcKMeKUG9nx13mLb06qgR0PjvclVacDBaI 7zDvUoqqJAIlCfCl50iT3HyORWiWBjOW3aWi5C+GamcN2TyDyOlwxRGjbpRIXm2olPmf h0Rg6p7cm6RqAP8lViF7AB9+EQXlcI5XCaq2YbYmb7mHi9LmPsGPHvz3OiQjB7TrpYE5 dAZ6D9frlOxMxNYsU+0Y6h+Xf6AV5mFA06WhBFAta/ldtN60UAQlejZHJlGk5mXm3MhR IwUPBv/dQVtWMyAE2AjIb4kKmW/KQa5y61oNUC5MdWPDPwX2dKBOQ4Qbtkky0TNHxnSi 2e9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763066453; x=1763671253; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=un1sbvC4EIJ4U5h2uAEeAY8i8VLppsg5RBzR6nEWK7s=; b=CU5FtpfcO2U/zpm+T1IKr2HxV5+zb2L7jvL5DDmJHQU39nUFKQSwLEcJnf8ca378Ff 8Xnp3LvVsJKnMawGMnYg/ttwh4qWiLConMTgzngv3NUeHuyO1cuHJDZIFwE4D4ZlpnQQ xtPp3hzqZnwLmEE1AuEN1v3zCh1LK3daO9nAURzej2zHaNgcxYLGvFuYeqTj239m//WD 9ZEGOwj1LjimvXNoksJXHgneCmzVphzU/x9pYhYENfSVImVrMKxEwjWda3ED+0MEIBpV lRJH1GzeqPv7fRS6G4qr9YMoY4c/FOQYeamZ8chRZYwkhNVPAmL+tUpV3BmHvIqm+1Nz cLLA== X-Forwarded-Encrypted: i=1; AJvYcCUmVExhN7mNAH5VwwJBEdipIeNvzDYMXAkh0JrJQEhc5737+Ofe0NYSsNoma2OSK2AzUWQIlkwWXNAaFG4=@vger.kernel.org X-Gm-Message-State: AOJu0YxS6O+ZCnRW4Xg7dXWpkMUCMf6g7q7jvdnpqgut0OzWpqkBNPfL wuVYQTaw2kRED37R9/UwAxwPvsYby9Fg+gjYutwN/VDrOOYlI0HIH70i97paAICBb3bLBX/aHP0 5qiIY0xOywxUvJi9Je7Jh7CuY+xxSPUhezDE5+xIIRlOTMNieJPpUNyIjn0taZEpLxDk= X-Gm-Gg: ASbGncuzymOGVXk3+QldJMt/BhgJp+LekJf0zLRBirJ/i0q7dzoNPnYRghgGlRG1veY IIVj41dbioXdE7a9yrHT1QMjyaVhNUbyn3wTnazwYZJOMlgiuvhBXqmqYxah7LJgm6wZldfSUF3 p25YCKb61bG+2Rtjr1B12MEZJJdcnuOvA5y5CTGqnPfPQUCqLIGsZQBdcZzydVqBf83UN2788X3 eV39TYRYnO8QYdVtiHGJOrxaEuyyHaDbvUW4GuLTrUyNfTWHpy1ciGCNUOqNRnnKa5lsRuU/MZ4 jF0q7QaJ2ohZMIDkcDPfOY0pzxFwnbjPM7JkD/FQAU3Ltgx0IF2wDjbU0GbEiJEssHh6+52fHWN 2ecm5s7jA0rG9KH2BWuWCckve35Fkbn69lLrctMcxQvykvAuq/G8rWrGvMtP3rvJeeanzpw4fO+ rknNhVE1MwfQzS X-Received: by 2002:a05:620a:468e:b0:89e:f83c:ee0c with SMTP id af79cd13be357-8b2c31c782bmr99107485a.74.1763066452637; Thu, 13 Nov 2025 12:40:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJcep4EHFroUI4le9fG2p8XxLEpE63t3UsRzTaVzkNUFIpdtbATFPMKQRz+CrN9TDqDI3V8g== X-Received: by 2002:a05:620a:468e:b0:89e:f83c:ee0c with SMTP id af79cd13be357-8b2c31c782bmr99103485a.74.1763066452109; Thu, 13 Nov 2025 12:40:52 -0800 (PST) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5958040567dsm607217e87.86.2025.11.13.12.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 12:40:51 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 13 Nov 2025 22:40:50 +0200 Subject: [PATCH] drm/msm/a2xx: stop over-complaining about the legacy firmware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251113-a200-warn-once-v1-1-c28bdc8e36e4@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAFFCFmkC/x3MQQqAIBBA0avErBtwNCm6SrRQm2o2GgoVRHdPW r7F/w8UzsIFxuaBzKcUSbGC2gbC7uLGKEs1aKUtERl0Wim8XI6YYmC0du36QGYI3kONjsyr3P9 wmt/3AxdqlE9gAAAA X-Change-ID: 20251113-a200-warn-once-55f47c138cbb To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1453; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=tj7tl1xY75QhAePiZ/+a/AlI7VgVWoD4r4G5vQ12TvE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpFkJSdvuNwFeOIk5OMolNUdG/dAJrrYoH2YqeC q5pIr7R0weJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaRZCUgAKCRCLPIo+Aiko 1dcQB/9L+DF++n7lQF+HQ177fs6ET7FY2o9xrczoEC5Y8wtn8ZJaLVnxYRLzaSUkoJb/4pdkL10 DZIdKuCGMiyCAlfAZYDhdeY+O0dh3J44hVCij4UliwOvFoO2ohxBqgG/CldOHC2RH4S6uspnXN/ EK3/Jpqj++7yibambHKiBA2PsI8cOK0LMCmHvrRpeCKoJokXM0OiA4mk2TveKPxv/OfhJk9abA1 TnXorBTXRQVDjtjjDyh2bIK6KYHOYNxCKln5Z/fIO6gSzs8WvWKAO74KWSpAI9tsOxbekdGGSjY u9YhibJjAHKiJRNfeUPIfeEABal9rqv4cx14z1Aml1CvsCpJ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 0Wve09nacPO1tzPZIhC3jD93KcnBs7DL X-Proofpoint-GUID: 0Wve09nacPO1tzPZIhC3jD93KcnBs7DL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEzMDE2MSBTYWx0ZWRfX0Z4HKZkgJTcS +V+Z/0U6OBoYrKSWkFoJHSDWBubc9R4YgQ+ZxT2QvnjzeUOWIkj81Kpyr6AWa4dUzSPQ3q0EAyb CxIe5jFopG+jx8j1bjoBtpdkabWsoarOvyHOVXJSDbNpCx/LNad/shz328Cyc3tUei7frezv/j9 9dyT8nn5FObNpEfcLrTIWuYBGEFw8A2nLpDtERza5G/tJMnZ+VUHOZHnXRvwt16ow0zMAkn3eIY LDkINagFf5nGcy869VO4FZbe60QWYsp0eVUyE/AitO8zLJqAsEHTOAEos68+PBJem26qeQBnedY SHbIKVH0qSNTWWFkMnj0YUu7G8XdpAJyw56d/Yr1Rf+ayfrYh0aoJ+YCnuNU9e2b6mqfwAl1k8L 1YfmKXixJB03/Z377Iuv2QYi9Vriww== X-Authority-Analysis: v=2.4 cv=AJKKJ3lP c=1 sm=1 tr=0 ts=69164255 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=5wgBRnbEGa8ryjaxEzAA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-13_05,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511130161 If the rootfs have a legacy A200 firmware, currently the driver will complain each time the hw is reinited (which can happen a lot). E.g. with GL testsuite the hw is reinited after each test, spamming the console. Make sure that the message is printed only once: when we detect the firmware that doesn't support protection. Fixes: 302295070d3c ("drm/msm/a2xx: support loading legacy (iMX) firmware") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a2xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a2xx_gpu.c index ec38db45d8a366e75acddbacd4810d7b7a80926f..963c0f669ee50d4568b521e2e85= 48e04d606d9ca 100644 --- a/drivers/gpu/drm/msm/adreno/a2xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a2xx_gpu.c @@ -234,7 +234,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu) * word (0x20xxxx for A200, 0x220xxx for A220, 0x225xxx for A225). * Older firmware files, which lack protection support, have 0 instead. */ - if (ptr[1] =3D=3D 0) { + if (ptr[1] =3D=3D 0 && !a2xx_gpu->protection_disabled) { dev_warn(gpu->dev->dev, "Legacy firmware detected, disabling protection support\n"); a2xx_gpu->protection_disabled =3D true; --- base-commit: b179ce312bafcb8c68dc718e015aee79b7939ff0 change-id: 20251113-a200-warn-once-55f47c138cbb Best regards, --=20 With best wishes Dmitry