From nobody Thu Dec 18 20:02:17 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C6924A044 for ; Wed, 12 Nov 2025 19:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977201; cv=none; b=syHEb3Z3cpWD6x6GqU33XpsdJC4Ec+kxWdPWTBhe7UhyIc8VE+Fdfh4naE1wSlCJ2kDZN7A0cU2mqrz1bVsS/w8vfdwxyZQ0D95USQAszeluf6lXuwrOhG/bwo4gKusLP0mnaRx/zFu/gps74xBYrDgvbW4dDAIILs7nb5z8HAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977201; c=relaxed/simple; bh=w4mXTwIUioCEf3aLDXcvRdVOG3IPPERu6LaKLIbBAuQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=YsV/e3FmnXFdDJU5xitKC7/oWwFzVevbfZXK8YYTMzrSqKVmKimsPRLj95LUSwYVSk7bCeZWa3ntHOq/P1Vqa4a00cHn8AOLEBKjMWQpyNiVyN/bo1W1efUNrPTJWT8dKpGt1Y4qCzpy0hv4C4FI0FL2+nQ7EKCJcmOty/g53zY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vzAxCyBP; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vzAxCyBP" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-297dde580c8so242335ad.1 for ; Wed, 12 Nov 2025 11:53:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762977200; x=1763582000; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=LOuSUBzWe69YA4hvkhtZgT3oWHyjTIb2wmtwYv6DBRI=; b=vzAxCyBPzRnyIRaauU/fx86vo4gYt+70bb+iB9XG1wi1zlMKTNbupZ/JciE4LSVL+i p12SgE2IkNlEyOYWKjBoLKg1A662vf359UJ8HGWH5+1szvFuNcThuo4HZ34FJSWgF4CJ YND+pcpzjBiHldyV0gywxg5qV+bcox2eeB4ufIhazzf01r5/+xBC2T1pJobhfaYtEjv8 9vhlaVeZkcGZwWHmgPkscSk5EEa/Sxvvhkr+hxwq7lGutC7JUvUx1Bu1TuVgLLJPPOYU iuih4kzjpYVdExWqW9G/7SQ/0CLlldS5JdnP+OKZx1LnhIeUrp4qxRUuo/R4y9NTFdJM ZSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762977200; x=1763582000; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LOuSUBzWe69YA4hvkhtZgT3oWHyjTIb2wmtwYv6DBRI=; b=gY6IfjYrCntLzYrroUIatKj/NLsN7cpDOJGT2mEiLQrJd655YWN6ynj5n4kTVkyyia XyB/fDkFzzOAV4C4N3PMu/03Xgg0yBTfnmqPKmc3Vs2pD4hCM++kFgzIS3PCKwvDoeCF 5n0Jp38SJP+U6IQWnlTWRuJNJHCT9SQQvlBMT3zUC2o37GNuDLSp06PAymTzpuiA8fEE kNOBQa8JRV2yGsTMCvlYU4O7FEey3oGA7sjgjzBfI6SXA9jIzuptI8JWPLSYGTOdVq1K 8Q6Kkw6n0ry2Ea0QkFLylUo3h8bhGaUwTc+hJ4G02oipGqmixML4zBv8OwCK0aOmGVor A7mg== X-Forwarded-Encrypted: i=1; AJvYcCWAGCr/lpipzU/Ix1AXN/xDoYUq5dQJZ5CwdmDK6UhIVV6jAa+bmUkpHWlFZkIBDP5GmY+OTJQtXryB8kI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb7oEO8zz7swQsrGNUKmA0c3TddZSoNldmwLV9Gi9cMjabf1/l jo29HA4o74nqOWZyEeVH0h+Xmz9rFDGySBqF3KNd68ft6wjJrNeZ8b61a/z8WQyzWuSSNDXEKMP ZxrV4cauckg== X-Google-Smtp-Source: AGHT+IEtfQ4Sqv4rc5xvV8ORzN3/URZ7AozB19pmumlIecktr+wJTuUJm0/zwgHJS4tdicZktfBpuuvUUUKu X-Received: from dlbqd14.prod.google.com ([2002:a05:7023:b0e:b0:119:78ff:fe0e]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:dace:b0:297:d777:a2d4 with SMTP id d9443c01a7336-2984ede0342mr58377285ad.46.1762977199650; Wed, 12 Nov 2025 11:53:19 -0800 (PST) Date: Wed, 12 Nov 2025 11:53:08 -0800 In-Reply-To: <20251112195311.1673981-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251112195311.1673981-1-irogers@google.com> X-Mailer: git-send-email 2.51.2.1041.gc1ab5b90ca-goog Message-ID: <20251112195311.1673981-2-irogers@google.com> Subject: [PATCH v2 1/4] perf test: Be tolerant of missing json metric none value From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" print_metric_only_json and print_metric_end in stat-display.c may create a metric value of "none" which fails validation as isfloat. Add a helper to properly validate metric numeric values. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/lib/perf_json_output_lint.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/lib/perf_json_output_lint.py b/tools/pe= rf/tests/shell/lib/perf_json_output_lint.py index 1369baaa0361..dafbde56cc76 100644 --- a/tools/perf/tests/shell/lib/perf_json_output_lint.py +++ b/tools/perf/tests/shell/lib/perf_json_output_lint.py @@ -43,6 +43,9 @@ def isint(num): def is_counter_value(num): return isfloat(num) or num =3D=3D '' or num =3D=3D '' =20 +def is_metric_value(num): + return isfloat(num) or num =3D=3D 'none' + def check_json_output(expected_items): checks =3D { 'counters': lambda x: isfloat(x), @@ -57,7 +60,7 @@ def check_json_output(expected_items): 'event-runtime': lambda x: isfloat(x), 'interval': lambda x: isfloat(x), 'metric-unit': lambda x: True, - 'metric-value': lambda x: isfloat(x), + 'metric-value': lambda x: is_metric_value(x), 'metric-threshold': lambda x: x in ['unknown', 'good', 'less good', = 'nearly bad', 'bad'], 'metricgroup': lambda x: True, 'node': lambda x: True, --=20 2.51.2.1041.gc1ab5b90ca-goog From nobody Thu Dec 18 20:02:17 2025 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071562C21E2 for ; Wed, 12 Nov 2025 19:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977203; cv=none; b=NOAWZylHE3fMARMvToVS8K5phU5tlCHFZBknc1+NkpWBUTCHV8zjQ66uWA32D90slmMbjN/9GLoj89XqH5rI6Y+jc+aTYVJmOYGQdgBeKqBUzanpxfRY7MCaHxLIrbuewsKNduIP2JMgdVfQFMqB5/v9hX4nMWlBe4nC5RvGT0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977203; c=relaxed/simple; bh=yYYSEm1+78KFE95YmQCyenLnSRE/5b8iEhqKQfSJY+c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=HVGdzC2ebeHPbjfydkWcd1K24892nic0Sg+3zj+3thrnc50mgKDZvq2SOADQgAJBl8cIwmIdpJVcC8NJ27g2u7vBQdzIqjxBOQpLJilb/dKaEbxkbs4aqTzdlKqRwwFlxn/YsXOjUD6xnqptjWLJBNJuXoUBp+aTM3dky8eK3LI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Cyq1n7q4; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Cyq1n7q4" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-295595cd102so83195ad.3 for ; Wed, 12 Nov 2025 11:53:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762977201; x=1763582001; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=aWhwDpn/WcIzrlLSKPaqF4IGWaujqE9kQM3MysbpHr8=; b=Cyq1n7q4v7HbBx38n63bzi+esySXHpGg1yJAu4gbI2SzcjQYlBf3VLkvD8PjGKt8K/ aPMsUYkEWAyNCH9jquw8N17A75VFhgv4xHC0qwmE0+XnO0NhW8X8Pjg6pqgqlfVObir5 Jo2bTfMQ9Pjyx6f7Ab/eZps36+H/Y3CrMtoribkH25Rap2lAl8IIrY1TE1i6RSHjStDj UPcyG45IViUWo9uAyNIUr1ZUYriy1ZXbCEUdhuXjHiPCsAmZil9pY6xaWSz3uX4RxiMQ h9GXCUm5vWOd+fnf47cL4sTfKGB5AFSOT9aKYB3an4FsR7sfd1C0qau52hCByEnkbVTs pVKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762977201; x=1763582001; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aWhwDpn/WcIzrlLSKPaqF4IGWaujqE9kQM3MysbpHr8=; b=G+QyHkFXrZ0fPjFEWZ/FS5T/Sjjh/Epel77MNPpu2wFwUXRaYiNA8WkgR2e0753rKT mHX1pF6HmmcMTK9J9SJxRpN9cGd5Qub/2wAH3xVhUST4yxPBOv0wFXfBmZHXGLYhqz7Y ASueJxzOb68MqFfcfnD7qyu6y6UBHMe9AemTGTxpdIPMZujjoGfD3bdnZd02h2Pusb9U 50c+oB6CHmezGq3Yvtjayw/YUY0tGeZ2hZRgXhodz4XheIhoJi+wh7P6U9TesO79OCs5 X67rJycwAEmjzRbK//O8a9uMRw3kRK2wndJVnCJQ2hPlAORfEsfOIZPbf2Fm7f9kV4aP ql5w== X-Forwarded-Encrypted: i=1; AJvYcCW1e2ZDFEgwhBbMz3hHhkZoZ67plRVk4fQDXdkysGkFXKOkAYhohCrcULPBNRd+qFifFtzwow2l2ACmwiI=@vger.kernel.org X-Gm-Message-State: AOJu0YxqypuapwXUi9JV2or6d4c39N4JZJOafm9weJI7D8MlG38y7Qyw aDe9jh/17gvN9dtKDJSKj/fQvstY+BdHqrCy789jv6B50hpw5OgcrxnTVLVDoOphcZVfsCbrk14 +3BkhinLHjA== X-Google-Smtp-Source: AGHT+IGr8jqCt/mQgH8SPenACb3EoRr0g3D/bK0976Lf844ug4u46eKIIXxBLg83l6XVCi7QbfIWMrTnn91V X-Received: from dlf13.prod.google.com ([2002:a05:7022:40d:b0:119:49ca:6b85]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e94c:b0:296:5e6b:e1c8 with SMTP id d9443c01a7336-2984ed92467mr56093505ad.13.1762977201529; Wed, 12 Nov 2025 11:53:21 -0800 (PST) Date: Wed, 12 Nov 2025 11:53:09 -0800 In-Reply-To: <20251112195311.1673981-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251112195311.1673981-1-irogers@google.com> X-Mailer: git-send-email 2.51.2.1041.gc1ab5b90ca-goog Message-ID: <20251112195311.1673981-3-irogers@google.com> Subject: [PATCH v2 2/4] perf parse-events: Add debug logging to perf_event From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If verbose is enabled and parse_event is called, typically by tests, log failures. Signed-off-by: Ian Rogers --- tools/perf/util/parse-events.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 0c0dc20b1c13..e522082c5a21 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -2236,6 +2236,8 @@ int parse_event(struct evlist *evlist, const char *st= r) =20 parse_events_error__init(&err); ret =3D parse_events(evlist, str, &err); + if (ret && verbose > 0) + parse_events_error__print(&err, str); parse_events_error__exit(&err); return ret; } --=20 2.51.2.1041.gc1ab5b90ca-goog From nobody Thu Dec 18 20:02:17 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E362D23B6 for ; Wed, 12 Nov 2025 19:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977205; cv=none; b=Wa/a0fqGCKWBP2k0rSlvrPaUINqo7TSCJn45SEpkY2ij8YNo38MopTpiAIqndGsawcDkiG+SajWUovuM4j9aInU1qUn8L9GbBOao1LdURTX7/9NVPJTAJDCmHnt3FSOVDpa9NI5j+VH3B82ezLPCiyjpsoY4hiPkTUGvZ1RZGT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977205; c=relaxed/simple; bh=D2qFWI5rI9XWj2yv5NMBGr9wzwRjSjUkpoKM6NrqaBo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=dFKCpNvCx9p27gpt4USoefZYokRfWcq3c6eL6Dgg9j5FReTcFHqzh8oPEpRBMnv/ZauLC1ORyRtRPIWjzMXJ40fb0h23xC8Cq5kFLHuq/feYUJy9uzLh6espv685v35c41k6NmeY2f1PDfyu/wLs8MMI4h8Jh3LrOJmy4CmLa2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n2MBwKOQ; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n2MBwKOQ" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-295fbc7d4abso112595ad.1 for ; Wed, 12 Nov 2025 11:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762977203; x=1763582003; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=ohw+LfkBQ7p0CYFFLUG3dUA11yOfDumKvPxiRgcLzqs=; b=n2MBwKOQuRfoga8yfU4j1nrMsf7BEnEaMuC5McPjHK+qdCosenEHhUXH2FHN0znjEo 0scfCvoBl0cvTVR2ZoU0LqB3WxtgWKrVa4eo5qWeRQ0mFWquiGkC6XejJ7d4nNlTzUgN M3fL7t+nY94hxKgMQ72C50lFO7OGrxLTtB1Gi3X8EZI+EjUwgbLFLaqKLnGyN6nGDI/v HC9/8dBk1M33wH4IJKfN4QQ8IIVEy1MSkjwDkF12CIwnqKAbyNJkYCfPmjrNBZLRAT+E o77CeSoy5TvOIK1J+UYw1ZFbtmxak4gK4tMVP3CQyMh9x7ASuzQwjwNtnFXqrczdGxym GHiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762977203; x=1763582003; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ohw+LfkBQ7p0CYFFLUG3dUA11yOfDumKvPxiRgcLzqs=; b=pwypfo63PMQ/BcO18gAkez5zIjYy8YHUaaz43kMdviM/8jkxNNUSXCcTeQjacAc+JE ACYSzEGknw3xS7c1wSNxG9sOZydl9OUS1DPktwFY6Xm4cJUf7F3A5U+iH7hmy4WB/R2v 38mzv2KZdgSh0FFI040KC4D2tJpiZXq9cn4gZHBUVZeh2Cco7j8L2lRcIcIyjw3Sz7ck 1QubxF9hGhu9HfLa+pfpEh2glndTH/gUN2dOq2nIqM6btu3cAmJxTHVtFGFlKeAdRacD DKymKPGcSutT+RWbIQauS7pVHec7kW5EYqWvPUwl0nxuNvbGQDoqZCUFM8u8SeQvBP8o 2QoQ== X-Forwarded-Encrypted: i=1; AJvYcCVMMRuOzCGpHmMq+I0IUX9LzKlflah95gnBOLDdFBVA6IX29sTr8cAv4q02/bGcFmKF+11rJKn29iXlwi4=@vger.kernel.org X-Gm-Message-State: AOJu0YyWbQITwsOKvj9jBOhLYZmv6vukVvVlCmydPjtheXeH/7BHVLTl dhQCRY7TTvSv03kDTazt0TRIQRs8xHQ+Nhy0HIms27voW2ds7r8eALv7FBtQ4FicjXpJMWXhZQ9 Gu1acSadW4Q== X-Google-Smtp-Source: AGHT+IHsLG9tsjG12ghzU+324EEnValmEaNnP/kKoA2IYFkuZTbb8uoThhf/fUIjBEdNGu9yPxQmWhM83Gun X-Received: from dyoy40.prod.google.com ([2002:a05:7300:3728:b0:2a4:7751:c312]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f68a:b0:298:33c9:eda2 with SMTP id d9443c01a7336-2984edaaee2mr50098365ad.33.1762977203460; Wed, 12 Nov 2025 11:53:23 -0800 (PST) Date: Wed, 12 Nov 2025 11:53:10 -0800 In-Reply-To: <20251112195311.1673981-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251112195311.1673981-1-irogers@google.com> X-Mailer: git-send-email 2.51.2.1041.gc1ab5b90ca-goog Message-ID: <20251112195311.1673981-4-irogers@google.com> Subject: [PATCH v2 3/4] perf test: Don't fail if user rdpmc returns 0 when disabled From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In certain hypervisor set ups the value 0 may be returned but this is only erroneous if the user rdpmc isn't disabled. Signed-off-by: Ian Rogers --- tools/perf/tests/mmap-basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c index 3c89d3001887..3313c236104e 100644 --- a/tools/perf/tests/mmap-basic.c +++ b/tools/perf/tests/mmap-basic.c @@ -322,7 +322,7 @@ static int test_stat_user_read(u64 event, enum user_rea= d_state enabled) } =20 perf_evsel__read(evsel, 0, 0, &counts); - if (counts.val =3D=3D 0) { + if (rdpmc_supported && counts.val =3D=3D 0) { pr_err("User space counter reading for PMU %s [Failed read]\n", pmu->na= me); ret =3D TEST_FAIL; goto cleanup; --=20 2.51.2.1041.gc1ab5b90ca-goog From nobody Thu Dec 18 20:02:17 2025 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285402D6E74 for ; Wed, 12 Nov 2025 19:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977207; cv=none; b=e0VUSYbu2pUfbYTtU0WqHGo/Gm6VSvSgPy5fTytJs8REd7vop3tGKBz+BTXdMAwEf+VC4DUwGSHb7oRGXQq4G4dqLluBDoiYQ50TaViujG5DumNALLDejaf196OTpYBk/cGwHOPuiidA2CUqg1pmM9wjhnHiAaa+7oXEPS1BJb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762977207; c=relaxed/simple; bh=V0KWJkkWP57M69eZSbl6MF20thMIqRQTy5N0N9OK3YU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=IKuT+LEfZCOaP0cKQQlnJMUayzjRaO6hCJRhtC2oOroNUekFvaKpjsfryhyMEhSANGjy/0TVaYr1nzLlZKrWoNJ94M+MKtCkXlkKQYx0rYGSsPIC4fzik1vK/Wqq9lDztDQUQGTBIOxr4Ojrut1np8dKAB+OqkNeIe8bX0Ik6wM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=G3dzzOCN; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G3dzzOCN" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b99763210e5so18989a12.3 for ; Wed, 12 Nov 2025 11:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762977205; x=1763582005; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Sf0aJeaxTeWu5QV0R458NriwUUamTc+0q0vKrwxanVw=; b=G3dzzOCNfVSjLAjaxHPQDMaIenDAXbSoiKsuT1BIA+LstY1Hmgv4eoO3/WmiLUZCXC MBYDCRVPJV7q1UIIh8UqIlXYXJ5dY0nGe3KYBkAQIfbagXSAVVLEBAidNPXibvPtgnuf iTULhyf4LK4IitNqxs+GHxX6KgASyNAf94/JRuTPUXoZCVK0ePJy5NDlhmbqgknXrbXc jhXwKQZ27E/vXISP/GltMo6hMpEmj6xUX0M51KvmC4SlHGqwV9PPi1XlrOYE0oCag/9L TgBQ7Opuw43wq7a6EnQJkR/GdzvPc62eVZ3IehcgKmpSn38EnEMuB4kjF/WwKA5K7Qc5 cZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762977205; x=1763582005; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sf0aJeaxTeWu5QV0R458NriwUUamTc+0q0vKrwxanVw=; b=DHYhsoqmELcKCqSvQqfFzRP8NNNZMXR1kUHAmzoUdgoE1OLLfwzlY6hq45CqiuK089 YH7a2BvnlsiEHYcBz/KPtVNP2zdrwn8zNsdnhkTB7OPE0U7wA2317qP6biwYAlD1IR/D DY+vjIdLV/yDKqU7vPJah1TG/G1Kxj2hrWYH2xQi8l0zkb32jEiBV2z5+yvzX+RwbsyD JPaXRCXLGISE5v9Cn2Yt+4QKA4a8r0Ceg6v2Js6WsY1nZptvpaBKfNkIsWfXflSLGVgL E9HXPsknUiQfUG/0rdLPQjRiYkYZ6f/dgdp5SyPrAhZ+ipMliT/DOsyUFcH0BUvCQvwJ SCvg== X-Forwarded-Encrypted: i=1; AJvYcCXFgUTJnCQv++QbtlqKmgYlh2+Imc/i/LGP3LGLUMVNcBiyck9Tk9frj71aTBhIM0hMJh/OZBQUTZYrjr8=@vger.kernel.org X-Gm-Message-State: AOJu0YxSuTgiWtAon50CCP8I/xNDEWJQIz/zbDjLblGSaQ5anA3Ntp08 Ucg43vjLIdWRTbwOtzVWmLWBzo/4ncTBccp8dl3ngxhxb683OHHL9lcg3M0HteYyarpFVqWbS6T U8ljlGkj42Q== X-Google-Smtp-Source: AGHT+IEawx7w00JKKScje92At3LUybXF4Jn0RR4rsvxGaZj5ql5/vEbJL4i+EbvSQME0ybNylUkue5E5gq8k X-Received: from dyx20.prod.google.com ([2002:a05:693c:8214:b0:2a4:6312:d053]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:22c8:b0:295:59ef:809e with SMTP id d9443c01a7336-2984ed41fd6mr48593805ad.24.1762977205409; Wed, 12 Nov 2025 11:53:25 -0800 (PST) Date: Wed, 12 Nov 2025 11:53:11 -0800 In-Reply-To: <20251112195311.1673981-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251112195311.1673981-1-irogers@google.com> X-Mailer: git-send-email 2.51.2.1041.gc1ab5b90ca-goog Message-ID: <20251112195311.1673981-5-irogers@google.com> Subject: [PATCH v2 4/4] perf stat: Display metric-only for 0 counters From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Chun-Tse Shao , Thomas Falcon , Yang Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 0 counters may occur in hypervisor settings but metric-only output is always expected. This resolves an issue in the "perf stat STD output linter" test. Signed-off-by: Ian Rogers --- tools/perf/util/stat-display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 5ac9854f8c58..6d02f84c5691 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -913,6 +913,9 @@ static bool should_skip_zero_counter(struct perf_stat_c= onfig *config, if (verbose =3D=3D 0 && counter->skippable && !counter->supported) return true; =20 + /* Metric only counts won't be displayed but the metric wants to be compu= ted. */ + if (config->metric_only) + return false; /* * Skip value 0 when enabling --per-thread globally, * otherwise it will have too many 0 output. --=20 2.51.2.1041.gc1ab5b90ca-goog