From nobody Mon Feb 9 22:19:06 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011055.outbound.protection.outlook.com [52.101.52.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4321426E717 for ; Wed, 12 Nov 2025 07:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762932632; cv=fail; b=A4lF0KSQB+VxH1CHISbHKvaX1hvMeIzf24KVBvd6w8SVgFz3DJkMKfVHQcC/ebHXhCb555QErPfnxKvhu1osj2Kb/BAE7aaEoCYz8UJRZVKEmG6KkWUn2CWZUuvjyY19ClPjLJloZLnQxQWIq9Q3hrP/+aYgBl3MWzTmZhuU4P8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762932632; c=relaxed/simple; bh=44xv6nrYK1VS1tUCQdQl3zXzSMVEe1B/xowZOtKCg6s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jtGJ6mJrqtUWQyd2t3Qh0FUTZ3HYrBdnfVqcnji+EPtL4xajlvALylgGWsJPtyNc3cj1evyhcTdYWFoCIXTUo4TA4ZykfNJycZRDcCK0I6S68AA6/I7Tq6Hs9yDJJpaQJmMkkf50dwkWLY8WXT6SoybCn64dYNtAQmLof2ROftM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=avoEzBdC; arc=fail smtp.client-ip=52.101.52.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="avoEzBdC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q5QPHN6LXZHw9oVg08IkKNGj/Q+xpNDa5M2KXk6tg4RDy7Pq28Cb6Wh2+KOsGqWTyLASAN2M2ZC57adDMd1NCZahBwtbOn0Ifu+M2TVDsrvDNkhYk1H+KzgotOzeLHkjMJ08mD4kF6jw2Q8xYE6lLkq9L/XryDXyXUZHc3grfgh7+xkgE8LsIOVijjAa/PTzSuvtEwhXNLA13VEjhBwBFztDhUiWyR0+9qQddrlKnllQfDFakbybOcGyAR3Syni83zEiwUTXDmEN6XA3Tuzi3TpOjVGAOx06YW/swV00Rts2DGqSAud6rO1tDUMTrkj69SOvCP/bq4Qn5FZ3jTRm2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WQQMX/nlAJhaBEBziG2NLFNNdRLNtD2k+Os9agqVAPc=; b=o2Iqb+0ykmhrsuMZ24MJDYMBOXnSJPxej4ULGM8HNgNDPGPmuZ0eOcPi/IBXCvn56qRebZCkW9x6e2KrKsw5CvDLZxmxpBDS//frpH5m4tS6JCu2nN8n2hTbdZE8pkpIIjrkjya9qxXZS0Xq6DMsd5IErmc4JA9B3V5qrBVwTmxNW7f1cgftdRfPeoTWwODmsvDLwOt/p8xpT4of+6o8wGNdZjbk2U/7sCT+dmQ/Ok2Em4nwNkmkhf7RB337wojzStt0lKOkYEXqiTRHuKFWKp7AlGcE2OeE4FAmdllb/OX1sWxGA2yZyFq7N6s6VDq5S1kvyLO+NCpTRyL4pzJRzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=collabora.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQQMX/nlAJhaBEBziG2NLFNNdRLNtD2k+Os9agqVAPc=; b=avoEzBdCOmgqr477M5oAAKeCtp8EWQPZcSQsf7dohay4F7nTsUaNLRi+18IkW8zhjbQ9FOcCCqtClWTBXdDoM0SiU2Xmqwe5uwnaaXWpSa2tnXrQcHbjrcdL1VDucuLmJEJc7nTYFD76F6zlBzv4+PGu9Xb1szdGULKUK+Plh4g= Received: from CH5P220CA0009.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:1ef::11) by SJ2PR12MB9088.namprd12.prod.outlook.com (2603:10b6:a03:565::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Wed, 12 Nov 2025 07:30:27 +0000 Received: from CH2PEPF0000013C.namprd02.prod.outlook.com (2603:10b6:610:1ef:cafe::2) by CH5P220CA0009.outlook.office365.com (2603:10b6:610:1ef::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.17 via Frontend Transport; Wed, 12 Nov 2025 07:30:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH2PEPF0000013C.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Wed, 12 Nov 2025 07:30:26 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 11 Nov 2025 23:30:08 -0800 From: Honglei Huang To: , , , CC: , , , , , , , , , , Honglei Huang Subject: [PATCH 5/5] drm/amdkfd: Wire up SVM ranges ioctl handler Date: Wed, 12 Nov 2025 15:29:10 +0800 Message-ID: <20251112072910.3716944-6-honglei1.huang@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251112072910.3716944-1-honglei1.huang@amd.com> References: <20251112072910.3716944-1-honglei1.huang@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013C:EE_|SJ2PR12MB9088:EE_ X-MS-Office365-Filtering-Correlation-Id: a613e7ff-c707-4875-d7ca-08de21bd596f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4gjWFkOZo3vQOUY2/EIfBEq5s6HBpOoiRqoqKteCe7vd4MgY38qBtYeCdBhG?= =?us-ascii?Q?SaoQcmg3FIkqMPCnzj66srwLCMfaQ3THUDZSepLyg79m/hRW1SaKefK4/Y/O?= =?us-ascii?Q?Fvyzvp5RsOtQmZ652O0M2AXSyrhkSpH55MWYi0Jp5ralVrkEJHBs3g4yZsq7?= =?us-ascii?Q?IcFTrMUEO3ROd9L8HUgAtD0K/qtcGmD7XK3IQnLAfTQBN7hDIw8Z6jS1l4DN?= =?us-ascii?Q?mdkQAWKv9sRNlQeyVFM4GRuvvyqBMnfqIIgKq3TU8ZGHuwGzCCKriQhNAuxP?= =?us-ascii?Q?zTsE0SIh0FNhQC5tX9FxGymfgin93iCoOBETSAcf9x97UJpuRkLYEj6G1tpw?= =?us-ascii?Q?finBWlaRpC+4DjX80WDNZf5RJKNEAu2Yo9X2FEgzIXXdn5ZIfNAOUKctE/bz?= =?us-ascii?Q?1OanDaeFTc2j2EyjpnZuezD+6NyLe6UgpjPWZNwiDxnXC0MAertKvglbNN1S?= =?us-ascii?Q?me1hamOtH7w0yfhGpuhuZm+BeJd4VsuUnllFMw8i3FyU0t1Y+Ax95gKUD+4U?= =?us-ascii?Q?eTD2g3haC44dqAmg/uFHxSUdjHH21Kgptc3vC60AEFXpZQyBS1U7nTnkRPgO?= =?us-ascii?Q?33rrYHzYotiaAtg6otCyhd6aqTp/M1DgwHbCTuinYbjLriTPLgoZLHZSWJBF?= =?us-ascii?Q?rVKCWTD+jC28R+H5HefC19gY5JNHNbxgfRsEjafLrKgRUqayY2/xjcoCB/xX?= =?us-ascii?Q?itf8mgspy+N+2LugRDShMRF6I4OrNDfmpgysnlPOO8V+r0QbIoHwKRzFeeps?= =?us-ascii?Q?QTy2F09we5EtcgT4bsevU3Nikh5/QLjGRHz8xLDmJQblwm6PLuLdllTRdvIP?= =?us-ascii?Q?XdoUSWw2N2n4VJJOBxRlbEMCKRvSVIUgxPB4iGWezXZs3c51UPYBqcwTcQuB?= =?us-ascii?Q?Ek79moQDvPBZqbrvqgDX1RwxHXm3b9jlOS69gQwSgCaAnd87wzHHbICzKlWt?= =?us-ascii?Q?KQ+HxDOvhkz4ATrbSBs5kO1HmIZ2MGY8oTnyYqgizynRQXHkITXN6sR9lkm7?= =?us-ascii?Q?E+u3yxbwHwSONNKUuWUttQzYPr5oOF2kA2h2LiulJxvEKT1WUpgqdA4JrP5d?= =?us-ascii?Q?BmM5ZBUHccPDPqxosXJzJTV8UN+4zBrXBityRGdSm7qlmVl6oVTriILYQaJM?= =?us-ascii?Q?NR9RvUAQDqG4RXOPsIWrJ+HsATTO4AnS0HCE3naC0EGV34lZvYce5Xcbab4F?= =?us-ascii?Q?LgQy9SmVB/1WZD99zH0h6ypjR9f/ASV7sS4anTvVLrdWlmZKqrIKpPxDFL/z?= =?us-ascii?Q?S1QNyUz5i4IV4/WE84hlOgtQa+JCCDi8WE+HcI5hHUsiq5kZCVormThlC8nl?= =?us-ascii?Q?L7ThjQ3dkxKbTWiLag/YImGHZzFg6kLG+S2M1CgpER5J3bfBXz8rSNpyrqpz?= =?us-ascii?Q?54T4SoGbSjAEyp5fGsV/a22V7Vqz9jEj0WclsBlocHHdq6MQTlENxSYDF81G?= =?us-ascii?Q?zo7kHQY7fhSOpdTHS+YfIJ3FLgM/Ab8huCyGTjkyWON2bU7Mep4dtBkhP9Yb?= =?us-ascii?Q?eP/0ElRnahwOU4P2ZXL9LVEownn2fPnKVcZHtVYH7O+1F//S7r7+xWZzS13+?= =?us-ascii?Q?H5zbPl4K3dnwYOc59eM=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2025 07:30:26.5691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a613e7ff-c707-4875-d7ca-08de21bd596f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9088 Content-Type: text/plain; charset="utf-8" From: Honglei Huang Implement the kfd_ioctl_svm_ranges() handler that integrates the SVM ranges functionality: 1. kfd_ioctl_svm_ranges() implementation: - Validate input parameters (ranges, attributes, addresses) - Copy range descriptors and attributes from userspace - Call svm_pin_user_ranges() to pin the specified memory ranges - Construct kfd_ioctl_svm_args and invoke existing kfd_ioctl_svm() - Properly handle memory allocation and cleanup on error paths 2. Extend attribute handling: - svm_range_check_attr(): Accept KFD_IOCTL_SVM_ATTR_MAPPED attribute - svm_range_apply_attrs(): Set prange->is_map when MAPPED attr present - svm_range_is_same_attrs(): Force update when MAPPED attribute used - svm_range_has_mapped_attr(): Helper to detect MAPPED in attr list 3. Register ioctl in amdkfd_ioctls table: - Add AMDKFD_IOC_SVM_RANGES entry with kfd_ioctl_svm_ranges handler - No special flags required (use default permissions) This completes the implementation of batch SVM range registration, allowing userspace to efficiently register multiple non-contiguous memory buffers with a single ioctl call. The implementation reuses existing SVM infrastructure while adding the ability to handle pre-pinned memory pages, reducing overhead for applications that need to register many scattered allocations. Signed-off-by: Honglei Huang --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 67 ++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd= /amdkfd/kfd_chardev.c index fdf171ad4a3c..7e7e00d3f873 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -1739,6 +1739,70 @@ static int kfd_ioctl_svm(struct file *filep, struct = kfd_process *p, void *data) =20 return r; } + +static int kfd_ioctl_svm_ranges(struct file *filep, struct kfd_process *p, + void *data) +{ + struct kfd_ioctl_svm_ranges_args *args =3D data; + struct kfd_ioctl_svm_args *svm_args; + int r =3D 0, err; + struct kfd_ioctl_svm_range *ranges; + size_t sattr; + + if (!args->nranges || !args->ranges_ptr) + return -EINVAL; + if (!args->start_addr || !args->size) + return -EINVAL; + + pr_debug("start 0x%llx size 0x%llx op 0x%x nattr 0x%x nranges 0x%x\n", + args->start_addr, args->size, args->op, args->nattr, args->nranges); + + if (args->nranges && args->ranges_ptr) { + ranges =3D kvmalloc_array(args->nranges, sizeof(*ranges), + GFP_KERNEL); + if (!ranges) + return -ENOMEM; + + err =3D copy_from_user(ranges, (void __user *)args->ranges_ptr, + args->nranges * sizeof(*ranges)); + if (err !=3D 0) { + kvfree(ranges); + return -EFAULT; + } + + r =3D svm_pin_user_ranges(p, args->start_addr, args->size, ranges, + args->nranges); + + kvfree(ranges); + + if (r) + return r; + } + + sattr =3D args->nattr * sizeof(struct kfd_ioctl_svm_attribute); + + svm_args =3D kvmalloc(sizeof(*svm_args) + sattr, GFP_KERNEL); + if (!svm_args) + return -ENOMEM; + + svm_args->start_addr =3D args->start_addr; + svm_args->size =3D args->size; + svm_args->nattr =3D args->nattr; + svm_args->op =3D args->op; + + err =3D copy_from_user(&svm_args->attrs[0], (void __user *)args->attrs_pt= r, + sattr); + if (err !=3D 0) { + kvfree(svm_args); + return -EFAULT; + } + + r =3D kfd_ioctl_svm(filep, p, svm_args); + + kvfree(svm_args); + return r; +} + #else static int kfd_ioctl_set_xnack_mode(struct file *filep, struct kfd_process *p, void *data) @@ -3226,6 +3290,9 @@ static const struct amdkfd_ioctl_desc amdkfd_ioctls[]= =3D { =20 AMDKFD_IOCTL_DEF(AMDKFD_IOC_DBG_TRAP, kfd_ioctl_set_debug_trap, 0), + + AMDKFD_IOCTL_DEF(AMDKFD_IOC_SVM_RANGES,=20 + kfd_ioctl_svm_ranges, 0), }; =20 #define AMDKFD_CORE_IOCTL_COUNT ARRAY_SIZE(amdkfd_ioctls) --=20 2.34.1