From nobody Sun Feb 8 09:10:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27A62C11F5; Tue, 11 Nov 2025 18:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762886669; cv=none; b=BLp6HeP+4pSW2zAqrBkpgtybOIq7PgMT9PO15meidUc/HMzpE8iehAYWDMpAUN3F+hMfcKJTLimhXC0awepA7LVRfdPWvO64OSH1czGlCgZBcMcIRkFrDmLEyhWXdSuBwpk1R9Mwf/8FmCAlQqYXyfGxQL6jS92OTB6LesdhXQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762886669; c=relaxed/simple; bh=+8bf6ecH2QvmrcQl2a7rJm2jNUhjf8tGWK0R12xiYjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZqVLs1Q5pdbn0sDGW/aqhd+XDzWKRzUqiWU/moFcPpt0aLEKvR++zuB8NFyUxbt2o+86kWEhPXd18mg4zbYQA1Ia84F0YEHOEXg19eEQGKXGwicrUigapD3jtZeH4gTcInQ8UYvGoYtqZYXFXI5Sp2EYPy3O7g15qHR3w9ZJJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pTdymFss; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pTdymFss" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03EA8C4CEFB; Tue, 11 Nov 2025 18:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762886669; bh=+8bf6ecH2QvmrcQl2a7rJm2jNUhjf8tGWK0R12xiYjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pTdymFssBjyFKZQvY9G5+u54zM6i/+Y4DTZAt0CIeOQDITh6nLowUfB2sTsgOz3uB pgc2KrrqQHpnatga8xi7CQ5mlgLiVf3IfzofdVbdNeGDtBolgZ6QfixzluMbHTyDUa eyCkNpGQKJM4hZx1bvGAxutK20scr0IQuyY9Ef03FAgYpKn8XsVFcyn0ZKL9/qMIOm ZtcNNlgg9YAMgyymYON55BB6n7QIpZ/krFt+5dx4ZD49Z8WE5GPuO1q+XtFptUMrsH mslTc6T6m5UPLhWDP+Agna40O5ACC3ecBjRMY3r/Hy81pTaaYgrjxhveaA7yi4QLnN VIQt0RDIb5BVw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Brendan Higgins , David Gow , damon@lists.linux.dev, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 08/11] mm/damon/core: pass migrate_dests to damos_commit_dests() Date: Tue, 11 Nov 2025 10:44:07 -0800 Message-ID: <20251111184415.141757-9-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251111184415.141757-1-sj@kernel.org> References: <20251111184415.141757-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" damos_commit_dests() receives 'struct damos' pointers, while it uses only their ->migrate_dests fields. This makes code unnecessarily difficult to read. It also makes unit tests writing complicated. Refactor the function to receive pointers to the ->migrate_dests fields. Signed-off-by: SeongJae Park --- mm/damon/core.c | 38 +++++++++++++++++--------------------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 06ad359024ad..a14cc73c2cab 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1000,36 +1000,32 @@ static void damos_set_filters_default_reject(struct= damos *s) damos_filters_default_reject(&s->ops_filters); } =20 -static int damos_commit_dests(struct damos *dst, struct damos *src) +static int damos_commit_dests(struct damos_migrate_dests *dst, + struct damos_migrate_dests *src) { - struct damos_migrate_dests *dst_dests, *src_dests; + if (dst->nr_dests !=3D src->nr_dests) { + kfree(dst->node_id_arr); + kfree(dst->weight_arr); =20 - dst_dests =3D &dst->migrate_dests; - src_dests =3D &src->migrate_dests; - - if (dst_dests->nr_dests !=3D src_dests->nr_dests) { - kfree(dst_dests->node_id_arr); - kfree(dst_dests->weight_arr); - - dst_dests->node_id_arr =3D kmalloc_array(src_dests->nr_dests, - sizeof(*dst_dests->node_id_arr), GFP_KERNEL); - if (!dst_dests->node_id_arr) { - dst_dests->weight_arr =3D NULL; + dst->node_id_arr =3D kmalloc_array(src->nr_dests, + sizeof(*dst->node_id_arr), GFP_KERNEL); + if (!dst->node_id_arr) { + dst->weight_arr =3D NULL; return -ENOMEM; } =20 - dst_dests->weight_arr =3D kmalloc_array(src_dests->nr_dests, - sizeof(*dst_dests->weight_arr), GFP_KERNEL); - if (!dst_dests->weight_arr) { + dst->weight_arr =3D kmalloc_array(src->nr_dests, + sizeof(*dst->weight_arr), GFP_KERNEL); + if (!dst->weight_arr) { /* ->node_id_arr will be freed by scheme destruction */ return -ENOMEM; } } =20 - dst_dests->nr_dests =3D src_dests->nr_dests; - for (int i =3D 0; i < src_dests->nr_dests; i++) { - dst_dests->node_id_arr[i] =3D src_dests->node_id_arr[i]; - dst_dests->weight_arr[i] =3D src_dests->weight_arr[i]; + dst->nr_dests =3D src->nr_dests; + for (int i =3D 0; i < src->nr_dests; i++) { + dst->node_id_arr[i] =3D src->node_id_arr[i]; + dst->weight_arr[i] =3D src->weight_arr[i]; } =20 return 0; @@ -1076,7 +1072,7 @@ static int damos_commit(struct damos *dst, struct dam= os *src) dst->wmarks =3D src->wmarks; dst->target_nid =3D src->target_nid; =20 - err =3D damos_commit_dests(dst, src); + err =3D damos_commit_dests(&dst->migrate_dests, &src->migrate_dests); if (err) return err; =20 --=20 2.47.3