From nobody Mon Feb 9 02:24:23 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011025.outbound.protection.outlook.com [40.107.130.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C0B52DA757; Tue, 11 Nov 2025 01:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825298; cv=fail; b=E+A3IuUV2rF4aRrOEyKnBCuq1F7NpGlrwjLtTJoEjKJ9Ago0e2MDiz6IrMrFYximAjWMxoLUzhJe2GTbBmvk6kpljKb7afOQBlfs9CDx6eSg7OcggJur5E8vFgndFiQhzbafWvGJ1VPKJkYHCk5jBcR5iqlW3MsAIGtmyvwru7I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825298; c=relaxed/simple; bh=ij8t3n2nd8wDFjGcZXm532mzD4yk8mdglUqVtDdNe04=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=QmrMeLJPXs/WVKhkDC6CFPK4zlDxeNKSAsOAEopN6H+j3eAbiKl+2X17Heg7O04yLJ041DnwckPPF740HC2m+LzoxhiJdjkqyqtf16C0MjuT/MKRWzwfUan5ZJgsJM8GoEfCf7cpRhKzexpe6QpbXlDa0izONnRg6tFKUU9spHs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=d9YQDVEq; arc=fail smtp.client-ip=40.107.130.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="d9YQDVEq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dOgSv4IBPl7YqNhmf41hBOM+I3ay4y5yv6WN952CAyQJuz9xfms2LIFE30Rbbxj967e5JH9DaAexougjqxOp6SmSpYfsflZS/myZXmTpP84ED9bTJXf/2hqtlLxl/klI2j+DNMatgYIKGHTtjcG1OX/32ql5nw3v0QYEand4UYtILlWr2X68q9DknMIqaoWBnj7TY/MEZ+kVU305XYPr9nmO9OAIso0KrjV5E1UbrxnFzCA8TAZTXlPllATXtzj6jOSHGetxtpt8l7gC3GeOaApZoThcLjG7RfZBRQSryZqf4ovOHteF/L/5g7fohqyL8nNehxUUjOYJ+8nNr3APBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IyROMaN5c4nGf/mOynrdcZm8n83SzYFZ0UWSxxp3pvc=; b=vtU0OOZeg3/pXkhMnwlMeGGuqJchUlfPQ1r/zVA//qge3E/hRtFAG/Hee6aB7Abo8USBtAguThSG/4xCP2jUzh5Cdh931uwZ8JWZFS314J2tPFGBjSlXH02cGiugWtXvkLTcXPpNClbyOlHdvnHwO57/qy0OziDQudoskNRUd79kZLosMCXYP8r7vf0zKTEB+mu7zIcdWSjG1uy4LKxa3sZZCJg3zpdV/s5qJO64oY5EW9PTFeb6siFyjnzkLfEvJRq84ajCaUtP3oktltZtAQbMOYujka05BILsKDXDh0CoVbKzdl1dHHD+PPmz5PQRKMJsRl9Efkvdhj8JTFNvdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyROMaN5c4nGf/mOynrdcZm8n83SzYFZ0UWSxxp3pvc=; b=d9YQDVEq9HRWZzlT9JVbAsh6/odhWWB4dXkti+kjSG9gLYC6UVuLwdfQnZVcNNyVAlM2AeV+o3Zp6wLuiU+F0dnPp6svl2+wQIuvp/cGethx6Fuybrgio6i8svs7u/5d9UmK7dLMHOlWMhzwoi9zSnHlZczEmXoST8I4Yb0dlVzyf5XfhcZrYb7LTR0XVtV2id6EhIN0onItoYNMSZb2Hy1YpANtxagnvuXzDXgMSJgW/8pGp2YvSiwcT/SqOJCBgxu9Hc8XsyarcUlrQa59pxb6dLS6cshGXAbbR8+yk1ebAsFAlq05EjgmyUI+rOTpumLfz3lPvt6KpQWTFjES1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM9PR04MB8455.eurprd04.prod.outlook.com (2603:10a6:20b:414::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:33 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:33 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:12 +0800 Subject: [PATCH v3 01/11] remoteproc: imx_dsp_rproc: simplify power domain attach and error handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-1-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM9PR04MB8455:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fcf4cb2-eb61-4c5d-4d2b-08de20c371e1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnprZk1nQ215NmZGNTd0WTlCZVlJR3Iwd1o1clRhUUJRa0doQlNzQnhiM0Vo?= =?utf-8?B?ajgwdURvOUczKzMvVlhFTGxNODZPOTBvWENwcEJrdE95d2ZSUWlWNkh0SFlQ?= =?utf-8?B?ckdXQ3htVjlUVlhkZnFtc3U0Rk1GZGJsSnYwOWpweEZOQnZoWGZSU2wrRHkx?= =?utf-8?B?YmljcDVoOExmUGNlQmRVbjA4aGFKNWM3b0dCaW83RXc1WjZ3MGlqUXZZUjRP?= =?utf-8?B?eGtYM01lUjZIbmZFUXU2V1pCWDF3TWhZVVc4bVVrcVlINWUxbHFOTlBEM255?= =?utf-8?B?NkRlNHd3bkxJSFVqNUwzZERlc0ZxemlpcFp0Y3RzR2c1TncyZXZOdGVGdHY5?= =?utf-8?B?TEdzajJFbmpKM24vOEtTVzdtUE9wRk9BRjBrc3F3TjZmU2owd2NPU2xMY1Jl?= =?utf-8?B?dThTMlZRUzZ4bVFiL0tpV3U3ZzduVitCS3QrQzVId3MzWlVMVTZoVWRxSlRn?= =?utf-8?B?M1ZycjFRQzFNSUJZVHo5emRoSXhaOENPL0JYUFljUWkzeGtweExXWC83ME1E?= =?utf-8?B?YzJQZjlXVmRXMUhhLy9vbkt5NEF1ZVcvTmZrUCtuUlIyVTZBY2xwT3FnSGl4?= =?utf-8?B?Q3NaUGlFMll4ZGtEbDVrRjdNTjRvUnE2d2ZreWZOTktWOEs2dzFiMXZBZTcw?= =?utf-8?B?OUhJNWdSdURMdm9CQVNhWldNbE5Zb1Bac1ptU3FqcXJnV1FoMCs4SmlXNHV0?= =?utf-8?B?TFpvbitjUWx6VFlObFR5YTAxYTVTc2ladExWQWJ0d1MzNFlDQ245L0kxZkcy?= =?utf-8?B?U3NNOE9aVHF6b200Z2tUOVQ1UUtscEtGK0UwbGhSVUtmTk9KZmlUMkNubWJi?= =?utf-8?B?dnE1RnVoS2pSUDNXOVNDSzd1TUhaSFRGRTdoeFNLOHErMVFnanpCN3NOUFZU?= =?utf-8?B?Mm1rL3JIU3BKa3BOVjhGMGFXR1M5NW41N01zYTQvRUdQQzF2OVMrMEZCQWlT?= =?utf-8?B?aHRkTzAvdE1LSGhSSFQ2OW5GaEdORmlMdkhJbzNzZWxkRWJmSnVjdUk4bk1M?= =?utf-8?B?MDZjVi9HMFVaSzRxL2lPdjFGcEw2YzNJYmtSVWNxUVRVNnY5cmI4SEV6NTVT?= =?utf-8?B?Z29hc0w4NXhORXlvUnp2SEJ3SE94Z0ZLTnRQbEY2dTZPM0crbWc4RVBKOUdU?= =?utf-8?B?OFRxLzByMFV5cUJpbFJYK0s1Z2RMK3Z5YmJwelVXYjhmSlJKYVVNNXhCaTBk?= =?utf-8?B?SFJGWjd0RktEVnpVdzBxL1d1dTBLSUJaRG9XT29GRUdFcy9RcnlpUUpPVzBp?= =?utf-8?B?RFROd2FjOE1QY2l5K3FoZy9wKzVOMW1WUEszOE5lajNLZDBWNmE1NVpCRVBp?= =?utf-8?B?bmh5eTh1R2F2anQyMkkxUC9KcWk2QmRkcFRnTXdmSEFKZFdtRCtqUkEralVW?= =?utf-8?B?MGR5MEsySU1VL21NYW8wa2FDbUZYSzZJbXgzUkMwQmxnY1RScC9pZTFSdmlC?= =?utf-8?B?bWRvdFUwY0NFa2Y0aDJ0RXlDTE1od2djRTUyalFFSVhZeCtLcmw4SW9zZmF0?= =?utf-8?B?Qmd2bmlrSGJjdVZMRlpXNXQwam1Mb2pEQnVXZXZ1Wml6TFN6WS9hUXBMMCtL?= =?utf-8?B?VStXcmx2bFJGdGxTUXI1Z1NoMVMzVHBOWlVJUzBkWnBaREg0NzREbU55cVJ1?= =?utf-8?B?MnhHbG56OEhHUVl3TTlsNzJYQUJLMFhMSnU4eDNqTUVJbWNlRXNOdmhTNXhu?= =?utf-8?B?bjhEYTc2Z096RzdMRDlTZ2xMNUd3Y043cmxPZXh5MlVIWHcyUmUwRHZ1RU1S?= =?utf-8?B?MkUvbGR4TEZiVU0ya3l5djcwdnlNYjhPVVVsWHZ4ZWFwbFBqV1NNZGQ0RUpV?= =?utf-8?B?K1BLSUdsSFduWGlLQk1YWWpmMzRUOTZrVDVhS0JKTEQ4MkFIbEN6akQycEx1?= =?utf-8?B?Mkthd3pMYWkraXYwN2lsU1dtK2dSS0Y4cm15ZUMrTUErakZvTFc3WFJCR1dK?= =?utf-8?B?TGxPczFrZlV1ZjczTHVESU43WVpkeWNtS2xLK0VaYkdoWTE1VWgwb3pwbTRX?= =?utf-8?B?c2FpRDg5bUw4SUxKd2l1S3NEU2FuUkwwREttMzQ2VDVOa1JGa3dxWmZzcUJZ?= =?utf-8?Q?M/YS/X?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVRER3l1ak5LaEVEWk5LeGQ2OFZkdDcxcVFObGxaaHluSFhLblBhcUp0UXFi?= =?utf-8?B?c25LZElIQlFMMFV2Y0dWNXA1YW8wQ1YwbFJveWgvYUlTYnlMVDd5cC9xNGpN?= =?utf-8?B?YklZVUp5SFFSWlYvalpURlBlNmVsN2pDQWZvdjI5bjFEbzVpVnpoZzJnVXk0?= =?utf-8?B?MzhISTdpclJyTGk4QWhvT2pmOGdQOWNuTnF3Z1g2Z2J3NFNDckQ3aUo5RUxF?= =?utf-8?B?cG8yZjZsdUNEYWdnR3ZHVXo3N3JvUVlzKzk2YlFmOWJGUFUvMDE1VEdObStH?= =?utf-8?B?V3hyNzVkay9lNWZhREpyMFNsZ3UvTXZwTWpUdURrVXZtTkRRK083Q1FKY2x2?= =?utf-8?B?MFpaVVZXa2IrNDh6OXRTK3JXMDAvT0ZhN1JlQzdXMjByQTVobkkzSUdBc25E?= =?utf-8?B?WlFyWHBWWlk1Z2pSMm5TRUZIa2szL3lCREl4aFFtbTQvRW1HMHBaSkc0dFVL?= =?utf-8?B?NnRyOEo3TG1XTHZyOEtvUkpCbUtyVjAyYVpyMTdaZGw3cWpiYVRZbG1LSnRn?= =?utf-8?B?bW5JNWpPS3UxcG1kNk1DM0NvbVhKTXpEZkZVM1QzYnRuV3prSGZreWNoQlZn?= =?utf-8?B?eloySVhaeUl3WWNFd21lL1BZc1F5Rk1zcUJEZnRNNkIrRVkyR2drckhCTm1C?= =?utf-8?B?dGFEcjZoelowd01Da09vdVZIRjF1aW9JTGw4dVc4bUdsalk0eDhlbGhNYkYz?= =?utf-8?B?cnhoSkZaTkU2MzJrdWxlMkZrcDVCQ1lSTFg5Mit4U1dCQ2pDa2lxT3VHZy8x?= =?utf-8?B?MmVFQmM1aVpXb3BEdkVJdlZEeUVIWVl0bS8yTFlINkMvcmszMmVEcEdObHY3?= =?utf-8?B?YS81OUk2VXNyaWNOaDA0VC94bVIzSCsvQ1RIZWVtTEJIRWM5SHJxU1dUWUxQ?= =?utf-8?B?ZGliZ281ZE9Odm1jZkpHR29RMTRSOEF6Ri85WXE0SWxWeFhXQW55VEFoWVNP?= =?utf-8?B?UDVIaEp6dzBBSmVqMWFkOC8vQUxCb29aRTR4WHVBQVFPR0k1SHhDem5FdlE2?= =?utf-8?B?WElKWU5ZOVVxL2puSVJDVklQTUExc01pV2RZNEpxODZWZ3FYeXdXVFRXWDJ4?= =?utf-8?B?TzNBdStuMlZpbGtySzFjekFRay80V0F5czdvOHRUbU9IUmdLdjlxTlBzY05R?= =?utf-8?B?SWFteUFtdTVIOVpoaG00b1hXbkFEZWRoSk5JMHk0RUV1VFo0NnJKRlBvb012?= =?utf-8?B?akU5dStLZlZ4MkZhYkR4SldIMTZFejVYZ2xaUXJUVk9RWHFlWDA4SUlNUlRk?= =?utf-8?B?akIwaGlRVXJ6b0lQRDBoM0V2ajAvRS9nS3ZFc3VjWFZBbGVxeXFNODE3VWI1?= =?utf-8?B?SUI1TnRyaHRWQXNHamYzZDliVGN0VVRQRTJXdkR2ZDB3RnhkZHR4RURyQ0Rz?= =?utf-8?B?a2Y0OUlIQmw0bWZnWFM0RitaclU0aEhZMmNTSVJtMUM5RjNHbjVDOExVYzB0?= =?utf-8?B?TmdUQ2ZLSm92dFlmK1M1QzBsWFN2TlBYNGZldEFsd2VsUzVKT3hBZHhWVkxs?= =?utf-8?B?eVduQjdkYndjeVBqbXU2cEQrS2xIOFloRG9WcTR5NFBHZGxQYzg0N05GWmJn?= =?utf-8?B?YSt4Z1o5L1JyVUUzY0lPcEY4WEI1d1VET1JualZvQjlCVHhpbEFJRzFrZUUw?= =?utf-8?B?VGFueFVmRXFqQTZNT01KWWZ1VDZEWDF3cWZSdnhhUVc5SEcrQzZaRkhDWUZQ?= =?utf-8?B?YmRmUUdNOFAwVzhlNktJOFEyc0xqY1JST0x6elVDNFo2SGN1aU9ONk0vbCs4?= =?utf-8?B?R0tjanU3YVFkU1g5M1pvQnRKSXd0VjBDM0F4RFpYQkhzaUd5MS8zZ2UxV2Ux?= =?utf-8?B?Yy93L2FRSklORzNEUUtKRjZEaE5qcEk2b3Q2Y2RWQllxOUtOVjlxeHo0NEh3?= =?utf-8?B?eTdXbmhCYUl2RXZ6WXd2UGdUMERsVDMvdHNXQ2F2dXVYYmNNbTE3amYyUHdq?= =?utf-8?B?SW5rcXo1QkxERHBVTjNUSEdDay9jRVhFWk9BbTYyRFJtOWZGamVtek9JQm50?= =?utf-8?B?TTFkU0lLM3F3c2xHaHdvOTBuRWRqVjF3bXozdEN1WDgrbFM3anFtckRhVFUx?= =?utf-8?B?dDRBZ3B2MzlSc1Rkb3hrUE4rNmtldzFoZGRBM0VsNDA2T1JCMi9UTGR6VDd6?= =?utf-8?Q?yOi6D3TjpPcG9wBpEaUvJejuq?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fcf4cb2-eb61-4c5d-4d2b-08de20c371e1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:33.6100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6kjdzaFbEqtkcfa+3j2fHjEsfrSF6DRm3pr1Ug4bee4x8eWa37C5fPqe5NRapEb1PjRlsaQJgQNQrKr5nURAKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8455 From: Peng Fan Refactor imx_dsp_attach_pm_domains() to use devm_pm_domain_attach_list() directly, removing manual detach logic and simplifying resource management. Also replace verbose error handling in imx_dsp_rproc_probe() with dev_err_probe() for cleaner and more consistent error reporting. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 6e78a01755c7bdc28cd93f00fe6f74affc3d96b0..c466363debbebe8f91b908b3bff= aa32e9bf8b9a6 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1062,14 +1062,12 @@ static const struct rproc_ops imx_dsp_rproc_ops =3D= { static int imx_dsp_attach_pm_domains(struct imx_dsp_rproc *priv) { struct device *dev =3D priv->rproc->dev.parent; - int ret; =20 /* A single PM domain is already attached. */ if (dev->pm_domain) return 0; =20 - ret =3D dev_pm_domain_attach_list(dev, NULL, &priv->pd_list); - return ret < 0 ? ret : 0; + return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 /** @@ -1186,35 +1184,25 @@ static int imx_dsp_rproc_probe(struct platform_devi= ce *pdev) =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_attach_pm_domains\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed on imx_dsp_attach_pm_domains\n"); + /* Get clocks */ ret =3D imx_dsp_rproc_clk_get(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_clk_get\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_clk_get\n"); =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; ret =3D rproc_add(rproc); - if (ret) { - dev_err(dev, "rproc_add failed\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 pm_runtime_enable(dev); =20 return 0; - -err_detach_domains: - dev_pm_domain_detach_list(priv->pd_list); - - return ret; } =20 static void imx_dsp_rproc_remove(struct platform_device *pdev) @@ -1224,7 +1212,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) =20 pm_runtime_disable(&pdev->dev); rproc_del(rproc); - dev_pm_domain_detach_list(priv->pd_list); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011061.outbound.protection.outlook.com [52.101.65.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D57112F6923; Tue, 11 Nov 2025 01:41:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825302; cv=fail; b=iAI5VxkBZzRujRP1dqjh+ufOYIkUf3cu1zsNqNLRA7XFiddDWzliEMLM6E24nrpkUU4l1rWuXA7bPO4yJiJoPnNGGwuCQAPVfU+E1TR+39JDWvIIkcpcnF2fBmg9O09RvBnj8boQMQoxB9qBMO1Y3muexWcUEcOQiBXBEVuQ7jI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825302; c=relaxed/simple; bh=tc+LmmQ+xzWQeBObbwMixhwruyikLlMHMARclSmw0Ms=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=m2Mvgo6RccIaV3XB9LiNpIR0rsw0cLhR1u1yl8+siQR6QF/f0Fb011QO1SFCZ1cN8tA/UxMmCRVMwMocasMSj3nLTLd8Xb9B0KVJQP0DPk+Hv6gH2eNpEVGmUKpDCluB600H/fjQh+cow6pxn0lk0sdBKUZ0QJtAqR+kdw+uJrE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=m9lCK3IV; arc=fail smtp.client-ip=52.101.65.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="m9lCK3IV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZaNwHwUzcdYI4sl0jBfkBvC1JMz3iVcFhEqC1uLPgujOKRfrrKAeK73mNleG0TK0QHzPJO568+qk3HcDfCKPWpH3r2WTsnyP+y1AVHBbpPA51Gjv4mA9IOoOkUFqPgTjJfGkz/ftZkH50vQRTBYRyyh6F6Q+YhyFBqTZ8BAu5Yfqp8G3t/WhLy3hYS9zMMlsPo/jSDqnU4QVuIZjXtoe49LTJ6aye/yfVq9knmKhBGrvkYYTPSQkVvZ+YvbQdzISFSE36QCuEhyRwVkgPwTM8nTqgu5qIrcMtXcZBia8ETRrcWmRhiOXVgBPD6J2wzEBpsHQEjzBegCRiVbDQfH16w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C+8Q9dljdn5mD7otM8RZ92is5vHpGCRtkrfnyA8zU1Y=; b=Nnvtdo1fJEWBC8CNXAm0MkmNMdfEiEuo8R/kmQpycRV5MBTj5M0/vAQrKO+5ozPhWjZ7OfiEVPBS2S2f+Ng8lfUTUe1RdMP5zr1VdOn9uqtxtiQe+xI6DIWRC0Sl2jKilPeGvmlQVnnkzF+K5AcsKPGqH+K7vzZh2JmNjjEktp34/2T7zHclIaHzuAQOS0OGvJB46aVMpaAWH4TX2mfvqFbohBZ1+5eovMhLW1FQHOYc9ZZc9mag23/PRCsTttKtpcaxLb5AUKfsHtFAxqiJEG3umSiDZYbTvT2Fv8DRtw9/yVurjVeqNkxmWpyPp1HV31hq79aV69smPwQXlQvZxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C+8Q9dljdn5mD7otM8RZ92is5vHpGCRtkrfnyA8zU1Y=; b=m9lCK3IV2mQEr2+qoJZihed5uaJGF93suYgmHrSSXyDXF0m8wg4M8RQPce3lwKu2IQAY8ifg7746Ppw7KnIQs0JUOSHQYe/JiZA6IGFGZaYD7r9R68fmtSziNbS76yKnGXOZK19CWQQfWNNY7mdU6TWRgb7/Y/reny9XEQhIczT2dUVb1pn3fepEl3WOy3/mjgbqKlLvAdPzmPgl2z7Z6gJKsmPdQHwDd8WsXA48z50IAYbuoT/8dLi6Ajq5L+NaQ6qCJtAMLZs/n0nJw40Uibrn7AlAeoEhoCVgb1CDmGWqiVnWlqp6Uo/GgDYxAYA+7FHqE5O/g8QAZ18ki620wA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM9PR04MB8455.eurprd04.prod.outlook.com (2603:10a6:20b:414::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:38 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:38 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:13 +0800 Subject: [PATCH v3 02/11] remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-2-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM9PR04MB8455:EE_ X-MS-Office365-Filtering-Correlation-Id: 56ed36ba-44f0-4a7d-c1b4-08de20c37498 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aUFrd0gwN25zS1lKQVJxMGc1OU1FRndiRFA0bUtCci90VVVkV09LcTI0L2JM?= =?utf-8?B?WlprVW1NcmJBMnNzRktRdXRaWmYxQzREREVPTzdIanhYYU9GcjlITmkxSFJT?= =?utf-8?B?U2R4VW5CS0gyRUoyR0czaHhkMm5yaXFlZjdxUDVMb3hsUlhRTVlraGpLaTl4?= =?utf-8?B?OWFXa2FOOUdRTzVvRUM2UEZsR3h3anlIcUZJT0FnR0djbEFJWTJxU2ord1hy?= =?utf-8?B?S3Z4ZldGeTVib1JwTFdiR3VFYWwyRjVESHh6aTUwS3J2UTJHZ1R6VzlkM2Fq?= =?utf-8?B?NUFwZ1d2bFMrKzlrcnpUOVVZUHBodTNGeG4ycmF3TldETU1YMStzOTRQbjBC?= =?utf-8?B?a3BoajNZMnpEUWp0dUxoZHlmc0d4VVA2RjFBVUpsejBtcWJWZVg4eFNUSVpY?= =?utf-8?B?bWxQRnVrY1lLMVh5amhBSjZkL2huaStUMm9BYnZuaktBK29aemIyekt1UllO?= =?utf-8?B?RnJQdjFPU2pGSFJKclNiZzBmZEpSMVNGQWVwRk84SU5PTFVnRFNYN1Rqa1p5?= =?utf-8?B?MFpsbURzaEEzWmMwZjVYc3B5dnBnZ2NMKzMraTZEemxuRFNoTUR2VzExWGJn?= =?utf-8?B?aWNNQndGcXZhL2F5Z0hJRW8wTzIvWGhIbzFseXRkZnRYY2pBSzhGdC9HTzVO?= =?utf-8?B?NEV2aXNWUUpUL1d3RVRleXNZMzd3dkR1TFMwOHEzeDB5RktHR0N4QXB2OXlY?= =?utf-8?B?QkFtRUl2SndtMFVGQXdVU0VjNjdXSWJPcjJIR2hWS1JhU0R4S0R2S2FzK2Zs?= =?utf-8?B?MHM2OUE0S29CdkFSR2lURVJ6YnVHbXFDdVdWcnJQRXplRGhXWVg0dHh4K2h3?= =?utf-8?B?YWM1ZXZUNFEzUlJVRm81cE9RVDlpM2x2c0Z4MVZoNWlkZmIvdHJsVDBjQVNO?= =?utf-8?B?MzVMdU9vVUZHRStUdGVrR1BXMFd3SzlNdVk0bjFhdjdjUkFYWGVIcUcxVFlY?= =?utf-8?B?L25CNnJsdGxuejM2Z2owNWlYeXZPdmZ1QmRHdm1zZGk0ZmFFK3JLdkE2SDUw?= =?utf-8?B?OVlwa21iUk9jMTNrRDdKOGtZQ2tOOFNKeEF0K1VIUXZtQWpYeDc5WlBzUWt0?= =?utf-8?B?eUtiSk0rZkh1VmZ2QVpYOFFQUWhJU3BSRmYyaFlvSjJUNjhYdFB4UUd4eTRE?= =?utf-8?B?VExFRUFHL0hYc01xRUloZVFKVXp4dnlFdmhlL1RyNjhGcjRzOFBic0Faeis3?= =?utf-8?B?SC9HbFE2UnJUTG56M0VTc2FySFhkZXlzQjREODZkeXJkbU50NnQyMXhVeURG?= =?utf-8?B?aXpiWVVYSFdiVjd5aXFpQUxQK2k2T0FGWnFZN1A1U2Q0bkFvNWcvZ3FJYlR5?= =?utf-8?B?alJZNmhyVHpZdWIyTE50NGt1dXBYNlRIdG0xSmpTMmlJZEdHOG0zY1l5aGFy?= =?utf-8?B?c1plNHZlOHk2S0dPeWR0TmdIVzBjSVBraTRUTGJ6Ukh1NDdLZVEzcUw1K1dm?= =?utf-8?B?K3Zjc2xocUg5bldWT2dYWG5TeHhyR3JQc21PK1BtTGdiTkdYSE1UbXZnNWNC?= =?utf-8?B?b25IRVJaOE5RWnlrcjhxOXorRkY0M3Y5Q25mRWlFejF2NzBKK2kzVlNWbzVs?= =?utf-8?B?ZDFlZXBkNldLdFdVV2krUXpJa0szdlN5T2U2RVkwMEd1bzJSSXFDS3lhNVRi?= =?utf-8?B?S0YyeGNGOEVjRC9mU3p0cmVTbXprSHArdFBPVFJMTE42R1VSU0swdzVseWZi?= =?utf-8?B?amNXSE5OTmRTMWh0ellkaXVBZnZaS1N0QWxydytCbzIyZG00N2ZVaGNrb1da?= =?utf-8?B?QWVuMTl4eWlWNWg3eGxIc3VsdThYdVFSRlBDWE9GWW1wYUtCcmdwSDdKSzR4?= =?utf-8?B?R3Z4b25wb2ZYZXBLVkhRTHgvMngrQnpsQTkwdHN2Si80MXczVUE1UENjcCtL?= =?utf-8?B?RUpFTkRqN3dsTENWWUpWV0Z5cmp0dk4vWlRNNkZsWk9vbi9kTWtXcXBJeGZq?= =?utf-8?B?ZXBqelFVS1BPekVyVEcvTmg5RktmYVhvMmpKajhwcXRlcjdQTW5rSlFsYVlj?= =?utf-8?B?VktMM0p5VmJ2RzB5VEFaYmIxazZHajN1WkE4bVpvd3c3dGZIOVFXODMra2k0?= =?utf-8?Q?3OoP2W?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUlTRUlub2V1WVpva2xBSXhVSVozT3RaaWEyOXdFZW9CQWxrRU1YVlRJTnFV?= =?utf-8?B?NkczNWZKbUJZbmtvNUpNM1d2dG9rVytnY2Q3UWZrQTNKNUNTNGRpSVc5RThk?= =?utf-8?B?a1JQNDZ1RHpCM0FVQmFvSlNRN0NwL1hmN3BJYXhidkcyRTU2cnRqS0U1ZWJ0?= =?utf-8?B?czh6K2p2Y1B2cW9OdkdscEgrOVhwWGZYMjM4RjQ2WlljUVVmWklhcGtNT2Fq?= =?utf-8?B?b3lzc1lNWE56LzI4QnJXTGpSQ2ZudWRaS0xwVWtMZzdlRmV3cWllK242d1ZZ?= =?utf-8?B?dFpOb2FSR3lRRUlwenNQOGVrZVdjUUxrakpNNXpQZGZJSitiajQ0eUovRVUy?= =?utf-8?B?eUxPWmZEd0JYVGVSWjVUa2M2MFA5a05pbC9WQ0F2MGcvS3YxV3hndnFvSmhk?= =?utf-8?B?bjc1M2hnYUEzL3VzMC95bHpqdjc1Y3NBZ1owY1VZOHFTNmtqSUNwbk1PTkhJ?= =?utf-8?B?TmxtSHFxQW91YjJOM0M3UHFvaU0vQ1padldpbklGWDVhdVRGSkNoeXVDVjgv?= =?utf-8?B?Q1JVQzNPaUFqWDgwV2FvS2lOUDlDNzFIZGo4U09Ja1R4NEF4WThrSXhrQ200?= =?utf-8?B?K3VsN09GMmtvM3JpZ1BuSzFKZDIvTHE4WEE1TzUxSXFRaWE2TWJiaGFVN3Ro?= =?utf-8?B?czJtSEtpaTVaTVdUb2NHN2EzbU5LbmNrcUozMVBhUlJIbmEvR09wU0Z1aktz?= =?utf-8?B?T0pXdzJ2SUdYbE1lQnY4UFBHZVRtUE9NQ01KcVdQYnd5aXJ2S1FZcEx1OG5G?= =?utf-8?B?OVJ4NkhRNGhuUnR3UEtXVkFwcVhnL0ZzdlhmRzRPRWQxeFoyVTErZTJGUmMv?= =?utf-8?B?dUg5Wk5FTFFveHBtSEVOdksvbDZYYW1GM0JVcUNTak9mQjd6UDBYUzJhMlds?= =?utf-8?B?TGpOQXhQMThRbmJ4NTZja1hhN2pvK2svUnVsTnorRVhRQU45aU8vMy9URDQw?= =?utf-8?B?ZWlkUmpFbm9DMUpvMFFwUGxNQWVhOGpWdUZwT01XMVQ2RmhqMXppelVlcEJn?= =?utf-8?B?cjJUNkh0bTRBZEtMV2R3Tk5SVGRiWHorRkljTDdqaUdGNS9VcGxlVElnTWVF?= =?utf-8?B?bUZrKzBLSWljVTBlWUVWZ1J2RWhEa211cU5oRXNvcGJrOHdyMy9oR3p1aFRi?= =?utf-8?B?eWZzR0VBdGlyU3JzM2FycWgrSXFHcFY0K0dibzRpbnMyWGhiVGEwWUhGeE15?= =?utf-8?B?eGtPdU5CSUtRZWJxK0VmOE5ISG54OW0xbTN2MHM2RVEwZ1Z5b2pWZWQwSnJr?= =?utf-8?B?WC9pZTJlamZwc25rRTcyYXFkMkFNNVBZbXJRQ0xRUDQ4UDZ3TmRxbHVmMXhv?= =?utf-8?B?Szk0UFRnNXlpTGxqNVowVy9ZSDBWYlA5ZTdKVDhHRkRzcFZhMmVoM1huMkxw?= =?utf-8?B?Ri9yT2Z6WFcwdEZaMi9HbVJmY080TENpT3lTWTF4VW1mT3ZERkFNS2pLNFAz?= =?utf-8?B?OHdISzBLamYxWmlIL3BTL3NXa09ZdzkrYi9YdldwcFNqemRuWFQyNzFtWUJM?= =?utf-8?B?dk5SekVBSXBxYXRtZC9CblFnSklFNzNLTmpGdVphZ1R0SGFxSk9za3FMbXJK?= =?utf-8?B?YnFrMStQbVFtZ3U0dWlSem5YbGwvbnVHUzNmVUptV1lCK3ovQUVYVHZ3T2p4?= =?utf-8?B?Nyt3eVJJNlQrY3Y1MmdYRm0rQ1BhVkRGN2lyRG5zaWdOSUMwb285TWR2YWt5?= =?utf-8?B?cVV1Sm1vQkwwcHJJTzRnZDVTYXZpb3d3SUdOODB0UXJLT2ZCQTZEM1JwSjEz?= =?utf-8?B?L3NGKy9VWkswYkFtWUdDK09KNnlBd0FuZzliRU1JQTVYUTFjOXYvays2cDBk?= =?utf-8?B?TnZPZUNTQXlUQnlqUWpUeEhaQllzY1ltb3VQK2lIMXRqcW5uSHRqcmZyWHVC?= =?utf-8?B?TTEyaTlDOWs3OHQzQjhocU1CUDdQVDhLREs1WmNabW5vakZEZloxTFp5OXRz?= =?utf-8?B?ejhWTmpEdklyMTVjNzBJT1hlUDU2TlJDQ2h4U3lSU3JnUGIwNVZOd2swaDdC?= =?utf-8?B?VzNldys5K05UL0JEd1NoMzkzNCtjMTNlQjhFQXJzMXdWSDJQTDZuOGF3b1VF?= =?utf-8?B?RUNSaWNuVnVOeStmU1ZjRE1sMms0V29xcVpDTFZsQVYzSlQrTkFpRTVlcXkr?= =?utf-8?Q?vP3M+xqQTyGNQk4TmbzBClq8Z?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56ed36ba-44f0-4a7d-c1b4-08de20c37498 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:38.1323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4SBxy9kfhZ89og/1q1hxl9Br8XYB8DD7urM38kCPSuBXeAb/LxnGOvGvRQQ8wCLlcBHyJUGBRR4gCZ6rUsZ6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8455 From: Peng Fan Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index c466363debbebe8f91b908b3bffaa32e9bf8b9a6..df6a4126538d22ff6e02145edb5= ac13c2d72c949 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device= *pdev) =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; - ret =3D rproc_add(rproc); + ret =3D devm_rproc_add(dev, rproc); if (ret) return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 @@ -1211,7 +1211,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) struct imx_dsp_rproc *priv =3D rproc->priv; =20 pm_runtime_disable(&pdev->dev); - rproc_del(rproc); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011017.outbound.protection.outlook.com [52.101.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF24340A72; Tue, 11 Nov 2025 01:41:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825307; cv=fail; b=g0VqKIO4WiY3Z9wrBCdJIUYvhSVxIn4xgbM4zmORHU1AbkS22+CAP83B2nz20vtkJFqI9BZtEY0IJ/vWNwoY7hBStItW9NkknKxW90KkS+APldMxw3cc3fbYgTaotQOOU2f+omYpaidlzEkBCz0hOQe6jKqevFUSPUVVEgB/mWU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825307; c=relaxed/simple; bh=iWVGNY4XbelyPLRFb6lVSSEduCg/Vd8aiEhT4qvFcT4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ADTX6W0hzwz+xDpwde+nQFOSO7tB0+i8AfsDLc4qIU4qKU8xhZBP9zWJH3GOFhB/xZDmFhxPNEz0Ri2+ZLwFWVBeyieA4s37tkA3IxBYOxh0hmkaYFekIUna4qW+FTVphjUeQfOO87GPBB+L24O6BtEvORUGprmwodl5qGRxClU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=nnNPi2o8; arc=fail smtp.client-ip=52.101.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="nnNPi2o8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hWbuhAck63XRC8Z2VXlIW2Opw5KnQ3HsegQotOHYuLXjANoRLdJMQZJxPzZR4xuW5BZLlYqTg/TIwSiHEaxq4BNRCBiaBp/sCH9FBy/WNopf9QZiU+b1zzf9XGgPUPwKs4CnArIIzTJDtTwCtF7Qo3fRN5J7mU6QyfMTWINmxT5DyWz0dJmoG6i7bZ5QIMKmI7e7UZvQZVS+krvreOazFhYGEH2est11l3mw+nH3PWMQqrF0RphkQSlUbNwYqSJljdWWkh1m71PZXKa89yXHkY6Y/mAkre9UBYW0w30EnLzLqnomrpOK8nwOtqGS4KhhoZ0mLjNra320p+OGCVpjRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KlklTO7Uq958PMpPpj2Kc9/Q0psnuRQ1xj0uSFddDWQ=; b=lEAw5/m0vspLukGCo23XDaWSpzaPYn3e5VENzxrXXMF3ICsPEUSKEf3HgIlRylQSpI8qPWP8Usun3UE2W0xB7l6AYs5KjCMWaat4+Sl8OcqKEy1XoBXW8KXcnwAcO5wdn5ySumsTK3fQmjVoqTzmDMzxeF/C9SSyq6hDstUxFG1zG89YCgB9OZns4Z/MLKvCfAFAHJYRKmJbJKdXzpjcp3TxhgyiwWwDwbo4SxL/ixvLXJZwRu2CWPDAINnpIxUrDY9XTrUyLdhHlMELJ5lWi2lUlgVmi+QxKaqDWjGB/57oTmEjd2Slo9cR3HyOb6MuXPmcPmFbMuLRbnZbZECJ9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KlklTO7Uq958PMpPpj2Kc9/Q0psnuRQ1xj0uSFddDWQ=; b=nnNPi2o89v4SmYt0mSOBtSlVkPAJbW3W4pwmQRX2OJlc++6B0j9OiFoNugpj7JP60DVz4ASqq+4YHwTudg9HZLxRgDnYd6rYlRsYBCDyFe0IZjuT72dQszs8EFnbMHg/bEbgpTOKVNl7koD716/Nu8s0HmZ0CTb/4OK9UJMA+F5nH458saTCIsZHtI1Vr+XqkNGu+6F1qA2QmZlmZ7deJGyr3y/FMpJNFDkXPsy2Z5AxnOfj13+owQ5B3fJauT+Q1bJZg9/WCE/cbZ7OmRQ6UDqmvjlbrjhLdBqa3fRAaSvc0OqPkzgjRPNZGSQg3Kpd6zMhef88KMGLIa55sW3C4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AM9PR04MB8455.eurprd04.prod.outlook.com (2603:10a6:20b:414::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:42 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:42 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:14 +0800 Subject: [PATCH v3 03/11] remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-3-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AM9PR04MB8455:EE_ X-MS-Office365-Filtering-Correlation-Id: e581754e-596e-4ea1-3024-08de20c3772a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?emFYZktLbnlObnY5WTVPblNSUHpFcmJkWk1yWmlpTEpqN2JIcDZQYjZZNEFt?= =?utf-8?B?QzRRZWdFMzZ1T0o5UXlXR2MyQ0VHRWRwOFJmUlFGSlVydjZjamg0RGNkNW5t?= =?utf-8?B?RnNMNmNTTllNVTlqdzFNOExBbGRmZmpmNlNHK3l5NDM0TWNpUU10cVU4aVpm?= =?utf-8?B?dXRmYzR3SE54ZFNCODlsaFY4QjVqaEpSMXhTazRreTJGeVhBcE9tSkxnSWVj?= =?utf-8?B?cnNjb3Niek1pc1g0Zmt0ZkUwaWZpOTFvNGVPeFBaRXRtRHI2a2ppU084ZStX?= =?utf-8?B?cHlsbm9yS0o1TVZCTmc1cDFqdUhTVlB1R3oxOGxDbVEzSzQvc0FYQXZHb281?= =?utf-8?B?YUgvV0VxZmlCZmo2U0ttTXV6YVJGUllCc1V6U3F2QWFhVHVnbVE1ZFBkUGdX?= =?utf-8?B?ZllhQldUdnlhQlJJRkJ0dEo1cW1Wc3RtdHp4ditDangrVEt6KzNGeHBobWU3?= =?utf-8?B?eUdYcmp6Z2M2Q2VCUGtONFpPdllXRTFUUFA2ZlY1dXZTd2FYMmYySzcvWHB1?= =?utf-8?B?Z3kwVDhKazZsdDJiTnBUQXYxWTJXaEhHcEMxeFNJU1dLTHp6N0J2eThnRTRK?= =?utf-8?B?ZEI4WnlQKzA4eTErZUxUZHB6TEtsU1RXUkt0a1djOVhiYmUzV2Z1cmJ1TThx?= =?utf-8?B?MG54Y0Q3Wm16ZFNKTEJVa21GL2hwMFg2d24vZFVYbFAvRzIvaFhlNHJGN3hm?= =?utf-8?B?QkU3eU90anVoOGVCYjk3ZE1KVnlRUHFwRlhwQUVuNnJob0hVRXZ1ZEhaeFVT?= =?utf-8?B?eXBFL3UxLzI4NEg3bXc3WlVTZFovYkN4VXRhVVRaNzlHc3U3dmtDMVUxZU9Z?= =?utf-8?B?cm1NQ01Nb3pYWGN6Q1hibzZJMnA4M1lNSjYyMzZBb2xIMlhoR3RoVlBCZjRH?= =?utf-8?B?dUsyL2hqcnErNWVVTE1SSVM2OXJ2S25CS2hZU0ovbWQ2MkNSaG9nWjZXSTVP?= =?utf-8?B?QUpRUXRkc1QxQ2lDb01sd3VHaTVHMnI2Wm9IQ3cvVk1FekZQbGNyWXg4S2k3?= =?utf-8?B?U2JnV1RPelBnUU8xTElGUmczUXZoY0tuTVlLUTdhUzA5c1ZzODNJdDlBVnBj?= =?utf-8?B?R1BZWnMzUDJ0WEJucGRCTjdoNC9hNDJURlRNL1dzL2JpdzNzODcwVXZaNFJm?= =?utf-8?B?cTBjbVNjUGhsNFFCdDAycW1xRjJlOVRmbllURUtWV3FYUWE3S1RtMUI2NWxn?= =?utf-8?B?NE1YV2JwMWhRQlEvbXBibjFvL0I0ajg2MXdpV3JqbFF5VVhSTDFISHB5TnZZ?= =?utf-8?B?KzMzRFppNkVwM2hOSkdiYTVlTDh4dFRxYzZQOXAwZDMwaXZtZUlTRkNpUmtq?= =?utf-8?B?MWdpdDFaL2pIZ2JzaStHNkphem5uNTZjWFpRYnJKalNNVnlaS1BEQ3JKTFQ2?= =?utf-8?B?OFZBZmNNS1RPSXVwVW1sVk5GaktFWFZLK2dFd2tNemxDZzU0R0IzTCtISlNo?= =?utf-8?B?SW5tQXN2S3lvMkdVeWJkNnFQSE1laEZkc0U1MGREaTh1aytEa1RQTnFiVlND?= =?utf-8?B?b2svT01zdHpENUlvcDVBMlVYQkd1ejgwSEwrM3JGL0E2eTE0a01FVmpQTVJT?= =?utf-8?B?Vis5UjZMRkhUNVcySzNqVXFwRUhrUGY5azJ0THFXM0RMbEIwRUNpZGVSVVhM?= =?utf-8?B?dkVhVHlTaEFsZkpoNXY3ckNaNFJMcW1oMldkUG1YZ1pWRTY5NTMrcHhZV0VP?= =?utf-8?B?cmE3bERZS0RBZVBWMmEvbTUxNmZqdGFjbEdORDI1Z0VWUEdTYUNrY21UMVQ4?= =?utf-8?B?Zm5SY3hJMjUzZEFDREFFam14VzlYSmtLaU1KNXhNZ1Q3UVdoWWw1WURvOE9V?= =?utf-8?B?RzJFZitpTWxCWmQza3BQMXd2U1o5azZYY0hCZVRTQ2RxNCtZdjI2OHNUaUxP?= =?utf-8?B?NFF0Z3FEcndpbmpSZkxPWThWZDRqOWJzZjNWV21LZXp4cWFVb0Y5dnBtbWNP?= =?utf-8?B?dFZTTEZtRmUwR0tDdjBnNHZ1ZWJJSlBaWmMvei9sLzgvaXkyT1RVV1RTZmFF?= =?utf-8?B?dlZLMklSclVscUVnWXYxNFVlT3Rrd1BjM2IwNVVraHdTdVZwUUVPM0dsaElR?= =?utf-8?Q?3dYopV?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU9wNFNIdlcyZFZOZGxnTFA3MDhnc0hQd2NUNUxGNmMrb0RLYkg3VXIveE83?= =?utf-8?B?ZmFLS2pXcjdrWFNEWHhMRkkrbDg0VW9LOGxHS0lmQWsvbkNjcFhOSVJKdVNE?= =?utf-8?B?anR0K2tKMmYyektNWnZ6elJNUEtXUlRTNWUveThBUHVsbVRMc0JabU0yWWI5?= =?utf-8?B?eHRGU1ZYSmFGeXhHWlJlWEZFME9sK3lQZUpib3ExVnpQa3RlODEza3BHNk8x?= =?utf-8?B?U253Mm5hOHFlMUdEcW4xakowMnlBbFdiM3UxV3VETVJpeTRMaUU3THA4Tmta?= =?utf-8?B?RnFPWUZyaWw0M0p5UmNvRHJ2YTl3bE9UWU5GckgrbzFXbHlDMUxVcHY1VEh6?= =?utf-8?B?OUJIdkNKaHdGNzFUMDZwZXNZMDVLeXFxNTlXc3FVQzRaUTVybVViaHAwZkpN?= =?utf-8?B?WGVtMWhQQXRNNTlERk9PeVpWODdCNEl5R0xNZkVkL0FMSlRWVjZpcFBRMlZv?= =?utf-8?B?MTJNandPUUM4djU1RW1ZenRlTGFqaHVYaEVEM1hHVktPRzlGZDU3bWNtTC9h?= =?utf-8?B?OFpING9lTWJIUDZNazBkZ21XQXJNZHVsSEF3TWNSVDRVdXNlblRvU05Fa0ZH?= =?utf-8?B?ZFduTDh5bk0vVlpvZDJPK3h1SllkRWo1c3BWWk90SG4xMHJ6ODFxUllwYWFG?= =?utf-8?B?elhFQnFHaGNOaURvMWNvWEFTNEdBWVJUVmpnbE1KSDVESDA0dnZBNWVCdXBF?= =?utf-8?B?anFrdG96Q1M2WGU3OTZ4d2NLM2FXOEtlNS9HUmsyaGlTUTBGOU85V21MMWdC?= =?utf-8?B?RW1WdGJodGt1ckNzb1FjdzRWMmFhWE5DVVBuZFV0MGlub05OWkRvNXRKbzFL?= =?utf-8?B?T1RhWnhHVFVBai9RQUJmamZ3VDJ5WklzU3BXMkdGdnFNUTlqVWIyb2RvdG1p?= =?utf-8?B?bWxVTEZCc3V0YUpGdmg1WWRMQjFpdFFhZnBFdkxUeU1Ea2tXWTV4ZHEwQ2h2?= =?utf-8?B?OTVBK1U3SUFmUlNMNytRTXFjMTFhb1hnMEN4cXlzM0JVRkRRTUNCa3hYT1Fu?= =?utf-8?B?QmRtZzhxWVhGNDhJVDJDM1ppMjZsanJIeGhvc0VIdnQ0cUdydEZNMndJRFg5?= =?utf-8?B?YzVFUmZkNHdwV0lxOTJuemU3UnZXcGlVNmJkQkh6cUFTMDJLcDczNUw2Y016?= =?utf-8?B?TlorNXlEZUNodmM5QXo3cjRuUnVISjZYRVJJYmc3ajd3bEw0U3A2MlA4aUpU?= =?utf-8?B?amVJM1VGUFJBZGFucUdhTWhld0RkK0c1VmFUb1h2MzFXUnM2ejRvcGdlckV4?= =?utf-8?B?Y2JYSmpjcTdKL3VKZ1VwNEpnVWYwZ1Q2YU9uYVZYM08xMkttczZIejk1eDhB?= =?utf-8?B?UVR0clFGNVQ0K1FjeEVCd3RpYXozU2p2TFo2QlpnZTE0N1V6V2NyTU1Qdk80?= =?utf-8?B?b2pSTWc5aEVsYVFQcEVRTE5BSXJ5bXg0eDMwU1N4Q242dW9uMlFJeUhnQVhI?= =?utf-8?B?eWd0ckFRT0ErSHptZ0hzbktFQ1lyNHFicHFManFuelJuUEU5MmN6R0Ntc0tS?= =?utf-8?B?Q3VjRW1XM3lmM0kwaXVmcG9UcFlLK1BWV3dCZWcrZWY4ZCszRFhDZ3Z3SC9S?= =?utf-8?B?WkFqVFFScVJoQ0FtdWZ2UUNubmNtbUlBL1RHUDlXTzYvUjVNQ3lGbUMrSTVi?= =?utf-8?B?TmRZdG9RNXpSYk9xaE5pNDIrTTlDdjcvSmRwYXgwa1Rkd3U3eHV2QmpnUTRT?= =?utf-8?B?eXlkZTdlSHhnMkg0aE5yUVhTYkJXK0tIbm5EUUFDUm5BUXg1dW1zK1kvY21T?= =?utf-8?B?SU9RNlVJRkdvV2lmY2M2RnZselRQQy9PcGRXSENKMElBS1ZUaGUvaVFpYmdo?= =?utf-8?B?bjUzWFpZbS9lamtaZVVhd1NRa1JlWlhUUU50WU92MDZpODhBV3pQdkJjVjRG?= =?utf-8?B?My9ab1R3NEczR0o4Z3crcmZNU1lWOXhiVjZMclAybk9BNXc4am53d3RnSTNx?= =?utf-8?B?K01Ba25CclpNSnJNclEyMDJ2dHpGR0RITkREL1Z3MFhhOEVaRTBSaEo0Y1ZX?= =?utf-8?B?M0FiZVQrOFA0TUgzTXRHUVlJTlpva29vRHVualpOamhpTHFNWXQycDNzSWVI?= =?utf-8?B?OVExWU9oT2pEUXVpTHRETTZ4RE5uaUxYaUc2MVgyNVF3aEJPYmJRaE54QzN4?= =?utf-8?Q?2oHHKyc4/R6+5+Lekhaa20Y0R?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e581754e-596e-4ea1-3024-08de20c3772a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:42.4417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mgnvO7sIGDDLgEtOz16BYPl8hygzjv9u9XaaPBX8z3NEVFwMd8r5iiLJEEacsh2rGKt94cv74pnDDXgv7QAPBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8455 From: Peng Fan Current code on the cleanup path just disables runtime PM for a device. Using resource managed version devm_pm_runtime_enable() registers a cleanup callback that sets autosuspend to false and then disables runtime PM for a device. So, basically the same functionality as we don't use autosuspend anyway. As a result, the .remove callback is no longer needed, reducing boilerplate code. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index df6a4126538d22ff6e02145edb5ac13c2d72c949..f5d0aec52c56664d6074272e276= edb0c4175c9ea 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1200,17 +1200,7 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 - pm_runtime_enable(dev); - - return 0; -} - -static void imx_dsp_rproc_remove(struct platform_device *pdev) -{ - struct rproc *rproc =3D platform_get_drvdata(pdev); - struct imx_dsp_rproc *priv =3D rproc->priv; - - pm_runtime_disable(&pdev->dev); + return devm_pm_runtime_enable(dev); } =20 /* pm runtime functions */ @@ -1361,7 +1351,6 @@ MODULE_DEVICE_TABLE(of, imx_dsp_rproc_of_match); =20 static struct platform_driver imx_dsp_rproc_driver =3D { .probe =3D imx_dsp_rproc_probe, - .remove =3D imx_dsp_rproc_remove, .driver =3D { .name =3D "imx-dsp-rproc", .of_match_table =3D imx_dsp_rproc_of_match, --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013016.outbound.protection.outlook.com [52.101.72.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4404347FC0; Tue, 11 Nov 2025 01:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825312; cv=fail; b=RQgB6ZaJXvE9uZVEz39g3H5SW3ZOdZp4ZlvABszHzAAlmRx916QsBthlt66BZhQAy4gZmtX9uX39ln0yHKcmytZFIeu7dIJHTS3XtDpOJgu0Vax0VdgjWwTkB11uZVFxA1OGhj2cv3SgJ7qWAVlKHHKDSBwE7qhjFS6U139vz+M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825312; c=relaxed/simple; bh=mOlgX3Swl4qR4KQcDPR/11i9MUxU/mYJnKcWYOzlQH4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Scf4fcINihu2DAyHNNmXt+7hKwlbBFaLuUGozbQVumYzBJ1bPTf0Y8eBC4d/QI6IlN/hesfPh4TK3epR8ZumIQrB0UBGgPL0HtSomdjqacvRMENcMKLoRoy4wNdDylkKIAjiFJiOSLpSRnsX2Hp9BTbTL7g3unzQZt4LbZEN41c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=hU/POmDT; arc=fail smtp.client-ip=52.101.72.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="hU/POmDT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CCIMXSWxee7HceGhLNGXEoshOz3fl0e9c+EOcH37JE7qED/XNbdpLBFVDW+Sldwr+thoHdVy7kdZ03PbTbH7xwHovISQB8b373V/Lchgst0Sy5hrwELuCnhftD+K0njTUgz19nhk792ybBJc5reA0MGrC2CaK2bO8TzSsFbaAEWjjozexSrkZSKrpfZWqv15YA/C7b8QG9NT6+TPCzoHYOBdtn7VNyBaORUQZ77w3LE0KFPtMUwRQhVZ0Ya7XpeC9sdv2c0Y4OzRPyIBLPxOmR5J0RX24MhOCatBxhSOhJXYdeDi1+W5ROV/oQpX11PwmJeMKKL4sYmWKW/dHqdnCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xd/wCzE5XxnpiqfQb3I2kE59FcV5SwtyBwHo2LaB9G8=; b=blNCcJ2WnMiRvAHsfUSbVlu49UjmtuQRzYIic1aHhvBhg9zakuWYmqsZa12D/TndS4bWwFYRS6pXVB5wnMJb1Nl6AtRAjAWJoIS0rfxmNJxzunlpRnzjRdwEluD/q0onItdf3ZuONEyol0ztbxOaf4w15kbvjRLINd/fJQi5DNNc+xJ/6EQQfi99Xrzf+N5Qt8iQeR6I+Z4GHllbEiW0LwiqqSJRfo7x/qnqq4anCM4ZY71GozNkongQWASwaIUbzIq3HHxNUz1WWbalbNuR/rpyHdfEggpiAEArN0eF+CCHS8AktgQNVZd9AKRCxZRt5kxd3hgMwMaHU2KWPWRUzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xd/wCzE5XxnpiqfQb3I2kE59FcV5SwtyBwHo2LaB9G8=; b=hU/POmDTPW0W04VLP1mLLBQWVBk2UlXLhzR4BoKd46CwIThlgXhssMWZllLt+jykVjaq0ENnOhDOI3yXP0fDFnl7w3NWcMgena+Y7V0wRxVTViOJTvgHTK5gG+S3+PHzMRIimy0u6IklX8jmBhyk/eZl8qbWCRC0smB6sln2nWbyfE/vLGSPkYW2snEN9Q1lkdsLkjnsP6IxVJ+5/aLHIVZZw0vq8OCZR22W7iRAwEKn6gaKF1U3TMpqCzpE1XJ0feWZlxl+krmMuluEti5FJi6Uj7mhYoilNrCOnkfFgEPvuZqkZLMHjdwddnMj8I4wwwzhpjLNV7eoSMimMqMg+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:46 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:46 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:15 +0800 Subject: [PATCH v3 04/11] remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-4-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Daniel Baluta , Shengjiu Wang , Frank Li X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: cf382c08-91a7-4fa2-f6fb-08de20c379b9 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QzRGUS9xV3E0UjhqT2xtOWc3MnYrODNQVXRVaE5GeFl0cXBzOU5IOU14OFBU?= =?utf-8?B?QW9KdFh2b1JXbXRHb29idzZTQ25vbHZwMkJxN08ybDUyT1ZMSG5vcDNYdDlI?= =?utf-8?B?d1htUzQvOXJyeXM4MGhObE9vb0NHOWhQR2lWYnVxZzBKQVlnWnV1NUdmaXpV?= =?utf-8?B?RzVMY1dKWmVjVlV0UU5xTUVHekwrSko4M2VPZ3U4V204RGIyeG8yTWJMQUtT?= =?utf-8?B?T3dEQjIrdVdPaGhvVjM1dzVUZzcwU2orMWFsMzUvaTQvTjVrc3V0bk5GU3A4?= =?utf-8?B?ZnppbjBnQlZtYVY0TXFUSFltNEVvYm9TUU5wMjRSU2sra3NBUFNyT3N0Rkdr?= =?utf-8?B?RE5JM2oxeStXTENjM1VDeHA3a1lhalNZcnZ0VWNyTWJCNDU1Rm14c0JxRmk0?= =?utf-8?B?TUdia3BxZ1I3NXF3UXFtMDIxclJsWjhtZDh4ZmNicGhWV1FsSEV0OERkWk9S?= =?utf-8?B?VkkrT25ud1Jpd2FmVUpyRlhNb3l1a0l4QnRldGFxZU1Id2ZEUVlScndoL3dq?= =?utf-8?B?QjlGRnVwOGJ1WDZqZzBLaStlQnFQdzRPampVcEdvMmRJYVpZckliTnlJcnBV?= =?utf-8?B?dEI5dG1nOHV3NmlvM1dHeEZGS0VFYmJyMUhmQzNKb3JnSU1pZ3VSMktQV1lm?= =?utf-8?B?QjJRMm0xZDNBYjlMN1RQekpLOWpJV1pNUHVSNDJteCt2dmVpbEdMSzVCenpF?= =?utf-8?B?Y2lIa3cvejZtNWRDdWpnUXZXMy9uUnhocm1CMzFWN2s3ZHNibnRjMFZiTU1T?= =?utf-8?B?ZldIS0VJOGdpa1RUNURtN1pRQ2xzcDV5d3I1cWpVeGREa1JWUkJnMmpPbHRk?= =?utf-8?B?Tk1LQUZlR1R5RHRsUnlQVlB3WGVZVTRnb1BJTERPNWk4cTA4RXRqcVFONGFw?= =?utf-8?B?bE41dmU2T0dHbUJYMU5ISDhyQWcrTlg0dzhZNm1yLzF1aXAvWkJNUlBtNFE2?= =?utf-8?B?TFZNaHRhMXJObmUrUE5sRlZtWXg1QmJEZGJYRElSazhTWHY5TnR0UGYwMCtF?= =?utf-8?B?NmFSZ2FWQ3RvSit0cjJsV2s3SWFpd1p3WTN0VzUydWlhNHpQbUtLVWpQOXQ4?= =?utf-8?B?K3l3cERab2J1QjNTWVpaWUpvYzVRZDBFak1sZkpxbllld1M2UjhYZlRieUM0?= =?utf-8?B?b1NDZm1wK2FYUmN3VTRjNys2aUVWeUo2cFFPVGFEcTEyQnlNR3NVNlZvd0Q1?= =?utf-8?B?STRZeUtXSUI2VEtOUVZ3aWNJQ2h0TTRGWHJrQmhnb1RHOVpVMXdaR0ZKSmMw?= =?utf-8?B?MG5EWGNWbVRWdUVWL1pZbko0a1YrYXUrUEJ1OEI0Q2lFMy9OWUhiWUlhUlZr?= =?utf-8?B?VVc1RllFNUFGUWlsQ0U4Tmd5VjUyd2xqQVdNMG4wMWtISHk4ZWYxM3hHdGJ4?= =?utf-8?B?R1NZTERaVkpRZFpzUkp4WVRXVUZLVXNaYUc2SEN1Y0o2dk1INUJ5OGtoVFgz?= =?utf-8?B?NHZFanBnOVhLcENnY284UUNaTUtSQmM2S3NDcG9FcStpOEJRZXQxMkVCK2l1?= =?utf-8?B?Z0hWYlQrR0ZuUWcyWVF1aFFZd0ZaUHVaTjlVTVVVc240MnpFSkYrRUtIdGk0?= =?utf-8?B?YmRvSjVaZlJvOG1CUEdXRXk5MDNVN1E5WVA0Um53RVZScDRPZ1pRVWx3dHBz?= =?utf-8?B?cTVGN0xSRzFldWZ6VUJhUmJSVVBQTkthZ1VrM2Rpc2MxcjhMTDd1Z1VMYytW?= =?utf-8?B?aVpieXlmZDZCN0lFcE1mdmEvL1o0V2F3bmVYU2trd01UakxiZTQwWi9mL0l3?= =?utf-8?B?OEtQZGhOT2JIQ1c0YS9Nb1dTQWRHdzBNYktUTFJFc3N3Z01RcXRqdnMycFNO?= =?utf-8?B?NEh0TmZkVDU5aStlT3ZyZ0U1VEJ5K2hPMkxXUUlxakozZGNRNlRZYXBJdGRQ?= =?utf-8?B?aGpGaG8yU0hMb0lWbVRmQjdJa2pZTjd3Z3NZeHBSS0ZHMkZjSHVnNWVFTjNF?= =?utf-8?B?aXRXUjhuZTlJc2V1MEZhaU84RFVVSWFCak5Icm9qNGtTT1hncTZWSDNVWkdx?= =?utf-8?B?WGJqNjUreWZPYjF2WUVjblFFZ0ZRMCtWbkZsN2ZKOHNYeGdEZUkvNU8rRUJv?= =?utf-8?Q?phrFRI?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0orWjhTQ1FqN2VReU9CbWgwa3lYVHEzQzh2L0FjdzFnSFJyZ2VEOGV2UXNy?= =?utf-8?B?aW15U3YvOTVhdFIxQlJrYmNXWFovYXpDZkVTSmpHTEo1bEptUCsreDdYN3k3?= =?utf-8?B?aTk3a1E3bEdadGpxcmEzVnRuaHdFOW5lL0dVK0g0OVVEK1NPZkJzWEI2MXM2?= =?utf-8?B?Y0ZkTGV4OWRTM2hCVTluN0NFcGJLV1R3Tm5PQ0xGM0VuWVA1SmJNRGVNZzNy?= =?utf-8?B?aUZPSVNGcVUweTFkREU4WnpWZkJNblBVZVJrcEEyaGc5ZWhRMmdjTmJWemZC?= =?utf-8?B?a1pKTFdLY0d2b2ZOdzFOcVlVdTJQaDNJY1dZbjFxbW9sb2IwT3A0czRaOGQ2?= =?utf-8?B?RnNKdnNQejdscUxoaTZFNjUxUngyUDR0UDdFVWpOMk9Qb245eStTeCsrMTIx?= =?utf-8?B?cjRDcjlQY2FtYUl3OXVvaXpMTlcrL3MxcVU4RlBRMFVsbEh6ckZjL1hnSzJC?= =?utf-8?B?dktiamtPMlRNdVdaM1oxaDRSTjdONFEwZU9IcjBEUTZ5OCtpUTBEb1JFdENx?= =?utf-8?B?L2dOdmMxZjE4ZFZBRy9lYmpraWJEUm5Fak5MMGpobEZpa0FMTWQwSkl2UVZo?= =?utf-8?B?MDBqN0czSGhNQWhyN0V6SVdHcHRza0c0RTY2WDJJWEJYdENndXg5MG9SV05O?= =?utf-8?B?dXd5RkI2eVlQWmtHMHVDeFdWZ0dWckhZR1BuRW5OQmJzNE5IZDFyUzZvUDlM?= =?utf-8?B?d2RsZkJWTlVUL2ZXV1pSSGV6RWlEV0VKekNtMXAxWmw0SStaMzIzVjBaaWVO?= =?utf-8?B?dWFGcG16VURFdnplKzdJV0FMWitNdFVTOUNNSlcreVNOTVVXbngwU2EvTHg2?= =?utf-8?B?ZmRqNlZsZHQ3bVczVnR0RjRyRWtZTjY2M05sbWNDQ2NqRGJjM3BSRjUxT2V1?= =?utf-8?B?Nm9zZ2o1NmQ0emFYcGFMRWRhYlNZTVIyTzNVRFFQVjdTdURESW5QeEFZTW1G?= =?utf-8?B?cThGMFExclBua2FoZzJyaDhLMmpYMUJRQndDaElpYmZWRjlMdUI0L0tZSlRa?= =?utf-8?B?YnBpeVV0ZFFCUGl0dGhlL0lXSnhhYytEb294dGFZV0tUYjdqWnlxTHozL1Nl?= =?utf-8?B?N0tUSnd0YVNHTmFWV05LZHRsaWZpK3I3N01La0JTT0paaUlIQXZmM3BZcGFr?= =?utf-8?B?ekExcEhYa3p0MWFQa1FhTFk2YjVOS1NFZVBFZnV5VFA1QTVkeTlFMm55aDNK?= =?utf-8?B?VThXWFpYTkRkcFE3Rzl6K1BNSnN6cjVrUU8wTm9OQkpjV1VoQ0g0OWpwRXRI?= =?utf-8?B?Sy9aUXBmbVZzZEtSVm9RMXdQV3BTNTltaVVpMlBhRnNPU2lIT1RUalJublVB?= =?utf-8?B?VnhoZEVsTGtiMmNoRmY1U3pJa2NlTHBjWmY2cUw5QUlzK1VPS3ZoNTNjeWpo?= =?utf-8?B?REd0TXpjODBwMVorbkJOWXRNUnRmMmtwOGJqWENEMGpQbUV1aWxhVXZ5UFQ0?= =?utf-8?B?Q1h5TFljSU1TY3MyQjMrVzhoMGpzRDNSY3FzK0NUY3pjZ1VSRFdiQW1vQU52?= =?utf-8?B?Wm91VTFiL2ZBUjlHWDk1R0NxTG43c3MyTE04R1lIMXhJSFRvbzBLZnFYR09x?= =?utf-8?B?YlhjT1FyanhSdUE5cnBTemo1ZkxMdFY4RjV6dkVIcmsrNWR1Rll3anA3b2pP?= =?utf-8?B?d3RpNEdXSHBKSFZ6a0R0bnFiL0dVWEJzdUdzaGkzNU53akttcGJmcVExcGxU?= =?utf-8?B?V0NZbktIU2IvL05ZaXZRK0luSjJVN2FOS1RNb0VSZHBKVkNhN25kT1RmK3Rm?= =?utf-8?B?ZFdPaHR6cWRWeW9PakJGT0oxazNKYTA1ejRSK0xsaEdsQnhwU2t2VDBmQkY0?= =?utf-8?B?VUZ5SkFibVZucGExcHplNmcrcmV0VUVSNllsS08zM2ttc1NybVZOa3ZvTm9r?= =?utf-8?B?RVd1WGg3QUlMY0xpK1Avdy92cEMwWXNxR3llQ0dYUmIyNFdSMjJRM2lIbVlR?= =?utf-8?B?TFFjUk5ibmsvWE4vRkZYRHZVTnI1ODNXSnJJNWgvVjZZMU82cGpaYlRIdWtU?= =?utf-8?B?dm9scThPMThlajlaWnY2U3MxVkdsRjhNVVdoTzhrV2pTeUhhVit1Z3hPM1hP?= =?utf-8?B?cFd1Z1pYVnBmeVVqcnlHV1loQkw0SFYweFFiVEx3aitmR21BWlB5R3l6cDY3?= =?utf-8?Q?CLBi48FpCEN9Btpjx7xJboX7E?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf382c08-91a7-4fa2-f6fb-08de20c379b9 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:46.7864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HVAWFav0P8GhmBSi0K9FL4y8YU7zrB7e3yJKbEDYgS9wytL3RvCshZj3C3Hf48prZUV3Bq/hyr4pAskBvU+79Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Use dev_err_probe() to simplify the code. No functional change. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f5d0aec52c56664d6074272e276edb0c4175c9ea..87f4a026c05fbf1c9371058290b= 2d33cb94b9e54 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1150,11 +1150,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) return -ENODEV; =20 ret =3D rproc_of_parse_firmware(dev, 0, &fw_name); - if (ret) { - dev_err(dev, "failed to parse firmware-name property, ret =3D %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to parse firmware-name property\n= "); =20 rproc =3D devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, fw_name, sizeof(*priv)); @@ -1177,10 +1174,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work); =20 ret =3D imx_dsp_rproc_detect_mode(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_detect_mode\n"); =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013016.outbound.protection.outlook.com [52.101.72.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D30347FD3; Tue, 11 Nov 2025 01:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825314; cv=fail; b=lu8zWBqa/BadPoKIPc9sgevkORwgTjXfWVSyhgLDfvAuJSAjDirQs0g+ArI0/JjaB3Kc6SS/di3uQLPt2aEoaiFU88LyWBOjrllGZpz+BHi3OS/9MLE4T0yis8dMrhoWZR+HU2fpvKM083ijIUbzp9StxMUa1RtbBNzDoZAp0QQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825314; c=relaxed/simple; bh=Fq5IvWSmKCviejA/PZJvB+ddjqBumt7WRoqyafXnxBI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=AGZcZ6mPSnFpmIr4T8Hbc35m+cfyAE7/nekLHc3gAHMFQUTnGTwr21Oo7R8K/ejIAgwL1C4NlGUIj03qoXzpNroC0QMWyxwgn3XVl25VAqOQSsb7wVHaLmQ0LprSPFwJUFjCywxrpcZl/hB4wOvRe6T3OzIHFqZcOLbEe5swK2w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=RrKdygFO; arc=fail smtp.client-ip=52.101.72.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="RrKdygFO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NkwKBCR4RRMfT5Nvb4usogPFppwf4qeMbGhvbW80k10zDV1Ugl3ac4eaYMx+iKiWS6w3rjoVEAnh4T+I1JDJmLUJjJFGsiFIN5bNIPwjGvaxgUIbbHlATY+OAhOxYLXE6bJdS8M6YytAvzWoWJEb/Mz/Au2gSvW9req7XPIEramRenoFt68Z+dmc63N2UqqQhqGusb3ktpkFNFea3TK5hyjCRcZiv1MbOqFzWbK9iFCBLpQHVtl5n38N+b2Z5LOtj57wMmvtO1xrdQKTU6nzuFf7NGRW5OLnAVfYYLPEKxW7bkARfilvEe6G3RtFswyN78I/p1h8JCtUwHLoV+k1LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1hZfPcFU0TTXuNLWx4bPXq9j2hRbCP44xdcc8ZXUF1g=; b=dguOfI8O0vbIklY4PKMvlXMJ9ly9l9ABJtgieQsDVdREk9XUmGmPVvJT6+/JiuVjnACnlJ7mB4aomks/5NXy9eX9BfxkMuQcuxJSSE+d66pYpFlkq3j/x0TrW8U3qDPzSdRHy/fcyIKf19E8lE/ezQmstUvvDc94zxQ7C/X7iSWZuqMPL+K9j3Zlq/gE3VtKNdZYB6QcvGKenzS4JaI/w/WwizgcfsoaxzTlVY3xSAWn7rS3x8qh1oULgDaOylLN+zpLfqSzv6+lMXzhTVGnv0ISB2EFKoh0HuSi8EPp3MJG5RAUv0VYWNXCsgs6XtMJWn8hnSpcQuEnggZnYsHcLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hZfPcFU0TTXuNLWx4bPXq9j2hRbCP44xdcc8ZXUF1g=; b=RrKdygFO7Bi3I7tuLVs7yYA9Q7pBKHNPxjeDj/cpy3Tl2Pr3JnsK7/VNy+kU/BxIxOvqt0HOyuASx9O0Mh0MrMPvsvGMExe8hEDTAq8hD14dwLRYhimI90qxQ8nH9KZpdYFit2BUh1k+knfE/ODw5YuBOv55HoW71dlaUdv2e5rglp74iWalk01HCtfNPkoah9fIDQpC3IxFQG0vEom+Ai9SlJFfh7X8OQA6Pj9+drvxLfisJovEaSVBh0XshjA+mRGR5mOv6j7G9jUwDTp7WRolVOlKrUGTZj5/Mwtb0in5oio09kII8F09vkjGIyRfz+CsD9qi5K9TMIXKyHuuwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:51 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:51 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:16 +0800 Subject: [PATCH v3 05/11] remoteproc: imx_dsp_rproc: Drop extra space Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-5-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 70276013-22d8-4aa0-f8aa-08de20c37c53 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U1dXU25BUnBlZE54RkI2ZTN4WXg2Z1R0SzVvc1E5U1BHT1h6MlNHQ01uQVdW?= =?utf-8?B?bXQ1ZFVoTkQwKzZVOTVmc283Rk5PckFPbk5xRjNwdVdjdklJRHJqWXh0alZa?= =?utf-8?B?cE1iL1JXeU1kK2g3enA0MnROTEYxSGFDaHpVNEFVam1oeUd2M3BKSWhwbEZh?= =?utf-8?B?T0h0am8vOWhTT01tQUFScmRIQW16REkyOFBnTk9OQWxmVzNoVnlxM0h1em9q?= =?utf-8?B?YlNocldCdmRZdDdFb2F0T0srbERSckg3L2JmN1dZNHp2QWpNcit6M2VwMEYz?= =?utf-8?B?RGxLVzVMMit5aS9SeTBKdG1VMUs0bkVnN21XbWZ1RFdyQXBzM3dEcTdES0tj?= =?utf-8?B?VkJ0WVRCSkhYc05wRlpCSXNqZENLd0JQOWJETm5OVXc3UUdaWHRJN1hieWVx?= =?utf-8?B?WHQvbmxzd1U5WHM4WEhnOS9uTUZ3RVdhMGs5aDJlbVBCYm93SncrTkpmUUtO?= =?utf-8?B?bDJRUVQ1QXdaZElFTzdoNG9icC9sUzBRanF0NEtyOG9qamdob1c1L3FEWi9Z?= =?utf-8?B?N0hFVndnTE9JS2dlVzN3U29LMFRzbkZIQnF1blZmRUFNbGMzd01LNXV6MUJD?= =?utf-8?B?VWFpd0FQTDdueFAwanc5UTVzcW9uc1FOd3VVd0ZWTGM5SE9HK2tsU2ExeEMx?= =?utf-8?B?MWdaQ21XMHAxRUlQM1REb1dORTl0Uzk4aTVXRElFUGNiQ1BWZEJBRmhOK2ls?= =?utf-8?B?NzVxR3RiNVRHb1MzWmg1b1YrcnlwaXltUnZuMGp0cnAxS1E1ZmpvOVRxR3Z6?= =?utf-8?B?dlJsTVJqQzZ0Y2ZCbDl6QStaWm5yNVZWcWxQL0JSdjBHQUFpc00wSlZoVXdS?= =?utf-8?B?dEJmUFRFMEw0NFd0c1BnRlI1bm5VSDBtWG03YlM2OFAzQ1B4SFZJQ0VzN3VE?= =?utf-8?B?Qm9ocmxMb0pHeTlQNjlaKzhYbnBMTVBHZXBjOXcvQVB5T0RDZmZ0ay9LNm9L?= =?utf-8?B?MndUZzgybWxOdXhHeTlUVDEwdzg4VDlmalFYR3A3TEh3d2t6TjhwdStiUUM0?= =?utf-8?B?MGlZeE1VOFNFQXhxNjBDNEZpa01wMWt2RmZIdUdxM1pxRVVaekVqWnExYytE?= =?utf-8?B?cVhqek5pd0JDdVcrdU8yYWxKSGVCV1NVRGVUU3JIMndDaGRVZE9UeXNKMS81?= =?utf-8?B?dkt2Njhsc3lzVHNxTVdPUU9LTlRQWmo3WUU3OHdSeFhLUGFrSjBwUTBub0py?= =?utf-8?B?VXJoV0dHNmliS2w0TnlDeFdZaFZvTC9SZXV4Qk5UMWFxemQxQ2lXMzV1aXZq?= =?utf-8?B?TVpqWEJRbEZmdVBXQUticWJuekpWcngrWEp3ZTh3RmVZb3ZlSGxoK29SN2pa?= =?utf-8?B?ajlDQUZLVTI2cDE2QlZNVDErRmtQdUVGLzcrQWNpa0JYVCsxNk9lVTc3eFd6?= =?utf-8?B?WUtud1llMUxCRUNNdU9qOWswSlJCZmhUa0xWSlNYQVdESG1qei9qblBZL2Vj?= =?utf-8?B?YUNlSERmY1IzQ0R6aTJSTGNqcUNNNEJRcXpWcXJudkhLQkZJSm9PNS9xcHdX?= =?utf-8?B?dDM0bzh5VEIwUTBMb3RNa21TWWZMSUZhSXUwUDA0K1kwVFc3MFI4UFVXMkls?= =?utf-8?B?ZE9IUnNrTUxrY1RPUi81bHpkcHIzdkxZcEhmcDNZeFFRMys2S21YcGNwWnIv?= =?utf-8?B?ZktoOXE5R1Rxc0cxaVVVMDBxaW82T2tHYnlYTFkrMHpsdWppbzV6WEl4dDR0?= =?utf-8?B?Ymxza3hVTEhRTlRuQ0RYTHN2N3kzTjJMdkc2am9McUVxVXdRcFBoV0JieEhp?= =?utf-8?B?dkdvYjJaRGdFbmxrUzE1MlhsSTIxdG8zR0hWRGd1U3ZabEZvWXZTdUZiT0Nz?= =?utf-8?B?SE10c1BkYXVmNTE5d1lJOUtubHlNZHpqYkVhUVh0R3hKRElKQTFYQkJabVJM?= =?utf-8?B?cDV4SXJlUjVFT2E2M3hqSkZJQ0V4NWpDVFFTdFVDb1BvVFVHZ1hCRW8rV2t3?= =?utf-8?B?Y0hONTlKbWZ5clFpd2FvV3JVZjBsY1VlN21NNGdScThiNnE4cTdFeFQrdXRQ?= =?utf-8?B?L0svZ3JINUhkTlRNdWJxWjNVb1oyT25sK2RvNWgwemg5RlUxTWxiVy9XcVp0?= =?utf-8?Q?gAkBcu?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnNoOTFGRGZuaW9pa0FDUGZUL29LU2ErR2FndUlrMWQwcGdjRTh5MFpnOEgw?= =?utf-8?B?QzZqT3BuWUtSODNtS3pwM0VhWWtpdmMrNjlHQ3J5ZklRTWgxTFNxdU8wRkFi?= =?utf-8?B?R2JOaGxiNjM1Ulk5Q2ViSjR5dUszdHNSQ2g3L0VRRHlqRTRaL3p0UmxJdTJM?= =?utf-8?B?eFJ2dld6RE9GS3hXdXdod0ZZTHJNTUZWVHpkd25qTHhKNk5UbXF0YlpEK29K?= =?utf-8?B?VGY5L3k1YjlVNlRGbXdEcjU3VWFJUkIyeit1QU9qWmgzRTZrQUhlRmFiRkda?= =?utf-8?B?cDU1UVhtenVPWTNMUHd4SURLQTVoTEh1cEVqN2M2UFZPcm5Cc0FLOTNyYnY4?= =?utf-8?B?VERGSC9PYWoraFluVzZRKzBZb21NS0I1TEVMMkNsdnkwaWEyam5IdmgwZFRL?= =?utf-8?B?T3RrNmxrRU1PUTJHd2gxVGtqVE9zdWRSWDhyUzk2SDUzR29QcHdNL2NVbU5K?= =?utf-8?B?dzl5dEtoUDgrbXRjTGlNZldzSXZzN2FKYkV4R3dnT2c4Y3Z5dHBkM1pQSFIy?= =?utf-8?B?aDZDV3IzZFVNTm51U2NPL3RuUFBPVURPSkFEdW5qdWhGYzE1a3JXWTFXV3Z1?= =?utf-8?B?V3MxZGhUcnJGWSszclZzc1YvdE9UR3lSRXI3Q0RvaGs4YUNQYWhLVFRKN1VY?= =?utf-8?B?WFhZL2srTDA5SG42S0s0YlpjRnMraGFROUIvdDB3WjRpK2RyK1Z4cUFQOXVn?= =?utf-8?B?SU1qRXlaVFE2eXpUMUh4YW40VkR1WlJDVjduUWVJUjY3bm04enhOVld6Z3A2?= =?utf-8?B?UVpyWS8yTkVSblcrMVlvcElRSDdIYVhJWVpvSVhDdFpjZVh4MjQ2Nm9zbzJT?= =?utf-8?B?NzJXVVovMFZQWjZhRURYWlRsdEh4QzkxS2V0ano0bE9TUjNzNWRJZmo5QWx2?= =?utf-8?B?b2JnTEtEL2Fkc0dnM2lUNVdBWXZJRGpBYWxUWldERCtVUWpOcDFrNEtEVU8x?= =?utf-8?B?bDdJRnVuRk5pRzdSM0E4SWFLdnBnWGlxaThmL1NXL1I2VysvRmRvZFo1Y2xW?= =?utf-8?B?d3BBejNrcThHZGt1cFcreU91cW9XQVlHSkpTN0FGYUxGVU5sUm95RzNNRlR4?= =?utf-8?B?bXE5RVZHYjVDdS9oWlBsU21QMlhrZ0h0aldwcEpuT1ZQd0NzR1pjRnhwYXh1?= =?utf-8?B?UTV4dlJCMmZoWnR4M2ExcmtZNkxOeTZNU0llMHhiQk5FOWExQUc5Z25Ld05K?= =?utf-8?B?UjFkcGFmbHdwMms2SSs4ZGpXMVh3MTU5TGtVU2Z2c0RVTjBEMEVyTXQvYkJG?= =?utf-8?B?MnVJT1ZEdXJaUjRONUx3UlVSZy8rc2F5Ny9BekpwR2RHeWNyelNPYk05U0dE?= =?utf-8?B?N2diaDk1WUI1eC8vQ3V1Y1BETjFpTkNDSDlMYlh6alNLZDVIYUVUTE5kRm12?= =?utf-8?B?ZWNjR3ZYS3R2eTdvUmNZV1BtdW1FNXEyOFJacFhxSDlRa1c1bW9ZVDNJNis5?= =?utf-8?B?Q0U1cEdIK0orTWdXQ0VLbVZic3dHbjM0b0dGbW9yNi9reEFEWjVob2QwdEVL?= =?utf-8?B?ZGJxdmtLNlpEK3JHOFBvYUFvcGpFeWJCWG1OWTA3QkdXdHZqNVFiWjlWenE4?= =?utf-8?B?WFpjVzJkbW81czY5QWpYU2c3ay9rZWZEYTVqQTN2OW5tMFg3RVJBQS9lSmF3?= =?utf-8?B?Y1pINEQ1OXBJOFdkWTQvZmU2QXhhK084MFNlRTk3amdaL2o4bHFYNy9lQmUr?= =?utf-8?B?dWJnR2pERzVQSUllNWNGVHk2T3hwb1N2c2MvVXBES25ZeitoMmR3aFdMbmls?= =?utf-8?B?dE9JQzRtSERhTllkeHl6cXNlQU1ybGJldmNNTlhIMGhrQVQxWndvbzl6a3h3?= =?utf-8?B?aVpLWWExZHlMZlRWRWJSOVlsb01zcVJQTE1oZFN3Qmd5T1VxZnhiYU9nRG1B?= =?utf-8?B?bXR2MkZNNTJQbm92aXlJQWE2ZHdnK1R4UUZBS3ZybjFEaHRwa1RiSUxSbS9n?= =?utf-8?B?cU41SEdQRTJDTFVVZnNJaVlBVzI4Yy8zMjJIQkhaSTFnTFhaUXhBRnF3bGFi?= =?utf-8?B?YlVkOHdwOG1EcEp6Nmc5ZFh5eEI2ZGlxSjJaWkJrTVorcDNhYktnelM3NHhN?= =?utf-8?B?RVNWWWFDd2ZobC95dHZSRGJ5SXdyQWZONml1WjJRYmYxeEhsUTJOQjZRb3k1?= =?utf-8?Q?Rkw6SP3JF8fRRhdszJLpjzmjS?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70276013-22d8-4aa0-f8aa-08de20c37c53 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:51.1501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wFd8sA97v3D/Ux3Dwq0BlUVAHTfGc9iE9sUG4C9Tw+Elj5inYuFFR3W8O0uxn7D/1bRrSWry8NTcL28yuT+LmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Drop extra space between return and zero. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 87f4a026c05fbf1c9371058290b2d33cb94b9e54..1726aaa1eafb9ac1a913e3e2cae= a73801b86dc09 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -784,7 +784,7 @@ static int imx_dsp_rproc_prepare(struct rproc *rproc) =20 pm_runtime_get_sync(dev); =20 - return 0; + return 0; } =20 /* Unprepare function for rproc_ops */ @@ -792,7 +792,7 @@ static int imx_dsp_rproc_unprepare(struct rproc *rproc) { pm_runtime_put_sync(rproc->dev.parent); =20 - return 0; + return 0; } =20 /* Kick function for rproc_ops */ --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011013.outbound.protection.outlook.com [52.101.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD66347FC0; Tue, 11 Nov 2025 01:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825320; cv=fail; b=f0B+1JzKruBSE9pmNAMEDR30AKizD5rzQd0NcVecmflrFufyxpMvGe0Via4KFeVoFQ6/H+TjIwsE/C8bhQcvIdXMTUWLdt7XuRfTXPB9lX+NgoJGG7GGIpsY2FfE1zFEOiJcrBT1kDUKs2MnfykvikZp04TdQqKOlpcm9bdgo18= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825320; c=relaxed/simple; bh=UOhUAHwHq7YiRbYpE3ZSLm+md8L+fYlfo0TA5OP2kQA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=QKBthktoUMnqs+4Rz3ts+BKToTTBbAIg/UkiUTVwLE6aCpPYtxzxxJuptL+xuFG1wzSGBfr7bTSzYFfDrt0HRjioEsNbRqaT8T4hMye5rfGeQF2Gr93/kfAmv+kbAQd7gzhqQ0MmVDGOeIJH2Ibdkn24SWJ7UMQg7+QkdKNqhqc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ApZ9fm1a; arc=fail smtp.client-ip=52.101.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ApZ9fm1a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HcQP+5KUcXSpOEMSXsepxjrC/StQSZ6FoN37x9og9FtX3n8aFswQd8rPayA4RkBvI+mF0l3v2Dv+vuENoiVU56iGD8pRx6pbInTxqkmqBqoHsi5gZjN7i/oC40JryT4uouXZ8N2qDK8my152qclcK+5lvsqbQHgfibgOrdubi1N35BHD7xcYrgQLw3qexi8mxumwXSK+sJdKKmlMisbjCI+zF2UsbbVlER62EH4cjUP3aCwpRjg9qJLsxRyDb6BdG/jxvZ0bpuTfCRelSsegdL+VqvrczZR/KvqubKRDT0kQNKWPIbK4hr5PpW5ULmgfeVVHYkONIKTcNUlWubv2KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOGdix019KvufUcdeKWPJEJT1GFK9Go8n254/HS6bAU=; b=JKLySOPv1X1L8SwQQ9C0xleXGf89z+QsVSSZ7vIbmkmN3av2/hjyTGgdrtlll6ftDT6GaZlga7I9N3LApMWMJBeMuUBPg1qkqs4a5EjoDXVNrawE8Tda2enGhXJm+DhBT/J6YedXiEztUVRlcYEGLXcB7Eg9y5Sfmo7jlk28S44feIS5kcqvbceIEswWYxgfEF/8d/WFKpSD+AIb78sgbR3AOsTIY7o9IXrH1sZnqYwl194q4QZouTTtLv9jSzs51w94WWhdvMlBDPPWoci74WvLi6SjxbWEL5jB3B/nDlfBWMwETVd++s+ccigHTiTMGwmsXv9i0XQgIUhVXwnWLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DOGdix019KvufUcdeKWPJEJT1GFK9Go8n254/HS6bAU=; b=ApZ9fm1aA7U9fMp7V9fdM8Sfvp3VBibr+m0mUFlQGC1yJaQ7JfPblAYEa6Lz1tURKBflPBckjhP1yp3Nm0i2DXRFFUJZWO3V0C1lrEWHGWFm1LcQHDCg3M3LHhK4a80BrCA5tBduzNlad7TJVIj3EjoPwJGOF/K03T+2iQeYeRbkwnPDfh9puIlbDGYjIoHjpDXAZjr+Jb9VQUX01qGhTSw+nz/msuP3OHwdwrCM8g0+rxDz9uiqF3XDD72bLZw0lerckxpwgo0fvQf561af177NiXHDrMVEwuPMl+BWxBi/j9X3i2Uxbboal/L3mh1hjfAttck+ssoqTvDXvptXpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:55 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:55 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:17 +0800 Subject: [PATCH v3 06/11] remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-6-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Daniel Baluta , Shengjiu Wang , Frank Li X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 126af67f-8fd3-4f65-2fa8-08de20c37eeb X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dEdiYTRsOHdDTUlNMFQrbjR0Qzl3ZFdGdmRFa0tWOE0rMTFBOVIweGRBMVUz?= =?utf-8?B?WGpoSmJzRHdnY2VONDhXR1J1bEJrbmhXNlY2ZU1FN0ozeUtqVE44VTg1dE1E?= =?utf-8?B?OUh2NHc4Z1FMSXk0S2hjWEQvS2l6d08wRVVQRnVMc05qT2Y3SGxMQnRvMGEw?= =?utf-8?B?R0hkNUpueWpmOEFETTZJK2ZTL1lWRjJXRi94ZldSYW53Wmd1eU8ya1JvTHVC?= =?utf-8?B?aXlVZkhQWkhPOUdYZlUraElPa2dvY0JQTmh4aC83T1FneUhPSHBLUllzTjFm?= =?utf-8?B?NzhjU3hvQzRKekZjUDhMQW1keUg1b25QUzEyUnB3cElqb2RpMjJGaEFvQU4w?= =?utf-8?B?ejN2eGx6N0Z0ZmR0Y2ZtT0VTS0ZaNUZXaVRqdHNnSlN4UlRGOXdHbG5tMWdT?= =?utf-8?B?U09tWEQ0aXRoOExBMnZQT2dZN0NoMFhXUVBwNkJKRWExL1E0Y1VsVVpXb0hH?= =?utf-8?B?L3Z5WDlJcEpwcWk5RWIwYkFmdnlNTUNraCtLMHRubFBtVDZzaElkY3FJZStL?= =?utf-8?B?Rm13RjNBNGJPZmpJdWl1bnUxZW1majRxcGZnZE9zbzROVGQ0YTdlaWFiQjY4?= =?utf-8?B?eng0YU1WLzlzMFdOdnNyTCsrZHlwMU5PelJOM21rdk9Wc29vbDhncEc0R203?= =?utf-8?B?c0E1Wk1wY2NDc2I3L2xqMlNxdlQ5ckkxVFlWUlRiWXZTdkY2Tm10YWF6WFNV?= =?utf-8?B?SlZDMnpjcHR4clJ5ZWhxcGN2Zk1IWUpCbmdwZUptRHYrYXd3a2FWVS94RUNS?= =?utf-8?B?eHB0bUJaRXgwcm5Kbk56VjN5Rnphd1dNNm52Q09Zd0NwZ2E4RHlDRXZkbko2?= =?utf-8?B?ekQwbGZtZmxFakZlY1gxV3Y4dkVwOWhUUnUzK0g2L0FtajJYTERXVUZDUUMw?= =?utf-8?B?L3RyM3NyUTZzTEs1aXE0Q3ZjRlZGYlQ1RjhaeVp3czg0U3FFdnFESjdTaVht?= =?utf-8?B?V0VwTEY1enovS2VFOFk0Vy9Ud3ltdWJhQURJYW81czNUU3NtWGRsQmNzV2lP?= =?utf-8?B?MlA0a3lQTXZ1c1B4TjdCcXBwMFErZ2djK3FIcXd0aXI4NXg4KzJ4NWdVaU9P?= =?utf-8?B?Q2VLZGx3bHhJZWlIMlNJNU5Ud1dydE1ycHNuRVhkTTA5S2VuRk16QklYYU02?= =?utf-8?B?NlZLNUZvOHlrQW9LNFRoMFRmaFhvN3N5Tk9na1JxRnFSUFNEYThtemhzZ1I4?= =?utf-8?B?TU9ka3BKZm1oMmh4ZVJXUVNaRjl5UGNuYThzMS9DcXBZWlhGZnpyelBvVlhJ?= =?utf-8?B?YTF6NzRodVBCczY3VVVRc3dJNjlWS1BHZWxwSUlvemJEbVY5VWdyQ0ZxVkFo?= =?utf-8?B?amdCZHB3ZjBIMjd5N2tVZ2N5c0tDbTBlUTZXKzlQaFpUR0VtNmFGTHk4TDY4?= =?utf-8?B?NU9SK1o2cEVmOFhWaXZXVnhrYTlUNitSYW9VcU94TnB4cHAzeWRkYURnOEVP?= =?utf-8?B?RUZVdGUyZStOZnlQUUU2T1ZiSjlWL2JWb2pETC9QQWJaTTRnRHd2TWRNbkpN?= =?utf-8?B?ZDhpT0RDUS9WZTZhNzhscVNRL3dxdTNlejIvYjZqN2pzZTJWUjQrdGg1eXlX?= =?utf-8?B?THNKR29sWGgyUS9YTmk4TXh5SVdnb054b3I5bjJRbkNXa3VoaHdvZ09yemdI?= =?utf-8?B?cUh1VGxXVzhlVXVicVp2VHh2cVNTZFdMb2JQNGhmaUt1cld0aGNic3FSeXQw?= =?utf-8?B?RmZER2lLWnNsUmNnNVRZSjM3Z1ZwR1JQS0JZRDBZNXNaQ1lIZkxObkp0N0VE?= =?utf-8?B?eEV1Mm1nd3JuRHFaNCttQlVBcm5JRDBWVC93V1JNUEI0d1ZSc3JBY3A0eTZN?= =?utf-8?B?T1NFbUlkcFNNUVcydjQxQUNYUXBDb1drL2FjYUpBU1VQWGhPdVRzSXBGeUlx?= =?utf-8?B?cDhNaWh3cEFtb1FuTEFJYnZJS1NkbWd5UnMzSEd6WGR5WUx4UEZPQU55QnFV?= =?utf-8?B?aldHS0pLalM3TFhnbE14UVdrMHprQmgzQUhMbWNCVEM5bGtUMUlLRUJtWDFY?= =?utf-8?B?UGtFc1J0bUErU2RKS1F2V0pwY2loR1N3NVFoU2RvaEJoalpqMnRxMElFWUN0?= =?utf-8?Q?WJ/r2V?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGV5aTZJTUg0SUhvQUJmam9vaWZKSmdEMDV4L29tc1oyb0lGTDNGVERCdlJP?= =?utf-8?B?RTI4bDRvQWZtYklxT0krc2RwcE1wZEtackpHNXl3KzNha3FHcjk4aEJWUC9L?= =?utf-8?B?bG81Zko2VVJwWFF3N0xybVV0Z3JmYm15UU1zYzdHZlZQY2dFN09YQXJJOVhQ?= =?utf-8?B?aGtteDc3eng0M1BRYWJ0QzV6L3N5QVN6NGRMVk45QjB4UklMZmV4L3NUdnEw?= =?utf-8?B?T3Z0cEw2amc0NnNzODc3M3JqL3pVZDU2bEdHZ1dBV1VadmZIcDVHL3RickhM?= =?utf-8?B?QjNWaENyamhSVDlFSFh2elArZ3NrL1BjS1VWUXEvU2FZTkFuRkJ5citQYU0w?= =?utf-8?B?Ykp1d0ZURFFmclMxQnhBc3lNREhPUDZmZVZVZHBZR004alQ2Y1NPTExZUk9G?= =?utf-8?B?U3Z5VzRuM1R4UDNvTzhraHpuQTl6eW1Wc3hBeWZYVFNSMFlVUkgzZDJkdXJG?= =?utf-8?B?blE4dzd4V3AzWk9Yc3JxdW13VlhMQWtwckhlWkc1VDRzeExBNCtNTnVFdStQ?= =?utf-8?B?Y2UxTU1MQXBVWW5xbklhOCtYTG41a1RyVmJYMVNlakdnUzBkZnRoZ2pJSVFD?= =?utf-8?B?MGRmeUxGT2Z1bVpCbW5qSFZpZTIxclU2d0x1eTBleTl5ZGV1NzlzV2dkZUVS?= =?utf-8?B?U2lHMzFxaXBEclV3WHcrRExiT2w5ZHp4aE1IVjRCK3dsK2dxVEhhQXVQYVp6?= =?utf-8?B?QWYxanhObkZ0UERTUEUyekxRRmthS0FEZXVqV1g1Ulo3eHMwV25wbEVFY3VM?= =?utf-8?B?Mks1OVdiQk5xbjdwMUhrVDExMHZBeS9LUWd6OE9CSnhqbGpTQnpHWUdla2ti?= =?utf-8?B?TWFyVnIvbG9BNG9GYktOaUQwNGhCbmlqWXVaQnBLaHErMDgwK3NzTndCVTBY?= =?utf-8?B?ZjB1c0xHcFR2YzZCTVd0TW40VlNvUzVjYjdNT1YycmVqK1MzUHZVSmJpcjBV?= =?utf-8?B?QUx5dlpIUnlYM3pZRmRSYmVIaTh4TzRzY1hVSDJ3MVJ1TjRQNURUbE1RMys2?= =?utf-8?B?V1hUcEhjR3REQVFwTGV4eGdWRFBXdEREN2g4RGNBSG5TMHpqbk8xZnArNXJ1?= =?utf-8?B?NGdZZURSR2s4aUM1KzF3T1JYTklxMlRvZWtDd0pWNXJaYXp3alNtR2d4WlNW?= =?utf-8?B?RUFyMEJmYkV5ZUg5UjMvU0wwbUpmL1MxdENMOXR1dEVrSERmc0RTSDZyay9V?= =?utf-8?B?WUZHazlDK0hOUzAreWJlNys0WjVwdXR3UmVFd1VlOXVLYWRjem1ITUlvR0Vn?= =?utf-8?B?WmQxMlM2RE5DOXJLOHVjbHBVNkNabzJIU1NiR0ZKQTRnbUR6VUFKUXU4bTVm?= =?utf-8?B?ZFEwZTljQ1NiUE03NlJkSjd1RnNuVXYyZVlNZGt3WHN4TnA3azBOKy9NWEJC?= =?utf-8?B?YmtDS3R6VklkM3pJUEExMG0rM1BPRnIzcXIvR0o2d29oMmgxV3B2VFRwK2Vp?= =?utf-8?B?MERKVXp0N1d4bkNUZkpQSWdFUklwbEJSS3g2ZmdoOW5hNE9vSkJVWE5KU1Zh?= =?utf-8?B?dlZTTE90ZHBxc1VrSkxhZzlvQmJsK21PZ2xxazFtT2xSeDJabDdUbVowMTVy?= =?utf-8?B?NUVabURFdXNrMGR1c3k3eGl5Y0duS01uQW9iMUhKTHdKNEJvZHd2dFlCMHEy?= =?utf-8?B?U3pNVTBMNHVxTFp0bys4TC9pQU05b0JQTm9GeHNJVWhUdURTVS91UlgyOUlQ?= =?utf-8?B?REVtdFBxRFRrOWhPU2RRR3d6SC96QWtteGgrUFNLbUpkd2M5SDgrUjFFRCtq?= =?utf-8?B?NUJ0TkprVU1lMGRhYWZjMEtjQ0dZRlFrQXlnaTY0Z0RzN09GS3hEd0l4cWlT?= =?utf-8?B?dEhUZjdoR0RZd095NjVlc3FNK1BBN3crODZDbGVjSnlaOUcyLzFGU1lOUENv?= =?utf-8?B?Y2ptSm91ai9UN3R4THJCdVBBZ2ROZkdhMko1Wko4RFpFRmVXTCtHc0p6SW8x?= =?utf-8?B?aCtDVmZxRi9BVFVaQXpCTVV3dTZ2Tmt6QmhRZ1ZPVlZpREJ2b0FXWUNwVGhX?= =?utf-8?B?d2piM3U5ODF0OVRZeVh0djdPcUM1M0JOWTRmRGdYTzVRa1hVenFHc0NUWEh4?= =?utf-8?B?M0lnMWpkcW9JZDUyLzJWbm1MKzVvN2YvampBZUtwT1RNcWRHOEFja1FpaWlJ?= =?utf-8?Q?QXG2k7BE/PMMKYg6z9LJdIIKO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 126af67f-8fd3-4f65-2fa8-08de20c37eeb X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:55.4579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TaIE82tMtJIqCHPoyL+vlqTksdNBr9uc/xdi0ORGexAOcqrxi5F4z0nYiUrXxu/YiYXJCWoakQ5fhoicMggdQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Allow each platform to provide its own implementation of start/stop/ detect_mode operations, and prepare to eliminate the need for multiple switch-case statements. Improve code readability and maintainability by encapsulating platform-specific behavior. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 1726aaa1eafb9ac1a913e3e2caea73801b86dc09..833b1bd4019614157f0bedf09bd= 348caab802eef 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -404,6 +404,11 @@ static int imx_dsp_rproc_start(struct rproc *rproc) struct device *dev =3D rproc->dev.parent; int ret; =20 + if (dcfg->ops && dcfg->ops->start) { + ret =3D dcfg->ops->start(rproc); + goto start_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, @@ -424,6 +429,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return -EOPNOTSUPP; } =20 +start_ret: if (ret) dev_err(dev, "Failed to enable remote core!\n"); else if (priv->flags & WAIT_FW_READY) @@ -449,6 +455,11 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return 0; } =20 + if (dcfg->ops && dcfg->ops->stop) { + ret =3D dcfg->ops->stop(rproc); + goto stop_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, @@ -467,6 +478,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return -EOPNOTSUPP; } =20 +stop_ret: if (ret) dev_err(dev, "Failed to stop remote core\n"); else @@ -1085,10 +1097,14 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp= _rproc *priv) static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; struct regmap *regmap; int ret =3D 0; =20 + if (dcfg->ops && dcfg->ops->detect_mode) + return dcfg->ops->detect_mode(priv->rproc); + switch (dsp_dcfg->dcfg->method) { case IMX_RPROC_SCU_API: ret =3D imx_scu_get_handle(&priv->ipc_handle); --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F88C34889B; Tue, 11 Nov 2025 01:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825324; cv=fail; b=aZ/0Dd7qwRFUzNyEyupAV3GWIIuYT6YpQjaAQ5lAjKzadnf9LRgLIoQ7IG7DfmbG0X3Hlbs9ecC17604Ja51mCVubUcxYX6BCm/C4vLBB6Wd8lKCsJ2V2H4QBpuzzIg1WdOJPnep9QA2USeSuAbvr35RdD+0uzNTdFQ2cHNlGzU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825324; c=relaxed/simple; bh=KCk9mh7/uWYK2DCvZ111I9yYzTE/Qx7N0VfajvOhA1I=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pdpDBMHcbw00a7WYodqg5QLXDCqHiGl06MPlavqG6oB7/siX/DJGluy5N7uxwB1ANgz9RWR+neXzXsFC0lU7lq23jSkcx2R+07kfmVNEwgEQXN8JPVpajuW6psMG4JUaYtIZztdvK8njcfOe6Kc6KcLAor7r1Q4IQPHKzf14Lpc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=rKbZsZlA; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="rKbZsZlA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZRihuABj7sOPaQQiMk11eo0UnlY7e7ILJkRanZTSw+aYnDuRiYv0xM2Lbo/2XLgPjAu/aJVfG7jPyJugyXxbJvjC7fhdvaTbUsbAFv3eFcITvQH19xWxjez8f+k3BHVHLr5GxzlQHkmhA+WevvYry62ljx4qpBL6qZqWu1byzjHf4EqRudi7wfMdjv/pr3vXV5U2gSSj3OOKCz70qKyrDAWcnNPbd3TrAOOF25CvGd/utxCc27yfUM0h2dMqRe7mn2EPaFDgEQ0EV1tBtmKOyLYmaXALVSKtJ6v/UCb/s51vOOlPC1Y+e/JgwSxnzsAzaaMRInFcTgUmLrKLyC0nkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D7oZrjjFQjLTk5G2jMvxwb2d2bcKT2Xztpz9wSQiML8=; b=BG/NODGVVvZIRxRqsxEBijRNQD3ASYR06rNFA2LkJFG6m5tvjxbYnOTOAShmU9/WVSEX9g+pfksGKAHcTtTg0nW8+oqIAoGX8S+OGbJjscTG9HC6wXh7hTR8XBTiBur/d1FnwU94wAxTZwWr5Xt4tJ1EcAVoUjqzoghEi2Fs0nXgkF95cRbhusjmIH1qvs/1KTZHkLmAu33B0s45uDRy2oZtlKoX3jA2xx3q/M+zo/VvCOFwIHTwsbFj8E7rlprEfH3xm+tbm5ema4XH40wggZGt3LGXO+3dPa2sMPJPp8zdok43mnrvATpj9+kuRaZYJN6nGdV09IuOFRrfHCeHbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D7oZrjjFQjLTk5G2jMvxwb2d2bcKT2Xztpz9wSQiML8=; b=rKbZsZlA4gQ2A4Eg+c1aIeQqLPDRla3Sm/ZIr5rzUjuOMRg7eNJh99oONVfODzBY2O3T7kiqLj9bHGT9h2xOA0rebGoHPr4/h2KDt9v/Q/ATurStpngGzQaSl/rWEnU3BJxp4EjHq88T8KhQGFLY++i5y0rfZOqV341q6wHjgKV9N4LOWvbcoH1Yp0md9twK9zafkUNGzt1tFvXTZaSRC9yVmgM5a7bwCsQt1ayABeZu2pEir2ePkG1Sgb8b4WXWrh2asUGvWS1ZAITRyj/YbScV57WSMuue33hkW3XWM15BfjuKuAzOX2+q+NGfiQiIqB4w2IHdnR07GZMQ8JAhtA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:41:59 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:41:59 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:18 +0800 Subject: [PATCH v3 07/11] remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-7-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: fc0db1d6-0a67-47d7-8597-08de20c3817e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bk1xMFNWdXZmWnFncVZIMlFFbFN5QWRab1V0eStMeGYzUUpUNVhxWXdwTVpZ?= =?utf-8?B?WTlYZzBDR1o2MVoyTUo2amw5THFvMVF1QjVXL3g1QU5jTlluaG84bW15M0ZV?= =?utf-8?B?cHhLYjdGVkNMOVRzUkd5M3hmZ294K0FZMHExNTMzQ0c0VW1maEtVME8yMFRh?= =?utf-8?B?WExMcGxoNjBpUWxmaTAra3pJcUloM3JuanpnSDNwRVpoOXJ3Rk54QTVZL3dG?= =?utf-8?B?bVJJeURJWTFrdzhuODB6THprWFhYVUF4UmVnRHVPcllXbm4wdU9QY3YybDZu?= =?utf-8?B?dkVZOU03TklqazlOQkR1SGl4UlhxeFAxNjRXMjRlNFBtbmJPK0lTb2FZb1I2?= =?utf-8?B?Nkp0aFAybVFHeFo3NHd1a1ZYV1F6RCtmQTlVOVkxNkFPUHkrUnphVG0xcVpH?= =?utf-8?B?N0tpbTh1MHhVTzZyV0RlbG1nSyttMmVReFp0bkd4c0dmTHJOQXBqaUMzMEpu?= =?utf-8?B?bU03Y0F1YWxmbHpXdk9VVmJnbjdkOWVTZW15QjhNT2hDaE5TSi9HSzdPbW9y?= =?utf-8?B?RE5LcjVGeWxxWjk0VUR5bndNRWtUbzV4dW1EaHk4UkppOEZzK04vUHMxNHJJ?= =?utf-8?B?cWQ1bnF6ZHUvK0pOcFFEVkxvY1JWVjN4M3VzcmZDTDJRcEh1eGlHc1RGTUxl?= =?utf-8?B?VHkrcVRJWWxXNlNlbTVJYStXaW5xK21RSzN4TVRLMXUvVUM4WjRCQ0gyU2Fk?= =?utf-8?B?V1IrZ1pjMmdnMDc4aU5RS0ROeURtQXhrTWVxKzRjZUd0b1VFaDZsMDlqM3V2?= =?utf-8?B?Y3RGWlE4dE0vcnZia3NwcU5lcVMzcDgybVlFSkUzbkRKY0NhOCt4Ujk5NEtQ?= =?utf-8?B?K1lFcjhKc2xUR3N6RHZGUTl5ODJLa1BEaEVYbWNJSXhCM21MMmgzYldjOUhy?= =?utf-8?B?eThyU3FVSk1UMTFMZTBsbGplTTVuUzVlYlBDaUNYaDNDY3pJWWZCakVKOFVN?= =?utf-8?B?WmloUWV4SGRCUkFVSk5zR2o1a01qeGVTWnBQQ0xMemJNdGVYbmFNVUE4SDV0?= =?utf-8?B?Y3Z0b1VpU1h5YnRxTWVndTRFZ3JVcjZKK3pOMVNYQ2dkWUpEQ3ZTZlN2VFRU?= =?utf-8?B?NERMYm1RUDZ3UHhoMVFWS255eHhqenRPcFR2WllCRmY5eFJablRwTmo4Rkkz?= =?utf-8?B?RC9qTTd3Y0Ivakx2Z2FFLzYyRVVRWjMreTc2VGhKeXZZR24zMmFKcm5tZU5K?= =?utf-8?B?eTJUUW42UUhNV2NUV3MwLzJ1QlZrUno3L3B1OER1dTlxYkFZUEhCRURXSGNO?= =?utf-8?B?V09PWnB0RTdKSEZocmZlb0RWeVM1S0MyMnVTTEQ0YkpkYmpQQlUvWDlqU1Zv?= =?utf-8?B?clUwM1VONHN1SkVBQ0ZHdEdDdUtKRFNWR091UUp0Rzk3RXBnTVB5ZC9Jc2hU?= =?utf-8?B?ZVA1TFd2Kzd2NXJzVEVHRkhzTngxL0d4ZExrWHJLUCtjMFR5UU14UkJYRGd4?= =?utf-8?B?ZHd3aS8xMDJtRy9sVGI3eHRrb0xIbHRtOEZnTWRhQlNEbldYKzVGUUVJU0ZD?= =?utf-8?B?d1JOT1ZDS3J0NDJuRW1kR200dnVPVkdLNDd6aHkwTHNjOXpkcXRtQ1lBcHlr?= =?utf-8?B?RGI5Ni9FaTk4ZWJjb2VUUmpLSE1aY1pLRlJKVGNJVFh3RDZzZDVVMmlDc2xl?= =?utf-8?B?dmZWMEtrWkNlTmpCL09LWmR5SWNiU3RQRmJaMCtKblRremZWYkcvTmJ1aEJa?= =?utf-8?B?M3hERm1US1EzaERrT2pXWU5od3lVWkczMSs3bkE4RDlHRWc2aTg1aWNITWVE?= =?utf-8?B?TWFXT1gwQUpJdW9uQStvOXhrRGJCSkh2M1ljS3I4MW0xaHhZek05bnVHdzQx?= =?utf-8?B?SEhDWTlqeDlFQzMyeWxsWGNLQXNvcFc2K20xc01xZFAyQ2E5L2MxWWZINDYv?= =?utf-8?B?aytBaGc0YWxjenUvbjNtNGViNnpETnhPSlJCNS82emt6M3JMeGlsbUlLVHR2?= =?utf-8?B?MHVJdVF5dUxCa0hYVjFBd3hoaFlFeHNRSlBpVzBoNDYxNmVuRS9uZUdrcTVB?= =?utf-8?B?M0tKb0UrNEQ3VmdwV2c2aVlLdUJxcjVaTElMbm1pUVNlcUJVNUhiWHdISjJq?= =?utf-8?Q?08eb01?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0VyNWt0U2ZvY2pUVVkrYXJXVEU2dmw1aENZSFVLODlaY0p3bmZidURLLzBJ?= =?utf-8?B?ZDVBSjZNVVoyek56MERLNlJxclorNTc5dnJLbFgrQlo1MGN6NTBjU0QxRGFY?= =?utf-8?B?d2FRNE5nL2JJOE50Qy8xUko5Yi9UVzcxcGZjTFRGeXlxc25YT3dDNytodGZu?= =?utf-8?B?bE4yczhGRXR2OHVOejMvUDVEK1FpRjNDdFRvbDJQMHBPYXRlWnUyekFaeFNh?= =?utf-8?B?UDYzSkY3YU95SmtYWE5rT0ladGVURzIxVEVPOFEwU2ppOHB0VHRBNVkvNzA1?= =?utf-8?B?bERTU1JKMlpPOGV5MjR0bUJKZk1FVjZTR29WNDE2UHRFYUhzOE5RUmhnUWxB?= =?utf-8?B?QVN5V1d0VGJsRVphdVpWZW9oYXhHdTFzTHhzbmlHbkV0dWRnaitIdlZyN29M?= =?utf-8?B?aVlvYTkzd2RWV2h6WUdTbWlLWHhvK0RIaVhyc3M1dGxOV244djdBaGZNbUJk?= =?utf-8?B?aXZreDZvWjZ6bkFHSy9IaFk3Rm9MaW5WdHVrRU92VDNGL29hSzk5YnZ1cWxO?= =?utf-8?B?Z0laQklhZjBkaXJrU3hSUkFkdmxqZVlBZUNCZ3hqSzk3eEtKYjluZFpuWkFh?= =?utf-8?B?VnBkVU5VMWRLMTJXMy8rWnlMejhQMFBBMkxNcGI5NGlDY1kvbksrWmo4UExO?= =?utf-8?B?YUVJKzF4NGdUMnVlL0NpNjVPTDZzN1JzQnkzeU1LTjlmY05yZC84R0dML1o1?= =?utf-8?B?SDhXMEI1aWpHVHg3VHhHTmhmK3RCUjJ4RWtxMVZJQy9lSnhkWlVyZk9ZN3Vj?= =?utf-8?B?VXRtRmVzR25TVlNjVlFlZzhjbjYvRHg2T0ZKWk9DRHRnWndKT1pmUG11V1Vk?= =?utf-8?B?dDdicllXYUxNbzdpcUVlVmN2UGY2c25pQit6QytJcm9zSlA5RDZsOWhrbHlN?= =?utf-8?B?UDZMbjVlTlN5S2hxVnFqaUl1ZnVZN01BTmNTUnRiQkZlS2RtTlNiNWdHNWxD?= =?utf-8?B?ekpOWi9ybENIUktVUHZONUp2WGdqY2Qrc2tDcDhvaW9McTJObU5DSHM3TmJE?= =?utf-8?B?ZUNjQ1JNR25OUlU5VE1WSXQ3WmJpbTcvRm9ocGx4OEpvUkZnbzRYTHg1WjZ3?= =?utf-8?B?NlR4eXE2anhYTWpnK3RLcDBEWWpnYWpMRjlQSi9lMXRQTWZzTGI5RXR0dXAx?= =?utf-8?B?cTZkRFp3M0p1VmxvVjQvandZRExnWkpsSGg4S1B1aFdVb1BwMlFySDFvRzg2?= =?utf-8?B?WnRCOW5BQkdxZUYwUExDK0RtcnBXTWxXMUJFK1RWL1ZKMms1R24vVm83aXNS?= =?utf-8?B?NndIL3lyWXFRRTVmNTh1K2JEd2w4WnorVVo0OGVnQUlXankwbFljNlFqaDhY?= =?utf-8?B?ek82c0t6NEtWVVY3Y1V1UVI1clhmRTJDZWMyNWQwMUYvOWpwRnBRQzVMNVpW?= =?utf-8?B?dldjN1Z4cVFGS05nVTNxVUdhN2ZHQmp0RHJPSFBEeEhSa1YyeUI1Q0NkSTRq?= =?utf-8?B?MkhQZStzckRjMXJ3eGJ3UVZaTWRNcmJ6TkUrWWpiMGhYeExuUG05bVZLcmdx?= =?utf-8?B?OVJ5dERiVThtbCsyZTNHUm5QSEk2Q3crNTdrMUxDVDRqeGJEeG5NZHhHRWlj?= =?utf-8?B?L0VONXE2dFFFOHo1cy9DRWpCUFVLWFpEeStMTERmMGdhci9WTHMzby81Nzkx?= =?utf-8?B?UjhlUElaVlJwR1N1SE10dHl5Ylg2dU5FV3lvZiszcjJ1Rk03enNDQ2ppdzRn?= =?utf-8?B?WHU1bm16WW9wMkcyTjFGWEpxVDM0MVB6MUwxRnJzdGZCdWE1T2NxY0xScFZy?= =?utf-8?B?UVI1dENoTTYvT1JQMnpXYVlZVXBEQTNZWk1sQ09NWHZKak0zUHQwZTN3Z3l3?= =?utf-8?B?MVpQUlV5SWs2UDZVWjBFc0xKdWx5Y1RZWXI0eGFRVDQveHJtRUhOUmpWc0lS?= =?utf-8?B?cEpvVHl2clFRdlZBU0FoSlRhK3JCSDdNMHBFZUZ2VzFtVVRPTXRwR1BxNjBn?= =?utf-8?B?UlhsSTRKKzZVYk9YM2FoVHlvc0dqREIxTDVJTlEvcStjZS9MTkY1NGpqOWJk?= =?utf-8?B?NUtCeVE3cGlRbmZ6SnY4V00rUnBGV1FBQXUvVlBzYzNiR2JVVk1ZM2VjZ3Ex?= =?utf-8?B?UFdSb2VRZ0RVV3BRbmRTQktadHF3TnpvblhoMWxmSkM1TGd4Z0tSd2d1WVgx?= =?utf-8?Q?2Hg5IhUhE1BNn2kf6pkl/6pP2?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc0db1d6-0a67-47d7-8597-08de20c3817e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:41:59.8104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fbKxxhzNKb2d2ImVtwLggn3SExkCcKi0W50Wnl/v3dtI3vY4BNgKZr9gBdXbeZ3pzVtal5SAPdm9eAmBswsTQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Move the imx_dsp_rproc_dcfg structure definitions closer to imx_dsp_rproc_of_match to prepare for adding start/stop/detect_mode ops for each i.MX variant. Avoids the need to declare function prototypes such as 'static int imx_dsp_rproc_mbox_init(struct imx_dsp_rproc *priv)' at the beginning of the file, improving code organization and readability. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 100 ++++++++++++++++++---------------= ---- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 833b1bd4019614157f0bedf09bd348caab802eef..f28d25cab3f1d89e5cde37a04b5= 28870a59abeed 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -261,56 +261,6 @@ static int imx8ulp_dsp_reset(struct imx_dsp_rproc *pri= v) return 0; } =20 -/* Specific configuration for i.MX8MP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { - .att =3D imx_dsp_rproc_att_imx8mp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8mp, - .reset =3D imx8mp_dsp_reset, -}; - -/* Specific configuration for i.MX8ULP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { - .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, - .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .src_start =3D 0, - .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .att =3D imx_dsp_rproc_att_imx8ulp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8ulp, - .reset =3D imx8ulp_dsp_reset, -}; - -/* Specific configuration for i.MX8QXP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { - .att =3D imx_dsp_rproc_att_imx8qxp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qxp, -}; - -/* Specific configuration for i.MX8QM */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { - .att =3D imx_dsp_rproc_att_imx8qm, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qm, -}; - static int imx_dsp_rproc_ready(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1351,6 +1301,56 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +/* Specific configuration for i.MX8MP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { + .att =3D imx_dsp_rproc_att_imx8mp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), + .method =3D IMX_RPROC_RESET_CONTROLLER, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8mp, + .reset =3D imx8mp_dsp_reset, +}; + +/* Specific configuration for i.MX8ULP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { + .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, + .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .src_start =3D 0, + .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .att =3D imx_dsp_rproc_att_imx8ulp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), + .method =3D IMX_RPROC_MMIO, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8ulp, + .reset =3D imx8ulp_dsp_reset, +}; + +/* Specific configuration for i.MX8QXP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { + .att =3D imx_dsp_rproc_att_imx8qxp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qxp, +}; + +/* Specific configuration for i.MX8QM */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { + .att =3D imx_dsp_rproc_att_imx8qm, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qm, +}; + static const struct of_device_id imx_dsp_rproc_of_match[] =3D { { .compatible =3D "fsl,imx8qxp-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= xp }, { .compatible =3D "fsl,imx8qm-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= m }, --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012010.outbound.protection.outlook.com [52.101.66.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D5E34A3B0; Tue, 11 Nov 2025 01:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825330; cv=fail; b=IrkWqqG/4Ttxkalf2RBEi+9ALFxCCQ/WLl7s7Gp80GHoE4somFe01FHhiTYqiN3raSXhL5QONUauZUi0UFP6C2wnXFH5SCFzxnjzvJsxHe1PMj4zOp06oDR/tgkIrYIJ0r/Ov6j6tQwPRV9j5ghHwaxhAEE5Z7onL+3WNRoRPWE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825330; c=relaxed/simple; bh=3skxHG5eTvTfqhxA6se84MamT3XZ6yUVVsdpc9To+cI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=D/B3/uPU1kKUNIeIYe1Ob+8zCrNbYhfmTN3At60S+lXDNJScNmYNsdIui6RKvlyNICtyvdJLRp4UJSy6QiExeI8c33ShdZuvCq51qZAQPQkv9UWmMFRDcPbK/Kq7Z3e1kTSfSvJyQ5RmgGlYofQjGI9cLiLDuSFoVeGkfmErKvo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=CA8mcEFI; arc=fail smtp.client-ip=52.101.66.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="CA8mcEFI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LAD66I91SABbqQcsGrwXDh0KCF9c/oHoIs2gzK2+VR3/XXSumuyRlVRaClG3atDyhtu4OcFpcfk8nR2Ag5Q931R8Y1jtpUNoRffB1f54b2Fd2u6N62DLj0+QIpX3FJZj4pVETIo+E8OqrYvTQe/9FWy/gfEZJ1yQPtAeI5+juFItxPl6GV5A/pluSYD9JFI5LS+ypiBCapi2L7RvQTkxpqnx1Ebv7qDJ+IWLhPS6tk8LIdAaGRCdP32nc0nyMDZllssvJYsbzm7Jtmh8wVIiAq5ClJO5LbE+Pd1w+Jq9foBKQZPU8zA5uzOG1oLnNExt9hP4yj59A9PTMx8vAxyH8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qdEbKpQBjO6zYQ4fL7uDVaCSR0keCG4Jka1GdP0gWHg=; b=ZM/vQf9kHbIuDy5AXNmkuYhGIj0KTQ+485QGkeR6odJi4MGY5rpCpwSLYGkHp+OwdxodU5oUcZCVeZRptVWCSoQSRX9HlPkfwptZH+WmNoIC11FLIa17s/0zmIx0gpGudLjbfhDF13sVtyMC1LvJIVN7/Zi3h+kX971xeYzu9kWt9Jzd8H0WYX6szcLS51jp7XvL2NoDXeVrFGmiU6RWmIyta8jgT6y4huYCVlrBoBag7agKalVAM9+gJJIdqrWCHsBGWqJ5dmhxW3eTtGpRDVCB0JZkthw2IAqnh42DnmnALWgsyd1m0x3HZJph1tDC1kT8eJPJcEjZm1DLXC6HLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qdEbKpQBjO6zYQ4fL7uDVaCSR0keCG4Jka1GdP0gWHg=; b=CA8mcEFIRLyq4BqrixE9rFWMikc5x0wZe1FLhRB10x08v5LuI0A0X7GJDbCW6qM/yGJITv+gyCj+O69VB1TnGPe4/1CRoF8Dkfa5Kw0NrpDnHRLo3Y6AmbPWhgM/ixfVyPd9AIjGEbMMtxo8WZjE7dKrAcr3sXLP4BltgYGRk2fe+nT0OTzf2W6Er+0dEGtmleQj91OrZbwsRrjoBLoMpnpvOExFXvrI5MMJwHQu5QhMU6K4JOwrzcis6pUVzOFpvy3uw0YjXGENvL7t+FNUDoNJlWfl1wOnDml+r5+ds7p5lYNU4oo0cR3py3J7Chk5riJbfu51shS2WDnm0FSCIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:42:04 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:42:04 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:19 +0800 Subject: [PATCH v3 08/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-8-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Daniel Baluta , Shengjiu Wang , Frank Li X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dd9b37d-b843-47aa-4d10-08de20c38414 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SDF4RGVSNTI2RzBDLzdVR3cxUElKS0dneWhXTFd4L3ZZb0d1KzA4bU5aZGxY?= =?utf-8?B?N3NWWEVRekk1R2FPdi90c1BzVUZYeHlTNGQ3UXFTN0pGOEFxL0krcEhjMlpq?= =?utf-8?B?WHcrcVpLODlpTExNdGltZVFhTTc5MUZBc20xVFlLWUNUS2RXS3BXaEd1bmRo?= =?utf-8?B?aUIzdVVXNWs0a1RuWjlZMzBiNWhtelZXTnVFWnI4UzhJdHgyakhRSnR0M0VW?= =?utf-8?B?SlRwb1VMNzh2M2tuaCtrNkRaNk51Tm40bjkweDl5YUlFT2txM1U2K1ZzMUN4?= =?utf-8?B?MlpIVTBLcGxtZXVhNjdGYlhjRG1oS0o2TUE4dHhGOEFnYlhUVFNoQ2t3UC95?= =?utf-8?B?Q0VWTGZFSC90djk4QjZXbW5ZK0VJYmNWQkRiMW9ramNORERyTjlmQ3hTLzMw?= =?utf-8?B?YnBrTWpNZVlxWlRSZmh1Z2VWYVdLVXVaa3dNU0RsMjUxOUpJdHlwN1JaaXFn?= =?utf-8?B?c3JVY2JlUUpaUkREaDhEYjdKdnBEMWcxN2xrbHlpTGNLeWJTT0lJQWxSeEds?= =?utf-8?B?QnV3U3BZenlrVzh5cXlEZUxCbEZTQmdvYTNHL0pSSk9XQXpDQXFZbTJtL3dD?= =?utf-8?B?M2NKb0ZMVXo3QzhWU3paNm01SnhUcDBIblZiV1NpZjFMQ3FpOHJ0OWEwMG5u?= =?utf-8?B?L3FxWHhDTG9QcVEwY1VXcENPR2dNeWxLZEQ2TkdzNk1IZFJBRllpcnUycEJx?= =?utf-8?B?UVdvU2JZbnJhWUc4Y3hwb1lwUGQzYzh5L1RSRzlaRi82UWNaYUp4a1dhUUlT?= =?utf-8?B?WGduWDdRYmJoWXJNK0N0dUthTGYxL3RLRmwyaWc3QnV2Zk9YSXIydmRnVjJM?= =?utf-8?B?cVJnODRkK01KdU5mTk5LUW1PdE1tWHdBYlNaSVA3YkxrNm1mZmtQNlRPY0hu?= =?utf-8?B?NW5Cajh1UG1EczBrYU05dFZZWi9rUXFoOG1GVUUyQjF2YWRtRngxZllmeE9V?= =?utf-8?B?VkdmSFFYQ05ZNnQxcXFwNzNEYnZrd3NvMmthcGtBY3RrT2drS0tlT0F1dTFC?= =?utf-8?B?QlJqcnIranpNdURpdmlPV3RjZ0Z2S3l1OWg4ZmcvVWpQOWtIK3FVQ2dsSW1p?= =?utf-8?B?ZXJEeU1QMjl2dkp4UFFSL2dhUGl0dDlBQVJxcjZjRkNCcXAzeHZxMTZsM2Fr?= =?utf-8?B?QVEzV0lmR1I1cldhR0c2WlROM1FQbG1KNW9GQ2IrS3RqQ1VXSDhzeXEzRHI3?= =?utf-8?B?Sk9CZDlLMjlVWDlKZWJMdnZ2YUhkc3A5T0NVYUhMcjdDK2JmT1NsdnZobVd4?= =?utf-8?B?dmU3V3NwYXNQQWNMcE5ocUZQNGh5NXEvSHZDcTFrcWhmaC83emdJSmxUWHQ2?= =?utf-8?B?aVdpbUVPKzBPZjFxLzhwYW9XSkpEZFNJdnJYcWpwbTJicjdpWk5RTTIrclF6?= =?utf-8?B?K0U2S1NXSDc4d3k3QlNTeWl1RnlrYjZxNW5VdTZpKzJYdnpoV0xPZ3Zydk4v?= =?utf-8?B?MHVRMkZNUkVkVUd6cjF6c2JDVVkxUkFGd0JSVi83M1E4Y0pzdHlDbVlXdTU0?= =?utf-8?B?NkFtM0M3L0IxUXl0MjhFNlljZGdKT29teGdrVGxXY1I4YXYya2VrdXBRRGRQ?= =?utf-8?B?cndxWUJ5NFYzbXcraGwxQ1RjS3RTdmJ6TUF6TTIzT2lCUGJwREpjWEVzTW1i?= =?utf-8?B?b1Y1UWZaSnAyNjJOZkNwU0o4OGpIQ2trcWF4SmE2SnNuenpRak5kL3dXRm54?= =?utf-8?B?WUtmQWRHS0xueDU2UnN2UkdOdnZyVVJ6Y1F2Z2hkc0xocENPSm1TVnBzN0I2?= =?utf-8?B?djNWOXdUeFBPdW9yYUdubU1NZW9MaDk3ZlhnS2FEakZUbGRIT2U4V2VHWVJt?= =?utf-8?B?M21CaitxV2VnbmpiMG9BdGs2MkE4eTkyV2VLa2NkVVhuOVppanJmd2I5SEU5?= =?utf-8?B?bTJteTNjMkJjald6K3NrWjFTQVlFWXQ5UEpnQ2NhZ0ZZVmhSYVhaR2prc2M3?= =?utf-8?B?bWVEWUtDc2NUemtVTURXUVNpUjdoS3NrUkxZSnVxTlJ3dmdLcEVERWdRcUYx?= =?utf-8?B?Z1lJT3lpOXd4RDFkd2JIamcxSTBVVngxdHZyU0hPencxSnRWUFZ4dEJxZ21E?= =?utf-8?Q?CHsron?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGhnSnZrNGUxdFlOMnBYRVVXaG4yNmQwNXpNOVo4WXdWanJFZlJDR0R0SGl5?= =?utf-8?B?cVhHelM4UDJGZ0FJNDgvODFtOG1iTDQxZWpwTHgyZjFRNUVRK1BaRjlEaHBz?= =?utf-8?B?NEQ3dUZzdEozVWtmVjNpNi8zY0REN2VCY3oxZ2NKbTVuVlEzNEZ0N21kQVZJ?= =?utf-8?B?SHZBWExMOTF0cm1PWEpqT2lsSVF4akYwWlJIMnlLZjltMmNqVjdOR1UvWGNE?= =?utf-8?B?UU9FQko5UGlyNHFDSm5ZNnE4czJJMVpvTHl2YTNlMFRzd0h3L1JRc3AyWVFw?= =?utf-8?B?Z3E5NGNFQWVVd0Z0bTRYMldMTkJxa2tGTGJWVmh6U2xCNktWcFZMR1lQM2sv?= =?utf-8?B?b0RqaWprdDI2Q1g3Z3Jic04zMW1tR0tUZ21pS2JPaDh4bW85MW0vMnlZcGRX?= =?utf-8?B?eCt2dmVXbVRJZVdsS3VVU1BxTDlvTmJSRmhjdUNhdGlkSlJOSUdrR1pGM0lm?= =?utf-8?B?UE5RZXk1TVhMd2pvc1JJZVBZby9XTlZFVmNnS0cvZVVHQUtiN2YrSFF5NUEy?= =?utf-8?B?Yk51OEZUTFg0QVVOSDZQaFNCVU1ZZmwvcTlBQmlvOS80SmRDeGJiT0tSeEhI?= =?utf-8?B?US9rd1NuMk1wQUlmSXNEUE1wdkpCTjlKMnhjSU9UWXlKaWRhZnBCMjR5WWpZ?= =?utf-8?B?NXNLMVhDRzF6ZTZGdWVNb2hOYzYxRDN6TTdJMlBKL1R1NEcyYkJ6UWU5U282?= =?utf-8?B?VFJLMFNyUksrM2tRbE0xV1lDRVBaK0htbG1odEJoYmdhRC8wb0RBaG5BbUZm?= =?utf-8?B?UWhNSGxuVlppUzMyejBNdFJ3alh4MnpVaEJMakw2T1FLMUtMaEQ3YUhaWERj?= =?utf-8?B?bTUzREVmd0VhZjMrMWRHRkU2Z29ZeVcyYnJnZ3ptakQ1THVkSktlN1RSU0c2?= =?utf-8?B?enFLN2o2WmtYWVB2NC8vVzZGbjBpUnVVbG51MU4yLy9qdyswQ2RYNFo3TFZq?= =?utf-8?B?TStpWnREdjNkQ0UyeDJCMWpHZDFWNzdxKzFwQVRMdGlrYTYwdUU3b29mNG1o?= =?utf-8?B?VDluYXJESWdoRU5FVlJ1L2lQUXFpUTJKUnZKSk93OGZYWjRlTnR4TG84cXJ1?= =?utf-8?B?aUVHYXRTVWxuRWxOeVoxU285UHo3OUpCbStNRS8ydmw2WTI4Sk1Da2Y0WkFu?= =?utf-8?B?QjhvY1YxaTFVeTJQZW9PL1BZQVVUVldVWHZveStGWTdIL09RUXdkTW9GVFVB?= =?utf-8?B?bUUwTnN0Z1NER2RXcVJua0ZodGZITmZ0d28wZGxiRXJNY21BODRkR2QvYXpZ?= =?utf-8?B?MWNGdm4vUC85Z0thUXRZdi9rNnFkN0szeTRNUEYwRDJhbWxnbmxJOUxiS3gw?= =?utf-8?B?Z25hMlB3dktsa3RYQ25Vd0F5V3VxNjd3MVN2azgxaHc0Z1BzQ00rdTFyRmN1?= =?utf-8?B?d2RhUHR0dWtnQ3pQOEhJYVYrajJ1MVVud3pObVhaUC9udkNhb0h1dEdnUlpR?= =?utf-8?B?RGpiWGdvSmVKVFhCS1IzWis5K1BGeEZtaTZuZjZaYXBVb0ZrWVhnS0c5R3VX?= =?utf-8?B?WFBmeStFTzkwVVMxZHhWWEppczE5eEU0Njc1RFp6ek5mM0FPVUgxdWQ3aTFk?= =?utf-8?B?Q1I5dERROTl0VFFocWp1V1JaWHpFK0V5czh3YkgwbnA2MXVJdlFpbHJWRkdO?= =?utf-8?B?STVSc2wrK2Zib3BFbkl6QVV4bC9NdkZFbnIvN3N6dGZ0RStMOVJWK1k1MHVS?= =?utf-8?B?OWJ2dXlicWZQcDg3QURvN3NyaUZXV0tWQURBbXRmQ0dBSXA1L2hiT1NSVUJS?= =?utf-8?B?Q2t6Qzd3b3lZQkM1S0svVGNpUTcybFNhaHZkTXVNQWVEUWplL0pKVkJEMVd4?= =?utf-8?B?aHVpcVRNTTh4MDN3dEYyQmVoYzVBcUgxSXVSOGI4b1FiSlhYNGdNeGFLZGY0?= =?utf-8?B?dmMvdnVScjA2UThsbzh1VUs5RGdWYUhKRkp5SGQyQVFxODlkU1NTWHozSjhn?= =?utf-8?B?Q3JtY01abHc4VHhSM1lKYS9ORElDU0tEdFZ4MjJkSWk0STVoemFTVHF1c1Bp?= =?utf-8?B?ajdFU0NpNHF6K2FDTHByM3FRUjFBcVFoK3hVMG9KWWdLdVkwSTBzeTN0UnI0?= =?utf-8?B?eE91cUVmM3lrVGN0Nmc3TThmdUl0cVVDK3l4WkU1L0RMdXpkUDBCY3JRenhB?= =?utf-8?Q?6mhq85MLtO8WQRoQ9J1H/Ecqm?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dd9b37d-b843-47aa-4d10-08de20c38414 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:42:04.1536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMWI3IKsa514za7jxIichcL2PWvI9vcaIVxI9iqwO1ofcwRPMjz4Z98D0n3wmWbKaOQqnnpfbdtZp9ZN9C2Z4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Introduce imx_dsp_rproc_mmio_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_MMIO to manage remote processors. Allows the removal of the IMX_RPROC_MMIO switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 61 +++++++++++++++++++++++++---------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 40 insertions(+), 23 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f28d25cab3f1d89e5cde37a04b528870a59abeed..71776816c3508a86bf7b8a09ac4= 5827a83a7bb3a 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -338,6 +338,14 @@ static int imx_dsp_rproc_handle_rsc(struct rproc *rpro= c, u32 rsc_type, return RSC_HANDLED; } =20 +static int imx_dsp_rproc_mmio_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); +} + /* * Start function for rproc_ops * @@ -360,12 +368,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, - dcfg->src_reg, - dcfg->src_mask, - dcfg->src_start); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -388,6 +390,14 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return ret; } =20 +static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -411,10 +421,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, - dcfg->src_stop); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -1032,6 +1038,23 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp_= rproc *priv) return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 +static int imx_dsp_rproc_mmio_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + struct regmap *regmap; + + regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); + if (IS_ERR(regmap)) { + dev_err(dev, "failed to find syscon\n"); + return PTR_ERR(regmap); + } + + priv->regmap =3D regmap; + + return 0; +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1049,7 +1072,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_r= proc *priv) const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; - struct regmap *regmap; int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) @@ -1061,15 +1083,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) if (ret) return ret; break; - case IMX_RPROC_MMIO: - regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); - if (IS_ERR(regmap)) { - dev_err(dev, "failed to find syscon\n"); - return PTR_ERR(regmap); - } - - priv->regmap =3D regmap; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1301,6 +1314,12 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_mmio =3D { + .start =3D imx_dsp_rproc_mmio_start, + .stop =3D imx_dsp_rproc_mmio_stop, + .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1321,7 +1340,7 @@ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8= ulp =3D { .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, .att =3D imx_dsp_rproc_att_imx8ulp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, + .ops =3D &imx_dsp_rproc_ops_mmio, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index aeed08bdfb5619c7afd7201589f417cfd6745818..912827c39c0dedeed76c13740ef= d42a8e7cf9c45 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -18,8 +18,6 @@ struct imx_rproc_att { /* Remote core start/stop method */ enum imx_rproc_method { IMX_RPROC_NONE, - /* Through syscon regmap */ - IMX_RPROC_MMIO, /* Through ARM SMCCC */ IMX_RPROC_SMC, /* Through System Control Unit API */ --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012010.outbound.protection.outlook.com [52.101.66.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8071234889B; Tue, 11 Nov 2025 01:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825332; cv=fail; b=uA4rqVvIcMTm8bFba7BGR3TymNP6XVhTSfQNc68EIWnUxOF+7CU+g1CKuX2e8RMwYEKGA95E3+R8j0oSitgxqzY7fuCDIplAXFcReuL1UXMkfO15fyErSL0NOZof8J90XEeUYV3oHff8GAO8OKv0TxZShQTL9d9x9ZMaIC22nZI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825332; c=relaxed/simple; bh=BQXomjOXVSFSIkRQJERKjKFthROEP85wpBffuxfl6w4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=K48gcRVqAuyVAiIBoowYEVWIBsFQ+/15IWFnMA3/DcJgC5fhTewQ0sTGfR3kNrgyGEHMYCStQ71pFy+Gtf/XLRbL7avVSVm22Jom4mrDcNP1ux7JEdsRE1snQWbNkd1/ZEmJN50wdf6Bcw+60dwk7DeM8WyT6jThlKMOjZmCcb0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=A2GkJIvv; arc=fail smtp.client-ip=52.101.66.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="A2GkJIvv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y9jdhEOZ5XkOgBISJVcCLzMFed02Y5MTB3Nvt+FAmEtp+D46pGAd3d4XMKkDF3uskD8gJGE7zjU4LQJoM9SpA19hKQsQn/7mUhFxLdKOgtB8WAVJt/k7mo03pOZkkkQN6uVaOjpFZhymgVUhMe2lRF2++Y8A1rQuysIieGuOgHC8gAWc+/9xt4Sh/Tgby3Tj1boZP4UTtShRApsuYTNeqNKRYkSdxf7IIIo+qmMQiUptG9bglu/qVusAxn4n2zzEk+nU/mGraABZvjbwBLqVEQq8B0AYo7CzA2Q1D9KbXJhJtPZZJrQ2ytp6e12poanjHJ6l9Cdl2sm7S+dhDpqNww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mY1mjf1VbQRcyElK4muzJlLBxfXOzLmtd0WhQQid9OA=; b=L021tSj9cayQjTSxNOZ3QWEsTk70d8dBP7Y2kwUHnRxFl24ptIvwSYD2qm1+T9Zj6jE4S6Kh0yuEF3ejgo3whfYfh4Zp6vYgcLLCxDTFWAJjp5VtEMRlodWz84W9/zrGdxZ3X/0DLkGCpm3mjfIYd04X8wCFoAazlXeCfsnhOONTUYZDXfBr68eqVFs3PNPxr9P/kEiVuLlj1Ek3ZGv+iov+43fT7DGfQmHFpKj9lTZBdf1v50EWATgcDHc4ONojsAojzWXfdQZHNgO7z5GFi/7PxQJ7J3cA0R6/dUFAriNtdG2zhUtE9ZsH0wDB2bjykC1mRILugmU1YseXA4Sytg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mY1mjf1VbQRcyElK4muzJlLBxfXOzLmtd0WhQQid9OA=; b=A2GkJIvva7SyuyhK3flD18GprPl82Yz5gVkmEsJsltyIhIPTJxwVQXf2Yisx+1KaU6Nj5k2qD9D/wpCDg+9HjkD/ycfnmB+NZiTQnhkeguU1RIWpq5C2MDp+xAZPpYQ9APbj6yViEGjVIc2XHNd7DbmmnCYt5XJMj9PNxKBmvV/JkbFPXhdcQE6sk42lWC7rMCMkfkz37axfSRVNwLxxQ466PRZNB5k4FOG5gRcku+w4tq2OR5seNMM6KD69eDVQC1yVJmlPerMmwuWg/cq9bZuP69+en9LQYvZxTQkyRVMs20CbPHj+f0V0WzXl/DoXAR3U//I2X0k4aGz0lHT9aw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:42:08 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:42:08 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:20 +0800 Subject: [PATCH v3 09/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-9-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d3361b4-91fa-4417-eceb-08de20c386aa X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MmQ1UnFRTTg1dE1aRW9ZZVI4bEc4amJIQldGZWJmYU5keXR5ektkUUNmZ3dy?= =?utf-8?B?ZnQ0cVc0cHRFSVg1YVZJZnBmTWdqaXQydlJ4Tkg3b3JCeWFhTUIwS2JpZDZh?= =?utf-8?B?VmE2L2RRNlVYTEFFaXllVTFSS0xvVzRsUzhFRkpzNnY3Z3FPZkl0SWN2ZVc0?= =?utf-8?B?TXI2TXNEaUZZZ3VMMFBoblVRUDgwRzZFc05GUmt3WlYyVG4wQWJlYUEwakMx?= =?utf-8?B?N0lrTkpKdWZGYVVxVkk2anpaRGc1bkpjV29rNGc3WHdlYkoyZEtJT2l5UTZ1?= =?utf-8?B?NVpQZ0lJMU02ekNTdlhQTzRveEdoVHI4KzJkS250c2Y0OVZBRTJvTk9Rb2Nx?= =?utf-8?B?aEQ5UTBZc0JEeGxYaW1qbU9SS21SckhNM1NzV3lYSDEzV29yVkxKMUY0RzlN?= =?utf-8?B?VXpHM2hCZ29WeUE3Vy9YZ1hFUTdzM2ZQS0tpbFlhcHJlSTM0NUs4aE94QVBy?= =?utf-8?B?UmtHT0lxTG81QXlMTTQ5L0F4eENvbHg0MHpQVnREL2d2S2RIMnZ2ekpza2JF?= =?utf-8?B?bGlVWFpEK2oxZmdjc25RdXhQbzk3TWROaFpXcHVMM0YxVW9yOHpHajJFMER5?= =?utf-8?B?UURwZlQyU3dFZWZHYUl3TXZ1VWp3QUJCQ3c0dG55UTU1eE85UUFvMzdzaStV?= =?utf-8?B?KzBaYlhNY2hpRDRGaHk4aTFwVWxtNFFndHBzcG9xc2g2QnlsemN3UzlocTdm?= =?utf-8?B?TVdDZ3N4SFpyb2p3VWZBRHdObEM1Q0RsdEg5d1BUVml5bXlTZTRtNjF3Rnc4?= =?utf-8?B?MzUyQVV1VmNuN25jd2Z6VEpYZ1VHZ1JCblBUK0lvRzlkWjhKSFZ5bXduR1ZO?= =?utf-8?B?SXkwZm9HMEJoLzhLSW9pU2VwN0RUcTRTaE4vSFkwUmlydVRyWElZc21Gakky?= =?utf-8?B?YUduTnA0SVdnR3RYZ0dORFZzODRFRnFmbC84M3RiRjVzbGg1TjhlRTQwdTZ0?= =?utf-8?B?OFMyc0NOWVMzckJ4bUh6NXBXRjYya0dLa1cxVGh3ZDUzZU53QWxpU3c1aXNl?= =?utf-8?B?NEswVDVrbGVXalNhZkN2dE1EaFJuQU92RDhrcVJOenVBNzdnWGgrVHFsYS8z?= =?utf-8?B?aWVEcS8yMUVLNUtWcFp1TmVHeXhEOTMxbkovZWNDRVQxa1dZeENpOHdraXlw?= =?utf-8?B?bkwwZ2xMVHBvd2VEamVsb3VSNmxhZFJPeTdqTjZyUUNDaDBFbzBRMllrNDdv?= =?utf-8?B?dG16aGZkOGJXZHBlYVFVeUluVnhZU29xZmFlS3BSK2p5MXdOV01Nc0xsNFUy?= =?utf-8?B?YTNIMEN6cXBrS2Rtb3Y0M1dCVUg3dExsMUx0R3E1bC9SdmNneTdJR2J6ZWky?= =?utf-8?B?VE9EdG1Yd3JxQ0pBRDBLcDdQZmJ1ci9HbjZGRUpuL0JOSklXZzYxR0oxZ0xX?= =?utf-8?B?a3hPKzl0dHRmaFBScUh6R1A5N1FVcGo5cFhwVU5jSmhGRGgzK2JZbGo0ZE5u?= =?utf-8?B?VUpkRURQSWVmSGdtRUF1aWVyU05xQ3Zpd251TUJxN2VEcjBJMTNhWnhKU25z?= =?utf-8?B?OWI4UnRENlFic0lGeklGbGw1NjQvVHdXd1ZhR2U3VThhU3FZSVJZbkVyTGNC?= =?utf-8?B?aVYzbTFzMVRHUU9ibWFNVGJQTU4zMU85bUx3QW85RWJLWVlGUEJOdnlYQVZJ?= =?utf-8?B?ZjJyOGdCMUNlRUlrZTRaQmtiN1UxRENteXRITWNBVUFGN3ZRdHB1c3d1WVpS?= =?utf-8?B?K0ZPSHNhL0RRZjZVZDZWSGpDVlBIVFh0MUJZZUxiUzlwclowN0dNQ3Q4SlpX?= =?utf-8?B?NFpoTStNSFBLSllrd0k5ZTcwOGJHcHZ6aEM5VjRLK01DYnRWekJTVGxEV29M?= =?utf-8?B?MG1KNUVaTzcra0hMZ2dzUDBOWFpRR1NrNmdxb1ZBd21NWlpTMXcyNXg2Nm84?= =?utf-8?B?eW45RGNzOG1KMEFjUkJid2FxbGRiU1hDVVdxYlBPamdRLy9TRGhtVU8ySTUr?= =?utf-8?B?QjFaVU1FbDVPT1laUUtvNGI1RThWZFdDSmEvTnAvZjhSQ2lFQnVITVBvQ3VX?= =?utf-8?B?YlNqR0J1azNLR0d0Q3RDak11VTBUU1ZZYU95cFMxRFQyYkxQdWlFZzNrOFVX?= =?utf-8?Q?BcrPXQ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUVoWUlEU2hHczhsMUVVR1F4M2R0OTdIYnV1SFMxb1lsZSszK2tWY0xNTE50?= =?utf-8?B?Q3ZYcjVjVGFRQk9KS1NFdTF5ZlZDV0JZNVFlY09UV0xFMzF3ZmZQOS93Y1lT?= =?utf-8?B?YXp2RlVVUExPSENVbzJDVnpFM3ovSlpORW12M1BTZ0lySERYQlVTYWkrWmx2?= =?utf-8?B?cEt2M0xUOHpVN2RTeCtjcU5oR2s5SVVVYXQzVGlTd1FoNU1BM3NGRmg3aDJQ?= =?utf-8?B?d3VVOEhFbnA4K1hoNjMweUpzRmpDcTFpT2NOWnpvQU5rbkx6Yk1wZmJRN1o2?= =?utf-8?B?NjhORWNoQ2x0ZGtKL1UyWmlFYVp3YmxDUTdkME4zTUk0anZSSlFrR2hHdjRT?= =?utf-8?B?TXIrM09wRjcxZTZpZnBIRkM1T1NhWmdwdjV3dXllb0ZiN0Z2TCs0eGtZOGZJ?= =?utf-8?B?eDIrUXRyYzQyOHhDcTkyUG80MTdxdkg4VXZINFFUWXk5Mm1lWHhOMXJUc3Fo?= =?utf-8?B?N2x5N3d1Y2dVcWN1M2trcjVtSGVSZThDVUQwWk13bTFUNFMyUDUrdFI2WDRL?= =?utf-8?B?SmhLbWx6bWsvamg1MkZoMFA0SkxuazQwcHNPeFRBdkdZVE5aZEk2bXZXZVhV?= =?utf-8?B?c2FYQUZnODVHNWNWbkxXZENwdjRaeUN5cnpySlk4RlFIaHY1bVZoYnNYMmtE?= =?utf-8?B?QVg3N2VJTTdmQXhtUk95aFJiQnY0UFE5YU8wazAvQWNGbmw1MXZUTFZEM0xy?= =?utf-8?B?WUJHa3J0eGZFTkZjTm5LTVEwaU9TZFM3QW1aajV4d25YMUNlWXcxTkR0Q0Qz?= =?utf-8?B?SjNwTFBNYWVQSmtseWJneXRlcENZV1M5NmpPTDhPcFRBNEdUanBKWFVuL0dU?= =?utf-8?B?aE52bUJmWFZNT3JBc2lTbEw2ZGo3cEtDL0hjTVBEQVpWdWZseEFleXFzdHJB?= =?utf-8?B?OFp0Rk1aOFZjajduTDBRUjA3YWR6SDdFbFBaUXZmOVFNQW1XWThzUnFIM0ls?= =?utf-8?B?ZE1odG9qZGFkVmlqRi91bmdIdWpONlNrRlRnRFcxbjVFUFYwS0oxbkE5ZC9l?= =?utf-8?B?Vm44TG43eFo4WkJ3M3pBdDFjYU9uV1JiZVhRVFNadHNnRndEMTl4VzNxSmlL?= =?utf-8?B?RDY5Mzh3d1pFc1pSSGJpSndsN2pBdHR2M3VhTkR2a0hPN0ZnM1M0Z3R3RHJK?= =?utf-8?B?UUhUZjZEdFFmUEN5TkMzSGcyeWFUcDZ0SENqZHNmTngyUDJ5L0RwdStKNU15?= =?utf-8?B?UlRzbVJwR1AvYno2YW8xRUJ5Rk5Zckpwang2NDY4a3AyeDlETGZWKy9lU1p3?= =?utf-8?B?T3BBSHlBYXZEcUNJVVJUemg4L2RuRG9acWRRSXlMY0kwWjNkK1VTZXlBeHFu?= =?utf-8?B?Ylh5TUN2cXNaZGpZckJad2FjdFQ2REtSZ2NKdnZWUEVja0hOK2JiQjJZc2hZ?= =?utf-8?B?THBOQm5sMktVNVZ5OVF3czIyTTREaCtIOGZFbmdNNEd4eWxzZCtiUExiRGVk?= =?utf-8?B?RkR4QkFOVWU3YzJwT1R1a3diK2lNbVhTQlptSnFPbGpVYm1VZEMycTczMk12?= =?utf-8?B?Mk5GWGduRVkzQ2RQbDZ1QkZzVG1aTytoajR5QnNnUHpkVFROQ0ZpUDYwQVBF?= =?utf-8?B?UDdYMGlPOVRLUXRtK3JwdGdoNkc5R2lhRnJSWUJDbU44bWEyTkI3UWZJc3Ft?= =?utf-8?B?SjdqeGlqdU50ZU5NeWovMTZYdk5vemRQNDRpTEhPSmZ1WDNLRU1JMFlNNUZM?= =?utf-8?B?VG1sUlFORTVEUnM1amFiWCt4U2dlRVNseFVIYmpJSTZBK2dRMytpcnMyVG5V?= =?utf-8?B?TWVKT1BnM2dJbGtJVnVZMU1MMm43cnhwYU52T1hqdzArcnBTQ1lIMkpkVXJC?= =?utf-8?B?Uk55RHlLOHV1Mkh4OXJWbVRlNlZpRnBZcXFnZSt4L0pQeEJQTlNITHBLVGlG?= =?utf-8?B?Yk92blZDSHJ2WnhUK0xkRUJRZTFpdDJUOUQyQkhlTjY5R0o1MU1lNWUxYmF1?= =?utf-8?B?TTZNZjRQZVVxazdNa0NzVzNtaXpwbUh3NUo3NHlqU1hCRjZFY3E1QStmL2JB?= =?utf-8?B?WlpUMWx6WG9YWkh2ZE9qblBpcEtmcVI5VVp1TXd1Z1pXVEtVYmNpSGtWYjRW?= =?utf-8?B?YmpXeHJQVDFFbDg4ajkyNFdyZnpyOC9hRVlWTXdGU0RaZlRrNE5YelBoMm5K?= =?utf-8?Q?A9WKsZEXhEDFRuqiFOPb0qJIK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3361b4-91fa-4417-eceb-08de20c386aa X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:42:08.4764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tco3cp+vmrsidZ3JIJQiX6yQ2NgG0aQG2Esw4pFiPm2LOkpawSdeY0CcQgSVdZMNsK4HjeoMQvM6l5CTFb97sQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Introduce imx_dsp_rproc_scu_api_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_SCU_API to manage remote processors. Allows the removal of the IMX_RPROC_SCU_API switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 48 +++++++++++++++++++++++-----------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 71776816c3508a86bf7b8a09ac45827a83a7bb3a..91d041c15ac19f527f48c818942= 1f71fb7c9745e 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, true, rproc->b= ootaddr); +} + /* * Start function for rproc_ops * @@ -368,12 +375,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - true, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_deassert(priv->run_stall); break; @@ -398,6 +399,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, false, rproc->= bootaddr); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -421,12 +429,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - false, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_assert(priv->run_stall); break; @@ -1055,6 +1057,13 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_scu_get_handle(&priv->ipc_handle); +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1078,11 +1087,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) return dcfg->ops->detect_mode(priv->rproc); =20 switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_scu_get_handle(&priv->ipc_handle); - if (ret) - return ret; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1320,6 +1324,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { + .start =3D imx_dsp_rproc_scu_api_start, + .stop =3D imx_dsp_rproc_scu_api_stop, + .detect_mode =3D imx_dsp_rproc_scu_api_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1352,7 +1362,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8ulp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { .att =3D imx_dsp_rproc_att_imx8qxp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { @@ -1363,7 +1373,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8qxp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { .att =3D imx_dsp_rproc_att_imx8qm, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 912827c39c0dedeed76c13740efd42a8e7cf9c45..a6b4625e8be76c6eb6a5d8ef45e= b5f3aec5fe375 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through System Control Unit API */ - IMX_RPROC_SCU_API, /* Through Reset Controller API */ IMX_RPROC_RESET_CONTROLLER, }; --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010005.outbound.protection.outlook.com [52.101.84.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6D834A795; Tue, 11 Nov 2025 01:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825338; cv=fail; b=It2YXuVaxYy9LdOqfWiOjfHnY6C/tG6EMXhl9bLZECwL8oG+TXcV0H3P3Cj34bFRbiY9CbwqL6AsYclQx7TpH61sD1agQaDPH1aC8ijo1VLD7naMFK7JGvMH8SSj29pdU5nQl/YrgvCZreWc8xNXgyZyKlsg/TDtpdgMBuGkvkw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825338; c=relaxed/simple; bh=PSKlS2Icc0z1f64MsYUkcGz1b9Z+R4WDz/pefQpi4bU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=klF4+HdqLbyvXCcISfFJW5aBou1dH4HzFgTeO/Awb0H3kWRUyyLjnhBNacIPZ4b4BICZ2OjbiBuwc/8UVS3mygbhSzUz/pubUEf8M7tOVvcwMq/DxE9BTYG88x3Nu/aZPvqGNxBG5jfCMeMvt6jRyItFCx8YefjSg0zgIYQuEqQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=j26Orv1T; arc=fail smtp.client-ip=52.101.84.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="j26Orv1T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w98Jf5Mrb56kc8LhMY9KvrjsfQg58mAITD9DKLWHXdbN+oUT77zh5uNPvOZecpnWR2VweUY7hhqdjf/mmvXtl8u6JdCB7GHZ+is9sWsnia5l5L5FY2iJNl6/xStt2D0cdqymadl0yMf5D2T2zwvGnIIM8/WyNIR4OgNV+gcO2r0r4FX6w74JSteyOaHHeyVjAMY2bMC/fyqewJQg5oFzEaRNQp/hFyDXeZn+IzC63x4Oz0C2Rx6n/0ekgwu1lCePZe4Fx+atFtFZWJXVJ5Vr/LtQG8mrSr+LbT3TcqmWXFT6Hdw65i1aA6eLS69E6Kc41gFvVBC8W8rkUI2yU+PZnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hY0Pt3/c9h4U7/TWiyqsYecUf3tiAGKhheuAf9PTMcg=; b=N4x+bvlnii+Wtld/aZu9DmC9y9trtPqT1DRucaNi/yd815awhdkCCzdKUlakdEA0ljnYDOysYYYOGJbQXF3dZfuRy6L/JpW1F2ifvrGNbN6OJTZUJSeg15y1VRr9km+Iyl58nLUphAAhYNlaZRAl/+H3VIco4RjoTsSVrzpap1pLIQLqc/lmF+ux9D4Oz+iatqYwQJ+h1K+k75A8SV5LHJ/+SX1mhH5Dbi/lX/FBdq+XqpS+29LQkf6IgIfN4vxxrNEe4ICOZKQk8I3/pTbo/Bh/WtirmdJNIwJeMNagq0908b4UhSQ3qeonULGGcJzsyDgSjNqbfRLij34LiXJRSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hY0Pt3/c9h4U7/TWiyqsYecUf3tiAGKhheuAf9PTMcg=; b=j26Orv1Tom6JTCcrJzeMpkqivEnIJDo5VVkzU59Jo+TiQvHZWGxYAyb5RYxiSuMgagwa6RNqq2blfcZjZ1RSieMzsZRxkyzLtB70oVIxRR8VxwJ9WsvuwP0qyBWY7wDuT0lMsg7jPGk47snAvN/CLvBAi/EyD/K37Dzp/60DEaavgrX8Uq/aE9Sq+jD25V1nDkon63tJML6xroYbdbQEVSvvDwb5XkNYwPLH1v0Pdk85bc2KIFhsMjyUmPGYIhZvqwrgfe2gmjkslZKtvB4Y0IMLUpohHwwA6eNO6i/7O/9ocnDnyWvUl5lTYtk4qw9mA8AzStQBMQNCnhc/eGT58w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:42:13 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:42:13 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:21 +0800 Subject: [PATCH v3 10/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-10-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 073be814-1b3c-49be-bc97-08de20c38941 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b1NsNjQxSWNZR2I2STBWelVWR0YxeDMvTEd3MUxtcm00TUtyNURRYWY5OE9k?= =?utf-8?B?S2xSYnBSMzNBbEV3RkVGdVJUVWRHSDl4cGFhMHIrZG5IUjJVb2dhUGxMbXJM?= =?utf-8?B?SzVPV1JEVWs0N3dxaTJCSTNNa3FpckdrRVFGOW1jb1p3dzBSZEFwR3NiV1g1?= =?utf-8?B?cFR2SnNGRVhWOVRNV3ZWcWRLek51RDJGcDRJZG5aNXVSc3FkaVByQXljNTNo?= =?utf-8?B?WitTOTBiZHdTZVc1eW1MejdmYytFQkZxRUt2dUN5WXJGQkQ2RnZWYWFjUlRl?= =?utf-8?B?dG9id1BuTkFxZGk2T05KVFphOVpPeHRQWmh2eDdmWWdXcWFyeHIwc01GWVd3?= =?utf-8?B?cFkvUWJrZXB5WTR3eTE0bDRvTEVUN2RxdkgxWHptYjlqRW5VdEVNSFdtc3E0?= =?utf-8?B?MmpHNHlXczRJamtjZzE2MDFiRHhlSlg1Y1paaUg0Sy9HY3VRVkZ1ZFpFekh4?= =?utf-8?B?dmthRFJYNkxVQXBpR21nWGpMbzdMNjBkbkZXQzE5SDN0WXRIcWx6YksrYW1r?= =?utf-8?B?VTd4YktRcE12OWhIdi8venY2VGxZaDIreXUxU2R2VDY2dkpmRFY2Z2N1Z3Fl?= =?utf-8?B?dWRtY3Q3V2I2K2dvKzVtQy9aYisrZ0l4VkFPUG52eHAyZWQzVzdqaFFyMFR1?= =?utf-8?B?Vk5saDIxYURjaHROUXplN0xHRFBXeklQejkrMWFtK0xkNis5dFY1WjZ1MGwr?= =?utf-8?B?WVpiOFJiL2EwaHk5RENUY0dreGR6M2hRNk9yMEZmajk3QVliYVFsMXRVb3c2?= =?utf-8?B?RGUxNTUzUk9kS0J3czJ4bHBNbEtsZW1UT1dsby9jcUQwb2RoZmkxekNWc0FL?= =?utf-8?B?Mld1M2FTQUg0dVZZRzlFM2p3b0xWd2NydlFFenkxMjNNUHhRQ09iZjQ3VEIv?= =?utf-8?B?alRtYzJWNllKSE5QcmlCWjh1MGJLVTN1SEZrT1dlSDZtQ2lhanRNUXZPbG9N?= =?utf-8?B?YVZYWjdWSmlYRWZPTElibWVFQWEzN04rb1l6RE1HZ3NsNk42VXRmMUNSM3VX?= =?utf-8?B?aCtEUDNvRXdBMHFyUjAzVWZUQWVvZXZYdE1QOTJsazhkMHRxNjNWTDlMM1JQ?= =?utf-8?B?SDk1VVBpZzRmTjV3SktTSFY4OThJK3g4MVR6cEYrVlZ0ZDBTcVJaTVlZcUFq?= =?utf-8?B?ZVZXMk1sUk43ZkpFa0daK0NxMWMrV2Q1Sk9URWQ3U0FycEZnMUFZU2VwWHNy?= =?utf-8?B?YlQyR1FDUk00S25xMVhZZXMwRlAxYktueFc3NTl2Zk1OemVCZVc1VkxJM3A1?= =?utf-8?B?S0F0QnVMRXJWRE1RWkFoSjd0NGljOEVpVEpnTDdvMENxTWVSTUJWeEZUWFkv?= =?utf-8?B?Wm1zOUNiUEVuN3RaSElEVllTOFduSFo3QlV2REVlWDh0TXlneG1nQzZIYUVN?= =?utf-8?B?cUZHanBxMTRGUzk5ZXJXc1JvWGZ2SEg2V3hJTHM2THYzcytoVXd3NG1HVUhV?= =?utf-8?B?dGFreXpYdHY0enpobUZlaVdYbUxKYkp3cXVvMmlLNlNoSUVQRVJueGI4UDYr?= =?utf-8?B?aWRiUzZJRGNwWmdYeWNlM2QvalVlWndMOU8vNHo2TkJYMzFYeGNUWDFSVDE4?= =?utf-8?B?QVhOM05BNnE4MndBUUo4SVpNNGFXR0xFNi9VcnMxVzRLdVlhUFZ5VDRraVlS?= =?utf-8?B?blNPMHJRNEUwTEs2M3hkZVBVNGVmaWpsTWxJSVRYR3ZNZ1IyRml0V3V3SjI0?= =?utf-8?B?R1Vja255WmhiUlRveG5xbC91WUJxMnBzS0Q3bHNrSzhXRnJBcHFUM1JpRUFC?= =?utf-8?B?MHFqV3prUHY0TlZhM0o1Tmo1UVZ4MnUrK0ZrQnJKelNMR2tEa3lUWUJVdUtW?= =?utf-8?B?THNXVHN5bjZTS21MSEJRM200VTZSVW5mNXM5TCtWY256Z2JqbzZTSEZqbStl?= =?utf-8?B?TEc0MTZqektRV3JCTUhTOUQ0V2UvaXZia0NzNmxYZXFNMkNWRWVNRUlKT2lr?= =?utf-8?B?TUdKYjRFbzFFL0xHRXlWQW5ER0hGYjRoY0tkS0M2cjJGaUtPT29YU281d2Yx?= =?utf-8?B?QXZTOW05ZmJNeEk2RDN5RVBaWVNveWdaQ1dpQW84dzkzNm9Ycnp6dzhyRTgr?= =?utf-8?Q?U1Nfky?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1p1YTdVS20xVTg0TUMvT2pyVXRlT0hGSGdtY2tkYm5MeGs3OStmeWExMXlm?= =?utf-8?B?eFFSYytINXdadmNWallxU2FDbE5sNUh3RTUyQ3ljNllpNGNFdzJkQlF3Q1BL?= =?utf-8?B?SE8yTjFmbUFsNzNRNW9INUdqNDlqdGJLaG9BSXI2TzAxRTJKa2ZKMndJK3FI?= =?utf-8?B?U2NpWjRhVTZ4OEQyN1g2akJpRklvOEloRVJBN01DY2ZUMndxZjNVbnBwc3Rl?= =?utf-8?B?TnViVUZ4bDFWblkxTTlEMnFhOU5kMUZiMzZvNmdoNmIxZkJIbDJMa2luaGZV?= =?utf-8?B?cEhKdVl1WHJnWmNyUlk1QVpKdnpOTWMwOGNwVUUySGFQc3d2V3F1ZWZFZW9y?= =?utf-8?B?cFVmdjB1N0pwYTNlcVBRazZ1TmNtRXpDQ0k4WEpXWjZ5RXBJeHFXZkYybWUw?= =?utf-8?B?cHZGWGJ1VmJ1SGJsMkRSVkNEUnJOSWtPbnZMNjBjbzlkRHZONXpaNGx4MEZs?= =?utf-8?B?T0tQNzlYang5eFRKUjRuQjRqU0trb1NoMHVYTFRPRVFQNklGcEtHZWUvQzRD?= =?utf-8?B?eU45NU5KZDV5OWIyblhjc3h3Zk5jOFFqVTlkRFFJaVgvUWswajh0a0I2QzVv?= =?utf-8?B?eU5VL1ptUm5hWXdzdnBhMGZka1h6STBTVExxd2RMd2xuZWtjODUxTkVFczV3?= =?utf-8?B?dmtQZktPNXZLTmtpT2Y0S1orN3ZnZEpRN1F5LzFzUXZtelFsLzNWQm8rZk9k?= =?utf-8?B?cWFOcy81U0hMNDZWWnlGR0Q0SmhnQ1h5alBsUENxTEYyU3RBZW5LOFRReXJ1?= =?utf-8?B?K05BZHJOUS90a1ExZEJ3M0dZeEYzb05jT0lCbWdVL25wTW5BdFMzaGgxVmFo?= =?utf-8?B?ZTBNZEtVdmpRUVY3UWRGK3BlTHVHa09LV1BzRHoxOHlLblFGNDFrNFZNNUJ6?= =?utf-8?B?dzJVYmY5S0VyWVhCdEVYcjhWV0ErMGFhZ2pxbTkrQ1VHRHFpZkluL3FQQ1BD?= =?utf-8?B?emM5YnpTQzhTVVdNb1ZxSGNCWmwxL1Z1SFV4TlRuenprVTFBQ2JFaDlZU2pB?= =?utf-8?B?MWtTdzY2aGRVMTlQTWtIZEpseGxZZ3JCbnJUcnZEZFJPVklpTTl2MWQ5aVRE?= =?utf-8?B?c052T3pFR2JXamJ3RXVQVEN2dDBRQldFd3gxS0pBYkV6TG5lMS80TmxtUUJB?= =?utf-8?B?VUlDRldHWHByWHNHQUpsYU1RWEhCSlYwQVEzOWlsTm5CTmNtTHhWKzVTSGJI?= =?utf-8?B?MWdocjJHQTh3Qk1YS0tpSWxhWGtFNkQzeFRUZ1ZZbXJORnl5Rnl4YlkwZi9L?= =?utf-8?B?Z1lFc04vbWZvVk10K1Yyd2x0eHJmb2FxVDN4Vi84UnlKL0tUVFUyS1V5WmFq?= =?utf-8?B?L3ZvUWZoQlBmU29PS2RtUEhReEFaVHU3dFlPZkk2b25BYTQ2dFRqUUxKbVFy?= =?utf-8?B?dFZ2Q1ZBTDBDd2duWUMrUVpxMDVNVlZMSUtUck80U0hHM1dxVEJlcXQxbFhz?= =?utf-8?B?N3U3WndGNEZiM0ZucUdlTWNIS1M5VWluWWxmWGVseW9UMWtxUnN5NkU0OUlD?= =?utf-8?B?STNtZ0JqZGlMMUFRN2cyUTNUZmZOV1lrRlhzSEhJMTFWQnR2TDdWWDVuV0Np?= =?utf-8?B?TVZvTVNrOHRZbzJ1bjAzWnNrdkRhc2N4WTZPQU9HMFpwWVROMExXR1pESC8z?= =?utf-8?B?RSsvMngvQWVuN0VObVlhRjA2VEdZV01BcGdPcEozOVoxQXlyYnJ5aVA4U2pm?= =?utf-8?B?Vjh3WHBnNU9hMlBYZW1ESjNSdU1NaTQ5dkdPYnJudnBBelUwZ1EwV1VQRkp4?= =?utf-8?B?Ny9YQU5BOEJRYmpVejJDenJQUVJjQUJlM1g4emNaditjSENFR29lTkZqNVZ4?= =?utf-8?B?M2o1UHFrOGlqQ2tpSEFpdmVOSzJRVXpuSUZtYWNEYjNVYUNyYnRSTGdmekRk?= =?utf-8?B?eDhpVlo0Q2diaFppcjQ3ZDZHL2J4dlJPVm44ZFBmUE55dWFTc0cxZUhCVllR?= =?utf-8?B?cDVocWlTc3ZmUkZXc3RrSUc0cDdqM01rM0d0VHRTSXgweDVIaWl4VmlTc1Bn?= =?utf-8?B?R3FIVk4wMXRsY1E5M1VKaVlEb3ROYWdualgvZTFlTXV4d0hCUlpxbjdSL2RK?= =?utf-8?B?SG5uajNhU3VzNFV5UlhvTllvMFVhSzZxd0swLzRVaHcwY0EvOE1uQ29GQm95?= =?utf-8?Q?MOoLMz+/VdUcPQue87jaSOlVm?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073be814-1b3c-49be-bc97-08de20c38941 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:42:13.0410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VuDnafqUfeuPq3S79Kjm2ZDSL9FMNEMztNHYU8SYQsTEKlwYua+/BcuLgjywUOwMd1I6ZXtemsO1ubqjurWXwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan Introduce imx_dsp_rproc_reset_ctr_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_RESET_CONTROLLER to manage remote processors. Allows the removal of the IMX_RPROC_RESET_CONTROLLER switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_dsp_rproc.c | 69 +++++++++++++++++++++-------------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 91d041c15ac19f527f48c8189421f71fb7c9745e..6237e8db2eff759c2b7fcce5fb4= a44e4ebaec8cf 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_reset_ctrl_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_deassert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -374,13 +381,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) goto start_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_deassert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 start_ret: if (ret) @@ -399,6 +400,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_reset_ctrl_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_assert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -428,13 +436,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) goto stop_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_assert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 stop_ret: if (ret) @@ -1057,6 +1059,20 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_reset_ctrl_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + + priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); + if (IS_ERR(priv->run_stall)) { + dev_err(dev, "Failed to get DSP runstall reset control\n"); + return PTR_ERR(priv->run_stall); + } + + return 0; +} + static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1080,26 +1096,11 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp= _rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; - struct device *dev =3D priv->rproc->dev.parent; - int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) return dcfg->ops->detect_mode(priv->rproc); =20 - switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); - if (IS_ERR(priv->run_stall)) { - dev_err(dev, "Failed to get DSP runstall reset control\n"); - return PTR_ERR(priv->run_stall); - } - break; - default: - ret =3D -EOPNOTSUPP; - break; - } - - return ret; + return -EOPNOTSUPP; } =20 static const char *imx_dsp_clks_names[DSP_RPROC_CLK_MAX] =3D { @@ -1324,6 +1325,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_reset_ctrl =3D { + .start =3D imx_dsp_rproc_reset_ctrl_start, + .stop =3D imx_dsp_rproc_reset_ctrl_stop, + .detect_mode =3D imx_dsp_rproc_reset_ctrl_detect_mode, +}; + static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { .start =3D imx_dsp_rproc_scu_api_start, .stop =3D imx_dsp_rproc_scu_api_stop, @@ -1334,7 +1341,7 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc_= ops_scu_api =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, + .ops =3D &imx_dsp_rproc_ops_reset_ctrl, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index a6b4625e8be76c6eb6a5d8ef45eb5f3aec5fe375..6a7359f05178a937d02b027fe41= 66319068bd65c 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through Reset Controller API */ - IMX_RPROC_RESET_CONTROLLER, }; =20 /* dcfg flags */ --=20 2.37.1 From nobody Mon Feb 9 02:24:23 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013053.outbound.protection.outlook.com [52.101.83.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0ADD2DE6FC; Tue, 11 Nov 2025 01:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825345; cv=fail; b=S7L0kkJdE1h6LWJW7B7vjEOUdT+HzydGVPhvikoF8vt3wpEjKdI0dPQy98SVped8YRjV6cjy+sLrQ+snDeAiwaAqRDqNoKdqlVzoGIv5ZbJJ8Zrf4tCe3CMeBRHylp9u+eLlyqV6LPPMkFzv9U/Y+wO/5t8RJ+kWvLRpTNo7VuI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825345; c=relaxed/simple; bh=W5HBerhV6V2HXlOuuW+1pXNUEUioYGPdX0YSTQ/tMbU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=SabvQckIf8CvetOp6H7gNs4c4wdgi32aEM+GOnWxOY1JgvzYZLXoSCc7mla2mbdCWXMfmrROD1/ZaAZKfm4PMlAucxYZnKP7V4CgP86TcS2lqKXLNkWKmqOokBl65SHYZnUgd1uCwqNboOUnbfjcQtbKiV6C5WdmFVvLxzU/cHk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=VOdbKBXy; arc=fail smtp.client-ip=52.101.83.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="VOdbKBXy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BLf/aELASiHlZJ1MYyzK2nWZbbzZ6RdFl+CuIkP2aLgD1qTeIB6QXriwTmeQZfjX7giwiwPL1uiH9315Hum7cLmYqytiMmjDDOIOtCeZi74fw0mTSPcRpl3x1ol10SVfuigZT70VldQQ58vGZQsGApfyAtvdm7/RoXH0W2zo+YbEDaffe4UFZf0E7Ut3OMzpsb3FMiFiPWITb2809Md+4eYiR+p5CLgiE1Vcbuviku28GKTXWzgd9/SmGv9Tj/E/vWnbfTQPcNNz7q1gQiHKFJcN+TRGqDLVrQ4BeOya2fE/TWf02o8dAJX8pD8/efBfrulHx2dXTOA862/N1ymwdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=92460uPc1JawV3CNDNiLhEb4beTKipnm7MbBh8C+gJo=; b=zRWk0wpE1qPiBWAa4IT8oHEMeQhpV6Fefj85yXH6esapAQlWRMOzVPFWO2/BDrH/HcWfIEO7NPZ4NmkEKz4FH61u63ZD8krlfyHzUOcI84qmIEkVaxAoeU136V8RL2kX/EPKwBbwREy/+xslNZftIpQBolMPOHaMjICzvTvLKoOSyUV1oMOx9d/Kc+9IcsDuc+uRuuZ94Zg0d6XsjXLUJLxH7dP7jxbJWrryPeyA2ro0insVkI9IjCYlJtJW88vHhWNdZCTK9J5HOUSN40b5lH2nJuh5uBaHECquI/e2xKyraDWfLjOrLyao33ST5vvE2Dj9MqbnrxsHeDMicEyQFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92460uPc1JawV3CNDNiLhEb4beTKipnm7MbBh8C+gJo=; b=VOdbKBXyL9cRdbW7sqQczYTd22W/7tI8WlmDbOEqjrELH4x1nixtQ9WytCJYCCTFZsybBQxBdoPSd0S0/Ylmsco76DpVvH8/9YktJtp9RJNNjqwWxJvjxUr4DyqUTl14lCSzIdq4XLoU2bov5APEQv5fxA1OuZ+krWc7KT9kcfFFMJW8opDdkLMOzyWpQdT8M4xxiYxdADZGnLe3aBunEkiTy+sei7DCZ2gMNxOuSS5WLHEfC9cVo7GIqoWb8lVvFu6S/ouh59nEejjbY5CAG0Ejy+yNs/uM50mqcyGE+sJ2b7U0uVMN3ytqedWvb+ofAslAr7HAWdg42gAVPyoHDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Tue, 11 Nov 2025 01:42:17 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.015; Tue, 11 Nov 2025 01:42:17 +0000 From: "Peng Fan (OSS)" Date: Tue, 11 Nov 2025 09:41:22 +0800 Subject: [PATCH v3 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251111-imx-dsp-2025-11-11-v3-11-d05dcba737fa@nxp.com> References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 573b59a6-7e08-44af-8c8c-08de20c38c2f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|52116014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UXpmUlpUNHdGTDlMQi93UEpyR2RHRlM3QUtsU09mMXpvQ1RMa3BVb2cyWjUz?= =?utf-8?B?dzloN29ZdzhWUTBERVJrOUFjMjZCSHhRNVkvcFd2Vy9oSGlzRkUrSTBpTTk5?= =?utf-8?B?MXEyK0x6Vi9IaDR1eUxmeFJXMjVsMVB0am1jNUdVdTRXQW5FQ2tNc09yRFlU?= =?utf-8?B?VTM1UWtDemJ2VG1GNWR2eVdYRDVJbzA2bnRadng3U2NMQkozcnJLOWUwWTd4?= =?utf-8?B?QkdHMVlZU2UzUWpIbGJESnlMa1dHRnVEdTJWZ3JsUytuSEpnWlJ5QW54dEFE?= =?utf-8?B?UFI0ZDJTNTc4Ti9ZbXFjWGlGdlNFUWpjZ0wwekhZTkF6M010K1h5T2YxMGVE?= =?utf-8?B?NjBSQ0hWaXNuSTJST2MzeWZlMnB2R2Q2Q3FSTUtpY1FOYjhuVEZZTVVsSUx4?= =?utf-8?B?T1RLVkNnOE92aFFlbE9yOVRFL0JXTXV3Mm5SUlNIdWpxT0NLMzZ5RHRkOUxB?= =?utf-8?B?RE11aU9PMSsxMWZweHp1dGkwUkhuaGlOOHlZSkEvUisxRllBSDExMDdRRmc4?= =?utf-8?B?UXN0N1RacUtCek1qek5aOTZyWmRXTWJSdXpvS21YNTZGWUdYYTJLZUNzWDhH?= =?utf-8?B?bXlhUlp5RHpZK0dkcDhLOEpLR2ZXK1Z5LzhSaWt2OVVaQjFsR2tYWFlZcFB1?= =?utf-8?B?TTJpOFRNcmw2cklGS0ZCL1lXWk5OOWRMMU84MUNtenIvSnZ0NHRFNXNjbkpV?= =?utf-8?B?eUNwOWtDMVp6VmxvZW16VWFjUWJXc2gxdkc0RTVwemg4N29FcGpuV2liekY5?= =?utf-8?B?ZEF1THF2VnNVQzNtU3dRdStxM1FCbFIvbC9SUVVob0lISGZHV1FjcTlQOEU5?= =?utf-8?B?T0RzUTFTS2w1TE5GMDVFT29DWnpmMUw4eU1VUlJvdVFaNzdjWmNBcFRuVVJy?= =?utf-8?B?byszemJqMjFwRUtBWm9tVEw5RmJGcWNIV08yZElveDU5V2FVbDM3TWtHYXVW?= =?utf-8?B?OG1OcTcvT0xwcm1QRmEreCsyeXNqYWhPNHhVZHBaTldEbjVqTi9jbjFaeDVZ?= =?utf-8?B?Y1VlK3NoeGtTQTQ2QVZZZXdaQ3lRMlBhbi9FUWdmNGhxWmE1Tk9WR1h2M0VW?= =?utf-8?B?SHpPQXRnUndwZ3VPblo0TDRJSEN6TkNZOFJEQzA3OVlCb2gvWituMXI4NGVa?= =?utf-8?B?L0FXM0tTMEtYMTJEVlVNN3VaZmYxRHFYUUNYdklxbkxpRnBRYnFQSmkxWDMy?= =?utf-8?B?MkJOSG5tK3ZFSFV5R1FQUDB1NUtESEhtYndXK01FcE1TYTcrSjZHcmRYazI0?= =?utf-8?B?N2ZFTkpwZFZ5UXQzQTZQOUx5Nk5iUU10RmtWMEl3K0NKNm45YlVWdGJPUjh0?= =?utf-8?B?L2NsM2orSFYxd0dBWFlBRzRzWTErN3JkQ2JLOFFsckNHUmhtUkQyMmYrenVu?= =?utf-8?B?YysvOExTN2ZmaW43RE1zYS9rQmI5bkJjNjExM05ONG12OGxwVm8zSG5tWEhz?= =?utf-8?B?Mmt6UzdvSWNlMkhhbXJsS2VESW1jd25FYm1iVDR3T0E2RHIvOGlXNmtkUXIv?= =?utf-8?B?VzYyRHErckEzN1hNaHRqTFl0Mmd1SDA2QnBRdjdqVG5RY3o4OUQ3V0Niblg4?= =?utf-8?B?cTUzK09FUUhPTHpOOWJldFJ4TmgxSlMrdkpwb2NQVUcvYkFab2wvRzBOc2k3?= =?utf-8?B?K29xMmZ2WlNlYjBsRG5jOEU0cEs4RTJtcVFqaUc3Tm1lWVpDaytvTHY1U2dj?= =?utf-8?B?bUlCb05maHU0UXRjWGl6NmlkQzFibHRxOGpzaGRRTnRxam51bmZ2dFRRZnF2?= =?utf-8?B?d0kzNlFCWW0rb2dQNXdYQjFSRlhqOVZKRmJLK0hSVTlacXNjZHlOV1lQQWpG?= =?utf-8?B?Tm0zSjVMN1JnbzVLKzRZZExmQjlWTGkvZGRRTUVxcFlpbTBGZnkzNzVMOEtS?= =?utf-8?B?Uld5cVIyUXRKTFdqSmpuY2dENjB3SHFDK05Hb0x2UGdOK3E1VzcrdGZvNlUv?= =?utf-8?B?Y0xEcllqa3AvZG4zMERzbW1WMkdweHhLVnlYa25iVEgxc3E4dWNOV0lmQ0Vn?= =?utf-8?B?ZGlCcTlWS01DRTdBSkU3RlVhTFJUREk1TnZUWFlmaEJ1R0JvZEprVlhyeUpY?= =?utf-8?Q?a74zln?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXRTOFRJVmVNRm94ckNpUStZajRsYWgvQUJJbHBXTHZsSll1ZUF4UHNGa3FW?= =?utf-8?B?UTd1ZG1KS3dtRVI5bEcxNEZ6ZHVYYlZQUG5CU1J6eXhxWm5TZ1BJbXFUOFli?= =?utf-8?B?N3NTWnBCYjV2V09oSnpwWDluOWpQTkVFNnc2YWdsRmhoNW5aK2tEQmlXL0Zv?= =?utf-8?B?emhvTGZwL3VuWWV2QTh1TTB2eDFDOG13UFBvTTNMTFlYa1JkZjBZeFJSR3I5?= =?utf-8?B?YW1ZYlFXOWF0WVJlcGxZSmVQamRIWGIxR1VwOExLaUxPalJxTm5iU1ljZ0V2?= =?utf-8?B?ZXNDMDYyUnN1MkxnNTVNTEMxYURmeitZdjJOSVB4S0FJekx4VG9KRUtZaU0z?= =?utf-8?B?czAxQlNRaTk5SVNtQVVBNXBkalY4ZnE2UDFlWTJIYnpOSVdlUmc4NXhOenEr?= =?utf-8?B?UzZlNzB2U1puV2cwVkNjelY1YjlOOGhoZGJEUEMvYjllaW82M1A0dU1JRnBo?= =?utf-8?B?MmN0SCswenpicnBXNEk4VktCd1NhSmdXYzM2K1pwTXVDQVJXWHdMTlNXS2hX?= =?utf-8?B?bS9jL0U0M212Z0s3MjFnVkVJcWErNmR4aS9GS2F4K2ZkUldkK2ZTZVhXQVlR?= =?utf-8?B?RjVBZ0FvRSs2OHZrTTJjNFBwU2hlaVZESE9HVHJFSmMvQmpYcSsvTnBscENZ?= =?utf-8?B?cGFhWFBWd1JML0lra2FYUG01MFlnRmlnRWc0Vk9NU1p1VFRyVzF0RDU5UHlN?= =?utf-8?B?TTdjcGZTSWZrRFBsTFRkRVRFbCtkRHN1eUJkNHpXNlhFRFdDbEtSbVd5VFJo?= =?utf-8?B?TVhXaUlJQjlkSTNFTjJpbDB0WUZURVBVMTdKOTF4QnB0ODBTeklZdlJiNUR0?= =?utf-8?B?dnowckhsbWF6Mm1CZ3UyN3h3bWtOUm5oMFFPUXkzd1BYRTBEZjVtS0VjZ08r?= =?utf-8?B?bCtBVHk0RmNlbVBJd3dCOExRcmptMWd5aGd3Q3JCNGdtbFRkdkt5aW5wNTdx?= =?utf-8?B?Z2dnckt1ZGpxVzAyRGkwMUVyaVZTdjZwVWs2UFlhUkgxWjhJMFhQdlpha0k3?= =?utf-8?B?UXBmZzMwNWhTNldIaGlJNUFjajdIbXUwUVNOYUJoMkFYQk93bmUxZHUwMTN2?= =?utf-8?B?Zkgvd0lrUTFtUGZLOHpCRHBybkRpTHRIa3Y1WHk4R1dITW5KOWd5aDlNWGhR?= =?utf-8?B?WUtvdHlqZ2hjd0xwSDlwUHd6SzhsL1RWSzVPMTgyeEEweDlUUGZtNng5U1Nx?= =?utf-8?B?WnhBNlZidFJ3S0NiVzYvMEJtVEp0Y29ialJDTWVtSm9RZ0NqaUJSaVlyVHNC?= =?utf-8?B?bTkvRUpLNFI2eXRiQVFmL0FrOGE0NHRGaWRhVlVKSm5xRGc2bHdzNk42YlpV?= =?utf-8?B?aWdBckM2bHZTWHFDUGVCU1pDQUJ5Z3RSN0xFb2QrY1J2Y29ISS9GQkM0RURG?= =?utf-8?B?VEd2dUZ2Z3BxRHdTQU8wN0Q1emxIcmZXdXA1Y2IvM2ZRZXhmTGdFd0tKbGFT?= =?utf-8?B?L2ptMysrN1pJeE04MEVCc2pwa1hGWUlJMEhTL1NYSmppNWZ1d3JUcXdJNTlk?= =?utf-8?B?SkUvOEgwUFJpOHZ1d2R4OHloTHhMdFVXUVNOSDJRbEhHR0o1dkNQTVJTM1Iz?= =?utf-8?B?YzEwNm1hRW01RHJnUHZwd0dSenRYTkJjTDYzZzJrbGRNUkpkTVVnNEpTZjBR?= =?utf-8?B?Unl5ajZURFdjVjJxY1BUWWdRK05tOHNkd0p6TFhKV0M2c3hMVTNITzFvbGFS?= =?utf-8?B?WXkwc3VEalBISnRGN1U0bll0SVZmMWFTWWRsTjdBd2Znc0Z2cVFRMlNnZzJx?= =?utf-8?B?Y2t2T0pmRHZpdEliU203UUpQa3lhUFJCYXd1NzIvcDMzSU44NWNHYjZsRitm?= =?utf-8?B?ZUxVMDZ5UUhmMFFhSmQrdmZjYlhyS0F6ZWdJeHhyQUNiM01RTFFhNUZVZnds?= =?utf-8?B?eXFIbjhIc0k0aE9sN0RDYVRIUnZFa2hYd1BCNmV1VjY4MVYwM3ROd0RGb2VJ?= =?utf-8?B?RjlpanZkQzA1N2IxQmZGcktDK2I0aGduL1ZPRjB3SUlINEVBSjMvbGZyeDdw?= =?utf-8?B?MEdHUHZUNWhRTlc1cWIxUFE2TXRkRGtPRFpRWW9zVEVhZGlMQjlJYUd5Y2lw?= =?utf-8?B?L1Y5TW42WUZDclZndVU1Rmw3ZUFTZzBjMk14MUlYTWdTUVcrTURpM2N0SEpP?= =?utf-8?Q?VMad9xkSAAEgp1YnLjq/BVvTm?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 573b59a6-7e08-44af-8c8c-08de20c38c2f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2025 01:42:17.7065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zu4yt/GI4mRfObnTGYMJw3g6Q4hqnWxU/P8Z8Us51ZLsPzMQtsfOIiAynQAuSLg5HUvN6/xt5OUzWJbJjVOOiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 From: Peng Fan There is no user of enum imx_rproc_method after moved to ops based method. Remove it. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan --- drivers/remoteproc/imx_rproc.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2= ab3488281916a 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -15,13 +15,6 @@ struct imx_rproc_att { int flags; }; =20 -/* Remote core start/stop method */ -enum imx_rproc_method { - IMX_RPROC_NONE, - /* Through ARM SMCCC */ - IMX_RPROC_SMC, -}; - /* dcfg flags */ #define IMX_RPROC_NEED_SYSTEM_OFF BIT(0) #define IMX_RPROC_NEED_CLKS BIT(1) @@ -42,7 +35,6 @@ struct imx_rproc_dcfg { u32 gpr_wait; const struct imx_rproc_att *att; size_t att_size; - enum imx_rproc_method method; u32 flags; const struct imx_rproc_plat_ops *ops; }; --=20 2.37.1