From nobody Mon Feb 9 08:49:26 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA0CB2DECDF for ; Mon, 10 Nov 2025 17:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762797208; cv=none; b=D9HFlguCBYP7sycd5PcsJ+urPNuKaj+yiwkV8MGxBT0lvDoxmaScO7VlRu+gSyt6Bat7oJTtcr9l5x0MVy+VqkvIGzIbV6x/mxobL6KTacShzDQz3rapwBFOOlSBj2y/nxwMYQ+mKUMQFVcH/z5E7wVrh8SPDZ3z7IxM1oyDKFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762797208; c=relaxed/simple; bh=Lt/1CFIZSYE9YGBEOPIRVp2yrsoVFOp/QxdHkcY3gU0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mcg6BlaBznfJob+0VGSHRCQKB18G30n5mzcQFVFMbV6KHWXTxHfKM4M+Td9YJ8Jlkvn0zBYDRUQjRYTi2QuCMqS7QL/d6pc+QZgPKPsKK7wsLbjrFoJXvnZ133iz6rsRf/x+EcXBj+95JTW+oQSr/OVE58rTnwRJGlxlSB25r34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=jmXgRtZV; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="jmXgRtZV" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7ade456b6abso2780584b3a.3 for ; Mon, 10 Nov 2025 09:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1762797205; x=1763402005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XUcDXkPejgMco2JfdbhYSJS3kdJZuowM1tOw4yzk4R0=; b=jmXgRtZVXVmaYY+a9RUmC+LknWuMBbFAh2sD2WP9ZW/VHz+WsoxHoIdJgaI/OJlTcD CxKDQmt4yu/5a/S1fkzzt95PAh9ekm0OqMNGEuuSvnWB4cr7uXPuLBYkmuR0LxWpW66e PFLiSMlSIYveO+b8FyNR8MRIfq0OHkVmTV/MWWXvlJnemetoevEkYcsU+Hdf037gcz8I R0jnW0l9TSXzubmR6elb2a2o3cD4J7d1OexY0X1CG7Ntptr4PPeHN+l6KmSmXrxWR8hb AAQqhQWeqS6cp5kZU64AldF2skHRXqmH/mp4diEVK/uvKwjBXge9yAm9DMRtFUgNgMqD 2rlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762797205; x=1763402005; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XUcDXkPejgMco2JfdbhYSJS3kdJZuowM1tOw4yzk4R0=; b=EKyOsQeIdgHJloR+j7nmlvl2bYy74VKfFByNLmWhYQhYvTijtnH+5Fu7Y/dv/ekyPR DzO/2qENlsAeAuuOGPWV7bs4mVW9FNfZcCR6E39pQrKniqYZMjLOxKmymLPUUV+HEUrz ClF6P7HHzLdrSJIfBVOTbd/ZN8Y5sT3dwFQ3ltvqxWhe1urtJHsA5QtVBLkDh/6LBK80 d8xvGhlMUwPn1GcvSwYfbqJT2NBwaL2Wum3LEu9Q1lcAiNkAoG9/OOokfuiqgUA+ypF3 08BeHfs0EwXIRGUGKeaKM4IUbeEIjFi14AmkH8hvuOzcrGYQQAdC6p9zyxqlVcv2jOag Hvxg== X-Forwarded-Encrypted: i=1; AJvYcCWu0APu440Az3Uhft2GSQr8nojSx34Iqd3HV2R3yVzIv2eSKVA47blqzHUGdBAuEnLZsiBevph4NJVkLZI=@vger.kernel.org X-Gm-Message-State: AOJu0YwiqmpYAbovt/237RCbnlVXDx4uq4hoBCfLx62QiAwrmy76YhqX 1kAYXVdZiF24wRmNhWZAkdL5qRBRdTT+NmUnBJXkrtb8/W9PyguAroGS9rGsj2iNp/Y= X-Gm-Gg: ASbGncvrXbDCQsiAeOPE3I/ofXmsYIAl1lTKD8mPNI56AK/vS013x0eioLYjvyvNb9y WnD1wYtGRPFTrPu/PQYsNSIS8V3hlvM6L8LY75g0pt3Nl4a3xCoMGo/fYZ7FZy+PLK76kM1o5iu 4qMh8q2M4Q1OdHub7GBJASsqQdck6HrXef7aMMi7aKxWMS9koRpFbTXy0FphvXBGSU179fI7SMD NakQu94HEwZi8jOhDoflkBoklX4goKDOdHN5jX74Fh0sRbVbc+J/TY+ZM4cXY8XoNIkjN10pVkU fer0LS80zIWAnwVr38MDEY7NHhgEzao6ICGImR8Tmgiu7whevc/kxtfyThc020jGbzcJhXiXmrI 7JxE3emru3CSlZPyozO+ZYSyj14m8czXBE1SRjXfROXNmZGVFvDm/Es6MekpT1o1ApN6T41n3a1 ajDr6+CcOiZqpgIPAs2cozMxc+ X-Google-Smtp-Source: AGHT+IFoANBS+IaD+50u8WEIs8LTu+6CF+x94Eog59zLa6zFUQ0ovUDXHwdutBc/eywjQzKVHdO8mQ== X-Received: by 2002:a05:6a20:430b:b0:352:7cc0:93b7 with SMTP id adf61e73a8af0-353a38596eamr10965577637.40.1762797204710; Mon, 10 Nov 2025 09:53:24 -0800 (PST) Received: from localhost.localdomain ([49.37.219.248]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7b0cc17ad4asm12525193b3a.37.2025.11.10.09.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 09:53:24 -0800 (PST) From: Abdun Nihaal To: linux-wireless@vger.kernel.org Cc: Abdun Nihaal , linux-kernel@vger.kernel.org Subject: [PATCH] wifi: cw1200: Fix potential memory leak in cw1200_bh_rx_helper() Date: Mon, 10 Nov 2025 23:23:15 +0530 Message-ID: <20251110175316.106591-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one of the error paths, the memory allocated for skb_rx is not freed. Fix that by freeing it before returning. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN = chipsets") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/wireless/st/cw1200/bh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/= cw1200/bh.c index 3b4ded2ac801..37232ee22037 100644 --- a/drivers/net/wireless/st/cw1200/bh.c +++ b/drivers/net/wireless/st/cw1200/bh.c @@ -317,10 +317,12 @@ static int cw1200_bh_rx_helper(struct cw1200_common *= priv, =20 if (wsm_id & 0x0400) { int rc =3D wsm_release_tx_buffer(priv, 1); - if (WARN_ON(rc < 0)) + if (WARN_ON(rc < 0)) { + dev_kfree_skb(skb_rx); return rc; - else if (rc > 0) + } else if (rc > 0) { *tx =3D 1; + } } =20 /* cw1200_wsm_rx takes care on SKB livetime */ --=20 2.43.0