From nobody Mon Feb 9 10:25:44 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BB2C3148C4 for ; Mon, 10 Nov 2025 16:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762792651; cv=none; b=ElGdKsaG8DGWi2Q4eYSZ9aEh2yBLt9A3pwIqZaMcmMJWPNUxtzzXpup52v9IdJWfwtZpzrpJooZLEujJWf0j9EqowU3Yp/ToI8FLysX8cqdnwinInTQsLPwypdMCokjASsdGkLCuY0ApVP18jzDAap7cxFjrJoh3c5CSOcoiijM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762792651; c=relaxed/simple; bh=g1wEhkOGJQ86eJMHw7XszrU/CWcE9VZPoVm5H+XJaoM=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k42+ejQw+4vl3OBI5ZEk9egUNC+Pi3CQh8sZe2YLcojYXLPIRxhh+5ihav0WtwNfzO0da9uCuC6G2r3ro3k6ZCvWdybydZJ6HtW6rrqpdp7z7CBUfLuDQTNxisImtlRw4RYub0rGLBGTq7OSM7KlSCwYSUDjy1Q8waSHg6WgLUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V/ccWJ/u; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V/ccWJ/u" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-298144fb9bcso11585705ad.0 for ; Mon, 10 Nov 2025 08:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762792642; x=1763397442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pLWfzYX4fFMPPLWMDyPb3KZEfyFxyFdWrCERfTSFQ90=; b=V/ccWJ/utRobCre/Wz8e8tqbqycDisjP2q87TSxtuMthhKPQTlu72MM666VB7dt95R DWQdUBORZ7JcxOtEySRkd4jisgm9Ju6tflUABM5MjOr3ed8oO7kOqRn3fAO4WltThERS ta1qbnUkWkgpoyTSGTSInWj1vh6xSOx3dwX9s4fmAgF9cKcbf3bCKGbM5h3cXNiLQhVi 385RRvWom1Mv9QZIpo5HqR7bJYazQyMIzPa4hFWU6Sd0F5O+9rbvTGHnsxVUDGKUpaWI rZM8jnRZpLRPlgMkXWYN8sJyA2O4G1QYyn1EAjbfBIoJrYLSGj2FkgjtLf8p80VhE71p UA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762792642; x=1763397442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pLWfzYX4fFMPPLWMDyPb3KZEfyFxyFdWrCERfTSFQ90=; b=lcBsv4ZEUWiHRhfY/HUHnqx00+I/AzYRT2HHyj+I0tcsJIzuBN9ys2ydCMhlkPUGK7 hs/7Nxla6lXI8Mzw71y88BZE8JYjxSeNu/ylxl92FC0CSD7sp5SHbLiWVwIU+aPPqNfA DN95wOYpdQzD/PximlsxEX5kBQy3weLu7JEvhb1Ux7WeH6k2nzEszhU6JSuij86bEkg4 eRL1tNSn+VNIejwwyx2kjXEdpQhQ0xW051pj7jW0J+h0fSxGmzVRgtKpIZSXBNiRZCeH zIJr8YRwXZ15qHCEb01/iyygyiFa1TQ02BT37lAHLjDTzAh/u+5I22ceaUIYV8EIWWcc mWFQ== X-Forwarded-Encrypted: i=1; AJvYcCWySJLW7ufATzUWgPH6ZT8joNTd290RL0f+O3gMLphVtkn/BmtuP/xdCFtflQj8ugBqsxtksvqNSj/++D8=@vger.kernel.org X-Gm-Message-State: AOJu0YzGFEr/pG8FbPJ7/M/iTIYHRuUjoETokcJWUUXVEDMmZWWSIhWT Ie5ebTblYfK71iSjyzvCAsIU503EFKLdaVHlHiVEMIFImo57cD33VK6j X-Gm-Gg: ASbGncvPZ7l8rTqFnw25++6vDMX11Th126SOTOVw5ElBMOq5Q1xKLf0sqEnqgPwAnrV JqRct2w2izceGrXnJ1SmSaon+CZSDg42WO5NGhOpdeeHMNLIyaBuRrOCNOOzwhMGUBSR/d4OA9h aF8ap3LFcdNxUPPCGUE+5oX7arhH+00RYBuR8k8M7eg7WmcgVK90udLLnGSVJI/AiehvGGU5EHD 4v9ct89GovOAOz84kCOR1uQ7L65w8LxRLt4a0ONgV99081uV1YooENJMw//moy4tuPHZxgXBtwb ZKmPXz35IcAsQ8VJdfQnCrRrixzZvbo7fHfxLxAO92ijUcUJ0QsiuLP0ZrbuV8AtGzGDBUeqvvO CdADgFMfsjgWu80yRG3IRbi2kYPzDYTXKojjk2vMLtk26pZQhGwJbod+ecVbU/MwHbHF+XsbuH8 uF45DYvlYaDmg= X-Google-Smtp-Source: AGHT+IG/cFQI/lmXu5Y2kAApFRNeOGqv88LbladeQ9d14Tfk1RPsTiArc8xlLuvBlu4N/APLeeqQog== X-Received: by 2002:a17:902:f791:b0:297:e267:c4c1 with SMTP id d9443c01a7336-297e5718125mr109122315ad.55.1762792641884; Mon, 10 Nov 2025 08:37:21 -0800 (PST) Received: from localhost ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29651c740b5sm154589925ad.70.2025.11.10.08.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 08:37:21 -0800 (PST) From: Jinchao Wang To: Andrew Morton , "Masami Hiramatsu (Google)" , Peter Zijlstra , Randy Dunlap , Marco Elver , Mike Rapoport , Alexander Potapenko , Adrian Hunter , Alexander Shishkin , Alice Ryhl , Andrey Konovalov , Andrey Ryabinin , Andrii Nakryiko , Ard Biesheuvel , Arnaldo Carvalho de Melo , Ben Segall , Bill Wendling , Borislav Petkov , Catalin Marinas , Dave Hansen , David Hildenbrand , David Kaplan , "David S. Miller" , Dietmar Eggemann , Dmitry Vyukov , "H. Peter Anvin" , Ian Rogers , Ingo Molnar , James Clark , Jinchao Wang , Jinjie Ruan , Jiri Olsa , Jonathan Corbet , Juri Lelli , Justin Stitt , kasan-dev@googlegroups.com, Kees Cook , "Liam R. Howlett" , "Liang Kan" , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, llvm@lists.linux.dev, Lorenzo Stoakes , Mark Rutland , Masahiro Yamada , Mathieu Desnoyers , Mel Gorman , Michal Hocko , Miguel Ojeda , Nam Cao , Namhyung Kim , Nathan Chancellor , Naveen N Rao , Nick Desaulniers , Rong Xu , Sami Tolvanen , Steven Rostedt , Suren Baghdasaryan , Thomas Gleixner , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Valentin Schneider , Vincent Guittot , Vincenzo Frascino , Vlastimil Babka , Will Deacon , workflows@vger.kernel.org, x86@kernel.org Subject: [PATCH v8 09/27] mm/ksw: ignore false positives from exit trampolines Date: Tue, 11 Nov 2025 00:36:04 +0800 Message-ID: <20251110163634.3686676-10-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110163634.3686676-1-wangjinchao600@gmail.com> References: <20251110163634.3686676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Because trampolines run after the watched function returns but before the exit_handler is called, and in the original stack frame, so the trampoline code may overwrite the watched stack address. These false positives should be ignored. is_ftrace_trampoline() does not cover all trampolines, so add a local check to handle the remaining cases. Signed-off-by: Jinchao Wang --- mm/kstackwatch/watch.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index 3817a172dc25..f922b4164be5 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -2,6 +2,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 #include +#include #include #include #include @@ -14,10 +15,46 @@ static DEFINE_MUTEX(all_wp_mutex); =20 static ulong holder; =20 +#define TRAMPOLINE_NAME "return_to_handler" +#define TRAMPOLINE_DEPTH 16 + +/* Resolved once, then reused */ +static unsigned long tramp_start, tramp_end; + +static void ksw_watch_resolve_trampoline(void) +{ + unsigned long sz, off; + + if (likely(tramp_start && tramp_end)) + return; + + tramp_start =3D kallsyms_lookup_name(TRAMPOLINE_NAME); + if (tramp_start && kallsyms_lookup_size_offset(tramp_start, &sz, &off)) + tramp_end =3D tramp_start + sz; +} + +static bool ksw_watch_in_trampoline(unsigned long ip) +{ + if (tramp_start && tramp_end && ip >=3D tramp_start && ip < tramp_end) + return true; + return false; +} static void ksw_watch_handler(struct perf_event *bp, struct perf_sample_data *data, struct pt_regs *regs) { + unsigned long entries[TRAMPOLINE_DEPTH]; + int i, nr =3D 0; + + nr =3D stack_trace_save_regs(regs, entries, TRAMPOLINE_DEPTH, 0); + for (i =3D 0; i < nr; i++) { + //ignore trampoline + if (is_ftrace_trampoline(entries[i])) + return; + if (ksw_watch_in_trampoline(entries[i])) + return; + } + pr_err("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D KStackWatch: Caught stack corrupti= on =3D=3D=3D=3D=3D=3D=3D\n"); pr_err("config %s\n", ksw_get_config()->user_input); dump_stack(); @@ -164,6 +201,7 @@ int ksw_watch_init(void) { int ret; =20 + ksw_watch_resolve_trampoline(); ret =3D ksw_watch_alloc(); if (ret <=3D 0) return -EBUSY; --=20 2.43.0