From nobody Mon Feb 9 05:29:46 2026 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 592CF318146; Mon, 10 Nov 2025 19:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802152; cv=none; b=Zh8O4YTj9DVTJh7d3t1cUzrahC5EHS8GHkzgd+8pWJIHUgpv6MHmG/BirHC1ZHBvXCA6bx12Y27FVli4aULWP6MlkWOohhCVArpi1W6Vy9d760T7wRw0FdwR0b1q6t37RUAIjQruZodFDvAFhLwSatfgBGIwQDIpxQSENRweThs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802152; c=relaxed/simple; bh=WjXwOm2Yr8Ij8qCbPNopPeBi/pr03nYMCV2DdL5d/q8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uC/0L/EU+ePe00yQBHRm4exPtaiU6EXpos/tPBCBUxzMSYkKizUc0G06aD9mpFQwLzPHdQdnM5skz3+mxCb+WJaTw/kAbYoF0NoL8PapHWkYI3hpjwra2wAfIs9wIQ6F7VsAakMAj0OMN2AtQvR3QRJzU0ONCoxzx99DDvJdw0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 1F2B81C0240; Mon, 10 Nov 2025 20:10:30 +0100 (CET) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdd8:ff00:36bc:9812:27d4:17cf]) by srv01.abscue.de (Postfix) with ESMTPSA id 98CF71C0037; Mon, 10 Nov 2025 20:10:29 +0100 (CET) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Mon, 10 Nov 2025 20:08:58 +0100 Subject: [PATCH v2 1/3] mfd: sprd-sc27xx: Integrate power off and reboot support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251110-sc27xx-mfd-poweroff-v2-1-fd5842e732fe@abscue.de> References: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> In-Reply-To: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> To: Lee Jones , Orson Zhai , Baolin Wang , Chunyan Zhang , Mark Brown , Sebastian Reichel Cc: Rob Herring , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 The SC27xx PMICs allow restarting and powering off the device. Since this functionality is rather simple and not configurable in any way, make it part of the main PMIC driver. Signed-off-by: Otto Pfl=C3=BCger Tested-by: Cixi Geng --- drivers/mfd/sprd-sc27xx-spi.c | 148 ++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 148 insertions(+) diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index d6b4350779e6aecfa19d9fa21b9174447d589e33..250938db549cbba1428371b20f9= 2ad48ca9557f7 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -21,10 +22,48 @@ #define SPRD_SC2730_IRQ_BASE 0x80 #define SPRD_SC2730_IRQ_NUMS 10 #define SPRD_SC2730_CHG_DET 0x1b9c + +#define SPRD_SC2730_PWR_PD_HW 0x1820 +#define SPRD_SC2730_SOFT_RST_HW 0x1824 +#define SPRD_SC2730_SLP_CTRL 0x1a48 +#define SPRD_SC2730_RST_STATUS 0x1bac +#define SPRD_SC2730_SWRST_CTRL0 0x1bf8 + #define SPRD_SC2731_IRQ_BASE 0x140 #define SPRD_SC2731_IRQ_NUMS 16 #define SPRD_SC2731_CHG_DET 0xedc =20 +#define SPRD_SC2731_PWR_PD_HW 0xc2c +#define SPRD_SC2731_SLP_CTRL 0xdf0 +#define SPRD_SC2731_RST_STATUS 0xee8 + +/* PMIC power off and reset definition */ +#define SPRD_SC2730_LDO_XTL_EN BIT(2) +#define SPRD_SC2730_SLP_LDO_PD_EN BIT(0) + +#define SPRD_SC2731_LDO_XTL_EN BIT(3) +#define SPRD_SC2731_SLP_LDO_PD_EN BIT(0) + +#define SPRD_PMIC_PWR_OFF BIT(0) +#define SPRD_PMIC_RESET BIT(0) +#define SPRD_PMIC_SOFT_RST_EN BIT(4) + +#define HWRST_STATUS_SECURITY 0x02 +#define HWRST_STATUS_RECOVERY 0x20 +#define HWRST_STATUS_NORMAL 0x40 +#define HWRST_STATUS_ALARM 0x50 +#define HWRST_STATUS_SLEEP 0x60 +#define HWRST_STATUS_FASTBOOT 0x30 +#define HWRST_STATUS_SPECIAL 0x70 +#define HWRST_STATUS_PANIC 0x80 +#define HWRST_STATUS_CFTREBOOT 0x90 +#define HWRST_STATUS_AUTODLOADER 0xa0 +#define HWRST_STATUS_IQMODE 0xb0 +#define HWRST_STATUS_SPRDISK 0xc0 +#define HWRST_STATUS_FACTORYTEST 0xe0 +#define HWRST_STATUS_WATCHDOG 0xf0 +#define HWRST_STATUS_MASK 0xff + /* PMIC charger detection definition */ #define SPRD_PMIC_CHG_DET_DELAY_US 200000 #define SPRD_PMIC_CHG_DET_TIMEOUT 2000000 @@ -48,6 +87,14 @@ struct sprd_pmic_data { u32 irq_base; u32 num_irqs; u32 charger_det; + + u32 poweroff_reg; + u32 slp_ctrl_reg; + u32 slp_ctrl_mask; + + u32 reset_reg; + u32 rst_sts_reg; + u32 swrst_ctrl_reg; }; =20 /* @@ -59,12 +106,26 @@ static const struct sprd_pmic_data sc2730_data =3D { .irq_base =3D SPRD_SC2730_IRQ_BASE, .num_irqs =3D SPRD_SC2730_IRQ_NUMS, .charger_det =3D SPRD_SC2730_CHG_DET, + + .poweroff_reg =3D SPRD_SC2730_PWR_PD_HW, + .slp_ctrl_reg =3D SPRD_SC2730_SLP_CTRL, + .slp_ctrl_mask =3D SPRD_SC2730_LDO_XTL_EN | SPRD_SC2730_SLP_LDO_PD_EN, + + .reset_reg =3D SPRD_SC2730_SOFT_RST_HW, + .rst_sts_reg =3D SPRD_SC2730_RST_STATUS, + .swrst_ctrl_reg =3D SPRD_SC2730_SWRST_CTRL0, }; =20 static const struct sprd_pmic_data sc2731_data =3D { .irq_base =3D SPRD_SC2731_IRQ_BASE, .num_irqs =3D SPRD_SC2731_IRQ_NUMS, .charger_det =3D SPRD_SC2731_CHG_DET, + + .poweroff_reg =3D SPRD_SC2731_PWR_PD_HW, + .slp_ctrl_reg =3D SPRD_SC2731_SLP_CTRL, + .slp_ctrl_mask =3D SPRD_SC2731_LDO_XTL_EN | SPRD_SC2731_SLP_LDO_PD_EN, + + .rst_sts_reg =3D SPRD_SC2731_RST_STATUS, }; =20 enum usb_charger_type sprd_pmic_detect_charger_type(struct device *dev) @@ -149,6 +210,77 @@ static const struct regmap_config sprd_pmic_config =3D= { .max_register =3D 0xffff, }; =20 +static int sprd_pmic_poweroff(struct sys_off_data *off_data) +{ + struct sprd_pmic *ddata =3D off_data->cb_data; + const struct sprd_pmic_data *pdata =3D ddata->pdata; + + regmap_clear_bits(ddata->regmap, pdata->slp_ctrl_reg, pdata->slp_ctrl_mas= k); + + regmap_write(ddata->regmap, pdata->poweroff_reg, SPRD_PMIC_PWR_OFF); + + mdelay(1000); + + dev_err(ddata->dev, "Unable to poweroff system\n"); + + return NOTIFY_DONE; +} + +static int sprd_pmic_restart(struct sys_off_data *off_data) +{ + struct sprd_pmic *ddata =3D off_data->cb_data; + const struct sprd_pmic_data *pdata =3D ddata->pdata; + u32 reboot_mode; + + if (!off_data->cmd) + reboot_mode =3D HWRST_STATUS_NORMAL; + else if (!strcmp(off_data->cmd, "recovery")) + reboot_mode =3D HWRST_STATUS_RECOVERY; + else if (!strcmp(off_data->cmd, "alarm")) + reboot_mode =3D HWRST_STATUS_ALARM; + else if (!strcmp(off_data->cmd, "fastsleep")) + reboot_mode =3D HWRST_STATUS_SLEEP; + else if (!strcmp(off_data->cmd, "bootloader")) + reboot_mode =3D HWRST_STATUS_FASTBOOT; + else if (!strcmp(off_data->cmd, "panic")) + reboot_mode =3D HWRST_STATUS_PANIC; + else if (!strcmp(off_data->cmd, "special")) + reboot_mode =3D HWRST_STATUS_SPECIAL; + else if (!strcmp(off_data->cmd, "cftreboot")) + reboot_mode =3D HWRST_STATUS_CFTREBOOT; + else if (!strcmp(off_data->cmd, "autodloader")) + reboot_mode =3D HWRST_STATUS_AUTODLOADER; + else if (!strcmp(off_data->cmd, "iqmode")) + reboot_mode =3D HWRST_STATUS_IQMODE; + else if (!strcmp(off_data->cmd, "sprdisk")) + reboot_mode =3D HWRST_STATUS_SPRDISK; + else if (!strcmp(off_data->cmd, "tospanic")) + reboot_mode =3D HWRST_STATUS_SECURITY; + else if (!strcmp(off_data->cmd, "factorytest")) + reboot_mode =3D HWRST_STATUS_FACTORYTEST; + else + reboot_mode =3D HWRST_STATUS_NORMAL; + + regmap_update_bits(ddata->regmap, pdata->rst_sts_reg, + HWRST_STATUS_MASK, reboot_mode); + + /* + * On SC2731, this part is skipped because there is no reset register + * and the restart must be performed using the watchdog. + */ + if (pdata->reset_reg) { + regmap_set_bits(ddata->regmap, pdata->swrst_ctrl_reg, SPRD_PMIC_SOFT_RST= _EN); + + regmap_write(ddata->regmap, pdata->reset_reg, SPRD_PMIC_RESET); + + mdelay(1000); + + dev_err(ddata->dev, "Unable to restart system\n"); + } + + return NOTIFY_DONE; +} + static int sprd_pmic_probe(struct spi_device *spi) { struct sprd_pmic *ddata; @@ -204,6 +336,22 @@ static int sprd_pmic_probe(struct spi_device *spi) return ret; } =20 + ret =3D devm_register_sys_off_handler(&spi->dev, SYS_OFF_MODE_RESTART, + SYS_OFF_PRIO_HIGH, + sprd_pmic_restart, ddata); + if (ret) { + dev_err(&spi->dev, "Failed to register restart handler: %d\n", ret); + return ret; + } + + ret =3D devm_register_sys_off_handler(&spi->dev, SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_DEFAULT, + sprd_pmic_poweroff, ddata); + if (ret) { + dev_err(&spi->dev, "Failed to register poweroff handler: %d\n", ret); + return ret; + } + ret =3D devm_of_platform_populate(&spi->dev); if (ret) { dev_err(&spi->dev, "Failed to populate sub-devices %d\n", ret); --=20 2.50.0 From nobody Mon Feb 9 05:29:46 2026 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5934D321F31; Mon, 10 Nov 2025 19:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802153; cv=none; b=AtaoxkeoIhSTXOmAuf6Kp5LddgFf4VeDKYTfCz8HbUzkoaKZWx22uvoW6cyd7m7Rf/YSoSNnwnBNFQOaMY+AfYzXteRn5UhW8TVFzBk2hZUyqXyFYiZBeURIERTh4xRZypeYf9GGchgjZy86HAuD3Z6xZX0M2jKGlWOSmffxTw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802153; c=relaxed/simple; bh=cBXYI7Ip6U6YABa4Zfp8DyYBdPx77L6yue/v252LACw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eOguXQ+1llbm3pvhGrUDxKXLlFdQxolRSgl+vu/ib8cfVBTyVTgVaHZgDuZjsJFE1/7/Q1Y2x8MgNeU3Jk9Kgu59jzDFa8aVk1NmJ0vawewFmCthTU7ru0zHmqXf6kr9e2EQLzS6QBTbYCw1AC0DShXb/IzJ9SgBHvYzH74jQt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 6CAFF1C24F0; Mon, 10 Nov 2025 20:10:30 +0100 (CET) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdd8:ff00:36bc:9812:27d4:17cf]) by srv01.abscue.de (Postfix) with ESMTPSA id E45B81C0038; Mon, 10 Nov 2025 20:10:29 +0100 (CET) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Mon, 10 Nov 2025 20:08:59 +0100 Subject: [PATCH v2 2/3] spi: sprd-adi: Remove code for storing the reboot mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251110-sc27xx-mfd-poweroff-v2-2-fd5842e732fe@abscue.de> References: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> In-Reply-To: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> To: Lee Jones , Orson Zhai , Baolin Wang , Chunyan Zhang , Mark Brown , Sebastian Reichel Cc: Rob Herring , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= X-Mailer: b4 0.14.2 This functionality is now provided by the PMIC driver. Ideally, the entire reboot code should be removed since it does not belong in the bus driver, but it is kept for now since there is no driver for the PMIC watchdog on SC2731 yet. Acked-by: Mark Brown Signed-off-by: Otto Pfl=C3=BCger Tested-by: Cixi Geng --- drivers/spi/spi-sprd-adi.c | 73 +-----------------------------------------= ---- 1 file changed, 1 insertion(+), 72 deletions(-) diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c index 262c11d977ea350c3b8a861064d9f109cc57a45e..47e6fbbf9991dbe77ad22e03c97= 09e6ee3a1b01e 100644 --- a/drivers/spi/spi-sprd-adi.c +++ b/drivers/spi/spi-sprd-adi.c @@ -101,27 +101,10 @@ #define BIT_WDG_EN BIT(2) =20 /* Registers definitions for PMIC */ -#define PMIC_RST_STATUS 0xee8 #define PMIC_MODULE_EN 0xc08 #define PMIC_CLK_EN 0xc18 #define PMIC_WDG_BASE 0x80 =20 -/* Definition of PMIC reset status register */ -#define HWRST_STATUS_SECURITY 0x02 -#define HWRST_STATUS_RECOVERY 0x20 -#define HWRST_STATUS_NORMAL 0x40 -#define HWRST_STATUS_ALARM 0x50 -#define HWRST_STATUS_SLEEP 0x60 -#define HWRST_STATUS_FASTBOOT 0x30 -#define HWRST_STATUS_SPECIAL 0x70 -#define HWRST_STATUS_PANIC 0x80 -#define HWRST_STATUS_CFTREBOOT 0x90 -#define HWRST_STATUS_AUTODLOADER 0xa0 -#define HWRST_STATUS_IQMODE 0xb0 -#define HWRST_STATUS_SPRDISK 0xc0 -#define HWRST_STATUS_FACTORYTEST 0xe0 -#define HWRST_STATUS_WATCHDOG 0xf0 - /* Use default timeout 50 ms that converts to watchdog values */ #define WDG_LOAD_VAL ((50 * 32768) / 1000) #define WDG_LOAD_MASK GENMASK(15, 0) @@ -139,7 +122,6 @@ struct sprd_adi_data { u32 slave_addr_size; int (*read_check)(u32 val, u32 reg); int (*restart)(struct sys_off_data *data); - void (*wdg_rst)(void *p); }; =20 struct sprd_adi { @@ -355,58 +337,10 @@ static int sprd_adi_transfer_one(struct spi_controlle= r *ctlr, return ret; } =20 -static void sprd_adi_set_wdt_rst_mode(void *p) -{ -#if IS_ENABLED(CONFIG_SPRD_WATCHDOG) - u32 val; - struct sprd_adi *sadi =3D (struct sprd_adi *)p; - - /* Init watchdog reset mode */ - sprd_adi_read(sadi, PMIC_RST_STATUS, &val); - val |=3D HWRST_STATUS_WATCHDOG; - sprd_adi_write(sadi, PMIC_RST_STATUS, val); -#endif -} - static int sprd_adi_restart(struct sprd_adi *sadi, unsigned long mode, const char *cmd, struct sprd_adi_wdg *wdg) { - u32 val, reboot_mode =3D 0; - - if (!cmd) - reboot_mode =3D HWRST_STATUS_NORMAL; - else if (!strncmp(cmd, "recovery", 8)) - reboot_mode =3D HWRST_STATUS_RECOVERY; - else if (!strncmp(cmd, "alarm", 5)) - reboot_mode =3D HWRST_STATUS_ALARM; - else if (!strncmp(cmd, "fastsleep", 9)) - reboot_mode =3D HWRST_STATUS_SLEEP; - else if (!strncmp(cmd, "bootloader", 10)) - reboot_mode =3D HWRST_STATUS_FASTBOOT; - else if (!strncmp(cmd, "panic", 5)) - reboot_mode =3D HWRST_STATUS_PANIC; - else if (!strncmp(cmd, "special", 7)) - reboot_mode =3D HWRST_STATUS_SPECIAL; - else if (!strncmp(cmd, "cftreboot", 9)) - reboot_mode =3D HWRST_STATUS_CFTREBOOT; - else if (!strncmp(cmd, "autodloader", 11)) - reboot_mode =3D HWRST_STATUS_AUTODLOADER; - else if (!strncmp(cmd, "iqmode", 6)) - reboot_mode =3D HWRST_STATUS_IQMODE; - else if (!strncmp(cmd, "sprdisk", 7)) - reboot_mode =3D HWRST_STATUS_SPRDISK; - else if (!strncmp(cmd, "tospanic", 8)) - reboot_mode =3D HWRST_STATUS_SECURITY; - else if (!strncmp(cmd, "factorytest", 11)) - reboot_mode =3D HWRST_STATUS_FACTORYTEST; - else - reboot_mode =3D HWRST_STATUS_NORMAL; - - /* Record the reboot mode */ - sprd_adi_read(sadi, wdg->rst_sts, &val); - val &=3D ~HWRST_STATUS_WATCHDOG; - val |=3D reboot_mode; - sprd_adi_write(sadi, wdg->rst_sts, val); + u32 val; =20 /* Enable the interface clock of the watchdog */ sprd_adi_read(sadi, wdg->wdg_en, &val); @@ -448,7 +382,6 @@ static int sprd_adi_restart_sc9860(struct sys_off_data = *data) { struct sprd_adi_wdg wdg =3D { .base =3D PMIC_WDG_BASE, - .rst_sts =3D PMIC_RST_STATUS, .wdg_en =3D PMIC_MODULE_EN, .wdg_clk =3D PMIC_CLK_EN, }; @@ -568,9 +501,6 @@ static int sprd_adi_probe(struct platform_device *pdev) =20 sprd_adi_hw_init(sadi); =20 - if (sadi->data->wdg_rst) - sadi->data->wdg_rst(sadi); - ctlr->dev.of_node =3D pdev->dev.of_node; ctlr->bus_num =3D pdev->id; ctlr->num_chipselect =3D num_chipselect; @@ -606,7 +536,6 @@ static struct sprd_adi_data sc9860_data =3D { .slave_addr_size =3D ADI_10BIT_SLAVE_ADDR_SIZE, .read_check =3D sprd_adi_read_check_r2, .restart =3D sprd_adi_restart_sc9860, - .wdg_rst =3D sprd_adi_set_wdt_rst_mode, }; =20 static struct sprd_adi_data sc9863_data =3D { --=20 2.50.0 From nobody Mon Feb 9 05:29:46 2026 Received: from srv01.abscue.de (abscue.de [89.58.28.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 535F0136351; Mon, 10 Nov 2025 19:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.58.28.240 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802152; cv=none; b=bI8S34pHhZ7PMf+NNwauMafmS5+lAqfE/YmHS3uvUh6F6zboBVyzWd0LVy9HB1e5JAr3cQNW0pS8jiCPecL7CAJgwgVlpF8unbTELWo5t7Aus6g/BKJ9oPjllxhqHjeuFv6AuBUivRtSv7vjBocsROchbAKjcUgl7r6QszMvCJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762802152; c=relaxed/simple; bh=id2JJee4nGZVhNPaZX1f6WOSr0vjJcvlPgl2F1hrb+E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pd6t0VP4DWp3EMAPLUKWN8WzNHW5uLYyCCC1PbeTrzKUYZaxjGJ4PV+s7HSo+6JridygNTgyNf18qPYCErx6OBaFnW76MSA/DJ8NqVdzYlzWrh4zLBj+tHduYRIeroB2ZIRDIzFMxtH1J2XpO9pN7wgN0tg4LiT67k2XCI/ABNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de; spf=pass smtp.mailfrom=abscue.de; arc=none smtp.client-ip=89.58.28.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=abscue.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=abscue.de Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 887CB1C0036; Mon, 10 Nov 2025 20:10:33 +0100 (CET) X-Spam-Level: Received: from fluffy-mammal.metal.fwg-cag.de (unknown [IPv6:2001:9e8:cdd8:ff00:36bc:9812:27d4:17cf]) by srv01.abscue.de (Postfix) with ESMTPSA id 3A6AC1C0241; Mon, 10 Nov 2025 20:10:30 +0100 (CET) From: =?utf-8?q?Otto_Pfl=C3=BCger?= Date: Mon, 10 Nov 2025 20:09:00 +0100 Subject: [PATCH v2 3/3] power: reset: sc27xx: Drop unused driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251110-sc27xx-mfd-poweroff-v2-3-fd5842e732fe@abscue.de> References: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> In-Reply-To: <20251110-sc27xx-mfd-poweroff-v2-0-fd5842e732fe@abscue.de> To: Lee Jones , Orson Zhai , Baolin Wang , Chunyan Zhang , Mark Brown , Sebastian Reichel Cc: Rob Herring , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Otto_Pfl=C3=BCger?= , Sebastian Reichel X-Mailer: b4 0.14.2 This driver was never actually probed because it was missing an OF match table and was not integrated into the MFD driver. Remove it now that the power off functionality is handled directly in the MFD driver. Acked-by: Sebastian Reichel Signed-off-by: Otto Pfl=C3=BCger Tested-by: Cixi Geng --- drivers/power/reset/Kconfig | 9 ---- drivers/power/reset/Makefile | 1 - drivers/power/reset/sc27xx-poweroff.c | 79 -------------------------------= ---- 3 files changed, 89 deletions(-) diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index f6c1bcbb57deff3568d6b1b326454add3b3bbf06..007e2cd53bbfba8dddcd1a71118= ddaf5ec47c0ff 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig @@ -329,15 +329,6 @@ config SYSCON_REBOOT_MODE register, then the bootloader can read it to take different action according to the mode. =20 -config POWER_RESET_SC27XX - tristate "Spreadtrum SC27xx PMIC power-off driver" - depends on MFD_SC27XX_PMIC || COMPILE_TEST - help - This driver supports powering off a system through - Spreadtrum SC27xx series PMICs. The SC27xx series - PMICs includes the SC2720, SC2721, SC2723, SC2730 - and SC2731 chips. - config NVMEM_REBOOT_MODE tristate "Generic NVMEM reboot mode driver" depends on OF diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile index 0e4ae6f6b5c55729cf60846d47e6fe0fec24f3cc..14876511c675bd52a99a10890cd= 685a254f0e030 100644 --- a/drivers/power/reset/Makefile +++ b/drivers/power/reset/Makefile @@ -38,6 +38,5 @@ obj-$(CONFIG_POWER_RESET_SYSCON_POWEROFF) +=3D syscon-pow= eroff.o obj-$(CONFIG_POWER_RESET_RMOBILE) +=3D rmobile-reset.o obj-$(CONFIG_REBOOT_MODE) +=3D reboot-mode.o obj-$(CONFIG_SYSCON_REBOOT_MODE) +=3D syscon-reboot-mode.o -obj-$(CONFIG_POWER_RESET_SC27XX) +=3D sc27xx-poweroff.o obj-$(CONFIG_NVMEM_REBOOT_MODE) +=3D nvmem-reboot-mode.o obj-$(CONFIG_POWER_MLXBF) +=3D pwr-mlxbf.o diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc= 27xx-poweroff.c deleted file mode 100644 index 90287c31992c4889f9241e82a21a1949ecca7702..000000000000000000000000000= 0000000000000 --- a/drivers/power/reset/sc27xx-poweroff.c +++ /dev/null @@ -1,79 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Copyright (C) 2018 Spreadtrum Communications Inc. - * Copyright (C) 2018 Linaro Ltd. - */ - -#include -#include -#include -#include -#include -#include -#include - -#define SC27XX_PWR_PD_HW 0xc2c -#define SC27XX_PWR_OFF_EN BIT(0) -#define SC27XX_SLP_CTRL 0xdf0 -#define SC27XX_LDO_XTL_EN BIT(3) - -static struct regmap *regmap; - -/* - * On Spreadtrum platform, we need power off system through external SC27xx - * series PMICs, and it is one similar SPI bus mapped by regmap to access = PMIC, - * which is not fast io access. - * - * So before stopping other cores, we need release other cores' resource by - * taking cpus down to avoid racing regmap or spi mutex lock when poweroff - * system through PMIC. - */ -static void sc27xx_poweroff_shutdown(void) -{ -#ifdef CONFIG_HOTPLUG_CPU - int cpu; - - for_each_online_cpu(cpu) { - if (cpu !=3D smp_processor_id()) - remove_cpu(cpu); - } -#endif -} - -static struct syscore_ops poweroff_syscore_ops =3D { - .shutdown =3D sc27xx_poweroff_shutdown, -}; - -static void sc27xx_poweroff_do_poweroff(void) -{ - /* Disable the external subsys connection's power firstly */ - regmap_write(regmap, SC27XX_SLP_CTRL, SC27XX_LDO_XTL_EN); - - regmap_write(regmap, SC27XX_PWR_PD_HW, SC27XX_PWR_OFF_EN); -} - -static int sc27xx_poweroff_probe(struct platform_device *pdev) -{ - if (regmap) - return -EINVAL; - - regmap =3D dev_get_regmap(pdev->dev.parent, NULL); - if (!regmap) - return -ENODEV; - - pm_power_off =3D sc27xx_poweroff_do_poweroff; - register_syscore_ops(&poweroff_syscore_ops); - return 0; -} - -static struct platform_driver sc27xx_poweroff_driver =3D { - .probe =3D sc27xx_poweroff_probe, - .driver =3D { - .name =3D "sc27xx-poweroff", - }, -}; -module_platform_driver(sc27xx_poweroff_driver); - -MODULE_DESCRIPTION("Power off driver for SC27XX PMIC Device"); -MODULE_AUTHOR("Baolin Wang "); -MODULE_LICENSE("GPL v2"); --=20 2.50.0