From nobody Mon Feb 9 13:52:44 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8333303C85 for ; Sun, 9 Nov 2025 17:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762707970; cv=none; b=nTtw0AFU/42qWYz8uH8X74O+v5QtodRyiPk65QL6MWdTFM6btvpsuAQgXiizKq7xOyyj8ZuGUt2M/uMqzDl1CcIjCBuMJEvxk69l8DYW7Cv0eOUCCNBlT/OIHc7IuQBOrnRnOAhIjp7UDL9zLFgaK0DUmCuH0RUSMoVZVixSD08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762707970; c=relaxed/simple; bh=BqSH1sGgWhPw1gfWfRVD15p+7RBCWiB0kCRAPxIY/aE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RZWlCwr6+erdGGoCksz1xBzWlxIwH9RPC7S9ku3fSw43n/QSBmQ3WssneWpav1KOmFHWO7XHDhws6LMELs1B6M9+lsdqHiuizOzl6KvZaXtUxhlG+gfReEr31fHwriezsRuc8Z/uIjS5fx958qBjjOIG+tOoocuTkN8goIhyM7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=UcpRSje6; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="UcpRSje6" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1762707964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aDs8kbwCuzv3Qb5BmYXwYP5JldsXD1hYrMKIH0qG1uI=; b=UcpRSje6/RzpyOYo4IZVlmL2TUgeeFWnCvceLyMfVeHIEb4eBlwaR4CcWlVCWGoU5zu5AP lWuWl/4+f8LkTxjsEXbKksxigl1NBB4uwVnjcrkbqn+RTZLiBdOxrk6lrzauFKc4UizPWV FjTkOq0ruslJRee4zAL2oZIqjFYKEN4IKoL0O9GtL6mUvilEMEorHZ7siId2w1rf54CRA2 6zlFDjEDDuiNaqi9gaw5YaZRZis4jswAhpo7lK6PnLAw/RYNhPJ+KfkuiIvEMtACcPrGRE ajwH+X7r3SPagdcLBbucKChCCcUjslodsqliwqcqD07DCVAwVF1A3sf0p+wjEQ== From: Diederik de Haas Date: Sun, 09 Nov 2025 18:05:26 +0100 Subject: [PATCH 1/2] arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-1-ed38d200cc04@cknow-tech.com> References: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-0-ed38d200cc04@cknow-tech.com> In-Reply-To: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-0-ed38d200cc04@cknow-tech.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Samuel Holland Cc: hrdl , phantomas , Dragan Simic , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas X-Migadu-Flow: FLOW_OUT The USB-C connector on the PineNote has only 1 port, so there's no need for a 'ports' node with address-/size-cells properties as a single 'port' node suffices. This fixes the following DT validation issue: Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary Signed-off-by: Diederik de Haas --- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64= /boot/dts/rockchip/rk3566-pinenote.dtsi index 5c6f8cc401c9..7c65fe4900be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi @@ -485,16 +485,9 @@ connector { typec-power-opmode =3D "default"; pd-disable; =20 - ports { - #address-cells =3D <0x1>; - #size-cells =3D <0x0>; - - port@0 { - reg =3D <0x0>; - - typec_hs_usb2phy0: endpoint { - remote-endpoint =3D <&usb2phy0_typec_hs>; - }; + port { + typec_hs_usb2phy0: endpoint { + remote-endpoint =3D <&usb2phy0_typec_hs>; }; }; }; --=20 2.51.0 From nobody Mon Feb 9 13:52:44 2026 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15AD93043AF for ; Sun, 9 Nov 2025 17:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762707970; cv=none; b=PziHBAHm3UW2xi0VurOvLjAojLlHLwQmX1c/2INO1gHuOpUvlmS5XYO59WeFsJZ48QQ+Dp4ut5XLfxBb0XJBbbWEuK7/tiLTe822LpP9+A95HJqNfK8QIGYkKAgilwZYKmb/wR67euVNoZzP0biKYfKYcJ6TLkGiUz0BysGv8JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762707970; c=relaxed/simple; bh=RhBkr40435qqQR7ennySLZHbqJD8qlvK6xOZ8kA4q/o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lrHf30kczzMD49LiXYCMPsCoV4+c6vq7HK8b7GMbFchwWY0Ri24TZrQIo8ClQWIOcyWm3sD8Y+v8XfN+l7uukpFAT6W1Td65tFOy0VMwllI+kJNy6NzdzLuPKznJHj7Y2GkmiwxvGOdUNTme67G0FDKRTVVBTAPYEwEx1ISf26w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=mbp3x7HN; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="mbp3x7HN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1762707965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8+c2slFEzvpnuvBcD3m7Q9rIW5GkW6bzoQAArBwQCS8=; b=mbp3x7HNQaUSE3tE8uuKBbakcDwLBufkUi3KvKZ96eOfRvOEvr1SMAq/aw+GpWfufFKohC tnBVGD74pj3pgNji84zBhj5FgdFbSS20wUjFA++wdW9Ch/PRG/6YGQa2FLB0OjhDA6T3EF jWDdAIh5076hTOJvyvoUOF8nqiP48m7TgN6jJslczwnSpzaEKynsj0Oegg+tN51CQRnRhV iSrlnA8RrP08AHrq82oLIVjULKBAvykaeJJ+sTgUjyKdd9HfLA1X6sQ1a7riFeLZSyzn9Z fQ/ppQp6PGIZUuBXXeHrckP483ZxmhSd7GYOXExVdF1TVLYpLG3OGEgAuvI2NA== From: Diederik de Haas Date: Sun, 09 Nov 2025 18:05:27 +0100 Subject: [PATCH 2/2] arm64: dts: rockchip: Move otg-port to controller on rk3566-pinenote Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-2-ed38d200cc04@cknow-tech.com> References: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-0-ed38d200cc04@cknow-tech.com> In-Reply-To: <20251109-rk3566-pinenote-dt-fixes-upstream-v1-0-ed38d200cc04@cknow-tech.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Samuel Holland Cc: hrdl , phantomas , Dragan Simic , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas , stable@vger.kernel.org X-Migadu-Flow: FLOW_OUT The 'rockchip,inno-usb2phy' binding's otg-port node does not have a port node, so the current definition causes this DT validation issue: usb2phy@fe8a0000 (rockchip,rk3568-usb2phy): otg-port: 'port' does not match any of the regexes: '^pinctrl-[0-9]+$' Its purpose was to define the other endpoint for the USB-C connector port. The 'snps,dwc3-common.yaml' DT binding does have a port node to connect the dwc3 to type C connector with the 'usb-role-switch' property. Therefore move the port node to the dwc3 node and add the 'usb-role-switch' property to it. This fixes the above mention DT validation issue. The incorrect definition also caused these kernel errors: rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) w= ith supplier port0 for /usb2phy@fe8a0000/otg-port rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) w= ith supplier 3-0060 for /usb2phy@fe8a0000/otg-port With the changed definition, those errors are now also gone. While at it, remove the 'dr_mode' property as that's already defined in rk356x-base.dtsi and there's no point in redefining it. Fixes: 87a267b4af09 ("arm64: dts: rockchip: Add USB and TCPC to rk3566-pine= note") Cc: stable@vger.kernel.org Signed-off-by: Diederik de Haas --- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64= /boot/dts/rockchip/rk3566-pinenote.dtsi index 7c65fe4900be..be8076a8e30c 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi @@ -694,8 +694,14 @@ &uart2 { }; =20 &usb_host0_xhci { - dr_mode =3D "otg"; + usb-role-switch; status =3D "okay"; + + port { + usb2phy0_typec_hs: endpoint { + remote-endpoint =3D <&typec_hs_usb2phy0>; + }; + }; }; =20 &usb2phy0 { @@ -704,10 +710,4 @@ &usb2phy0 { =20 &usb2phy0_otg { status =3D "okay"; - - port { - usb2phy0_typec_hs: endpoint { - remote-endpoint =3D <&typec_hs_usb2phy0>; - }; - }; }; --=20 2.51.0