From nobody Mon Feb 9 04:14:12 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A272DCBFA for ; Sun, 9 Nov 2025 11:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762686382; cv=none; b=Jt9hvYVTc7Yyu9FQ0FCfdOUS/AORW4TP27KU54iVpqDFYqf0P9xLAeCQjP765ByheLsM1/JQco3XVBUorL7OjtIaKTp1xPi301MMpx1KZCEVkHMKl1qJIJOXUTUQh0WyprSntqfpzmJqT5p2/S+axXErQOT7qYgM2JQvoptp11A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762686382; c=relaxed/simple; bh=Sl57n5h3qnQFQNcmwKkS4S8dI3DCYu3TXVSej6Ds+H8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fWvrxj5xpcKhsQyafgMccxlmTWpB0rd5uYAKYPe0QsFGH5leimcOMbfs480m33aVgNjY8p4r9Bijcqjk+V+I9X5bUwLHhIYZhXlPiPJDmYWG5yicrWh/z7ojr+d+3s+JCD9FvaNpC2up24JUVz+XG24ZQ/avlPu/wRQgwx4357g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJFs75lf; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJFs75lf" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b387483bbso183159f8f.1 for ; Sun, 09 Nov 2025 03:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762686379; x=1763291179; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=85FBK1N7968Zf3zmy7BJUL2wfVMtCnOsN9wdrJDgfgc=; b=hJFs75lfTSw6dZ9ude0fkIzdZfEXfXOneUe+NdXfnS/ZG1l21Ppofl+AXJUrdPKvwo nEr3PTun0Kkmvrh//hhyJBanf2bPN8xIVyrWQVTitZk1Nv3bTMN/MyUuTcLlt3vK63yU RajnY7mQJv7TYrE4tIHcqo/wsl/58Nhuba+RQQDYC5LuVd1wO1TOS7o00VZBKz64eyoG /vsY79s9uO9y5FZK0+F6FPRjZI7zcoZWR39/BTgVAjUVR6XqgFqreSkmdMIM9Oa3lRd0 Da1vT1dZNJFtw1v55W5X7YQc1X3vpR+yLVHwvMuISCQPqqgLGlsF0KrLvMVFyxQoLObF l1kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762686379; x=1763291179; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=85FBK1N7968Zf3zmy7BJUL2wfVMtCnOsN9wdrJDgfgc=; b=SdY+hkCTnmypuVhEqAkVL8y/p956PO6LuKds2zi6DqUKtDnG3Lyf4X8PNYvzjAXrcs YDODQbdo90ICFu/cSvvAjZHAH39IghAJdN7AF5V779aUFEw1Z0mU6+I+Ef7oc1mdqTqN Qrn1hu95s8Fhqy4CEwQl+XaMglGlRcnffYC8lLu+Pn2qDQg4SRueV30WKqwroa4aZ7dJ G1S34praNZzIY+FAVv3NqxVBq0XvcywzEEkrHKy838yW2iM6uifidnCOb9f8jlQG8cda w7axTB+jy5LVbEes8wyjeOcmkVQk4Z0GhjQ+Uc/T147ZqT9YxkLbj5tzDKnWT1gCDomD AcwQ== X-Forwarded-Encrypted: i=1; AJvYcCXE/M/zhQwpRzs6ltSko6Kz/aXfnK0OTxlPl4sRpSiAocfw/GWEQcfvteLYfEfOx+PT7gXWl/yofsfg/xY=@vger.kernel.org X-Gm-Message-State: AOJu0YyylptFWEEd4cyJSdJ+1C/q2KoVG9vCZykl8GmWlY3xcw5UY162 0m3ZFmeoUhxfYYqB7AQDLZsMwOwFUpp+6KGmL9Nh63fwYcTOovzLcpyv X-Gm-Gg: ASbGnctazPzKZX1upJCUhBkpOPw2+NtH6yQm7yZidsdV9ikXK3MhpKqLd3Ms8pV5xNc i4csfsfqL2QNde7H4iES7v0CnknlTH7eQfbmV2dqTJiS4vaa1Zwol3Ek1t5r3MG7kejyJA1dIRe WAMZ6c+/QveVZnWiYDIEOeThBxkqauGx1o5bwrJrgkPQ54s8hw4TKAU7WOMt2JV6jt8aSlAVeKK rtexPPKy7e4u05O1kGhJZvAQU0f31jKEqcrPFHfWisEZxWbwSUFax9RGjASPSitfORWp6ZfGLbd Cd1VR+hflHw4VEJjnkZ6gLqjdTvECGZtlCX4KIf3Se9PFCSckz1NNMxpjvwbjYpN7JeO5FSgXp9 izhdgIM4iayMmoLwD8WdVzOHg46C/jozTIDxX8hyx4thKYYO9JKCjFk4QLgYuZgbccNHLyP+dzg yzUI4x X-Google-Smtp-Source: AGHT+IHFIeiuJChm/jLLid7Ik0+NY4IPeqhmAps90p1OjDHbjatYqMo8FhZ3+4mJG2x/qi9W+hfY8A== X-Received: by 2002:a05:6000:2912:b0:42b:3ace:63cc with SMTP id ffacd0b85a97d-42b3ace6596mr20172f8f.35.1762686379085; Sun, 09 Nov 2025 03:06:19 -0800 (PST) Received: from [192.168.1.243] ([143.58.192.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b316775f2sm6354925f8f.16.2025.11.09.03.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Nov 2025 03:06:18 -0800 (PST) From: Andre Carvalho Date: Sun, 09 Nov 2025 11:05:53 +0000 Subject: [PATCH net-next v3 3/6] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251109-netcons-retrigger-v3-3-1654c280bbe6@gmail.com> References: <20251109-netcons-retrigger-v3-0-1654c280bbe6@gmail.com> In-Reply-To: <20251109-netcons-retrigger-v3-0-1654c280bbe6@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andre Carvalho X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762686373; l=2028; i=asantostc@gmail.com; s=20250807; h=from:subject:message-id; bh=C8sdELlfliWx0wFIHhmVjWXm2jGpSIoVSQHcSClL97Y=; b=VosP6vA0UGMteFuPJJrdAB8s4fo0qd1/JQ+Q+l3P3elVqVgg7+IR5SyFib/tuF7ioDch2jzq2 PLd4XS9fShgDELOMFlnJkQ5b97MLBXZXZgrG/Qc6y8rZBZr0oy34OK2 X-Developer-Key: i=asantostc@gmail.com; a=ed25519; pk=eWre+RwFHCxkiaQrZLsjC67mZ/pZnzSM/f7/+yFXY4Q= From: Breno Leitao When the low level interface brings a netconsole target down, record this using a new STATE_DEACTIVATED state. This allows netconsole to distinguish between targets explicitly disabled by users and those deactivated due to interface state changes. It also enables automatic recovery and re-enabling of targets if the underlying low-level interfaces come back online. From a code perspective, anything that is not STATE_ENABLED is disabled. Mark the device that is down due to NETDEV_UNREGISTER as STATE_DEACTIVATED, this, should be the same as STATE_DISABLED from a code perspective. Signed-off-by: Breno Leitao Signed-off-by: Andre Carvalho --- drivers/net/netconsole.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 2d15f7ab7235..5a374e6d178d 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -120,6 +120,7 @@ enum sysdata_feature { enum target_state { STATE_DISABLED, STATE_ENABLED, + STATE_DEACTIVATED, }; =20 /** @@ -575,6 +576,14 @@ static ssize_t enabled_store(struct config_item *item, if (ret) goto out_unlock; =20 + /* When the user explicitly enables or disables a target that is + * currently deactivated, reset its state to disabled. The DEACTIVATED + * state only tracks interface-driven deactivation and should _not_ + * persist when the user manually changes the target's enabled state. + */ + if (nt->state =3D=3D STATE_DEACTIVATED) + nt->state =3D STATE_DISABLED; + ret =3D -EINVAL; current_enabled =3D nt->state =3D=3D STATE_ENABLED; if (enabled =3D=3D current_enabled) { @@ -1461,7 +1470,7 @@ static int netconsole_netdev_event(struct notifier_bl= ock *this, case NETDEV_RELEASE: case NETDEV_JOIN: case NETDEV_UNREGISTER: - nt->state =3D STATE_DISABLED; + nt->state =3D STATE_DEACTIVATED; list_move(&nt->list, &target_cleanup_list); stopped =3D true; } --=20 2.51.2