From nobody Sat Feb 7 11:25:43 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013045.outbound.protection.outlook.com [40.93.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9398524EF76; Sat, 8 Nov 2025 04:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576794; cv=fail; b=CWeET6As6QOvf9FFRj+7PUv3ZouyEosI3lKvy5dAaqi5LU9d5hhTzBA2mJ8PVXjM6NAOWuN1r2fSrrdyd5JOFQFOHV937b/AZq50Dm3GyWlIZb2GcfUx3Dd46i/DY2RiSP/coMYGN9C7qH0+oj9+LwQyibzofW9U0QJROj/MzcA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576794; c=relaxed/simple; bh=NStJmHuAFNzOyCwIvExH7Oa4iLrLCtRVmMtVgClrJD4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rFGFG25UAy2iQJ1tVdk1AhuOS4b3y7S+QaJxgEYiym7eBttmhfxA9mcmatGlLa+tyq5Eu78a9/EF9SuiJfsPdjcSdg+/2orj1h6VrPZti3c5GwP4iMYrmbtohpwc+qGK9pNeBpT1x4S1s+wBzwMoo63k/5MXr2bA+52VdFseewE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XbfUKC3U; arc=fail smtp.client-ip=40.93.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XbfUKC3U" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Usd7qW+Bqjq6tjNH86O6Vi+CunzZW9Zni34+uMb4iZpvgoTxnTCKe+GVgdkh4tk+012xCWuQXDy9oAcAlxE7MXEZqMM5t/tYHxEp2J3R7YJKgxO5iW9O0ms4xgFvlXHqGa3HDEweaNiKgydYQ8R/yCUdUv9inDPghWNo68cWKjzgQ1MxFRlNMjlUlg2o9Sga42LNJB7SxjliYaQixhFBJtIJ1RbmvKqAvFV1sKIR8Fnb48hwszKu4JmSaOM71SIBZdRIbligp4j2FpBeRgzwzVKiXXkr25qeCRg7qi/rEtr4+IPmg/Ru3o4AVxjtbNxrmTpM7u71AqvMcHdFO7ueYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=leZ4TF2oZcRrXe3OR/GG+jSVNE2uvwsOa4NTd2soR90=; b=es5epih3wuD0ZcopQp3UU3mkQTTAGsmr0L80ZLQ8v111Yz9c1iV0lW0iKNw/X0svtsVqeUPGbiFDoOcTD6w2FvUa1tIn8JrUFlb+N1TOo6CkfOcxoU0ogpetfiibt6MNHIb3c191XZKBa8yCSKBlHtejA2hGo3l8eN7AYNDGKYh1YIFjOfD3mzH1yJ2w++QCNkrSum/ouNKOEHae7ajUL7mlIKNBaeYs6oebofY8ia9Cd4RtghZlYnVN8/PY5TjN4S8ldq+Zo2BeCoNvGEH0hwkN44jGfvwyZt7KKesmecJip8KZVuDvrOHQWVfbUbzq9ViXtLrazL32mlHQ+TCQDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=leZ4TF2oZcRrXe3OR/GG+jSVNE2uvwsOa4NTd2soR90=; b=XbfUKC3UFTDIHwhcVNeB5xNfEN/RjS2nOeV5Rq3A31AD9jrGk3qaVG93djWa31pt7F6525363ygBoiDXlsaaqlJlPqL1DSbDKSyaDLb1x38/41vXua/fjG2dXVuNPXH3iMuGWR/VnOTuC6D7L1aGnn7Iy8OlogrX6mLflBE01Oeu86Q8G5WlZULmjJm1N87/JFhc/QPopsEk/iC2jkpldJSBC/OKq5hiru5HfwDw2aEVKI13mZ7a3uzdlDspltUGNVY3UyQmd/A0XLDu2LGDEakW2x55mt9siaMwbsXq4uWjIv7ffwFE2bn8be+Dqlcl3kovkn0JOvKyIc4xbNl+cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) by DM6PR12MB4169.namprd12.prod.outlook.com (2603:10b6:5:215::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.14; Sat, 8 Nov 2025 04:39:48 +0000 Received: from BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4]) by BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4%4]) with mapi id 15.20.9298.012; Sat, 8 Nov 2025 04:39:48 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 1/4] gpu: nova-core: implement Display for Spec Date: Fri, 7 Nov 2025 20:39:42 -0800 Message-ID: <20251108043945.571266-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251108043945.571266-1-jhubbard@nvidia.com> References: <20251108043945.571266-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0009.namprd13.prod.outlook.com (2603:10b6:a03:2c0::14) To BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4116:EE_|DM6PR12MB4169:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b3e4e2f-0681-4047-eae9-08de1e80d8c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZjRRk6VD8eNL+8A9DXmielt5KeR45a2dGPERATpycaMA7hLb6Wl/UyF1ztb3?= =?us-ascii?Q?fMk0Kt/SQ+WZeZmMXjS9qNtzlpniULAdudJVx2Vk+4e6zvkO5Hs+7RHODAyO?= =?us-ascii?Q?HR61j4G9xUK25PzjQzh5Ha9QlgicnkCgTwoSX+5peFWePOEcn1yL93KN/OGl?= =?us-ascii?Q?NAI9Az0bPiwDmoqP/YYmKLddVIakh25SZN4aiPoVG2aeskoBwLPok8glctit?= =?us-ascii?Q?TJK0Ez5shTmtujX4yAyDNy0KWxRJAXDaF4T6PYo/sQh0+rxF4p40leZhnP6S?= =?us-ascii?Q?64mmkiKSN2MPDKirDMpKSHFYWeDUDNrsgtZG6+DTl9c2lJ9pefdIpaojMWDb?= =?us-ascii?Q?eKtAqB31SGRIcHTHBDZHz23f2zPKoG29QBtMkF0we7fTjCC3DZNucype3B8d?= =?us-ascii?Q?WVz9m8eRIsWrsVaQ1SfTK/82R2GHs8uWSF/ZOmoa6/fOxTf+l4huxEbTQY7z?= =?us-ascii?Q?YkW83Z/uDcasM0BkG4vI2zC/eqGAXcH7bQc4L4eeokUgkPCj7HB9Icrt+7cm?= =?us-ascii?Q?wU5ksUSPvyPizk7uD+e8Tc8aQN98PnPmiNk5Bzzdi07KCB/1AfFxNzh50/8z?= =?us-ascii?Q?AOG71aHqLROgfvdeh8Kjqhx7oM+fWYE10V8+wCoZahqDbibcXu06Nkc3Sjae?= =?us-ascii?Q?aiWKKju1/MLT3i1Stwh4H72k3BCprRe9/uyXWVM3DJWr7JwafdwY2P9x89g/?= =?us-ascii?Q?dBgMRw/4bYM22U87JW8WsR+kyPfIBQtUSVtkyGV+W9Nn/eT8mAOY10GcvtkS?= =?us-ascii?Q?7u7ltpJ5ipBqvIZS1o+hi6YjE4TXP4YMnZkBfhC6Yew3gCKwqq6SIIAJcfik?= =?us-ascii?Q?oewqwBX8vL5lgfowFTflemrCw106x5wxDy5YBkKPnYjNxf1TgTkyPceHqFiX?= =?us-ascii?Q?UldQJfgXYgrm8ytdaYLJn/dRQvW6X4roWnOhwtxEODdcH2EcavwOi1x3PYKN?= =?us-ascii?Q?YCSm4CHpSL5a6Pi2g6oUcSFeW+3Xwl62n2YF+tJ+kugcNSEV0g7J5a6RHjBF?= =?us-ascii?Q?IkBSj/YXeRIRtnwRWDik5d+lrgveByH1X1vwSKavVdGZpLsOTsLaEWqduMGh?= =?us-ascii?Q?nsneeTj1TlDykcECEu1Wy/ZP5b0TI7LIOY1lJ80WER5tKmdPaEeuKF7uj5p9?= =?us-ascii?Q?4fBqx4PzkWXCPdd5qnpTgoLc6hYu0YnmEbkG/n2M5xQcvhkI8CsZIKGr0o0T?= =?us-ascii?Q?fnh+5aMUt5QrABsti6D6QzcSCBXs3ToxdgWOH19UWuxOUg+XyMBjHxuC6KcE?= =?us-ascii?Q?JmKWjbMaIwAIkN5+6dpsj9ubXlYq1bUzMQhSZaNhi2oRQdqJEKRPv6t+Mexp?= =?us-ascii?Q?KtWHvF6iRQokjKzXy2DugPG3DwB6lhK+te592c3vDSqVEsGtMBbq3xHE+j4O?= =?us-ascii?Q?exivFbQUupL0TuqxgmvWFF13HZ+g1BOeRxSBKJ6PaDToXCUx9AhL7s5G8Ji9?= =?us-ascii?Q?92TvmhE5fNq6bmRv+GeNPFyxvIoi2F+2?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4116.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UaKd9lA2S6j4ds3oMrBegPRy6YfMlv06XOwt5Np0V/zfaTsx3clqXj1ADx5a?= =?us-ascii?Q?pIC/4EU8ZpKRa2iwuacuj6CJr/uL7T6CuQNjcDYXEufe6Pjridm6gfEjm21N?= =?us-ascii?Q?0YggPoqoUYZUClVKW3xJ3GrAIrFXFaZ9+Z8ppjBeKlt96xruCB8ZK1+AKK31?= =?us-ascii?Q?JS2WAfFa6hLxi5VjEnnG588O0e0h7wU/qr9d4/6X6qiORmlJaW/WkJHv7wUH?= =?us-ascii?Q?iPatf3fw0njsWLU7mlRz6bLNbmfeRk8mRqG656ET9cil3q2daL+bdHy12dcK?= =?us-ascii?Q?3EKoBoj/k/mlOtCmo/vyebK9hsE8H3EKPrxKtLgZkAUbj+TIPBEdrdBDYBe7?= =?us-ascii?Q?7TNCJ9J0aEE9fnV++rYRPNlNVRAo3iscP2NA2dNtGDa+oo6GnHLnAj0jmgJM?= =?us-ascii?Q?ECPht1abk+R92E4urwGVe5ucEZ/uTgUYEj7tiY9SESOAI9MKoHd+FL+DmQJO?= =?us-ascii?Q?7uRTXrbz9T4clOCWS/KjOIm7qYy9jh8ct8z/mELXx7N2dm3Hv5e919GgPwnR?= =?us-ascii?Q?SRTvKR1VztATRcs0A0stnctEGwrJojJuyeVGfiN7sRIve3Nsf5G4SRxy8DBW?= =?us-ascii?Q?PPcnbAdtVg/dgg+XEOU4Db3+3JjkdYadrwK97JdgEqvTLJKtnaeoTvwHxsw0?= =?us-ascii?Q?JN/2QttUWo+gRUh1Q8UmrZPG2iQc+UHNEd86NCAU2VqFBD7bGB5AEfvG+oJv?= =?us-ascii?Q?9dHCJR/OttSczwbGXqmjU2kumHK31/nJApQnjgXpPvrdqhP4GXL8tSy3XP++?= =?us-ascii?Q?dvV0kf22Wmz+PLMMiJ2vPQ0m5dyT1eKPOtBnkN98PQzL4qOV0Hk+rxJZUxP7?= =?us-ascii?Q?ubPheBirssYpBKHsIDMmhLjUt/1f92R92m9ncrawwyziozU6UkcfA3UINGJz?= =?us-ascii?Q?0gqLClARo9ByXI/XwCEv0mwiAJta6BGNwy8hR7kBaCViMXmFaS2RjJ/fuSOS?= =?us-ascii?Q?G+sZyAC6zzvbJotZP1HJMRKQLL1NduMoRKxhgeDuFb5UEbNyx+X0/IUdF/YP?= =?us-ascii?Q?CT4fdgLU7hSs1mPL6miUjYBPRARocHeggIngOTnryh5oSdiZ82oZFKIHcWCk?= =?us-ascii?Q?ZqlomOvdCsfRDCXtjWRnqE+fPzlRf8vZ+a93Cux+g0/1JcjQTClSTF6q+s1g?= =?us-ascii?Q?52VrB5yj7nxiRA9zwGRsMBWn+W6Icb+Hiz8go8cbLSrQWxCHGryFJ5Vl+XPf?= =?us-ascii?Q?ZtFq8n8LoaF1ItOvzZfVJO0b/v0o9F1HBpGbktiC+vPHKdLlGQ3dwfZUtnXO?= =?us-ascii?Q?IERbZsri1WaU+a+uS1f7IcoFN3uuBH+DZLxKcc5H7ZbNwsqCpaqOA2kUvdau?= =?us-ascii?Q?hTWrcAO0AOI4zfuHlhKD2knwZYORX0LBdzh7ZQ89ZdPDRYAg08nQyC9C2CkB?= =?us-ascii?Q?HbmtM4dN0ClvJKqpaDnmWmNS+vIW2oFi9alnqOgdxjSeEBmfUETzzee/FOCz?= =?us-ascii?Q?IvgW2sGANKv2NXp+3P/swx2V54tf0xOMuerE31j4uQ91ycmjFJ3Xm2bTXU6i?= =?us-ascii?Q?19ureqN4b4+Nf9c5STKSPYNfAD7ZzhfyYAP0+aIHUT2RHlNBBstNsEsPEa4X?= =?us-ascii?Q?DoWpodxv5GMPhxNkj/BQRvloWYuM9YH/ZTIny8cH?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3e4e2f-0681-4047-eae9-08de1e80d8c7 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2025 04:39:47.6023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Mup0VPuGyZQKp4VwAxgj+AIOyeziAesblBgEr+40sUKY74unA9xSzVv+blA+qpJP53pKMIzM4xNxVHKl0rTuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4169 Content-Type: text/plain; charset="utf-8" Implement Display for Spec. This simplifies the dev_info!() code for printing banners such as: NVIDIA (Chipset: GA104, Architecture: Ampere, Revision: a.1) Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 802e71e4f97d..7fd9e91771a6 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -180,6 +180,18 @@ fn new(bar: &Bar0) -> Result { } } =20 +impl fmt::Display for Spec { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + write!( + f, + "Chipset: {}, Architecture: {:?}, Revision: {}", + self.chipset, + self.chipset.arch(), + self.revision + ) + } +} + /// Structure holding the resources required to operate the GPU. #[pin_data] pub(crate) struct Gpu { @@ -206,13 +218,7 @@ pub(crate) fn new<'a>( ) -> impl PinInit + 'a { try_pin_init!(Self { spec: Spec::new(bar).inspect(|spec| { - dev_info!( - pdev.as_ref(), - "NVIDIA (Chipset: {}, Architecture: {:?}, Revision: {}= )\n", - spec.chipset, - spec.chipset.arch(), - spec.revision - ); + dev_info!(pdev.as_ref(),"NVIDIA ({})\n", spec); })?, =20 // We must wait for GFW_BOOT completion before doing any signi= ficant setup on the GPU. --=20 2.51.2 From nobody Sat Feb 7 11:25:43 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013045.outbound.protection.outlook.com [40.93.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D3A92D63E8; Sat, 8 Nov 2025 04:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576798; cv=fail; b=GPQoUAtWi2PaKfdJJZjHFiUK4DoSnRRGP8mc8+Ew0LiBmLe+RitgcZ9HtUIxY1yA03lH4NQoPk3SD+UAiZN6cbw1tXNMqsJBjHKpfndRFH442cHRrevOm43Ikr3JnHkPe4HUlRLjPg4EmZGVjh2uxjfeCFOktAXZU6mlAah/2zQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576798; c=relaxed/simple; bh=mffuke9WiRLLvzAC9BExOcTdY6rnrVhAXiaALYuUK+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tYyPcxjZ+k0ThZrn2cBa/iQCs43kawRYfYWRVMVxL1YraSK4IP9qwBHIdB0T3GS0MLNkT54MXzD8qYj+C42NRKD/XVssVgwB/hVgtjtdwnAcr0hQkr7bw1ROUGWhNljyuhAW2o3NvcSKztcpV6S24pAlcb4T5in/qQER02YBwEA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=JD3H6Fky; arc=fail smtp.client-ip=40.93.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="JD3H6Fky" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QiB1xjAYoOBZnGrTDkau855kePjVw2eHDiV3Vhd17BJ21mnpSjXplwFqLOcNHilRugFq2W5WWkHF1AlAmDefaS/I6V9U4z1MIjJeYLpBRAiowbKIjY7tF1mNwCIdOwnjuSRnYsZVOuYPBmxLMk1zUXbBABF5O5jEdnU12wjfvSdMfMGkQnkv9DZJCne9TWiHng2v6MfY0+f2eFTHalH8hzdU6IhqZedgmmsWkwPzOpSgtb4orAHM5xlmR407A54P97KufZ3CH4kf55kGKOlf8l7tKABj6Q95YjQSeT5oWT5aMuzJkDSBPIjOl0v+d1zbZYfhhf+UZQzBt66ZxAb9LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziZPlECQAGQZP6V9aCUK+MjbC5vcIZQ+Naw1dlxex44=; b=VAwegAJAjSRkk7htJccIG7jlA264rrOD++9doJG9ZqhB9vgz3Lm4B66RLL0vtgox0WptU7LyEMg3Eyzr30xLh14Zyn3hrrwCcKQXiw431AluHd8VR1Aoore9fl4SbwPPkO3ItIZZFg/gTmPlpmGmw/YlHRx8wdja8ZrpzSf+qrqoz5FCU9qU2AhK/IbHEXm9w1v4uNFQOrXpW+hxsPXTsS3MUZBqH4eJ5j/aL6b2kH6CHHmfHoCuysqdZ/5P1AX3+BzWtIzun3ePa6HLvs+4clTygClWpOWsnGcpo4QSOcXXjz9BnK74sUuDcAvHgSZd7Xe0IRP5vMuyf8xf3OMRMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziZPlECQAGQZP6V9aCUK+MjbC5vcIZQ+Naw1dlxex44=; b=JD3H6Fkywh1HBBuzF8eUG7BswEZB6QfNRrVlzLd1iaoIrpwuV0IHxvydbeSPOs8srySrI1l2pbQ2CMdzpicNUCavYZeeb5UXAMtP67K9TFzIs+1/mCMbUFqadr+FbHlMH4kgTEw5K7nUctHQTvWVYZNZpZMtvcIgFR7alQB29aNSiUC1xf2/rTnZQqDvRUNv1aOSyLuFHIAVi2eiwC9+D/OimVPGu0uBCFsQdjQJlVVrRj6HUL0QJEpjMF/WBbv+7jgEPilTQQs55x9J/b/l2UHbt5E3JrNVmTbXBO3sxY7u6C2wl6Hnn8iIZmpCrHlJlAXRaXfc4csIDjVrLry5Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) by DM6PR12MB4169.namprd12.prod.outlook.com (2603:10b6:5:215::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.14; Sat, 8 Nov 2025 04:39:48 +0000 Received: from BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4]) by BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4%4]) with mapi id 15.20.9298.012; Sat, 8 Nov 2025 04:39:48 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 2/4] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 Date: Fri, 7 Nov 2025 20:39:43 -0800 Message-ID: <20251108043945.571266-3-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251108043945.571266-1-jhubbard@nvidia.com> References: <20251108043945.571266-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR04CA0006.namprd04.prod.outlook.com (2603:10b6:a03:1d0::16) To BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4116:EE_|DM6PR12MB4169:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bdd2a17-08f6-4a38-7be1-08de1e80d94b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6zWs+XhHWipD1fAooLUh4dEsqjyCgp4b/3jxEBSCyG+vNBHFUvujUFKRRUKD?= =?us-ascii?Q?gFnZ1KXXmfp8CdmyCG7bTnyR394E8BubcFB2LXlrqqGCY2c1wDdmqgxhrq5m?= =?us-ascii?Q?IHnCHq66nqjAim5AElNWSOcmOXMrEc2RPKcC8uR3l7pbzwRhYTZYb7CC1Anf?= =?us-ascii?Q?ooVoZdbiMLjU1w/Gi+troFrleTMSNQrEyJZFAYju7almMN59IR2HAB3KsF7X?= =?us-ascii?Q?xR9u2Kl3PeRwMuTK7cmKMKLyAQDGvMaphL8vZ7CDoHaakLb92YmdK1gRYhkT?= =?us-ascii?Q?yKS0/5wWNbdY4kmOf0ETbCW4W+qNRS/SdWGHgTAdDu5RNxmpQU3Ol5tZN3l6?= =?us-ascii?Q?/mK3eYSiLjk/lTxVHellXPmdJDfXSfcPLRAHHnY+eZs+1umaZlDeuco4+WDm?= =?us-ascii?Q?M2L/GUxxqYYlXb9LecS6WTsiBiNTjMvS4X8eMGbnTCRxhNnspuNTRpR3uIOf?= =?us-ascii?Q?5TvXvwzmDfIMtD60WW8YqMn1zy2W9klXRcYBFDvph0XaGigZH4P5vXeXdHK/?= =?us-ascii?Q?BF1i82j1jeJoS5X51widV39p7rxlf6vdmrrx6ateKooCZiRnQAKzIwiI2O0N?= =?us-ascii?Q?E0lKLPLxgUkAzgn6pMOgDcwWpjZ+Dru0nE06Vu9g4yz5iu90t+tcNZ9M67cX?= =?us-ascii?Q?X5vWbz8SKBD1NIOUldrjr8agBEI8oBqMRIp4a1jeGr0LDmhB3T1y85xiKdps?= =?us-ascii?Q?TS2YSvgb1n/0QN7vBmQz4rv6utYUntIvKep66odfsB3D8LmU7EoCfKKw63I5?= =?us-ascii?Q?kANXdMMKbwIXwwr2XkPla8dFv/jMaqAs653St6br948jset4kO7hSEBEVI8z?= =?us-ascii?Q?SzJK8JCGjQdZeZcqaZTtTSwKZjuZG0l9ojB48gM5zIg2Ic9yQ16lkq7VbaE6?= =?us-ascii?Q?i+XQlEmriCnbnTQuUdst7qrgOPMgP8h/YrdieEdLnqXBCidTuGs8xyIuUpuw?= =?us-ascii?Q?7DdNKV+KE62pq/BlPhhvaRcCvN6xZVJkRJ245KsFxwzb1ix7X8JabO3Vll32?= =?us-ascii?Q?XQGoGIfHHI8vDEr4JYNaSZgPVXWy5Ic/gxWFk5Tg2Hj6aJFbpLJxF7xATHVm?= =?us-ascii?Q?IhQOHRWh2up1+Pj5MTlqvx3vf/IuH1rVXh0tQvnMjS1qGC3t00wfg06bM22X?= =?us-ascii?Q?0UGUy15FL1o0oHSDRuqLyRXDJG/J50+psBi/XjMdKIp68vUPfAnlopTVDKUD?= =?us-ascii?Q?3qseVkmD8ole8IVaTGTLeoquaEXgVE1WIvIUe2EnnQfhMykyODKDy9Z7ngq9?= =?us-ascii?Q?ADFk2wCTaqH4PEWPZUGu4npspFrD7RpiutQVcSFrNwrXEJCdNfbSd1oT36xI?= =?us-ascii?Q?sQg7f79gZAKedFcWN2dskvwQm6zjo8H3wbtkUCqR0wvr7zlo9Ulc4mQkPsxg?= =?us-ascii?Q?CuIyOsUnifw6XdzB51vH+vYIR3yFap5aylEJGQy64QYwKdqXBRFh5kb3DfhD?= =?us-ascii?Q?MaIuecGg0RikvC05uM+5alBFflODLgaC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4116.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u9RIy8lHR5+XsFrvaZXC7NOB0FySU9pS2/lUGNITzQDueaVJER0tNZ+PQpce?= =?us-ascii?Q?DTkpKdt26oHU9RrIsLmniw59gNpvzsHxKESD2mQ3O6Imp+lqJIDsHHzbxhXm?= =?us-ascii?Q?dfih5cEvH4XJ99X5aXDY/vdxBt9yTzIdc7ay+bkSrV/yUs/7Q5M8VXn6H/3y?= =?us-ascii?Q?EcMXRikcCL2ZPbGFJW+J11xDMtCqtbxDS/iOvKD3XtuNigl1mLa+Slp7+34k?= =?us-ascii?Q?fCjYRvGFhRUEynNBE6uS2QzG/lq6cyfnyC5FnvaOlJn/GUg0irj8V4hJ0Zao?= =?us-ascii?Q?r+NM4OiTqr2etU0YnRXMw8OQgvYZ02ct6NIwQaBp9RaiCyOAz0dI9h3x7t8q?= =?us-ascii?Q?exSWPddIh2Ff0lwNaEAm3ykaGc1bj2D2SGACTpEYA4Wqh+GbQ9/58DM8VsAz?= =?us-ascii?Q?jhHbnPR/IRv4tWjP0mf0UvBaubaT+1v7AbW56rtYH1FTwQtZk5hXkZQQTLU3?= =?us-ascii?Q?0ZqD+65II23gvOJV7MFRvheiAuXrWU6DB6PIBwpKQ9RHpQ9/TLWgO/RYNmxM?= =?us-ascii?Q?s9PjPJKVqatJb9/84gjUVq2hhwuvngw7oNk0LHzyDKIJLn/zlu+SsxaTK1Q6?= =?us-ascii?Q?HDypQCwGT5BNhqTjGUso4pxXZ5nERdnGOYdIu+i8Vfm5Xm3Ztj2ktr8iXOWp?= =?us-ascii?Q?IQ9vnBn5fka+60JL8zEyCpbpZgFNsef2Ig29uDgjVFoCeUNOPoSOc2rkpFfE?= =?us-ascii?Q?TUhOi+019iQJtN8qEnBwK+KAqCMHX5i3KsS9sPJpTt5cw0EsJgX8dQaRPyXR?= =?us-ascii?Q?rGaLnKrFb6+ByDy5141T9La67W7kFxlkgmrbKDJVlD3r+ucJYTNC+FivdjKC?= =?us-ascii?Q?cawVL4wdhJ9pSx7QGGSlFBKqPO6QYylK2txX+ud1VboAeaPdVNoe+MZTbQS1?= =?us-ascii?Q?3hdS3VP1UDtOcbrhUCJ0dw1iXKN3oqriby5ZEtDAb7piMTtaZRth+Oz/TZc9?= =?us-ascii?Q?L/3n6zZxfUjw9VwMU8AiChRJSyNIwtcQtF44FH69bHoQJ49DzQ380i0VY4LJ?= =?us-ascii?Q?cHcLhjLql//Nm+zaCMB3MEQ4PtE+93TJ3a9b5eT6O/DyM/EOdwxKs6SdCNFH?= =?us-ascii?Q?Hws2h6gOXRKjdjAZQbyUc2h0Gu6DX5UD57ncgda2LzGC+fy2utMg+bJX6Rg3?= =?us-ascii?Q?G8BfxNfIBEo/wmpCZhKPrghLluwhdxv3jhSjI8E3TgflYbTpBxcrDVNCdlWs?= =?us-ascii?Q?C05AeesVTY9VNcabJoqSDYoMSZFmUeqt86hBAEu8agK3tGY6TurKQjtG8m7d?= =?us-ascii?Q?ma9HVG5FM2jrqSvezGY0rd57MLnffVaRTwQv2GIj+EiidWDgzl8RjPWQtI2J?= =?us-ascii?Q?17dru4OqnmOPJWrBhzC8e85rRdDGwKIm5GK5COg4Je8lNH4tnQH4NtU4Gnlv?= =?us-ascii?Q?pvT4Oxf2fbfIWD1tWxxgP6andi/7J6jG9Wzbao7RZ6uiCzT3uSbi7/ILzUhO?= =?us-ascii?Q?Qy51YmlPEN2eZGkb4XnPQAu6/6Ws7NsaaiX4quHMm0pseQnTVSHaM3UvAvFl?= =?us-ascii?Q?fHLJqVyvv6LPEkk2ZmZQ3Vil95WgeYKi74sPrtOm3zBqs6Y56EQtA08F16Sz?= =?us-ascii?Q?e4hDo6UrDrGgh9697i1wheMHrFLbXvwv5Z4TQF4g?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bdd2a17-08f6-4a38-7be1-08de1e80d94b X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2025 04:39:48.4744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: acp5RlCYmJDHNgMb/p8s86DPkPt98Il5DEF6r4/WYl85jbzefDoag2my1GCLBrJxXMU4ltLhyCN2EeDjlsrqwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4169 Content-Type: text/plain; charset="utf-8" 1) Decouple Revision from boot0. 2) Enhance Revision, which in turn simplifies Spec::new(). 3) Also, slightly enhance the comment about Spec, to be more precise. Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 25 ++++++++++++------------- drivers/gpu/nova-core/regs.rs | 11 ++++++++++- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 7fd9e91771a6..acf564fee9c8 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -143,17 +143,8 @@ fn try_from(value: u8) -> Result { } =20 pub(crate) struct Revision { - major: u8, - minor: u8, -} - -impl Revision { - fn from_boot0(boot0: regs::NV_PMC_BOOT_0) -> Self { - Self { - major: boot0.major_revision(), - minor: boot0.minor_revision(), - } - } + pub(crate) major: u8, + pub(crate) minor: u8, } =20 impl fmt::Display for Revision { @@ -162,7 +153,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resul= t { } } =20 -/// Structure holding the metadata of the GPU. +/// Structure holding a basic description of the GPU: Architecture, Chipse= t and Revision. pub(crate) struct Spec { chipset: Chipset, /// The revision of the chipset. @@ -173,9 +164,17 @@ impl Spec { fn new(bar: &Bar0) -> Result { let boot0 =3D regs::NV_PMC_BOOT_0::read(bar); =20 + Spec::try_from(boot0) + } +} + +impl TryFrom for Spec { + type Error =3D Error; + + fn try_from(boot0: regs::NV_PMC_BOOT_0) -> Result { Ok(Self { chipset: boot0.chipset()?, - revision: Revision::from_boot0(boot0), + revision: boot0.revision(), }) } } diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 934003cab8a8..8c9af3c59708 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -24,7 +24,8 @@ }, gpu::{ Architecture, - Chipset, // + Chipset, + Revision, // }, num::FromSafeCast, }; @@ -56,6 +57,14 @@ pub(crate) fn chipset(self) -> Result { }) .and_then(Chipset::try_from) } + + /// Returns the revision information of the chip. + pub(crate) fn revision(self) -> Revision { + Revision { + major: self.major_revision(), + minor: self.minor_revision(), + } + } } =20 // PBUS --=20 2.51.2 From nobody Sat Feb 7 11:25:43 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013045.outbound.protection.outlook.com [40.93.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 181D42DA777; Sat, 8 Nov 2025 04:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576800; cv=fail; b=A6fnR1DBnGVjCeSWqiePztpIbE9Yz2xcWqja5I93FKNorJcVoBL26B1/snuP+wSvPGuGUqstyHgY8PRwinY9DlBb+x61u6yW669XNiPkxjgEBkQHAKCJ+NG1PYu17P4+H5niWH+F4RjhO2fes1fSa9e8lmIxM2A/hRrdHgEgEWs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576800; c=relaxed/simple; bh=I6SXq2YhL/7iG/N8z/PTbRBUdTV32ewFXSa/XLRyNbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=coB5gJwXN2iJC8o3fH5Jvfz0uXTCUBPT/OR6EqVLEFjRJeNuWA0WBlrTw5VJ/CiVIHh+RXLI+qFwLT7cWwl0dTbyC+lLHGvAHPItoVNTc+X7xJVZOVSGhThg9N4hwlNloHz2Q4wknSSKiUY7aqfhnxKiRYTojS3FItcGoWOhiaY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=CiX0O5JM; arc=fail smtp.client-ip=40.93.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="CiX0O5JM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sUrchra9VDFLsN8aojqEUA8KqnQmuXuGeyTEYuPTCPSk4V3DQJ2GkT5CP99hFsAiRw1Ojo7PCcOIfGaG7VEvQg7Cy/LTbejKy7ubz29SmKN+d9uDH4JGCSvfyy5iafHwVP202d+9u5eG+sOU8EcEK8X25D/Fmyubb5NLd0k0ePD3XfmayQocnPfV56h84+gidwoNz62MXnwsVtJZDAaFSdL0Q7m1EU7cQYTlP5kt+/NvROsjuwLDD4UrxwkaGxFobof8Wjb4Mnkm//uUbAk2EBgKuZM0iMRXpgIBwA+eHQZGVDOCJ33loAxX/clVoXpynU60zJ+QDpIMP62hIVLrUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgWBIXx+jUe8V+sduVdomn4C81q8S3cYGIaFZBV6tMg=; b=GcihryyKQTDTizvvwlNj94ovoSYpFHpOffhIWTmpqdXHIq9saLSmz0Oi7ktt0plln98OYk7Q7c4cKT8a2u57vpTufyqlQQ9H2adyafHwmEXDnRpfD6dYPry29SruluAuw2/3V3eJoYv2uomjmkvUJ3zT48KLy4rSrGqtw7rl1yaHCUsKwpsKpA1ufbp91p0t2gtAoIRe4L5Mc31ktxkeN/eye78TeqqHjRxjtbMuCccEneM5/k/1gir2EAJm6UXauLOmLNcIqMIk+vSIM9XcZPpMm3TM/fltlb5jO6qwaPYP8FXCRXhbemJBu7LwcSrWOzdvaC8dPerswIk8pNkGvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgWBIXx+jUe8V+sduVdomn4C81q8S3cYGIaFZBV6tMg=; b=CiX0O5JMc6o37r6UggQ0uqp3ZXV8P7GquPnUBBjrGhkTOpzOEnC/joHW4UX05G3m16HxC5eDDpcSXOV4hM2RuxBaGyQm/L+saX0ADeF8yybots7fjYon4tdaDDrIN9P7DFKX2Ae4F/vfKG+6sE6DsacEoOWWUb+miWg+AOnjofOoYMVA55fO2AV3re89ZqgTphYvTT0pqRdnSp95cocgefV/+eZh+KzLYbW8JTDtpiKAqOBMjV7/JLAlkA0PPAlNAMFymDlld35MWDbX+xP1pf66aI55Wmj02tZo033boHaI7WT7cuWJ4a5RfT/WQjahWB0wrg6mPnkH7BGTYaaSUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) by DM6PR12MB4169.namprd12.prod.outlook.com (2603:10b6:5:215::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.14; Sat, 8 Nov 2025 04:39:49 +0000 Received: from BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4]) by BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4%4]) with mapi id 15.20.9298.012; Sat, 8 Nov 2025 04:39:49 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type Date: Fri, 7 Nov 2025 20:39:44 -0800 Message-ID: <20251108043945.571266-4-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251108043945.571266-1-jhubbard@nvidia.com> References: <20251108043945.571266-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR04CA0004.namprd04.prod.outlook.com (2603:10b6:a03:1d0::14) To BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4116:EE_|DM6PR12MB4169:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cbe91cf-a1a3-4ba7-00bb-08de1e80d9db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+/+beLMcml6laxSzo97mqjWWzVCFfys8W563mwR4FI3vMtYevek0iRgpV32r?= =?us-ascii?Q?Gu/alxbJ4wuoim5gK1FYjdggMKECCNIL3tlXX/x8zUjsI3zTdGrGiwgyxrbF?= =?us-ascii?Q?WJWcAOg3CRlJdvD9XkT2scm0OZQiW1rvHX4xy67MdAH54ll5p/DwbNFe2BSa?= =?us-ascii?Q?87N+mLfo4YMWUKGXMCdXc6PjAZU1tIXLbQqz9lI3xxlwd9+9/WcssZ2u5h9g?= =?us-ascii?Q?vLTU0IzTu9bFE+96Dlbc8To16r3pAcWsqHuNAdK2118UHYjCKvp6DJwhP+C8?= =?us-ascii?Q?wJnnopgZ3ZPTjhZdHYqU55NEKB8ea4POnn1vdOdG+JouypW9RBklTunEPSOL?= =?us-ascii?Q?92o/boSUPgYlArjFw+GOWGADogMoM8+s2AryLdgua1sG9w6TALovBWLZ4OSm?= =?us-ascii?Q?+9IofqHqdrcyEHJhXs3EpkoMszi0NTGKiiM/zylt6Bp6/Tsod8FdAr5/zzfo?= =?us-ascii?Q?nTe52jixQ+jiQEF9HWv2AeH6JWEUuc8Q8xpTSHb+7YcHvIw/Iz/lO1RJZLc7?= =?us-ascii?Q?knc8Qpafo/tJaYSi1PaNtxIOCpAuO17tCVLXZ758xiO3ECMTwXu93RkKvxLN?= =?us-ascii?Q?meKpUQwTsU/RAEW81d4CT59xk05Rkik3v2ngDtKiXUgP6/mOJEbMDsNg6jBl?= =?us-ascii?Q?KlvXEZLD2cVL2CHfoAzkZvGnA10deaMuVIjgaCli0BF19YCgsYSZkL+lKdTL?= =?us-ascii?Q?t/4drGWST/7lUYcrkXh6CY+UB5p4Ni2e2vJZ32wfjicra2AfVoTDze3+Nk68?= =?us-ascii?Q?cfTsiVmhrYuTKpgZZiV5qUX/VuktcQDWy4baVeMOk3rYmB5Dc5uqVpsEudNv?= =?us-ascii?Q?edPs8WvquacoJZiNtQqhQHrkJLGa7rwJHom00Ahv1hHVbF0RFEuzcZp8BPqC?= =?us-ascii?Q?O3pwRX9hS0lyomwfNhhyPMee7XcqbGokqw50pNd0HIk2RmhPJPtVBlz+FapD?= =?us-ascii?Q?zYFZhcb0e/y0bG3QdFR8o+YU0lCGNX0DZqw4oj+T9GLINDNF2j/NqdaY/GGl?= =?us-ascii?Q?p2mITjKzffEIqkUozfZrTIp1p0h3xbbZ5ZVuEaWaRhl1AhLdKZTIsoS0FMUR?= =?us-ascii?Q?OxSGcMMI5NeAVysKpEs19ffsAWzA+OV3Q/us0UVVkzs2v2cr1baCSWq2GnLJ?= =?us-ascii?Q?i73FHSOTKYWZNdbb8Qo9rkz8UZzuliclwd0ztIr2UiuGPo8DuXP6M5K/NX6Q?= =?us-ascii?Q?gbowghL82zA7fkLkqKwPeAJsgOGEHiZlfsnD6hcuWkuC8gAei3AkYrRAaLXj?= =?us-ascii?Q?uF3kA8VYcxYE6PwXe2nLNOAK6uiebLjAOd//dBs3bWAcrm7zhV6QAe3ZuggR?= =?us-ascii?Q?pNxzUxgu6wzHIlHBgivAtUIibtdyGBANO8OWvF4ON9bBso4q9StRESIHAD0E?= =?us-ascii?Q?PGDh8o0NuluMYnQeYv6rPyO9sWn3f8SHH1AsIzGR9dAk03aHDqIZVuNBtLrc?= =?us-ascii?Q?szdJmrOX9yJ5YKGniEjyGP80tCDwcdw8?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4116.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AY/BPOEimSCpB8aY234nODdtrF3hG1JskHqxKcmnCnc0yzaR+7tamha4ZERC?= =?us-ascii?Q?YAoZ2Chu+YeCd7F/AX03el8ANS6G7uQd4dFibGLdTFW7qV6RGJ0Lmo8wGVIW?= =?us-ascii?Q?lYid1PemA3QPEeLxAL6OfCezZ9/mHJPrBPdG2IiSWgd1Ed7S2J8qJ5eLrUjS?= =?us-ascii?Q?A3zzWbF+1yVxi+oMGHG/6MK6/SOIt76blSEa3mZ5yAx6PETAHeKksUjeR36Z?= =?us-ascii?Q?MSJo5TeyC3U8wToV4/qzNXOZbqRu42RAMlUfpDypWL0NLrVnOiIZjhlwsdPh?= =?us-ascii?Q?FlPLUNkTvjAbZjFZBTNxn6DzLNoD2E3LEw9MDn7NTpam66eJueghmDL/LR7T?= =?us-ascii?Q?7O+EI2rTbhVFL31RI5uimct3lvZf4WKx3DrSY2JbxdyBhzHbvENOyC/rJUi+?= =?us-ascii?Q?EOkiaUJo6sZ0Her6CGhHcAlj8UzJyBeLbe7UhJTKZZnxuJZWv26qiuHHfJiw?= =?us-ascii?Q?VivgpkU1BrouXS28mz2UTGN/9xzv4WAXzpYE646I9qaXV8HRqTsUEJc+QzRB?= =?us-ascii?Q?f4CcrRKBRhgn3+6mxY3D2bzrauUGlFWoETOvpceESRuHip6er59a68pQ50nU?= =?us-ascii?Q?17f24ASCpRFjEdeAYVIYGXhcptxTQ5QcHWn3Ba5tUk3pBlt2M5NCAZls8B/U?= =?us-ascii?Q?CPhpSFCraeuXZmQ1lhPTO8gEHmj/r7/G9HtVJwBo2v+jHygF2l/agSXINGrF?= =?us-ascii?Q?bl0tvGxUmk5sysBr+jgZEJykGD2kbijywheB9ioUb0snWQS8nW60xP3h+BYq?= =?us-ascii?Q?xhfyVyZp0MV+zmA6TwCxlRfSooGiOCUq1OeMTMn28jnOziztZNXH8HMZTBZc?= =?us-ascii?Q?10jxOVYRZ4Zcej7cC7fDEVXjWQrNFLkkRZFuRSTwtAkGq/sGjOQQ8DABcGXN?= =?us-ascii?Q?jXUY6PBag9c06qgemC3LBrRathPfBe3gdnK0Zam6HT6tIYp2KbIvl4S0FzOr?= =?us-ascii?Q?67qmf4PzazADx0hCSUeLgnjliok+1501dzQ1d7SEvT3wz2QtdFcE2S6n7DcF?= =?us-ascii?Q?KJfTMJV41obENAO+x2KIbv082JxxUcRLmFDhufg+dgKdhi3Z+di1HXHJyHWk?= =?us-ascii?Q?/dRiIIzOvFm72xM71i+PExEjt3+KQSojJ3XMfhDmMblKog+pO8RnvdNq0WS8?= =?us-ascii?Q?tkohnFt+Xpx8UmNfX7tCkp5ie0tRg2q8ooGJOtj/Y7/oUKui6dxY5XHlKoVR?= =?us-ascii?Q?5Kg2ZMUwBheuL8ut9VMcGwZ/hdCKsMyqEnCCI/CzuEeD5IKYCRlynim1AAsr?= =?us-ascii?Q?Q0wVR1z7gE4SFZOAC1Q0+A+RVk6qNV2zQC6K10dcpkV9i/NFXL0GCEBBHk/F?= =?us-ascii?Q?qDWKWrH/Os3r2B/C4Mnt4GPCLRkUUy3w/GtfUDMZ+g72PiyV+kWIfxGdLfr1?= =?us-ascii?Q?thc0l/0dvP0mfJ86GQlDSXmkC604NAClIyX28Qctz4AKMUWjDlJ0rc8VXyIc?= =?us-ascii?Q?8AL/BjAuJmB++Ib0/vd0GFpLJMa0irK+oErL8UjUd+Ib6ceZTs1+9M8MlEPG?= =?us-ascii?Q?+jCywjeTcDrVhCIINpJtnmfV/ZfG1cafYNMrWJ6Trlb3e6IklmyjqiCusOtV?= =?us-ascii?Q?ShVl65hnI8Ln6tMm49nB3A3FBaIuoCrHyQFr37qp?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cbe91cf-a1a3-4ba7-00bb-08de1e80d9db X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2025 04:39:49.3921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wIWp/gGP8zBienrGq6F8S5ViXnuDUucoAHrATpoxsx+Mmrfe6hyY7PhacJDAMJVmN6ccDpJp+zltxwDPjs4Wzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4169 Content-Type: text/plain; charset="utf-8" This allows Architecture to be passed into register!() and bitfield!() macro calls. That in turn requires a default implementation for Architecture. This simplifies transforming BOOT0 (and later, BOOT42) register values into GPU architectures. Cc: Danilo Krummrich Cc: Timur Tabi Suggested-by: Alexandre Courbot Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index acf564fee9c8..94a6054bab95 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -122,8 +122,10 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resu= lt { } =20 /// Enum representation of the GPU generation. -#[derive(fmt::Debug)] +#[derive(fmt::Debug, Default, Copy, Clone)] +#[repr(u8)] pub(crate) enum Architecture { + #[default] Turing =3D 0x16, Ampere =3D 0x17, Ada =3D 0x19, @@ -142,6 +144,13 @@ fn try_from(value: u8) -> Result { } } =20 +impl From for u8 { + fn from(value: Architecture) -> Self { + // CAST: `Architecture` is `repr(u8)`, so this cast is always loss= less. + value as u8 + } +} + pub(crate) struct Revision { pub(crate) major: u8, pub(crate) minor: u8, --=20 2.51.2 From nobody Sat Feb 7 11:25:43 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013045.outbound.protection.outlook.com [40.93.201.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA0BB2DC35C; Sat, 8 Nov 2025 04:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576802; cv=fail; b=FhaabUzs9ktvrNMY2kFJLVj6TatPqG6X6Q3vhs5kueP3aBm12HCBAOigxqcdCYvwF/Rc+z4zLg0XfVVF6u3ti/FctullsRrG7G45eGXthpPMwxfNdM/hty9FWtDCW8QkQQzHfijZSw1awDQfibGHNNmTXVgNAbvEb1JRe3VX/lU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762576802; c=relaxed/simple; bh=Yvn78e5jIgltpiD9tX5Zw3fxrYc1Ll9Q8t9aNy/APRc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=sHskphJ8XA0ybtLzqUb4yDD5gDonSnJKGoTI4GH8ulGX8F2DP50G2eLLMrCExLMkxkXoYh2kerF6aD78VM+xhQ/dF/omM5Tf9zg9wJ8u0mUL7Qu41krXja4iroD2Z/G7daqO2kikLexexDrQjwMFgX8O3R0fH9DEUoHkF+UiWLw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TNdmOwgk; arc=fail smtp.client-ip=40.93.201.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TNdmOwgk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e8iYrv/V15hLRFRFF/mHNzC2ipDtd6D7lLwuAyzMn6AvCduLis6NgmcqvF0GcF0poo9JjUtfuba7VS+uHnsk4pLRNJrfGAJHssfS3fM+rJ8J//+m46vM/82A1JblN+BaezCmTrVGCtBdrR9RZyiliIx18ZvDwAQyP2rurCHeKDaMK9nBjmoyCKhoqfzBRNkMndmvO1OL4hwzWS4lsX2rDn0XSKO6bRKAVGbJY/i6pM14Hbk3PavqajhEfsFH9fCv+1NSJQBiLpgzFEWAOmcvoIq7ktLqzZQxAJzLug+AUkMKGO2ZufxGOA0VK3oS+d55ioYlHMFlbJ/cKz5P6aeV+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KS3/cBVGkJIA4F/uVQpO5c+Qdi9EVo4LPJRotTLqUjU=; b=RKbn47KQLHeXPyhnnLxrDuT6NAWWRuIg10z4/hG44VluepJ7flhiBlkYbB3L9pBUBs2HyOrwdP3V5VpEQYPA+FT9xPZWiFmRC+1D3aQT4Ys5zVWIyaF+NMaCwbxKGWrG7i/ubk41uLdVMGLF+E4WwkS1oz6Uk4LX81vEMIP1+8/94A3R3Dn5VFi91rzJD1Tc7sjCuzajp8anfjalZHDt7Rn5g2VS3PuiU0Vq4fqvsM4pZDnANFogVHKYi0ByyRwY5k8Ky4agkcUSloKy9HLUektVQwIHYIS6Ad4MzTbnuhOPhWStQeFWu2bMIdQZaTOgN/nAJfzoU5AnZRh1yUXMOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KS3/cBVGkJIA4F/uVQpO5c+Qdi9EVo4LPJRotTLqUjU=; b=TNdmOwgkYJUC03yDa1YdyHduScJmyBT7pLoYnXa8GfCd6Q3n7MSe5tBxaFDBAgNqSOKBNYjda6OeNLiYQAqUQQd8hFhZ8SA8/9Ob+HgdeV4u25lDhW/iWp1ilmyE7eX+Um4cYobwA04bQ25IErNOzrLC9q5/jFwCXn9qX7JwGwwTSjBSD9eTXpP3V9GF15YrzH890cYWgqyabAKOmbwsU//wZ+VZuRTn38BwsSQLg+dytMUP60pgnjQHmva9wI7ROu4gbWrOgmJFEVGF8AZ27c2qJ6H6EJ5DCUV6tpGUtMmNwLtYBcvJ0zM73kDCG2Emad2Xl6MNQemwZItuLbV4ZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) by DM6PR12MB4169.namprd12.prod.outlook.com (2603:10b6:5:215::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.14; Sat, 8 Nov 2025 04:39:50 +0000 Received: from BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4]) by BY5PR12MB4116.namprd12.prod.outlook.com ([fe80::81b6:1af8:921b:3fb4%4]) with mapi id 15.20.9298.012; Sat, 8 Nov 2025 04:39:50 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 4/4] gpu: nova-core: add boot42 support for next-gen GPUs Date: Fri, 7 Nov 2025 20:39:45 -0800 Message-ID: <20251108043945.571266-5-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251108043945.571266-1-jhubbard@nvidia.com> References: <20251108043945.571266-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR05CA0071.namprd05.prod.outlook.com (2603:10b6:a03:74::48) To BY5PR12MB4116.namprd12.prod.outlook.com (2603:10b6:a03:210::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4116:EE_|DM6PR12MB4169:EE_ X-MS-Office365-Filtering-Correlation-Id: 2987230a-4c16-4095-3a69-08de1e80da4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dcr/aZaVAvv4RIb2Oy9L3mzX960cHX7Mvap7TMYHUyEV8F4VP2lxpMEJFj+p?= =?us-ascii?Q?kbp5yVe5alzGyzWVm8c74Qf/D69KvRNeqICkJzcNFpzRVznfILFd1qFdSSAj?= =?us-ascii?Q?kVFMb9gdEv73O1Potf5BkQxTwflVig5ghiSd1R9UYBxSj4VuaLtjOn+2ET/O?= =?us-ascii?Q?SFx6KeWKVJREjqNVnI/RivEVKZOTpau8Q4sO9pa/23+hACFjU5eKL4YJfr0B?= =?us-ascii?Q?oRy+D4EX0xbB8X00NpYIEBtpXUosqJ8sV7S3IfLMlkaH5D/RABlYTx9qpO1z?= =?us-ascii?Q?veNKBZT2Kve3BqrvFD6PhKZGekzly4vPKVRVTE2zwWY1PMDK0fp908gDLAfa?= =?us-ascii?Q?c1q/fpctFoQB+BYonf4z5vRYeyg7pi/CDpPKTxjgMKsQy/l3UIS1aDf4/k7Q?= =?us-ascii?Q?Tqd3inoThwiRaZtjZJLHxJ6n/OjzcCy0qk/o3eNRvbA1j/BpZmbyis8/ccoQ?= =?us-ascii?Q?3AGwnQCvX4riOGQd2QVJxj0FcLGEz2M1eH+EYNamytGEZcHzjZvlmrfWhNgm?= =?us-ascii?Q?paXhDgBpxFtvA3AMBf8QYVOJP8H7guWyI4vHNpg/HS3JGsp065WE9/DwouEc?= =?us-ascii?Q?k8y0zbAojAQ6DXScIjhEnhJYCUXdt7u4/4R1hHtj5ogRkXM4pNOzl1M5Bv0m?= =?us-ascii?Q?PhYfOR+fUB2YGN9mPLRFc9Fb7vwgeb4xyKg9Jsv1QbA4nuBnYCoq6YNAjCix?= =?us-ascii?Q?A3i545ln3943Mk15zQyxaJwLp7Pe4k7NhRy/AT2SNUQQvzR+hvoYiz6Ql/KK?= =?us-ascii?Q?PLZVOr775HbuPN2VbIEzTE95ja4KcgRBLgMH9lXxPTT5LSjv5BvMOi245j5J?= =?us-ascii?Q?aQ6DBVExhBKTOtuDjMjZyhEmCk3ZTyr7CCOkIBsV7iT5PcURiDkF5INrL3Rj?= =?us-ascii?Q?cZQSbAUxOXaSmtgQDmCEBqQmxOZTMI0g1DBM3soiYaDAA0Em33RVmuTB2A6t?= =?us-ascii?Q?WRc6YQ98JNfs2YwRg3Kv562zU2I10TDOfLZHkGjqatsin+J8sKNbMt1FvMTK?= =?us-ascii?Q?WA0TsjDYMYA0o+9oRiRlrhTRS3evvREtToih+n9iYHV1D7Q+/cg6HjTuRrGx?= =?us-ascii?Q?4LCzdURfnmvpol3UGrwZk66c5NkIS2Wj7gx3/cu8MdHtMy+my+QQKOyJIU1v?= =?us-ascii?Q?h5zcnWPm5cXlcmmn9+EQEUWyXGwOc62qSUZ5EVRjpw0KfX/z/ajgjWT1NKR9?= =?us-ascii?Q?1CA7vsMpt+w3snbZipDBKcP+wF+oKNWTIgiDDi5kUcIAKyYyvcLb4o2ueAxp?= =?us-ascii?Q?nFYuK4G9jxHrzgfObGdOM4HXcVeIVW9IxdZEH9p/J8IVxZuGMFF+Paq5sWg/?= =?us-ascii?Q?9BlsW0D+8/J+wOFfFvFH75RXESrPwyWmx6+PQ+7tpCBSbbmtj9YHsdbQEuV6?= =?us-ascii?Q?CrnaXdTbcVeWUI/tBNTpse03zD/dvvmWM+tb5GYq2WyXy2h2OTnyOWsKKNo5?= =?us-ascii?Q?zZd07px7wdzJQ7ceBDNb26FZWQ0xy9I6BRdQxbXZqfqgMGScqJjrvA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4116.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gFSaWxVLlNWrwLE2hI+XNqVzt4MuVpAfjvQvAACJPEGWo25yJgNeQpVVc5Ju?= =?us-ascii?Q?YxC0qDtQfQym2yWN//rD0sXgUGeu6Rc/bzApUdoZP9h/Dq7SNmwWA0J8zArl?= =?us-ascii?Q?k+CA2McXnJH9eR+AVpnuhAeI9zxpdTYvE+OA9nXxggiQKKt+kFs3vdhOHyD2?= =?us-ascii?Q?lJAyyfe+YwjERnpMKZiOdWpqSRVjevKwM8WY4ilLBz0/OvWu2jVaAQP4oWhP?= =?us-ascii?Q?hUyBB/cptMmL4miGAGuPwHzQn11yqFaKK+RJYrZ3ao1/DuqhwcFma2pXuMth?= =?us-ascii?Q?Gb/uDMlbo3OPDHRXz0J8wTUq3o54Ba+gs5YTi4BVQ1E+BhM/fQtbzOkqnWxR?= =?us-ascii?Q?Dp6dgpaDWhQ98lHjnmmkaWq1apeRy3F9R3RlSM3BDzjuzyS9HmriLY3mzkCQ?= =?us-ascii?Q?4Q/18oFolQlCdvuncsMRdq2F6jW5ftUWGy3U2Wnjli3SIsX4KuwAFmnjksa0?= =?us-ascii?Q?IsYbCk3qLhVSI5laxTZY7v6goNb3Ly4Lc3DTj34iNL1U2CtWnhjv4WJdqUkx?= =?us-ascii?Q?qCg1F01gZTpqpaZQ3Mm0uQSOGafov6prCduqZBrHOyHc78zgvvf9Fl6t/Ov/?= =?us-ascii?Q?WH25oYIs9X1faVunBQNuKjoKqOMUJjM27/cSrfC12rz4Vqtj9Q7oOZOL19bl?= =?us-ascii?Q?w/cU3nn7WJax3vidzgV2+Y3beKIiqJJrehGOWCTvNNA3Ul8twrwkyxbwFUCB?= =?us-ascii?Q?HKZG5KGA1fSaHs2qhEwEbkhESbzupEeYzYSx97oPmbykgk0CJRSJ9oEWli3N?= =?us-ascii?Q?E/uMq7LDxgtMxdGyNQ953pMx4q9Ic6oanjFzNEBQoL1OIYg2VZpsY1GqbfWg?= =?us-ascii?Q?2TZWGZrRGr3n7X0BORFkgBy1ZTBp0o1svMxqQU76/413LZJ8Fc/C2S8bMlCn?= =?us-ascii?Q?riSpuS2tgHNUQxWr61HvgIAMYLiFOuEdAGVck3Rb4f7sqbTMPC/iM17z7YyL?= =?us-ascii?Q?IywnAwN0kUpAEqHT/aXbEuIlenCzdrxXuQbvVWkQsqQEFQmGkpSXI9ha2ioH?= =?us-ascii?Q?jAmz1OSZaYW/OT3E6jKVRKgLe3jhhiSz6/rrNHqniIVHci+JefqEbDKISYQB?= =?us-ascii?Q?vtvnHuGo9TtK7ZTk6OUccT9jhWQrUjhTrpcMUSwDI9U8RpPhvUaj9lagq+sT?= =?us-ascii?Q?8JhC2vn/euXykQbcwJi1bfp8nPs+cLS5ACbzYpWvkijs3ZzQyaqpqRT5adMg?= =?us-ascii?Q?tj8Z8N+PzcTuTzyWs5xbmOkbZUzkuznce5DNOIMadId0FFttE2aV/50cZ7TT?= =?us-ascii?Q?uqy+XoC+Kbswjgv32u0NtSnxdf4cafDQHztBhJhRBHOGzNwzsvPH07sIyLyI?= =?us-ascii?Q?Y0JoB/lPOtNko0Wct2cNNqHueoMvAGpGqACYQgIyrVhSuNvlKyatXMMiwudX?= =?us-ascii?Q?KpR+uUuf5kRI04g2f+sndBeIEtPoTwcFHolJk6Ruhy5K1ibP79qu/SVWbDch?= =?us-ascii?Q?j2IoVZHN7e19g9dMe9g4Vh2UsY1pTq0VTXZEiB9gDCWKKM2S4yYv0J63s8nb?= =?us-ascii?Q?e0EdCAKH8IHP+TBsynUeKIgm7tKCSH9K6TfxgevP9ZLZiJD0+pGVBXI/22ij?= =?us-ascii?Q?Xge9f6T2q/9uh0wjYjTW9jklo2IBpeQUD8mJ3mC9?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2987230a-4c16-4095-3a69-08de1e80da4a X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2025 04:39:50.2332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l/S1GthjklF+cMhTO4KlGotp6Nw9AL1Yq3o18mH6nlwgZj/IFihyogoLlKCe9ivY8mcvlcztDwVHqxm8Cung/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4169 Content-Type: text/plain; charset="utf-8" NVIDIA GPUs are moving away from using NV_PMC_BOOT_0 to contain architecture and revision details, and will instead use NV_PMC_BOOT_42 in the future. NV_PMC_BOOT_0 will contain a specific set of values that will mean "go read NV_PMC_BOOT_42 instead". Change the selection logic in Nova so that it will claim Turing and later GPUs. This will work for the foreseeable future, without any further code changes here, because all NVIDIA GPUs are considered, from the oldest supported on Linux (NV04), through the future GPUs. Add some comment documentation to explain, chronologically, how boot0 and boot42 change with the GPU eras, and how that affects the selection logic. Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 35 ++++++++++++++++++++++++++++- drivers/gpu/nova-core/regs.rs | 42 +++++++++++++++++++++++++++++++++++ 2 files changed, 76 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 94a6054bab95..5650c115c613 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -171,9 +171,31 @@ pub(crate) struct Spec { =20 impl Spec { fn new(bar: &Bar0) -> Result { + // Some brief notes about boot0 and boot42, in chronological order: + // + // NV04 through NV50: + // + // Not supported by Nova. boot0 is necessary and sufficient to = identify these GPUs. + // boot42 may not even exist on some of these GPUs. + // + // Fermi through Volta: + // + // Not supported by Nova. boot0 is still sufficient to identif= y these GPUs, but boot42 + // is also guaranteed to be both present and accurate. + // + // Turing and later: + // + // Supported by Nova. Identified by first checking boot0 to en= sure that the GPU is not + // from an earlier (pre-Fermi) era, and then using boot42 to p= recisely identify the GPU. + // Somewhere in the Rubin timeframe, boot0 will no longer have= space to add new GPU IDs. + let boot0 =3D regs::NV_PMC_BOOT_0::read(bar); =20 - Spec::try_from(boot0) + if boot0.use_boot42_instead() { + Spec::try_from(regs::NV_PMC_BOOT_42::read(bar)) + } else { + Spec::try_from(boot0) + } } } =20 @@ -188,6 +210,17 @@ fn try_from(boot0: regs::NV_PMC_BOOT_0) -> Result { } } =20 +impl TryFrom for Spec { + type Error =3D Error; + + fn try_from(boot42: regs::NV_PMC_BOOT_42) -> Result { + Ok(Self { + chipset: boot42.chipset()?, + revision: boot42.revision(), + }) + } +} + impl fmt::Display for Spec { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { write!( diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 8c9af3c59708..5d6397f6450a 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -41,6 +41,22 @@ }); =20 impl NV_PMC_BOOT_0 { + fn older_than_fermi(self) -> bool { + // From https://github.com/NVIDIA/open-gpu-doc/tree/master/manuals= : + const NV_PMC_BOOT_0_ARCHITECTURE_GF100: u8 =3D 0xc; + + // Older chips left arch1 zeroed out. That, combined with an arch0= value that is less than + // GF00, means "older than Fermi". + self.architecture_1() =3D=3D 0 && self.architecture_0() < NV_PMC_B= OOT_0_ARCHITECTURE_GF100 + } + + pub(crate) fn use_boot42_instead(self) -> bool { + // For Fermi+ GPUs, boot42 is guaranteed to be both present and ac= curate, so that's the + // point at which we switch over to relying on boot42 for precise = identification. + + !self.older_than_fermi() + } + /// Combines `architecture_0` and `architecture_1` to obtain the archi= tecture of the chip. pub(crate) fn architecture(self) -> Result { Architecture::try_from( @@ -67,6 +83,32 @@ pub(crate) fn revision(self) -> Revision { } } =20 +register!(NV_PMC_BOOT_42 @ 0x00000a00, "Extended architecture information"= { + 15:12 minor_revision as u8, "Minor revision of the chip"; + 19:16 major_revision as u8, "Major revision of the chip"; + 23:20 implementation as u8, "Implementation version of the architect= ure"; + 29:24 architecture as u8 ?=3D> Architecture, "Architecture value"; +}); + +impl NV_PMC_BOOT_42 { + pub(crate) fn chipset(self) -> Result { + self.architecture() + .map(|arch| { + ((arch as u32) << Self::IMPLEMENTATION_RANGE.len()) + | u32::from(self.implementation()) + }) + .and_then(Chipset::try_from) + } + + /// Returns the revision information of the chip. + pub(crate) fn revision(self) -> Revision { + Revision { + major: self.major_revision(), + minor: self.minor_revision(), + } + } +} + // PBUS =20 register!(NV_PBUS_SW_SCRATCH @ 0x00001400[64] {}); --=20 2.51.2