From nobody Fri Dec 19 19:04:44 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D350F28030E; Fri, 7 Nov 2025 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762509358; cv=none; b=WoFi03C2Ox+1Zipj66V+oYfMJHP5CzuFBK+HBLCcTdb9SlDCuzh57P5smQa//oSW+p4EuuQB5l7IGzsl1yVR2t1HAfq9jlIXbFyU4qM3NuNYFq6zxTg7lKDwDDliH8eARaOOGTe5q+z+2qlW1wXy6fFTIrbiGX+eTzmrrefL+Sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762509358; c=relaxed/simple; bh=oSiwIvJ1gwfv7ZxU/yi/8StPjRYz/tn3ajtoVttXTB4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aPn8YRXBSC2IJFv6/U2agrm+HVOS04eMUY4WPrnmOfMdyVmkj+DIH3cda3nGMHpgWaRXu1uQ4JCy67kWxTMvyqFfa77p7GtfcPcqTVWmxFGbu/541PeFFd9zY2iXYSsnx9d4Fd2Z6PN7QTxrESO5S2yiTghSWPDXIdk0b30MIe4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [223.64.68.45]) by gateway (Coremail) with SMTP id _____8Cx5tAnwg1pZUIgAA--.4739S3; Fri, 07 Nov 2025 17:55:51 +0800 (CST) Received: from localhost.localdomain (unknown [223.64.68.45]) by front1 (Coremail) with SMTP id qMiowJCx3sEhwg1pBL4qAQ--.58318S2; Fri, 07 Nov 2025 17:55:50 +0800 (CST) From: Huacai Chen To: Huacai Chen , Andrew Morton Cc: Arnd Bergmann , Vishal Moola , Kevin Brodsky , Jan Kara , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Huacai Chen Subject: [PATCH] mm: Refine __{pgd,p4d,pud,pmd,pte}_alloc_one_*() about HIGHMEM Date: Fri, 7 Nov 2025 17:55:36 +0800 Message-ID: <20251107095536.3101371-1-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowJCx3sEhwg1pBL4qAQ--.58318S2 X-CM-SenderInfo: hfkh0x5xdftxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoW7uw1fGry3Wr1kZw4rJrW7Jrc_yoW8WFWxpF s7C3y8Z398GFyfWa1jy3Z7Cr17tw45GFW7AF429Fy5Z3W3t34fGa4DtrW7ZFZrAFZ5ZFW5 Wrsxta9xArnIvrcCm3ZEXasCq-sJn29KB7ZKAUJUUUU3529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2kKe7AKxVWUAVWUtwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUtVWr XwAv7VC2z280aVAFwI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwI xGrwCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU JVW8JwCFI7km07C267AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26c xKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAF wI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j19a9UUUUU= Content-Type: text/plain; charset="utf-8" __{pgd,p4d,pud,pmd,pte}_alloc_one_*() always allocate pages with GFP flag GFP_PGTABLE_KERNEL/GFP_PGTABLE_USER. These two macros are defined as follows: There is no __GFP_HIGHMEM in them, so we needn't to clear __GFP_HIGHMEM explicitly. Signed-off-by: Huacai Chen --- include/asm-generic/pgalloc.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h index 3c8ec3bfea44..706e87b43b19 100644 --- a/include/asm-generic/pgalloc.h +++ b/include/asm-generic/pgalloc.h @@ -18,8 +18,7 @@ */ static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) { - struct ptdesc *ptdesc =3D pagetable_alloc_noprof(GFP_PGTABLE_KERNEL & - ~__GFP_HIGHMEM, 0); + struct ptdesc *ptdesc =3D pagetable_alloc_noprof(GFP_PGTABLE_KERNEL, 0); =20 if (!ptdesc) return NULL; @@ -172,7 +171,6 @@ static inline pud_t *__pud_alloc_one_noprof(struct mm_s= truct *mm, unsigned long =20 if (mm =3D=3D &init_mm) gfp =3D GFP_PGTABLE_KERNEL; - gfp &=3D ~__GFP_HIGHMEM; =20 ptdesc =3D pagetable_alloc_noprof(gfp, 0); if (!ptdesc) @@ -226,7 +224,6 @@ static inline p4d_t *__p4d_alloc_one_noprof(struct mm_s= truct *mm, unsigned long =20 if (mm =3D=3D &init_mm) gfp =3D GFP_PGTABLE_KERNEL; - gfp &=3D ~__GFP_HIGHMEM; =20 ptdesc =3D pagetable_alloc_noprof(gfp, 0); if (!ptdesc) @@ -270,7 +267,6 @@ static inline pgd_t *__pgd_alloc_noprof(struct mm_struc= t *mm, unsigned int order =20 if (mm =3D=3D &init_mm) gfp =3D GFP_PGTABLE_KERNEL; - gfp &=3D ~__GFP_HIGHMEM; =20 ptdesc =3D pagetable_alloc_noprof(gfp, order); if (!ptdesc) --=20 2.47.3