From nobody Fri Dec 19 20:33:08 2025 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013069.outbound.protection.outlook.com [40.93.196.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 096A830C62C; Fri, 7 Nov 2025 07:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501362; cv=fail; b=CdivlWanx7bzMKNXk51zHAO2/9SSdquYQYyJYcj8FGGApEAN2YMz+m2iDZCi7MANOWTlqM1hAXBJ6FE5ZO/8xMcNTHjmnP1XKR+YQaMqKBYFSWUy9rHFWx1jLqn6DnYf5tqFbsI3iD1Rv9qVPe8bbEvmC6k57NPK6m5lilFn8gI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501362; c=relaxed/simple; bh=GFX4YnCsu87yV1eSlhHJtD5QlrWb7o73yuUInXCJz+E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TMydfNaNDxyi4mwY1AhADEAV/9t0ZY1evD/RYJI87KYUuOpsj5/3hO6sBFWB/V4w9gysYYvxRo2gtFTSXQ0bEztz5ipnLgwGDfldxpGodDQ2MNxLShbEpYB5m+cCopP6pwMiH158Uk7gtddVfVwzqf2yH9I5VlUV+V38Tv6vMyg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pds9+gcH; arc=fail smtp.client-ip=40.93.196.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pds9+gcH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yAZ0Zh2OXfPfolC6OZgqRgCbuuYJNhS2PBG6q2P+vVX8MlYIkAlt69ruhNVHDQufUZnTGWmxgus7+VhO9CowgFNc/7Fcjfi0942fkoI0s0DVAXKIbqzk2ho1dTU2S0mDmv/NaRVsGEQrRiMF7YgO/DCaXgeMaD9EOQmJy0RdNITEU4hIMWoaCIYIc74I9FQ4QR7Kycu0Fs/sqA2wmSwFPYHbUgKgK4Ki+8QrXpPgJ7aHCe8BiCH/JUta1Q+++ZtufJwCzJ0m8RndMK1mMP+gkZLHXvDcabFxRIwQmyymqm0JiAUv/XLsl3NaqWtC+a7IWL2A3FNh4MAmqZ5td5sUYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HDlz1tLA4MMIbsbUhrZfkp6OyiycsgMfjiZSRry11sU=; b=yiw8ZH67tNMXL5tPtCQaxk1kQgyOg/0/vSeKc8uZQiVGNEmn18oZhBEr5BT2twqkStiRcMRf1RJ5YR1gF69UNBbHPlLJTfIiUxIeXuB7QBVa1j/ue9VOGmc0lv11YZt3zLk1rCbef444iTmV5IguSxWYZKAHIxCVYqcQeqaeCycVymN+ryuvQ7RafhkRgaptnAy+msYe4IDjTGIyG7JlgovDUaq9Tsw8yNCYMvQ1lWK5ImuB8yY1OFKeJqHNIc9GaRTxInc7w55nGOyexf0WfKR4ZnnS9SeVZctR78IBmuftAgxrb3vE055SeAz4rNCdTD1nJfqvEm5Prwlhf34Wlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HDlz1tLA4MMIbsbUhrZfkp6OyiycsgMfjiZSRry11sU=; b=pds9+gcHN+Q+PlL0o1trMVr5uzTBsLwRHClH8denCSMH+D6ze3pZ9Y28+UmiyF9ix2IkdWA8Od0MhvwotdcHQh/7xZ3diMS+OeDtp5BUYMzvtqSJEWDUjGjBamftLHjunM7HFcc3Ddx2tT3jsGzURKrWccyjQNpl1dAY+CfMhmM= Received: from SN6PR2101CA0011.namprd21.prod.outlook.com (2603:10b6:805:106::21) by DM6PR12MB4140.namprd12.prod.outlook.com (2603:10b6:5:221::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.13; Fri, 7 Nov 2025 07:42:34 +0000 Received: from SN1PEPF000397B5.namprd05.prod.outlook.com (2603:10b6:805:106:cafe::63) by SN6PR2101CA0011.outlook.office365.com (2603:10b6:805:106::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.6 via Frontend Transport; Fri, 7 Nov 2025 07:42:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF000397B5.mail.protection.outlook.com (10.167.248.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Fri, 7 Nov 2025 07:42:33 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 23:42:26 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" , "Mario Limonciello (AMD) (kernel.org)" Subject: [PATCH v2 1/5] ACPI: CPPC: Detect preferred core availability on online CPUs Date: Fri, 7 Nov 2025 13:11:41 +0530 Message-ID: <20251107074145.2340-2-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251107074145.2340-1-gautham.shenoy@amd.com> References: <20251107074145.2340-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B5:EE_|DM6PR12MB4140:EE_ X-MS-Office365-Filtering-Correlation-Id: 9abbb735-1ceb-4490-eb99-08de1dd136c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?h2wH/nsJZRz+sUaIv6eYG4eps4V6lVoYtFKcKepPCBfr9OtKdMfMmiCCtzR5?= =?us-ascii?Q?4aRgtoJu5zHiXwj9U8QNOacQjuNERPcXBRLWPU/K655Ir+xJsy/LOnxna0PG?= =?us-ascii?Q?LW1G+i7q1iXupO+q9X7ZYA6MvROY8tsjtxcSqQh6lgV4JS4fiyixRKLUYDMD?= =?us-ascii?Q?bWB7NhSLq+dMsgCLuuxU2H80/579AHaZYC1fEf1IteigTDW9LXLwfowV/2od?= =?us-ascii?Q?piQM2LzmpbLZuyVWbicM1kLcZWLzAHh3JCx2xXuqxRiS9/2N0E3pgYZBumTe?= =?us-ascii?Q?Cpb4HgHbcEmwrHMxSaCh4eP0xv013mMvnN+/ERh90a4/o3ajAkqu8BUaAy5L?= =?us-ascii?Q?83dYAsDqZKGr9LxLQRySW4m3uaa5RM3w5GRvWsNkN/phnVxjJWBzaLeZsDFd?= =?us-ascii?Q?dTCBakY05tOUc7wuFCY8sK3YdmE4M6SHrpCPof+9YBhUBcXqqGCNcFYYzXBi?= =?us-ascii?Q?1oLcXWwYwC0CPvj3C+JIGx+1AO86qN25tDcA6QhCX3KCZOFm2TwS2SjsGxJ7?= =?us-ascii?Q?kbQmVeW+ZQBc2zaGahdduNRJf+Opn7fgZ8mvDZc+MftA0qQ/kJrm6CMwo59p?= =?us-ascii?Q?F8He1UY5WDIDhSSxIIisQUATgQaTS3ta0C5N5cn4GDPwEFjgj+Ckl9zbqfFu?= =?us-ascii?Q?uPtsZS1rgKviAD7k12FYb+Ftfr2M6duQzmgqH7VuV8vLSqNq9QEMn+DOUFCh?= =?us-ascii?Q?sROhdrzpKL9YBl/YKFK91mvduIh+MKbUtjhMI7LluxYMDXKYnfRojq0kkajG?= =?us-ascii?Q?/n3B0UgNwiIi8MPPQzretCHJ0wkXVZPyi9equPHPr7otlAdMLioogV/UfkIj?= =?us-ascii?Q?WOSSeapFHCxpKK+Sj4rlg8TyZTHY+owCPWAiHBYs5YdZAWHxkcJtyX7SRNA9?= =?us-ascii?Q?fn0lVFSE7KT3FYAZCAfbhklDMGj/aqqsox62Y3jZtX3lRcbmbjUVY47ma9LP?= =?us-ascii?Q?HXlC90wJD0A78dmNsRtqaScRMu0fxkSex3I96dOeZcAiHsNrJPpQ62rwoiip?= =?us-ascii?Q?DzLi3K0Q8NaI3F5/SbqNiVgFGoFs3ddIGqTOFe3vLfR/Gv2hTzG9T7vzhZUi?= =?us-ascii?Q?sBJ1sDYQB1ll2F7X/M4HORv4tEOkcdD+r0Gw+JDxhsN561Higdv7Dm7PSi2Y?= =?us-ascii?Q?5sW9dK1atdlS2edzXB7Flw/0rq2jm8GZE4g16kr45WM1rq+/C/RvuSGzedMh?= =?us-ascii?Q?H3thLjk1zbc/lBrLc3gBmXBohbeUKgsBQUzFGjNmN7iC7O+uXGbhuM+fmWph?= =?us-ascii?Q?bfHFIyOVWpVaFbYvMyKhNrdL/sjz1tSCMxNdMXzR6DFpAS61r3soHVUgP++x?= =?us-ascii?Q?vmHri78ApZOUF4y43lr/Hh3f4AtaH1qobZAYYsTGK+mTSBohfwNQOCFzmAn7?= =?us-ascii?Q?RQ4gtojX5TsZgPK4SqQo/w4QD4qQFLoZgFaeQQHD5ZatWFA2RxLaRE/3P+eh?= =?us-ascii?Q?I/MzaEvmaqV4sI9WwNgIKncXs01YA4hYh+hhD6CwfJZ7cvllKibbVQ/VhGb9?= =?us-ascii?Q?qSRDbGvIlbk4zDZpjsaj7Q3mAH0D6bI/MDwZwpF1X28Y+Z3stZcG7U9e0TR7?= =?us-ascii?Q?jCRTg/5Dkj5iMuNWBNaPD1VimPYoVtnJjhgJzT9z?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2025 07:42:33.6628 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9abbb735-1ceb-4490-eb99-08de1dd136c4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4140 Content-Type: text/plain; charset="utf-8" Commit 279f838a61f9 ("x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator()") introduced the ability to detect the preferred core on AMD platforms by checking if there at least two distinct highest_perf values. However, it uses for_each_present_cpu() to iterate through all the CPUs in the platform, which is problematic when the kernel is booted with "nosmt=3Dforce" commandline option. Hence limit the search to only the online CPUs. Fixes: 279f838a61f9 ("x86/amd: Detect preferred cores in amd_get_boost_rati= o_numerator()") Reported-by: Christopher Harris Closes: https://lore.kernel.org/lkml/CAM+eXpdDT7KjLV0AxEwOLkSJ2QtrsvGvjA2cC= Hvt1d0k2_C4Cw@mail.gmail.com/ Reviewed-by: "Mario Limonciello (AMD) (kernel.org)" Tested-by: Chrisopher Harris Signed-off-by: Gautham R. Shenoy --- arch/x86/kernel/acpi/cppc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c index 7047124490f6..d7c8ef1e354d 100644 --- a/arch/x86/kernel/acpi/cppc.c +++ b/arch/x86/kernel/acpi/cppc.c @@ -196,7 +196,7 @@ int amd_detect_prefcore(bool *detected) break; } =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { u32 tmp; int ret; =20 --=20 2.34.1 From nobody Fri Dec 19 20:33:08 2025 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012033.outbound.protection.outlook.com [52.101.43.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5E530C630; Fri, 7 Nov 2025 07:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501378; cv=fail; b=bJtq2Rr5LvMmrs8MLChxHaprg9rNjFfH+knmrHIzWkHlY61bDr0+eNJm0JyUkwhS13kb/rCJsSbReQbr/SKNOcxlLr0WNEGc84AjhqWR5qyzIfSBePxNR9dnOQX/bdfMbzHrpeAavF3CMY1Drj92P81OYdpJQowmOCndW9Jznzs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501378; c=relaxed/simple; bh=PmFEeqilhVg2taOfEmUde87eDZoDgmnfOGFjdBh4xBk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UmnKsesqyR6BWHxZIkhOzS2FZ2YQJd7CugDdoDVJVEoF5P7Ts7vUtksgUh9pPO8DuAZ9LPoh4BkwDse0cfdFy7aJa8EEdMqJs5XIul7Ymr/FtiJdHBgpBXt9AheTwT6bl3ZhrnYLHaFDfyWgiBPtQFR9/cc7rMM1Zjej1OfttK8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IPxRVGZc; arc=fail smtp.client-ip=52.101.43.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IPxRVGZc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Or95x5jEAwleJUmYUiUsdt+aihSwNmcObdX7N8f9GFgejcZWiXauTwXcnxBgkdJLaVa7UxnXiVq5SDVQnrNk+h2b2mRg97kTBerGfakvmv/jtzls1hwI/0Ph8IENpzdNahvProHOdwjMubVjb0LO8djGsSBg3d4xiuOAYoYFUkSMr2/OeazPLBIMb2bM8TEYdG0tHeG8ejYwmH6KSs+STO6hmVMa19sEBym9d44kwBRlVdXHRrJbcXiYo5B1i6nRjdaN2WklmObJkL0Pc1plwyUG2BYscnufeSKNz+UpDVpVnaWQHfzl3c1oMy/XIYSdLvRgNqseVq4wYUNcTHm1WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYTrw7wbpyKtHQVJCg7QkmvxauaVucuZWtktIncC/I8=; b=l6wq3GGGV+lPBmRIudNTh/mNjkIAwTgDqkow4/JcOxVi6GBO3Y/64S+47b4TvUoUWUXziVwW/lObJM0feEWbx8J1ir/s97vV2DjcvbBxj6gnNeOLLBp5bQ4e4JelQWlN2MTPDhJIerslgViFp9ttYSKpaHcmOAjjbpJbsN7VZogqP8BI1lAYnd+rn8PXpZWik9ZkAoAQO6X+k907+WF5U8VqzHwOe5T/sGTgKPVB0xq3IQKqg/fqsO262/frp8OLJCYLBV1IOdo2zfrKEiq+vb4t4VCyoz2nezTOx5v+VVR9ufSTWGn0jrXYPXo3Pq1EfStTWvsarM4/Aw0n8HnrEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYTrw7wbpyKtHQVJCg7QkmvxauaVucuZWtktIncC/I8=; b=IPxRVGZcg6ayH1xGxw4tdBwt8ANnXSfrUVAKXaMVt+WHO0kSGSJI37/1u7xzRIVt7/OGQWn6S4YaHCm7y0IZN9ns5Jlin06cwf6n3l5GyTaHfVpGmW1b/eSmkG9kBb5N7qpjFgEGzDr62EWd6fQkSokjRJJdajmyf/pHB2m+rdc= Received: from SA1PR05CA0008.namprd05.prod.outlook.com (2603:10b6:806:2d2::15) by CH3PR12MB9730.namprd12.prod.outlook.com (2603:10b6:610:253::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.7; Fri, 7 Nov 2025 07:42:53 +0000 Received: from SN1PEPF000397B3.namprd05.prod.outlook.com (2603:10b6:806:2d2:cafe::60) by SA1PR05CA0008.outlook.office365.com (2603:10b6:806:2d2::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.8 via Frontend Transport; Fri, 7 Nov 2025 07:42:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF000397B3.mail.protection.outlook.com (10.167.248.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Fri, 7 Nov 2025 07:42:53 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 23:42:48 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" , "Mario Limonciello (AMD) (kernel.org)" Subject: [PATCH v2 2/5] ACPI: CPPC: Check _CPC validity for only the online CPUs Date: Fri, 7 Nov 2025 13:11:42 +0530 Message-ID: <20251107074145.2340-3-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251107074145.2340-1-gautham.shenoy@amd.com> References: <20251107074145.2340-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B3:EE_|CH3PR12MB9730:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f316b86-62e8-4786-8e15-08de1dd14297 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QTxf5cjxRWAtovt9/nRxKhf2rHuMruZeSX52LF0Jg+o7pVboy8xwqPceDW6M?= =?us-ascii?Q?NQ94iBbTYPtQLrZWSQIiG0rkQ9w+s3SYTmFlyLIgORALWjGdl0fZ5+bdFEBj?= =?us-ascii?Q?dWtmExd4SN+Znt/2l80TLp+SKGGyefTIeSdaFjj9UG9YIl+P+RzjcQuf0bso?= =?us-ascii?Q?NuChYvsGN8R4GJiFZ+ELxNwRiLzvUjQ+R/ItKadgkL31V3+MiGq0oxHq6mow?= =?us-ascii?Q?dpJzVJc6SsOszGlwt+zD7Ar9MJSVMB7WoCA8qWdd20W68rArxGaezYGK48hC?= =?us-ascii?Q?zGPFk28YuVWSGTnhb3Fc0IwRVsM5R3mw9gY3rxTpXvD/89t2BVgDOA0q5XnS?= =?us-ascii?Q?JzwgC7W+pzOZPE+e0s1Iq6YAI9kFVXLNQd2o6YSAeJ/1rGiuNNqJiWBmGCL0?= =?us-ascii?Q?69EWBmZa2y2pgjFiaFDdQ2T9TiiagAZiTGIAh8DkKq+RJvhBMryxX+DdNxB5?= =?us-ascii?Q?M7fowDlipsF1T8k0JE7s2lJlrTvuGNNmOYmERvBesIDFW3ScXaCT6Xc8n+1V?= =?us-ascii?Q?yqocvGoz0kKuQo4xM6mb+9SfcNtxF86kPCZuevGTcKgTLw5WAz471dgjQwsc?= =?us-ascii?Q?KcjKldjSqt//AdDm0zFGaY0PTLJ15Yx94j0admC5lSMj3B4mLKKFJvwITyUM?= =?us-ascii?Q?db7lfFGOgpF079iPIJuLHvuIvL6lun1W7IgItEvbUah7hz4Y9Lgb/6IUFyvO?= =?us-ascii?Q?oZ19lS9sHnoVs+b+H6bGQbHyp05oVLhkG6bfH7O+BetFKUy1UGObpDZu6rmB?= =?us-ascii?Q?mdvvXe2I6gJDXVEn+9zeAKVGlvhLjrLL/EtZ7LCcXoYvq2M9W62AeJALSTlC?= =?us-ascii?Q?+7QL5iyouBnO8KGXvcAG52X0X+8TG7xCkMN82qU1Mm/zIyuncCsiGZp8TELd?= =?us-ascii?Q?hvEfev1OwBscEbc1fZeCkgyABywdWoPXw25oIciKi1M1Q1Yj5z3FJ3o/W91V?= =?us-ascii?Q?MFterGin3JsW5urFyGJmyEronV20tfFij3gK032z7i9zl4DMHJVjjCWXdDJU?= =?us-ascii?Q?Bj6eDa6V+AY7zmYOixoBJkAo5/32OuJ++XwnxnJ3GsOoDk6rVcrb5MkMzYdv?= =?us-ascii?Q?lVA9isiEBW3VPzU0yVMPpmI/gQM+WcET0f3IcjiIAA9gue9BTfjT+FSBGnB7?= =?us-ascii?Q?AItKCoSf9Vmw8QCHtv9znXUAtzRuyEbtiy+zd5jZM1N68cbSWGJ8Ao7QoEgL?= =?us-ascii?Q?y605fHfsHMvoACSTbUKMjYnKqoZVixRsBlIng8tS9VUCPDi5sLZOtWBlWITZ?= =?us-ascii?Q?R7sFlob1Oy2hyYeKcO2lXJzZyH6FxCsXTIc2yXSDvzuCaodhHQhLTRMP8FaG?= =?us-ascii?Q?53b5nr95/2ofjj9+xFbPEIVmDtDgFqYVeKjCMih98h18piHq8BisjxUGktwP?= =?us-ascii?Q?/wKr/2aci7aA+YFeN4EtF4O5VLjHvZq2ID4yzJoiH1uDLAaey/hE+olnIAlS?= =?us-ascii?Q?aerIa9oD5L/zVn4d93CHqEcPHmHpMClmmvGblhDKNApNKx/lYOaiMZCvBqaM?= =?us-ascii?Q?FPGGO7lm1g3oef7sIGj+xvZrL2ZD5AoLCH9sI/EbLnkzqeHsXkqY1C6cxwTZ?= =?us-ascii?Q?0takACIeusHQW4f8LhddOSd3NgZTWBOhAyKIZssQ?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2025 07:42:53.5103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f316b86-62e8-4786-8e15-08de1dd14297 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9730 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function acpi_cpc_valid() checks for the validity of the _CPC object for all the present CPUs. This breaks when the kernel is booted with "nosmt=3Dforce". Hence check the validity of the _CPC objects of only the online CPUs. Fixes: 2aeca6bd0277 ("ACPI: CPPC: Check present CPUs for determining _CPC i= s valid") Reported-by: Christopher Harris Closes: https://lore.kernel.org/lkml/CAM+eXpdDT7KjLV0AxEwOLkSJ2QtrsvGvjA2cC= Hvt1d0k2_C4Cw@mail.gmail.com/ Suggested-by: Mario Limonciello Reviewed-by: "Mario Limonciello (AMD) (kernel.org)" Tested-by: Chrisopher Harris Signed-off-by: Gautham R. Shenoy --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ab4651205e8a..50e6348b511f 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -460,7 +460,7 @@ bool acpi_cpc_valid(void) if (acpi_disabled) return false; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { cpc_ptr =3D per_cpu(cpc_desc_ptr, cpu); if (!cpc_ptr) return false; --=20 2.34.1 From nobody Fri Dec 19 20:33:08 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010013.outbound.protection.outlook.com [40.93.198.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9711C30C61E; Fri, 7 Nov 2025 07:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501406; cv=fail; b=DS/snnRCeGrprrGZ36jjEcJcK5fsVJbHvNheUbTZ/vC9H0kiAfgOp5sLG7Bd1PxGOy+ytEeYsRy6Y+T1NU2dwsiYyod/AeH1af5OakKs5wD+KwKQMga0YpeOk5bUCsbNVot0lm7YrsLTqvA2a8ZRgiT5cop1/ttmLvcUVDx48wM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501406; c=relaxed/simple; bh=tfJOe93wpWp4aQ5VJj57yIzefkQrNWOBTL8Cp3qe7dg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AHp1g6Rq/gI+gZfE6KeB0gEzu91DLiidsHcL+DK4gv0U/gxqTs52NivFm3L8WKZUKO+mH6jtHQHOkVxJuGMrQ8J0SxPgzPzErfqpHGGfuJkxahmRTXR/dxCiRSs5mnsbp9dgkfAgLIFOLVC/Gzl/s1piNYVMY9aE68lVzn0r5oA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=P5tA/RM2; arc=fail smtp.client-ip=40.93.198.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="P5tA/RM2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UXTOBkL6Y2mVFJyVPjgTijIyMckBjdxa+ZaBo23DyvGm/RfqRhZ8TvHmUc0dlU0n2+oNggxRUXB7HHSSUnBGbzjNV2zTQ5IfijwGESC6fsKWuoKMoZjsL3q220O5uiOqZNx0Dl9uWOO7Cdua7gjHBxqKaTRygxMohms/ZtTxor5U5sB8AenDeMipKbD5nq6fZxJ9d9p043dLUpP5T1MPDY4wRTlyvcz+98Lj+kpIhbcbUpbBOhbbhzTVsdJpNGClTcnGCQEaetKdS6M1slhtounVPuCJCGAUNXglztJVaykSgwKw102PqvBtQs9E7YiGiKQtzAvUZpp6lgZ3GwDrNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UdBM184OlOeHEEgkDtBDauPZfI2aDO0KT6fC8cy3NRI=; b=R2H/pCqGSi3PpmeHloSON0REeqG7xB0CvDpOr37HiQ7uAd6+jXYqNKSKUqFsiiDq0avXEh4jdua6jr2uX6EdnNof7p7043EJYb42bnrlrxS/gFxfhC1NsSWRG6y9jH+dRvFjS+FbAQhBvQpu5E4AsEGhkRpKU14WVaGScHHmbn3ZUQRVYlgm8XZjYUj2z7zKNIGcl6eV1MWLSMvgtXCPKC9lgD7TU2q2o4sArhs8bncLssgkadoDSKyrBW1i2wxJB/RZCLb8L72expO/O7AIa7rRXOo5fJvdJLyIiyByTDLunPKJCrLyJ9x3zenzyrlN9HQrHGFxml4yWYhAIL/g3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UdBM184OlOeHEEgkDtBDauPZfI2aDO0KT6fC8cy3NRI=; b=P5tA/RM2xKftlyAxGKrcuu5jmxiCOatoj7tpwQ1/k9oOuXZ2C3vCp50Gib23fD71SS9rijSXB68HUsFKjIt2tj8j3pDfofaZNRT1hT8pMFfymxWJsDNX7daXp+0lN1R54/FT4mNjCgBhX/Mma7VOJk8LmOL8wIWFzZuJg4CCGD4= Received: from SA0PR11CA0011.namprd11.prod.outlook.com (2603:10b6:806:d3::16) by BL1PR12MB5779.namprd12.prod.outlook.com (2603:10b6:208:392::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Fri, 7 Nov 2025 07:43:20 +0000 Received: from SN1PEPF000397B0.namprd05.prod.outlook.com (2603:10b6:806:d3:cafe::58) by SA0PR11CA0011.outlook.office365.com (2603:10b6:806:d3::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.12 via Frontend Transport; Fri, 7 Nov 2025 07:43:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF000397B0.mail.protection.outlook.com (10.167.248.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Fri, 7 Nov 2025 07:43:20 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 23:43:16 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" , "Mario Limonciello (AMD) (kernel.org)" Subject: [PATCH v2 3/5] ACPI: CPPC: Perform fast check switch only for online CPUs Date: Fri, 7 Nov 2025 13:11:43 +0530 Message-ID: <20251107074145.2340-4-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251107074145.2340-1-gautham.shenoy@amd.com> References: <20251107074145.2340-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B0:EE_|BL1PR12MB5779:EE_ X-MS-Office365-Filtering-Correlation-Id: 63196d4d-3cd4-4ae8-e773-08de1dd152cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3zvLFCmo1njtPffEMJnRse38wNVdC0x9BlsOATA9rnBgtgjWxlaH/5dPdspF?= =?us-ascii?Q?JM7Vm0SmT4SzPp8BnxennX3rC2CE0zGhcZOLx+nuRtYQyZ8gvMMwr+vFvUxA?= =?us-ascii?Q?GNlyFMha31W5pAPswrr91vb7NLRbUf1dPqMSr0HC0L/kjT9EC6+9m4Pj1ghq?= =?us-ascii?Q?31W98xL6cnR6G9CUFGvjpuq+7TxzbVmHogLTON9sV+ZQa68HuodOPFKUZS/d?= =?us-ascii?Q?LUd0mBftid+ZW2SX0dPYGtLprotqGdaz4LZ1gAT7lqtBRo+/t6uR22jNzhtY?= =?us-ascii?Q?s8ttyZxRRSsbuHJWZsjilRqFvV1f9/TN3M+trnertyp5N+6GCUts5/BO+oFV?= =?us-ascii?Q?0YBHprZiibD9CUPxTOioWuGGTqw9ljSuV+DGEV+K7zYTqSUF1/93h0ZamU3p?= =?us-ascii?Q?J2zS+GdswllFo/FuaBc/3A/CKfP7VBcWU+yidq/1fIq/ct/AAOP3tvteMqTO?= =?us-ascii?Q?GfWiZ1VtHeF+eh+/3z4a2aBeIVvnTLg2QCC8cGhCdLzdvQk5z8UWeVMjcy40?= =?us-ascii?Q?OL5m9pFs2CyEWcB7nlwD3MdwDbc8Jq7ENWdq4Qrv06aDHz+mfPPkzJ1Zvu+0?= =?us-ascii?Q?VkD9uIfHcrfPXs5QjXiTX2JpwMmIw7Db6F2V+ggY7n52JJsbUtMmOywpJ7aX?= =?us-ascii?Q?xELmMjN89M0HyHyKiqcN9MqwZyqHicFS9VRRDo0GEnXg6LSqzHLphQNjP+9a?= =?us-ascii?Q?T6tk3NlSvATm2LjDyeV8nV2f36lEptlxXdc3MVEhoZzYZrDkE/GerFUAlx6T?= =?us-ascii?Q?zsFhMpKRaMo/HKIoVSNbgTNXt7l6K5+Vb0k28HG3ZaVuL78yE6BBHt8Cnk4a?= =?us-ascii?Q?ze61IcMdM8oYDoJkkCPovmP6SPrC2eP1N7bdPhJBAxm3nXSf/EbPhx4mvGle?= =?us-ascii?Q?ej/Xb2XOrdD6ABflqGsqCAywxOWGFh+UQ/wd81HPii2PtuEB8R07DLureXUo?= =?us-ascii?Q?wxGBHlFn/g/AFVrlWzzkSPeubZS/Nk51E/FTGvsLeCaiZy/PdU46eTdzUPtW?= =?us-ascii?Q?6BFxupOwVPb9wsITrByEEyZnC35cxl/iSJ6Ncd1jdMv1qX5Ow3EKwiEkSI7F?= =?us-ascii?Q?zpQt07S9vASTW/2O53ZLhcB7KBCdGEg9CeKNLbLv+TwU+NRZtBzdtnTefwAy?= =?us-ascii?Q?GNXP6rO1m9hcz4GHSzq+ts2u607NPa/JiaNyZUYnc48vfGhdxZqHU/e/WBZR?= =?us-ascii?Q?GYoST3C9WhHR3pRJOCbEXcFaTg/3wCUixGB9ngvUmHDvpbeytx28t05FNXMs?= =?us-ascii?Q?+PRuNN6eVOz8ME0xZiNDUCigrYoEtJ8q8Ye8h2aE1H04yR7HyyXzZpmP2GZ6?= =?us-ascii?Q?Ucv2NuC2TtpAmbZu/4H3nVaYXew857yte6JNl+SqxeluvB1gaaqKW/8A5yn1?= =?us-ascii?Q?hXAh/Qa/6ji81iYmmH2fHxj5HqAFEftieuOscSwg4C+IiH9ERdcAu58tESyP?= =?us-ascii?Q?gKcskdTS+KoQ7Wd+IPAVNOx7Bv5TYOXZt4gKkrSKiFLs1/8S12/a8wDFJteW?= =?us-ascii?Q?1ONCRlQ3r4pkvfVP1+oJLQgaTIAtRW6fwCivuNVn4cAzflRxjpc3tyygBbz4?= =?us-ascii?Q?fZ8WCJ6HFWjHE1bkRQ8=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2025 07:43:20.7169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63196d4d-3cd4-4ae8-e773-08de1dd152cd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5779 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function cppc_allow_fast_switch() checks for the validity of the _CPC object for all the present CPUs. This breaks when the kernel is booted with "nosmt=3Dforce". Check fast_switch capability only on online CPUs Fixes: 15eece6c5b05 ("ACPI: CPPC: Fix NULL pointer dereference when nosmp i= s used") Reviewed-by: "Mario Limonciello (AMD) (kernel.org)" Signed-off-by: Gautham R. Shenoy --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 50e6348b511f..fb7696b27d82 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -476,7 +476,7 @@ bool cppc_allow_fast_switch(void) struct cpc_desc *cpc_ptr; int cpu; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { cpc_ptr =3D per_cpu(cpc_desc_ptr, cpu); desired_reg =3D &cpc_ptr->cpc_regs[DESIRED_PERF]; if (!CPC_IN_SYSTEM_MEMORY(desired_reg) && --=20 2.34.1 From nobody Fri Dec 19 20:33:08 2025 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012008.outbound.protection.outlook.com [40.107.200.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37594303C97; Fri, 7 Nov 2025 07:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501434; cv=fail; b=MppnXPK+rtZyWmTwYXDOclne37AmroN9vmNNv1ZIaOmbPtwOSzfYJnHt6mhICEiOiz21OYEBB+a1pIq6O1o8/ynqkVGS9/B7ENYo8m1sBWnAcHgA608neWaETNycDJPMRDbudj6JV0+c7+ZRl8CwUA/NnH91tw9+GvrwBO0LroA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501434; c=relaxed/simple; bh=r/lqbeXdn+FiJrdDtXMZ5NxybFnW45SkWCfB9SBaUJY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nVE6TtTOvrvyUFx39getnYmdEb1CggRKCkhCUrj/RToeDTdHx5x3ZYCBbSWCVCD9iWiRXjMGsZ4XqcVrMs8nTtFa97p2UiCWRNEFTvpKBaLpPVYGmLdE9cBMQvV6HQnaxAs6OM6BJJhfxCnoog8XqZiAWjwf0+jEzHiXkxvQGCA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yRqA+m7T; arc=fail smtp.client-ip=40.107.200.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yRqA+m7T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TASvmDL89Lv0YTcM5e8HUE1S8Ck3fXADyoDHNgcvkGmoly6w6zJwfbVIfbTjhCKiBWZfnGqkvO1tf75WmUOQIA0P24CSAyjqpKyAyTzsEZAa9gkbhf8NnDJUtyVGzjoa+QUR2M0bqcudBFzdBMzyZmc/jjA76AbLuRYj4l35CxKuZZXtWtKgPoU9nPK2Q4jI4dU6WYPnhTwgATDdEzVs7BYcVTTTJAdsr+CJtxUrdZV94fK+8fGSOnUDANmsrDfZQJsXtA37nGUoVBT7RsCdjmGQmP9oqS4RHK6TT1F7giuk6mxoPSG3kjtYPQA0BgePcg7cbq+XgdJPEff6eC4gKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pvbagrnBTwXSiYRoU03utR4d8CpMJuEt90S2BF4UZlw=; b=NRF+C0FBwO3liARXGDzHuYvzpxoJ3uP3lXdqgHcRjA54rgK2li3qflu4QhuYSwV8xUo2smLsYd3dsoeUVOY62hrRjJbB7vySISOzJ8RqH0ob/tWwokBI3r8obzXH+S8o40PvOAU1jKruocjLxlbLScLlCnaHFnbmcyqecuE+2MqrzBtaGwdQAM9eMN+gN/oFc6MZOimwLT3U9TpiGDWOf0LYdGZF2Y2sLSvhBsMMS5whKLYV0ZtZxj6IUOAmQ0fY2DPp5RpZCyEBUEW7rgVH4+XY4FfbpeL7csMKpTGMs5tWqs+q3o0RmPH/k8TgHmfCFNGAlatkqbzbzXjNUoq7kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pvbagrnBTwXSiYRoU03utR4d8CpMJuEt90S2BF4UZlw=; b=yRqA+m7T8LoYcDmvU9L3EDew5qdbeX3mLnogYoxH+o4hJZwiUmlgBJisLSQOTxx7zDe9R+4dG+uqcXN752Uby0Pn3+d/ZBQHsudtEfrlBFwqYkyncLdd+W+9Byf6DT8SP/HRlzqE48jAEJddSsIaaPlsK+lnFusH1ZXqoXORYj4= Received: from SN6PR2101CA0013.namprd21.prod.outlook.com (2603:10b6:805:106::23) by SA1PR12MB8117.namprd12.prod.outlook.com (2603:10b6:806:334::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.12; Fri, 7 Nov 2025 07:43:48 +0000 Received: from SN1PEPF000397B5.namprd05.prod.outlook.com (2603:10b6:805:106:cafe::bf) by SN6PR2101CA0013.outlook.office365.com (2603:10b6:805:106::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.8 via Frontend Transport; Fri, 7 Nov 2025 07:43:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF000397B5.mail.protection.outlook.com (10.167.248.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Fri, 7 Nov 2025 07:43:48 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 23:43:45 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" , "Mario Limonciello (AMD) (kernel.org)" Subject: [PATCH v2 4/5] ACPI: CPPC: Limit perf ctrs in PCC check only to online CPUs Date: Fri, 7 Nov 2025 13:11:44 +0530 Message-ID: <20251107074145.2340-5-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251107074145.2340-1-gautham.shenoy@amd.com> References: <20251107074145.2340-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B5:EE_|SA1PR12MB8117:EE_ X-MS-Office365-Filtering-Correlation-Id: b9ee6040-c044-4993-9216-08de1dd1638d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qsocN9SY3B1c3yI29yWmnCIpdwn7dessXEW0Vw5GEK//H61TCo+JjUirnVBD?= =?us-ascii?Q?2Q4zP4h+DgwXrjZTrEVPRT4aojjfPOwQ4FDDeTTDDJD2b+KiLnk1TxRjq29l?= =?us-ascii?Q?mbguCeYjiHqW4TImPjDm5OJB9b6hizECl0ztzzC1c0CRTlDZf1mVFLiLzwDq?= =?us-ascii?Q?Got/4TRN11aY7MofxHIKbmsNdxiDY7MvRak9gySEwjjXOarntjJTmwwwGr5/?= =?us-ascii?Q?MbhQv5QXgAojouX1eHehaz0utuHg8O1gFFH1yB+ekaeTMDqvHQ5sYbgwvfnd?= =?us-ascii?Q?m3TPKzCxjqEPLav4rZohXBg6eyk+wSG+Uq48qdXhL3S+GKYJWbWXruZvd9ez?= =?us-ascii?Q?SCNU8PT1wtCdHnCmmChN8JR0wuyEezmuiFu7obrbjunzzHh7tOf01VGznEWA?= =?us-ascii?Q?3eQ3WzgwNeo3kxJJ+m+T4clMt0XXCOtAToibIAJ4D7qVj9C2iz1GIFRsojAn?= =?us-ascii?Q?Wo4MdbZSTYzRAN7hpU+vIi98Qu1gva4OmCZGuNeUUeHGhbKg7N8aBGz88s1K?= =?us-ascii?Q?v+TBFa/hJZlQfpHpvSniSnpTzxFmW7IcLECNFCLmmSLqlE/grcifT4Py1ghf?= =?us-ascii?Q?2hOz2k+hEMzGtXb69E4qheLkKIOSkOadnT0CVXcpj+/EMOlOrDdkGh6l2Q7a?= =?us-ascii?Q?ci3dg8P/skvYjQzKZv5XBFih0N5JwjqyTL83dElblTx79yJ+rM0P3z9CrDDA?= =?us-ascii?Q?V3yj0OBD2nbV4Njb9BqTA1HxQzTdZ/5RAkWJVmEKyy6X+evbgPIYik2MWKnF?= =?us-ascii?Q?0iCOaX4p1hEfEN9bfGn0PfvvZPPyXN9t/S1Mt1PAyxPjsTlxf8ktJS9DydO5?= =?us-ascii?Q?Q3ORWZCTkdqrnOFbCFQMQ29dm4AnSi7Rm5Ney9+doONW29aD0wuAdnFY8Iz+?= =?us-ascii?Q?YV3UUoaDEmGVXAXDHj7SarvmrgSKCUi9tRiFoL5NmIV3ENzjvhF+41eg8jMx?= =?us-ascii?Q?pdigH9HqQ4RwreKBuh+1wocNpWI0HafshpiB1T7nN3+ndAahEBu5mnKf9rC2?= =?us-ascii?Q?cySBIjsv8SRUf7SJJXCO5akIKgO4FOaEWEBnPn2ifMxT4hP2jwboO8VMpgTt?= =?us-ascii?Q?PVFkAR/Tp8zMAvQ/WRQn6BcAVT7vTb6FuNnh+/xTT3YlaWAdtMnkyPPcsj2Q?= =?us-ascii?Q?njmbYhpovQFVgOHGTVcipjwOWXOzgxXNhz/+5drUZrJZLlMCtcUlpIA/3q2d?= =?us-ascii?Q?tWEbjzVy0iKBNMn7boTFCLai3Li8zoF9pYspk3Cby9AAB4Pnux1WU9tvcs4N?= =?us-ascii?Q?XfPrYPPjFQQxmyg0uW4QSbTphBejfqw7076WzXdGqszcSkNee9WGxTx8ieCc?= =?us-ascii?Q?Zhooy/p7rnOKlYQgz05sZDPz0kdGW6B4oqVpSM7Gm/QdOdoquNp256+vOnWR?= =?us-ascii?Q?oRmA6x0fQRDf+rMiIfdt3G2GYVl5eGFigwOMmJ8U0vps+m8Vt0DjSHLE0PaX?= =?us-ascii?Q?btuBvu7S4ZsoSgHMlbsMJxl3WJcu/Jx4LfBQNi3xMI4jw5wncAiZJ5RXgE8m?= =?us-ascii?Q?bzj6ozsy2vKT61kKRv0bUx30fp0lE9K4GH+YhXFPxaVOVE1ZEJhJv93CaNp0?= =?us-ascii?Q?TxsgPGjytX0BMab7Vrc=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2025 07:43:48.8118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9ee6040-c044-4993-9216-08de1dd1638d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8117 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPU via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function cppc_perf_ctrs_in_pcc() checks if the CPPC perf-ctrs are in a PCC region for all the present CPUs, which breaks when the kernel is booted with "nosmt=3Dforce". Hence, limit the check only to the online CPUs. Fixes: ae2df912d1a5 ("ACPI: CPPC: Disable FIE if registers in PCC regions") Reviewed-by: "Mario Limonciello (AMD) (kernel.org)" Signed-off-by: Gautham R. Shenoy --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index fb7696b27d82..f49c72d3a78b 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -1435,7 +1435,7 @@ bool cppc_perf_ctrs_in_pcc(void) { int cpu; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { struct cpc_register_resource *ref_perf_reg; struct cpc_desc *cpc_desc; =20 --=20 2.34.1 From nobody Fri Dec 19 20:33:08 2025 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011040.outbound.protection.outlook.com [52.101.52.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCD130C60B; Fri, 7 Nov 2025 07:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501459; cv=fail; b=oJEHuiBMCHl6iw38KcevkKr5vC6jZHX0ITLgy7F9lrbvkZu6LlfW0waXL0MWwt9Vi1j9TBruYXCVDbCLsF1Ds3iNNl5pzGMZbouL6WoFINbE3u28Q8x5GBgtWwOrNwa65QTB0os4Q1xXmZPmX3HiFH7Nt7wYhQZnumUF4YRhsis= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762501459; c=relaxed/simple; bh=v5ZbXbpda1x76jVMQVkGFf9nr1Z+yqGWU9LOg6/5svs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e+KzQ85SFEkQ1sQXDVH0XGzKlMJLTUNoi8UxDn4Diuj+V8ksje6r8NDtN3n5aTP/GF1ovlLthqB5rvayHtYuoAlRivi1nRQCu5OZUeUmGpTSeRDAxmF5If3AHO/a4EoLa+0Q3YJLMV2SZWSF/Lux7/tnKWwVe82FZeV3Fl0Mg+U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=og4NOjUm; arc=fail smtp.client-ip=52.101.52.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="og4NOjUm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TcRZYZb9hfFxvrtXQ+7/BRbG/QzgTvEi+Km39iUG5lfCVNXfiCoXiADyl+Ew7KY8GeT74R953iDRovepxs3XF9TqGIPy7c9WkxvcEQE/M3m2kJ6TJdhJlUX1j2ISLmyodrgQm7B/wfDO1/oLiUbjqLrA+fxdbhkWnTiOQcvx+4raH5kt5zA8L3PZrutlJ0xMR0a4PY2K4hwRssrQpeKgy9g7tEDZAh54r5Lp8deeFBOxcEoykdpLk7y2XdaX24heHD84QYKZYhr3tbaNrrheBjx5r1BEWwl1tP+Ht2irG/yi7u99Yg7CKv/tAwZJWqEEMiM9PLh8LYhkspWFpnbD9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XyWawckfW5TGyu9Olo/n9eWgZhfDXa6b7zOouWfKh2s=; b=Cp3uzfLn4zSqmDLB/EzTZmoK1vVQJM/8qjYBkzW+fTh3X4XOpf2t90xOwqybGrxKGQ7nq3dizl38sS1ttS1rKgPuB3qi2Cyfm9rp7sGT2Z6mmFodJyIQl64u/nxf05pOwPyoP2PTv6AxJlaYgalE2y5LNzxUNTM9yjM4v0mvS/NCDQaAWN1Lvn2BaLaKWdgPOMReoo6MUV9sC6Ea5sq6zSZ1vArFpPjZb9qTGTQMaA9w+r44CQa6XWhNwU2PvhIPBl7dgtNjQzi70fV8V2e78ldg0KVGTi9HbMkhe6SzK4bcKsqEwhlMZ6BUC3XdX+84IBw7VqZaReSCAj03u575RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XyWawckfW5TGyu9Olo/n9eWgZhfDXa6b7zOouWfKh2s=; b=og4NOjUmxyWuySzlK1FDtL6sTt/tCk0kzhZ70gs3V6SfzEimN5yceW5ElPwehKz32g4phQFaOq0eIKv3VhzQVSW8lPzxPUmTny0uYB0tGkTu43j5uPvV/REKf21q70JMzG7QaByez1k6QBubFxm1g7F8HYUqrJZ6k05zrP/Hgf8= Received: from PH7P221CA0046.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:33c::33) by CYXPR12MB9340.namprd12.prod.outlook.com (2603:10b6:930:e4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.12; Fri, 7 Nov 2025 07:44:14 +0000 Received: from SN1PEPF000397B2.namprd05.prod.outlook.com (2603:10b6:510:33c:cafe::cc) by PH7P221CA0046.outlook.office365.com (2603:10b6:510:33c::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.12 via Frontend Transport; Fri, 7 Nov 2025 07:44:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF000397B2.mail.protection.outlook.com (10.167.248.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Fri, 7 Nov 2025 07:44:13 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 6 Nov 2025 23:44:08 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" , "Mario Limonciello (AMD) (kernel.org)" Subject: [PATCH v2 5/5] cpufreq/amd-pstate: Call cppc_set_auto_sel() only for online CPUs Date: Fri, 7 Nov 2025 13:11:45 +0530 Message-ID: <20251107074145.2340-6-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251107074145.2340-1-gautham.shenoy@amd.com> References: <20251107074145.2340-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B2:EE_|CYXPR12MB9340:EE_ X-MS-Office365-Filtering-Correlation-Id: 52bdc501-da46-4db8-1d9c-08de1dd17270 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?61KKxY6d2yV7uJBmyPc/hPOVH8blMsCphIZZE5prgg7LaZOWvT46jQori/k6?= =?us-ascii?Q?g0HznTGr18x9hlsxtQGn+AwbkPiaEuc06Wf4OZDRIfjiO9x7+2fAO2GPJOMY?= =?us-ascii?Q?XSgL2Nvl/P2zkT/4mGFLLeYg+VLXMrulAjaPmiixb8CkGfuc228incpwAsFN?= =?us-ascii?Q?xIxfHENw4wL8h9vbRi+GUgLsfPej4ja7pSL+8fgySoxhTTuRLSva4EAM1ol9?= =?us-ascii?Q?QseyhNU8oJOgTUBi5t8GpJQl0bXUWGzBVi+hz2DU1aWLuvCGvkV6YtTb6Vcv?= =?us-ascii?Q?0kyIAzG5jyzeAwO6qf3JfVCkwqxYZofu28dxOMDQDLSCUKwy4LEI37KKvLSX?= =?us-ascii?Q?gp/IZmt7XbTmuJwJ4zB51kwYupn32AN86g9BDg3nCxdVEq43bWCL8bl8lt/y?= =?us-ascii?Q?Ny3mzke+2dsPoacFLsa+756NSqza2DiBFX2ycpco2eT8EG/fh9AS8bBjUKk3?= =?us-ascii?Q?GCFQNO/cf9D/VpEuHoqp4NsLp97mjuNuemhsGtxrH3UIqXGgJYAPdN18HRoU?= =?us-ascii?Q?X5dVhAhP3pVK+SRnlR0TpT+JiG/kD+qBO8/es+SMz45YSFR/BCfd2YezzWjv?= =?us-ascii?Q?YNDnrfGfDmozsQw99pNPzyXa41XXQVoJVQvhgQi1gvgTONjnhF5pDQ+8VQZZ?= =?us-ascii?Q?NdtWBPAWx8WrUXOq43KabT+QXRh+ety/UJHfqYGHzyqkxVXiXkKKdjALq2W0?= =?us-ascii?Q?LdpCMVy1PYVu+LA6Nbnf06Hv5bf+BMh8kv3kb+KcZo9+Km/QSM9eBtciyeSV?= =?us-ascii?Q?sovTxrFMBEVKik7DtRFJFLZ2v/psY/l+6vMTo7gxtEZTeNQ1+/8tu1labZsV?= =?us-ascii?Q?qkE8vA83mNuZ6bkOtyzigjrI5zCKOMf3fKK3/ejDb2NATJ0rgBkiT+nninkI?= =?us-ascii?Q?J2IKj0rN6OOYuVbGm9702nxEQjIJF0RoVyPNgCLVtYwzL/zDjk5qXZKXsjTS?= =?us-ascii?Q?w+l4ZkjRg9GKqvHEUxiRmEi0tykeqy/midIwdRbxonZXakA2PilOmkPiQzxk?= =?us-ascii?Q?NdJhu9wQZ2CillkMuzczsRgTQ081dYDDKGh8h9f8k3peHKRg46vyvTE5vqcS?= =?us-ascii?Q?iQcdofZ9/LUN1pL4JvjXefeXeAlXoVurziCfY7JO7E7XF41oRskO1XNnw1q6?= =?us-ascii?Q?uTg7Pg30bi76uL8hx7I/O8ilVB3a6BhnVvxERuYa8Yq6rRWHbjzntwWCFm5a?= =?us-ascii?Q?nQwymiRZBZrjHm4zEHRnXBJBlQCHmIHLIXrM9BaKD+mDz3oikVP9lajj5S4F?= =?us-ascii?Q?lqRRTN59VqxCB7i5Y53buYlXli+2fXWPRfw8CJ1J7wjH1xm8r1zvADxpB+JS?= =?us-ascii?Q?vrBrhPPVjyhGgAxfSYK3Kmjh05OUlRUzbz3/oOgn/80Ic8XLB44JYckdayHr?= =?us-ascii?Q?q97iU0vBCuAIMpS8iBAJkbGLBXRUUZTC26i7/JdJL0dqtoD7iorf5XOGQrmY?= =?us-ascii?Q?7XaYNqKNHfZqeo2K2niwZZaePD+V7zXEjwbFKcE8J6RHM6N75wh5FXLyUVw2?= =?us-ascii?Q?dJwnbfYIWjZOf4VZbDyYNxAMcKyiIt7ZWOA79uMgrn2nsyktu/ttu/NCZPDw?= =?us-ascii?Q?UsGg0//eV8Lpi5+2fUY=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2025 07:44:13.7905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52bdc501-da46-4db8-1d9c-08de1dd17270 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9340 Content-Type: text/plain; charset="utf-8" amd_pstate_change_mode_without_dvr_change() calls cppc_set_auto_sel() for all the present CPUs. However, this callpath eventually calls cppc_set_reg_val() which accesses the per-cpu cpc_desc_ptr object. This object is initialized only for online CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). Hence, restrict calling cppc_set_auto_sel() to only the online CPUs. Fixes: 3ca7bc818d8c ("cpufreq: amd-pstate: Add guided mode control support = via sysfs") Suggested-by: "Mario Limonciello (AMD) (kernel.org)" Signed-off-by: Gautham R. Shenoy --- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index b44f0f7a5ba1..602e4fa81d6c 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1282,7 +1282,7 @@ static int amd_pstate_change_mode_without_dvr_change(= int mode) if (cpu_feature_enabled(X86_FEATURE_CPPC) || cppc_state =3D=3D AMD_PSTATE= _ACTIVE) return 0; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { cppc_set_auto_sel(cpu, (cppc_state =3D=3D AMD_PSTATE_PASSIVE) ? 0 : 1); } =20 --=20 2.34.1