From nobody Tue Feb 10 18:44:04 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04842DF146 for ; Fri, 7 Nov 2025 16:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762531735; cv=none; b=GEHKGeYr7g5PlDAVGGEiUMRuAmtINz4pnlfLbVVPRqKT/LWD6ocYL4SApSBJgs1GldKL60FX5rnWjibfM3nyjsMnnTilpqk+wzTJk3TSybjlN5to9UiMpTkUaymiX+KfJXFCdxkY2lOdIA8nlYxYwXLDV0RUGwY3VrZq6PJqtKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762531735; c=relaxed/simple; bh=wCfL/0TbR2D1La8wfkO0vzsLgEQ1Zd5Y2m8FV9wi1Gg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pWKv7NBbaN3KZg/L9AE/2toDI4BnOpEHlH9Dj7Xzs4ntYi3GM/FAlNm9R8VyXTvP7fi+yQ6x2O6jQsZL203uSTpmgJCUSoYtgTOlGzLM5gwPdwloanpYzngQxq9ccSgGT/+rqDTsOvowXPEZCfiMGCBdjgbJTz3Gd+GLNgLdryg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=1HEvjRq0; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="1HEvjRq0" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-64088c6b309so1576115a12.0 for ; Fri, 07 Nov 2025 08:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1762531731; x=1763136531; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JYr/pky6aWVI2M5rA4U5Jbo/T6qeLZWOHBZOpvd4WCo=; b=1HEvjRq07orEtdKMLrF/T1DERJoBqusNCgxa9cVyRFQOQPrXX1q0UEoTRPc3SbdAHt biMnqwcsIZjXtaMKrb50II95uGXdcFSGgKlMUL7xizvYKBxpaGBtmis6DKlnEQC/7z6Z N56YlbxILEhT1M55DItd3eHGOF5WnBB2t5rPqt2nW1QWrJaLN9kNUhjBa7wuVuJTqQ34 GYBHZSx7k+momuoIUEVgY5SxlreW3yclJpzwDgR6lWlHCaP6+3oYZPkLvM6kfqjcn5e1 uYyJQkQ47BFasAelH4H2O492RGsEPSLt9gYHjCIVa1kBtVudPL5TfgDdvCrtM4pXxxQA jrrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762531731; x=1763136531; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JYr/pky6aWVI2M5rA4U5Jbo/T6qeLZWOHBZOpvd4WCo=; b=Z2iNe71hwwRis/OP/jBwiu68XP76yP5gI79rOvi7VLVJ6a2pcY9+Uy3Osm8GvMXWx9 BzSevDH1OLwuSsip1ELvXjYssayckgnZNG+76lMK/zWPezhWypvFJ8QAagtY2nKN98Iu RAKUa/3v6/lCsDBZtg7kZ5Lev0EnY8CbP4rI5hFtiRPt3dXC9W762iT/h/XvW598RmEa WaNNpcdztx2U2mi3h0ON9URXiFsA+JfWPMIHOmebQ6YM6/UZnTCt6Q+tmie1AILVYGo5 s/Sc8s7+nKz5vi2BzjYdzT4mwtxz4jRTHgJtnyQLxnKZ4U5IZbpiC7oVQbgWiEon1jhH DFpw== X-Forwarded-Encrypted: i=1; AJvYcCUb3SqXDTkinDEG4CdmnXt0+vIuCNiyl/xBUihZm0scCLk/BG7KebWad5lCJZD3rAZJNmnVhDg+N/4WSYs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+GHo/sTEbpeC4WkdZC9iuKCYR77JRcazVBGyQO5m1Nry4acXa C2sSubWj2ThWRYgC6waXlJJUMkJhvAF6EBaxHbTEJQDINI71C4d/gm5IIPzX2/J8S360r+FM7s0 qMhWip3A= X-Gm-Gg: ASbGncuyJ/4UYZA7Srcj6iaQLrizZlVrsJobeWolaqeEtVEz9M0k51jck8YvdURsXc7 cHrpCMoKfwWmJqeXJdR8rEFJ4YS74LtT4rkMIsN9bnxdl+YcdrrOLYx8M7NNM5K4tt42lNmzgAu GwV7cf2NcQn0sQjtAc/hFJ7aNE/AnXsN205dx82COAtsWAv5ZtxoiMs2sh3MhPaufSmRVCvUYz1 KY0/FKNguMkRNXX0xPbF1uRMSNh0QMBECzzPJINxvxECsRV7mPgn6laqpA4vXT/RVy8vFZjJMeI AwhWDvZrxDGFkJAGrPF7jwNWgb2KU5dJvrwBfvkRKeQRGgImSeY6szthcOKuxGnE5cwLndkYVZo 2vT8NL+s04//AewTOd8x8uwBOHJ1WXs/sDJ8hs9mExvhV5HzOGuUFTngf+LurEEu+gd/vqxNLyP OX94xGJfir6JPwgCNwpo/stKz5VxJiXgwCuMmsAibV0a8KQD+ysJX53m1Y+Ep1WvseRA== X-Google-Smtp-Source: AGHT+IEpbRanFI/ly4pOhSKtJJYggLoWCyVGHF5JexpXtBfMcrU0Svhu9ZaKyv7MJNW8LAKNg2Ua6A== X-Received: by 2002:a05:6402:4406:b0:639:d9f4:165e with SMTP id 4fb4d7f45d1cf-6413f0a08c2mr3306548a12.29.1762531731003; Fri, 07 Nov 2025 08:08:51 -0800 (PST) Received: from [172.16.220.100] (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6411f713959sm4444376a12.5.2025.11.07.08.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 08:08:50 -0800 (PST) From: Luca Weiss Date: Fri, 07 Nov 2025 17:08:47 +0100 Subject: [PATCH 1/5] dt-bindings: interconnect: qcom,sm6350-rpmh: Add clocks for QoS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251107-sm6350-icc-qos-v1-1-8275e5fc3f61@fairphone.com> References: <20251107-sm6350-icc-qos-v1-0-8275e5fc3f61@fairphone.com> In-Reply-To: <20251107-sm6350-icc-qos-v1-0-8275e5fc3f61@fairphone.com> To: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762531729; l=3518; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=wCfL/0TbR2D1La8wfkO0vzsLgEQ1Zd5Y2m8FV9wi1Gg=; b=XFhe9WKdgQrhgwCeP/Zu9aHiY8hnx5TxEMqejAH60sY7NNNSJ7zYWpPjHr9tJL6L5Vxd/IUll 0+5xg/BwfpFCCSx7nx2Yh4b+QYUkjuUBCgHp1iuRuFkX3leuHhJRZFG X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Add the clocks for some interconnects to the bindings that are required to set up the QoS correctly. Update one of the examples to aggre2_noc to have an example with clocks. Also while we're at it, remove #interconnect-cells: true as that's already provided from qcom,rpmh-common.yaml. Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski --- .../bindings/interconnect/qcom,sm6350-rpmh.yaml | 65 ++++++++++++++++++= ---- 1 file changed, 54 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpm= h.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.ya= ml index 49eb156b08e0..2dc16e4293a9 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml @@ -12,9 +12,6 @@ maintainers: description: Qualcomm RPMh-based interconnect provider on SM6350. =20 -allOf: - - $ref: qcom,rpmh-common.yaml# - properties: compatible: enum: @@ -30,7 +27,9 @@ properties: reg: maxItems: 1 =20 - '#interconnect-cells': true + clocks: + minItems: 1 + maxItems: 2 =20 patternProperties: '^interconnect-[a-z0-9\-]+$': @@ -46,8 +45,6 @@ patternProperties: - qcom,sm6350-clk-virt - qcom,sm6350-compute-noc =20 - '#interconnect-cells': true - required: - compatible =20 @@ -57,10 +54,54 @@ required: - compatible - reg =20 +allOf: + - $ref: qcom,rpmh-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre1-noc + then: + properties: + clocks: + items: + - description: aggre UFS PHY AXI clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre2-noc + then: + properties: + clocks: + items: + - description: aggre USB3 PRIM AXI clock + - description: RPMH CC IPA clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm6350-aggre1-noc + - qcom,sm6350-aggre2-noc + then: + required: + - clocks + else: + properties: + clocks: false + unevaluatedProperties: false =20 examples: - | + #include + #include + config_noc: interconnect@1500000 { compatible =3D "qcom,sm6350-config-noc"; reg =3D <0x01500000 0x28000>; @@ -68,14 +109,16 @@ examples: qcom,bcm-voters =3D <&apps_bcm_voter>; }; =20 - system_noc: interconnect@1620000 { - compatible =3D "qcom,sm6350-system-noc"; - reg =3D <0x01620000 0x17080>; + aggre2_noc: interconnect@1700000 { + compatible =3D "qcom,sm6350-aggre2-noc"; + reg =3D <0x01700000 0x1f880>; #interconnect-cells =3D <2>; qcom,bcm-voters =3D <&apps_bcm_voter>; + clocks =3D <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>, + <&rpmhcc RPMH_IPA_CLK>; =20 - clk_virt: interconnect-clk-virt { - compatible =3D "qcom,sm6350-clk-virt"; + compute_noc: interconnect-compute-noc { + compatible =3D "qcom,sm6350-compute-noc"; #interconnect-cells =3D <2>; qcom,bcm-voters =3D <&apps_bcm_voter>; }; --=20 2.51.2