From nobody Fri Dec 19 15:48:07 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8D2295516; Thu, 6 Nov 2025 07:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762415484; cv=none; b=Q4oPp1pxTlxLzkbdjmAJItu2kXyDq+8INg0snVuNiV4H2i2N6tEpBu1s5VfiicA1Mi2RmEpUrfe/bYy7j+TpZ3V6tnCBoTb1Nmo48NJJdkpMj0FSoBxs+FN49ctgu9tswOwFJmh3Pk4EYe9FpNsmEgSa33TZ8joYrOi4USFfL7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762415484; c=relaxed/simple; bh=KvESVpECG/hSqZs6a/6LvTTpH8QiSRhu2VyyX90vh/M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KAY6a43gkMzMCGEAi3KveEpO+IEgX9z7X3p/Et1JI6jNNDMxI1ncS+zaRnDgqXobwSMcwV6yr3let7li7ajAZOmVXxjQiEAyjfFdPe0+70GJbn8394/QKYv41wyRDLyDTL43w9++ADvZLiLbxeeB80H+v4Hw7fC51HN3UHMspnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowACnDmlnUwxp5jinAQ--.2074S2; Thu, 06 Nov 2025 15:51:05 +0800 (CST) From: Haotian Zhang To: srinivas.kandagatla@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] ASoC: codecs: va-macro: fix resource leak in probe error path Date: Thu, 6 Nov 2025 15:50:54 +0800 Message-ID: <20251106075055.555-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowACnDmlnUwxp5jinAQ--.2074S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFW5Xr4ruF4fGFyDKrW7Arb_yoWDZrb_C3 95Wr48ZFy8WF9xK3yktr48A39avrnxCrW5GF42y393GFyUJr13ZF4UCrn8urW5Wwsaka45 WF1DXrW8AFyavjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbsxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r1q 6r43MxkIecxEwVAFwVW8CwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x0JUfrcfUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCQ4SA2kMGc3mDAAAsN Content-Type: text/plain; charset="utf-8" In the commit referenced by the Fixes tag, clk_hw_get_clk() was added in va_macro_probe() to get the fsgen clock, but forgot to add the corresponding clk_put() in va_macro_remove(). This leads to a clock reference leak when the driver is unloaded. Add clk_put() call in va_macro_remove() to properly release the clock reference obtained in probe. Fixes: 30097967e056 ("ASoC: codecs: va-macro: use fsgen as clock") Signed-off-by: Haotian Zhang --- sound/soc/codecs/lpass-va-macro.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-= macro.c index a49551f3fb29..440d0f54aa33 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1663,6 +1663,7 @@ static void va_macro_remove(struct platform_device *p= dev) { struct va_macro *va =3D dev_get_drvdata(&pdev->dev); =20 + clk_put(va->fsgen); if (va->has_npl_clk) clk_disable_unprepare(va->npl); =20 --=20 2.50.1.windows.1