From nobody Mon Feb 9 02:12:47 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E171D237180 for ; Wed, 5 Nov 2025 16:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762358611; cv=none; b=Be3PMUpnLBuL9bOxDocj8aUpMh0bYzQeXZH05n/wXJwZ1OxGcpE3+lrT9sBPuWOrepDHJUqazZh2Q9YKWsTrx3n+3oQdJDyLhT/T8TY+StPYdTXlvN4fBXawMgBztt1yFYsooidGrfs58ZowlfxYwg7LsKaO7gaHgejREARGCP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762358611; c=relaxed/simple; bh=l0Nk7GVBJ1qI7KNylnbSMpoEa3nN+cyLJ8/L2EcFb0c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=T86uURcf+A6knIWbBA4SiwTtLBQUmrX5cE1O4W15jIfzjzfhPran9a1isXoAhrDnDf9IKrKNTPuZAdxQXNOANVm2lbzQWhX8CZbKozdy1eYgE3C/5RHQOfQ+hYjeNWbZaTNBj4xUJYpSlaxnM3nOzgBroeC1gMxUwtOhdc78mgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bx7IIG4j; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bx7IIG4j" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7a9c64dfa8aso20125b3a.3 for ; Wed, 05 Nov 2025 08:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762358609; x=1762963409; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=yQYfiOpDWl0sTNTx1hCAEQfYbuDMN8nzIM3Ra+ul0vg=; b=Bx7IIG4j/E4yaZYGmuQ5xX/zbhEK/nWPnOv6VfWQd/m2ip7V6gpd5RUWdyB+eiOjpg GfT27+qFz+2gi0Pb5DZ3JkM3eqP9oedgT+VidU9IR1cZ4gjQR2aMg7Dod67uUFcMJ8kc OuO84d/Dibq++txeq1/bJxxszUrN48toUVP8KLKhN2fN3o9RVkPVoFZezoP7RgTgooOf McVrtJmDHBbXZIdicwUjEb8EdkxETLR7zNsW32V58yH2HxIrhXcdo6qNQ4ltsRiIqPTy Gs1XV01pck8BOt4F0/ZLgYCk9o0C3N9+O6ja1qXXgbLGqFz0svDeckz2Tlt+fgM7pLhK lJDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762358609; x=1762963409; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yQYfiOpDWl0sTNTx1hCAEQfYbuDMN8nzIM3Ra+ul0vg=; b=dGBEmXakM6o5MJFvr4X5El+L3JF18zetQmJ28ABotISz+FvInTic/REEGQiSjxX0AS eC9VRYk2PDN47V0VK8nDOszYHWneO384bd48F2QvvNp4M/Fr3+3vERtSWuZNtt/5AiBH ROWSTvOlNYD4RqR9/LOrnUTCnVakfu8rfLVoO5HWi+66aNEye31esCB7P2LHWq1E3a4V emNy9a5tNkXI0JgENkbodgWPJStgwdbNRO4rBQ/3xR6kn+IX2VOiSWgOKwuPq+EDl0ib w3KDe0PEHHQ6Fg/NMzNhQDmquP+9RZp/D+M7+dHYaxFdaJJiA7F1FMKKO0ZdS/3wABoy 1Hpg== X-Forwarded-Encrypted: i=1; AJvYcCXN883/EwDep0kSJOiTmCb4RlcV/62W9VzCp6dyTjBBb1CwIpCQCHm/W9oojOQTACo2U26piGNaClRkrxw=@vger.kernel.org X-Gm-Message-State: AOJu0YwsKoSvyO69VNKSdl87U8sQf4KRcbFnhE6YwCOhEkk/sOE5eg/R PX62LAAx1kLw7nUIOmhQ7b4TxhmwqvWF2LmZun1wSE4n3QK6Ao5HNupY X-Gm-Gg: ASbGncuzOxZj1ID8OdwfojwRZLO5fC8LUqZpE9wkrSrA1IIE1HUzSerttrd23T3EuOA 53thps262GC0lUpGclc9KwbHPA62dE5uvLjaLGlh6ypDcFGQEZhzQdh2tPdBaK84aCb+8XbkxBB k/0QkiX/ZjmuM1tWmt24W0+3bSwQUrinRnRt8sapzKeNThY0bvk5Hu8Z8ceIpyFfyBue/WOtE6O wc+lxLkKobkejeKJa96YMdwxEXwr5bJLeVEeBi8yvHlGkWgY1YSJnjuBujrhZ81aB7REo5pafb7 oDCggGT8FUpCsO0hegBTLg/IvaP4jrj4HX79SxSLmLuUgq6bnUBAjFD3zROZsVonaRZlqXAhyTk X2vRrc4uZBiAElgPpXTtz/k1LfYp9bxCOyBH8t6AoObKpYF24kXTA+T03WGKgnIC+lGveIqS35U XLlcJKv464VZg= X-Google-Smtp-Source: AGHT+IHJwjnUIGI8gDNaxibj4sXg44XjKfIRuSM7Iw8kysNt9Y+apm7udBv6IooCou81dlnb75b3uA== X-Received: by 2002:a05:6a00:a03:b0:7ab:2fd6:5d42 with SMTP id d2e1a72fcca58-7ae1ed9f9femr4377537b3a.16.1762358608506; Wed, 05 Nov 2025 08:03:28 -0800 (PST) Received: from [192.168.72.66] ([240e:441:9718:7c7:b13e:ed12:9e56:bf18]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7acd6823f78sm6638331b3a.63.2025.11.05.08.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 08:03:28 -0800 (PST) From: Goko Mell Date: Thu, 06 Nov 2025 00:03:16 +0800 Subject: [PATCH] ASoC: spacemit: fix incorrect error check for sspa clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-spacemit-i2s-fix-v1-1-ee2cedcdda23@gmail.com> X-B4-Tracking: v=1; b=H4sIAEN1C2kC/x2MywqAIBAAf0X23IJaBvUr0cF0qz30wI0Iwn9PO s7AzAtCiUmgVy8kuln42AuYSkFY/b4QciwMVltnjHYopw+08YVsBWd+kNo6ts75qWsClOxMVPS /HMacPytboKhiAAAA X-Change-ID: 20251105-spacemit-i2s-fix-e63d655ab94c To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Yixun Lan Cc: linux-sound@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Goko Mell X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762358601; l=1364; i=goku.sonxin626@gmail.com; s=20250522; h=from:subject:message-id; bh=l0Nk7GVBJ1qI7KNylnbSMpoEa3nN+cyLJ8/L2EcFb0c=; b=XpqASyQW0RdHbCLkEf2XfIsntbTBZK8hH71TYZgySwP0P0jIrF2a24Krhc5ELR/kzKnFBR+nV WhQD04oBe62Dg+xi0OVCFhFRVVymT8BGqaaQW3Tdd9/O3KDLSgKAMh1 X-Developer-Key: i=goku.sonxin626@gmail.com; a=ed25519; pk=YAEtp1QQ+5hMv+clz+l2GN5MRRfR5AvnzZi99Qxamqc= Fix a wrong IS_ERR() check in spacemit_i2s_probe() where `clk` was used instead of `i2s->sspa_clk`. Signed-off-by: Goko Mell --- This patch fixes a wrong IS_ERR() check in spacemit_i2s_probe() where `clk` was used instead of the correct `i2s->sspa_clk`. --- sound/soc/spacemit/k1_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/spacemit/k1_i2s.c b/sound/soc/spacemit/k1_i2s.c index 8af05e1604f518b63cbbbaa66b73cfee8262d87f..1cb99f1abc7cde3370ca643c8b9= 55132d8a1013a 100644 --- a/sound/soc/spacemit/k1_i2s.c +++ b/sound/soc/spacemit/k1_i2s.c @@ -414,8 +414,9 @@ static int spacemit_i2s_probe(struct platform_device *p= dev) return dev_err_probe(i2s->dev, PTR_ERR(clk), "failed to enable sspa_bus = clock\n"); =20 i2s->sspa_clk =3D devm_clk_get_enabled(i2s->dev, "sspa"); - if (IS_ERR(clk)) - return dev_err_probe(i2s->dev, PTR_ERR(clk), "failed to enable sspa cloc= k\n"); + if (IS_ERR(i2s->sspa_clk)) + return dev_err_probe(i2s->dev, PTR_ERR(i2s->sspa_clk), + "failed to enable sspa clock\n"); =20 i2s->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(i2s->base)) --- base-commit: 84d39fb9d529f27d2f3d295430d1be0abdae7a6d change-id: 20251105-spacemit-i2s-fix-e63d655ab94c Best regards, --=20 Goko Mell