From nobody Fri Dec 19 14:22:51 2025 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011032.outbound.protection.outlook.com [52.101.70.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00012C11F7; Thu, 6 Nov 2025 03:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399859; cv=fail; b=qz0CXNUUDi54TW+WWzir+5nRvzHEUowNUE3SX7x2DV1wkeY2ld9NQQeLBnSFLT816jF7avZ66a3J5tzsRS+sNwW0y1OXaeEHtubOeJJ05/zsVoahjg9lV03RJk/cFDqHPPvizzmBSacRvcfKhqIsMlGm4aVlYM25eAMA42TU3rM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399859; c=relaxed/simple; bh=iAxfBlROukCera/YGBM9lkYOks+v8vyZ98+1X+VVr3U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mAQyncH1W2QsxsfDzrHGmYwn4CjsANmxK7V9g4M5Ou8lWKRfXN1VIMhJFaHgl1djrSmHQKLCBeOTH7kD0mxjP0bstI2wsNOmsJk0bRHOLu76kCLsUGASO8tqhTJbVsuy+0cEvruoshp7dCymD2HhdARUt4LNP3CjhRtLvCkn7Fk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=l91U4l1U; arc=fail smtp.client-ip=52.101.70.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="l91U4l1U" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JnQD2SVvrwbN86kkMhU6MmKWj6HUsSS6G+a86PWc2svHOK2Kx9HjcMZreKKMViqj+QK7h0bKHy3zTtLO5Nxltuner2xOva1lhX7v1SSDt1BCy34IZY6qPeIw5Kay7+1UY2q8BNoFSm04KDkmqHwvcXcce58GQ4Nmaci99U2j2svPGuYbQEmelpU5TxRvaj7sgzIx1OQpRw2Waqyjzz1pKi5lPdgqOLGivd1VM6/TKzf9x4VycCdUjwF670oTHkt7h9TGJ7j+Ug7qMXHewBa5d+qpGBgIRQ8XOojFPG51AAmXW5E34ETfeMKWyDVteixgk01ROLWelhyzyFoGtLkgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Y/MWVZL3k204caJ5kOWWewlvej/OoWjsAtFTfviSm4=; b=DsrRZRHfhSkL9eZ4pG3QWzL6jjTUJFqGORMfIs7BbuvKlTM5uI9SxBZf8Ezu4f5+Vco8MfTkWqLooR1kjhbO8zdlhAjX4R8wCnZBavAcbl4+YfiiMXIWULf8O2GPf+d8758WiWGcHAW7PpknwPkdR8LLQ5+t83GpjtUpBQCduRd4PSY1abHun1/nvN47oGklgP4OSW3iw2VIC6yJYQYUfeT0IaDH3jqFl57eRQDn76FtaAZ3ftibr+m4+2GNaVJXuHjXnI0kZVdT2LM9x9yzyyjjPORoGN0bf7q0nu8OrTmnXpNwo8hIH4t6sJUg+6UfnvO62lKBnhw2qB3s7srgtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Y/MWVZL3k204caJ5kOWWewlvej/OoWjsAtFTfviSm4=; b=l91U4l1Uf3YgNyksaIdkY3JY0/UeKFnqk1ox/mwNWbqtwOTMYmFTC3nwHiuwMtJu55TCKI/RjTupprmaVHbuNxKEmhVUWmLZc943mB+E8mGo2DvfygKTrjmSEoMfdOGCOWnZ4nMtpyg9PYtbEGXeGp2HNnQkOZXmqdhuvfTuVFdGwTHeV3MIecGlOYN/cfbQNyKF47n9wVvFt7WUrmxHmnubcR/uALd1aUj5YAh+jrsFP48yHd2n8nFvLhErw7rBge2bGbmiY3lnyLbLw8VTemD2hQGdBtublwL7uRETytc1unwoSOPYWjhuj2hTcSwLxRJGSy1G425koF+OFoqNYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.8; Thu, 6 Nov 2025 03:30:55 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:30:55 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:27 +0800 Subject: [PATCH 01/11] remoteproc: imx_dsp_rproc: simplify power domain attach and error handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-1-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=2779; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=iAxfBlROukCera/YGBM9lkYOks+v8vyZ98+1X+VVr3U=; b=zNB+m3wVNdhWRVZdfr1Guh4xIHNSKq3JgOFLIKlf058jU7fobSm87PL2IxD4CV1dCMRb6+5wu +T2nciD9TuXBm9MletFoOglEwrK9daoP3iNU9cR1e/dTlffFVzb+NtO X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS1PR04MB9287:EE_ X-MS-Office365-Filtering-Correlation-Id: c5c584ce-1e00-4692-1469-08de1ce4e491 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|366016|376014|1800799024|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aDdCMzZZUDhOL25TM3VyRE1XVHA5UFlmYy80SmowcG5RbUl4Q1FNNUlxTFNL?= =?utf-8?B?UDBwbjF4aTVsOWVDdGtQRkR0S1lGRkpqRG83bHhTQThmRm9jd2dpNzZrMytp?= =?utf-8?B?SzlKYndQb2U4RkVqZHNYZHFSWHRaQVRPKzFZeFlsOFp0anlqQ2RsenM3UHFx?= =?utf-8?B?UFkybW5FMWkxTGIrbTBQb2pjdGx5VldyWFlISzg4SS9hemNCcU84dEZQVGFz?= =?utf-8?B?b0FyQ1M2OHNKYkhUeG03ODcxSXlvbjh1R01zeUROZGlrblNhRmFtSm1CVFpI?= =?utf-8?B?WDcwMkxkbHY4ZG5JeUVSTTFhemxrcDFlZUx4Rno0RGdmaHhUQ1pOZGlZZW1l?= =?utf-8?B?TmRHT0dVQk5QcHZhQ1RpNTdWZDkwSGwwU1d1dlJFTFUxcnhLUlcvOXNGWVl2?= =?utf-8?B?dVFOWld1TDVyNklQTENpMmVEaE5lUktzSWdtbkxJMGZRVTlXc0hETG1ETjFM?= =?utf-8?B?alhoSnhCajNlcktZTHY3MnpieFc2ZDhMNTJDWThERGE5VUtoZncycFY5TUhx?= =?utf-8?B?QVEzeE5kTlJENFVkM3RaYThDYTFxdmRyKy8yRlhZT1orTUt0TktvcktOb3Uw?= =?utf-8?B?ZzZLcm0rRk9wY0J5YmwvZGEwblRaUXlHNk15Q1dWUzg2Vjd1WXhrQVFTZFZ0?= =?utf-8?B?Qno0UWRVTmpkK2JWRHhSZEd5Z3pDWUN5NklVVWd4SHZmR0lXZWVEbVlUNjVN?= =?utf-8?B?NXZvajIrUkx3c2kwQjJDZ3VqeEpQOVB6VWFIMExqbzNaNGFEYk9RMFU3U0FX?= =?utf-8?B?ZlE1dnNIZzFETU5CaDdCVHlkYWc0UzNkZlBkVlNXVnlBb1BlbEtOcXVDeldQ?= =?utf-8?B?eldqaWhLa2UzZnVUcnlxVVJqVlUzQnFWSmpyTXppcGZMS3J0alhBQUFIcUVY?= =?utf-8?B?Z2wvQ0U5S1c5UVN6L2hlbnF3L3Z0dzhzSklHUG85eC8xd0J5emwzd3ZDWmxD?= =?utf-8?B?SXZGR2h2Nm5GaFVQY3VIdmg3OXZ2M05RbTRFVzd5RFBQZUtXOXl6TlJQTVEx?= =?utf-8?B?dktvWWhwYUhoc2d3ak9zaWViSmRYSE5VKy9CaDFxYk5NV3pQemh3Z1ArV1h2?= =?utf-8?B?bFpEdU8xeHJndFhRSENUOXVYS1ljMHp1Z0NhampMMExRbGJRbllJS3FoWHZ6?= =?utf-8?B?THp2NitYV2lCSXBMTDlXSElYeUpRTE03eERNNW0zSUJMVnYrUC9qUGQ4M2R6?= =?utf-8?B?Qkl5SVhMcWFtWEI3OVN6YmV3TEhlT3FRNTFjWnU4K3ExSm9naHBoTDRwWTMw?= =?utf-8?B?ZzBDOHluWHZ2RWQwNFpUUVQvRmUyeWdVWlY2OFdqYjUxVis0SkRsWXI0NW9r?= =?utf-8?B?a3Z0clpuVm5yUUQ0TUEzTnlnbEpkZE9hbG05dUdpYkh3M1pPQXNMZlM2bmxP?= =?utf-8?B?cGRoTktQSXFIVmUrcm9jdVUxSy9idGFNUlZUbFJpc0VRb0lZM3duNnNSK0w4?= =?utf-8?B?cEZGK1NkY1RnOVBZSmZuQWpoMHdIRlZPRjBIbGlISTRTZC8yaHJ5eGFHQjRC?= =?utf-8?B?Wlppd2ppYlRhTlJDSWUzcjEvMm1iWDdCak5YdUFJalpGMmhlYk9ETDVoUmkx?= =?utf-8?B?NFdpYktKRXhhY1c5QnBtdjB4YlpKMFc1TkFTVDUwbmt6ejFqRnJHY2l2Tm5H?= =?utf-8?B?L3VQRFNpU24wNDR4a1Rwdjg2VjRYZ2ZCMi9IVHpHemlidjZpbVdpNm9oU1Fw?= =?utf-8?B?czdXblgrT0NWczU2Y3hhSzRaV1plQ0dHY1RXZXRjY2tVR2JpV2pmY3FHSEhi?= =?utf-8?B?V0UzRkc2VWZIczkrZWlIbUtTNDU2aXlSNlNtVGtkZmxOMWRIMGZlek9Qclg0?= =?utf-8?B?L0x1elBxajQreklhWktNNkI3MWk0RnFJa29YT3BlRkQzbGppUzUxTVJ0V0pj?= =?utf-8?B?R1p6UGgwSXdES2JWQjJia3FRaDloRjRMbnIwMHNobGovTjNPOFdvUUkyWmpH?= =?utf-8?B?SnpiUE5HT3ZFRDBMQjNaUTRseU1IV2xXV0NOOG5IaUlXNkE4L0dGNFhLT1M2?= =?utf-8?B?YlhaL0RGb0RLSHdDV0pvS0lCZ0hwUTYwSjM2dng4d3BVdXhDeW9vZzdiWWNU?= =?utf-8?B?RlZwYkhOR01ncHhaSWJsemszYytwbmVKSkdmUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(366016)(376014)(1800799024)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkJndWZNLzVCeHBqbkRHQm1VNDRZQmJ2cmduOEowZks0MGJ5WGlJeWpmMTZI?= =?utf-8?B?b0F2RC9JaWtBVGgzKy84bnkydTV6U2ErV1FOYjJGZ3ljVGZFcTI0ZDZWa09V?= =?utf-8?B?ODMrZ2I2dmJuQlc2bTFlM1BtUHNOTXBZRHM2c3F5OHg4RjJEVk13aXdUcFpC?= =?utf-8?B?OTBZQ05rS3RnNVRUREpoK3BBYW1NVXUxUEROVmU0dVluMTlZYzRYRUYyQkhn?= =?utf-8?B?V01zY3BGOG11OTI4Uy9qanJJcmpsZTNZM3dydjFLOHpqTldmSzlNZVhvMGtt?= =?utf-8?B?WTRMdk1RbEo1ZGlWUDNRUXJwRW5zSndmUHppUExkazhKYk9veTdQYkpTcWhS?= =?utf-8?B?VUJHZTE2S3VXdFg2YzhqdElkZXhZTDNrc3AyNkdCcnRNZ1ZLWlE0WDBPaUp0?= =?utf-8?B?cWJ4SXRwLzVSRGRXWDZiQW5rcTRkRXpXYjZvUkdCSUxibUpoVTJnbmZrZE9B?= =?utf-8?B?QVhGK0xXTXFTYkdvWm1oY1N5UEhvaldnMGw2N1hpU251b29GSHZNWG9UNHkr?= =?utf-8?B?UU10SVRrZHJXaEowQWppVWkxRlNJb1J2N2laTkdvYXhhbUY3alFhY2xQbDdT?= =?utf-8?B?S0VYM1hScGh4NmNmaE9ySFRDaE5ZZXFiMlYwVlNoQUlzVE1sQmY1dnk3Q2My?= =?utf-8?B?NkQ5bElUd3RNMzkzNTVXOUhmWG9qcjdYWHRRVFBWS0NiK3JiY3Y3cDl1ZFBm?= =?utf-8?B?anBwM2VjZm1tS3pOOVcrRkxjVGRqNVp5MTN1NjZaaWYwTTRJNHc1cWFnajVw?= =?utf-8?B?Wm4yM0tjSWVpL1NyUUgyTEZuR2NVd0k4OGFwN3RHQUNNWmlOQ3F6QVgvNmtH?= =?utf-8?B?akZDbFJuV2YyZlJiVXhKRHF2WkgvVndXQ2U2VFJZamhzRXI0YSt3S1ZPclc0?= =?utf-8?B?WVZpa1l2NWg5a1NxdkdtVXFUdVdvSmxWdkN5Q01DWnRHd0liU250Z3BXMkhG?= =?utf-8?B?T3lzdVA4RURZK2ZLWlB4UGZZVnI3ekZWQ0dYMTVUWGlTazBqeG1GTEdrMlF4?= =?utf-8?B?M1VZVEdCWVVSZFpwbjMzckluaVFCVzBSWTJNaU10eEoxMVVqSU9DdWpQdXVo?= =?utf-8?B?aEYwTlRUVFdvZmd1elNpbzMwZk0vemNSN2dGZUppNkZUME05UXN4a1FJSTNR?= =?utf-8?B?a0FpMlR3cGswSWMwWkRkRTAxakt6QldDMXlqQ09ZS0k1RTdMeTR1dTBLRzRi?= =?utf-8?B?MDlTcGNVZkV2V2didzZicXNBYkVaT1lrc3JTUXlhbjlEcjVpR0grK3VlbDFr?= =?utf-8?B?Vi92V1VLUmF3YU5MenQydUV6YWV1bjB2Sm8xRUY4cWpCdG1CVGxvLzZsQkdB?= =?utf-8?B?QSthbHdzaUc1UHlJNTVuSDhOZlZzN2tFUVd0cDZLRWlqU1dNcWIwNWYvY2xX?= =?utf-8?B?ZEFSdVY0dlUrQnJ5SG9nSU5UcHNsYXlIWVNXdVFoTVdxaXZiY1QrV3dXWm93?= =?utf-8?B?NVM0L25TaDJiZVpBYVEyWDRtakdTam9RY0M0eUxmNFg0MTZBMUU3eWo0ekMw?= =?utf-8?B?N1NSaS9oQ2RBVHFRM296Um4zRmdIQ3B6V0N1Y1Mzd3NPZzdvNVlhbmh6RDRl?= =?utf-8?B?Yk5YRGl0eWVSREwvMExBNlU4NE9Sa0tFNDIrUGtDSTViK1lmTGhwU2Y4eDFI?= =?utf-8?B?aDhPL1lRbVEweTNocnJyWVJxZVBpY29LUjlidk05Tkppb0RNZHdqdmJQS010?= =?utf-8?B?UFZxRVQxVXBCMEpEYXRPMzNYZnc1ZTVUNWltazgza3NEZjF4U3NoVnM4bDRV?= =?utf-8?B?Z2RZYXFNbWpPdzlaZEZ2Q3hDenhqSjJIZDdmVTdSVjlhZGVTcGhORTRmRlha?= =?utf-8?B?aUx0RXFyQnd1SEZBYXh6cmx5QUJmdU1TamZXaXFPVGxDQkZOMm9qMlpCMDhz?= =?utf-8?B?dlAwQklLcVd5b29xcC9RTkpuNzQyQ3hxdGI0djkvVzBpMXpqd0s5MWYxNXU1?= =?utf-8?B?UjBIR3kxekdOa3BOMnF1NlVsbmg0bW9Eb3M4UnNVMmYwK3U3U2Y2NkZsdHpw?= =?utf-8?B?VlRrTWVGdnVRdDlhVk53ZG9nV2NWMkdOblNSZ3Q2RXVmNzdPT2dvUDlZaDY5?= =?utf-8?B?SWJQb2dndHR6dFE0T0hXUHhUMjRMWVhjazFUOFhGWVBrSFA1SWpSMkY1Nnll?= =?utf-8?Q?JCq77gW9/cJIHcHUZ1M8LXK1K?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c584ce-1e00-4692-1469-08de1ce4e491 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:30:54.9633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 61Bu80WcoC2qNLBk7rIoZ7rA0Pc/4q5Wq+Gpt9HQapbQoNxnKfhUrf+BCQNCWiE4sPvffJYFAfofmEvs7EH9Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9287 Refactor imx_dsp_attach_pm_domains() to use devm_pm_domain_attach_list() directly, removing manual detach logic and simplifying resource management. Also replace verbose error handling in imx_dsp_rproc_probe() with dev_err_probe() for cleaner and more consistent error reporting. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 6e78a01755c7bdc28cd93f00fe6f74affc3d96b0..c466363debbebe8f91b908b3bff= aa32e9bf8b9a6 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1062,14 +1062,12 @@ static const struct rproc_ops imx_dsp_rproc_ops =3D= { static int imx_dsp_attach_pm_domains(struct imx_dsp_rproc *priv) { struct device *dev =3D priv->rproc->dev.parent; - int ret; =20 /* A single PM domain is already attached. */ if (dev->pm_domain) return 0; =20 - ret =3D dev_pm_domain_attach_list(dev, NULL, &priv->pd_list); - return ret < 0 ? ret : 0; + return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 /** @@ -1186,35 +1184,25 @@ static int imx_dsp_rproc_probe(struct platform_devi= ce *pdev) =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_attach_pm_domains\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed on imx_dsp_attach_pm_domains\n"); + /* Get clocks */ ret =3D imx_dsp_rproc_clk_get(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_clk_get\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_clk_get\n"); =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; ret =3D rproc_add(rproc); - if (ret) { - dev_err(dev, "rproc_add failed\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 pm_runtime_enable(dev); =20 return 0; - -err_detach_domains: - dev_pm_domain_detach_list(priv->pd_list); - - return ret; } =20 static void imx_dsp_rproc_remove(struct platform_device *pdev) @@ -1224,7 +1212,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) =20 pm_runtime_disable(&pdev->dev); rproc_del(rproc); - dev_pm_domain_detach_list(priv->pd_list); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011031.outbound.protection.outlook.com [40.107.130.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7F602D7DE8; Thu, 6 Nov 2025 03:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399864; cv=fail; b=aiFISfCbmqrA01xhD8jY3ZdVBHDSVTnV6Llb+V8KXJTPny40Hc5RrvteqboS62iqbbeueiBkc4VwWwEqSGZokTyOWrpQ1RztTR7a8Ia0EWLJJfA6LHklltKgRid/wNlWv1yTg+YZF/lfQLWgJANJSuBFD2bW2EYQolPlmP1eqXE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399864; c=relaxed/simple; bh=7bT/qKReJ8+5IC8OjjJeicEqFIHXrjl1U8G8/ppDtRI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ZBlYFukXFvRPry0vD/wG/NNfJqsnoUGl79VwyFMcOQItWwFybEtG8kzhYM+DzhdW5STjT6NdIk3JuaFXh/ypgZ/GkrgFph32im1t0fyWOFtrWw8fiiHhx+jyR5f/yOJ0kjjuPkmdMT0HSmnt30SnPljq14tGNNa5q/Mv+rzyZRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=QGo0lXho; arc=fail smtp.client-ip=40.107.130.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="QGo0lXho" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qIEmW/4hSYOZ6Vs2nScLyoa4aYNK0jkV4WIjY/qYzIqPMd+M8MFLWveT9Cflls0hXKTES+zf3tIVj7Iz1CrgTF6o1bZi3GaJc1U+/xJnzNaYMJ9qYwC7N49rflQ8XOFjG57UGw/+de9HgAPSCi3NID7uwXuJ+IZIdTJXeqC585tAuCeohw/J8mfU5IKeY2MYgg1KIBYnfUcOHeEST4wVTUUe8mQij956gvehoEji0Ha+nzynnVbHrLOkZbBRW5fggeYwmmM4SrI65FPV7evBZL485myYvISBTa5IX/ndp+qLM8p98xz9XQmVjJocbAcReg9MAc/mQsq+ZBTccTp7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3/aDG6F7xct298dmP1GLLktRHSLN4xNEFVtye0/WJY=; b=d/A7g/dFBEsi5OOWaF78w40pMmVnHaGpnjVDdaxiXANggZdPs31OOWiFe2huWdH3REfAFQQeo9epK+cQjYuxURGpq5G8H617O8ESsEGZATnCUfmGvUPe/hyNT9Wowk4wf+q14VlVyIza8g7/fAgkF/6p7SKqUpYwkEv+gJj/UR9pnH/UWLSMTyJzuDSryUXMxH1tZIYkmue8W6AfDi39K+Vvte6ppIb9Bo/UaGv4rzeQx/iA4te150NmWwUY7ETxOTMoxipe/0QxwRhaW8oV5rXxsMBlEUY3Z5rLhUJxH5X2YSplZUKur0woj4JDsQcetsC5v7w6z+OMZ0OFINoNVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3/aDG6F7xct298dmP1GLLktRHSLN4xNEFVtye0/WJY=; b=QGo0lXholdx8lCIX4p8sVgZ30pBDAbqr4ggWdl6hhYJwyCpg+6WCZCY1EpsJVZ5b/aItTcsMJMUeDiMSCHGWjITuMJ480+mg85E/o2YG2VAZ/LRIM6Ruyc5oJglFf5zEhsXTtEledKDziegsChoRkzI7hAB9SxJGQZCKwG+GaYJAEFbWY4/vnV75XZ7Ab5G5NtnTo4WpIhnjVTUl2P1w4rSu4slJluNX+5H2IWbWiBI6/S039HpnxYwuuLLA+mJPtBcNO/8S6kL9pbVkVb8EdaSWQhUM5zSZQMCHSTe7epIX9U0SUeGH/w469nceZNxKNBqMNHExr0xE/wS0CjIQaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by AS1PR04MB9287.eurprd04.prod.outlook.com (2603:10a6:20b:4dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.8; Thu, 6 Nov 2025 03:31:00 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:00 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:28 +0800 Subject: [PATCH 02/11] remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-2-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=1309; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7bT/qKReJ8+5IC8OjjJeicEqFIHXrjl1U8G8/ppDtRI=; b=Y/6ytkYKKJDnSAN3SNpEMoYLiVS0sY2LUpFh27F9vPj8iYsc9pJb839AGMj9r3d7BXhduUWwf zVngwb6gHo0DL/QlJHPBiDP6Q1EX0c69a7Tr7VUUzKDEBceLLFGZIZ/ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|AS1PR04MB9287:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a46c9f3-790b-4553-3e56-08de1ce4e7bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|366016|376014|1800799024|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RldsTEtlMXFkb0hvS09PemJWeXAzZWV3dkZEaXdoSzFvVmNmbTc2ZlBEZlhZ?= =?utf-8?B?WDE1VFVLeEJEY09UNnM0K2psNnJka1UybmtnVVFlQVNlNWZtU0NxT2s5THk2?= =?utf-8?B?aVV3Qm53emxIcmZkR1pUYUlBRFYxcXhiY1B0UU9MZXBLeitQQjJXY3F1SXVF?= =?utf-8?B?V3diNDhVSGZnSDlDZFRvaVpyd1lJbEl4QVQ5Zndlb0wrbE13RG4xSHl3d0lQ?= =?utf-8?B?Y3N6dzVuQmRDcm5hSU1qbFdNU3Z4U3pRRHlkYkJDOEJIaFBTZDJYTWJudkNI?= =?utf-8?B?OGtOdVkzOU8wNkw1c21hdUJnakx0MFY1bGg4dG00RVBTL0dTR05walVBRFo3?= =?utf-8?B?RmRJQXEvTWZ0V1NqWG9oUXVnQTd3Y1FoUzYxUmMxWmVJSzhHZFd6clpNeG10?= =?utf-8?B?eWJydm8xUVhyQWM0N3lSTDJrcHZvSjlzV0ZGUWFOZ1hwUHgvTVpXNDNnVE9i?= =?utf-8?B?eFhxNnZQUzRna0wrbWkvdzFyZk5BMXdzckw5MzJ3Mi9rR0RlUnRobnh1Z3BQ?= =?utf-8?B?bkpVOFJ5TDdqWGxTUVYzQWhZTmkzdFUxZXNlZGdBTXI0M3RSWlNwSkxXQ3po?= =?utf-8?B?UGJOS1NNSkxadkFTMlhUZUNiOHhOOVBjTW1keFJBYkRNZUZ6RS9VdmFaMk5X?= =?utf-8?B?em9XWFpnSS9aemVnN0NScWt3bU5sYkU2Rlg0cHJJaEJGbktPczA0M2g2OHJE?= =?utf-8?B?RThYaitzeWQxUnAyeDUxKzc2V1FMbXdhMXMxNGhFR1NWWkNYUFlNVVhwMDUv?= =?utf-8?B?akhYRjl0RjV2akVNZGZMcmNMKzAzbDlTYkEvM1dqZkpaQS9BR29rSEhMQjZY?= =?utf-8?B?TkhvdG5KVGx2SmhlcVlyb1RaWEk1ZC9xVStwbStLWkwxNXgwaGkvdExkVFFL?= =?utf-8?B?Wk15amxjbkhRbTJLa2RXQzVsZ0dHZWpQRnNab211N1ZEdjBTRURjbEJnaEJy?= =?utf-8?B?RlRwaUFoY3J4dzJSV3Bzczh2NE5HeFVrbmsvdmthYTEveWV4K2EvZERjc0Rs?= =?utf-8?B?UjBPR3lkbUZBMmZYOXFQeWkya3pxd0IxdVdnN2E2V2VLbTZVRTdiaDU4Mzdm?= =?utf-8?B?M216aUtWanRBaFJVY1ltb2gwR284aS9Xb0Q0akJtTEFUalJZVndDSC9jQ2RB?= =?utf-8?B?amhURDBNWFBHZUdEOGVqNnpGaDBlbDFQMW5jU1RtYkU3NDBKRHhYMEQ5QmZH?= =?utf-8?B?MGtxZFVzYUR1V0ZXby9TdGR4QkxUK0tFMVZrcXpkV21WZ1BkNzBtdnRoNDVi?= =?utf-8?B?ODU1b2pkTTN3Yk9QbzJZTmFTMjVISmRvcFN4VXdPbkhMOXovWnFNSVNrY2ZB?= =?utf-8?B?VU5tY000aGRYZG02dHg4UC9PTC9qaFlSTEdPNDNaaVVUa0ZnSVk1ZjljTmMr?= =?utf-8?B?Y2lPZXBVS0VRUTUwOWtpUFhBTy9VYkhwK0N6WjhZcmFscnpPOXlFcUJ5R2dF?= =?utf-8?B?NzJiVzJYSWhnVjQ1bDdvNHpxNG5YdDl2MHM2Vm16WE5ZWHZrYklpcTRtNHE0?= =?utf-8?B?NU1ONCt3Y0xaa00zWWJLTmo0MHlFNi8zRjAxS1R2eTBSTTRIbUxJeFh3bGxS?= =?utf-8?B?d0QvQkUzTS9RK1ROdFJNaTM0TU1tb3NyUFNta2lpbllBbEtDT2ZINitJMWRJ?= =?utf-8?B?dXdzNEdlTUlnYml0SjdKc2U5Mld4RHhDdXk2T2lVS0l1RFFwVUhDQTNJUk1Y?= =?utf-8?B?cGVGbTVsNkZXWngyaldnNVROZ01DdUpRV2NPb0h3bElHay9FNkJqb25SQU9i?= =?utf-8?B?aWZMaDkyeHhHeVhFY0FUekpXN2Y3Wm1OTSsyT1RWWHJaUzFibjYyYm1CWkxx?= =?utf-8?B?d2pjbmpSVEFWRStobGwyZVkvaUd4eUxENGU3UEZuWGJwcmZvWXJHY1NiaWFF?= =?utf-8?B?NDkvNm8yUmZBYTczSFhIOTJoV3dMU2hRWmZmVms3TnZLQlE5OUVGbnhlTStT?= =?utf-8?B?MkJiSHhJbXNRK1NYQkQ2TnRDNzhmbTEvY2thTGRsZklsME9uTzVyejhmeHUz?= =?utf-8?B?aEE1eklMcHZybU1GOFg0RmlZdCtRUHdKWStIQWVndVdnS3lDeEVFSmRSLzJV?= =?utf-8?B?VDdIem1ZVXlDRW9YKzBGV0UzUnczR3hJOWtnUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(366016)(376014)(1800799024)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGZHZStRRTZWQmxLdXRqTUVXYm5FWWJXR01wWDM4dVBKTm9nRFdHNHZKeTEw?= =?utf-8?B?c1hycXpBdVJOUjRTZ2VYdlFZV3Eva1B6ZWJTZDB6b0NqMzRJU2kxdEVrTE9r?= =?utf-8?B?S1NGeDJvZXcrL3BIVm9jS1dJSE9uUjNkOE85K1JGL2diREg2TU9hcmhQUFFQ?= =?utf-8?B?dXRyNVc3bG83SkVPSlJFZUNnSmZjR3ZKbGdWeUtrZWRLZlc2enpFNXRSTHNB?= =?utf-8?B?RlRnOG5RaEVkL0NZTzFIRk83d21tdjhZZGI0ZVhod3kwYXdpWTJ6QXNGTDlX?= =?utf-8?B?cGt2Mld2QzBMa0VyYXgxOXIvcWtOY0ZxNE54cCtSK1R2c041RXBudWJiTTBu?= =?utf-8?B?K3NnakF0SGdxR1lYbzJ1YmlYL01lQzBpRzREN2lONERvRCtqWEtVSkxWSjFG?= =?utf-8?B?d0dOM09oNnAzSnNOdGNIS0xMS0Y2aXFMTUdaWTRsOEVwRG5HQm1haDlmcUhU?= =?utf-8?B?a0lzK3RGRExmTWZzek1aTVlOZnhWSlAyblh2RjladXBHMUlKN0pVUndSOHF4?= =?utf-8?B?dXhabnpxQSsxZFhFcUQ3WXZVVXFIdDJ4aUVoN0hrS1RDSi9MSEE1dVV1azhI?= =?utf-8?B?d2RmdWVtWElmTmVYN1I2Sm12ZU5sZ0ZZdnc4dW5jYitvWXhOZHpyQms5LzlU?= =?utf-8?B?QUgyNFZGODlIMHdmTUY3L0l1SGZWZzRYaWY1NytFVnl6NG5LKytjODUvUTl1?= =?utf-8?B?RDFQOENsSEpvK3VOZnk1eW4yMDkrQThsdWV1Q1hjdkZQemFpZmZaOXBaVUo0?= =?utf-8?B?UDF3TGt2TnB2L0h2OEZHQzVJUVJ0UCtmalowdjVBeEYxRmh4QlhEejFnVzFD?= =?utf-8?B?YWtJZjRWZFc4V2lTZ1VnWC9uSW9LWU9XMHFmeU4vOWZucFlTV0Rad1NGL0VZ?= =?utf-8?B?RXA2UVpxZjlpV0g3Z09Fc1pIL3RVK2d2THpjSW5iSTM0WXNtUFhiWFJwejlH?= =?utf-8?B?NHVTY0Q2ekVlUkU5NDBDQmFwem13elB2MUlOajU3VWNaMFlhK0d6SExoRDZL?= =?utf-8?B?TGtGRkh5OUExYmJkSzB3N2RnMWtiRXZOR1pwQjNpa0g1Zk0yU1VhVm1sNlNy?= =?utf-8?B?K1d3QUpIRHFhbHdBYmUrU1F2YVFFL2JFa01ITUUrVzkzYm5WYW9pTlhuR0lX?= =?utf-8?B?WFpJSURzbnM1SGRzU1M0SkJ1YlJOQitYeWY4VnhBYkFaaDdYT1lWTGFFSkZ6?= =?utf-8?B?TjFBYUc2OXYrdmRwVExGZnVITHU2aWQ1dlZ0MlVjT1NSK1JaeWJzOWQxTzR2?= =?utf-8?B?VXlOK1NxeTNSeEZEMk1SZ3VQR0NOcUhueFMwMWNLTzd3Zi9PWlRiZHZtT1J3?= =?utf-8?B?aUdpUVJWLzZoQlRNOC93cDZSMFVxSklqZ0NidmJCbDhFTXlaNWdwNjc5NUxm?= =?utf-8?B?VWxzWkRsWGN3NzdSQWovN3hiTzFXcXk2VHQra09OV3lkcFpQdzRDWXR6ODZ3?= =?utf-8?B?NXlzNjMyWGtFL3Z1cXpRbGIrQTU0U2R0NTJ2RzdVdVQ5TjBBYlJNWmRBc3l2?= =?utf-8?B?ZDU2VGt2c0k3M1lDVnBQSmtQWTB5Y0ZIVTY0Vnl1U2t0Q1JPWC9qWUZpM1dz?= =?utf-8?B?V2NvTGoyWnNxWlpQVTNIZ1c1RTRITFo2TEFDQ2tMYUhUQ2o5R0xmeXdhTm9U?= =?utf-8?B?Vm9TSENvT1YxRWNSdCs4b2plVjBWVE9sb1Y4VWhKd2Z4NUpOUnRCb0lUQkE5?= =?utf-8?B?WEpMRVY0WlhBa3hubThhZE4yK2V0VndIblZsUWlXOWwxN3krR21tNHRoSUpn?= =?utf-8?B?ODB5eHZGbVZPMngwVUdiK0o1U010czlsVUF3TEdsUWdwQmQvVDBDbW1GTnpt?= =?utf-8?B?d0VWbTBjRm1Idk5leFU2YjBDY3lvOTZGODZjVkNLOHN5cWNsVFVaT1hTT3g5?= =?utf-8?B?SzF1eDYvYysxYzhtYStpcmZQeEo3MVgvWjZyL2VMdGFOaU01RFV1SjhoN05v?= =?utf-8?B?VTZmZkdZRlcxUWhjZGx6Vy9lYis3NWtFeG1iVkhXV1ZFQmd3TURDQlFWV0hz?= =?utf-8?B?VVhJUWUySDVBYzUvK25KRmdSbXNvWjZ2VFR2ZkhLazFJL3lRNU96QWR2ZUZL?= =?utf-8?B?bUF4TXp6c3l4b1RocTV5aTVrNjB4b3h0dmczeEMxRDNYcWFqL3JkN1A5Z0JN?= =?utf-8?Q?kefrUha+phDmmbKuKpe7A53MA?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a46c9f3-790b-4553-3e56-08de1ce4e7bd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:00.0727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xCmghX3xJjBpYu1H20AVLMCU1cASnbanrU0UrybILfJPf0BZmoLuEKSNq7khGQExoNetZVmko9FO1IIP+za3vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9287 Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index c466363debbebe8f91b908b3bffaa32e9bf8b9a6..df6a4126538d22ff6e02145edb5= ac13c2d72c949 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device= *pdev) =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; - ret =3D rproc_add(rproc); + ret =3D devm_rproc_add(dev, rproc); if (ret) return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 @@ -1211,7 +1211,6 @@ static void imx_dsp_rproc_remove(struct platform_devi= ce *pdev) struct imx_dsp_rproc *priv =3D rproc->priv; =20 pm_runtime_disable(&pdev->dev); - rproc_del(rproc); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012001.outbound.protection.outlook.com [52.101.66.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4058F2D9EF3; Thu, 6 Nov 2025 03:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399870; cv=fail; b=Of9kgOZh9gAouEjqiLuhzrM2tWdnxmwzH+cBlWEx/P88Slk4E+Q7OF1Zz/vMmLDplvidPyC+jcPxRfIZhRjd3r+CkzIN1ZFzpqz/itFTWNraVUnmE3u4KLliWgQsbiuG4yq3V3XHqQ9P3EO7HS8jJbhWlQ8PO5sE9kygmmQtJjU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399870; c=relaxed/simple; bh=bIvLCjNhP0+rwnyzlM6gsjUPBMJetltPcNLMLdue0wU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Z23/80qKEv4M3ApcVjVIcgyEKAdTYlFtio8q1tVgtoPMwpj5MSCSkMnJMBB0ZkN0YDQvHFcteX/MGIMSS5+atdzGdC5PqNvN7aIW64xcmcF6aSnSMeSOvUDGEe3sQCq57BxeBKrAHjXYQEEzQOL25JT5FP06SbGDQ2pW1eMxnyU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=dFIOlEDA; arc=fail smtp.client-ip=52.101.66.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="dFIOlEDA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aM9n36rMzCTjZ6e+V0cf8s0iApH8cDS3qh5aiEjOIr5vpgmC9WpKlaeOx8Oa/SfDoDtu5tMdpwbV9tA887/kr8eC6Agx/nm7ifzS47GqTnVgHjCHIGIZmD2HPWO6iTlNHxviboR5V0IiNHoackKLUA1jbfrmTLtAdrjEtz4fhPBdISGk2H9wBuCHCLWo7Oj+Ea4xjXr/DqT5+2IB0hntIYM/82rJWSy0vlIZdvzh0jUlwG+MiO9zudP6wVNd8QaupszOWKwCX1+5Bzp8aNV3D1svDhluDdnORhvXxqgCoix9oblbr0hcqvNBTZN2+/1vUqWJJMgZPBKrpNlalEKJUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2zZ+YgtiWq8CEwJWqYRYCCjjLihApNpFo9YjMoZ77IA=; b=mYMfRs7imOCz1uO64qobWBoWbLfFXfKzUcWzFCCOPPBnuDP5K6x2pau1PK66PpMKU3j9h8JimZ/FGrz4/KBBUJXJbHxUUP1Rg/u7nPGjG74z9gPJn4mk3n90bew6faVHoNz3uHVMKW2lDP5cPZKT+XAm/EtxoH9OMXx/o0Rx6UXzUiBa5+PiGpigzDepY4pfdu7qD49yEHGBjaJem7H1yPNWsXzG1/3hfSHPHoxd+N4CUCn30eKvoF13P9Yi7HGMUMfNTJI7/zK+cydS3Qeqg1ZALOd3D+oFaYQxpHBdVCeRUqnRVyB+I8uO2YZu5hoOe+NmYBtAWWSYuJjAi31U+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2zZ+YgtiWq8CEwJWqYRYCCjjLihApNpFo9YjMoZ77IA=; b=dFIOlEDAUe56xWVrNvcdvSPFNT032faW53NGZz69wArts671b8LVl806voQfzvSf/ke4JYVcr1kchDadfJ+P51ZfPFV2IgWYm5gwlkEg8o3XTTo3Yu3RT3WvYiuWNnysLAZBUy7ExDGBPALmRWrZrk4Za26cHHNPXJ9h0n0bkbeTmCwMJfFmwEUhFoeK+fE5hDjEqs5ehtgOP5YmC7COYqURM/aNqdRI8I/zENJ9J5Rc4tOAdGcc6klZbpyFv8l6Y2r/VH+iCnUW/sjZ6hHhGyFuQp1dKJpHnMEqjoy5tzLzAbKocev5BJUSxor0hOa1nXrkt5VRk01BtRsjfEEquA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:05 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:29 +0800 Subject: [PATCH 03/11] remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-3-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=1757; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=bIvLCjNhP0+rwnyzlM6gsjUPBMJetltPcNLMLdue0wU=; b=g8reAxpbILs6Nw1vVKZlLEWwO6z7ui034ZOcKTa3TGB3UyDXs5AW0PSPM3vJP1ZQ5iwt9unUj wBLs+Q/pKa4C3BA94A0P9Vzg9SOjpupCNDcuACQ41KL6Oohali9ngsH X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: 0153aea6-2ad9-43af-9f8b-08de1ce4eab7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SVBhZU5Vdnd6ZkEvc3dIazBVaVlzQjJ3Tm5IUnFIQ09IVVZadzMvWEFyd0l4?= =?utf-8?B?djhheGx5b29PcFYya3V0Znp6bzI5NTBhbFBtcjUwT204WUl4VzZzQUVFeWs5?= =?utf-8?B?Y2xJZjNiVDllWXJaa3ZrOXRvSkYyc1F1TkxkZk9rQ01EM0xJYTdDK1g5NkZN?= =?utf-8?B?MHE5eXlqMldCNFcwVE5uMDRVdDJGTTJSQTR4bzBCT3lTZkc1cms1T094Vko3?= =?utf-8?B?N0NvMXJjbHY4dHMrQUNCZ1lRWlFpNzBEdWxxWitYTzVONGRDQ2xEUEVwd2hi?= =?utf-8?B?U04wZDgweUJ6UnRZYnFsUFBiWGQwTk9HbnA5ajhtSDZmZlJtWks1ZFFIT1VD?= =?utf-8?B?YkxyNWttdndYb283eEtrMlVqMTJUQVpNUE9oK3NIckRkMC9mOERtN0lxRjNo?= =?utf-8?B?VkN3UW4yV2hUdk9FbklPN01WeGNPWDNnYWU2UkVITTdmVmFFWXBEa2FxeHZs?= =?utf-8?B?d3VwdXFFNUdPV0RXWXB5WTlIQUNVSmhocEJERnpENWR4YlNMdFFFQlRNMy9C?= =?utf-8?B?aXNPVllnQ2FKYWUwSFJNWHZGUlh1bjJ6b0QxYmVFdjFUSE03ME5kdGZWUHpq?= =?utf-8?B?bVdyc2p5S1NoaFhoSGdydnUvMlJ6RGM3U0t5SDNpUHZpaHUyaEVEeUg2T0d5?= =?utf-8?B?ZUZSVlZYWkNUOW9pa3JuTmpjMHlDbHNEdERLQlhBdTZldSs4QU9YZkQxU0py?= =?utf-8?B?MUFnT05FNGRTWGlzVm0xa1pYRzczTGh5dmhHK1htSHpickF0OHYrU3FoMXpY?= =?utf-8?B?V3FCbHpQZDg0TE1JcmUzK1RMUW5PaWNhTzVmckJuTE9Tb1dOZXptM0YrTjho?= =?utf-8?B?UFo5NGoyZHNhclltWWgwaGtodXNtRUd5TVM1bjdYU215SUticUhNWlkrUjVP?= =?utf-8?B?K2xUekZOQ1NLUVdZc20zemY4UThvbzlUZzJoalNjVEUvc1o3aUxuMDdrUCsy?= =?utf-8?B?RlR6SGNHcnQ0dkVmSjJjd1JYRHc2ckRVem54b3ROKzduNlRQS3hQYU9XOG5k?= =?utf-8?B?YTd2cDR2SmVQSFR6TGxmMk8zd21HWlBIMmJheld2ajI0U1hBZzJWeVVOeHJG?= =?utf-8?B?WXVJajVtbUFYaVVxSTZlenJxQUlOS1JaSUxLTi9hUHNMOGxZeXNNVlNCMzlj?= =?utf-8?B?L1drR2x0M21NSG9RenMyWG5QTkd1TSsrVDFFWUZ1aUk3bDVTT0JMVnRhRmRv?= =?utf-8?B?dGJXdkQ3UVhudXpuN0VhdDRyM1JwVzJiTU5jQzBBYk5RT0E5eFdaczN0enR0?= =?utf-8?B?L2EyQ1NuVkZ5MGxIa0JPRXA5SXgxRThYVERCTGN5U2NzVXY0MWU5TE8wUlNT?= =?utf-8?B?SDdpaGVRM1Q4MHZVMzV1L29oMC9EUGM0VWdQeWtUcFNXRjRSTWMvM0JjZTdP?= =?utf-8?B?SThZOUVXMzg3NG5UVlVLK1pjS0tSdWdCV2liWjVyMVhuU2NicENHbjJ5Qkx5?= =?utf-8?B?SEcxdkplejRsYzJWNlJrMVd1VytmN2RvbTZKUlYwYTJQalNSdW9qVmR3UVdZ?= =?utf-8?B?WEdHbmx1Y3hoaFBEVlJVUXllNWVDaTkvVHNNZGFKZEZicU5XU0VTUjdjQ0dZ?= =?utf-8?B?QUEzTERRbFlqNitaNDNESU9uMnBmalZEMWFZTFlaSGFWZERVRFdPVHY1STZZ?= =?utf-8?B?TC92ZjdFZ1cvcmh0NHlZREZLTWpuS2VmUUVXdjJjNGNDbHh0KzRvK29nNDQ5?= =?utf-8?B?UjAzYXpLd2lubXYvUURlZE9qN2RyZEZ4Z0k4ZHM3UlVwM09teHJFQUhlemNk?= =?utf-8?B?QkFyUzZRbExVUUNoSTJCa3lsMXRQYlZVajhSU0lFWVdkV0tlMUg4YVhTZS9j?= =?utf-8?B?Z1ZBamhaeXdoVzVxWTA5cmNzRWhyM2tYeC91dFpFeTVjR1hENlhRR2wxREVE?= =?utf-8?B?eHdWWjZOSFZkdWRWbnJCeDRjMGxWSkVvWGd1MEo2aXZqZUF5aWNoUzRsVnho?= =?utf-8?B?VFNaOEduL3FESHZrUGlTM2ZxN1JLaGc0ajRTbk9SZGhGangrWmV3M0VFZXpF?= =?utf-8?B?ZnBkOFViVHFwWkQ4K25BdmV2UUU3elRJZFNUZmM5YUs1b1RXK3p0WHNERlZs?= =?utf-8?B?RU1GajZHYWdNVXQyeVZpOUFVNkFUVGdUR28zUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2U1ZXEzbmZBZ0pwU2ZXTUxGb0xUcElSRW5tOTd5TGZkNFN0bFN0UDQrUllR?= =?utf-8?B?MDRYaUVEWHFNZEgzeTZISXBQUXVtQkhPQ2ZiSEhZbTNEZWR4K1hLaVZFdlJZ?= =?utf-8?B?L21SdmtEUkdpM0FvR1VHN3NyUzJBMTZXZXJLUEF3Qm90ZXJPN3lnQmZ5SFQx?= =?utf-8?B?MDlZc2VTOXF4MWUrOGxvU3o1Y3FDWjhtbjUyOEM5V1lQY2V3Qm1jTm53VmE4?= =?utf-8?B?RjR6NnErWTkvTWQycTRLbHh2Q1RaUklxdS9temxKODRjODJ1ekRBNDBqZ0NM?= =?utf-8?B?SVpOdHp6R1FvM3J4R3QwWVlCRXRVWlpadS9OL3pGWDl3bmYwR1R4SlQ5cE1Z?= =?utf-8?B?RldGT3oxZE10YmZVSkFZTEhkVlFXT244QUZoMGNPUHYvcEtoemdmb3ZzVDMv?= =?utf-8?B?Z2gwQnlqRFlaVkVtZTNZRldXNGNNa1FQVUppdi9ldnVrU21jY2d0aEswcXJB?= =?utf-8?B?Y3IzVDUyeGt1U1FrWk14cG1Pd2NEL3NCV1AvaURUSUNuYTJMRkFuRWpqWW1E?= =?utf-8?B?WVZDcDQ4YTRJWG9KZ1ROZlNqWjhWOWQ4L09FNzQ1RDFpNXRITjQwN2E5aVZ5?= =?utf-8?B?TkU3VGRwSDdmNTMxdGUvZWowTmVRRkZtU2xVaFNyM2syUjB0TjVSNGQ1czdO?= =?utf-8?B?U2JlSW5pcyswTWErR282TkREMEQ3Yi9KNDczOEl5aThpZXZWWWphVTNOd0gz?= =?utf-8?B?VU85NUJ4UkFDdGdtQ1Qrb1prT004amZ3N0daOVJDb3BaS0lFVlhwaG9KU05l?= =?utf-8?B?YUxXL3NlTTZvVWxDZ0V1c1UxVThEUWFSZW9XaWV3Z3A1Wm9xQWJpWWgzdFdW?= =?utf-8?B?bjRQQ3dqOG8wbzNDKzQ0U1kySU5naEdtbmNld0VTM0MvcTY4Lyt5UEZtbnFs?= =?utf-8?B?OEdWTU1NSGNZRHdCOEZKc1pOeEJNVE9KdmF1WmhJa0NPUDJkSTFhOWpnY2Nn?= =?utf-8?B?NXI2cFVVTzhGZFZheCt6eS96cmhsazhDdVJ5cG5kZ2tqQTRlWGl3TU9TNzN3?= =?utf-8?B?T1Y2RFlBcFFEYjBDYVhBWDVuRjNnTzNkSjVoZ1R1Z0Qrb1YvbG5UdnJvR3VX?= =?utf-8?B?VzY2Q0h1RXl3VkJxejBBb3JFdmdkcHVIMThCT1h1RkNMWEtRSkV2VzdsTkt4?= =?utf-8?B?TFZtNi9ZSDZKVkpNY1hicDQ2bTQ1NEtaSExVa3FZUDhaOGIydzNRWDVWQ1Ez?= =?utf-8?B?WWJrcnBGcFJ4SWN5dTBFMG1acUdWVXNqK01wOUxVZzVFYUZPeUJscURadWh3?= =?utf-8?B?M0NXMzR3ZnE1YkdrSnNCbTFBd2xlUmkzYmJlejZMSjhXYUpQK2tBTHphWmc5?= =?utf-8?B?U293c3RSUFBiZ3F3UlJQdVR4WEJJOHBadEVza2k0UnNXangyS0N4OUV3VWls?= =?utf-8?B?eGticWJwbUJkUGltWXkyL2dKNGFORUMzYjVDT0V2TFVjUWxwTFoxK082SUM5?= =?utf-8?B?VHFnSnNjaWk4bkhPcTd5VThUMGlHa1lEemltVGhXU1dWd0lEYk94QldMWm1U?= =?utf-8?B?YWJuTjRVUDZUTHhjbi9Va3I2ZitGbVFEV1FPL1h0SEV1R1NpcDlrVW9XWFhQ?= =?utf-8?B?TmxXaThVTkhFNHZLaElpNExoNW16RjhSODJNeUxjQmhDVjIwNWgrb2lyb2No?= =?utf-8?B?VmF2TkRNTldQVElBV09sRnBYbTRXQ3ZieFhiYW1nMCtFNEI5M0RsTVF0SXN1?= =?utf-8?B?c1JMak5qVE91QWJoWVcreU1CR1E5a0RCc3NmaXFQL0QyMzhENUp3ZkFKR3lL?= =?utf-8?B?MmdIUE5WSEFKWEd1djIyZFhxYWQ0dURqb1BYbmd2emFXK09OUGZBaUJvV3gr?= =?utf-8?B?QmJIa1NaNmFEMjFlSFhYMjNrakk3MFQwVndBbStLdDd6MmRGUi9RZS9TOTlS?= =?utf-8?B?Y2Y0UVR5K2Yra2IzOGNZUEFyV202N2hTekhVejdzbVlrL25JN2NhbEpWYk0x?= =?utf-8?B?NWNYMlBBaVhWb2QrL0duNjRjd0o4ZmFncTRveGNmQUx5MytUaFh0QVY0em5P?= =?utf-8?B?R25xeVhuMWRBOXZwbjRpNk1USExJSXFRdlo5d05pZk55MWd0SEtDemRJMDVT?= =?utf-8?B?WE9JdysrV1Q3WTROVkttSG1NenY5NEIvUnBuaUM3T1ZtK05QdTdmTkJ4NlpD?= =?utf-8?Q?wiYzbr/VRKKhI7wl1V6GnRorM?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0153aea6-2ad9-43af-9f8b-08de1ce4eab7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:05.1243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F4OvW0OcReBubynaKA02KJsDPPLhoXk654Fg0t1AcUpgMf3FmwLHHkMw6xL3mRbowBeBl6UzTZO6J0DHO5vYjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Current code on the cleanup path just disables runtime PM for a device. Using resource managed version devm_pm_runtime_enable() registers a cleanup callback that sets autosuspend to false and then disables runtime PM for a device. So, basically the same functionality as we don't use autosuspend anyway. As a result, the .remove callback is no longer needed, reducing boilerplate code. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index df6a4126538d22ff6e02145edb5ac13c2d72c949..f5d0aec52c56664d6074272e276= edb0c4175c9ea 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1200,17 +1200,7 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 - pm_runtime_enable(dev); - - return 0; -} - -static void imx_dsp_rproc_remove(struct platform_device *pdev) -{ - struct rproc *rproc =3D platform_get_drvdata(pdev); - struct imx_dsp_rproc *priv =3D rproc->priv; - - pm_runtime_disable(&pdev->dev); + return devm_pm_runtime_enable(dev); } =20 /* pm runtime functions */ @@ -1361,7 +1351,6 @@ MODULE_DEVICE_TABLE(of, imx_dsp_rproc_of_match); =20 static struct platform_driver imx_dsp_rproc_driver =3D { .probe =3D imx_dsp_rproc_probe, - .remove =3D imx_dsp_rproc_remove, .driver =3D { .name =3D "imx-dsp-rproc", .of_match_table =3D imx_dsp_rproc_of_match, --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013008.outbound.protection.outlook.com [52.101.83.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C372417E0; Thu, 6 Nov 2025 03:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399876; cv=fail; b=TtrRLmXCpGR8LyLHB8E1nRSBATIYicTT/7dAn8/b/bUuzExi3z5C/C3UUTMCAGeOsnqBhq+d9hkdMPYLQQZtZhm8MHeDdruS9mlyk89ameO2yAtQa0L95cdZv4yWb2YjDvxKTjc1L6hQyDue3KzYMaLpYX6mWo9xX2rW7o1m0oM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399876; c=relaxed/simple; bh=p46yHJMi6Hdv0X/Q/8Sj/NdQeh73SSgkFBYhVZvarAo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rvpAdIgjpuWvr11+911+fBMFPSvRVTZhT6fl9v7cVLakhj0Tdtw4dV1z6eo+mAyGy2GTIly+DME0SK9DS9gZTdcvRbZezkWtqiwqxsYrDWcy1HBlDEfClQuyIpLXVDqIEHgsQoWDMi7g8LwYL/53ja1oc8A439v0kWaxWggPivw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Finv3WB4; arc=fail smtp.client-ip=52.101.83.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Finv3WB4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zegvaul8We6J24ARdjDwLhsaQx2W7/Ta9VxV1X+nwqa7DyRT4P4z+eW0LsQ5sxPABmD5R3kqaq4uSU6s0jXIe0wajvISrMyiPxqDHYThNptImzdHCJnc1FOukfrAv1is5Gnpke2XWX+0y05Deq5y2HFA3YD1Pt1jbCD1K9/f0k/celoN/9sL/jZ6c/6YPj99rixiGaWkgx1sJ5XWa2Ga+3blhy+fqnU/iT/kC2TbKfY+pzh0tWJzALBNLy5TpMhQxPQYHhZ7uEvA7qHWWRhIOKqA4IjPnkWrIqVLjjOCZFlCN/zpz5WWzVnbev22zYy4Dd4aI3hzvvGCj25ffelLiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64QVLc8cGUfZENk7MRBk0lJp87eCEUcV6S1lcOA7LG0=; b=Lc5YLR7jt775KWFOczFPIr9iMgkfpCzu02EBcJfCdiTA6OXCxLTreGjoDDdQox+5nmaTOnwxI1j+iPmxFpBIzn9oUMGzOhaV9XKw531NqSR2RD5+odwu/0CzobGfCWfPodTEQkewAbEgxI1BPNL83KDXmWvMxoI0B/a4GzWHy/delBnOjeaiuCDjdbgKYjZt8Cysfk2mcNmnfMpw5+ZUQwt9uP9gx0NeogsSDWUPBY3+xlVX/b+fKd9R9LcntdZrXC1x2VJgXDnyaSHrL+M3jsRdBTbJoskcT3i/iQvpq850jnkBhX2VSEdZ75ut7VlvdOSapDXvLyWDhnAPRoGafQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64QVLc8cGUfZENk7MRBk0lJp87eCEUcV6S1lcOA7LG0=; b=Finv3WB4Ra/wdlARH60SPjrU0bWNkMaiZj+wUKYeuzNhS3k8pTMD9mjFCjGTdcgkfq5AL7o//t3JXQ7cvz+7/v5oHHqcjqbyy5vD//uQElCnxb5XR/Nof07kPLLY+rXVIQCM/A6RpKsnYoGeRSUx5fkPdM7P/OTDKcN5zx376ThnZhyja1QS/BBRJA2ojP6NZGxIqMHJ8lZf6460es4ve8ILmzm/K581l+/dYRMLHNgsSqFu5NiUkXZt/uYQsE1r/rso3EUOXbpSjhahtAXShh7biNSfXv11eSNcgGVqnNIy3D/wpvzHlexM8pZ7HNchN4PBDC0InIXR8TF1KqI0Ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:09 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:30 +0800 Subject: [PATCH 04/11] remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-4-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=1769; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=p46yHJMi6Hdv0X/Q/8Sj/NdQeh73SSgkFBYhVZvarAo=; b=sdr9UBOtXQOSEerZg22VHyaITfQcybY5FjMIET1PV1lv7TPjiCrn5vrxR4mozbV/oCv3HJJaW 0XzHGTHwi44BUnAXuylwmbIp0z832NdbJlMnAVsoIY/Z1xjTZtom+FO X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: e3b1920b-6ea0-40f3-c2ce-08de1ce4ed93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TUNVR1Y3VkRxb1paT2VHQlJraG1EZFdMeEx0NmR6VExteGZHVXB1Qkc3Ky91?= =?utf-8?B?NjdYcE1qMWdkcURzc2N1bExLYURBSFpJakM2b2xwRjY3Tis5Q0MvWlA1Y0NO?= =?utf-8?B?V3I0dXpyclIwdDN3TE80QTJnaFpWcmErVDRtNGFtd0dXRWVzUFVzdW1LQUdL?= =?utf-8?B?WVcrWWZWYU1BblNBOHFyWWtya28zNEtUS1VFdG1wTlJic1pBeHIrRnM3MkRz?= =?utf-8?B?bzRoaWNMc0RJQUlRZjRXcVQ3SnBicVliU2dNR3JqUW5JVThYWjZETXA2bGhu?= =?utf-8?B?Sm5Rd0RaWkIwenNaTFRQRnlUK2ZuRHEyRVdTMHE2NFFiQTFvVXZUNnREK3hQ?= =?utf-8?B?Vkg0Zi9qSDVXem1mNHN4ZXFYOUwrV1BSTE9IRVk5VTdUR2VRWjhjMFlzK2ox?= =?utf-8?B?NUxiMlVxTC81Lzl1TEw3akJiTWdrYi9tZ2xZVVBLVytoYWY5cUJzeXNpcmZw?= =?utf-8?B?WnBhditOcEV4bDAzQ3lpUTdtYnVhcTdPd3JZL2xmNzNHMUE2WUZZcFpLYjAy?= =?utf-8?B?U3IvS1h3RjBiU1A2ZHlpT0lOYXl3VEZxenIwZkJvQnNlTmkrSUFWUjBKaHZE?= =?utf-8?B?d3FidW9CVGg0WG4yUTNLUzhwdHZPbHQvK3V5amVCVlE2S0pZdVpabExwMHNE?= =?utf-8?B?bnYwYXp1bXNiajFIK3dERjJJTHk1OFZldS9HSmM4b1h5YmMxY2piMVpyWTFi?= =?utf-8?B?MUtqZ1FlQnhpT1JVL3kxTURLbnlWUkVxTmNnTVh6eVBuUmlSRzZYcjVXZDRQ?= =?utf-8?B?amxYVVM3TERXOEpjNHZ1UVdYSVRDV2hpZGsrV0hpa3V2ZHBlcVB3T0luRnE5?= =?utf-8?B?YTRUeTJWMmJabUUxRHBuR2tRN21vdmF3VHUxYklVb1VnOW53b3VLL3FsQ0Jx?= =?utf-8?B?ajlVa1BLQnZ0Q1hpYTgydis5S0t1Z1UwaWNGSS9XUTBwVzgzMkVIeEo1STBK?= =?utf-8?B?TmJhaFRxR2wvL2M5dEdaRkRuSStqeEdzZFFNSm9melVFMTY0aFQ3ZnhOK0tv?= =?utf-8?B?OHJNMEwxNDVnb2ZaTENIbFNKb2llOStPeWY1TU9NamNrYXB0REI4cTdlR25o?= =?utf-8?B?bzMyRTEzUE9pNkgzcm5vK2t3ZmVmaWcrYjAwWHFobFdiaHZ6QkM5dVFpRzJa?= =?utf-8?B?dEUxOVlvWitsalFGbnNXS2lGWTVteUEyNEVRVEhsa3FUS0diM2lOYVB3QjEr?= =?utf-8?B?emJWL2VSeFNnVVMrMnRVQ21Td0Y5RmpQSFhGaWx3L1RQRml6RWtSWHlKdk9j?= =?utf-8?B?SFhQZlR6UWtnWTcxUzU5WmNIYUhWK1FRdTRNWlBGejNlMnRyS25IaG1hTEN1?= =?utf-8?B?d2NnK2g2SVFJVm5jK0ZnUjk4QUQ1dkpObzVDZUhlRitHaHdQdmo0bTkxSFFL?= =?utf-8?B?aEFXVnBZTlJFMjhHN1lyQTJzVEpFcUk4cFZSd3BvdGNxNmd3SGZpaExZUUpO?= =?utf-8?B?VXVUc2dBaEYyMEJFSmtpekdRa2huUjdnN0ovZndYaHY5amY4WmVZQk9LdUJP?= =?utf-8?B?a2l4eFVvZm1qWkZvM1p1V3JuVkNYS3pqRVZBL2ZsTGcxN3ppOVpCRUFtcUFn?= =?utf-8?B?RnN1bFh2MG1mOFZtMFB4M0tXY0NTRW9rS0pteFB3U3BmNlIwTDBLbHo2Qjlq?= =?utf-8?B?UGRzRldvb25kVldxc3o4ZlR1SXR0WWdGTEVQZWRsVWNlSFAyTHFJd001dzVk?= =?utf-8?B?SlJQdGRndXliQWlwcVJDZndZQ0s2UDQ5Ull3cnNrUWtpa1pTeitqNzFRQXFv?= =?utf-8?B?bFVQSlh2NVU3NGljcG9qWFkwVHUzYjdaakkxVFdDaUpNK3NZUjFvb1BvSmtp?= =?utf-8?B?cHBRUWdEZ2dCNFVoSURpd3I1SXRPRldiaEdhRW5sVTZHR05yMjBhYnNXWFlv?= =?utf-8?B?Zms4c0NJeHJGaXkxZG9tQStuVTdsNGRWNzA1cHpZbko5YjQ3RFNCYlp1NUw0?= =?utf-8?B?OXJUbEpENU1PQkhwY1pXc3pSR29ERVozQlpiL0pPekEwd0RSVnRVUGMzU0V6?= =?utf-8?B?MWdtbEFDcTd5M096Z0cvYjdFK2NMZUdDTmp4Q2hsSlBIMEEvN2lRUnNBY291?= =?utf-8?B?SDNrNXpNZkRvR0J1WlZBL1poRll5T3dTbWV5Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHRtRXNqek9hVFU1QjVsekFGVTFrTDRZa05YazhKbTdwcXJabFpSaVpVbC9Z?= =?utf-8?B?TWFqc09jcW01ZExLRWRRdnN4UUNZWHJRZkxjZlhIRFZPTE1QcHZQT1NhNkZ5?= =?utf-8?B?OWRGR01CdEpCSFllSFVHUHR6NzVlcTcrWVpMNDhoZ1dPL1NmcmVNa1B2S0dT?= =?utf-8?B?N0ZEeGVqSnRWMUZPVVZabEdPdG00amtTTGlyYkhCRmlxNlcxRVR6aWxxSUNT?= =?utf-8?B?UkVrbllPd3ZTbXZvbWdkQjRCMC9sTWZpSHpNMTdsTTNpZVVwSzZqSkFyd0lG?= =?utf-8?B?K2RhNHM1MGJFYVZVbm1zc2gwWGQ5YXhCYk5aOFdrdWxQaThad1RpRU1aZ0FU?= =?utf-8?B?S3NDTi92SFN3aEsxN3Y0dTVIdEt0T0E1MEp2aERGQTAvb21qaXlXSnF5WEV6?= =?utf-8?B?cmEyc1owQjMrSGhuRlYzMjU3UXNBQ2F1OU9XREw0OUpnU0YzcWtQbDVxbGtO?= =?utf-8?B?MEtZRVliUnM5a0x0SWl6clJCL1lKemtPS2R6aDhBSkVMbzJmWEdNcmk1dlpa?= =?utf-8?B?VWR1d1BjaHRYN0VHYVFXOXJUY2lrY1hDdS8rMGd5bEFnSWxIWGdSS0xuUDd1?= =?utf-8?B?SkFPWlpYdzczSm9GMk5rdWZ0SnJLTmROcTl6NnMvd2VqZ0tIQ2w2cjhqRmdk?= =?utf-8?B?MDdCVEN1OXlKVmRHUWJucVpmQXpZbTZMSmNMbmN2b0NzaHNtcmxZandIWlpQ?= =?utf-8?B?Wlp1Q3cvdFNPRk10NnBBWE8yQmd0ZmdLN0dFenp6RmV1b25ZR0xDWmlMVkVJ?= =?utf-8?B?L1owRjR6OWdMeFlRWFNFb0NrdXNBUGFzZHVnL29QN1VsNUplMnVtaldFZEZE?= =?utf-8?B?S0ZXUFFRRmZXRUhpZlVCYmRVVWpyM0d0SUVGcmJDUGI0cWt3N0VRYVN2N3BZ?= =?utf-8?B?WWNTcUVIT3FWN0FyblpuTUY1TXM1V3JBaFlaMTNPdTJ1Rm1WS2pjTEdpYVJa?= =?utf-8?B?RzMwZzJrcU9FZmhlRjNsc1NoM0ZlUy9tQ2IrZGJPYngzRGJoOHZ3VFh5dzI5?= =?utf-8?B?OWRQY2M3UWxYb3dBbGRHQ1NkcXdpNjhST1pPNU1VVEZXdXNkSklFbVl2UFpG?= =?utf-8?B?MkhKSFYyQVNJcDk2ejRqY1kxK3JlM0E5S21EeDZ1b0FmSUYwbHExNHNWMWNm?= =?utf-8?B?d0VGY0xWb3ZSU0hYM0tYdHhvOG94djdxSWQwTW0wSXhNMFZVODY5R1Y3enNB?= =?utf-8?B?MUZMVGVELzBIbHRLY3ExMXpPeHFhTVdCbFg1NnAvUzFDQ2pUaXZ6UG1veUUy?= =?utf-8?B?Z2pMdit0dUhkUDhxaEhGTFArczdWTTVaQWsxSEZ2S1hCZkhCT3E4U0lsWlZK?= =?utf-8?B?c0gyT0RGRmlLOXM5aWNDUkxZcTN2QWJkZUZicnY0UFN5eFR3Q2drM1l3cTZX?= =?utf-8?B?b05LMXFCVm1FZFJ5VDRkcUVvOVFlTnlpNmFKZmlTUDBHQTNwRklRZ0p5Y1JE?= =?utf-8?B?eVVyN0FPVjAzeFdDQ3dJSDZ5THM4NEZWSXV6ZUVnYTBOMEVQTXhqMkdaLzZG?= =?utf-8?B?RTNma01Zc2RwY2tFYXpnYXdTZHZlck9UQ3VHQ0JYN1JiQUlLU3RsL1grMUJk?= =?utf-8?B?N2tnbFAzTnV6Nzgxb3ZtcXpsRmRiK3NSUHZGUVluZmE5dW5Od21laUx2a2ky?= =?utf-8?B?dkFsK2NwbkUwdGdlaFVJYXk2ZFVFMk9GV1lNanlnVFBTb2Y3SGJkMGc0eTMr?= =?utf-8?B?OTdzUGlyQkFpSUFYOElOdTUwQUU4b2ZvUzVmelBZM3JFWmlGNXM0WXEzWG90?= =?utf-8?B?VWdDUFJ6bkZSaVhQQzRuRE9yN3phMERwYVhXMkRKalhGbEdnYTlPd1FtVjI2?= =?utf-8?B?QStlNk9hTm9MeGFSRUtTZ0xhS0NNR1lkZkZrNUhIUnJnTVR4TGdKWFJodXFl?= =?utf-8?B?bG4zZkJ3QS8zM0dWN0NLYmRUbmQ4dDBtQzEzOTNIQVQ4N05KMkxWbjFtTVdY?= =?utf-8?B?UG1DTzNKcGZCVUI4S0t5cjdPN0pDYVl2TTdpN3dyMHdWNmN6dWE0cVZnQkV1?= =?utf-8?B?SzBkNktDU1NTVFRtLzhwdVNib0theGRGMmpCNTk3SXhBbUhpSTNIRTZCOGlZ?= =?utf-8?B?dCtMeDFrWFZGT2FFbHE2OEtBRGxDOVJsbStqZSt0YmRCSzJ1WkJiazlxUHdt?= =?utf-8?Q?gvZdSMRf8BiQ3g0QwBOtt8eb2?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3b1920b-6ea0-40f3-c2ce-08de1ce4ed93 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:09.8895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SpDdEGjv4anUrTQBqTQpS+xbKSBcJtCc2FypPVautaC/y5ris2zIAsZySW2t1Wh31MVJIDJmypN3E1kGZ3+QAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Replace error logging and return handling in rproc_of_parse_firmware() and imx_dsp_rproc_detect_mode() with dev_err_probe() to streamline error reporting and improve consistency. Reduces boilerplate and aligns with modern kernel error handling practices. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Frank Li --- drivers/remoteproc/imx_dsp_rproc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f5d0aec52c56664d6074272e276edb0c4175c9ea..87f4a026c05fbf1c9371058290b= 2d33cb94b9e54 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1150,11 +1150,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) return -ENODEV; =20 ret =3D rproc_of_parse_firmware(dev, 0, &fw_name); - if (ret) { - dev_err(dev, "failed to parse firmware-name property, ret =3D %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to parse firmware-name property\n= "); =20 rproc =3D devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, fw_name, sizeof(*priv)); @@ -1177,10 +1174,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work); =20 ret =3D imx_dsp_rproc_detect_mode(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_detect_mode\n"); =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012003.outbound.protection.outlook.com [52.101.66.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4ED52DE6F7; Thu, 6 Nov 2025 03:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.3 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399879; cv=fail; b=kJcOYvJjG8/X2aeF36TwnLIZuYi7lssi02kw9qK3lyL0SIj/AqZrW6u19PRbflPw/4RhJTX122sy6wCEwnQ6UTRM12Ob/7d+Hz0P3Wd70TPgBiKd6gcFGZfs9EseEKCeam66l/5KYcn0/rU7RAOKZKQtVArwEsDJ+Zk68ckeKb0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399879; c=relaxed/simple; bh=MabbyjyoPbnWQv9vkkZtABhK4D5YWt7ZD821p5s8Gho=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FKA8cfqrwPrlU8OjsTQtgLQ+cYA6SyHBiCn3JL2B97CgXw8D1DTJZwx4+eSlvdIk9SPhpbaeVp9D07Osccepsi56waOZhARTJICVIWQwHUHjJUG0qX4uxjvP5EB/Obijz8hXS/g7m3JZ7u30Xee+6jiBIg1Gr3NNQbTRLFvW4ro= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Ks1pu8kk; arc=fail smtp.client-ip=52.101.66.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Ks1pu8kk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c2JnBBx9Nrm3+85EZ53Mkmzfb3PjUBlFtZi+8o8ec31yIcEBr1eDK3doKLgcZz3bTUcWxkTBZgo4e8WNl9XMEzTUFptiVJ3fZEE1T0OpyAKiR+fE37ZrNEqrasnX3h8t/j0iiqMl36fws2TR5TLG2FMIs8ku75o5JClca6asXUrsK9o9QGEqFl7MtlAk6i1ntzosYWigucRESGtE+1pglNrg+voOSNvpCS4AJVCrtpOS/Cat5rDAWzty/c3U0C+NbCmA4ZdGlDjRjD4m1Bl6nJjwgCVx3THtGLpe8bujFaqHvmmMCC08J2Mw5CFvtnUwU8tmjuIIk7Y1BjLzGIeMWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMwFQnF7q+YGW6rwyr0ioKajjHxxtxFwAJntznhH9IE=; b=XJJjyDB5xlN0Jzrgvhx8EBFCTBJsd0pqeaKMLqo9B8nrCdvA+yyVLhvGQwQUWZbTLbwuhft7FI8RzIK0et5i5w8oFbeM4UmGtNXr1oxb6GSjXc6/qqPKed9csF7HgqCSk9oCZq30ty9sDb6JDpKcVE6MAOiRlEijbSLtnkAfla8xFF7sXVIUT63ob72Ebe68P8qZK/hcSupIO4yheqOjjGQX8SzcjFtvbi6A1Fq0MooWoKM+LXd2Yqw7UpyCS1YJlkDhhS9xA17Ia0pMdZiQl3bydAx5uNkJRrOqMPkF0H9BPsWfYCg7z6lV3S6vV51dpdZl8MPxZpXWVq8FSa1mZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMwFQnF7q+YGW6rwyr0ioKajjHxxtxFwAJntznhH9IE=; b=Ks1pu8kkK7FI7hxAgzRKo/a+HO317x1fUxP+8nNOyf8sW0Ze6e4La7w0VFNSOENkS9sRT+KBKRZ4YqjnAJaBeby040gMq2hUF9HMfdp2ai1SwzanCgqi2ihSL5DzIW5sJqDvFBYnKWt7GE78PKfATU0jIP27ZIOw/aJS4ImIshlPpBx3oZKOQP6e/qE1BlR2WmrYV9JnCgC4Py6g3EljMxLwErDYIxjIYyb8vEXFXxsxp0uACmSqhgEnxP7J+t5f/YLdxFdnoqXNk3WMqGvImoNRpwO/Rpe/PmTWgciiYIKbZ1oQeVcUov9ZKTHm1layRY2fXK7sfO3+WShyxK+qnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:15 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:15 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:31 +0800 Subject: [PATCH 05/11] remoteproc: imx_dsp_rproc: Drop extra space Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-5-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=1002; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=MabbyjyoPbnWQv9vkkZtABhK4D5YWt7ZD821p5s8Gho=; b=o5vMz1B1GxTjeX8Ma7CjWAuyTuXrkSidUaj3DBVwhIbXSSHF4dSbljaUlEai7Np7tvy4BTFAf eEs7bUdJGWcBQeU9cLURa4dCC1ApOvJGT1hrkHAmakSEok7Xd/7GbBl X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: 833ee535-3b68-4756-aa69-08de1ce4f0b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b2R4VklNYjJjTzdjdFhPRE1FTDNBcHFnNTYxZEsvOXNvVy9SQW5iMjgrMHBv?= =?utf-8?B?TFZ5ZjlwSWlmdm9qM2xhTDBXTTJaZ0MweWR3dEVVOEthdHBYYkhzdHVDMHlY?= =?utf-8?B?eEJtVVVSL3c1NkZYem5ONHJOZlBPMGo3bEVIOXBTbG01eUF1YWs2WkJ3aFRi?= =?utf-8?B?d0s2aWo2cVpyUnU4UWdRU0pHMDZEZ1c1RTF1OWk3a2pMZUVGa1NKR3NTZmE5?= =?utf-8?B?V2JTMnAzK3VBMVE1N1JldFgwWnMwWnU1cDlmWUZOTlZTOFN6OWxZeFE5aTdy?= =?utf-8?B?RlVvb0dEYjBWNDdRbDJrNU14ZkJ1c3FjTUpYQ0FiOGtTcmlXay93TmJObnlY?= =?utf-8?B?RzRIWVpRU0FNb2RBb2oxZW94bXA4OElHUHBWL1dlTlh3d1hZQWZobVo3RUkv?= =?utf-8?B?bDE2WEZFUWMxRExSM0NCVVlkQUcxbHR6VDZ3dXJoUGgxRTlOdXBnM0poK3Vx?= =?utf-8?B?YXhFWmE1eHlULy9udW1zOFFjRXZFcWdLMzB0YmRGekh0cHVqTGVCVFp2SjlP?= =?utf-8?B?WHFLdWxVajdidlFqa1h4ZkQ5ek5LZXhDOTJlbEsxeXEwRlZuM1o0ZGphSDNH?= =?utf-8?B?TkFHZGhwMHBvWjhJWldtTDYwZlRKSG9IVTNULzZveDd6KzYxZTFZMjNWYWUr?= =?utf-8?B?Q0pvSTNzN1dtcHNmT3dQcGIyQVNqR2JGNEtkMk9mVnc2WmFkeVdwVjRXK2gx?= =?utf-8?B?aTJFRWd2RWkzb21ndDU2RkN3QnNqZGlickZPQnl1K1ZzVlg5OFhCVm45SWJp?= =?utf-8?B?Z2p0NC9GTUZkVnVSMFFQOFBKaWQ4TVZobFRBcmR0OGZpYzNKM3JINHFPdlQw?= =?utf-8?B?WkNNUDVLMjk2emcyeTlBUXdhZm1GODk4ZXhNSGFZK3dValBFVjdpQUpZMnpp?= =?utf-8?B?bkxRQ0N3SXljblAydkMycW1Lei8yd2dPUkhXZHFlT1psdVZmamtMQ3gvdmE1?= =?utf-8?B?dG5qL1BkR2ZLcnJjZVA1U2Z0eWVZMEp5UUlFbHlBd2d1bFIrbDhNM3dWZncw?= =?utf-8?B?dFpueTQzNW82MHRjK3V0ZFFjNUkvaTE4Z01Tb0Y2UXh4VlFzREt3bVdObDdU?= =?utf-8?B?M3B6dG1tamJabXVGc0JSNVlSWW15aXQ0QUNQdkpNLzhYQnVvWU9BQlg2YlM0?= =?utf-8?B?Mno5SzNuVE9mbXduY1IxN0RPM2U1V285Yjh1L1orcFR2MENWRFVYOHBIYUJu?= =?utf-8?B?K2srbERRRGI3SVJVU29tR2E2cFI5YU1qTnQ2dHNvVUt1UXBSYjRZOTNYN3lW?= =?utf-8?B?Z3F4NXN5NTdZSkNzV2ZMU2hSMGN5OHp5dmhGcXltbWpMQ3Q0RHhqc0dxSmt5?= =?utf-8?B?OEszZUxVSUtlR3RGQXRpazQ0MGJXK2hYVW5jY1NkdCtES244djdCaWJSWXU1?= =?utf-8?B?Mll0QzJRY2crMEZTRk5jeWIvekJTRk9YUm9yZjM2MTNYUGNaQnc2bXZoVnFw?= =?utf-8?B?Z2dXSVNuSzB0ZlJuZnp6VzdPRlBuMS9jYytlSEV1WnRvSzVhUEFCL1RCbkU0?= =?utf-8?B?OTJFeVRZa2RqZnkzZGpIQUo2QVFlMlUvTTlBZVg3WnBXckZTbFBtS0FzNzlL?= =?utf-8?B?K2I1WUphd0JQYlJDTEIzaWdXTzhwcmhseVByczB1UUxFR3BURDMySzNQSkxT?= =?utf-8?B?RGI3NDZBL2JySCtCTVRXeHB2RUR2a3lpU2xIYmo5VTd3bjJVd1ZiLzRoSkdj?= =?utf-8?B?d3NEcFZxU0Jzd1Y5SUFWSFpzbHdla0hzV0hCcWtKNUpTN2dkbUhaeUhLWkdB?= =?utf-8?B?MGkrdFZ0M3ZPUVRobi9CWDQzZDAwNHRJS2crM055ZmdkT0ZMbUI0T1MwcmFL?= =?utf-8?B?VGlLZGxodWwxNGpyYXFxbFJzZGwwdldXejB5cXdSY2hlSU9YYUhkOFVSdmIx?= =?utf-8?B?RHhGQlBORm1VTnBlVkxMTkZTM280Q2prV2lKUWViUFF5TzdtRG9Db2w0N04x?= =?utf-8?B?K0YrUXB1K1psQWJKVHlRZy9ianVESUJwYWJyUDA4OVJjN0dRVHdqL1I2YkRH?= =?utf-8?B?TUtQYWJabE5XT3dJOW55TFIzclA2VkxjVVJVajMzM0t0QklZa3M4T1JmMUJI?= =?utf-8?B?M05HT3htMThsNFdrMEdiaTROTmhPV3hQcTdiQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkROYUNxaVVSdC9maWJFVVBuUnhVNmw5KzVRNndpOUN4ZDBqbCtOTi9QRTlK?= =?utf-8?B?SDVkQzVmak5MRmFtOTFmZjlVRjhVMG9wejZuVUtZVGxHMHhBQU0zVlpRamVj?= =?utf-8?B?dm1rRWZwMFdDSExONUR1L285V0NoUit3aXBoMkJkS0hheDBqR3pKUGF6L2Zn?= =?utf-8?B?NnQwU09zd1RtK1NCNXlJSVlsRU5aL1VJcGROV1pxQkZrbE1hNjg1YkFYeFpF?= =?utf-8?B?c2dnS2FtMzhvRjB6TUlwYkpGQ2hZMlowOFVVUDdSY01PSE5zSFV4Wk9QUEhs?= =?utf-8?B?VXlScXZkejBsY1RxSW9KbnhlaVFLT3lTQzVLeTZpRkdOZkVydEpuQWtVVWxF?= =?utf-8?B?N25pYUYyb3FwKzVSdTVIRkNLaGhIM25MVjlzNktPbjkvNmtNZ25MUHIyVUx3?= =?utf-8?B?Y1prREh1VEpkY0NBRGd3T2Y5T1ZKWXppY3NQZmI4ckh3bE1DQXVxTzllSU5z?= =?utf-8?B?d2dwcXNnZURwdzE2dUFoQ3hMZTMzT2xGditNbjdiYUhCWDhKbTFmOUpjM2Vq?= =?utf-8?B?Z2FSc3ZZZGljNURxNHM5Ukh1Q1pwTmZrbUoyS3czQk9USGU0OEZ2WEoyWGN2?= =?utf-8?B?ekdlWVpHZnNtV1ZTOVJRY3pCMUdmV21Ea2hucnUzNjFyMkhpQklmWE9YaFdh?= =?utf-8?B?ZWV2bkRyZ0xpTWJLVWxOVUdMczQ2UTRac0dqSjBJL2owaGIxVlExc2t1cXR3?= =?utf-8?B?cjhWOEdlVEZuUi9iMlpsWFprSS96bW55Z0tka0ErSi9ZcDBnVVJOS0ZTNytq?= =?utf-8?B?alBxRElNWXZWNEt4eDNCNFpsOWE0bDVLMjlucVg2L0piSGFCd0hpNUxucTVD?= =?utf-8?B?WW9xUDE1RHBIK0gvSko0ZDhRVGhka0VjS2x0NUFZVWZQT0l0UUtUVSs0eE1Y?= =?utf-8?B?cStMdjZUQ01wTkpzV2Q1clVwd2ZxRE9hdFFrdnlBeEoyT2JEWG5BOE82K1ls?= =?utf-8?B?M1QyZ3Fhd1REWW5rYnJLS2FtWkhOaWxyandhTzBZNEVFaWlTUlBYRmgraUNW?= =?utf-8?B?RzJBcWJabTR6aGlkMmowNU1sK3F3L2ZEWndGSXZMV1B6OUZQbmdacE5FZFM1?= =?utf-8?B?Um9manVlWmNDalhjaDFMckdZeUlDK0d5RWRSZjV4MmJPNnZvTC9yUitYc2pk?= =?utf-8?B?ZkYxYjdpWWdJckN2SDRCVXJFUE1MNUFXYVdyNHJJL0pvSEhQTmg1NXh5OVV4?= =?utf-8?B?eUl4d2dUcmlYQ05kS0lnY1FSZ0s5MkZxa3BtMEtzQ2hJSlJyM2hvbWZtUS91?= =?utf-8?B?SUJvV0VhSGkxVWJGZHZwcjg5ZzNMYy9NTnUxZDYyOUFteXI4dmVrTHdYVkNJ?= =?utf-8?B?eFZncXpoQnppditxOEc5UENZVzNIV1V5c1QrQ2RONlU2cjJCMkpGTGRKbzJ6?= =?utf-8?B?VS94d2NPSWduWlJzN3RodmdXSzhLWUwvRG5POWY1YUJHaGJWc1d4V3RvdGNq?= =?utf-8?B?SlVWRjRUN0dmVEJWb1RNRmw4NU5saGV0cXNRU09XTE1JR3FVVnBPMW9jMjZS?= =?utf-8?B?WU5UUEhIUi8vTlJrNDZvMHUrdXoxMmZDRU9JQ1JKbjRhOC9VTWhLRWtQZjhz?= =?utf-8?B?d0tnY3JNRDFkR3B5OFVvajNKcEo3NlpYWldPZmNTVXpCUkVEM2xxSlVRWm55?= =?utf-8?B?b0V3QUw4YTIzWEpsdUhBY3c5S2JSTVB0aXhxcUZaTlk4STZsVW1lWWo2Ym40?= =?utf-8?B?S05tbVc3V1VmWUpaZ0kzMHY0SEVxYWsvYnE1cVZaS0JDdXRVWUV3c21sS0Jj?= =?utf-8?B?SWZiTy9hQk9nMzFrV3dHejdrTlQ1OE9jRk8veWQ0M3lIQ21OL00rek53b1d3?= =?utf-8?B?Z1RsSFFXbHpDK2MxYmdocW16eDRDK2s2eTMyRW9CVWZWTldOeWZpRWg0TjBJ?= =?utf-8?B?UGdJRlVXKy92SzkwNzhrTmY4TFpsajlKWGx5enl2Wm5GWGk5Vm9PRnExajlM?= =?utf-8?B?OVRaZWdnaVByTXdpK3lGTXVpQ0pjMklRanN6dy9HVmJuSUhRZmFaaTNqUitJ?= =?utf-8?B?VnV1NW1NYTVxNFIxZzBQdWJCYnFMblh6eHovQ2VLRk5uYVBpc2lhYVZEMVhV?= =?utf-8?B?bmE3SHVMbnZqTXZ2OFM3S2ZDK0M4L2hJMGV1TVdKdHpaNDJ5bzhmUlg2RWJN?= =?utf-8?Q?OfLE3lMZcw5fLclFtKucHa9UK?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 833ee535-3b68-4756-aa69-08de1ce4f0b1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:15.2709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2noKaCTAtOrjgv1gSTOz1afMclLQJFFp6jstqRoFWFnlaoCp8IaeI3z/RAv2UaR2N/Vvaizv5PYR0x7K9oCClA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Drop extra space between return and zero. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 87f4a026c05fbf1c9371058290b2d33cb94b9e54..1726aaa1eafb9ac1a913e3e2cae= a73801b86dc09 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -784,7 +784,7 @@ static int imx_dsp_rproc_prepare(struct rproc *rproc) =20 pm_runtime_get_sync(dev); =20 - return 0; + return 0; } =20 /* Unprepare function for rproc_ops */ @@ -792,7 +792,7 @@ static int imx_dsp_rproc_unprepare(struct rproc *rproc) { pm_runtime_put_sync(rproc->dev.parent); =20 - return 0; + return 0; } =20 /* Kick function for rproc_ops */ --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012045.outbound.protection.outlook.com [52.101.66.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C162DECA5; Thu, 6 Nov 2025 03:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399885; cv=fail; b=XeOMUKZfKF4+03AazHDzEhp1A540tSnDj1/LnW5zG1qqpBjKJWqBVbotCOmXinrqZ3qTTI0L/kLFx7fsj9eoZco0m9nEqhPacK511bsVy1QbXiWIwsmz+j9AnQA8exm9+KXTp5/1U7TifxvJpiFNnY0HAikXrGiKjk0RlZzcJhs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399885; c=relaxed/simple; bh=Z19UBLIlnL3g+Vw1kO633FUT8iiXU2JzyLxoSehCLzM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=t9a6ES1P+pY+CCnN3XdiE9joZH6FPwIDTMWKbbUFD3Oh5JfSRP2LWLHj0CQDSgQ76R6kYDCGp2cVMvKL03doBZKN8pVPBPlntpb9dH+On3rT9Hw2YsMfMVuI90iuiMMpU4UyzD6sTBVGwfD7FLA685ozXgsD6MVEvYqVL+QU8i4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=f6eYPbas; arc=fail smtp.client-ip=52.101.66.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="f6eYPbas" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gylGi+n50J9G5vRKEh8QvrCvVGWQiMVxX01UPPxwyhqD5QRXxkFampB7FvT/rfnAccfSinKQTCxtbYeEd5Tvew+Rji7RItolIWbNfqwmDjXdv4PkzOfYsp8HGFohBDRFaszrGtrlq52MN9VQ1i5m36kHOE8tiGbumKB2oU4s6B1HSDTgv69pwN0NXmNc53EhAbpfeHB7rs4e6j7vlEinWaNahOMvaTE9AxG1y+481V28qdyP9i2n74cKV1oSjGQOa/Wrx5i+zQOrHmk71ngGk7novUKLl4E8sYIi9SzQ0nOQBsF9fCeaBe/PDt+DXmjOrE2Ou/Jg9GOpI8tfEUwgKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/4ISHg9YXVkW2NrrgUUu7Zz1jQcfVLSfopDDEsNdBy0=; b=H+Qcyo9wvKy/7zk3ZqMNzrBTTMcf5fvGB2Svl/9uoaGzH0F0CZdmk3j6kdaZq4KM+XaKituQwj0hnqK681cA2C66tzE0ekhUgUc2mSevgB1hPmNi36HX2wXpd59jaOjr3ORYxIDTQhccPFHypv8qpXzBWICXjRsSk5UAfi8z3Xo2CW0t556NV7cVekn/ujpDxpBWCesTnAIdmNjlih2PobQHbY3GUJAtLFUeDkoxj1BbUZ3VVUhLluorp0dVvL0jA9jUqs+yNkpJR4Z+SH3914JD895QFdEnofczbEMxlsnXzkMY/O/EtRs7kW6IhSNSll1r96aqdKI8sYzZTZQ0cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/4ISHg9YXVkW2NrrgUUu7Zz1jQcfVLSfopDDEsNdBy0=; b=f6eYPbasONGeNFJLmOqMc0RfOOfJBO/Yn5oDI+OcE060lEs19VseWzUWFHB6PR6IOsP01OEtHDsJnop9ZthCQek/x37cRGQkXieF4QZO5lUL2HndVEneWZqL1th4/6XRwxnMtB9N1ZcSrIHKYXgm+ckhTlGu04f6Q8ku8ujs9pOsQmlSwhwMwmM8vMPluymB+q87uEiex/PCR8PwPVDNY5U0yCPPAbgsPHyLQTUtuGBdTQe7HppM+peoL9mefzjAiA/XohUBBW9s1P6fSHHAO/xGuruni8LEdYcSp7gwrMLSpmZEwdvx2hXkutEx+W1ilSJgbl7XF18Jb+AXPBvsIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:20 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:20 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:32 +0800 Subject: [PATCH 06/11] remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-6-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=2460; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Z19UBLIlnL3g+Vw1kO633FUT8iiXU2JzyLxoSehCLzM=; b=xPz7AQf53HFURkriaIdUhx818g1/xKUD1SrK2vY2Vz8gm5/VGxl13sRaTjpTRdj8hFU4jNnLk FsTJVOrDjT7AzwLHw6iuraHXKC3CLneSfZgKpk6LscnxlRTIE0uggBX X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: 5055fff7-cf5f-478d-146e-08de1ce4f3a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aWRCcWlESlBDbHg3N2dyT3g3RGxldTBrQWZFbHNIdUlubE5zWmh0OVp4MTkz?= =?utf-8?B?c1ptbU1VSURaa3pRVGRBU0lGbC81ZmhrdXc2UUJzUHl1QTdKWlFpcjdGQ0p1?= =?utf-8?B?cUduaDk0eXlVZ2VxeWVlSFcrS0JBQkpna3NKWjVHbll0a1B5cEgxVEZsZVky?= =?utf-8?B?WExNa2hWUTdFd3VsWDF1eUdOeTMrcFB5TFgxWXNPUWs4N085eGovU3pwdzQv?= =?utf-8?B?ZWFINkJ2R2VORXI2d2ZMMm9QV0RseldSNzZzWVJxSnVnVlY2a2paYjQwRzFC?= =?utf-8?B?QXBNK2xYaXVoUmw3QVdScTkwRnlOd2tsSk4xZldHa0pHRUxsMDlIR242Zk5V?= =?utf-8?B?MEJoQ21WL0d2QU9rZ2pvZGhFaFZBaWZscXA3c2o1RW9PUEtQckowbmZ5R2dB?= =?utf-8?B?NXhDalA5SWZvVDlQai9KRzZBNFFDY2NLRk9kSHBwVmpHenhianBUdldrdFNM?= =?utf-8?B?VDZZMmhISEJYdnMxRzRjUTdHVytnRkszenRDRVlUbG9SL2kraTVCMC9nN1hl?= =?utf-8?B?U2h6Tm5iTTlOR002UzQycWwvRGt1LytXSnNFSk1WWmZkOFJOZ2ViektQd3J6?= =?utf-8?B?dERZWmVtVEhZMVJFd2JiNEYrUW0rWHRRbVVvemM4c3BhbFFDUDZxZmo5R3Mw?= =?utf-8?B?Wlk4Y3RUMFZpQ1QvZlQ0UkdBVnUxcjBRajd4T3ljcVBvclRwbEgwMjhSdGZJ?= =?utf-8?B?NlBWTCtOOUF0VUtBKzhCZ0MwbzBvMmUreFozVTdxRUU4Rkw4Q0daakoybDVp?= =?utf-8?B?eXZLSUpMN09mbU5yeWhqZlQvNStZa29uaC9wdGIwaEhTRTJ0S0NyZExzbllj?= =?utf-8?B?L3pZN2duM2VYL1JhZlN3eGNKbGhIUmJTSVIrNXJmdE9ETTg1bFprTVVWZzhE?= =?utf-8?B?bDNnSDlTZlExeEtHbUpOd0tCS2ZWOEkxUHFDQnRKc0RIeVZCSUZlMDB5NDYv?= =?utf-8?B?eGtFNXVXd3JFZFk1TUlIM2JvSFl0R0gyblNPYnFaZDVpdzUrNFRFZFNVZjZJ?= =?utf-8?B?UWhWbzBMWnE0TG5ZVEZCOVN4T2hnQWNOd21hK1hsNEh0dnVGUXY2VnByKzlW?= =?utf-8?B?ZnNHNzZCUmhTcEhwQU1qWThTaHZRYmk5OHlXd25hdFh4cEFjQ1JPMS85T0Fh?= =?utf-8?B?UFpQQzA3RW4yKzRGaGQrQWpCTkR0anF4YlFUZVlzSURKMWgxRE5DU1laWFBo?= =?utf-8?B?YlBmbkhpOTlCTlJOK3ZsYlczd3Z3TVJqVzZkc1dDamFGQWkrVjgyWVAzdk45?= =?utf-8?B?Y01LbzdqRzJCMHVRUUgyZ20zUjA2Z0tFY2UyTG1ZTFBBN3pqL2VLR21tcnJh?= =?utf-8?B?TTRRTWVUbDRLRzhXU1IyaU9lNFRMOGJpbXVzeCttdVpZWTV1OVhQL1Y3eTVC?= =?utf-8?B?NERsU3VPR3dOcFlnVWJ2MVBTSk45Q1BxdW8zcEwxaU1wZHNEbFhCSGw4UGRl?= =?utf-8?B?NjZObXFXY2xsaFBFZ2tvSHlMd2czZmt6TGcvRURvUUlaUkR2TnNpNytwc09R?= =?utf-8?B?OVhFQlNrcjFlRlhXMjg0djNFSm16VGM0VndRQ0VkMUV6SUhIR09INjY4b3g1?= =?utf-8?B?dFdkRVJmZWxHRnBtYnR2S0xnK3BIalE4dGt0VGJBOElqL1NHaEo2bFROZUVR?= =?utf-8?B?cnAvTWZOQkZuS2N3YlF6K0tqK2FSN1lHOU5pNGY5VExaYm9ETXFsd0liaHdF?= =?utf-8?B?cStwNWpoTnhyVVJEQ2xDVXM2cC9XcmxPOGRJWEJkWkJyV0pUKzFKYkpocWQ5?= =?utf-8?B?R3I0c0lxV1JWSnROT0JHVUdJaHFWRVBZWUpQUHhOUXdxMWhrR1RlYzA5b1lH?= =?utf-8?B?NC9kaVFUSWdQM3Y1UVM4enlPYzhiYzVib3B0VlZ6ZUZWMVQxdkFiZWhLTHBQ?= =?utf-8?B?emI1bkFYSzVJeWJMOE1RYzNFMVpTRTFxZWtQemVpY0RwUmg3cjRvWk91SGJz?= =?utf-8?B?NEJqZVBxUHgvaTZ2a3FibGM0akJIQTN4Z3psL0VzU3p2VGo1aHE4VlpNRW1D?= =?utf-8?B?NWZxaFdHUVZjM0VWZzdvTkd1UWZjQnYxVXB6cUJZZmk2NUZJVU5jRnhwMzda?= =?utf-8?B?SzhTT0lHNmlFMjZYV2cxTkJnQnVSNVAyWm9MZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWdvY3REVFVqVElOMVFnR2VkZVE3ZU5jT2xKUGxKREpzWXNjdkYwQkFld1pa?= =?utf-8?B?UzNnTVREbk8rM3p3VllOMk9Oc2Nib1BkK2UzeFhEZ0hyQllaZ0F4bWNkcXcv?= =?utf-8?B?dm9TQzB2UmdGbHQwZmwzSi9RdlNCa0FWbjdvRS9oNmtTYlY4cGZYN3VjVXVy?= =?utf-8?B?eXNkMCt1SktLYzY0RS9ib2M4Qlk5YTN5Sm5tODU3VmhXZTFjdHlyQ2RhZ3dw?= =?utf-8?B?RXhtclIrd28zSlZYWVNpT1djQ0prSDJnTndPZEkrNnB4d0ZleUdoQkJsMUxH?= =?utf-8?B?aURscXB5cTlPLzlQY2dLV2hKMXlxVG9QcVI0ZjBzNVI5OHpZN2hvd1k5bm9D?= =?utf-8?B?MTJzT0tnS0RmV3NmdnVKN3ZXYlpjMFo0RW5SZmVMd3YxdjJUdnhxanppRDlH?= =?utf-8?B?NWNPSGxDWXFVTU5lUDh1dWRGVk1qa0FnRWhiTUpLdEd2aWtDMkFRODF3UFQx?= =?utf-8?B?dWlWMUExa2hLQnUxVHBWVVNtSVJJczNxYVZMbkJFRkRBNHFqVEZ3NHdSRVlR?= =?utf-8?B?RVJJMkFWVk1JSURkODNGSklBYk54YjFwT1pTMDg1L2h5blRIczgxaHpDVVAw?= =?utf-8?B?c3RnaktRV081QkZydmFpdzA2dFdjekEzTWprREZDYktLN1pYenhsQU1IQldE?= =?utf-8?B?TlNydWhSbE5iWGtSais3L004YVBDdjNEUDlBU1Y0M2lBY3dRUDhxUTJMMWwz?= =?utf-8?B?NzNQSDVGbk1JQS9qSno3R2hDRHQ2akVCLzVhUDZ3SlJ5TnVZSU4zdkpmd2hR?= =?utf-8?B?MEtHcHp6M0ozaVRteVAwcmI4aDdLZ3VJZDlzN3VOcytPalA4NjVjMzZNUldM?= =?utf-8?B?VlIxaGhGN2ZkUTJrNitjT1cyS2tyRmN6M0l1QlJTUTVMU2srSmxSUUtSOGN4?= =?utf-8?B?MU55cks1V3IyY3JPVEwyUElJZlVWL01vbWdGUHhHWDJWTWdSQlpJSGpra3Y0?= =?utf-8?B?M2RpYWdUR0VidlIybzdSeUNpOVlvMXRxRUVyM25kWE5QYTd2RGV0dXRsN0NX?= =?utf-8?B?NEZDWTBhRlFhbHBnRUo1b3RSTGZpem9ZUnR0T0RmYU9CWERWbE5MOWNXTDVu?= =?utf-8?B?UXpLVGxkWENUTkhxY3BKS2ZwZVROaXh2YjZTU0pZa2lKa2FuRU1WcmYvN2hu?= =?utf-8?B?SmtuOVZUbThmMXhxUjZXR01mamJjR3pUZlFuSHY0WjZZeC9XWkJMZkZYVkJV?= =?utf-8?B?ejRxbzRQRGloaXlXOTgwaEdkbHBGVmU4Ri9MTXkxV1pvVXpVUXZDUUJTS3JC?= =?utf-8?B?TjN5OENkdnk0NmgrZG0zVmpCaXRoTXBJUTV3K0tlUW1OMWUraG5aaDlXSER6?= =?utf-8?B?K0ovbE9KcDhsNGxkbWVFci9MTzQ3SWdKd1Z5Sm1yMFh3bk9jK0hXODB5WFZH?= =?utf-8?B?NEFuSGJ6Zy96NHVkUVVQYjI4TW1GWHM5MVpDOU9DODhBeHFsZnRZRjBlcGhE?= =?utf-8?B?SENvcm9QejZHZ2UxWFkxcCttcXo4V0hTUnpzZmlVSXMySTJFUVJCSE82RlJI?= =?utf-8?B?SUpNN0NJU3J4R0ZIZllDOEVGR2k1SE9zN2dtaHp3RktLSTJZZW8rZUNwbGJU?= =?utf-8?B?VHlTRnRJb0tsOHA4cXNxVHBrSlVRUTN6MnY0NkhkRDRIMElTZlZLNWJ6NGUz?= =?utf-8?B?SjNySElkQ2RjWVdCbXhEZGkvRXdHemNoRnI1dkkxK2gxWHY4R1M4SjNlUGJD?= =?utf-8?B?cUdtejRxNDNCQ2hoMW1yajhQejRYWGtlV2N0WktuWlp3U3FNQm9mbTVJUXJH?= =?utf-8?B?UlRKTVdFTWc4ajFOY0FBWk9oK3M5aFlwVCtLbFFKQ255ZDhZUTA0K0F0UFg0?= =?utf-8?B?bTJqNDdPMTEzU2R6TDBWNTVVb01KbUdPS2UwTEhkVUw1cExRcVE2M2hkR3U3?= =?utf-8?B?R295aE9MckJHVEJBVVVKOHpWdEU1ZXdLTXRDYmh6TXE5VFpJUzd3cVAxR3BS?= =?utf-8?B?R2dnWGYxYi8wUEowSTBnL0Fub3k1cUc5c00vT2VPN3NqSmhPeHdIcUZMQ1lh?= =?utf-8?B?L2tFdW5uWi95R0huYVBkV04wQmUzbzU3dDYrK01rWTV0Z05QQzN1U1FZanpN?= =?utf-8?B?bjh5bUdqR3NuWGZKYTlZWlJBeS9aL2s1YzRNTjlXYVFVS2JlL2k1eUJmMDNt?= =?utf-8?Q?fzUriiJX7PRdeAmkQJ4or26sM?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5055fff7-cf5f-478d-146e-08de1ce4f3a5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:20.1074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9iBvCjcAmTAa0Z86lWSoVME9rrL+u58++mfvyz8VtVJHMB5ynRlSq7FoEs8QEKRcpAAUaa8f09MVm2cCukKc0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Allow each platform to provide its own implementation of start/stop/ detect_mode operations, and prepare to eliminate the need for multiple switch-case statements. Improve code readability and maintainability by encapsulating platform-specific behavior. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Frank Li --- drivers/remoteproc/imx_dsp_rproc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 1726aaa1eafb9ac1a913e3e2caea73801b86dc09..833b1bd4019614157f0bedf09bd= 348caab802eef 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -404,6 +404,11 @@ static int imx_dsp_rproc_start(struct rproc *rproc) struct device *dev =3D rproc->dev.parent; int ret; =20 + if (dcfg->ops && dcfg->ops->start) { + ret =3D dcfg->ops->start(rproc); + goto start_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, @@ -424,6 +429,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return -EOPNOTSUPP; } =20 +start_ret: if (ret) dev_err(dev, "Failed to enable remote core!\n"); else if (priv->flags & WAIT_FW_READY) @@ -449,6 +455,11 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return 0; } =20 + if (dcfg->ops && dcfg->ops->stop) { + ret =3D dcfg->ops->stop(rproc); + goto stop_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, @@ -467,6 +478,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return -EOPNOTSUPP; } =20 +stop_ret: if (ret) dev_err(dev, "Failed to stop remote core\n"); else @@ -1085,10 +1097,14 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp= _rproc *priv) static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; struct regmap *regmap; int ret =3D 0; =20 + if (dcfg->ops && dcfg->ops->detect_mode) + return dcfg->ops->detect_mode(priv->rproc); + switch (dsp_dcfg->dcfg->method) { case IMX_RPROC_SCU_API: ret =3D imx_scu_get_handle(&priv->ipc_handle); --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012013.outbound.protection.outlook.com [52.101.66.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DB41DF254; Thu, 6 Nov 2025 03:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399890; cv=fail; b=Z1/YhNSYL0zfL8ui4yv289A3v3V+ZPUU3oOp5ZyvXFSV6DMW/EI7ZU3ZndfCfUD21AbriK69zjRoGoHHfL0Y2cRs7yp9sFI2OlBVNVSkEaMAXAfbP7LVxphpcxEvVKVIYxBJYg1MYrztPje/f568oxqVGPDpyYw298AmmdHL8UY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399890; c=relaxed/simple; bh=/GQNWAxnuzz/Fvi6TX7zQgT+OJeyV8GsV7UaS2Mf/OU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WNg6reOBG7+Bk88EVCePCU9iD9GZc57Z/GkQJltI99tlZnTLQkjTY7lTjvFSJl8qk2n73Z4989Fiq8SCsVb4Wd48ZZJfTgFvUHrd32So14lCDUd1qpI2mtiOx0iEe2VTmYQ3y9QpanrUEc86olwqSp3DzDbqcZYObat3hgqupWo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FChjaTs3; arc=fail smtp.client-ip=52.101.66.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FChjaTs3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=boWJnHSYtMedrYg4/ZUyDu0QBOX50JqCeZTvs71QFe/IMkgx+lLQ70tSFhRaa9BogIgT+HrOuauojdkap8mQuJndJHh4eahQN33ibRhMeLHFzlghZmxRvRJwR2ROkqVAUNR+dnwzeYVQ3p2nt/W9LX/k9RgqEs24yaOphKsgomKxiP/JOMiFmzdgusr7DnSfuXUE5LSqsq59xI6hcb0cGLQq82xzc1Z0xXoQJWXvp1NOW6ioggAfti1z/6liGQzrSuI2wqt4O7QKMkklVobmM2CMa9nE41VlYAeBNM603jHNmVD81eCImiQj6but4oE1/LXaSpmeesKjuwZujkCLhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cb/doVVYTQ8i+xe3Rwic4xjXgD/ntRjJ5EgKDxyw2DI=; b=r+4pVPD1teN22H3J6lf3L3G6NvmpZyRwPsOEudPh3eOYvH0ROcLu1n+SCPYg/H5ti2DuzXiL0dceAw7wNc0UYRGqQniASU3tSOO6qGNPeq/uAWwyGB62f8brpWvmTOQlYU+Olq8UaSEldqssZUGOLpPnZaxgKw6fLuMbcQhDyNZG9l+n0vR0834B4FG/E7856vw5XSXo85DFYyKODH/ATgGx51gYnwnYNM5yfSygNjVJ/XsfPuy7swh0VSCTjva81nFVFsg0GLpba4BisL254W1dCY6VCnMoFeSM9C0GuN9QmFpFUSb7IC/H3JqcZzaTPK3fj34eNzE1UBBCBagO7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cb/doVVYTQ8i+xe3Rwic4xjXgD/ntRjJ5EgKDxyw2DI=; b=FChjaTs3ithO34KW0enQD7e6jloQNWbic24P2mYZGcKO/P6uUiqJFZqwf/VsaRDnBDbNPIGYQRWcib7laYETzm2gxStmpgBOIsnQuByzPfhVDXawYIXdtcbR8U+5Urhtgp1Ix7uS1JP5qH0HmBrCNJGBfOfod4m2RtKPsmGfjX9gW8BEX9mBiKwawdNsa8GeaKJRKIB+Xm0C1EEG5/cpoSc7rUJxlBseoAnv8wrtE8kpIwHAZZYKVbFVmujZhImGqqOQp7TSnw3JrN2fZbir1VflkVOFWuAbM4Q2TRfdlXyD3eCYk65QVZwcr+jj6NNj5Mphdp6JAplpxuXz4Q2FIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:25 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:25 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:33 +0800 Subject: [PATCH 07/11] remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-7-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=4866; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=/GQNWAxnuzz/Fvi6TX7zQgT+OJeyV8GsV7UaS2Mf/OU=; b=ohBKyWX02wGIC3D5lTYf4pNuQvBtoBpFn2T6pKo6yV8GHY5I+zP2sL6jLGEQN+LJk2RIPmXsT 9JaUwDZJ9UCAz3+PrRgSudm1LF+vbiRGYvX6hKSJA14mFOH/xX1hPhG X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: 25ea594a-86d7-4a37-98b3-08de1ce4f6a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N0NXRSszUHp5YjNEckFMZ1JzcDNGQWJnbWI5UW51RmhmT1RDVWR6bS9HcG93?= =?utf-8?B?elphdlNZdkFhNGg0ais3MU10SWxiLzFaS2tFbHd1V1VTK0R5RmF6T1dzU3hn?= =?utf-8?B?YUFFRU8vU0hkN3JtdzNlbm9MT0Y0bEdMa21XK1pMSUF2bWVjS1dXYzBiT3Jk?= =?utf-8?B?dytFbkRlcllqVTVhbWxrT1dOeDdQaW5qeEVhQlUwMG5RR0hOR1E5ZnI3UGF0?= =?utf-8?B?UTJVU2tTcUJSNS84MTM0WnZFam9LQ05BakJEUE1jdmFDa09UTm5SNTB6VmZk?= =?utf-8?B?eld1ZjFrcGNVdUVtK2RnODA3N0R4NkZCdFc5UzEvMWNjVUxCTWRYTHlFa2Fs?= =?utf-8?B?bzhnWE8xVW44WWVXUG80cm5keTlWWU0wcE83WlRtdWZqeDJYTTc3SFdVWk4v?= =?utf-8?B?Q1hSNWhFdjV1MHhmZ1lEcktoU0hsVTBReTJKa2RmLzAwRUJ3WmErSEtKY2Vp?= =?utf-8?B?dGpBV2dpVWlXM1hkTWwvR2dQaUNBSG1tZXNGaG5sbVpXQmNPejhqbUlNTzdq?= =?utf-8?B?K212b2NaR3V0a2NPYi9oSzAxTXhlc0lKaE83MXdtRWRjUkRLWnRXQUhEbm5z?= =?utf-8?B?TVllL2VRQlczdno5S3kvRndiRXNLT3RWV0szenE1dmpEaEw4LytrYW5qbHVB?= =?utf-8?B?cVVEMTFvUW9ETmJJYWJwMVVOekRaTmpmOThoaVMrR0hoWnZYRENqVVJOVXhs?= =?utf-8?B?MjVXWHNpbGF2ZmF4Ynh4Mk1BdldVcmFxYUg2RTRmUTgxb3orK0NyUU5lZEg1?= =?utf-8?B?WkFzV0lqcG94QTV4cktkRmtWV0I3bGhSa2w3Ym1wYWRLUG1aWUZmYnd5WFRj?= =?utf-8?B?N2Zpdkg3NUl3OFZtRG4xY2tId1ErWVhXeEE2SUd4a2RqUmxpQ1JLVDl2TWJj?= =?utf-8?B?SWFmdU1HeVhOSHU5WUE3VUQ4SzJvVmZIQUxhc3VzZjJDaEpyZVMvY1Zxa0d5?= =?utf-8?B?SjVqZmlmY0U0WUYxaWRpTDZJaXpmcE03enNnMllURGxYdVQyRjMrSGpmQUgx?= =?utf-8?B?WkRWcmZ1ZTJiVmJpZEpHM1phWnYxbkExakU5NTVWRmtMYVJ6RlZvMlQwSXZw?= =?utf-8?B?UGd0anhaTU5vaC93QWVlZ1dxcUhCZHRkdUNNZ28xbEF6dHBOT3I0QkpOeWVk?= =?utf-8?B?TFN0TU9ET2hhQ1o5U1kyTUsvQmF5OGNQbWdnSDNLMWszTFNJWWRldE5Hei9k?= =?utf-8?B?cVJKMlVzUkNTNGtvTkVQVk5YdFE4LytMSkZCZCtQT1pnTzdNcUFhM2VNd3pn?= =?utf-8?B?TnBLMmJXbm04bm9zY0dGako1Y1BxQ0hpdFRObjJvd0VwRmZXRFBmM3lCQS8y?= =?utf-8?B?N2FFY3lVcHpNL0RuUEpORkdnTTcwdmREdldaWkwzKzRXT0RKL0V3Y2JvWGdm?= =?utf-8?B?MUFweG5OaXVKZDErMXY3a20zeXZEcmU2OUJWL2taZ3VMbG5sd0Zua1lXUGZK?= =?utf-8?B?YUw0VnJLWEZ4UTdDS3M5RXVwdUVKL1BnOXgrSUNTZTAyVjNEQXFMT2xxV3la?= =?utf-8?B?SWtYRXh0WkNhc1FWb2tDLzVwMmtENERZNFJUaTVmQ2JMTGlmZWZZbzZRT2Vp?= =?utf-8?B?eEJrRE5FNjR4T2RJMTk3RE1PeGRnQTlsN1puWi9sR1FoZUFnYzFrcjBXbWll?= =?utf-8?B?ekhjdVVWLzBHckdCYTlZNDZnY1FTbXQ3QmMrWXpqQzJQaFVreHhtNjQrK0Nh?= =?utf-8?B?Q21VZXRFRXBwdE1RT2JJcmt2dVJ5aVdXakdvVHF4clNmUlN1T05PVGVNTlY1?= =?utf-8?B?bkd3dmtKRTJudGdzOTNPZzg4amsvdXYvN1AwdUhyTkVJVTVhZGZFQ1JqMThT?= =?utf-8?B?UkxGL2Z0RWQ4QlU3dlFDYzN2OEFrTVp2YlFzTUswakRETEpYNS9NN2xXVlBQ?= =?utf-8?B?WFo2VlprdnpmdjFFT3ZZcE50NWJqdG9WalNMQkZnM29hWWxVTHUzYk4rOWMz?= =?utf-8?B?b1VSVzIxeTlBRm1EZjJiQm5kSjIyS01zYS9KS1lzOGZ1THBZOUw5b3IvaStH?= =?utf-8?B?L2QramZ5SWx4WWMrUXl5ZlZ5ZHVYWnorOHpzajZqUzJmVytJYnltQ202YWt6?= =?utf-8?B?dVFWblJvK3ZkUkxwclVwWkZhM3BzMHArNmt2dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzZwUFNPUU9IdXo5QnY2MXkvTThQcm5IMk5VL0szR0tIbms3andJUTZ5aUVV?= =?utf-8?B?bWxHbTZsUCsvWkZhMCtNQ2hTUXU4b0MvZkJYOFZnamdVMks4YldLS2pLdWp2?= =?utf-8?B?UXJCYmJlRy9DUGRDMkpDSWhlQWlhNURyckh5U0pRZG9uSyt6QTg2RXpibTNy?= =?utf-8?B?TTNsZlpVc2w1cW9VR3ZQZjZhbGxFVDVON0lvbTJaZkdsVzZRL1hMRjdIT3NN?= =?utf-8?B?WXFRRUxBdjE4MzVrOHBiZlkrdHZtRzFJcVp4T3BIQnY0d2NobGN2aEIrUkRw?= =?utf-8?B?SVVYMWdoeGNRaGFCSWF4SCtGcEd2K1EreTh5QUhZUk00VDhJMWtYWVR2RU9G?= =?utf-8?B?aFVYeVZsMVdJNWdVeUtoaUlTejN3aFd1d1o4YlNTcjllWWFXOUxWNG5HdGJ5?= =?utf-8?B?YzE4OW9SdFFsTHJzZ01xS2toWEhuTmZTQU11c3JIWno5QVl4eWd5ZnlYSVV0?= =?utf-8?B?KzhUT0lHK3hEKzVQSGlxVW1BSjZNYTVycmtCQzBaejNKN20yM29namVNRlB4?= =?utf-8?B?dFBuQjNyREIvWTAvRVlLWGoyTUoxOWwrak96dUphUzZIMTkxeEp6N3ZHVW1O?= =?utf-8?B?MDAxWTdYZDFleWJqWWF0ODZGS2x4aVpIL0M2WTNpdVZFMTQxKzJlKzhjbkRa?= =?utf-8?B?Y3Rnd3BqeXVjYlVSWEFMSVhpZVQrbnp2VmxSSGFNbElLbmFydzdDM2tWcmxN?= =?utf-8?B?YU40aUg0RkcxNHptMzVibGZXekRSU2pRVjY3ZDBXcHlhZFljRUJXOE9Gekxs?= =?utf-8?B?NS9qM0NBVEYxNGYrSWZBTnpwZmorQkZwck5rZmprbXg3ZmRNdGxTRHpjT3R0?= =?utf-8?B?TkltcE9sNmd0SnVpMDVvcFZNWlI5NHplbmNuWHNjZnF3R0lMVHJ2OTF3VjBJ?= =?utf-8?B?VTBiVjBWZFZNR3FxOXRhaEQ0VW5wK1J3ZXE3UjVJZXAzVHFPSTdpMHZvUUV1?= =?utf-8?B?TXVMVS9DZ2g0MHFpamhxL0MyYlRnaXNQMHc3TjYzbFdUdnpTVzJMVGlXVDRj?= =?utf-8?B?b1BPbW95bEl5QkhQV3YramNocmljQ2t6VjlJNTlyTkFNQVFpUlNZbExVcERv?= =?utf-8?B?OEJIYkxCU3ZscXdWOGZkR3lYekRFaXA1MjhrL3ZZVVdVZnhSbm1La2s2R3ly?= =?utf-8?B?dzZ6WEZRYWRLVVJCeEw1WnFFQ3N4Qm1RZUpselVtOGY5dGgrY1dtZjdmazZo?= =?utf-8?B?T1lUYWVqQTlmVHdTOVdMMFNzcFBTZFZ1SHpWNFRua0dGN01FTlBQTHFUUEZ1?= =?utf-8?B?MG5UNExCRi92SUtocC91ZlJ4N2NhZUZZTUdIRmVFSnBDa2g2RUREZmtmenFO?= =?utf-8?B?aGxkQXdEaldneG9qZEl3RExDTlllQTJ3Skx1RDFzZkdqTXRNelRjU2dwWHZ4?= =?utf-8?B?WU5aRGVVdW9RWHZqVXprbjNkNVNHWXFsdjVNamQ4bWRHZUsvVElzdFFOSmJR?= =?utf-8?B?UG90cVF5OGYwLzB3L3p4WWRuS1pEclkwR0tiajAzTDEyQjlOYUhmK0JVNklT?= =?utf-8?B?aVNHdWprZFdkOURrbHVkZGRxTGo4VmdwaVR3MzRUbmM4UjFzMHdrWmZWa3NL?= =?utf-8?B?MENFV3ZQOWRlcTFmaVhYS1J4V0xyU1pFeEs0S1FibWpZRXBQRHY2K0kvemxF?= =?utf-8?B?alJXelBlT0VyUUM1UFpka3FpQVJKODVHV0xmam9UQitDRjUyYTlOYmVWM1lh?= =?utf-8?B?OE1zT3loWmp5Y21CTXFIdUkxTGpTMFlTQjRvN0hNcTFseEh1UWladldIVHBQ?= =?utf-8?B?d3V6YjNacWJsVmx4UStiMmUzT3g2Y2h2aWwxMlhHUnpEVXhBOG9KVmpMeXpq?= =?utf-8?B?YWxaU3J1VlZtbHpGbFZvMjdoR1QzL1ZGaHRKUHdneUlmem5iNDA0cWVVdzNu?= =?utf-8?B?ZmtYS3VxZ0lWcm9qVkxnTTE0UTdwYVpiQ2VqcFo5b1QwU1NZM010U1hBTDJj?= =?utf-8?B?bS96b2NTY21HZi9pcHNMZmNkdmNsd0pvcTVLN01EWXZ1TFQ1RS9aS1d0YlY4?= =?utf-8?B?dzNtWTVJemZpV0dXSFRJSGdTT083SDZCd0dwWGIzOTNjN2ROZUh6VEsybWlG?= =?utf-8?B?bEpvR0E0VUh6ajhkd0VOcHNKSWZQTFNlcUFoREhwdktCcjRWQVBkbWp3MEFB?= =?utf-8?Q?/2n3druuTssajbpCSgsOzDhq0?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25ea594a-86d7-4a37-98b3-08de1ce4f6a3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:25.1548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oPRJk8w+FKuM4BI5CiQ5Rid2f8ECVRznFJN2ov/UYUOqDWo1tte9nBCqD83Yaku+ATFqPnE5g15B9ByHSDEaxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Move the imx_dsp_rproc_dcfg structure definitions closer to imx_dsp_rproc_of_match to prepare for adding start/stop/detect_mode ops for each i.MX variant. Avoids the need to declare function prototypes such as 'static int imx_dsp_rproc_mbox_init(struct imx_dsp_rproc *priv)' at the beginning of the file, improving code organization and readability. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 100 ++++++++++++++++++---------------= ---- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 833b1bd4019614157f0bedf09bd348caab802eef..f28d25cab3f1d89e5cde37a04b5= 28870a59abeed 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -261,56 +261,6 @@ static int imx8ulp_dsp_reset(struct imx_dsp_rproc *pri= v) return 0; } =20 -/* Specific configuration for i.MX8MP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { - .att =3D imx_dsp_rproc_att_imx8mp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8mp, - .reset =3D imx8mp_dsp_reset, -}; - -/* Specific configuration for i.MX8ULP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { - .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, - .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .src_start =3D 0, - .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .att =3D imx_dsp_rproc_att_imx8ulp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8ulp, - .reset =3D imx8ulp_dsp_reset, -}; - -/* Specific configuration for i.MX8QXP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { - .att =3D imx_dsp_rproc_att_imx8qxp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qxp, -}; - -/* Specific configuration for i.MX8QM */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { - .att =3D imx_dsp_rproc_att_imx8qm, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qm, -}; - static int imx_dsp_rproc_ready(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1351,6 +1301,56 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +/* Specific configuration for i.MX8MP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { + .att =3D imx_dsp_rproc_att_imx8mp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), + .method =3D IMX_RPROC_RESET_CONTROLLER, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8mp, + .reset =3D imx8mp_dsp_reset, +}; + +/* Specific configuration for i.MX8ULP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { + .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, + .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .src_start =3D 0, + .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .att =3D imx_dsp_rproc_att_imx8ulp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), + .method =3D IMX_RPROC_MMIO, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8ulp, + .reset =3D imx8ulp_dsp_reset, +}; + +/* Specific configuration for i.MX8QXP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { + .att =3D imx_dsp_rproc_att_imx8qxp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qxp, +}; + +/* Specific configuration for i.MX8QM */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { + .att =3D imx_dsp_rproc_att_imx8qm, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qm, +}; + static const struct of_device_id imx_dsp_rproc_of_match[] =3D { { .compatible =3D "fsl,imx8qxp-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= xp }, { .compatible =3D "fsl,imx8qm-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= m }, --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013007.outbound.protection.outlook.com [52.101.83.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FB702E06D2; Thu, 6 Nov 2025 03:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399895; cv=fail; b=levxyL/j/5lTZ4Z/4fJ275e0Giu03o1RAUmQE8sk9g4nA4i4DWVNTZ4wXVudQ7F7H1vS4xHfSSyhsK8Ya+TZ+q/1wMsq+AdXFTicagee4yP6a9PKsnm76kVEwPreRBZUsZjOCZB5CQxYE+1zGkoyJ8hzti4HfZcEWKMGupARfvE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399895; c=relaxed/simple; bh=Kfgs/vF82eWV1bNh0E+Y7nXzmmVLX4GlUMjPOkJRabk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Qg25yFp/RUCrfiEbYEfIdpYrb/nSkNr4uJXnik9Cl6ICyYlMckhD/eASAIp9lIPcQ1eWgeZw0mjTJhxJCthm/RQ8ZMYAUhaCD+X4QAO6bVbcoI41OvdRDsMyC7sAibE3HZYY82Qk9LsBq43XT3tfceofrdFNLrElvq68dTTBbhg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=DT172/GJ; arc=fail smtp.client-ip=52.101.83.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="DT172/GJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E85EkrPWyxTQiRt4eD4ydUL/2rpQAftVyKEynDc4HoIePtMebaElamEpqcbOI8Js5Ycovfwtuu00ePprRRtRXCgOoaQ3ECKi7bp7fDWfJkpHagmCTkS8Z6xwJlAMRCUZTv6LGRRWH6OgtCRke26wCi+S1DtvEnwGzJIaqzig3vOcqDcai6oGyZBHx4EPaUyra5ogfInGpAxysmsYKGt5nL1nk6WDVBjqjaaotlJt9LoNqpK99ThvGfCZDrukDvp4c0Z/ORNkRmyTu46dWwshyyhRGOP0CZdjr1K5BhJ9B7kV39TC9LYV36Bc2qU5h0iRGBkwOtBmtHp+njJhRI4YiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJQRzwyv9hGdcFinz3mJ/IkcxW6QFlg69+WbpJe0g9o=; b=hKm6hSgoUktkRer3h9XtVzfC6pZAQm9TjnAs327mec3e3GGN2VpyW3JgelfRFDY6u5ALSkwMa7oXOzMDkOFL1X9z5vLw+ZHePIVAINnRhKI820d3RArt0TsNCQLXwzQpNBOWtsHcEJ+RhnoXTvsXhWf6Du7KO1mrBMYgzS18J9Ml0GkIkeTu8FgSnOFRiSMTMazO4KT8MglfXgAHeFW0ZC3JOEiQp2Xdx35kAoTjzRUgZO4Ovhdp8NQgXC2QewnGT/nioP8OZabAqVlyaWpi0X7D66s/CL8wKRBPdAE9Z5QZodtR4/WDaOxyebrljipZDcTrFyuDFCqKO6IbdA+lWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJQRzwyv9hGdcFinz3mJ/IkcxW6QFlg69+WbpJe0g9o=; b=DT172/GJUaFPuy8gz3X/3FX6mUANSLuBYeCd7y5X8TATksrj0m/lZAk/zcvpNILHn4cDNLg6r1qrYkaObJL29U+hszV6mshzBPiOgVqRKcxhxKo9ARJ5w37z0SOdsOAXRpj4BRMFOel3GtH9il13zo9I8E6TTRx6BpudoV2r25iQ1cGHJ6qSr0yRX32yjfYHoNwDREYtv3u50De+5RVWqHsYlE/MnwsnbypLFyPaM8sDH6/mSLb6UzdQi5NVp4BqNgsoLjPv63i8ssHLOkQKa3hBLNAxYULUR5vK6krB0fAAUD058AOcNLwyFf9AfWnnL/pFVSCMvL3PIJmKXzuP+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:30 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:30 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:34 +0800 Subject: [PATCH 08/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-8-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=5452; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Kfgs/vF82eWV1bNh0E+Y7nXzmmVLX4GlUMjPOkJRabk=; b=Tp0YWMcFvS5m7XHo08CYkUe4JUf3ySBCBhdwpukkZ8Xsz7xq9VPoJpeGJKbyXfvcTGLv+kvrW KsXWfRMP82CC9CoUuq8Bw1NiKyaEPg3CdOlNxacB6wNMrjOucsn3viu X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: d67c66e6-1c1d-4616-2228-08de1ce4f9a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WFdpMUh1OHFoR3AvMEZIeGQ4bWhINXZRaDN3dFBpejZxSE1jbndYSmh2VExq?= =?utf-8?B?M2VjNURDbUxNOEhXKzlTWHpKZ1NmUkRyTnhqQVZUdWFJTkhhU0hQSnBYSzBV?= =?utf-8?B?T1FManIrK2tkbTEvWDV6UCtIVU5NSGxVd01aOTBwMU9xdC9sQ3k3VWZadmpX?= =?utf-8?B?aGtxdjN5SFVQV2RBTmpOVlFMVGlvUkh1UGZyZkxXc3pxOXA1OXFBWXZzS2F3?= =?utf-8?B?ZTNET3VpMTF1WFYwUEhtM2ZQU2ozRFdmZW9sOW0yVEtYcDE0cjhTMzdzNTY0?= =?utf-8?B?a0RCTVhQNnE0ekpoU0J3SHdRczNPRXBkeW1QOHVHUXkxZmJGRUJtcHhwVHBs?= =?utf-8?B?eDBNbis0akNuNVU5ZlpmdWoyYmNXTGdUNkhMY3lZR2QrRVZIa2pYTEtIWUNI?= =?utf-8?B?THo1b0ZqM1QxamdDZGtOUW5kMWFsUUsxaDhOMFNnbzJpVnR2YzRFblpqQW5m?= =?utf-8?B?M0I3NkFYMmlyamVsSUlHRVR6SFdLSG8yb3c5d1RVcmhOc0pCYUgwbmJYMmJR?= =?utf-8?B?eXovcW5VK0x4YXNKaFR1cXFNejhKbTAwdXZkZ2t3S0JLUmlmdUU0M0ZsK2VY?= =?utf-8?B?RUtER1FvZERhVEpacHV6a0gwMjF3Ym8zaXlOVjExQkQwa3FLQ0ZwazVVMkdu?= =?utf-8?B?d3d1VExxQ3dXaXZsUEFFKzBnaGdCTE5qQ29qQWc4aFRSWGpydkxsUkE2cjBk?= =?utf-8?B?cHF2YTFzVWhyckJJOGFkZSs4MW84VjgzUnpiekNsbng0a3F2cVpsb0FXdW9v?= =?utf-8?B?WUdwd3AzaHR0eEtOczJTaklOazJNMlllNFBWdlRSRm1jMHd4QVZRL0NpbWor?= =?utf-8?B?dEtDbkNPZndES3ZqY3hSWGlJU1FwS0xuNC9qZHBEeDZpcEdGWm1HL1hFTDdl?= =?utf-8?B?cHZZWHhXS0JLcDRwTU0vZEhUN0xjaklKd1F3ZHQwa09CdGI5RER6NVZmNytw?= =?utf-8?B?Qi85RGN4a1pqSGtKMC83eG5NSWpTTUV1Y1h2dU5GWjVSdkdtcEV0Z2RFSGJV?= =?utf-8?B?YzJOSHNHL2I5Mlpha1JFbklUNllZb3VKVEpNbnNsdkFZdXFsQ3FTMC9WNkZY?= =?utf-8?B?S2ZubFdRWFZEWlYrNXFJUE9mb2JwaUtpSkU1VHhySkVDZ1RIeDBhblVkRk92?= =?utf-8?B?dkJyU1NTWGNQcW10TjFlbWhIRnFiMEdxQXh3K1hKSVQxQTMzMkdBdjlsOTJn?= =?utf-8?B?T21EdlJWOTNWTVJmUGxPZzRTQWI2QzVwZEdvNk9tcm1CN3M1aGUrNVBNRjV2?= =?utf-8?B?QWVUVndSUXJWSjJKS0w4cHpqVldPbGdmOURPU29BTEJhVW5YSk9pYmgrUm8r?= =?utf-8?B?SXQyVlJMSFY2MXFFWXU2SFM5RmtPOUs0TS9LOGpGTWJDbGtyNW1XdDByUnVR?= =?utf-8?B?Q0RqckJHVG5ENkg1YnVRSnJPREVNRldLTnQ2RVVYTkRuWE9LUkM5ZUlrZnNw?= =?utf-8?B?MzNlMEFMWmJjdGwwVHAvNVU4Yk1GcXg1S1grbnJzdjArQ3pYZkc2ZWt0eFFk?= =?utf-8?B?ZHBRUEtLN2diNDJHZ21MczN2UU03bnFMeXczdDdLK01rTjNuMW1RYUQ1RHVF?= =?utf-8?B?a21QM25TQmllalEyTzZnVVFXbUtYUUt6bGdyR1o1QzlyMUc2amwrdXRYdi9V?= =?utf-8?B?dXlySnRZcXlPZ2lsT0NOZnB2ZFZWOFVEdUJoK25sUm9EdUo4aFJvTmRhM0xB?= =?utf-8?B?N1ZwZHpMS29kMU1yL1hnMU8vTTZZcjlqb3gwTE9GeEJhSUVwTEF3TFM3eG1r?= =?utf-8?B?QzI2TUNvdlp0S3ZFOTllZ1lyZzQrVUtOL3oxakFTWGtzMXdOZm9RQTI3RGFy?= =?utf-8?B?aGc5WjlyT3B3V3ByMDIzV2UvWTBMc1o3TWxtV0FlRnhkb1RuSjBlZDU0b2xF?= =?utf-8?B?bHI5WVFJRGEzU1hZSlRSSm1UeEU0Z3gyL0xKbC9LVVN0WWZrUGlDendMczNU?= =?utf-8?B?VERzbGVBNWZxM09KZXh4QkQwazlETUpraytEaVVHd3p0dkFhTzk4MEwreXBj?= =?utf-8?B?cm9uZGJqUGNpYUpzZEl2M3hRZmk1NytmZ3ZRODlTNzVpczN1b2s4TFZ6UG10?= =?utf-8?B?ZTJKMFdlNGZ3NEl6VnBqNlZXT1MzdUtsd1FQZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWhDOUNpM0xrQnNkUWlmZWtvV0FnNkQwRktlQnJtZ2lVb1oxbng2ZFhaaTRy?= =?utf-8?B?VmpWZFYwTkRxdDIrajFqcFg2NTVBMGpXdDZ4SzJZZitpMzNxTWxKN3FGRWlQ?= =?utf-8?B?VXo5eGUvM2I0elRHSHdibmtFd211NWlPZDJZc2I4Mmk4S1RtSHVzOVdZYjh0?= =?utf-8?B?dDVMR3d1UUdMNHZzOTFUaWVPaXFwV1MvZ3RUbXdLUHFONFl4WHI3dDBvQ0RF?= =?utf-8?B?dlFzbG85K1FqVE1WYjJ5eHhQSUZBd0EzMnJFb0Frb3JRSklpTSt6N2xJR2Vt?= =?utf-8?B?eUl5Y2hwOExheVZWT0JEZDRyOWlnV1JzMlZvUFRVRkU3Rmt6V3lvK1hUR0M0?= =?utf-8?B?ZUxWZmR6WjgwTFQ2OVoyV2ZFUnZSdlIxZHJEUmlaaDJZb1JLaE15bGZTN09n?= =?utf-8?B?SkJQQUk5NXFuWXlEbVJDQVZUeEtFUUVweVV6bzMrMExsaW5RZEt1bjRmV2hG?= =?utf-8?B?YnBuc2w4NWxINGxENEllOVJIT1Fab3dMY0ZNdktFREFxblU5a08reTdDNVBC?= =?utf-8?B?R1BacWhIOU9hMEFqTnlNdWZKK01FZVI4Qk9RYndUSXFvZUdvTFNNV1JRbk9H?= =?utf-8?B?OE9SOGNad1BLVFdJa3Ryb2FuQUkwdXpjVlJzRHU2c2MwUjdFbllLekdqQlNa?= =?utf-8?B?REFPcSt2Um11OEZwYU43VlN0YzJ3VnFDTVczUVh4MkNOTXVkWHRQWHpHV1da?= =?utf-8?B?Y0pBK0ZET1o4RlJkc2ZwMUhVdGZPM2VtWFhpY2J1d05NTmM4NXdIa20xd0RF?= =?utf-8?B?ellTUUdKNE5UN21sMnJEVFFKdjZMd2hBL0t3RHNqSVhOdXN2TUJjTTB1SExH?= =?utf-8?B?UkNNVURPdzhoNDArbjJxdjJsanludHRzNERkbjRKNVFjZC9EbDlFQmVIVnZP?= =?utf-8?B?NDhSNHRZaWh2YjdSNkJoT2duRWJvNVFhUmpYUHFnQW9lZ3FrTVVqQjkxRXZv?= =?utf-8?B?aHpzV2E5V3BPMDlMbzA5cGplMnhHdnM0eDNMVXZzMTJBSTU1Z0krcFpteFd0?= =?utf-8?B?S0dqUFYxK0RXYmxNb0hVYnA0K3lsZDU2YlNXdVM4QnJzYU5RYkoyaUtGdHIv?= =?utf-8?B?OUZjYW8wSlZEc0kvVVhxb1pPWjBCOGRod25lQWNZbGkyM1JJTlJPbkd6eGtO?= =?utf-8?B?RTdyWHI0YTBYVjBxUlgzQy9QdytPT1JCdEdrMXdjYUtRaVByTy9QUUdYakdq?= =?utf-8?B?MlpBN05zTlNtZHBSdGZFZ211c0krbVBFLzlIdmdoV0FHaVRFaS9EWU9lMmVl?= =?utf-8?B?Zk95M1VWa1NkMjFIUFZiZ3BSc3g3VmVZa3BqVkEvMjQ0RTlrSXAzMk50NENl?= =?utf-8?B?N1JZcmNTd1UwUC9xaHFYamdmWWtDOEdhUGhwZzV0MlppejJHSFdjdEdHUERY?= =?utf-8?B?cWNibExISUZQQWJQaDJNdzA2Y05LeWtlVWsvYnQxS3BQRzJiMFVqZ2FiT2JQ?= =?utf-8?B?YXJBSUxoL1NwdjFrbTJEQm1FSU1ZamM3SDBhVlNVMmJkc01sbjRSSnpXMjhV?= =?utf-8?B?b3BCMFZ3bm9IazBnSWIwZjliUHdRbDRGakduK2ljTTJWMTdjSmRmUFJ6bEtI?= =?utf-8?B?Z1pYYjlxbzNTc3JvTkhLTGQ3QW9WbTZjWDA1aHdXcTdyWXA4L09TdmNBQUZE?= =?utf-8?B?b3Y4KzRyK2s1QVA2VUhVZHFoZXhxdDZqdHZ1TkY5TWNTeVgySnpENG8yditt?= =?utf-8?B?eUp5cStPc29CbzNwZmN3Q2FnZUpzZVJBR3BuendNdlRtVGdLRmtSWTJxLzMy?= =?utf-8?B?Qk00elcvNDEzcThXMkw2bUNZQ0piRktwZk5zSXpYT3VlNkJWcmNOYzVlKzVH?= =?utf-8?B?dDFyMkw4Tndtdm11eTBFUXlnNXdmZUJmWGVWcGpQdHdmK21ob3Q0bGo0STFu?= =?utf-8?B?b1liSmlRRkMyWnBCaFhtNHViRENYczdqR3ltM2FKNXRBRzVsaUhWbkVIbC8w?= =?utf-8?B?d2t4TTRWMzRZeTFyK3RSdk5jL05tUDdNRnVnd3M1czY2V2N2dU9UVFVmczdU?= =?utf-8?B?TC9nTkk4bEtqaThHbXJmM0pwVnZtMFo1ak9VRTg4ZENVVmNGSkJFblEvcVlv?= =?utf-8?B?c0p4QzdGWjFINFFMMmM1NEhlRk9ObnMzSTJkS1pPMlZNcGg2YjNYbVVTVGw1?= =?utf-8?Q?8X9Jcs0JXSqnSQzHbOxJHSP40?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d67c66e6-1c1d-4616-2228-08de1ce4f9a1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:30.1914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KkaY2drf+fVlf6geF+go/3dYdB/WLCS4de7SY5l9C9iROEJAbd6KHPk0q21ouTXVGMN74nDneMEkPBWhtUNtfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Introduce imx_dsp_rproc_mmio_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_MMIO to manage remote processors. Allows the removal of the IMX_RPROC_MMIO switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan Reviewed-by: Frank Li --- drivers/remoteproc/imx_dsp_rproc.c | 61 +++++++++++++++++++++++++---------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 40 insertions(+), 23 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f28d25cab3f1d89e5cde37a04b528870a59abeed..71776816c3508a86bf7b8a09ac4= 5827a83a7bb3a 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -338,6 +338,14 @@ static int imx_dsp_rproc_handle_rsc(struct rproc *rpro= c, u32 rsc_type, return RSC_HANDLED; } =20 +static int imx_dsp_rproc_mmio_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); +} + /* * Start function for rproc_ops * @@ -360,12 +368,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, - dcfg->src_reg, - dcfg->src_mask, - dcfg->src_start); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -388,6 +390,14 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return ret; } =20 +static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -411,10 +421,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, - dcfg->src_stop); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -1032,6 +1038,23 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp_= rproc *priv) return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 +static int imx_dsp_rproc_mmio_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + struct regmap *regmap; + + regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); + if (IS_ERR(regmap)) { + dev_err(dev, "failed to find syscon\n"); + return PTR_ERR(regmap); + } + + priv->regmap =3D regmap; + + return 0; +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1049,7 +1072,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_r= proc *priv) const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; - struct regmap *regmap; int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) @@ -1061,15 +1083,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) if (ret) return ret; break; - case IMX_RPROC_MMIO: - regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); - if (IS_ERR(regmap)) { - dev_err(dev, "failed to find syscon\n"); - return PTR_ERR(regmap); - } - - priv->regmap =3D regmap; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1301,6 +1314,12 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_mmio =3D { + .start =3D imx_dsp_rproc_mmio_start, + .stop =3D imx_dsp_rproc_mmio_stop, + .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1321,7 +1340,7 @@ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8= ulp =3D { .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, .att =3D imx_dsp_rproc_att_imx8ulp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, + .ops =3D &imx_dsp_rproc_ops_mmio, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index aeed08bdfb5619c7afd7201589f417cfd6745818..912827c39c0dedeed76c13740ef= d42a8e7cf9c45 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -18,8 +18,6 @@ struct imx_rproc_att { /* Remote core start/stop method */ enum imx_rproc_method { IMX_RPROC_NONE, - /* Through syscon regmap */ - IMX_RPROC_MMIO, /* Through ARM SMCCC */ IMX_RPROC_SMC, /* Through System Control Unit API */ --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013068.outbound.protection.outlook.com [52.101.83.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E472E11DC; Thu, 6 Nov 2025 03:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399900; cv=fail; b=gx04coUY/D9lxXheNhsglHrAYneXkw5BXvLpOdomzoQ5vYyWhXWVIqk0Ux0Yfinp5ba8/JGpFisK7iaAsJWMRpG6tB4CY1xbWsCZ21ad1wFZgNEQykodgZF5adU8AP7R3spfW2Rv8c6OVDIC+0MeJp1/v6dBPGtyW5aQ47O2UyE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399900; c=relaxed/simple; bh=UUV00BYdhRV1PEUA3QZZOPpCC1TvitSqxib8CVTFrHs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Am5b6oR5T+wD0d0dXaZS15OBJUWfrsKE05XqCktJyHNMWyL0+Isf1TcW8c4r6xdOkBFnpPZc7gEY2znLoDPRm8dh6Kmg8cHpcmQRUnTzb/XeBVLZGedjxrTyRWxjaWLy+qvAXFApX9EMm11PCpscE3iP20lNszZ9Pgsa87w8Pkg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BuwuIjo7; arc=fail smtp.client-ip=52.101.83.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BuwuIjo7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=genSdfVnpy6tNACRX7JIy6dDPJn1aO5up3UQ7QgrMr/L7BZQYlfSnpJgDXoMPgDrnjeAsEv0yno9dVUm3rtu5GAD2xZqmgX8X1CmW+vadoHIvLw/9a6gTNkze+3k1Cee7ZU3QfZbGoR5mZusJnSEIR00jKnnzl2upTEH7Pw2LWlG7xUT5fhSyXq1JKDaHRx35dNW+5FCEhMAw561+dB1dl3PIzCsyfF1MqIQfzwFXZd9FyRoi9lMbzSYMFUAQ+er+eV5NNmp7NAK7Cohaw4OVVIoGKSjLVeeSqiqrgGmrba0xfCXzwZ0+LSyBWueSYN7Gx51Eckpx9XCqjbMOND/nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XWTD8AckO0Y0UdMiPuVIHGFXxeNt19QlUXtWl8P6cQ=; b=ANcSMbfUCC+vig98pwF2X1ZwP2eCax0kMSe0zcwoZV7u0UfvEiReFWKWrc7Clrc3elPWzDew4nLIVXVpG2elE70Zn0bcnFK2N4pBn6257lVCD+MSdxcp1gPwxgkRyRt/FTbDQqUk+C5OUpC5ykVu6jaf1Is/6zT/gvlLCbdg4KPQ32Dupl37Ae2ITX+WNSorvhPa2VeJuazQZh0/5MP9zZYs23n3bNEdBxCvx+4sO6X/94kdmBb+ICrPj9rfoYUbGqBed875k/TujHolxLQihs7tfwvhYR/g2pZJ3po6CUkGw9QDOqejTG/0eT/DHI3nYSCmiktUOikS1AKzNKO74g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XWTD8AckO0Y0UdMiPuVIHGFXxeNt19QlUXtWl8P6cQ=; b=BuwuIjo7ZGZ39dYDHdKTz+di+eNVcUStKFFcbSAodwgAxdkGKmXZHKINMtdV+uKPGlDqRoxlfAf63kvb95izNqAWujSnYQgdS/WbwCe1hO9uMg1GCXJpwI/T6c/Uqc74LsRZiCaG1JqYPpupbTo+8z8Zd5Ho66fHwCa/jUpihmxL1noxYhsaTVX/gDuilikUsgBvLKSRUyd79YwWhhEkPIMnTUYnPNpRCa/WPp5kBb8ufKVkfmzshNISkml8ipFSPFJ89lYbI4/a2S1l19gXY9qCal2Xb9Xalx73M94rcT0tPmBKeACc2cZUcGfqjAsYxm6HLHC/sMyV+T//WbjLdA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:35 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:35 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:35 +0800 Subject: [PATCH 09/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-9-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=5217; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=UUV00BYdhRV1PEUA3QZZOPpCC1TvitSqxib8CVTFrHs=; b=vt7+FXRWXtJ1dBCnaGF/SzmYM+FjH5aTNYCEozcJQtlCrihKimlYip+HH35l/iwiPN/SZCZ4e Oy2Mc9tSyaSDFeHSX2OAF/zNc7CYkYXqWbBNYmSm9SnH9U0JRTNbGC5 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: 9927915e-d3e1-41ae-e0f0-08de1ce4fcad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SDRUVURDTWdoMHE1OUxZeVpBckFvOWE4UjRwaHl4RzNtRytCNW5XN0NMVEo4?= =?utf-8?B?Y0Fsc3BnOEkyM0kzM25lY0lvamRhZFdqZVA0RjNqbWxyTkllMC9oTm15Vkk1?= =?utf-8?B?ZVFTWllaVFVXQW1ucFdyMU54RU5TMmtncWpWL3JXQ2VwZ3dwZ0E4Z3ltUTJW?= =?utf-8?B?V1VQNVB6MGc2cUZpWTZNQ3dGUFVGWFdEM2UxQnBvNk4rQmdaOExhVExWWDZj?= =?utf-8?B?S1lodWpvcjR6amZGenFVYjN3MEdXOXpheHFVUEh3ZXp4RWxIL0QxMjhEd280?= =?utf-8?B?UnZPRUhmVC9JN0hJYXl5TnhsYTNlUnRtNUYxM0k3RzEvRkI5N0piWlJrWWFZ?= =?utf-8?B?c2Y2RkFyb1FnQ09tZlFKUjRTQkJtT0tMWVdKZnVvYWl5Sm5YeCtuc0xKRmRs?= =?utf-8?B?bjlpUCtwelpRM3dSd3B0YUhJMGYxbVVFMmNVVlkrNWJwQzRvQ2ZqcS9BM2tC?= =?utf-8?B?WG16aUV5YmhyOVBrSEcyOGp4UkF6eG5VQkt0QllSZjUxUjFqVGhFMC85MUFE?= =?utf-8?B?N3k4UVNHMC96eDlyUmFleTU0UmphN0M3Q1RTb014djJNZjhaNVBEakswTk1i?= =?utf-8?B?ZkNLeXZHZDNCRkd0V0JSMThRY1hETS80cXRqdEFkR05adXZxdGZxVTFNelNp?= =?utf-8?B?eVUySWszVFBBSHJzUTV3TVJvdG1nZnF4S05JTmVQOExucllUWE83ZGlYa0dx?= =?utf-8?B?bC9CdEduN3pPMVJwSkh1ajJtblA0OFJWdEdpV05DSnVWQVpRZW5MNk82VUFh?= =?utf-8?B?YThBTVdXY3hXZzhMVnUvbHYwSlBjUXhmOHV5N0NiQjEwTElaeEVCMG9QR1c3?= =?utf-8?B?ejAzaEd6cllvSUVEa2xNWlExNVExR1JCMFB1ZTNoSjBKYk5BRUI5ZlN2eEUz?= =?utf-8?B?SlFncE9YSjlYYXA5b2J2U1EwOVYrcjRhWVVBdnJsaDRFRG5oU09PSkJoUEhW?= =?utf-8?B?VC9PVFREYTQ3dllJNUFJRE4rUmdMKzdHZUFPd3FJK25US0g5MTNjSW13K0ZP?= =?utf-8?B?ZWg5R0U4R2t3bTNJZGlHYXdTWng2ekZWcG5NZkFMc2l4MzQwckZCUTdOMVdU?= =?utf-8?B?UmpzeC9odmhHU2p3TEVnVTBBalZSZjE0TUdwY1plczFDeDlKZ3JZcCtyR25j?= =?utf-8?B?bitNbGVOVUt2TEpOR2QyMldzSUlGUjJhdFhZRnlzYys1NDBhdUtEbzB3bmpD?= =?utf-8?B?b2N3K0pBMVB0V2lwbitYSUJsQjVnUXE3RVJuQVYzNVNYMkhuUDJLbXlvbDVW?= =?utf-8?B?Ukp3STN5SXhUYTFhWEIzRVBYZmpLNVoweEtCUStWUDRQb1d2NEVtZWkzWm5m?= =?utf-8?B?bk9ON2d3TVd0YktsODFIalhjQS9ubVBNRXdVczBEWlVaRWZsSHUwaVlBaENn?= =?utf-8?B?Y1JoZmhOb2xBNlNpYkdVdEpyd25oczdEOG8vQm0wSFMxdDE0M0NzY1AzTVh5?= =?utf-8?B?bDJZcUhNeW1BMnZybWtqdmxjME54Sk1JMkpZelFVQUlpQ1pIZlFNdFc0VzVz?= =?utf-8?B?dkNLR1ltR2JqQ2NBaUkyZVNBQmdBdjJLcGg1dDZpQmY0TzhiUXZjbzVwQ0lB?= =?utf-8?B?Y2U1KzZBQ0RDa3RpZ3NKZEV2NEVBQWJadHF6eTJScWMyQnJpVFdzQTBqcDUy?= =?utf-8?B?SEt2d3hxbG0rRnczMUJEZ1lScEhhVnJEdXkzR1VMRkNLUnJOcVhxWXJ2aHpF?= =?utf-8?B?ZDBhYzRXNUNxWFNIa05aMm9kNjVieUl2alVxaWsrNHp3d0tVM09UbGYrNWdo?= =?utf-8?B?ZjlJYlowSDlPbFBMcmRtQ3VQdVBxZUFDenVYbkNzTWFHODF1RkRDRkRJa1Qz?= =?utf-8?B?dDA3a0lHMTRaeUxrWWV0cm4zK2MycmJTcG4rQ2tRZlRyQmRieGlTNy9Sb0Vz?= =?utf-8?B?bllpZkxRRWV4bWFkalAxS3BhMWsrMi83M1FobXR0ZG1SdFMrVGNjaWZRY3Qz?= =?utf-8?B?TzJ0d1Vra1ZTNzI5RGFhaTR4QmdvdVpmQytMYWFyV0JPM3lRNjZYRUljMUI3?= =?utf-8?B?MHJlazVSYXdtSTB4Zkx4VU1jamZBTnZOQ0NBMU5pUHFnRzhQclVGVFNXcjlt?= =?utf-8?B?cVExVUxaTm5aRHAvUmViMWk4bkd5K3l6VEdEdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dldkcWdlRzVjWG5kQXRBTjR3d2xkZHpJVkdzNDdKemtnOGRMKzdQMGlQek83?= =?utf-8?B?RjhKWkM2aFR2SlhvTUZkdTNtcmhXYnYxWE0ybnplUUI1RG1zcU94MXlrUjlX?= =?utf-8?B?eXR3MWRvbE5iSWJLcHNBb1M2UytONjVEUU5oVzY4VVE3NHl0RkJNWFJ0bUZC?= =?utf-8?B?ZHNhcVNlSFlCSnB1TTMzdTNrNWFWSUpIejhMNUlUSjJNZFFvMUdtT21TdWgv?= =?utf-8?B?NWY0VUsxQkM2bGwrci9jeXd3bmY0NXhjL1UvRUdJYk9VRVhUSERLVlRsQ0FH?= =?utf-8?B?bXlyaW5KZmF5ZkpVVWlkYWhvc1dNNFREb3RvYm9NbmJIZHU5NGh5K3RROGJ4?= =?utf-8?B?a3RTaWVxYzNZSGt4TVAyaWcwcnFXWmNoS1ROWkNyVTdzcG5rOXV5TmdUcHQx?= =?utf-8?B?TEZHTjFrQ3p5dmh1WldqQWFnL0R0aisybkFvd3lLOUwvZG5FTWRWQnByTnA4?= =?utf-8?B?MDdDVFFDckJaWTdRdE5uNmJTTnRlOWtwcU9mRWxNWGRIODNrZ3FOSEtHOU1T?= =?utf-8?B?ZDNSWit1UmVsWlRhWll2WDFka3ZraGNtaWNxV3Z5U3hnOEljRHpYTjdQdFNJ?= =?utf-8?B?aHNaMmZFR3drT2tFUTRhbEZjT3Y0RnM3M3E2SmFoMXJncmdiRHMxTXpzUHZ3?= =?utf-8?B?cVpNemluTEVlNzg3TFhMVnRNVFBhZ2dpSnhick0zNXp4bWd2bUlIY1hOUkQ1?= =?utf-8?B?SGtnWUUvNmhhRzc4eGR3OWh0ajFaQ1Vjd1NhaWJ3WlBGK21EcmppSEpVYjFW?= =?utf-8?B?OWRBZFVOMWFwTFcrNG9zdHp1WXZRL1NobWdHc1hjM2FDc3k4RUFmNGI4clBB?= =?utf-8?B?SVhjT0RkUmNwN2pSQSttZGQzWGU0bXJ3UnFwSUdpR29QMTFSakpUQjdEWEFq?= =?utf-8?B?TXR1TS9HVTVYTHVNZ09vdlU3RUZEUmkwWXNCanB6UEdwR3dlZ3F5R0p6b0Jq?= =?utf-8?B?dFpQdGlPWm5yOS9KcUJBVWlCejVlLzZNYk85MDlhRXNoNlhURmdYSFR6K1ZO?= =?utf-8?B?Y1NUSHJmblE3M3gzRVcyS3dUWlNhRXJKV1JBbHNyTUN3VkVFd241Ulp1Q1FL?= =?utf-8?B?SEY5WENwcklIcGhSZnF0OURRMk00WUhFV0hmMWx1MWZENWF3c3J6eDJxSmN1?= =?utf-8?B?cG1hMmViNktIemp2bHZPbWsvSFM5TUliMGh2ZzhwRzN5cnBjb3cxTm91M2ls?= =?utf-8?B?YURCR1VQY0R3dmpGb2swRk8wUTluOCtSYWI3L2FLaHhkcmtpWkF1c0d3QnlV?= =?utf-8?B?bFVHQ1BPNVJLVUVOemJ6ZE8wUlRqZXdIMHh6d0tIemVRT1F1cE5IOG1FcWJZ?= =?utf-8?B?eVRubTFPbk5SL2pjcXdNTEdZNGZiNkRmS3JwVy8zZFJwUWxsZzR5d1ZNLzhr?= =?utf-8?B?cUtWak1nd1JKcnJUSHNocVFuNEZNSWU0WlNuUW8xRVZzNDViaFNKWVpwZHdH?= =?utf-8?B?ckROR1hieGNwYVc2emhybVRkTzhoUGo4aHhHSXByMmJ5MmI5Q3g1T3d2c1pS?= =?utf-8?B?Z21MNXhPeWs3L2RiblF0Z3FpZmJYbkpBeEtTK040aytQWXFlNUpoUHgrMm9T?= =?utf-8?B?RUowSVZhUGVMQjRYaUplM2RIRzMyWXgyRFZhRDhPV1ExTFNFSUdiSEZVOHhL?= =?utf-8?B?QUJaanRYQmMzLytRZW5OL05wWFlTSDFMMkt6eUpCRUtPMjJKbXlhd1hSbWF3?= =?utf-8?B?allmenlFTTVpS3VLaTkxYzhOSUJDZzJrMy9VU3M0WEcwMkVCdzc1VHJUQndm?= =?utf-8?B?TzJzdWF6VHRUOEJGcXlUZEtGS0NhQ2tvVFRKUWxQbXhGdkJFN3RBK2dLT3Bq?= =?utf-8?B?Ry9SYnVxVnNnQnltR3NmRUk1L05Sellpa2graUJzbVliUkY0RGM3MmljRTZR?= =?utf-8?B?d20zY3FGTFlsSzRjWVo0NVk0Q3FGTXVTcnc2MnNNUjhCdnR1Ty9tZ1VicER4?= =?utf-8?B?MmpDZStNWWg4UnZEa0FBMGlDbWIvRDVaWXA5MUcvSTM0c0k2RVk0SDk3Yjhh?= =?utf-8?B?dU1DbGpaUGZmd05IV1dxUTl2aEY1VkJMVzVpUlk1cFN6dys0bmhlTTdra2Qw?= =?utf-8?B?bmxUOURqU1o2ZlVWMTlMVDJ1U0VSemQ4aERxWGdYU1pHU0JQbjVZaTcyTWJJ?= =?utf-8?Q?ffiv/yIGfmPCYooukv94wu0LD?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9927915e-d3e1-41ae-e0f0-08de1ce4fcad X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:35.3578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nDDojnwHqCftrgAT9cOJc7l6hnlcNSH0lcFFAg7PG+bi9pbCc+ImLpRMXE4KCf9/Tch2IESCyPitQDo1aoTj/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Introduce imx_dsp_rproc_scu_api_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_SCU_API to manage remote processors. Allows the removal of the IMX_RPROC_SCU_API switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 48 +++++++++++++++++++++++-----------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 71776816c3508a86bf7b8a09ac45827a83a7bb3a..91d041c15ac19f527f48c818942= 1f71fb7c9745e 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, true, rproc->b= ootaddr); +} + /* * Start function for rproc_ops * @@ -368,12 +375,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - true, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_deassert(priv->run_stall); break; @@ -398,6 +399,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, false, rproc->= bootaddr); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -421,12 +429,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - false, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_assert(priv->run_stall); break; @@ -1055,6 +1057,13 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_scu_get_handle(&priv->ipc_handle); +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1078,11 +1087,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) return dcfg->ops->detect_mode(priv->rproc); =20 switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_scu_get_handle(&priv->ipc_handle); - if (ret) - return ret; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1320,6 +1324,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { + .start =3D imx_dsp_rproc_scu_api_start, + .stop =3D imx_dsp_rproc_scu_api_stop, + .detect_mode =3D imx_dsp_rproc_scu_api_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1352,7 +1362,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8ulp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { .att =3D imx_dsp_rproc_att_imx8qxp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { @@ -1363,7 +1373,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8qxp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { .att =3D imx_dsp_rproc_att_imx8qm, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 912827c39c0dedeed76c13740efd42a8e7cf9c45..a6b4625e8be76c6eb6a5d8ef45e= b5f3aec5fe375 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through System Control Unit API */ - IMX_RPROC_SCU_API, /* Through Reset Controller API */ IMX_RPROC_RESET_CONTROLLER, }; --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013067.outbound.protection.outlook.com [52.101.83.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126982E5407; Thu, 6 Nov 2025 03:31:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399905; cv=fail; b=CwEyY7dV3UiAys+C53rd4zk3hUxXXBHha2cAy/T8YM+rbDp2zL9qA5xtgvxo1ZvTFovDoCBFjNWityxz11D0HtYF+VPFKo+ZuUn4LzfKUfuQt1yY4LcK1p3XmD92vwPdSY/odzkCQyKAr9th+2lzL2oB/h/gWV7GqthcLRkNIUU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399905; c=relaxed/simple; bh=H1ZhkDk4Tk2E1SaXT47Xny1BX/Nwutje4gk1jOz/Whs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=KADP4nLvsDkzxXWcdXCaIWJBrTqQMoXdWLrV0K8bNnhezt5s85kIFybvSTqYhiaHLfrWO0EXLXSMDKMpJHHebO2VDpTtHQNMenuxbgCR/+PqxPkKLPiQPTVh2eegVKqnxd5trmOHDpvQsYTFNjZKRr9KqLpeOG6MR6VuVCEDS9I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=KIs5IqWZ; arc=fail smtp.client-ip=52.101.83.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="KIs5IqWZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zFyPlIeOFS67zw5feeCun2dJcMx15a65poC1CjnagYD3hf4vvCKvdXGqgX1NAiRt96WZw5Qq4S5zEpVOR0Lzy5MAyDaiKnZ0ktN7fBZ/sud4xrIXfGjJoMxrcjigccmugsgEKL/9VjDJXl81xDouV+XSUKx4F2KgUXLA8kNNraOqx6EnHWGheafD7NKatRZj0BzgOozZPWLOwBomY6kj97ukZ/RJWbbBCfV4WSwuW0z0FYj9Qw7cnohDCd2CN9MHx0FpTjJWASa/mIoI2DF1+TMTlF/oPurCOSEr38U3sK9NUoeaj4B7zpzpB2cV1CGiU6meH2YaOc9gE8r89gVvqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HLlnU+4jk0CusejujmbrSBdKGICMd53A0UMZL60F7UQ=; b=u2hTm7+nwzlIiYz+ieCClQlyR4Wrw8ScztviCzIkjHWhxKYGiKhcfWR0y/7CFNFkODBObnLs7lVEIG1ihIAQLc7pWs64qTLeeaUCMeYC866DuLjTaYoKGjYRD6N298SHL0ZyAzk+qScdd6vX7uyyjWR+tIhCg4mzI109feM3f3wKtWuzSWzpH/TGRNE0BD8HnE4sTDHhK1/f+vB5OVrIp9Zl3WZHYLnScCxq7AkWf4F1DtFN/LLmTTzLjJMheo/Cu7jD+tavBWkO3RB3Z4mo/krIkIYupDCHsuP9Mi/6cKVFI5Pxp9G2wbzZMUKT4MsoR9JCMm940Lm2TjC0btC4KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HLlnU+4jk0CusejujmbrSBdKGICMd53A0UMZL60F7UQ=; b=KIs5IqWZfUIh79tscsfmr9otK29kUYnFdkP33kdDiutE52cxGtsTfnvKRCEQHYNdTii33c4lOkZV1BD1Z+IcxYq86iA3YhrDflB8t47LcakUtYqL+ckPo4c9DxA6b6MUXeNYVrBG9K7ZX7Nn5LTeOV6V9yvhra6Ke67oMNJSJuM1i2jfkuydWuMAP/os5czRHjjJzNFitkOfcsNEYvkba32I7EU45me5iGItl6BLviuC4oTMX00EeArHMVpirNVRvLrcZ7SX04yYsvJuhunoRd3+inzgG73mv5yh75DlPqIC4dhQPRcKfBvD+OiyzVUZmibWeo9GjVy3TgGlP5FSNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:40 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:40 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:36 +0800 Subject: [PATCH 10/11] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-10-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=5427; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=H1ZhkDk4Tk2E1SaXT47Xny1BX/Nwutje4gk1jOz/Whs=; b=tCSum5g07h0195CSOzZl39miEEgeEZr/YUs0zzZfJXObPsp2rs1XyYTec0rEJcUW3tbMvvgs7 +wvEPMwS/B/DLttWKpCS7qkoMrD2Xfwxt59Iez4Wr5ZOz039iTmgRdu X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: d782d156-a706-4c09-3e73-08de1ce4ffc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WlpTZzVJQVM3bHNicUE1aUo4NHRyYVgwZktNVk1yUXFFVFlPeVBsQmd0UmFl?= =?utf-8?B?OXZNWFdYYjFSQXczSjRVMWVqZUZkWkFtdFBUenN0dWdCWUo5b1A2SVNGdXpl?= =?utf-8?B?N0hsQXloem12bzAvMmNiUk9yWm9MaG9PUmw2VWQwSXRtR1ZLdE02dlhndTBK?= =?utf-8?B?S3RmcFY3RlBEY1FUWXVURUl5aXZkR1RsTmJqem1EOWV3YnpyQmZDdUo4a241?= =?utf-8?B?Zm1YcFFTdmFlWEFKSlo3Sk1BRk9aZjc1a28yZmtnRnVKLzljSjVhblNhMnI2?= =?utf-8?B?dHhIcjFWN3oreDQzR3V1WUtsTlFWSkdCcHJ2V0lSWEcvSzViOW5UUDltalRR?= =?utf-8?B?NXhjbVlzaHNiODkreitNUS90c1dLclpyZHJiUTkzVHFwLzFzeld6dG43TUpV?= =?utf-8?B?WE9ha3pKelRCVTk5eDREb1EyNXZQRHJRN1ZQNCtheS81ampYMHhMMHZBSzRG?= =?utf-8?B?YmpNUUZzN1M3U2oxa2FlTDBNcnF1bTV4ZUd3OFRhNGlBd0liOXBkaUNYR080?= =?utf-8?B?MG5LbWp3YjBhYXZZTUNLTGgrbnRnc0lKU1NPMHVLOTFDSmRWQTMwVFpJZHMv?= =?utf-8?B?SDR5RzBxajdidHQwV1BiTUI5QkNzRUJ3NWc5d0g5anU4eEhnTm93eGJEaFFN?= =?utf-8?B?S1A0eUZpSGhiVVdGM0FYUE55ZFM5Y2I2dGJ0TThSMTMwQmRBZWtabW1Idi9l?= =?utf-8?B?YkRSY3QvNHgwcS91Qit3NXFyOEV3ck5Ed1E3aW55MWtiTVBTUi9WNmNUNExr?= =?utf-8?B?N0lkNCtkaXIzcUxUQ3BCUWFSU2RxbkVxSUNSU3M2b2l0VnVpTmxXMkVkOUdL?= =?utf-8?B?T2ZVQTFkTjRqUnBWeVhKSER5OWZLQTEvVmFlZElrOWhORHJ4MytHVUhCL1Jx?= =?utf-8?B?ODQrV3RPTWUzK1MyZ0VYWW0zNlBDZys2MzNEeUhiOGpyVDR1ZkhvY3RZQ0tB?= =?utf-8?B?YUFkSXZybFU0SGhvV3VpWit5ZjRmYzVVWFViSTZMM3lVZ0laQlpxRmgzMkRt?= =?utf-8?B?ZXhuZ2hlWHZrUUtZQUtUcXpvQnI3QU5TL0p5bnFteDRmVVVGWDZPaDJoV2Ux?= =?utf-8?B?dE4zUlRWTjNUaTdIcWtiZ3BHdm1NSnZrTVdyQ0NWK0FUQ0FzenZZKzBYVnpW?= =?utf-8?B?Z2p2ZWpMc0JmblZ5bVhlQnA0VFU4b3dkdWh2eXNrdEVEOStFVnpEdnBJM1Fw?= =?utf-8?B?alhtWXRwVG9aNldNZWNneFdsamNlNkxzNzh3dlJjckZqeDZkRUowWHhVWDlW?= =?utf-8?B?MGdFb2hGbE1PQTk0QzRza1NqWndlOFBWcGxuSjNYQldPUnRoTnpaeDdNdlUr?= =?utf-8?B?dklYSklKMlk2czlUYlRQZjRtbVAvdXBHUDJ6WVVGdi9YWHVJQ0g3L1RWcS9r?= =?utf-8?B?d3ZZTENrNWhFUDdEaTFrd0tOaHF0RUZ2VWZqWmpSSThDOVdzdXNCbGlJYURD?= =?utf-8?B?MGY3eVFjSlFvOElIZEV4OGR6Z0NJNy9oWFppNVdQYWF6WnZ3V201T0xNdlBU?= =?utf-8?B?cjlOdWN5Tmc4K3R4Kzc2Y2tQQU4wRzQ2NUxiSGdodFdGcWprL3VaTFYveGpB?= =?utf-8?B?bTRpTm83dWJxait3Z3RRVEo1Sm1ldUlLRHlJekFQVTFoWm9RV3VicDdFbnBC?= =?utf-8?B?eEljMWJxMDRocG9UMm9Yby9PRDNBRTNoM0ZuS0RhN3E0clpFdjdvTTZMUHR1?= =?utf-8?B?TDdIS2xOT1BlRlpVc21FNzE1UmlXK2lYZ3RoVGYxZFgzb3RJNHFWUEpWSm14?= =?utf-8?B?WFg3TWV5RXdQTXY3blhHMFVjckhWWTZwZjZvOHc4VUpHTnhHQnU3Tk5HOURr?= =?utf-8?B?aTF5ZDg3cFhwVTZsNWM4aWFySGhpeitYdGtZdXlpd0hnQXRGdCtXNGIxdkxR?= =?utf-8?B?MURBVUIvT3ZtSGlMZmgxZW5DVjE5bkpYUnh5LzRjN1pxWWtMTkI5SThjN25J?= =?utf-8?B?QTRkODM4bmd1L25NcTUyckpJRUFIdk15QlhMUXRLdVZWbXRSYnIvN01mdXow?= =?utf-8?B?ZDdOdjE1cDlhMzRuREFrV3pvRVppT2tyVmZsdlhJZzF5R3ROYUlWTmxCZGw5?= =?utf-8?B?SmM3cmlCVk5jZGNZS0FXZ3hSUlBtMmFEYys4UT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm5oYi9uQyt3QVNBN0JTRmJnMmZsTGVOSnhBWXdjVmUrUzNWYzlZODNJNVBk?= =?utf-8?B?N1I1clIxZWc0RFFiQTNUcUhFY1ZKTTlXaUZ5dEcxaVpDMi9JamltTy9LTHNl?= =?utf-8?B?eUFHRTJEMjRxdmEyUVJROFA3bW52dHdlckcxVVdrSDUyYjRHQklQcVNCUUtO?= =?utf-8?B?eGpCdlN1cHhoMVVQbWNFdFJRVE8zRGtlcXF1RU5GZ1Y0a3Z3UWoxMHJHaklC?= =?utf-8?B?TWwwcXd4RVV4ZWN6ckRHNDhmUWJYT0NMcHlPMTFsREhYK0c4djNIV3F2MW40?= =?utf-8?B?WDhIMnk2SjBVL09YRmJQL2ZoWnhJTFpJOUFYSnpHM0s2d05paERJUWYvRlIy?= =?utf-8?B?dWgvYUtQRnN4cHBSS1hhODI3Vzk4WDh4UjJXay85SVcrU2Q5aDlwZ2R5WWNB?= =?utf-8?B?RlE0WXhzS0dOci9QaGU1VWRKTTZsb0hCeUNsQTZzb25VaHV2b1ZhN01pR2wx?= =?utf-8?B?YTM5NGwzZmhMeTRqOEE0VmVnalJUNi9iVlBpUW5aUEdJTTlwdkFnN3pPbUZ5?= =?utf-8?B?VlFIZTV2VTVDZHRXSWgrd0JGUklNcmh6b0FCbjd3NWZheXJIM3ZvLzlqYkw2?= =?utf-8?B?K1UzUk5xdnltckd0MGE0ZnFUa01CcTIvY1RuL1U5N3B1Y2EwRi85UU15YUlr?= =?utf-8?B?aXFlb2ViYnNPTmdNY0lUWWFrcXBwQUdZclo1UFFNNGVZRElOTWJZaU04VGkw?= =?utf-8?B?dmNFZW5kQllROW9Oc2wzR0pUNTFlelNrR3BtVUwzNC9LQmxPRWFlaEpvQyt4?= =?utf-8?B?d0gwWlZEYU9VcFlGSUIzTXU2SW9VUVpXOEhsQnlmUEwvTjVieko5dVlTcW92?= =?utf-8?B?YVpMTlB4bVRoZUdVa2k3L1J1QzREUTFVV0dQbjlrdDNaS2RDSTRVblVobmZC?= =?utf-8?B?Vk9ZMU5xM3U5WEVpVzVpdmxPVkhlL09nbFNLdVMxczVVRmxidGRxYXdiQi9G?= =?utf-8?B?M0JxQmFqdnB3YnNlbGZ3YlI5ZGl2cm00MFFrQlI2WkgwdlJqY1NOdWhIT3Zp?= =?utf-8?B?YUJudXVrU1lQeDFzeS9DbEJUdVMrQVBYUW5nazZqN1V4cW9sM1BHL0dpUmNw?= =?utf-8?B?R1B1UGhRNERYUkZpL3hlaXplbGU1azhiRWUrVk9hWGtPZTJTVVloZUNJVisy?= =?utf-8?B?bUNCMU4rM3NhQ1FBZStqamd4akFDVWZWbkxINGNEMXVwR0N0K1JLYTJBUTk3?= =?utf-8?B?amRwbGswV09nV2xkNnRMQVFEckg1bHpkdmFwZVNxN3MxVCtqVmVxbUp2V2Y5?= =?utf-8?B?Rk4rT3BxNmZERXFwQzFzNFAvQzFnQjhvOFBDdXhUNlpqK0ZDYzI1a3owcC9F?= =?utf-8?B?TUdKcTV4N24ySTNFTS9hOHZLSFRwbEpZbTNTOXovdkk1dG5UTFVXODlrYWp3?= =?utf-8?B?MUQ5Sm9oU2pMazlBYkpBVVQ0WUxPbW1xaFdOQUxRbmVnVnFpNGF2VDdRS09N?= =?utf-8?B?N0QxdlZNaEJsVzJqWCtNUGFBZ0VPS3Z2ZXdOb29xNjN5TlJsWVFDeDVKOEND?= =?utf-8?B?TXV1enVrZ1IzV291WmFVM3owWXRrODZ5a0c3Skp3bHNQL01sT1JXZGxRcDNs?= =?utf-8?B?a0RRbFNUMmF0Sm9UWkh1aWVuNG96ZlhEVVQ4NmJodG9LUFl5TWlGYlZXVXpn?= =?utf-8?B?REdRcksydnZCNXNFMGVnbEhYSHRNR2RFZ1N0OU5PYWtMY2hIT3pKYTVpa05Q?= =?utf-8?B?dlFjWmtOY1E1YU5JTDl4SSs5WnlBU2FBcDlpQy8vbDlVRE9nRmNYUWNJNEtu?= =?utf-8?B?QU42SktPc1ZwYmJMQW1RSVVOSnFjREJWV2l3NHBtR3FhZXhaUVdZK3FacVhF?= =?utf-8?B?aWtITmJmR0RQTWJidklCdzdHa0NLMnpnN0l5NVFCZ1FldWlRb3NPUTVWQUhi?= =?utf-8?B?UTc0ZVZqeE1ocjZ4K1VRQjJXaXdSUERyQU95djhIMTFvKzMzaU1JVFhwdEo4?= =?utf-8?B?Tk05dlNlSk9CL0t3Vmg3b3oyM1MxUjZtbTZlVUkvZE8vZWN0OEwraUZkdzR6?= =?utf-8?B?NTdyK3Bkc3lyVERGSkhTYktEMG1NNEtOMm45NVpxcjBJaVNrMmkyUkN3NitV?= =?utf-8?B?cWN0U09CRE5kSFQ2UjN0QnJBMTF0TitJNG00SlNtd2NOamdPMUo5ZjdJd2Zi?= =?utf-8?Q?fiFGvYTDgCoEKteocxVQbhTFd?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d782d156-a706-4c09-3e73-08de1ce4ffc7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:40.4147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iKl15s7CYQ/yCDsFFiGuKQaJv0k3fezkK7svlbywlXV3l/3bsClHMVdgCnasC7tDM7BsV8yLvpasqetPhhuMfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 Introduce imx_dsp_rproc_reset_ctr_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_RESET_CONTROLLER to manage remote processors. Allows the removal of the IMX_RPROC_RESET_CONTROLLER switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 69 +++++++++++++++++++++-------------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 91d041c15ac19f527f48c8189421f71fb7c9745e..6237e8db2eff759c2b7fcce5fb4= a44e4ebaec8cf 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_reset_ctrl_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_deassert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -374,13 +381,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) goto start_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_deassert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 start_ret: if (ret) @@ -399,6 +400,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_reset_ctrl_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_assert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -428,13 +436,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) goto stop_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_assert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 stop_ret: if (ret) @@ -1057,6 +1059,20 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_reset_ctrl_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + + priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); + if (IS_ERR(priv->run_stall)) { + dev_err(dev, "Failed to get DSP runstall reset control\n"); + return PTR_ERR(priv->run_stall); + } + + return 0; +} + static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1080,26 +1096,11 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp= _rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; - struct device *dev =3D priv->rproc->dev.parent; - int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) return dcfg->ops->detect_mode(priv->rproc); =20 - switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); - if (IS_ERR(priv->run_stall)) { - dev_err(dev, "Failed to get DSP runstall reset control\n"); - return PTR_ERR(priv->run_stall); - } - break; - default: - ret =3D -EOPNOTSUPP; - break; - } - - return ret; + return -EOPNOTSUPP; } =20 static const char *imx_dsp_clks_names[DSP_RPROC_CLK_MAX] =3D { @@ -1324,6 +1325,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_reset_ctrl =3D { + .start =3D imx_dsp_rproc_reset_ctrl_start, + .stop =3D imx_dsp_rproc_reset_ctrl_stop, + .detect_mode =3D imx_dsp_rproc_reset_ctrl_detect_mode, +}; + static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { .start =3D imx_dsp_rproc_scu_api_start, .stop =3D imx_dsp_rproc_scu_api_stop, @@ -1334,7 +1341,7 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc_= ops_scu_api =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, + .ops =3D &imx_dsp_rproc_ops_reset_ctrl, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index a6b4625e8be76c6eb6a5d8ef45eb5f3aec5fe375..6a7359f05178a937d02b027fe41= 66319068bd65c 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through Reset Controller API */ - IMX_RPROC_RESET_CONTROLLER, }; =20 /* dcfg flags */ --=20 2.37.1 From nobody Fri Dec 19 14:22:51 2025 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012064.outbound.protection.outlook.com [52.101.66.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 315B22E2F1F; Thu, 6 Nov 2025 03:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399909; cv=fail; b=NIBcxowKrnhjgpU0KdNHQ+dp/S+cF+hKbq58Ua7BpN1oQyw9qoM7c64It+C5QOUyGl0Pgn1kOrxQ9cIU2yWnerKz4gby1DLRHLNeIxSmPl+LPL4sBiFehVdIzKwyOnPKzGa8NnOujgfCecBXzmaruzC4lXbDvq7sc0v5A6mexCo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762399909; c=relaxed/simple; bh=wpplMwcEJ3v7rrfEfqpOXt5gQqU5ZoZirvtf/OXL3a4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=s4fl6sQkS9JWgaUy+CvmW82HsTERO9yXNhrN6YH2PbsceF5MKzjmfqarFqR7rkVLxGJPmaysunkxkhzJQOoYqPf6vG4rh/uAbAmafReLJAsCyb+T9LVd+opsAjxxDaPMm6fOoFOkIMdflBCj4lbqqedH9znuIydqXrUQVmkswuw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=WycDnRnq; arc=fail smtp.client-ip=52.101.66.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="WycDnRnq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qXn5FUDUhhJm+H4Gpsd3551e4sNqG/raMO9W6A7QHnFo/R805A1s3V92b6Pmzd+/YQmBFkwi3WklkQIj7z3dYwa5TDym3KFcf+ILsqcAI9k7cmZ0js2Rq6r9pTp/oiMM6gT8Uu0FMBUirHzJ/pgBCx0qvEdBLYix0hUkVlw3zJYUJxEvuRjFgTPh0n/g/j6cQUg6YKCZwlzzqI9e68SQqMN2xqVvbo9iJJ7vlh3uGQIKCYcsyWu72VLgj8A/IiW0Go9PBtTPMELBqYPR+Vp/TMmZa6RbMg1E+gcfv+PWGy8T4aDXuQ8lrpXBBHtdzpj2bGWkT07eZ/nWRTweTaqcow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sf2whmWQN5dKodqoBrvEqYVleht56eGLU0oBXzmOtqk=; b=yi5E/4SpAYTi9C+eccD9CkywOX0vvV/U2up3/eOYTsNuEvPsJwNxvQKhkO5bDjdV6o5Syqr3lhoOHaWm09ehM8neT9h/Gens9Kcla7KJfffRhzEEGql5vUzmhrmeVRTsIZ/pSJpaWQV+nxwWUk7u9VezLYc31DGHGl0Ju9lHQeNbNGUGZprdUN3ABsmxOg/a8Nz2ILVyv8xGIDYrI7YRJqPKJzGm51WAVnvne5+jfWtvrY9YvKzJ2ZAnBMvcFcGaMMdIPyUgJbehSxwQUeEH/dCVWdiTG8gFR2loSTlTXHTx4ezRivCm0ENJJW5/qv5xewm32gA0OmkYRUldkjzzqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sf2whmWQN5dKodqoBrvEqYVleht56eGLU0oBXzmOtqk=; b=WycDnRnqXoOe+SaSsweXgXvh6OCfn43lRVnnpI+efux3AVooBH4nEc+N/soMkEsdXJjSxKDy5HWkMuz/yI3EQ9Io0rsMWVT6KhO4yCYkGUgbDL4/SpsjoDu/Hg/X4dCGvMmWqI7PCcatElEvQfKhZvUbSYwpo4tTZuzfOKJz8PXoDxKPkG+D8C7WsWYOE9+5DlRdh7Quz0R5oOOzhfSc9ssv2pDUD6R9X7RAF/6E+V9ag6iXPC0i2a3EgmwTMmvT+p4MjZnIe8QAEdQuOVDbHKu6J1QYMcQ1yi/ZU2a0e3APVbv/CoIE6VpVynNfgqNKPQXvEpLK/Dw7R/g0excXfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI1PR04MB6813.eurprd04.prod.outlook.com (2603:10a6:803:13c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.15; Thu, 6 Nov 2025 03:31:45 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9298.010; Thu, 6 Nov 2025 03:31:45 +0000 From: Peng Fan Date: Thu, 06 Nov 2025 11:30:37 +0800 Subject: [PATCH 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251106-imx-dsp-2025-11-06-v1-11-46028bc3459a@nxp.com> References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Frank Li , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762399839; l=1152; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=wpplMwcEJ3v7rrfEfqpOXt5gQqU5ZoZirvtf/OXL3a4=; b=vj1IgdJldm1iMAS3NXi31nVGg4in/O16Ipu86ErtjiOVoizWv4CbBPFtXrw+BCu/DLxfaBjwL KLqTfmeZBiqAeUXDLRD4PvRlX5rWWXcCZA8y8OYeetxwNVj6KDN0X/n X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI1PR04MB6813:EE_ X-MS-Office365-Filtering-Correlation-Id: d4f68b3a-3656-4089-642c-08de1ce502d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|19092799006|366016|7416014|376014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?THEvVVJPRG8xWFNxbTlEL210Q0VIbEpFVXlROUN0eXAwYWNPWWtrbzFLeHNl?= =?utf-8?B?MnNyNnVrK2hrV3ljYmhITEpJZnppYVk4Z3FGQlFnTHpaWE1MNW0rZWdPYnJC?= =?utf-8?B?djlrNWJaNWRZOUp5MUltTU81UjdKRDFYTDlSMWxhNjBiUXNmV3R5Ums0c0Zt?= =?utf-8?B?NFo1YU1yaGpScEVBMnBBVG00SEx5OUc2eUt3VHFmUnlCRDg3SW5lQ2JqWHhP?= =?utf-8?B?WDlialNSanVET2J5MCtwOExVMitsaUhoS0xrYjV1d0J6VHVHanpXOEJPSjJw?= =?utf-8?B?aitKYlc4RnlGeGVBTUMzWUpqMzQwNUthZlpXQWVJTndGaWV0Rlk2bzdoeFQ4?= =?utf-8?B?L2RYNjJGQTNRSVVoZW5SaHUxMFpxdXpabUhDbFFRZEN1cjNYYTkwRnlWdzJZ?= =?utf-8?B?SlhqRlFacCthSnhNeUFmRFp2YVhYSGFMRFJFQlZ0YXVpSU1Rd3pFQkNDdUl2?= =?utf-8?B?OTVyUmlwcnVCL2pqM0EvNEdqNXJqOEcxWSsrT2t6OVNmNFpzV3hDMlFWc3k3?= =?utf-8?B?Qmh5eFhJYWEyeXZlbFgvQkQ4akRoazd2clo0dUIyTGFWVXZGenl1S1Rpb1Bi?= =?utf-8?B?YzlvbCtlQ3R3TGd1d0pGMUpYZmdFS1piNjRndjk5RXlDa05aTXQ4VklFSmZj?= =?utf-8?B?K3ZKMy9LRnlESGJGTXNVaVJXb0w5TkNmSGl1eUNncVI4SVY2dU9Wb0p0bVJh?= =?utf-8?B?bzRUNFRsYmpKQWIzbFllbENPZDd4WWJXYWJzNjFHY2UySWNWMno2b0FGamZz?= =?utf-8?B?WFJJbFA5cVIzODFOWjlDR1VDYmNHY0xydjJDYTl0K0d2ZGVJT0tvNWxiRXNn?= =?utf-8?B?eHdUWU1YblQwc05FekFNNStleThxZjRQK1JoeHFZbFVUaTEyejNwSG1laGpz?= =?utf-8?B?REI1NUR4MVBsVk9HcmthYk9kVlVZUjlBM25Vc1VLTjRPMVEyN0pxUCsxeHlS?= =?utf-8?B?VG9Gd29FbHNMSk5tVzF2OWZqRjIyb21jQjJ6Tk5oSkM4cXh1UTdpWk5hSU1l?= =?utf-8?B?dUtoa3VUcU9ZNnQ2MUtnNzV6YzFBK0FScGF5MVJQZmdodE92OVROTXl6akVJ?= =?utf-8?B?dmROekRIUUsvdE1JaXRIMDh2UjhYQ1UxMGFicWRxMjNwblB5RVc4UnVvK2Fu?= =?utf-8?B?MExJL044VkdmSUZVbWw5VDA0YmljQktvN2QrblErZVM5U0prSFEwNk9ORjBS?= =?utf-8?B?cno1VFhJckVjYXhtR0w0Z3VBTDJBbkJmNHNqbXgxZDhlYi9SZHkvZFpwaUNR?= =?utf-8?B?NkhHaHhXNCtObDdxb2RvYVBNajcrbmJUSzVOcFNQK0VQOFcwQklxSmFScmRT?= =?utf-8?B?Ti9aTE5NdnFGckF5a3krLzVCdGZKTjlyTFBGWHRXTmNYMjV1Z1RtK1hYZEc0?= =?utf-8?B?YXc1Tng4WE5xK2NWbGZ2cG1RdVlWYUtVT2M1QU5NektvTXRsZi9HbjI3QjJV?= =?utf-8?B?UmhRR1BMcjZoOEl5aFlhSGR3em5jRXZLSVVuQVhlQ1V6WlloZEFadW42N1kw?= =?utf-8?B?Z2p3bm9RZVhDOWl5d3JNZHB6NnZ4alluMnFCTURnRVlvQ3FxWlZaaHVnS1dw?= =?utf-8?B?L0FJaENBOHZXNDljcjJSS1BxWHhhSUlpSkFOeWtEYU1Qb2JVd21iVC9aRXBv?= =?utf-8?B?UHg4ZS90T1pzSzF0TkRkM3ZiWE95WGZOT3hvNHcvdjR6OXJzREJNZC9jcHA2?= =?utf-8?B?UjhRK29hMXFyKzJKclE4RzRxVXlsdjlPbFI4Q0w5TFd5SUZ5R2ZoczJkMlN2?= =?utf-8?B?NVo3RmR2VjJyMFVOQzJRb0xkaFllVTJtMTJZRDRlTlY5aUs4MUxKV20yTklC?= =?utf-8?B?NEZpbk9PVWF1QmVNVGRsT0N6TU4wZ1o1TFJDUkp0aXhYQTFwS3RTdFM2bXNS?= =?utf-8?B?bHFTQ2JVbDM4VFg0ZWpQS0dMYzdXM1dGZ2VnSk94SFNZWVU2eTM0K1ZTb0Fl?= =?utf-8?B?ei9Ma0VVcFhHaFVsMEhPU1JreEZWdGxURXFaSmI4dDhYWElnMWRjRUNyUDgx?= =?utf-8?B?Y3Vjb1BxaTM2dGVCajN5MkZtTENnUU9qcUNZVHZTekZkdWovOGU3bElCc1BT?= =?utf-8?B?ZWUrdm05VFdXaUNZYW04Unh2bEhudGtlM25ZUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(19092799006)(366016)(7416014)(376014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3RvN2U3RVZrbDFUMWg4anJpb0Zhb2RmU2hPSFZNVDFMNEJ2SW9wd2RRRG45?= =?utf-8?B?YnpKM1paeS9zdmFwWDRudll6SGZ6cTJISG9zWkd3UjJVR2tZS0IrRDF5N2xK?= =?utf-8?B?S0Q3V3lOTlBPMGJQSW9wZktiYUUrNzMzNnJveGlkeGNFNUFHZW1TMDdGWWFF?= =?utf-8?B?QllYK3N0WmRVdGNLT1lNays1TlVUVmtaVDRLUXZtOVFUaks5c1VXZmhTNzZD?= =?utf-8?B?aStieVp3cVZ6alBwQnVrM283TGhyQlRDbWZ1ejlxK2FhYUJwUVVrSkVKWi9L?= =?utf-8?B?WVM1YjZYNkcvVjFudFNLOGFvMm1FTlg5RnJaRXZ5YjNia0N1TFQwYnhrTC9s?= =?utf-8?B?S0JHMWVXbmRIVXFUdGRWakZSY0Y0WXNsUHVnd243cTZKTzhQS1c5eG10N1dG?= =?utf-8?B?NVM3ZXJBdHhtTTVhczRGVng4UFJSM3ltOHo1YUhjekN0WlJid1EzMXlNbEFM?= =?utf-8?B?NDlwR3VGblpFMUQ4V0taMTJ5UlF4bzJGTGFLdFZYTXIwTjMyWm9pTFRnVFZP?= =?utf-8?B?WFdsMnI2Tmc1VmFrTE1wRHJWRXpuWXRTRzIwTVRyQVBrNEJqdnVRV0pGejdk?= =?utf-8?B?a0ZxOStsVVRkUVk5NXMxRXE0QmgvdGF5OW9ObGxXRUtEakE1OC82b1BOdy9j?= =?utf-8?B?clNsRWpqOHhLMit0UmxHWi9hOVVVRFFVZm4yTzNpb3lscWFVbjdzVTNibTR6?= =?utf-8?B?RWdXS3VhVzIxMWV4Q1B0VUtnNC9UUWVFV0F2Ull3OWwzSmJMdWxSSlZMWVVL?= =?utf-8?B?a0xybGpPU2d1QWxsek5BZGJxV2ZkNUZvRE9ScW9KU2h2WmR0Sm1leHJhQ29z?= =?utf-8?B?Umc1c3BIOUZ4UUdEMjQ0NldhUWhXL1hzZG54NzMvUC9CdzJNaStVZUlyM2hH?= =?utf-8?B?WlJSZXV2ZTVZU0NGaURWM05XV2JmVHppTzlpdmdkQkNFSnJnejR1UmVUZGUv?= =?utf-8?B?RmN6aTRqWUdpUFhrcFB6K08zQWhuT2Q0UUJGUzhNTHdIalFDZG0vSmJjQWYx?= =?utf-8?B?ZjMwbEJqLy9kREpVNVRMU0ZweXZBSzBPVXhYR0x0M3I4ek5Gc1IwaVZoSDc3?= =?utf-8?B?ZWpEU3k0eEpIbFVCVzNLOUorc0xhLzROeHRTUXBSVGhBRCtGeFByRlpVa1h6?= =?utf-8?B?MDJkK2NQWnVBREwxVDNxVndZSE1relQza3BJWlFZRkdQNVkzQmpFOURtQ0FN?= =?utf-8?B?ME92cFljbFRRU2pTRzl0TWtUa3Ztdis3ODdTTlNwa2pzekRmc3hOTUlRWVA3?= =?utf-8?B?dW9sVE1VcUpiaG5PQlh0TDZaZTRwdzBFT0V0M1NSV2FHVnN3L1h6VVBnWHJs?= =?utf-8?B?SmwwczRac2FvTzM4OHNpbkF0R2doeFBqeWdYenFBRDlBRGNQNDVKcXNaOHEx?= =?utf-8?B?UjhLYURycXUybDcvMHRYUVdscDJRMW9LUUp5NVF5bmpoc3BSMmZQZzNnRjcr?= =?utf-8?B?YlhmbkR2L254d1FnTlRZL2VIc01pOEFmc2hPbnhnbWd2dlhsWWdkYTIwdFRY?= =?utf-8?B?aVBodFJYakVCVEhxdnRvajBxTHhVUTdqekpIWjdPbEt5M2NXd2dkejBRK21h?= =?utf-8?B?ekgvLzIraWhjV2hoMFFhZ3Y0OUZiejFoVVYxZUdHcnBYZko3UzVUb1orS0Rx?= =?utf-8?B?N2s4WkFCNFlhNng0WHJTRFFvd1FLQncvbDE3UUdCZWVhdHRDV0ovZWNZTG5Z?= =?utf-8?B?M3N0RnNQMzFTcmxwNXpVMTl6cTVMazJwRzdnTUFxKy8xWVJ0QmVSaUlESVI0?= =?utf-8?B?dDZPeTZuSGcxdlg4RElTZHk2MEpINnZOSFlLL2p0Y3cwSjNxU093RVh1a3VG?= =?utf-8?B?OW8zYmhmYmwwL2ZHWGNuc1RDd3oxTmQ4QVJzbEhRUVpKZVN0RTZHc2dJTTFy?= =?utf-8?B?NmdzMmZEZnkrcmxUZjNsRG1VS2JrMUthUHdIVExRRWp1c0k3d2pocjgxSEhj?= =?utf-8?B?OHNrazZCbVFmTU13QjhITUthbHBCYlBwYmdrdlB1ZVQ1aVhxc3F5dnJlQzha?= =?utf-8?B?TGRqdzFMc3RNYUJWRzBTY2E4MGh1RnBTeXUyU0pQTE9xRUZoUkQ1R0Q5Njkx?= =?utf-8?B?WmIvM2dqYkk4cDhiZzh3dVdVbjltMnp6dGNqRUxad2lQSnBUOVBrZmpQT0tG?= =?utf-8?Q?njEryOIQy6nFqB8jeIRviVfUs?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4f68b3a-3656-4089-642c-08de1ce502d9 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 03:31:45.6391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yx00SnGn1UUG8xb77tA08TNjY9Qj6Cbtw8HRyLO2PtL56G7TMk2S9l9UGG2mea2fxlxn+489+QnusfXSiacSwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6813 There is no user of enum imx_rproc_method after moved to ops based method. Remove it. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2= ab3488281916a 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -15,13 +15,6 @@ struct imx_rproc_att { int flags; }; =20 -/* Remote core start/stop method */ -enum imx_rproc_method { - IMX_RPROC_NONE, - /* Through ARM SMCCC */ - IMX_RPROC_SMC, -}; - /* dcfg flags */ #define IMX_RPROC_NEED_SYSTEM_OFF BIT(0) #define IMX_RPROC_NEED_CLKS BIT(1) @@ -42,7 +35,6 @@ struct imx_rproc_dcfg { u32 gpr_wait; const struct imx_rproc_att *att; size_t att_size; - enum imx_rproc_method method; u32 flags; const struct imx_rproc_plat_ops *ops; }; --=20 2.37.1