From nobody Wed Dec 17 15:53:46 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3852D6E5C for ; Wed, 5 Nov 2025 21:03:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762376618; cv=none; b=jvgKv37GMOnlTH7K2rbwHIX2On84lWj8aMto1sb4cncAtgxmqbZnWCyw1ylQ/BLfR7Q+ISOsT3X/DKtGL9WvVoEkkcDH1QI2WmBEOCmbQugU0J+HRdAkJiGfmmRo67EL6+FP4oF4NvizT47ned/w0IFP+jPVQFfM2gRJAhr3IWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762376618; c=relaxed/simple; bh=dZxbC32mzy/JF02DKZ2snFfIWQ/TTrnP2h3YmTHbL8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m/NOebW4rt+tJBWklzLZPys9s4nDcGKJMC4HdgrFZb1iNBo9O+NJsYrSkqUg06rqnNR/m5RaEoIcBEdl/rfwTIz68EF6cGmhHCKRPtqDCfFfS0Eg9E6tvyHAZVf6njoG6+wYA7TDPI4ZNENbDv58c+cJoySYl7OAqRLRrPwdnEk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UHvEmO8F; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UHvEmO8F" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-341988c720aso258410a91.3 for ; Wed, 05 Nov 2025 13:03:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762376616; x=1762981416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvK6qvFSDKA15whyYqvYMfPkmiZehgHvoYJ0yEG/DmU=; b=UHvEmO8FDqslTM//zGwzpVTHnVnIzwxC8pLjsFNJOzG1VNAiDeY2i1v3/wuLwj5Ku6 s1pckZZIMwLJDpoCWYIiHl1OXgI33stdCpx455K5AaYyuyE2Q59gBJQ3Y0EVzeXVirGt llQI/Q/ZFGNNhHFY1TuDBgnrIEPSVssWEaZ+H5NacwaEH9Cv9eRzq/lsPzK7uXt/rye9 NZjCRgg4D8AKpCHVBm74SQDY1T8t2k7GE6DwzKTDSSvINYJPKTBZc75OFReHXubHW/fm jaqo1PYk8qIYhuahbxDhnSMPT3DABDQEMbV3H2qZyd3Onw6B3i31+IHnLIlYFfRPtYqa 2opQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762376616; x=1762981416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvK6qvFSDKA15whyYqvYMfPkmiZehgHvoYJ0yEG/DmU=; b=rdmeixzualGurc1JGftJ0vIg09p9/RNzrJF0enmuNSl7WTNHovWTQB7X/xQr3dbjaw BiuPx+ISMYsVLAJfssJQcKM7HiWhVs1Xq9LC9mH5c1XI902kBJo1CQq3glSVOJ8cwHpZ NwpiCq/Dd0pqK/0CeB8aMyGiEtp8Nuwqu2kW+e2fMWh0dfMxdkdFfAESV2MveEu9uqx2 rKskt9kcDT8NIP7RR6Ucw5HqjqNu3NR4Qa/+LbXCMJJC3lEqj4QpdOstCbI/Y9Oc6l3/ KalGsSD/jY3TvmOMrFASrz+Khdg6//D23SmcHfhBs/k+Sma9uV7TqTp1Adms/pii0MNz 2Z3Q== X-Forwarded-Encrypted: i=1; AJvYcCUSoq1FX2iHJIHmfxsy5UZGsdEqJJY1p0EI6apbrjWqi8iaGd5R3KZcMKMT1Paddoec2DNtYfzA8Hhtex4=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ0ngllitdK0ZNL8Yew5mIqIokrkS//SJlhroSQtegd6BrikDt gOGscS0W85gJ/d21iTyBzwMEUvK1KuRKzhvm9KdS2jlEd8WDQqNjrwSr X-Gm-Gg: ASbGncvHoF/U5UdNuiKuHbhCdP3i5dqm5xqCjiGAghk98gGayV3bXgzzjYzRsACj7U8 usMs+oYg9v7CEXZuiQzr1VV4/QbX4/iB0R6Ro5i+Ux+unreW8kdpPOxkhPic/UCtOBSB7XaJoaQ uezfw16Vmj+OgNt3P0dZifQpR0euDhHTIoZGXnHLbGzrRuAjjz2pmmR0dW8lY16piYVBsFQrZoA Jni6nDujWtLMA7kjiUtG+wRoZFoRu2kQV6gJKP4pLyKWhTsSUEGLvkTDx8ywTcwclTERLguYbo2 8PYrWhmOehLO9tNgzchD8g970UH8tO87koilEtTzPmBcpf7/Ggv4dUSZ79UmAk2UnaqWbcav1vS XI5XPmUriG/MiQNk1mCuRDRqpHdOK/FJZYEng9Y3WWK5Zt3s+11gYXw/dzQ== X-Google-Smtp-Source: AGHT+IHOziVsZSS5XJszgFIOI3dDfa90KKWH3MYFTR2nMejbJeWj2BTL5+TWVQ9T3SiGEY66XetT7g== X-Received: by 2002:a17:90b:5847:b0:340:bde5:c9e3 with SMTP id 98e67ed59e1d1-341a6dcc6admr4852945a91.23.1762376616023; Wed, 05 Nov 2025 13:03:36 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-341d125c93fsm13626a91.14.2025.11.05.13.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 13:03:35 -0800 (PST) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv4 dmaengine 1/2] dmaengine: mv_xor: use devm_platform_ioremap_resource Date: Wed, 5 Nov 2025 13:03:16 -0800 Message-ID: <20251105210317.18215-2-rosenp@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251105210317.18215-1-rosenp@gmail.com> References: <20251105210317.18215-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplifies probe slightly by removing explicit struct resource pointers and platform_get_resource calls. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 5e8386296046..3597ad8d1220 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1309,7 +1309,6 @@ static int mv_xor_probe(struct platform_device *pdev) const struct mbus_dram_target_info *dram; struct mv_xor_device *xordev; struct mv_xor_platform_data *pdata =3D dev_get_platdata(&pdev->dev); - struct resource *res; unsigned int max_engines, max_channels; int i, ret; =20 @@ -1319,23 +1318,13 @@ static int mv_xor_probe(struct platform_device *pde= v) if (!xordev) return -ENOMEM; =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; + xordev->xor_base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(xordev->xor_base)) + return PTR_ERR(xordev->xor_base); =20 - xordev->xor_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_base) - return -EBUSY; - - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) - return -ENODEV; - - xordev->xor_high_base =3D devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!xordev->xor_high_base) - return -EBUSY; + xordev->xor_high_base =3D devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(xordev->xor_high_base)) + return PTR_ERR(xordev->xor_high_base); =20 platform_set_drvdata(pdev, xordev); =20 --=20 2.51.2 From nobody Wed Dec 17 15:53:46 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7500F34CFAA for ; Wed, 5 Nov 2025 21:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762376619; cv=none; b=Wre2PQnBARih/muYjugMyg+kwKndVp0mYxeskpSu374XAJ8q6MDE/g/rmrQzsZR3Vjnqbblz5EsS5LPgCYI9mmDLzldc65YsRFn7FGeOXCNy5MCmd2bFBu6oTPsV9JFmEhc/mCNRRWa3HcRa2zQTYAfaw0tfGpRU3wRl5QQ2HZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762376619; c=relaxed/simple; bh=7zfVMY8XIGnKYdGtLUi3KWKuh80GmnankiFSdnvKcoI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=spp/ipjiI5BI/Kan2Xd2zZLNW25Ju9okUkYO4EJ9SwepTGxLl7q4Hcxf4S/4CtSE4UCU1s/+52nvsgMcwt/HWv1nNcDO9grHbgo4z7aQ0VtZH07GoktByJS9wJGVQ4rdruGFUkR1XPK24XcfpjHxIDVl8p6TEhI+hndSV1AfOvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXbST3Ij; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXbST3Ij" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2947d345949so2456335ad.3 for ; Wed, 05 Nov 2025 13:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762376618; x=1762981418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MkrJkdba1xSje2XMh2x048aEOPt8IqS+4z2rOIVGwVs=; b=NXbST3IjoD8sTIj1lwmrdm+jAfpfgZ0h/oSYjlEJbcPW6kpqnXfYyrGE9rKplh83XO 1QGiipHr9u9eC3Waxb0dvg5bOCG8hCTNuC2CZQMCkX1Xj8MhmO6yG0zMlPHGW0lP4Kup yTOFCbmW2eVkCbXo2tRX5XuRDwuA3LkSnUSrgjIpOjbekw+UqF66RJWTowotrMYQvdUs ZeZRR51KZbN5jywzWWeKi0MAWE32CDEDDuEPSmQ31SoDSOcpVSKUnAUKGD2WKCuu7WhQ svyX65mM722LsL7YPHg3LpJ0p3sfBZjF7dbCGSV84rSJeiYPlHps3NXZOTrqXxJ6WOHl joKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762376618; x=1762981418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MkrJkdba1xSje2XMh2x048aEOPt8IqS+4z2rOIVGwVs=; b=sZ2aRAKOMR0jpPoLFoEFdF30C+dkwUu0wpG8R2TggMUkJrvz8dlx37LWHYFLZPSVAR GIZrQa8JJRziAdLyVeKho+vn2QOuAOHgw49bgZHKwx4ejactJei36BuVXH8gGmUYhWCF djxF8cKvZMYJVRSr3L8Vkj6pr5nEH+QQeJ1ZTMbZJRz/mFtxamTEp3sOsUqaDeSlBwR0 7dYZG+QgXXNXieq4RLRZl2XROo1iCUbUiOtiLVwXAdjTH0I6KkFdiwz877arv/VjvshL Wl+iFkZaGpXIfJT3jUEM530Pm00fQ8ElQL7CtUkN7Z65DJAzZchJxmlE6HTKhTgwWrru bI9Q== X-Forwarded-Encrypted: i=1; AJvYcCUSHgTh5ILJurXAritkVDtC/6g5WWNcds6CWtjjiRq2bEBWcF0gKjC9N6TdH5H1EZg4xiBLxj45RDqAsOA=@vger.kernel.org X-Gm-Message-State: AOJu0YzM76n3Qf+118TSaf976D5QLAyzgOW8k6t4SwbO4tGkop1RrNGp Gfs4Ig8YxJoxrlRgstaZnZpN6SdmtSXb11lhR1bRyODTlhDN7FhzVw5z X-Gm-Gg: ASbGnculV1tXNaOQcPjtikyXuJqpvbOsa8Q5qLXnMv/cwY5m348SeXvzP6lSXyKeQK5 fPQEJgHTojritQlnzSZhStkBiI9qwxod5D+p3AqN+XROD6GmtRDRV7/SEo4g7JEpws7aQ0Vkmoz hZ3c0jjHN1ePboN+nLZoBZwRuhkd/oc92P7b/4ioSuVLKy5DEFs/v+QUOjcjZlv+QYqjMhw1L3D PC6SOYOwhX/2qUcjB94La5fnboK6kJYCW3Jv3NBFP6hVn+0aamuGynwW+Z9lIjp/mGkNW6qEStJ +RiY1q+AnMaT91ixG3S1F0sh9d7/+ZuJkymQDUpJyLR8WnJ1x2wjblaKfcpQIGRotUYxq99u02O j8h+0jG8ce8P10nieqTqphT8f+zc94FTub9V9z1gYYQzW4gIHw0Ok/MXJGw== X-Google-Smtp-Source: AGHT+IE+n66VzklfbAOrQrgUIqTmTgKBWIWBX+BwQFs7o7CvfPqTM+UfY6E430xCte9cNWMIOyPm9g== X-Received: by 2002:a17:902:fc44:b0:296:2b7a:90cd with SMTP id d9443c01a7336-2962b7a9106mr49267945ad.32.1762376617589; Wed, 05 Nov 2025 13:03:37 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-341d125c93fsm13626a91.14.2025.11.05.13.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 13:03:36 -0800 (PST) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv4 dmaengine 2/2] dmaengine: mv_xor: use devm_clk_get_optional_enabled Date: Wed, 5 Nov 2025 13:03:17 -0800 Message-ID: <20251105210317.18215-3-rosenp@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251105210317.18215-1-rosenp@gmail.com> References: <20251105210317.18215-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver was written before this was available. Simplifies code slightly. Actually also a bugfix. clk_disable_unprepare is missing in _remove, which is also missing. Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 3597ad8d1220..d15a1990534b 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1351,9 +1351,9 @@ static int mv_xor_probe(struct platform_device *pdev) /* Not all platforms can gate the clock, so it is not * an error if the clock does not exists. */ - xordev->clk =3D clk_get(&pdev->dev, NULL); - if (!IS_ERR(xordev->clk)) - clk_prepare_enable(xordev->clk); + xordev->clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); + if (IS_ERR(xordev->clk)) + return PTR_ERR(xordev->clk); =20 /* * We don't want to have more than one channel per CPU in @@ -1441,11 +1441,6 @@ static int mv_xor_probe(struct platform_device *pdev) irq_dispose_mapping(xordev->channels[i]->irq); } =20 - if (!IS_ERR(xordev->clk)) { - clk_disable_unprepare(xordev->clk); - clk_put(xordev->clk); - } - return ret; } =20 --=20 2.51.2