From nobody Fri Dec 19 19:19:08 2025 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2D0461FFE; Wed, 5 Nov 2025 18:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762367583; cv=none; b=aRJ+biJuWbtmXyk9CfT0QDgjvO+E3hWlaTmO3sX3yfVdgv9LhJOEO3Aj/7u8MI1SBvGRkgmevplyzTnqF5eZo4H/EBhph0hakLL4IG6SfDQMKeL4ISXcI8haTdWboeR7BReuv7PiOgGjYeQgypcQVXEHUL4Cyy5/Q8kATR0ccL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762367583; c=relaxed/simple; bh=eTnEqUfZ1QM8rQVdqe622sxSi3uLZoHR6Wimv93HDIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RieVmul4WCq4ZRv+Pibo8eK3T2/wULUovmhOKk10r599bAoi3+qGtQaw3XbplQt6rGR5SuSWaC1PYocEDD9JgkaoLEQYLzvHESpF9K64Px/T2/7mxKS5yrcKKdmYQumiEz8XXqzI2BDYtLeMGnwegYr4XZAc87met3CPMcstz5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=r2XjgkIs; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="r2XjgkIs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1762367571; bh=eTnEqUfZ1QM8rQVdqe622sxSi3uLZoHR6Wimv93HDIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r2XjgkIsRXR0hJuwsViDFkgEE3qS5lyXCAF7nE68uU3+Jy8fDHewh2wVEwqDrOOai vmLdTl5on9eWGq3e3FcBCbaUtnx6sKcJvV5Ik/J6q9LCWkz2myPIGGlaFZ2zrg6KzZ WixSsQV9yl//eNSR/aE14RMvrwsI2h839mHQUBhUKaLfQCLNz9tBR+xF1p5xRmmLgG nB0RK/XiPLTnf+da8GVqbJCfrt1GOfAS5Yx+y13CZULNeCPu6ZLGDJVFdoI42QqExW 7YRRLe8ddW3Q4ELo51oMFQBqngGLlQALqeATUPKNBS1Nkt9rBvmgkKoPo5VpxHPxfh ZEkhYxkzSYdYQ== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id F087C6010D; Wed, 5 Nov 2025 18:32:50 +0000 (UTC) Received: by x201s (Postfix, from userid 1000) id 2E41720517D; Wed, 05 Nov 2025 18:32:25 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: "Jason A. Donenfeld" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Donald Hunter , Simon Horman , Jacob Keller , Andrew Lunn , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jordan Rife Subject: [PATCH net-next v3 03/11] wireguard: netlink: enable strict genetlink validation Date: Wed, 5 Nov 2025 18:32:12 +0000 Message-ID: <20251105183223.89913-4-ast@fiberby.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251105183223.89913-1-ast@fiberby.net> References: <20251105183223.89913-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Wireguard is a modern enough genetlink family, that it doesn't need resv_start_op. It already had policies in place when it was first merged, it has also never used the reserved field, or other things toggled by resv_start_op. wireguard-tools have always used zero initialized memory, and have never touched the reserved field, neither have any other clients I have checked. Closed-source clients are much more likely to use the embeddedable library from wireguard-tools, than a DIY implementation using uninitialized memory. Signed-off-by: Asbj=C3=B8rn Sloth T=C3=B8nnesen --- drivers/net/wireguard/netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlin= k.c index db57a74d379b..682678d24a9f 100644 --- a/drivers/net/wireguard/netlink.c +++ b/drivers/net/wireguard/netlink.c @@ -633,7 +633,6 @@ static const struct genl_ops genl_ops[] =3D { static struct genl_family genl_family __ro_after_init =3D { .ops =3D genl_ops, .n_ops =3D ARRAY_SIZE(genl_ops), - .resv_start_op =3D WG_CMD_SET_DEVICE + 1, .name =3D WG_GENL_NAME, .version =3D WG_GENL_VERSION, .maxattr =3D WGDEVICE_A_MAX, --=20 2.51.0