From nobody Mon Feb 9 04:46:37 2026 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28DD833556E for ; Wed, 5 Nov 2025 16:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359285; cv=none; b=aaL84whFKoIjpkNBGbEwwrcG9HistGop17uXf2yhu887UMePpefoVNLz367s8F6zo3Cih5d54gFWGhXiZgcI6U98mkCxc5fjZDouEN32shHTNLF8ZilxqoMHxfppB6bpGRf1OiRXMaZd/a8Cj5d/Dc5bkEgxWdHksRUdtajBqvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359285; c=relaxed/simple; bh=s3n0unM8fl7/M0BhD7n2qAjj6YvnndYHEUBGy10hFU8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HJhdaNOTAvxe+RfEUYBnLEmRBeAWfCLdm0IflkcsLTwpjidhtUZmHyM4PJfQmyQ/Y/zOvEv1VYjWS7nqdeGCCYjKhazIIlN0kDk3k2pNTn8tpmRmndq/Tprv3JilRFSp7sxD882yHtlfAEOFrnMh5jd4FB3d4Tasm3k+QhXZeJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from spb1wst022.omp.ru (87.226.253.162) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Wed, 5 Nov 2025 19:14:31 +0300 From: Karina Yankevich To: Sandy Huang CC: Karina Yankevich , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , , , , , Sergey Shtylyov Subject: [PATCH 1/3] drm/rockchip: vop: avoid overflow of clock rate in vop_crtc_mode_fixup() Date: Wed, 5 Nov 2025 19:07:17 +0300 Message-ID: <20251105160719.2917175-2-k.yankevich@omp.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105160719.2917175-1-k.yankevich@omp.ru> References: <20251105160719.2917175-1-k.yankevich@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 11/05/2025 15:59:09 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 197810 [Nov 05 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: k.yankevich@omp.ru X-KSE-AntiSpam-Info: LuaCore: 75 0.3.75 aab2175a55dcbd410b25b8694e49bbee3c09cdde X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_black_eng_exceptions} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: 87.226.253.162:7.1.2;127.0.0.199:7.1.2;spb1wst022.omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 87.226.253.162 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 11/05/2025 16:00:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 11/5/2025 2:40:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Content-Type: text/plain; charset="utf-8" Conversion of clock frequency from kHz to Hz in vop_crtc_mode_fixup() can lead to integer overflow, since type of drm_display_mode::clock=20 is 'int'. Fix it by using 1000UL multiplier to avoid overflow=20 at least on 64-bit arches. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: b59b8de31497 ("drm/rockchip: return a true clock rate to adjusted_mo= de") Signed-off-by: Karina Yankevich Reviewed-by: Sergey Shtylyov --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/= rockchip/rockchip_drm_vop.c index ba6b0528d1e5..b1e2ca84c26d 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1239,10 +1239,10 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *cr= tc, * 4. Store the rounded up rate so that we don't need to worry about * this in the actual clk_set_rate(). */ - rate =3D clk_round_rate(vop->dclk, adjusted_mode->clock * 1000); + rate =3D clk_round_rate(vop->dclk, adjusted_mode->clock * 1000UL); if (rate / 1000 !=3D adjusted_mode->clock) rate =3D clk_round_rate(vop->dclk, - adjusted_mode->clock * 1000 + 999); + adjusted_mode->clock * 1000UL + 999); adjusted_mode->clock =3D DIV_ROUND_UP(rate, 1000); =20 return true; --=20 2.34.1 From nobody Mon Feb 9 04:46:37 2026 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C62A333445 for ; Wed, 5 Nov 2025 16:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359288; cv=none; b=lHxHFlNnK0QuJi9CclpA2oDG5fxRllHaAox8c5HVVIg5QyOg7JQKfMyRsgGWEbAtygNLV4U9dLhBV1357ah4eOP6N24KuJO9jHZUNS1khs0M2q8ywbMNz9Rp0j23Rq9W0mSnG08l4K+SD5IbAUkDdW8T3bRKFH4WbBvOgb97o2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359288; c=relaxed/simple; bh=G4Ea1aWe9+s9dH73P45akAacFOqvJ9EMtveBH/pcarM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aWEJTDD+4Jb4ZAYn5EvqHAIGjrJB9bAcbcqhXx7LBVrYzzKWJB+vUujHSTbPAXnVwDDTeia0euK6gz8QTeZY7FGVHfJ/Pt421ZQgM1SqouBTlLWvK9I4C1PNifIQhtSr0XbLEyGjiIf2GaOBWJA8mctsNGekyHnrHBRuIeS9Buc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from spb1wst022.omp.ru (87.226.253.162) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Wed, 5 Nov 2025 19:14:39 +0300 From: Karina Yankevich To: Sandy Huang CC: Karina Yankevich , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , , , , , Sergey Shtylyov Subject: [PATCH 2/3] drm/rockchip: vop: avoid overflow of clock rate in vop_crtc_atomic_enable() Date: Wed, 5 Nov 2025 19:07:18 +0300 Message-ID: <20251105160719.2917175-3-k.yankevich@omp.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105160719.2917175-1-k.yankevich@omp.ru> References: <20251105160719.2917175-1-k.yankevich@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 11/05/2025 15:59:09 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 197810 [Nov 05 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: k.yankevich@omp.ru X-KSE-AntiSpam-Info: LuaCore: 75 0.3.75 aab2175a55dcbd410b25b8694e49bbee3c09cdde X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_black_eng_exceptions} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 87.226.253.162 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 87.226.253.162:7.1.2;127.0.0.199:7.1.2;spb1wst022.omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 87.226.253.162 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 11/05/2025 16:00:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 11/5/2025 2:40:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Content-Type: text/plain; charset="utf-8" Conversion of clock frequency from kHz to Hz in vop_crtc_atomic_enable() can lead to integer overflow, since type of drm_display_mode::clock=20 is 'int'. Fix it by using 1000UL multiplier to avoid overflow=20 at least on 64-bit arches. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2048e3286f34 ("drm: rockchip: Add basic drm driver") Signed-off-by: Karina Yankevich Reviewed-by: Sergey Shtylyov --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/= rockchip/rockchip_drm_vop.c index b1e2ca84c26d..9a6395db455d 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1473,7 +1473,7 @@ static void vop_crtc_atomic_enable(struct drm_crtc *c= rtc, =20 VOP_REG_SET(vop, intr, line_flag_num[0], vact_end); =20 - clk_set_rate(vop->dclk, adjusted_mode->clock * 1000); + clk_set_rate(vop->dclk, adjusted_mode->clock * 1000UL); =20 VOP_REG_SET(vop, common, standby, 0); mutex_unlock(&vop->vop_lock); --=20 2.34.1 From nobody Mon Feb 9 04:46:37 2026 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7906D33507F for ; Wed, 5 Nov 2025 16:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359294; cv=none; b=UOiR63jxdFb567xdeZynV5LvoZ26bfjm6gn8Rz2UVsfmVa/CAzA6/3VaKT5yGtnHQJO3ZagNz7galJHISvclX5jdFPIJPPrmasxAwanemz8qWOKOQpKt1fzBaxYBK/kgGWTqLvzMRLzZF60CIcX0GsFMbgnQ3GzCBKHyab/kE7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762359294; c=relaxed/simple; bh=TmeZVR88pCskAzNdUhUd6j6Kpz4DZLRD/VmqksaVv6k=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NNZ/4kL4cjd1C0axUpG+M+73ORZtGj+FYtfboPCw2kChKMEX7DWcUBBlusKLCzYiC/U6nWfKznAjVzN3N0QAQvDg2ClRZlBd6wuBBCMmRhAzydt8xbfOppmv0xzdQgWsOEZcYeMGDRcpANdzKuOg/aOx9foXPirVDFIwxqQkfpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from spb1wst022.omp.ru (87.226.253.162) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Wed, 5 Nov 2025 19:14:46 +0300 From: Karina Yankevich To: Sandy Huang CC: Karina Yankevich , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list , , Sergey Shtylyov Subject: [PATCH 3/3] drm/rockchip: dw_hdmi: avoid overflow of clock rate in dw_hdmi_rockchip_encoder_mode_set() Date: Wed, 5 Nov 2025 19:07:19 +0300 Message-ID: <20251105160719.2917175-4-k.yankevich@omp.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105160719.2917175-1-k.yankevich@omp.ru> References: <20251105160719.2917175-1-k.yankevich@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 11/05/2025 15:59:09 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 197810 [Nov 05 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: k.yankevich@omp.ru X-KSE-AntiSpam-Info: LuaCore: 75 0.3.75 aab2175a55dcbd410b25b8694e49bbee3c09cdde X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_black_eng_exceptions} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 87.226.253.162 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;87.226.253.162:7.1.2;spb1wst022.omp.ru:7.1.1 X-KSE-AntiSpam-Info: {rdns complete} X-KSE-AntiSpam-Info: {fromrtbl complete} X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 87.226.253.162 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=none header.from=omp.ru;spf=none smtp.mailfrom=spb1wst022.omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 11/05/2025 16:00:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 11/5/2025 2:40:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Content-Type: text/plain; charset="utf-8" Conversion of clock frequency from kHz to Hz in dw_hdmi_rockchip_encoder_mode_set() can lead to integer overflow, since type of drm_display_mode::clock is 'int'. Fix it by using 1000UL multiplier to avoid overflow at least on 64-bit arches. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5e3bc6d1ab48 ("drm/rockchip: dw_hdmi: introduce the VPLL clock setti= ng") Signed-off-by: Karina Yankevich Reviewed-by: Sergey Shtylyov --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/= rockchip/dw_hdmi-rockchip.c index 727cdf768161..ca31c2a4e440 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -277,7 +277,7 @@ static void dw_hdmi_rockchip_encoder_mode_set(struct dr= m_encoder *encoder, { struct rockchip_hdmi *hdmi =3D to_rockchip_hdmi(encoder); =20 - clk_set_rate(hdmi->ref_clk, adj_mode->clock * 1000); + clk_set_rate(hdmi->ref_clk, adj_mode->clock * 1000UL); } =20 static void dw_hdmi_rockchip_encoder_enable(struct drm_encoder *encoder) --=20 2.34.1