From nobody Fri Dec 19 12:47:18 2025 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012068.outbound.protection.outlook.com [52.101.53.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C38D15665C; Wed, 5 Nov 2025 14:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353612; cv=fail; b=AMs+52LAwkti/VOTcJsskjHsrMcOMIA7egeqTY39GtkklquW3bPYxrKNPb7aynWWoaYX139yLO/BIoocIwKbViu1jfBHwkq+jKF5RcOnFpALLeg9rdrbG8fFzXmF+eI4/Vht9QSuUZCT8GMtE8TPXn3VORI8mIixvvvDLgQce5Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353612; c=relaxed/simple; bh=WkSPuxgsHn2guOlkxkhs9HZnuMHxLDW/9SNe7cmWC3Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HX/3c3+wBKyTRYw8bNXAF4jRjXQBz4hChKxyu+/AeMi4+0eqhZohqpxtll2nPRrk/fXkZtTPQ1L4KYzu6RCq8kTTWzh2MaFWMUnHrRMkcwN80/JHJmpC7kRgQ+LxfoQC9eCWTIWBz11D10KsBmL3GnfrlqWun6do/7kQndPw6nM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=J2JSGTLZ; arc=fail smtp.client-ip=52.101.53.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="J2JSGTLZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dmrG71TaPsto0YF+NRuRZPzqp17yTgPtvFhcbq6y+Qjg6SikvWdV3pLScTSuGEGgqO+gPTqlV8XMivERTy39YT3ZTiIcvjUnRhmv+wMnXc/LG/dCR/fPLQml0L2bXgDEJDZ5XPxNS0jNJwInpetJqHcEZWBAA8+q2kxXAiht4q5kdy70PAScAtIB6ctmDVicKihq3BMHgfZX/1BrICozd4kJNBTYc96UrFXAHc8h1to7s1vaKq44jmM9qmmalq8M8N4Q2QKi23rjrkjeE8YEwkXt3ou+Espwoj1Xh44HNvoMdpAkjZujocko7szBl0x3c7DRbzZK2iR1zcu3CukHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SdeQl0sMfwa/Q18Rj5Epbfkiu1gBeo/Ow4XsYngWJis=; b=UA5GY/wANIDR2Xr3PUkRoh/wnuuR8dOUzkxI2omP7GMNrtt6kXW5Rj4EZKlHMWT6GA82YChTZBVBMrT9iY7yD/9U3ubQnHvDuSHoTIVscA7+ZThDk0BHmxuhomdmn+2jo90vbaxGpetL+QfWdZi0k8ii5wwBCODItZreaDntUlLAjpjMzA3RtA7c9PSf1yVLg6Nw1xO+QP7QEFsNi2vN1opZL9iPsvTPy5/ifcdIeQVVQvRNjhFbDgt02Y51GB5pw2yAbrJ/hqtpzmXS1H+eUJFLkWperAGcEA94p9G9jKedaa3A/BeEdTNpNYpoJXDN6MRlUh5UQ9xo8d8//aDU6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdeQl0sMfwa/Q18Rj5Epbfkiu1gBeo/Ow4XsYngWJis=; b=J2JSGTLZEeEx8IQeJlnUPTClHkRrXQF4g/oVK5aUTcozr0vj09bxqIXTGHHS4WRMVBwqVZvzm1ViM+Izqwk0T4UgKAxiUhRXsG1YoNWAK4G3FK4wcMVdSBOp881z96luhQH2JS60hJEWDYwIvo/Rv8TIdGV4JfU419x0hKTm3GY= Received: from SJ0PR03CA0218.namprd03.prod.outlook.com (2603:10b6:a03:39f::13) by DS7PR12MB8083.namprd12.prod.outlook.com (2603:10b6:8:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16; Wed, 5 Nov 2025 14:40:07 +0000 Received: from SJ1PEPF00002313.namprd03.prod.outlook.com (2603:10b6:a03:39f:cafe::3f) by SJ0PR03CA0218.outlook.office365.com (2603:10b6:a03:39f::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.9 via Frontend Transport; Wed, 5 Nov 2025 14:40:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00002313.mail.protection.outlook.com (10.167.242.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Wed, 5 Nov 2025 14:40:07 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 5 Nov 2025 06:40:03 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" Subject: [PATCH 1/4] ACPI: CPPC: Detect preferred core availability on online CPUs Date: Wed, 5 Nov 2025 20:08:48 +0530 Message-ID: <20251105143851.4251-2-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105143851.4251-1-gautham.shenoy@amd.com> References: <20251105143851.4251-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002313:EE_|DS7PR12MB8083:EE_ X-MS-Office365-Filtering-Correlation-Id: 2229cb86-aa36-4473-1e86-08de1c793750 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FZkZVZycyEqmXezp/NN2n5+0vUkNBylhTeApLwC1J5EkXE4RO2aMtuEs8OVp?= =?us-ascii?Q?+Be8uc9Fs/P7zxjNpmggokhnLPuz3ommwnyYM7TbFPw2Sf1KRpAI6RjpFEXq?= =?us-ascii?Q?rdQl+Wp8CDgPF/edp8yCS2ySPqs7wIKrEKeexSACWlWo0v3XaNf4OhRMz9dV?= =?us-ascii?Q?1M2QJ30QzG1uSxOgDUy3b6MjI62M+J4mihoVt0LCNQOuO5OZ/F/q9N7bXXoQ?= =?us-ascii?Q?WxjjlTTpTJMm/9kJhFtJIJ3yHSL889+9eC6RkfXJ5J1Z4UDg53Kx8n3hRxeg?= =?us-ascii?Q?RU3ZGxP+h13sNq9nQm/d7u7s64+ONYjC9pGT//gcpcy2lbthooTyN7hNejV7?= =?us-ascii?Q?VsXgugBilBjLw0nFkngdfN0dgZo6nz7fRRIDAm08Op4RwM/JRKSulfMq7rT6?= =?us-ascii?Q?pj4j7SUyAmFcEC2+y9iP2R/WagS8SG6GVVfIcVy/nL2nsxIUJujQJTp4nMuL?= =?us-ascii?Q?Fyg7yCfOOHDP46okZpgjXt2ZNrzVxr92qARgabnmKBwM7lFa6utPfbZxYoLj?= =?us-ascii?Q?ABtPgwAd0869cDJDeeUQ+NOxhi/jdoJexjAyGFfolnJdQXMFy/rJY6AQ5QA2?= =?us-ascii?Q?dCDYTh+8wck8p8FDrt141DPalHueDswqP/wbmC4+CFMl+9DF2bJi+SHW68k/?= =?us-ascii?Q?tnIBJ3QBvGl0vleSJF3Im2qvVRu9+4KwZLaavBU+GA2TUSrRkBJA0TvhCMsB?= =?us-ascii?Q?hpcLS5lI9lVgwq/c/tVwUaIu4r4Whl2OftSVgSfz9B5LHzpYTIIA0/yQGj6l?= =?us-ascii?Q?AGPsEnlhpeivljRFDOFhucicdOdu0NNxHmTqcAyOIvkN3omJY1rgQf4gNpEy?= =?us-ascii?Q?FUwrIAUN4FgaUXn4oy+JRbhlsfi173Hbb2Ed6+FBvgv/yS+NntwaUNfJKMRY?= =?us-ascii?Q?Ba7Y8mxXKdyF2fRX6w0axAI88Gvb2dRPbN8ROJa43DxHjnONQUe3l49p6cN9?= =?us-ascii?Q?odSlntF2szCfB4onCNQ36yW95agFZkEeRccaL//zb6OrLYtEUPrd3gkb4ikW?= =?us-ascii?Q?baBdatJh2oPFGLHVndAndR3ixPT+k11eOeQ2DgByubKLQFJ8Z+9keHwTmxUJ?= =?us-ascii?Q?1ZWy1DDtcmtUvCaRx2+C2zLeeGVzol+nIovYrCMahJhH4Nrw+boN6N/oakvQ?= =?us-ascii?Q?lfeaqVXvSShjw7hXhqg6ydVj8JULXMvBdmDxGWGc3mUw3ttLWY5fO9w6aETJ?= =?us-ascii?Q?uvWIM0oicbSU0mC3NZNt8DUK8xeLzftFrNr1seWgC+yPSBmO2tUXurlnNEJb?= =?us-ascii?Q?V/Z7V7d6odA+sVCOB4880kyqWkIHGoOFFZVIGsheKAsqmQ4JrROSy+kGaXuh?= =?us-ascii?Q?rFkS/UYUEnAbiEEnM1qDDs8TEjqorxzZ2hG2PZiOCrSce4rz3PGorRMIgOGm?= =?us-ascii?Q?C9DvvRxuh+VrHlSJpqMcOflGj0B/m3lO5bBuIatFcR7yOFciIABRX78V9RzR?= =?us-ascii?Q?YBd6cvLFlWv5l1X+eo83iKNtUwhZbEyJ/uJ/vGPYVFtwh7D1Vdv3yIWj7Bhr?= =?us-ascii?Q?I0EpvZZcedEXbDrjsZ4YsBCXtcO3MgzV7orkm/MqSn1Y/6DOVRVe3ErjQYCC?= =?us-ascii?Q?gOiFxbIQhUUKN0Cxvk4=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2025 14:40:07.6372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2229cb86-aa36-4473-1e86-08de1c793750 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002313.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8083 Content-Type: text/plain; charset="utf-8" Commit 279f838a61f9 ("x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator()") introduced the ability to detect the preferred core on AMD platforms by checking if there at least two distinct highest_perf values. However, it uses for_each_present_cpu() to iterate through all the CPUs in the platform, which is problematic when the kernel is booted with "nosmt=3Dforce" commandline option. Hence limit the search to only the online CPUs. Fixes: 279f838a61f9 ("x86/amd: Detect preferred cores in amd_get_boost_rati= o_numerator()") Reported-by: Christopher Harris Closes: https://lore.kernel.org/lkml/CAM+eXpdDT7KjLV0AxEwOLkSJ2QtrsvGvjA2cC= Hvt1d0k2_C4Cw@mail.gmail.com/ Signed-off-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello (AMD) --- arch/x86/kernel/acpi/cppc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c index 7047124490f6..d7c8ef1e354d 100644 --- a/arch/x86/kernel/acpi/cppc.c +++ b/arch/x86/kernel/acpi/cppc.c @@ -196,7 +196,7 @@ int amd_detect_prefcore(bool *detected) break; } =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { u32 tmp; int ret; =20 --=20 2.34.1 From nobody Fri Dec 19 12:47:18 2025 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010022.outbound.protection.outlook.com [52.101.56.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0465432F753; Wed, 5 Nov 2025 14:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353641; cv=fail; b=IGAhldA2d1vJ/gaN20IqrbakleAMqJDZe8uBzvZ4rryrsIQGro2h6dR49Z7RDrZrAfATJOhNfVZl40KWRfnPgezDk/Oal5y9KKDwKTJJ320/1YQ3DFHqmhgWTnRalOQFESql3yfpe77kkl/flhJi9RwrUnG5AXVTnBwQopQeCR4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353641; c=relaxed/simple; bh=Ske18UpNe+6e/a8Ssht93pa8QczkQG2+33lxsyYqsGw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a5jHVT6WCxMJKE3LMgXZJsXotQiEToWmny1t/oTnXEW7FiFRBByVzn7h3TfjGfSOdM3WIeGpzMjqRHpeSTpC0yx7K3wmIPTFzgbhEhT0fCyRWI6pcC9IlZywYmSzisGQ9nhNM+q8XDpVdqTCEeo4INDaQDh4n260B3HRXmwPMWY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=290pJybM; arc=fail smtp.client-ip=52.101.56.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="290pJybM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WgrNGxTSYawYdE8K2l2T1blR3lybR9Q7LkPYFk/TN8L0Z0fza+Vwyw3kICLfNJ2sBz+NvnI1j8YIWHhYZZkxU5hBZIFTL+e1J/jQAozJcr5CYpVEQ4qBiRp6BQB3Nc16Ihfb4bgMOh/6pCADzVyKgllwhOjUsGoJkI0Hdg6LGvdG2vdc/Zz86NzLLJlWehw1seG+W2wSs9PgwY4cc62UKSf2i/9xPMZPL9yjzOZonPgbUtwRejpLJPt10tdFosVwSivqVx5EDFrFg/FmVMYDnYlZKndrxKKAPvSg6k+h3GypHCUpQaLomn8yy8zgPdcEX/qcB7R5ww+oIkP8yI3CZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10JC0U5Ndu7c60f2UN0F3f7RShDyiL2fwnXtlGggVyA=; b=A46zHj0PujZp53hSoA/1aoSMT8kkUU4JZ9PqAP/tYAu839JIAr4UHl0apf/ShSh0rkvqcjnLIhDkNWswFAxheBqLogbi8kPZMxnqv+mULx1OxdVBx0ka49ctQBNdvUoEKwAnXlzLWvmrBVZnw1b8eWAzY7MhHDf7GXo654TJyFMwB7HOFtNEEaovYCZlvDeaYAHDPp71by1wuY7+EtQ4GtCiwETYeDr4bqiB6XeHYsW4E5CWM/LsJkkpeouYkLJ36yWXWT8u80ktnuyw+3JuOVVm0599GUO0qeOQK+rRpJWmXCd2Fmqzi6ZxywTjOu1Ufvle1maAWD0xLIxe3iT3XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10JC0U5Ndu7c60f2UN0F3f7RShDyiL2fwnXtlGggVyA=; b=290pJybMPOVl9QnOL+aJs0F05qAOHMKThH1Ojbssz5wYdZoucddIj8oD2XYzDMDf+1DbUUbtb5YcOpTITWdn5VLEVwGt5ONURwTg12ssuhN3cgDgcXPKRFYvzfEYz7d+aS5Mx1OcJTEip7D54eq2Lc3HMpp3ttsjKdDSaJf9ZSw= Received: from BYAPR01CA0044.prod.exchangelabs.com (2603:10b6:a03:94::21) by BN5PR12MB9485.namprd12.prod.outlook.com (2603:10b6:408:2a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16; Wed, 5 Nov 2025 14:40:36 +0000 Received: from SJ1PEPF00002317.namprd03.prod.outlook.com (2603:10b6:a03:94:cafe::f1) by BYAPR01CA0044.outlook.office365.com (2603:10b6:a03:94::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.8 via Frontend Transport; Wed, 5 Nov 2025 14:41:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00002317.mail.protection.outlook.com (10.167.242.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Wed, 5 Nov 2025 14:40:35 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 5 Nov 2025 06:40:32 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" Subject: [PATCH 2/4] ACPI: CPPC: Check _CPC validity for only the online CPUs Date: Wed, 5 Nov 2025 20:08:49 +0530 Message-ID: <20251105143851.4251-3-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105143851.4251-1-gautham.shenoy@amd.com> References: <20251105143851.4251-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002317:EE_|BN5PR12MB9485:EE_ X-MS-Office365-Filtering-Correlation-Id: b31cea09-54e6-4a48-35ac-08de1c794836 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?25Kk/VGv5zCW1aZMmgQJFrrgoPydPEmuryLU+uCMu4TXFOXBDpPFTQ5/97Vu?= =?us-ascii?Q?N7pBEtS8ODTH4d0S0xQgN58/30SrplF1C3vqpG2UVGGMNKxbi6XfWTTcHTwz?= =?us-ascii?Q?V9XEvN4UBbvGHmpIItwqru1nBiDN5GKMTuGPwbIgUST1XG4AMjFpTMr1B0fy?= =?us-ascii?Q?lvJbasxwYuF3kBExTpOkEb6HhPCoIlbUAbm8wzslGKij2CA2WeqlXXEwc6wv?= =?us-ascii?Q?J/ZJL4qIZTpxgzGFZtCJWKnwEdjZsxu+mSROVGGeQc7FwFpS4cEyF0XTf8su?= =?us-ascii?Q?rAJaahpfdE4UAfoqCH6n+TzjsUnGwoyePHbmaniv34XaWdoIL18qa+xGvanl?= =?us-ascii?Q?2k1yCs2jutc1TsTjuzGURJWl2zjeUwvJiu6+iOZstvNtOyBUeH3Dkc7okmwN?= =?us-ascii?Q?t/1XVku4YIIVk5tZJn3P/xBz3gSWUbIgjx4/WW8YYXAd/vVvbHNU84xjqwLU?= =?us-ascii?Q?BdUF5wKDQcuYzlkHnQQbQ5AJbpCGwWKizHcII53HvnfPXBh9RdokBPxf6zph?= =?us-ascii?Q?HdUWzwn5UDGFV3tGGTYNvR3yZuOPpfd5hSPY5fpZo2+hJ3A5TS+AC1Nbg1Vj?= =?us-ascii?Q?6sQ8PdptNUAapimaTzz5vtD3d2ZhNQxyPE9EZnD6aaoB4zs8rmIMS1xgWe7A?= =?us-ascii?Q?HjaRXbr7dChlfDkiLZX+vwZ1xdolAkd7RB0W0JP1JbF8bvbSR4IkX4wU4Qel?= =?us-ascii?Q?HQwyxMEe9nG5AtQ0mMnzZKjxxPeVyNGE4HBsSqOOkuiPg+mpK0fVMB3+H3zH?= =?us-ascii?Q?55UTmE/IvMSffXtEq9onCD0+3QNNwUxO7a4LA9tQCZq5ar3DNCTl6Q3u/A9d?= =?us-ascii?Q?XRa9OnRKMYSAjZ39SOnYRYji3MvlUBrGaR7BIA7YKj5vKOdSw0J7IDRjrQqP?= =?us-ascii?Q?jjEq6FzkwuMUA7WldkiMox6YXZcFYP+LQdk3E86Ni4gO3fPWGbIGf59ICmjc?= =?us-ascii?Q?89Yd3jnSKbnKliK6Kc7eoei+LorWwY6RgwrpQQWImdHGp7h7T2yag+Nb0OEM?= =?us-ascii?Q?0bicNJCs3hQtgWbIVwQSxe0+WlN9nliS6niV+GSzjTAPVxzLXXSSA2BOZsWp?= =?us-ascii?Q?qJlLlEHc6KMl81ViFGtq6HmU65fisGSfroBH+DlKns7brhEAAW+jibfzCSAf?= =?us-ascii?Q?P/Zt1aSx9BYwCrGVPKIjFzaS9jVKiiO/JlP4Yqnz8OELtaKde7qfIxNKFg8z?= =?us-ascii?Q?6NxIBZFZkSBh4BhGAUulZvJrn21bV5QWtZjlD68HD53hIQH6CDqv0v7IQ8P8?= =?us-ascii?Q?/SHi4QNvErPcM0dC8T7XU5ELJf+Kd4RuIcbtXudwFUj6a2ECPjY3V2eEvKdp?= =?us-ascii?Q?TH5MCIpGGnLZ8XVdm9jI/ryJ4mAv0//ikcc9RhNCuYJbOk74iB3N1ESN7flf?= =?us-ascii?Q?epIeZhWO8LbGHxyQyhuMIUqrvBEPpmlk22wRqm/QN3nFnFnjADZI8A7JUVuV?= =?us-ascii?Q?ML52iUfjfIArVyjy0yb05KMZqVKOZWzetIjT3Xu5nntmqEGAI4bUlEvuOmIn?= =?us-ascii?Q?CWwz8IEkSPNnASnYnfescNCaW7JR0PtqvylAFKy4N1tTmeaOrp+s01xOAqPW?= =?us-ascii?Q?gadaY/Eb1quz+vpOOfes1bQS5BqEl8QRW3TkkKqw?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2025 14:40:35.9961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b31cea09-54e6-4a48-35ac-08de1c794836 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002317.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN5PR12MB9485 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function acpi_cpc_valid() checks for the validity of the _CPC object for all the present CPUs. This breaks when the kernel is booted with "nosmt=3Dforce". Hence check the validity of the _CPC objects of only the online CPUs. Fixes: 2aeca6bd0277 ("ACPI: CPPC: Check present CPUs for determining _CPC i= s valid") Reported-by: Christopher Harris Closes: https://lore.kernel.org/lkml/CAM+eXpdDT7KjLV0AxEwOLkSJ2QtrsvGvjA2cC= Hvt1d0k2_C4Cw@mail.gmail.com/ Suggested-by: Mario Limonciello Signed-off-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello (AMD) --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ab4651205e8a..50e6348b511f 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -460,7 +460,7 @@ bool acpi_cpc_valid(void) if (acpi_disabled) return false; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { cpc_ptr =3D per_cpu(cpc_desc_ptr, cpu); if (!cpc_ptr) return false; --=20 2.34.1 From nobody Fri Dec 19 12:47:18 2025 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011050.outbound.protection.outlook.com [40.93.194.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5138532E13D; Wed, 5 Nov 2025 14:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353668; cv=fail; b=HO8CWKqISQp7NqeDiZuYTQN+q2bWE0MjckPaeQTGGqc/UIT3XrVvgorpDS2zciKK+TC/aENjBMl7vVO4CLjvSLU5RHiPm4wEBHEhbPIhsR2Xe44gEKXXr1rD4mB/gYJy3wWNV0zl8X6sr5VbWqH+d2uftgUokM1e1t6Z9nd6hSk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353668; c=relaxed/simple; bh=YeMopl8Hb+SPrmtzkbKAf5PLbsPOqJGx+kjL/m+JWY4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BfVPr2Kcc2ffHin5aQEGtyXYxC+hlAPL6XqaIxBLDTV57X7irFkdq0CO3Fu78X620tlcZZkriYAKMdoMOv8tzbaYZ9n6vlkeM2MOvSWCZ4aJkskWDjURgeM80/d+u2Y+EtU4DJRw8F3OkZP1Byo0abmrsSNUiqmXr3FU/q30Gt4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bmiR2VxR; arc=fail smtp.client-ip=40.93.194.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bmiR2VxR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ep/XPj6gbVqq748GZIIAc4Yv77uxX/k2iHu++ntAiGDkb7rkf80I1w+HtVJ4m6KAkITguSZByMwism6UZX87V4i1fzGLwSpVh5W13JvkJVEjmr9aUTQh3eiu7iG9gaOB3yk0riWHmnzAC4mtm6OL3KxBcLlxjlAhp8HmPXF+jAWoVSn0xb3qyDUzoAQi2tbDbsyIlbMO9UWZjMaLh6ip2+tq/0uSDbJy/HwLD8nNahjMUZVeLP3aP+iqzNnvvgEfGJc8/uiZwuihE/KcPUhIUvIBEDzJQviWHgVJewygBEsCOKFuyasXn41kM1BjXT7ZMYxJhHnzw2sIZQnRepibVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V/jRnZyVfmd67MAd6Jl0ZbkiYit2XeUU6Inel5r7DFM=; b=GKjC9LtjKfYdUeU7oLChQnYylTOl8E5PIgU2EDAH9I4lfVvyTyvSzWrzZVAonZ9h87w15vIUYE+6ZEGHdv17JXiy/KAvVMgRzDdq4i08BGs4YR0xDLv6HocKDsnYCgP8j+tZTJ/pQuFc5etxWSoX+fXXJNnB8SNZ2cSSOPvd9k6KIIQm6CeBS2SOknwr8zrLlYteqoZ5v6lU75AxOwghtziHH94ip0Bao3hHLNrpCEikoffa82H2tIVA09Z0Krm4wTsY0BX1yoLxi1kdjf01szoTjtjQHXVLFCJPD1F5IjMXyKPfxcUTqbowj7TymcP0rOv0UE3SZyb/+V5MNdP+iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/jRnZyVfmd67MAd6Jl0ZbkiYit2XeUU6Inel5r7DFM=; b=bmiR2VxRvkZwtmSy12OlP4iN1alv3VEEtpkO/QuM+jpQ6A9Q/H63TWrNVtv4ZquJTu8uHe80Gjv3NTzacU//hPatwtDeIAhzCyReRQElFO159MKYo+ZP3AKXp63DPkvqK92tTEmheu+40EWxMaR47vHCPVAuZEb/KQPNTqmWfxU= Received: from BY3PR04CA0013.namprd04.prod.outlook.com (2603:10b6:a03:217::18) by MW6PR12MB9019.namprd12.prod.outlook.com (2603:10b6:303:23f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.7; Wed, 5 Nov 2025 14:40:58 +0000 Received: from SJ1PEPF00002316.namprd03.prod.outlook.com (2603:10b6:a03:217:cafe::b2) by BY3PR04CA0013.outlook.office365.com (2603:10b6:a03:217::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.8 via Frontend Transport; Wed, 5 Nov 2025 14:40:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00002316.mail.protection.outlook.com (10.167.242.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Wed, 5 Nov 2025 14:40:58 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 5 Nov 2025 06:40:54 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" Subject: [PATCH 3/4] ACPI: CPPC: Perform fast check switch only for online CPUs Date: Wed, 5 Nov 2025 20:08:50 +0530 Message-ID: <20251105143851.4251-4-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105143851.4251-1-gautham.shenoy@amd.com> References: <20251105143851.4251-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002316:EE_|MW6PR12MB9019:EE_ X-MS-Office365-Filtering-Correlation-Id: f5107ebf-bd3f-489b-bb6d-08de1c7955a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?307QQZ6aeRqV1PDvgd5cnHW82Pl5D3KZoBf6SYqXsaNlTigfOuQyKHhXPqvG?= =?us-ascii?Q?SdChpplUz/OQkARcei0QFXJrsjx9ge/bwAufmeUP6wxd7sakqJsoTm4AW1KW?= =?us-ascii?Q?XlllkiVhIo7P6RLSMzIRK4IWCKtBLfB//t/gEFoHl7izRm0tSitvyFM+xXqi?= =?us-ascii?Q?beUMxTDFvNA/KttThMvkynHe4lftPYfGf8BFqWMolpX/fN7Kb3mNNNHM5amR?= =?us-ascii?Q?ZXUEw6cJHOipxMeZX+jBteicSt2LsXeDHyPmVoLzIy3k/oNyRZ/pZqS2ke/Q?= =?us-ascii?Q?MPxnV9oFnIiqR/zSNv8pgbVQsXhPapCYFQNjDjeO8cK5HrzY4bXuUFu31mdZ?= =?us-ascii?Q?2yNviScJhVELCsbCgRxWgXlA65kopdfJvTvv9bUB5paWGFmmiguzvs0pDU0r?= =?us-ascii?Q?APfNjbPn4DlThdQMxKylMSp94NAF67gthh73dqErERWQXSy1HHSoPivn1GQv?= =?us-ascii?Q?apWMNpNRxNIYv1Pr7md9u4skAW0qC0cpk8M5x0jnAKxHXIyQ9V6++s0svnrF?= =?us-ascii?Q?4hjjKgt+4PP6/j+2YfbnjDWum65GQK/A7mFgMemTLhbEfO3JcNrZonOea9eg?= =?us-ascii?Q?eX34XE+Hqt5joC2ASqQOb6qEB7Z4I/g0Zr1UpaBRXfKFQBMedNCQ7AE/zP/Z?= =?us-ascii?Q?cwZy/PGmRcJk2t4YUmFnReKiz7Lj+s/IX8AnCypeVxov8T4UyVtk0s21Z0CT?= =?us-ascii?Q?oPy/l7kZA96lwR/cwyVPHMKlfQwYPW+XQBl7YKcAMi2iYK2xEInwuLnbakBe?= =?us-ascii?Q?khQhE6pNPf9lxIFfwXYlo09zmezvrdo5fItMTs2zPh/1C7h5nz8EygbqBbDv?= =?us-ascii?Q?u0JhcfoRQ25e8KgQXdvHm95zIeYEsliAn81mjMwOPRtd6GW8UP1gH9VTjm/x?= =?us-ascii?Q?Uxh9llIfvuPODgjndyG7nhK/JB58SsUcZo2hrTtk/hCGQfAdd1YlVMCJbuS3?= =?us-ascii?Q?ooFNGRmdRKlKTdHmQaT9MIKB8JbHN5JXtKMDk6cj77pnpU0mK7jqucbE3BZz?= =?us-ascii?Q?r/I0Wq37fcHCIy779otp4bLT1vhRS961j8PeBywSJg+rH/9cu5Rst/eGSvkg?= =?us-ascii?Q?IGiPzDXKccubplK3EdSI8MHX8CcRTLKiSETXD8+du0lzQD/00JZ82eAnAvwg?= =?us-ascii?Q?AVJOWVUSCrC8udcvy9yrf0LXq78xent6uheB5+0SN0EK4F3UAdLZtluM0gBj?= =?us-ascii?Q?Hm8v4m9KpBbEd/fe+U1I4RW3SG6+xOnNZpXi03nU86R5EmgvriQ7PS2lxErc?= =?us-ascii?Q?gxqLCht968L7WQ8AR0fmsOmZvVHnlPExvNcVy8TINl+4EawTTse0zyKaRszY?= =?us-ascii?Q?evh+JEgsswUrs1avPjKj2uroFY0lqhXO4GAZJ7oSI7a6+xKAZGLnoiJnfpnX?= =?us-ascii?Q?kTRWMvB+r6tY5idgzT/76YWBM5vAezKv3V4sSW0U4cQZCCEAxuBLpn0mG3zk?= =?us-ascii?Q?DQOFgi1nl5MqKsIj25AOT/nZRCavAT5vlBhFKE8CAa7vIN6uGwBZX2udk5MZ?= =?us-ascii?Q?on3Y1pyM+L1QIhi4Yy5stoPlv013K/JjzUuPvaZkPvQ/FjbDJ/6EKAcvVqx+?= =?us-ascii?Q?Zw/zYwuNTTqXB0+SVOk=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2025 14:40:58.5393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5107ebf-bd3f-489b-bb6d-08de1c7955a5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002316.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB9019 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function cppc_allow_fast_switch() checks for the validity of the _CPC object for all the present CPUs. This breaks when the kernel is booted with "nosmt=3Dforce". Check fast_switch capability only on online CPUs Fixes: 15eece6c5b05 ("ACPI: CPPC: Fix NULL pointer dereference when nosmp i= s used") Signed-off-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello (AMD) --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 50e6348b511f..fb7696b27d82 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -476,7 +476,7 @@ bool cppc_allow_fast_switch(void) struct cpc_desc *cpc_ptr; int cpu; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { cpc_ptr =3D per_cpu(cpc_desc_ptr, cpu); desired_reg =3D &cpc_ptr->cpc_regs[DESIRED_PERF]; if (!CPC_IN_SYSTEM_MEMORY(desired_reg) && --=20 2.34.1 From nobody Fri Dec 19 12:47:18 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010063.outbound.protection.outlook.com [52.101.193.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CB5F32E68F; Wed, 5 Nov 2025 14:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353696; cv=fail; b=FwuEoLBq7WlK/reTHLBP6aWklsOIP8yCFPwrV2S2wPv2gjNziX4lb9UvcJjtqfoETFxrffBwFgqVf5j38b1pifD/QUaxs93VTiySYo1Inz9KglYCfrYcxyaUfsLU6ptJdOyzhzL7+8bXWaQaNxp8esZDzpBT6IhixmDlOrAqVzI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353696; c=relaxed/simple; bh=YNJshCYQUwrPA63hHVbFZwEWyn15/ueOZ1MbDDl98vc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rm1pMKNXDga4i8Alk6mD2XDy8hHepJlPJ4YgsWzY7CVNtFm2wOR09J9XOEmp5omSE5aET2Z7vdydqexuZ9U+eGvPmPfqoPcH9vF/j0zmQ/91mABd0i1QlBY2XS5GTC7OQSUoMb7/odyzlleWDGCjAvLCnV7/5+RLAcnqvpLn344= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=PeMjFFwR; arc=fail smtp.client-ip=52.101.193.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="PeMjFFwR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QqqccDG0IuV6vKTfrdErO9pMeR1mVhdRscP+PeJct9ojA3Tl3oAvfAFmhT5S5Uh4SgtrCkQ79WwlhLwhLiIay6KcycpW5UyoRo9FdgMhIT2VQNR4D7j+hRphqP8NUGCI98y7r3VLBbCXtLJnX4RIfUk0sVeoIC+ra+cv2umXxxV5Dij0u7EtG2h8DOYXbA+GB1nKh8KRb7o07T0yyI7ou5OYqxpFhZePxaUL37avkcpMT0I6MYEBfzskqIt1oBnmqmyqHWp2Etwb/EjNePbgl3VLsd1mlwoHIJEp/lOY9Rquy5wVud2y26NP/dCSMLnLXrWuHp1/Uq3dyC1FRTe/Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZqQaR26R/Cu7w+D/eMKDKKtRja+2Zg2FEKl838Exoss=; b=CuLKmEPjcc8vfLF96DNptySGyqvaFeEbWxnhqZoWHp6YUGKuKqzz0V6tzwETLvXqPu3y1niQABSnTe/bFG3EQGIAq4RObUsz8bw1OvP+j+fkv5/Kdk2VWvSAh4o2X8uNVQ59z0yqIcwRiWHacD3C8cm6ZKyveHrprJ0Iwyv+iC67nFvQDlCBAV4BFwmsDB25FHaN7Nc/ZhVDlxzhw1pgQTm/q6FzGEDt6Agly+c53EaB0nFUq979kKtAOwPIFXJ74+HiLtog6XACiCAMsdEwdr7/uMmmgJOvUNPqBb0XDPz3VlShk+pkt6W9D5WhP8Fk3yvVWPLZl4eYRp1KtNuUpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZqQaR26R/Cu7w+D/eMKDKKtRja+2Zg2FEKl838Exoss=; b=PeMjFFwRO5CCj5q3oAfSPnxOtxYWaAuX0/nOjXVdNSCYGChaVCM8+laqRGSsmrOuIgRVA5YG5TuIWqWIQRMpAGAvkFvHfGQnbBv5akR8JtZcK/+xSOW0FuyRDxME57KevjObwqehU6MofhQkNASTbpQox1X4Q+DvkzjIy82YHMI= Received: from MW4PR04CA0051.namprd04.prod.outlook.com (2603:10b6:303:6a::26) by MW6PR12MB8705.namprd12.prod.outlook.com (2603:10b6:303:24c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.7; Wed, 5 Nov 2025 14:41:31 +0000 Received: from SJ1PEPF00002314.namprd03.prod.outlook.com (2603:10b6:303:6a:cafe::ca) by MW4PR04CA0051.outlook.office365.com (2603:10b6:303:6a::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.8 via Frontend Transport; Wed, 5 Nov 2025 14:41:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00002314.mail.protection.outlook.com (10.167.242.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.6 via Frontend Transport; Wed, 5 Nov 2025 14:41:30 +0000 Received: from BLRRASHENOY1.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 5 Nov 2025 06:41:26 -0800 From: "Gautham R. Shenoy" To: "Rafael J . Wysocki" , Len Brown , Mario Limonciello , Yunhui Cui , Jeremy Linton , "Viresh Kumar" , Ionela Voinescu CC: , , "Christopher Harris" , , "Gautham R. Shenoy" Subject: [PATCH 4/4] ACPI: CPPC: Limit perf ctrs in PCC check only to online CPUs Date: Wed, 5 Nov 2025 20:08:51 +0530 Message-ID: <20251105143851.4251-5-gautham.shenoy@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251105143851.4251-1-gautham.shenoy@amd.com> References: <20251105143851.4251-1-gautham.shenoy@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002314:EE_|MW6PR12MB8705:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fe38b13-253f-405a-20ec-08de1c7968d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?me3jDVoWu/HlV5JRgb0jglcdxd4xjG3ZpIOtVmhwsB8fxq5FJELOvVAbrIG6?= =?us-ascii?Q?RKyXh/yuoZ4cXVtaZ5CXR1PihgwJqYp/Dk+JN70FdXQOABULB/BLaWuwI/54?= =?us-ascii?Q?7N2ifiLHli4aLGs5paksVQgb4xvtxR2TBdcUQVcFbO7FgXE5KE4DecpqUsVw?= =?us-ascii?Q?GP60fqvaWAuIKXEaeCb20tvy9rdzVguGMLWIE4RI1X7Dwnx+LXoqbkrixl4G?= =?us-ascii?Q?8L3+hRwZHYfqnmZ6jhrxMhfb/H4LurOzoSyph/ch+OlhFSlpXg7tmcOorBls?= =?us-ascii?Q?LkMdik+pXu8WawX2xIqXevykrWJZzsq4oToQ+lxMWSpllqiHmyp/VpKh+DL5?= =?us-ascii?Q?RDAqy2Ip/QocMJ0hUzQ+0t466HsmsG1E1yd+wxL2Ql2DRlAjUjXAzjYCr7Sb?= =?us-ascii?Q?iQOkocaUF0sgl7RwqlYwR04Z9l2enNw/JtRGRtlPpP7Gq4uEe+H7wztmWMiR?= =?us-ascii?Q?3p4+8Qkp0n/le4i2SOOk5UEq+TqexuY8+qt17TGKiez6y/ot/Xa6gDIfLy2X?= =?us-ascii?Q?prF6TdJg+7YYqQEbbYubMtlyp/38bzCj6+9liNGJ5UommVN1AaW+yBQhBT21?= =?us-ascii?Q?H7eNtc89utD08bfhXLLCC3khs98YeTnoYa+RN5L7TJmdjW4996FZYjWUgG3P?= =?us-ascii?Q?o8B7Ijqjv4H64ZqsJgCHpb197MSmr0392jsW/Gzhm7l9ZnwbCudVrJegrgO2?= =?us-ascii?Q?WeiE8B9mW3n7L86lDjhubCkFuh92ARUtsBvvxCBSDoZsUgzeKhjesGS/6pGB?= =?us-ascii?Q?30X10iEX98IQAb7+/J2/mtI3UGB2iN8c9z8GV5NNr4Qoty0oiuQu7kAEpzUl?= =?us-ascii?Q?STodvU94bUUVgqyS82ctcsm7oB2KEGmxFpUbf4Wb0ZDMA7qwN+ub502j7sqc?= =?us-ascii?Q?iHbJpaK1elxCrgByreFIZoDF10s9VLepc3MW2JLoovMjZPJwI/Ya1kX/NCdw?= =?us-ascii?Q?tC5buyOQqvyCJAybjZzvlX/0q89GvWg0CRkBofgngMdcciHnk2RP7hh4NkxG?= =?us-ascii?Q?Irw4BmxXyXoKzUEbdbK3+y2vUIC33HiAI35SbNvKcIuQZgW7oC3SPVb4LHxY?= =?us-ascii?Q?lSE37X0GoIV4swww97JAWvTdiqanlr9uuzpFn5KIyvjp5zhVM8tMzBFNDy5m?= =?us-ascii?Q?2BMvB27QCcVCgpDyWFYIg8c961UEKdA+qnZ3P5+3wAkzN9EVvih2XfpsYhsF?= =?us-ascii?Q?qTrQ3XIs3GYXH3cf5v6fqDYAkkdflX4RGmp7qmR4F66SLd0cleBXu7TU00dW?= =?us-ascii?Q?b7SOD83R0EUju0lwQFC8OzZJrfx8pCL9DHZZ6PnNoHLstCPd+mFYzNavcEGb?= =?us-ascii?Q?3kxPBK7NCLFpwK2PHXJUbf6YW4wWVnetqwPdhjCw6AIl/FzE/2fwMnGSqVZ1?= =?us-ascii?Q?ZcEbGVPqgAbAxQOILCRqGF06cqPMfvPiLBr+Fu/j4BMX2kCcc2bis116a42N?= =?us-ascii?Q?JikxhCTOsR3OgoknWfjoWstxLDVOg2LRnfcCAtzW9ILDcOsynOX30SIXdGF3?= =?us-ascii?Q?r4cQfw63rWLxTT+RfvSb4G38sV1y/YMg5cMJAsUFfb3VrNRG3YDOb/PlkJ09?= =?us-ascii?Q?l7XPCoq7XCc/E4w+/rM=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2025 14:41:30.7255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1fe38b13-253f-405a-20ec-08de1c7968d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002314.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8705 Content-Type: text/plain; charset="utf-8" per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online CPU via acpi_soft_cpu_online() --> __acpi_processor_start() --> acpi_cppc_processor_probe(). However the function cppc_perf_ctrs_in_pcc() checks if the CPPC perf-ctrs are in a PCC region for all the present CPUs, which breaks when the kernel is booted with "nosmt=3Dforce". Hence, limit the check only to the online CPUs. Fixes: ae2df912d1a5 ("ACPI: CPPC: Disable FIE if registers in PCC regions") Signed-off-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello (AMD) --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index fb7696b27d82..f49c72d3a78b 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -1435,7 +1435,7 @@ bool cppc_perf_ctrs_in_pcc(void) { int cpu; =20 - for_each_present_cpu(cpu) { + for_each_online_cpu(cpu) { struct cpc_register_resource *ref_perf_reg; struct cpc_desc *cpc_desc; =20 --=20 2.34.1