From nobody Fri Dec 19 10:57:20 2025 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74CEC2A1BF; Wed, 5 Nov 2025 03:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762314504; cv=none; b=PpKF/P/aAo2S3pF7COxh43X/Q69d8hqyvxFL+ZQ3GIcWW3SFcXUg4u4O75g6V8FcURFZ1iaNUwOjW/I9ZNEkkJBlYh3gWPi6L+m/baIjJf7y1YJgnKpaSTWathyE2EuNGQrzyyveRPuJoyo7waDKJI6taw/Fw6HtryQx8oZWZMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762314504; c=relaxed/simple; bh=XANd4G32AqWyVQdfBYh557uL85JORhL8u3ZtOFm0xYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ad1lPq9ruJ8quRR2eIMksSpcyzpsiYmkbRNv+6Bv7LAK41LfRyFvRpcxFe972KhqFCQKov3io8lxMOcV5vc8eHHlUATgCMwwATTqZzve8lW0GU0r72fEsWaZWDnAAKR/hwhITd3upaktmPbcs0toWFvWvpbc9WTCXJWYGjq1PxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-05 (Coremail) with SMTP id zQCowAAHse_0yAppzc2TAQ--.26348S2; Wed, 05 Nov 2025 11:48:05 +0800 (CST) From: Haotian Zhang To: Herve Codina , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH v3] net: wan: framer: pef2256: Switch to devm_mfd_add_devices() Date: Wed, 5 Nov 2025 11:47:16 +0800 Message-ID: <20251105034716.662-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20251103111844.271-1-vulab@iscas.ac.cn> References: <20251103111844.271-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHse_0yAppzc2TAQ--.26348S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw1xJrW3KFyxXryrurWDtwb_yoW8ZF18p3 47Aa90yry5Jw48K3WUZw4xWFyrX3Z2k3WxJr4UZ34a9r45XFW5t34UXF12ya1UJrWxGa17 XF4fKrWfCF1DX3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkC14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v2 6r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUonmRUU UUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRARA2kKtTRV4wACsd Content-Type: text/plain; charset="utf-8" The driver calls mfd_add_devices() but fails to call mfd_remove_devices() in error paths after successful MFD device registration and in the remove function. This leads to resource leaks where MFD child devices are not properly unregistered. Replace mfd_add_devices with devm_mfd_add_devices to automatically manage the device resources. Fixes: c96e976d9a05 ("net: wan: framer: Add support for the Lantiq PEF2256 = framer") Suggested-by: Herve Codina Suggested-by: Jakub Kicinski Signed-off-by: Haotian Zhang Acked-by: Herve Codina --- Changes in v3: - Also replace mfd_add_devices() with devm_mfd_add_devices() in pef2256_add_audio_devices(), which was overlooked by previous patch. Changes in v2: - Use devm_mfd_add_devices() instead of manual cleanup. --- --- drivers/net/wan/framer/pef2256/pef2256.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/fra= mer/pef2256/pef2256.c index 1e4c8e85d598..180edde177c6 100644 --- a/drivers/net/wan/framer/pef2256/pef2256.c +++ b/drivers/net/wan/framer/pef2256/pef2256.c @@ -637,7 +637,7 @@ static int pef2256_add_audio_devices(struct pef2256 *pe= f2256) audio_devs[i].id =3D i; } =20 - ret =3D mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL= ); + ret =3D devm_mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0,= NULL); kfree(audio_devs); return ret; } @@ -812,8 +812,8 @@ static int pef2256_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, pef2256); =20 - ret =3D mfd_add_devices(pef2256->dev, 0, pef2256_devs, - ARRAY_SIZE(pef2256_devs), NULL, 0, NULL); + ret =3D devm_mfd_add_devices(pef2256->dev, 0, pef2256_devs, + ARRAY_SIZE(pef2256_devs), NULL, 0, NULL); if (ret) { dev_err(pef2256->dev, "add devices failed (%d)\n", ret); return ret; --=20 2.50.1.windows.1