From nobody Fri Dec 19 12:48:17 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE23C2153D4 for ; Wed, 5 Nov 2025 14:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762352437; cv=none; b=RwxDXmSHmiK2sYGG+4LMHbEXxYAUD0hogQGPHCJMRbgN+b/6ElbakMbwg6SWXPXoCghmYl3zxuQdTTOn2gGbUBbiyM6Hy78Zgq6DZO0COpIPvXHnG2Enxx3DseuXThwPQMUVLJeRXfiHp9JHQtr2Q6Rm9rxc8eLxqYUKKg97Alk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762352437; c=relaxed/simple; bh=2bydY0FEOcssCU3jumasSDa5bWFLWCHjfTYBtgqnKTk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LVXpPvaMbFvw5uXW62fPZLRzvkvTiIoAFzzfKspQgaVDdPEpKdixi2lOtmP7bdKCoXGP6tbId8HGEnUtNmd+rZmyaXhGMcrx3yo1n4o7KpyeDOIMuEw+++wrfknzV/iceb6xWHkuaqvLIJSRDR+voqgBvtzdadw4OYBR2oYgJqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BIteuqAq; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BIteuqAq" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-780fc3b181aso4852664b3a.2 for ; Wed, 05 Nov 2025 06:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762352435; x=1762957235; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=lKHHVea8wTIQH463SPis4pm7eX04G+ekedJN9dG7siI=; b=BIteuqAqsJRbkO2aBuNMzwCpeewN0+L2ujCWedng31IpnBdqxRHuJAe3Og2SG9jUmd bQTQdTEnBTdKLmSpgAZFSij71zpaqGiuBrd3ZAYWtKEGMuAmZ7fHIq6Qupuhan79hOtL lh0dRyDCwkxKEr9pprsVj/K5Y68rTU6vstbd/M/tQCoAsGQlzPqYHnN2R89XSnQjTYsl iGlL4xc3U411u24B61v71cx7CRSe5PBb0KjxEkkK7w3Krf2w/sRgsD53I6c6CNsgP2HH EUjJ7bxGf/EmzJ7Vuk/Dj7UFH8wEu3tDrBYqFilZkOas9iTjEgVP3GOPLhrGTmQ06aZi E7jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762352435; x=1762957235; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lKHHVea8wTIQH463SPis4pm7eX04G+ekedJN9dG7siI=; b=nd4J/yNkYBF1nx0DzqUeZ0yrwbBJrgrSWt8S/9maUc+RoKaBgPGy9ClOEUhEXi9eWA v2ltDr5VBaHLcqWQSXsDMrKKDJ/g3BDCWvUaHNir1QhXIN5BhA4Gv08E+8sSKpWIVsj+ et16WK7pmfLwsJOM2IHsu0w3OZHrJoCgERADYLG+JDnD6DkMxxxJO9uU5IgPM1HQQZSt DFcMrmxPQM4CfMSvvuk1ul3f16vPql3Bb9t50VzD3+KzjkCCOAMo7LzPIwTqkP4ai4r9 0Nb9W527e1YjHdfni9QrSQ8yqS4H3PQaK80KRs2ebwMghM4BI5LOv6tUZZ3fZn0FhtQC 0LYA== X-Forwarded-Encrypted: i=1; AJvYcCU3fUCePxTYp0BT/t1r/g1iBD6aLdAjAZ4HBvfKWo69cwqJQVx3HE4p+yxJwn0OnpEJUOgrIAF2tp0NrGg=@vger.kernel.org X-Gm-Message-State: AOJu0YxiD0HVg9ZRnFMSHEPpD78tT1N6HAo4PBcHIxzhyRMTy/Ow/H2a ygiqrIwZwv/2zedMuHrKcZrwKvBZPb8FzWqjr4QyzvGU4RZXBqrvUBIF X-Gm-Gg: ASbGnctq1XeWbdGdCkYXDD5JjUSqO8mzgJFXrUSwlqtnE5LamhIh8xWZhdEIeo5mPJ8 eGqSbMLW7mQy251zRdUleUyWMrnRQbUm7nlo9P88rRNAf+GEtmXc60fjfn/8g1ghcFPqWCWnjTf p1QwtTdu82bxMhevrSf3d70WRBzQfXJ6cFQS9Xvav/FkbEQPhJThl2ELD22tUjFWVtC0uI6Bzg+ KuErICYA20aty1PsVAZDfX0aej5zwts3YatUg1ggaFTrmREY6QBIMwJHQlmirrzFPM4Uu6qxtCP XW/mReBBo3PnECAq1cvTURoWjTj2o9PvYEtkph9hSXk94Y96RaNKVmdQIcMKRtnTtnGQ7Um+w9e /48vPfpr1UQxRS03MUqpbqsmNMF/1cWEPqsVLvAA/ONrnhW0nfewijzrao/7C2e1kMRHqq+cvYL s= X-Google-Smtp-Source: AGHT+IHzTTnPsxUzWsrmGxTIjfu7iWPk+D21UhbLo2AmmafmiFkrQxFxAHL2VAWLOH/Cs1o9hs8q3A== X-Received: by 2002:a05:6a20:3d23:b0:342:1aab:4c71 with SMTP id adf61e73a8af0-34f839f5a40mr4658333637.4.1762352434947; Wed, 05 Nov 2025 06:20:34 -0800 (PST) Received: from aheev.home ([2401:4900:88f4:f6c4:1d39:8dd:58db:2cee]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-341a67e2f82sm3198879a91.0.2025.11.05.06.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 06:20:34 -0800 (PST) From: Ally Heev Date: Wed, 05 Nov 2025 19:50:28 +0530 Subject: [PATCH] tee: fix uninitialized pointers with free attr Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251105-aheev-uninitialized-free-attr-tee-v1-1-2e1ee8483bc5@gmail.com> X-B4-Tracking: v=1; b=H4sIACtdC2kC/x2NwQqDMBAFf0X27EKyNJf+inhY9FkXSpRNKkXx3 xt6m7nMXFTghkLP7iLHYcW23CT2HU2r5hfY5uYkQVKMIbGuwMGfbNmq6dtOzLw4wFqrc20QRCI eCVNSodbZHYt9/49hvO8fhMJ3o3MAAAA= X-Change-ID: 20251105-aheev-uninitialized-free-attr-tee-0221e45ec5a2 To: Amirreza Zarrabi , Jens Wiklander , Sumit Garg Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Dan Carpenter , Ally Heev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1580; i=allyheev@gmail.com; h=from:subject:message-id; bh=2bydY0FEOcssCU3jumasSDa5bWFLWCHjfTYBtgqnKTk=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDK5Y/WKKr4yXPn5c0ZQ2G3bhTJfr3T2H+FlvFrzm+2UY VRb8fQlHaUsDGJcDLJiiiyMolJ+epukJsQdTvoGM4eVCWQIAxenAEzk9wuGfyZ8RXmOCltyiua1 Kr+MjrH/93OBS71P8p2b2r2nLl7d4cjIsPy2e3PVJPuES6Zzd3rm5T5IvbZZXNVg/eerInc03p/ 2ZgYA X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C Uninitialized pointers with `__free` attribute can cause undefined behaviour as the memory assigned(randomly) to the pointer is freed automatically when the pointer goes out of scope tee doesn't have any bugs related to this as of now, but it is better to initialize and assign pointers with `__free` attr in one statement to ensure proper scope-based cleanup Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev --- drivers/tee/qcomtee/call.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c index ac134452cc9cfd384c28d41547545f2c5748d86c..8b7b4decddd8d1811dc0a7cc46a= 4a4fbada45526 100644 --- a/drivers/tee/qcomtee/call.c +++ b/drivers/tee/qcomtee/call.c @@ -645,12 +645,13 @@ static void qcomtee_get_version(struct tee_device *te= edev, static void qcomtee_get_qtee_feature_list(struct tee_context *ctx, u32 id, u32 *version) { - struct qcomtee_object_invoke_ctx *oic __free(kfree); struct qcomtee_object *client_env, *service; struct qcomtee_arg u[3] =3D { 0 }; int result; =20 - oic =3D qcomtee_object_invoke_ctx_alloc(ctx); + struct qcomtee_object_invoke_ctx *oic __free(kfree) =3D + qcomtee_object_invoke_ctx_alloc(ctx); + if (!oic) return; =20 --- base-commit: c9cfc122f03711a5124b4aafab3211cf4d35a2ac change-id: 20251105-aheev-uninitialized-free-attr-tee-0221e45ec5a2 Best regards, --=20 Ally Heev