From nobody Fri Dec 19 12:48:22 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F3533FE05 for ; Tue, 4 Nov 2025 18:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762279814; cv=none; b=PAZEqV8s1DScbZoCiu9imRptCDX/3bXkciL16iI/a/dF8v3kk3//w4Yok2Yp1lhwFlzxjWzN6N5Uwpz5oMcr0v7/HVMEC8mHfBZomf3azP1gmvZBb0qJ+HPQucFefn54s9dihJFOaqraWjYaAF4r2IfKjDT0UraTrn4BOzO0Gfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762279814; c=relaxed/simple; bh=skVQGagTyy6PyNFI+F7smYSL+wQwoaFNd4LrPRY1PcA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Py3FcYYmSGTmv3OZYi/tKY6YmqmdBdtLgfpkDiItNcFIeFakkMy9VeNujVAWgtd5X7vx2XOOTY6apUx49rliCjeZgnaMx6t/HBwZ2qHWNmwCH15n2xbSjPkPGphwxRj8J2pKWFnGW49p6ZkxDON7J5w84CTdnlEzO6xdp5bi9LE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OfRc9Jzh; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OfRc9Jzh" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47721743fd0so31652485e9.2 for ; Tue, 04 Nov 2025 10:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762279810; x=1762884610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bDqva417xyNryg1IXFcTOy97H9FHEQaAyTZzRiGHEe8=; b=OfRc9JzhDWt8BJiJaBYWapcUOItNqdGmbQdDMNpf0YM7Aruq0r0kOZj5AlHR4F29RI cByChtrXc2xxVvM8w93swiUC5r+jbjp0lM+EoDhsrCN6mkaUZTli322//WeT9AaTv+u9 pH2McOQ3qzQz48+AL9nZ3FDVYwZqQzOuSkeTFXd8x0XE6ped/oYqmiCbGYlKcjQ941Ez hniThAN7iNcmk6VBYI6do9Wdhw7SqZIqmihVfQUx2wKUk1eoOsLDhZPjEjrbUuOj8Qva ypyyzwZp5V0w55TUS2ikemvCxjrMIj5kau441jvYHV3+y6j3b0EshimVbXt2BTPb9cv8 isYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762279810; x=1762884610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDqva417xyNryg1IXFcTOy97H9FHEQaAyTZzRiGHEe8=; b=I/OfOCSkdn+1maUpok7MClvWX8XyaPCijnB7LtE/Ho01ygJUXgyFwpwW1DhQa2mExR EJM1N8VKpALkLL2sHwDkLI5YjLtbsja01jOBdBS0lMU9ABxGwvqEs7P25HFA9P3b/8wf d1POhBgZCxTZNPbYldeIZ9QTNabVdWg5e+/bp2YAxBIjomhRn68pc4e/5D7N2TAlvlTF GDoz6k9JwhztnaEmcmZgyVcI9LNUi7b2gUBe1SU6dSzWgfO2RKxyEsBHcP7HJA2ZfyB/ 4j18WDBZmUdjiYhge2f7A9rTulj1pw6/KD5w5WmwNHTjaU+pFCZftGMBG0Npj0Kz2MSR vUjA== X-Forwarded-Encrypted: i=1; AJvYcCVl2VQBpAjH0dF177X4DrJ3VU5iG1Ixp8tY/Lu2YqbGpMwe9ex98Vv2xKHJ7SNDTudONxTINflxMuoIcRU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxRFzxrgikuV1DKaPBwfk94Zo0vnexgTNwRpHtJL39hLpaOVH8 QeRQDluR1zYs9NfgOPhE0rzc5wuLS0YyEnHUplelHBD23Ehl4gT8eJAQ X-Gm-Gg: ASbGncuauahrweUHvyMTFiCwJ/zcWX1T5YEa41UAUJ0ixY9O+63hGXKM3YyCM0ldG+6 f9vdWAADV0RqL475at+rCR/nkFNKXuYJ8IxSw4K1ympYdzBQZmgXdXfwH9cbEM91TcL7wylqvOT TBoKffV+CXMtTtbYwbUt46tQlbTiNknJf5W2emoi+GcVQs0f7xWQMcNmwY2AhLPyUb3YcDEyU7B tjxvQqigjWEs6/pAQumwaT8aDn7DH5DSHiCGdZYDO4dZHhFhKpPYSzblyYPWbn+FeJLI1mC0rHT D/hpLLURymMivJvkjKSJGd+5y+a5AaJiE/vy3S1uMH/saTe3PcZc28zth0B5SR1KIVKJdlVo0oA nAk0Fgmx5g+oxUYh6/1nAGP2xzWoPjrHTZlgXoSlv1cdrzvvkZzt5VCDjD5J1vHzWqfFQvgsDg5 Rbx7ZZ0VN8U8F5Mk+K505Sl0VFPaSq X-Google-Smtp-Source: AGHT+IHj09IPAOCbCEAg0ncAsr0LC5H9NwCy7b3YSE8GChtZbFobh2jD5PwMN9j5D94aGK3dEVmPNw== X-Received: by 2002:a05:600c:19cf:b0:45d:e28c:875a with SMTP id 5b1f17b1804b1-4775ce19fa1mr2767805e9.31.1762279810441; Tue, 04 Nov 2025 10:10:10 -0800 (PST) Received: from jernej-laptop ([178.79.73.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477558c1a03sm24688685e9.2.2025.11.04.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 10:10:10 -0800 (PST) From: Jernej Skrabec To: wens@csie.org Cc: mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , Ryan Walklin Subject: [PATCH v2 07/30] drm/sun4i: Move blender config from layers to mixer Date: Tue, 4 Nov 2025 19:09:19 +0100 Message-ID: <20251104180942.61538-8-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251104180942.61538-1-jernej.skrabec@gmail.com> References: <20251104180942.61538-1-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With upcoming DE33 support, layer management must be decoupled from other operations like blender configuration. There are two reasons: - DE33 will have separate driver for planes and thus it will be harder to manage different register spaces - Architecturaly it's better to split access by modules. Blender is now exclusively managed by mixer. Reviewed-by: Chen-Yu Tsai Tested-by: Ryan Walklin Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 17 ++++++++++++++--- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 22 +++------------------- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 22 +++------------------- 3 files changed, 20 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/su= n8i_mixer.c index f7f210a925f8..a3194b71dc6d 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c @@ -283,8 +283,8 @@ static void sun8i_mixer_commit(struct sunxi_engine *eng= ine, =20 drm_for_each_plane(plane, state->dev) { struct sun8i_layer *layer =3D plane_to_sun8i_layer(plane); + int w, h, x, y, zpos; bool enable; - int zpos; =20 if (!(plane->possible_crtcs & drm_crtc_mask(crtc)) || layer->mixer !=3D = mixer) continue; @@ -295,10 +295,14 @@ static void sun8i_mixer_commit(struct sunxi_engine *e= ngine, =20 enable =3D plane_state->crtc && plane_state->visible; zpos =3D plane_state->normalized_zpos; + x =3D plane_state->dst.x1; + y =3D plane_state->dst.y1; + w =3D drm_rect_width(&plane_state->dst); + h =3D drm_rect_height(&plane_state->dst); =20 - DRM_DEBUG_DRIVER(" plane %d: chan=3D%d ovl=3D%d en=3D%d zpos=3D%d\n", + DRM_DEBUG_DRIVER(" plane %d: chan=3D%d ovl=3D%d en=3D%d zpos=3D%d x=3D%= d y=3D%d w=3D%d h=3D%d\n", plane->base.id, layer->channel, layer->overlay, - enable, zpos); + enable, zpos, x, y, w, h); =20 /* * We always update the layer enable bit, because it can clear @@ -312,6 +316,13 @@ static void sun8i_mixer_commit(struct sunxi_engine *en= gine, /* Route layer to pipe based on zpos */ route |=3D layer->channel << SUN8I_MIXER_BLEND_ROUTE_PIPE_SHIFT(zpos); pipe_en |=3D SUN8I_MIXER_BLEND_PIPE_CTL_EN(zpos); + + regmap_write(bld_regs, + SUN8I_MIXER_BLEND_ATTR_COORD(bld_base, zpos), + SUN8I_MIXER_COORD(x, y)); + regmap_write(bld_regs, + SUN8I_MIXER_BLEND_ATTR_INSIZE(bld_base, zpos), + SUN8I_MIXER_SIZE(w, h)); } =20 regmap_write(bld_regs, SUN8I_MIXER_BLEND_ROUTE(bld_base), route); diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c b/drivers/gpu/drm/sun4i= /sun8i_ui_layer.c index 8baa1d0b53bd..12c83c54f9bc 100644 --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c @@ -47,21 +47,17 @@ static void sun8i_ui_layer_update_alpha(struct sun8i_mi= xer *mixer, int channel, } =20 static void sun8i_ui_layer_update_coord(struct sun8i_mixer *mixer, int cha= nnel, - int overlay, struct drm_plane *plane, - unsigned int zpos) + int overlay, struct drm_plane *plane) { struct drm_plane_state *state =3D plane->state; u32 src_w, src_h, dst_w, dst_h; - struct regmap *bld_regs; - u32 bld_base, ch_base; u32 outsize, insize; u32 hphase, vphase; + u32 ch_base; =20 DRM_DEBUG_DRIVER("Updating UI channel %d overlay %d\n", channel, overlay); =20 - bld_base =3D sun8i_blender_base(mixer); - bld_regs =3D sun8i_blender_regmap(mixer); ch_base =3D sun8i_channel_base(mixer, channel); =20 src_w =3D drm_rect_width(&state->src) >> 16; @@ -113,17 +109,6 @@ static void sun8i_ui_layer_update_coord(struct sun8i_m= ixer *mixer, int channel, else sun8i_ui_scaler_enable(mixer, channel, false); } - - /* Set base coordinates */ - DRM_DEBUG_DRIVER("Layer destination coordinates X: %d Y: %d\n", - state->dst.x1, state->dst.y1); - DRM_DEBUG_DRIVER("Layer destination size W: %d H: %d\n", dst_w, dst_h); - regmap_write(bld_regs, - SUN8I_MIXER_BLEND_ATTR_COORD(bld_base, zpos), - SUN8I_MIXER_COORD(state->dst.x1, state->dst.y1)); - regmap_write(bld_regs, - SUN8I_MIXER_BLEND_ATTR_INSIZE(bld_base, zpos), - outsize); } =20 static void sun8i_ui_layer_update_formats(struct sun8i_mixer *mixer, int c= hannel, @@ -230,14 +215,13 @@ static void sun8i_ui_layer_atomic_update(struct drm_p= lane *plane, struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(stat= e, plane); struct sun8i_layer *layer =3D plane_to_sun8i_layer(plane); - unsigned int zpos =3D new_state->normalized_zpos; struct sun8i_mixer *mixer =3D layer->mixer; =20 if (!new_state->crtc || !new_state->visible) return; =20 sun8i_ui_layer_update_coord(mixer, layer->channel, - layer->overlay, plane, zpos); + layer->overlay, plane); sun8i_ui_layer_update_alpha(mixer, layer->channel, layer->overlay, plane); sun8i_ui_layer_update_formats(mixer, layer->channel, diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i= /sun8i_vi_layer.c index dae6f83cea6e..1f4fa63ef153 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c @@ -49,25 +49,21 @@ static void sun8i_vi_layer_update_alpha(struct sun8i_mi= xer *mixer, int channel, } =20 static void sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int cha= nnel, - int overlay, struct drm_plane *plane, - unsigned int zpos) + int overlay, struct drm_plane *plane) { struct drm_plane_state *state =3D plane->state; const struct drm_format_info *format =3D state->fb->format; u32 src_w, src_h, dst_w, dst_h; - struct regmap *bld_regs; - u32 bld_base, ch_base; u32 outsize, insize; u32 hphase, vphase; u32 hn =3D 0, hm =3D 0; u32 vn =3D 0, vm =3D 0; bool subsampled; + u32 ch_base; =20 DRM_DEBUG_DRIVER("Updating VI channel %d overlay %d\n", channel, overlay); =20 - bld_base =3D sun8i_blender_base(mixer); - bld_regs =3D sun8i_blender_regmap(mixer); ch_base =3D sun8i_channel_base(mixer, channel); =20 src_w =3D drm_rect_width(&state->src) >> 16; @@ -180,17 +176,6 @@ static void sun8i_vi_layer_update_coord(struct sun8i_m= ixer *mixer, int channel, SUN8I_MIXER_CHAN_VI_VDS_UV(ch_base), SUN8I_MIXER_CHAN_VI_DS_N(vn) | SUN8I_MIXER_CHAN_VI_DS_M(vm)); - - /* Set base coordinates */ - DRM_DEBUG_DRIVER("Layer destination coordinates X: %d Y: %d\n", - state->dst.x1, state->dst.y1); - DRM_DEBUG_DRIVER("Layer destination size W: %d H: %d\n", dst_w, dst_h); - regmap_write(bld_regs, - SUN8I_MIXER_BLEND_ATTR_COORD(bld_base, zpos), - SUN8I_MIXER_COORD(state->dst.x1, state->dst.y1)); - regmap_write(bld_regs, - SUN8I_MIXER_BLEND_ATTR_INSIZE(bld_base, zpos), - outsize); } =20 static u32 sun8i_vi_layer_get_csc_mode(const struct drm_format_info *forma= t) @@ -350,14 +335,13 @@ static void sun8i_vi_layer_atomic_update(struct drm_p= lane *plane, struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(stat= e, plane); struct sun8i_layer *layer =3D plane_to_sun8i_layer(plane); - unsigned int zpos =3D new_state->normalized_zpos; struct sun8i_mixer *mixer =3D layer->mixer; =20 if (!new_state->crtc || !new_state->visible) return; =20 sun8i_vi_layer_update_coord(mixer, layer->channel, - layer->overlay, plane, zpos); + layer->overlay, plane); sun8i_vi_layer_update_alpha(mixer, layer->channel, layer->overlay, plane); sun8i_vi_layer_update_formats(mixer, layer->channel, --=20 2.51.2