From nobody Fri Dec 19 11:04:10 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF6F0332EB5 for ; Tue, 4 Nov 2025 16:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762273355; cv=none; b=S1/7Y/ozUAWDtnHPsanDInzxKN8nmSQFs7qbDAhamTwehYb2I8TkYVotQUZyp9IoNAHAIBVTjzTjSuAb5O5GwXR6fp71rRkFhiKkSUnpT4RfBjYHsVz0XRpPKviE5T1CNCldDuGgNIxCJ1TDKVJK1bkwvC2e/OH3VDqaaKdLeRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762273355; c=relaxed/simple; bh=Mq3xJzSfLBZFPyX9cJud5+ybummzpUE/k+7djoa/QTg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TpFLHBMENR5LWF89TR1Tdnl571DDiiXGknNZhCiaSFaxEKgDsMJHo/JWfv65yBuXASKd3mlzjXYkCJ0PD42fUyaKCEr7eneurGEJ7t+1HaEwjokMOt1KfyA1CzgSUWd1ZzvGgZgnFz0ZGeG1iKrfayGO3FSC7huFy3ZGYMCwf7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=leTgjlBk; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="leTgjlBk" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29558061c68so35753175ad.0 for ; Tue, 04 Nov 2025 08:22:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762273353; x=1762878153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iWqXKoG+UvFX2nC9qUqgJpT0vqXKcTPswRe35RqOoSE=; b=leTgjlBk4zQx7HXmTIIyxkcmChtJf0sbWNX1jbz/+oysiCCdP/Ir82LcOyLnZ9GL/F clkOP1eIrOPkyn1w+BxROAx4B57vNo5ChFp5MURvafQJU/IABLe11XY0VkAxFdpJg4/r 8wHTdPGw9/H4FIDafgV5CcqHbA2yPQITJxu0y+439IXuAn28lcTgc7w2VTiKi66Iptow A/Ghg/20zxYVt4gy2+739HLQd1TPZI4zl0wFZRAJlmVl0yy/RHHH6KrTXhsjgAkKh/1S vzF8RT7rLT97UNA7csnIM1UWRzjnO9xUYcOOkqT0B7vYvdYMAxtRtOfKuncnG/VL5iRw /JyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762273353; x=1762878153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iWqXKoG+UvFX2nC9qUqgJpT0vqXKcTPswRe35RqOoSE=; b=fAbRJBhG9vmAtPkXMYvYUmPXd7ydkUc4VYGkdoCC53GLHVuBD1WL5JPFl/Exi/LBxL vUsqjdR2vrOh9gVLwhkDeLs0tryPEeRqWASrDJ1hSw8HF24xwxcAcfuxEZSrx3xTjm+U WSySce2Ey/ynSM6bizzucJML5hUr4vdqxYjEXUq1GUtJFpxNY33Y/TS8n1e62XNI2Dgy IxebQ6ThGF87HM2A0FLt/eVayCXYla3HD1K7Rkqvck84QqZmCwruKyspFcCZFRBmgFlI X4PfE4jOdFWxFAAvAlTrKyPxytUo85MunJSYjyd4d7ZvwBNrrx1tNrvrjHO19DddlkTO 9lyg== X-Gm-Message-State: AOJu0YxJ1sWR+0zNmxaMRX1jbpZaOY6dAJo1ds6TonjRu4wupCY/lGRr pJA33pAYljSR3rQFD5TUrlgqi/5udNtuT3g5ePVF5WshEH95GMSg1jGJt0bhMA== X-Gm-Gg: ASbGncsoKHxIzmquAUc6tWabR8F557iEnaeCyS35ucgY6yQAcwcchmWETBul2QWN8k6 aM2R4eCp/ezz4JxfgWX6tY0Xzw1lndPZEhjoZjAuvnK9Al+rPKeboYcgs8Jkf/0Vz7nke94lIke DA4sbN7BkJ++7v3v1fE1+Cep4hBTjC7NrkObZbJT9gQVAfSW3e1UceaXHAmuFSNGIZx96b4hQ7g GUl6Qka4F7xKKoVNoYt7Dv9lRMU8wRPKL5VJepr3hIOdZO3TB+Rr3rvq6HlE/cfGtPUfs61sH3i 3CQPoJ4tDYDCZFUZbqYadRiGLMVn9BRZ/W2dr2jrEbAVxyV4sUVLiSdp4eDNfmMpLCrUBIv60xw 8v2AJ2DDbVFeSTaMNlaiAqsUXQsnhsNkDrHAlKIb5ozsPgvfulwo02X4IMqn8ltytKqlxxiqG2L FwxxqgkxSCYpP+1BVKgr9fMpWnKPhniC0EQTChvC3GEKtvNkRAM2HmdMp/e2LS3uC+r+E= X-Google-Smtp-Source: AGHT+IH0dE/olgaflfMfuvQns7OzSxqDaeSitM5vcT88hQS8ejyyRcn3araS0xuUCd7z2J3y5I1mqQ== X-Received: by 2002:a17:902:f707:b0:262:d081:96c with SMTP id d9443c01a7336-2962ad1c9b8mr2371985ad.17.1762273352483; Tue, 04 Nov 2025 08:22:32 -0800 (PST) Received: from daehojeong-desktop.mtv.corp.google.com ([2a00:79e0:2e7c:8:7b63:d7ee:4b43:91a7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29601a381e2sm31475555ad.69.2025.11.04.08.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 08:22:32 -0800 (PST) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong Subject: [PATCH v4] f2fs-tools: revert summary entry count from 2048 to 512 in 16kb block support Date: Tue, 4 Nov 2025 08:22:26 -0800 Message-ID: <20251104162226.919906-1-daeho43@gmail.com> X-Mailer: git-send-email 2.51.2.1026.g39e6a42477-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Daeho Jeong The recent increase in the number of Segment Summary Area (SSA) entries from 512 to 2048 was an unintentional change in logic of 16kb block support. This commit corrects the issue. To better utilize the space available from the erroneous 2048-entry calculation, we are implementing a solution to share the currently unused SSA space with neighboring segments. This enhances overall SSA utilization without impacting the established 8MB segment size. Fixes: 50fd00b168d7 ("f2fs-tools: Support different block sizes") Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu --- v4: move enabling the feature position. v3: add a feature to prevent from mounting deprecated format v2: detect legacy layout and prevent mount. fix ssa block calculation bug in resize tool. --- fsck/f2fs.h | 18 +++++++++++- fsck/fsck.c | 16 ++++------- fsck/fsck.h | 5 ++++ fsck/inject.c | 4 +-- fsck/mount.c | 60 ++++++++++++++++++++++----------------- fsck/resize.c | 62 +++++++++++++++++++++++------------------ include/f2fs_fs.h | 17 +++++++---- lib/libf2fs_io.c | 12 ++++++++ mkfs/f2fs_format.c | 6 +++- mkfs/f2fs_format_main.c | 2 ++ 10 files changed, 127 insertions(+), 75 deletions(-) diff --git a/fsck/f2fs.h b/fsck/f2fs.h index 187e73c..538c99e 100644 --- a/fsck/f2fs.h +++ b/fsck/f2fs.h @@ -441,8 +441,10 @@ static inline block_t __end_block_addr(struct f2fs_sb_= info *sbi) (SM_I(sbi) ? SM_I(sbi)->seg0_blkaddr : \ le32_to_cpu(F2FS_RAW_SUPER(sbi)->segment0_blkaddr)) =20 +#define SUMS_PER_BLOCK (F2FS_BLKSIZE / F2FS_SUM_BLKSIZE) #define GET_SUM_BLKADDR(sbi, segno) \ - ((sbi->sm_info->ssa_blkaddr) + segno) + ((SM_I(sbi)->ssa_blkaddr) + segno / SUMS_PER_BLOCK) +#define GET_SUM_BLKOFF(segno) (segno % SUMS_PER_BLOCK) =20 #define GET_SEGOFF_FROM_SEG0(sbi, blk_addr) \ ((blk_addr) - SM_I(sbi)->seg0_blkaddr) @@ -492,6 +494,20 @@ static inline block_t sum_blk_addr(struct f2fs_sb_info= *sbi, int base, int type) - (base + 1) + type; } =20 +static inline int write_sum_block(struct f2fs_sb_info *sbi, + void *buf, unsigned int segno, enum rw_hint whint) +{ + return dev_write_4k_block(buf, GET_SUM_BLKADDR(sbi, segno), + GET_SUM_BLKOFF(segno), whint); +} + +static inline int read_sum_block(struct f2fs_sb_info *sbi, + void *buf, unsigned int segno) +{ + return dev_read_4k_block(buf, GET_SUM_BLKADDR(sbi, segno), + GET_SUM_BLKOFF(segno)); +} + /* for the list of fsync inodes, used only during recovery */ struct fsync_inode_entry { struct list_head list; /* list head */ diff --git a/fsck/fsck.c b/fsck/fsck.c index 4c36dc1..d0766a9 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -228,11 +228,9 @@ static int is_valid_ssa_node_blk(struct f2fs_sb_info *= sbi, u32 nid, } } if (need_fix && f2fs_dev_is_writable()) { - u64 ssa_blk; int ret2; =20 - ssa_blk =3D GET_SUM_BLKADDR(sbi, segno); - ret2 =3D dev_write_block(sum_blk, ssa_blk, WRITE_LIFE_NONE); + ret2 =3D write_sum_block(sbi, sum_blk, segno, WRITE_LIFE_NONE); ASSERT(ret2 >=3D 0); } out: @@ -367,11 +365,9 @@ static int is_valid_ssa_data_blk(struct f2fs_sb_info *= sbi, u32 blk_addr, } } if (need_fix && f2fs_dev_is_writable()) { - u64 ssa_blk; int ret2; =20 - ssa_blk =3D GET_SUM_BLKADDR(sbi, segno); - ret2 =3D dev_write_block(sum_blk, ssa_blk, WRITE_LIFE_NONE); + ret2 =3D write_sum_block(sbi, sum_blk, segno, WRITE_LIFE_NONE); ASSERT(ret2 >=3D 0); } out: @@ -3879,14 +3875,12 @@ int fsck_verify(struct f2fs_sb_info *sbi) rewrite_sit_area_bitmap(sbi); if (c.zoned_model =3D=3D F2FS_ZONED_HM) { struct curseg_info *curseg; - u64 ssa_blk; =20 for (i =3D 0; i < NO_CHECK_TYPE; i++) { curseg =3D CURSEG_I(sbi, i); - ssa_blk =3D GET_SUM_BLKADDR(sbi, - curseg->segno); - ret =3D dev_write_block(curseg->sum_blk, - ssa_blk, + ret =3D write_sum_block(sbi, + curseg->sum_blk, + curseg->segno, WRITE_LIFE_NONE); ASSERT(ret >=3D 0); } diff --git a/fsck/fsck.h b/fsck/fsck.h index 40cb6d9..7e96b39 100644 --- a/fsck/fsck.h +++ b/fsck/fsck.h @@ -292,6 +292,11 @@ extern bool is_sit_bitmap_set(struct f2fs_sb_info *sbi= , u32 blk_addr); int f2fs_defragment(struct f2fs_sb_info *, u64, u64, u64, int); =20 /* resize.c */ +#define GET_SUM_NEW_BLKADDR(new_sb, segno) \ + (get_newsb(ssa_blkaddr) + \ + (segno >> (get_newsb(log_blocksize) - DEFAULT_BLKSIZE_BITS))) +#define GET_SUM_NEW_BLKOFF(new_sb, segno) \ + (segno % (1 << (get_newsb(log_blocksize) - DEFAULT_BLKSIZE_BITS))) int f2fs_resize(struct f2fs_sb_info *); =20 /* sload.c */ diff --git a/fsck/inject.c b/fsck/inject.c index bd6ab84..fe5c293 100644 --- a/fsck/inject.c +++ b/fsck/inject.c @@ -689,7 +689,6 @@ static int inject_ssa(struct f2fs_sb_info *sbi, struct = inject_option *opt) struct summary_footer *footer; struct f2fs_summary *sum; u32 segno, offset; - block_t ssa_blkaddr; int type; int ret; =20 @@ -754,8 +753,7 @@ static int inject_ssa(struct f2fs_sb_info *sbi, struct = inject_option *opt) =20 print_sum_footer_info(footer); =20 - ssa_blkaddr =3D GET_SUM_BLKADDR(sbi, segno); - ret =3D dev_write_block(sum_blk, ssa_blkaddr, WRITE_LIFE_NONE); + ret =3D write_sum_block(sbi, sum_blk, segno, WRITE_LIFE_NONE); ASSERT(ret >=3D 0); =20 out: diff --git a/fsck/mount.c b/fsck/mount.c index a1c4cbb..40159ce 100644 --- a/fsck/mount.c +++ b/fsck/mount.c @@ -1170,6 +1170,20 @@ int sanity_check_raw_super(struct f2fs_super_block *= sb, enum SB_ADDR sb_addr) return -1; } =20 + /* + * Check for legacy summary layout on 16KB+ block devices. + * Modern f2fs-tools packs multiple 4KB summary areas into one block, + * whereas legacy versions used one block per summary, leading + * to a much larger SSA. + */ + if (blocksize !=3D F2FS_SUM_BLKSIZE && + !(get_sb(feature) & F2FS_FEATURE_PACKED_SSA)) { + MSG(0, "Error: Device formatted with a legacy version. " + "Please reformat with a tool supporting the packed ssa " + "feature for block sizes larger than 4kb.\n"); + return -1; + } + if (sanity_check_area_boundary(sb, sb_addr)) return -1; return 0; @@ -2144,6 +2158,7 @@ static void read_normal_summaries(struct f2fs_sb_info= *sbi, int type) struct curseg_info *curseg; unsigned int segno =3D 0; block_t blk_addr =3D 0; + __u32 blk_offset =3D 0; int ret; =20 if (IS_DATASEG(type)) { @@ -2154,24 +2169,26 @@ static void read_normal_summaries(struct f2fs_sb_in= fo *sbi, int type) blk_addr =3D sum_blk_addr(sbi, NR_CURSEG_DATA_TYPE, type); } else { segno =3D get_cp(cur_node_segno[type - CURSEG_HOT_NODE]); - if (is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) + if (is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) { blk_addr =3D sum_blk_addr(sbi, NR_CURSEG_NODE_TYPE, type - CURSEG_HOT_NODE); - else + } else { blk_addr =3D GET_SUM_BLKADDR(sbi, segno); + blk_offset =3D GET_SUM_BLKOFF(segno); + } } =20 - sum_blk =3D malloc(F2FS_BLKSIZE); + sum_blk =3D malloc(F2FS_SUM_BLKSIZE); ASSERT(sum_blk); =20 - ret =3D dev_read_block(sum_blk, blk_addr); + ret =3D dev_read_4k_block(sum_blk, blk_addr, blk_offset); ASSERT(ret >=3D 0); =20 if (IS_NODESEG(type) && !is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) restore_node_summary(sbi, segno, sum_blk); =20 curseg =3D CURSEG_I(sbi, type); - memcpy(curseg->sum_blk, sum_blk, F2FS_BLKSIZE); + memcpy(curseg->sum_blk, sum_blk, F2FS_SUM_BLKSIZE); reset_curseg(sbi, type); free(sum_blk); } @@ -2199,8 +2216,7 @@ void update_sum_entry(struct f2fs_sb_info *sbi, block= _t blk_addr, SUM_TYPE_DATA; =20 /* write SSA all the time */ - ret =3D dev_write_block(sum_blk, GET_SUM_BLKADDR(sbi, segno), - WRITE_LIFE_NONE); + ret =3D write_sum_block(sbi, sum_blk, segno, WRITE_LIFE_NONE); ASSERT(ret >=3D 0); =20 if (type =3D=3D SEG_TYPE_NODE || type =3D=3D SEG_TYPE_DATA || @@ -2399,11 +2415,9 @@ struct f2fs_summary_block *get_sum_block(struct f2fs= _sb_info *sbi, struct f2fs_summary_block *sum_blk; struct curseg_info *curseg; int type, ret; - u64 ssa_blk; =20 *ret_type=3D SEG_TYPE_MAX; =20 - ssa_blk =3D GET_SUM_BLKADDR(sbi, segno); for (type =3D 0; type < NR_CURSEG_NODE_TYPE; type++) { curseg =3D CURSEG_I(sbi, CURSEG_HOT_NODE + type); if (segno =3D=3D curseg->segno) { @@ -2434,10 +2448,10 @@ struct f2fs_summary_block *get_sum_block(struct f2f= s_sb_info *sbi, } } =20 - sum_blk =3D calloc(F2FS_BLKSIZE, 1); + sum_blk =3D calloc(F2FS_SUM_BLKSIZE, 1); ASSERT(sum_blk); =20 - ret =3D dev_read_block(sum_blk, ssa_blk); + ret =3D read_sum_block(sbi, sum_blk, segno); ASSERT(ret >=3D 0); =20 if (IS_SUM_NODE_SEG(sum_blk)) @@ -3054,7 +3068,6 @@ int find_next_free_block(struct f2fs_sb_info *sbi, u6= 4 *to, int left, struct curseg_info *curseg =3D CURSEG_I(sbi, want_type); unsigned int segs_per_zone =3D sbi->segs_per_sec * sbi->secs_per_zone; char buf[F2FS_BLKSIZE]; - u64 ssa_blk; int ret; =20 *to =3D NEXT_FREE_BLKADDR(sbi, curseg); @@ -3072,17 +3085,15 @@ int find_next_free_block(struct f2fs_sb_info *sbi, = u64 *to, int left, segno =3D GET_SEGNO(sbi, new_blkaddr); } =20 - ssa_blk =3D GET_SUM_BLKADDR(sbi, curseg->segno); - ret =3D dev_write_block(curseg->sum_blk, ssa_blk, - WRITE_LIFE_NONE); + ret =3D write_sum_block(sbi, curseg->sum_blk, + curseg->segno, WRITE_LIFE_NONE); ASSERT(ret >=3D 0); =20 curseg->segno =3D segno; curseg->next_blkoff =3D 0; curseg->alloc_type =3D LFS; =20 - ssa_blk =3D GET_SUM_BLKADDR(sbi, curseg->segno); - ret =3D dev_read_block(&buf, ssa_blk); + ret =3D read_sum_block(sbi, &buf, curseg->segno); ASSERT(ret >=3D 0); =20 memcpy(curseg->sum_blk, &buf, SUM_ENTRIES_SIZE); @@ -3160,7 +3171,7 @@ void move_one_curseg_info(struct f2fs_sb_info *sbi, u= 64 from, int left, struct curseg_info *curseg =3D CURSEG_I(sbi, i); char buf[F2FS_BLKSIZE]; u32 old_segno; - u64 ssa_blk, to; + u64 to; int ret; =20 if ((get_sb(feature) & F2FS_FEATURE_RO)) { @@ -3178,8 +3189,8 @@ void move_one_curseg_info(struct f2fs_sb_info *sbi, u= 64 from, int left, } =20 /* update original SSA too */ - ssa_blk =3D GET_SUM_BLKADDR(sbi, curseg->segno); - ret =3D dev_write_block(curseg->sum_blk, ssa_blk, WRITE_LIFE_NONE); + ret =3D write_sum_block(sbi, curseg->sum_blk, curseg->segno, + WRITE_LIFE_NONE); ASSERT(ret >=3D 0); bypass_ssa: to =3D from; @@ -3193,8 +3204,7 @@ bypass_ssa: curseg->alloc_type =3D c.zoned_model =3D=3D F2FS_ZONED_HM ? LFS : SSR; =20 /* update new segno */ - ssa_blk =3D GET_SUM_BLKADDR(sbi, curseg->segno); - ret =3D dev_read_block(buf, ssa_blk); + ret =3D read_sum_block(sbi, buf, curseg->segno); ASSERT(ret >=3D 0); =20 memcpy(curseg->sum_blk, buf, SUM_ENTRIES_SIZE); @@ -3440,7 +3450,6 @@ void write_checkpoint(struct f2fs_sb_info *sbi) /* update summary blocks having nullified journal entries */ for (i =3D 0; i < NO_CHECK_TYPE; i++) { struct curseg_info *curseg =3D CURSEG_I(sbi, i); - u64 ssa_blk; =20 if (!(flags & CP_UMOUNT_FLAG) && IS_NODESEG(i)) continue; @@ -3451,9 +3460,8 @@ void write_checkpoint(struct f2fs_sb_info *sbi) =20 if (!(get_sb(feature) & F2FS_FEATURE_RO)) { /* update original SSA too */ - ssa_blk =3D GET_SUM_BLKADDR(sbi, curseg->segno); - ret =3D dev_write_block(curseg->sum_blk, ssa_blk, - WRITE_LIFE_NONE); + ret =3D write_sum_block(sbi, curseg->sum_blk, + curseg->segno, WRITE_LIFE_NONE); ASSERT(ret >=3D 0); } } diff --git a/fsck/resize.c b/fsck/resize.c index 58914ec..f71290a 100644 --- a/fsck/resize.c +++ b/fsck/resize.c @@ -115,7 +115,8 @@ static int get_new_sb(struct f2fs_super_block *sb) get_sb(segment_count_sit) + get_sb(segment_count_nat))) * blks_per_seg; =20 - blocks_for_ssa =3D total_valid_blks_available / blks_per_seg + 1; + blocks_for_ssa =3D round_up(total_valid_blks_available / blks_per_seg, + SUMS_PER_BLOCK); =20 set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa)); =20 @@ -209,23 +210,24 @@ static void migrate_main(struct f2fs_sb_info *sbi, un= signed int offset) START_BLOCK(sbi, 0) + offset); } =20 -static void move_ssa(struct f2fs_sb_info *sbi, unsigned int segno, - block_t new_sum_blk_addr) +static void move_ssa(struct f2fs_sb_info *sbi, struct f2fs_super_block *ne= w_sb, + unsigned int old_segno, unsigned int new_segno) { struct f2fs_summary_block *sum_blk; int type; =20 - sum_blk =3D get_sum_block(sbi, segno, &type); + sum_blk =3D get_sum_block(sbi, old_segno, &type); if (type < SEG_TYPE_MAX) { int ret; + u64 new_blkaddr =3D GET_SUM_NEW_BLKADDR(new_sb, new_segno); + u32 new_blkoff =3D GET_SUM_NEW_BLKOFF(new_sb, new_segno); =20 - ret =3D dev_write_block(sum_blk, new_sum_blk_addr, - WRITE_LIFE_NONE); + ret =3D dev_write_4k_block(sum_blk, new_blkaddr, new_blkoff, + WRITE_LIFE_NONE); ASSERT(ret >=3D 0); DBG(1, "Write summary block: (%d) segno=3D%x/%x --> (%d) %x\n", - type, segno, GET_SUM_BLKADDR(sbi, segno), - IS_SUM_NODE_SEG(sum_blk), - new_sum_blk_addr); + type, old_segno, GET_SUM_BLKADDR(sbi, old_segno), + IS_SUM_NODE_SEG(sum_blk), (unsigned int)new_blkaddr); } if (type =3D=3D SEG_TYPE_NODE || type =3D=3D SEG_TYPE_DATA || type =3D=3D SEG_TYPE_MAX) { @@ -240,36 +242,42 @@ static void migrate_ssa(struct f2fs_sb_info *sbi, struct f2fs_super_block *sb =3D F2FS_RAW_SUPER(sbi); block_t old_sum_blkaddr =3D get_sb(ssa_blkaddr); block_t new_sum_blkaddr =3D get_newsb(ssa_blkaddr); - block_t end_sum_blkaddr =3D get_newsb(main_blkaddr); - block_t expand_sum_blkaddr =3D new_sum_blkaddr + - MAIN_SEGS(sbi) - offset; - block_t blkaddr; + unsigned int expand_segno =3D MAIN_SEGS(sbi) - offset; + unsigned int new_seg_total =3D get_newsb(segment_count); + int new_segno; int ret; - void *zero_block =3D calloc(F2FS_BLKSIZE, 1); + void *zero_block =3D calloc(F2FS_SUM_BLKSIZE, 1); ASSERT(zero_block); =20 - if (offset && new_sum_blkaddr < old_sum_blkaddr + offset) { - blkaddr =3D new_sum_blkaddr; - while (blkaddr < end_sum_blkaddr) { - if (blkaddr < expand_sum_blkaddr) { - move_ssa(sbi, offset++, blkaddr++); + if (offset && new_sum_blkaddr <=3D (old_sum_blkaddr + + offset / SUMS_PER_BLOCK)) { + new_segno =3D 0; + while (new_segno < new_seg_total) { + if (new_segno < expand_segno) { + move_ssa(sbi, new_sb, offset++, new_segno); } else { - ret =3D dev_write_block(zero_block, blkaddr++, - WRITE_LIFE_NONE); + ret =3D dev_write_4k_block(zero_block, + GET_SUM_NEW_BLKADDR(new_sb, new_segno), + GET_SUM_NEW_BLKOFF(new_sb, new_segno), + WRITE_LIFE_NONE); ASSERT(ret >=3D0); } + new_segno++; } } else { - blkaddr =3D end_sum_blkaddr - 1; + new_segno =3D new_seg_total - 1; offset =3D MAIN_SEGS(sbi) - 1; - while (blkaddr >=3D new_sum_blkaddr) { - if (blkaddr >=3D expand_sum_blkaddr) { - ret =3D dev_write_block(zero_block, blkaddr--, - WRITE_LIFE_NONE); + while (new_segno >=3D 0) { + if (new_segno >=3D expand_segno) { + ret =3D dev_write_4k_block(zero_block, + GET_SUM_NEW_BLKADDR(new_sb, new_segno), + GET_SUM_NEW_BLKOFF(new_sb, new_segno), + WRITE_LIFE_NONE); ASSERT(ret >=3D0); } else { - move_ssa(sbi, offset--, blkaddr--); + move_ssa(sbi, new_sb, offset--, new_segno); } + new_segno--; } } =20 diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index bd75dbb..e1427f7 100644 --- a/include/f2fs_fs.h +++ b/include/f2fs_fs.h @@ -655,6 +655,7 @@ enum { #define F2FS_MIN_BLKSIZE 4096 #define F2FS_MAX_BLKSIZE 16384 #define F2FS_BLKSIZE c.blksize /* support configurable block size */ +#define F2FS_SUM_BLKSIZE 4096 #define F2FS_MAX_EXTENSION 64 /* # of extension entries */ #define F2FS_EXTENSION_LEN 8 /* max size of extension */ #define F2FS_BLK_ALIGN(x) (((x) + F2FS_BLKSIZE - 1) / F2FS_BLKSIZE) @@ -715,6 +716,7 @@ enum { #define F2FS_FEATURE_COMPRESSION 0x2000 #define F2FS_FEATURE_RO 0x4000 #define F2FS_FEATURE_DEVICE_ALIAS 0x8000 +#define F2FS_FEATURE_PACKED_SSA 0x10000 =20 #define MAX_NR_FEATURE 32 =20 @@ -1218,7 +1220,7 @@ struct f2fs_sit_block { * from node's page's beginning to get a data block address. * ex) data_blkaddr =3D (block_t)(nodepage_start_address + ofs_in_node) */ -#define ENTRIES_IN_SUM (F2FS_BLKSIZE / 8) +#define ENTRIES_IN_SUM (F2FS_SUM_BLKSIZE / 8) #define SUMMARY_SIZE (7) /* sizeof(struct summary) */ #define SUM_FOOTER_SIZE (5) /* sizeof(struct summary_footer) */ #define SUM_ENTRIES_SIZE (SUMMARY_SIZE * ENTRIES_IN_SUM) @@ -1248,7 +1250,7 @@ struct summary_footer { =20 static_assert(sizeof(struct summary_footer) =3D=3D 5, ""); =20 -#define SUM_JOURNAL_SIZE (F2FS_BLKSIZE - SUM_FOOTER_SIZE -\ +#define SUM_JOURNAL_SIZE (F2FS_SUM_BLKSIZE - SUM_FOOTER_SIZE -\ SUM_ENTRIES_SIZE) #define NAT_JOURNAL_ENTRIES ((SUM_JOURNAL_SIZE - 2) /\ sizeof(struct nat_journal_entry)) @@ -1347,7 +1349,7 @@ struct f2fs_summary_block { }; #define F2FS_SUMMARY_BLOCK_JOURNAL(blk) ((struct f2fs_journal *)(&(blk)->e= ntries[ENTRIES_IN_SUM])) #define F2FS_SUMMARY_BLOCK_FOOTER(blk) ((struct summary_footer *)&((char *= )\ - (&(blk)->entries[0]))[F2FS_BLKSIZE - SUM_FOOTER_SIZE]) + (&(blk)->entries[0]))[F2FS_SUM_BLKSIZE - SUM_FOOTER_SIZE]) =20 /* * For directory operations @@ -1709,6 +1711,8 @@ extern int dev_fill_block(void *, __u64, enum rw_hint= ); =20 extern int dev_read_block(void *, __u64); extern int dev_reada_block(__u64); +extern int dev_write_4k_block(void *, __u64, __u32, enum rw_hint); +extern int dev_read_4k_block(void *, __u64, __u32); =20 extern int dev_read_version(void *, __u64, size_t); extern void get_kernel_version(__u8 *); @@ -2020,6 +2024,7 @@ struct feature feature_table[] =3D { \ { "compression", F2FS_FEATURE_COMPRESSION, 1}, \ { "ro", F2FS_FEATURE_RO, 1}, \ { "device_alias", F2FS_FEATURE_DEVICE_ALIAS, 0}, \ + { "packed_ssa", F2FS_FEATURE_PACKED_SSA, 0}, \ { NULL, 0x0, 0}, \ }; =20 @@ -2159,18 +2164,18 @@ static inline void check_block_struct_sizes(void) assert(sizeof(struct f2fs_summary) * ENTRIES_IN_SUM + offsetof(struct f2fs_journal, nat_j) + NAT_JOURNAL_ENTRIES * sizeof(struct nat_journal_entry) - + NAT_JOURNAL_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_BLKS= IZE); + + NAT_JOURNAL_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_SUM_= BLKSIZE); =20 /* Check SIT Journal Block Size */ assert(sizeof(struct f2fs_summary) * ENTRIES_IN_SUM + offsetof(struct f2fs_journal, sit_j) + SIT_JOURNAL_ENTRIES * sizeof(struct sit_journal_entry) - + SIT_JOURNAL_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_BLKS= IZE); + + SIT_JOURNAL_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_SUM_= BLKSIZE); =20 /* Check Info Journal Block Size */ assert(sizeof(struct f2fs_summary) * ENTRIES_IN_SUM + sizeof(__le64) + offsetof(struct f2fs_journal, info) - + EXTRA_INFO_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_BLKSI= ZE); + + EXTRA_INFO_RESERVED + sizeof(struct summary_footer) =3D=3D F2FS_SUM_B= LKSIZE); =20 /* Check Dentry Block Size */ assert(sizeof(__u8) * (SIZE_OF_DENTRY_BITMAP + SIZE_OF_RESERVED) diff --git a/lib/libf2fs_io.c b/lib/libf2fs_io.c index 2030440..919318e 100644 --- a/lib/libf2fs_io.c +++ b/lib/libf2fs_io.c @@ -734,6 +734,18 @@ int dev_reada_block(__u64 blk_addr) return dev_readahead(blk_addr << F2FS_BLKSIZE_BITS, F2FS_BLKSIZE); } =20 +int dev_write_4k_block(void *buf, __u64 blk_addr, __u32 offset, enum rw_hi= nt whint) +{ + return dev_write(buf, (blk_addr << F2FS_BLKSIZE_BITS) + offset * 4096, + 4096, whint); +} + +int dev_read_4k_block(void *buf, __u64 blk_addr, __u32 offset) +{ + return dev_read(buf, (blk_addr << F2FS_BLKSIZE_BITS) + offset * 4096, + 4096); +} + int f2fs_fsync_device(void) { #ifdef HAVE_FSYNC diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index 6deb671..6efad45 100644 --- a/mkfs/f2fs_format.c +++ b/mkfs/f2fs_format.c @@ -500,8 +500,12 @@ static int f2fs_prepare_super_block(void) if (c.feature & F2FS_FEATURE_RO) { blocks_for_ssa =3D 0; } else { + unsigned int ssa_per_block; + ASSERT((total_valid_blks_available % c.blks_per_seg) =3D=3D 0); - blocks_for_ssa =3D total_valid_blks_available / c.blks_per_seg; + ssa_per_block =3D c.blksize / F2FS_SUM_BLKSIZE; + blocks_for_ssa =3D round_up(total_valid_blks_available / + c.blks_per_seg, ssa_per_block); } =20 set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa)); diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c index 8f8e975..49e203c 100644 --- a/mkfs/f2fs_format_main.c +++ b/mkfs/f2fs_format_main.c @@ -179,6 +179,8 @@ static void add_default_options(void) c.feature |=3D F2FS_FEATURE_QUOTA_INO; c.quota_bits |=3D QUOTA_PRJ_BIT; } + if (c.blksize !=3D F2FS_SUM_BLKSIZE) + c.feature |=3D F2FS_FEATURE_PACKED_SSA; } =20 static void f2fs_parse_options(int argc, char *argv[]) --=20 2.51.2.1026.g39e6a42477-goog