From nobody Sun Feb 8 04:43:38 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 411C32E8B8B for ; Tue, 4 Nov 2025 11:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255550; cv=none; b=GzPn8rfZn60GkW6U7WEnCQGKOifHsMHZl61KHR+Z5tRmhin7aag/gLo24P/OE37FKJQsBJ3GF3+PKXDW2hTIKjgaiF1UKYgVyQs6+QfNzMpzunLiomUzGalPVqn8pcfLN+6wQ2VBeFH4B1CdUrwdiF0dJunXlyrZAG91id5BFFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255550; c=relaxed/simple; bh=zWKlwVNm+/sMxBT6oj3FeSVj5qHQhcaixESKOMLw3Lc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X+/bHnD+hLM6/5e7dGKp3OSTRXq6PrnsimMdjah2qDZ4lyoEKvKfFuvZ6m1FTIOBwb/2gb50II7NWN/MPzWpgrN43+SFUFBaaSwLV/ipgzRg/zFz+Ry0vt9ocTNNVtyEeGMBoiJNbRxZ3gneWPUT5Oeo531GfmH3z9THqyBbRw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Ethg0iR2; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Ethg0iR2" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-640c3940649so3127540a12.1 for ; Tue, 04 Nov 2025 03:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1762255545; x=1762860345; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=stYzH45VwWUKNAgerNUBsncouNNyJb4yUgnMDG8eTks=; b=Ethg0iR2k37uygb5OtTKzMWIc0LJqVsr0tqz/GsP702sAnD3jqWaeBG2C/8B5mvJ3z FRbYvwnUmXtR2H83ys6DRA3OtFqMgmyltWxd9sMqCFIH4vLiAprPkC2sdSiLhKPfkLaV +rmrH4qV5jFlKMCRDPe600i+CFT5Cus3bwMUdPLCQUsbC62+QBpnl5ygvInz0CI+106u 7mAu5woUpYb0JVGk/neDSh11vWH/jkFPtk41oXXpRNsFVABeDLGpUIcFWMTrfPVU2scL oChj/LHZX/dTVPhhYtDwPsyeWuSVJe2AdRK4L/W+cVrlLB/hnifrVWljdpmuebU0SzZj SuUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762255545; x=1762860345; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=stYzH45VwWUKNAgerNUBsncouNNyJb4yUgnMDG8eTks=; b=frfaqhXBdvt8hzoC0WzRDhgx6fsC9xiiuE6aMhckq+3u+UBA7y2gQ2XkkFNL+O0s1d xnasHYcc5tamZBwjB1uuKDZKrJAUym9Of2LiDKk1LqqHkWwfaRXsxBRWQXWN6FbsPJzP el6Hh5ejki51gy0ZueLle9W/osOiafVnqVhkfahMOwosY4iZt01lpJsrLSTLss+oOrYA NFdS860Q7aSUREptejculilx+05Ix9HhhQYO2N9i9FS0V7q5gCUbMRUU6E8tes6ReNdQ 6r+DMbcXbgx9izaq3zXTdddDllbEzGK3TopLB5yFiMAYPU7JrMI2xg2GdDP1yPZrSAH0 lzlA== X-Gm-Message-State: AOJu0YxVRfvx15WQdQfRyA39eogGYQiRtxG4Q7sdXOguUKqB89PR+HlK 45pIs57YcsYa+2eVgM2tsAoqSe9TO7IlSTIl3HuCtEewTCdLGbijQDPpK07mEcAacTPbAxscyC+ W/lHf X-Gm-Gg: ASbGncvCF7FuqA5N1uguzDK1aZj46koQDbAZF6fbyQ70pngtFHhclUc3dswDLZSIhcm CA001eFFY8d1FfDpblmVteSseb+CUdrjPr7oxbC9WCjbxpbWAQ3+ZF8rPjBBkKo9ntv7mGQ3hpJ O9/xzEjefOZPCno+b6Fouzg+V9dGWlJk8azd9IpczDr29kIp5/bwC9bGz14ULs8Gx7FyTIY+zO1 6UDyIfQ2N+BZSv8Rzahg+JTztJJh0MVT7Y9jNxT8ASYy8pXltjv8Iew9wvpxy0HvMekraMK643K K7eE5gnARM93m4i826VGpvNSA93FvxljxgtOSVnhw39yRGjSblQuI2SEZxv/YdAPSBO9syhG4od GjeVj7IMVDqeqfjsV784le4gwByoPYWXFOKmS5UQsn6kXzU1UCgIZOIUogYXVkFIy5llQ7HJn0H 7tFXs= X-Google-Smtp-Source: AGHT+IE6JQ2SIkOePpolRdtpQwBCWa1MbJb7n/XyJv+jCBR3fHY/bgWDSuf1lU4NTorSPgPC4CHpEw== X-Received: by 2002:a17:907:1c17:b0:b50:a067:2d85 with SMTP id a640c23a62f3a-b7070137f35mr1576695566b.15.1762255545149; Tue, 04 Nov 2025 03:25:45 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b723d6f33aesm184101266b.19.2025.11.04.03.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 03:25:44 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Subject: [PATCH 1/3] nvmet: replace use of system_wq with system_percpu_wq Date: Tue, 4 Nov 2025 12:25:26 +0100 Message-ID: <20251104112535.139450-2-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251104112535.139450-1-marco.crivellari@suse.com> References: <20251104112535.139450-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") system_wq should be the per-cpu workqueue, yet in this name nothing makes that clear, so replace system_wq with system_percpu_wq. The old wq (system_wq) will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/fabrics-cmd-auth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index 3e378153a781..29281f410cc6 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -1604,7 +1604,7 @@ void nvmet_execute_keep_alive(struct nvmet_req *req) =20 pr_debug("ctrl %d update keep-alive timer for %d secs\n", ctrl->cntlid, ctrl->kato); - mod_delayed_work(system_wq, &ctrl->ka_work, ctrl->kato * HZ); + mod_delayed_work(system_percpu_wq, &ctrl->ka_work, ctrl->kato * HZ); out: nvmet_req_complete(req, status); } diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/f= abrics-cmd-auth.c index bf01ec414c55..8f504bf891de 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -390,7 +390,7 @@ void nvmet_execute_auth_send(struct nvmet_req *req) req->sq->dhchap_step !=3D NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) { unsigned long auth_expire_secs =3D ctrl->kato ? ctrl->kato : 120; =20 - mod_delayed_work(system_wq, &req->sq->auth_expired_work, + mod_delayed_work(system_percpu_wq, &req->sq->auth_expired_work, auth_expire_secs * HZ); goto complete; } --=20 2.51.1 From nobody Sun Feb 8 04:43:38 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866182EAB8E for ; Tue, 4 Nov 2025 11:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255551; cv=none; b=J0twr14BFOTrkJqhH4H87XOQgog/YIigreg/GBFYENwfOvNUa882CgbfTwxV/6rn1QBx72O3zTACJGKtGwRqu6HZBJ7FZ3Plfi0r8tmC3SSCEVZaUWlhzO0yfCbyFSXPhhMgnGiPvABLXB3YfP8hDWdajvrZzvX2pySQGKVkPI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255551; c=relaxed/simple; bh=nz0CMheUSMhg+Cur994tubijSX1h+9AiSkyrByGrlDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y3u/i6upKoPOwAxUFXrGvjjsUkK/QNGu2npoKACqG2XVLJM442jVve9pJo4vwNHj99MeniYnk6rpo2iWX8goFy+wyT1dU4KynjYcZQisPUL6HXOWOJ3PbZmCd/yA5PlPPFRTh4WqYdedELg3mChJ5Q0RkuUoS/jRAR1A6RSNV2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=U/jY9TvH; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="U/jY9TvH" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b70bee93dc4so287667766b.3 for ; Tue, 04 Nov 2025 03:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1762255546; x=1762860346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Hz/eXxLAJrsYCSjgGA9t2bRyGKcFTsC49+GNbs5K18=; b=U/jY9TvHEXbxLuy+9fh+QGpBEIaWpu2Gldrf+gyWOLMMXLjooW7Frd9x/xYHKCIV4T Ke2mdGPd1l0djnLH6Q7htXgZDpMysrbb2oOTRGULEP3VdPlxHJUp3nQrTc55/89w/OPz EWNoIp+MljkPYfgcFSjpe+w1Sxnvlqy9ExklBcDerlLK4KyOIq3X2rghsCJ2L33TmU+h YB0mkrdcmm6pkY7k9r6Zbfev+CQ8oSwG/7HWN98LPOHCabWl5DEF2/+Scz2A74s2NIKQ 0DbRo+6HcfBkUb8qHac4Lvr1RGOHw5+HKC+F5TtOqknCQgNu7uNKZMX9NmQ5Tpaw8Edx zxVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762255546; x=1762860346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Hz/eXxLAJrsYCSjgGA9t2bRyGKcFTsC49+GNbs5K18=; b=p5IWe0G/SDfSd5G8VAM2WH6jXCHjT7hQC2oif1+It6MGGe0Q1XCJPs2/+y32N9yOzD woAzSUk8spXbI2dxqIuo4YlcUqSVd0SFLmlit9W1+zb6mcTlMvUpIzLQCOnUxNKXTili WT9CM3TZEPejTPSF23XjvIc2GR7atxH+ABfFmRs7lLkklT5BfeTXwECVnNetHEWBiZhC 3eUXggxeRqx0SNHZIXofK8g4+9pksywc3CKRdiEAVG0ISP/039bCGEBPG5g29Dsf4qmR QO8hk04ABKdZHFJYQ4twvue0zIj9xgakemFkemSlcN87MNW86SrrjB6vtJLnokLjdQHC RhAg== X-Gm-Message-State: AOJu0Yw0x9ZNRGkN1MCLc3lD5x91dDs2tPh+aSizny9YM8PHsdEMnT/2 u3PNjzz5DipTvbqBpHYODDKfmodcY/NIvxqbri0KV2+MmDnBeRyW8r+g3fQvrthKTIWZvMRU5aA r4/NY X-Gm-Gg: ASbGncu1urwwjuThgrXviPV4K0eJq/LRGdxGtwIvzdiCxhznYVJZRQwBHKozr132c0i gA2LTMjStNkfmV6GrwtaWin47xAIoy+fIxJj3FcfN+ILIKZbzU8L3RP0NyCbASZmiKHK/1FI3y1 ClYLyiBq7zNoPr5vY32XvF3Dq7zIxCzEPiiWFolTBpyw1/4EhYUDA8x6Nokx2zZG/ZiEgZdz6Rn cq6Oodtj1KNXENx8E5jAobOtcClgiC0+kfDgu1vZRfg4C6TsFCNkXjWiHbKlyVPGtdSqfFiVRfd dv6JZzxHufp9B1rGWKs4etkUW4BkZ0XisG26aOarH+9YiI5z9OqD6dWUd0GGqqfgDQzEASOVMcq EHEOXwOM8SSITVPCt2riCrRnkUaLU9nm1ctxDByUtJkn4w7X5m7M3DBpO7GAf5olSM76if7Lt3d HUbLU= X-Google-Smtp-Source: AGHT+IF1k470AEqd/HXmgoSWzg+3W3h3tiSB1rbfKQH9JA4864/MW5uhBMF5xc1yU7RXjnqRtZC1Dg== X-Received: by 2002:a17:906:bcd5:b0:b72:52c2:b8e2 with SMTP id a640c23a62f3a-b7252c2baa2mr127511866b.26.1762255546396; Tue, 04 Nov 2025 03:25:46 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b723d6f33aesm184101266b.19.2025.11.04.03.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 03:25:45 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Subject: [PATCH 2/3] nvme: add WQ_PERCPU to alloc_workqueue users Date: Tue, 4 Nov 2025 12:25:27 +0100 Message-ID: <20251104112535.139450-3-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251104112535.139450-1-marco.crivellari@suse.com> References: <20251104112535.139450-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue= () to be per-cpu when WQ_UNBOUND has not been specified. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/nvme/target/core.c | 5 +++-- drivers/nvme/target/tcp.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 5d7d483bfbe3..ae8e903b55ad 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -1943,12 +1943,13 @@ static int __init nvmet_init(void) if (!nvmet_bvec_cache) return -ENOMEM; =20 - zbd_wq =3D alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM, 0); + zbd_wq =3D alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM | WQ_PERCPU, + 0); if (!zbd_wq) goto out_destroy_bvec_cache; =20 buffered_io_wq =3D alloc_workqueue("nvmet-buffered-io-wq", - WQ_MEM_RECLAIM, 0); + WQ_MEM_RECLAIM | WQ_PERCPU, 0); if (!buffered_io_wq) goto out_free_zbd_work_queue; =20 diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 470bf37e5a63..fa7a56626bcc 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -2198,7 +2198,7 @@ static int __init nvmet_tcp_init(void) int ret; =20 nvmet_tcp_wq =3D alloc_workqueue("nvmet_tcp_wq", - WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); + WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_PERCPU, 0); if (!nvmet_tcp_wq) return -ENOMEM; =20 --=20 2.51.1 From nobody Sun Feb 8 04:43:38 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFF612EACF8 for ; Tue, 4 Nov 2025 11:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255552; cv=none; b=SK4GT/KR9e0fnqWu+mJ/5n2wF7zJcGX6qCHwGgC0qUXoFZdw2smwKkK1nLuayzP8RXUV9BhpXu4QXM8XdDiDDKHqE+SdZnN1dgxGxBhzuOB8uhwEy6+XE+UQCIq8b3xtlPfca1dlBezIYg6qZXPPzP/QELCoh/Ub0D32S8ixd2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762255552; c=relaxed/simple; bh=EfEGmqKgQNrkpGkIrhSxjTAfQflH2CxOaVMCDrdEOQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jGeP28c+T7SwNg+ju13ttqUYVPptVhyIH2RspQ113/NnurOzcQY1K7p5DAkjF5EMPKyX6vwbwfBV/VunUhsQpuEVZXbsj/WMPUks9FN8alHOWOHhCQdD7oVP+Z9yrrMA2McS/xjbhKKpJ0GfT4UNeNZ1LWSThEDaqZnmhEKDh9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=I+gzfpBk; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="I+gzfpBk" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b719ca8cb8dso164774066b.0 for ; Tue, 04 Nov 2025 03:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1762255548; x=1762860348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=36j1MV0BBUKjnBRL8wiWamNCoEnZNdmYYjMeE2B5BRo=; b=I+gzfpBkjg8fI7eGEzNg//Wxeh8gQ9TZ64WI2GSIJCZm0iAn0Vu5g8H5kOPsAtt8y4 7P6moZNa+z3m/7rLXRAmCwa8kBcc+ADyVauRJ1zaGDwQ/iCK9mFJV81gECbh8uAciqmU J3GmQrqMM4DhkgrIcYnFmrSyirRrt9Nej7DBY4/KjU2kuMW+SDIyCtssu5IdbiYG1o4h IWH9JYha+p5iFxQ6DRlkTgZy3d/oocx1CVakgYYqfVazJSTjhkloymXgB3wdrW6Zd+uH uojrHWGhCIKaa4YKOpTOu4a+zO3ENrb9GI2vfaAoeBRTaMTBLrWDmOUZ7TiuhieVfLWX eemQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762255548; x=1762860348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=36j1MV0BBUKjnBRL8wiWamNCoEnZNdmYYjMeE2B5BRo=; b=mJjKLv3iTwLQU44Fcfz8tDYG6oYyiuMUXGOeQC7H9aaKYo5BmQvXzKPJbV4Rvp36fz HV5igjU8GGclI4mWBiEIDB54HIpYvN1lsF7dcXpRMXQEesvu1g0DSDI8lbqfElYtRQrC 1rL9tay8fNnw5BvZqUe23AbeZ9gpLXbOeqGNmGoXS7u8B8y0u6kApmFuPEAtsfbCZ0hx NzSC6BAnx4HIwTQ72ib4PBqqlw017iVw4qHbbCcfMUBWK4iiV5pF7RwxmjvOMs/c5hKa 8okanaEW1aUQDiSObD5/xBdvg+CJvVEK1wTLWlymBTvRU1gTgSEZ7miqD5cLi2tZa+nD jxPw== X-Gm-Message-State: AOJu0Yy6bAS5WtM6AIAFdHeX7taY+1oIat/b26mtLW/qqwFe5EK+mTP/ vbkB3YK4QiTrbOjAibZXlBMWwc2TwScZAfu1he9AnLMqG3y/WHfokmQqtcEl6NWjaEP9j+sPRxL BmxII X-Gm-Gg: ASbGncv/eeB7+rG/eAM/gEJPJnqShs++JSu34LPkRzc5NNA65rfNLuCFyhiLENgHBEt HRCUvkEAS6CWiJQ8v/C78Q5yCDb71xRvzzgENq2a3qosRU/SEr2YHkxVoOy3S5FvrfVyg3MGcDV WtASvTmjWJNS8NnQ8P5KMCyZPgX0jb2CRKu1oskoLPyRlzpTsLR3G4Kgha0XEceDwmvyalnWv86 sL04E9DROFSD66mDnICxC3a6tFUsjCHD6zhg8zm51hI8ESdRjDCb+yIADXdZD7tC0dt2nvuKVDD PK/YmwuKUpuaotfE0nE5dx3aqMlQL8IO2HsW7GmBHnFfmT3igqSmqe2nxHL+mEvd/UGpyMVAXvf TGueNAXgxPjpTjpxYIJcUBKZfEPJNBRD8+E/5lypcMZsOgBzOM4fLFaRwpzU4taTK3j6/8w7s4p nArXQ= X-Google-Smtp-Source: AGHT+IGIauAMQQkqNOIjJqL/lfAch5QIY2pQHmm2/rqf5NN0Qlk/r1xJiw1HdsIBefQeKTnDF/XtWg== X-Received: by 2002:a17:907:97cd:b0:b70:b7f8:868f with SMTP id a640c23a62f3a-b70b7f88d2bmr789376866b.27.1762255547591; Tue, 04 Nov 2025 03:25:47 -0800 (PST) Received: from linux ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b723d6f33aesm184101266b.19.2025.11.04.03.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 03:25:47 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Justin Tee , Naresh Gottumukkala , Paul Ely Subject: [PATCH 3/3] nvmet-fc: add WQ_PERCPU to alloc_workqueue users Date: Tue, 4 Nov 2025 12:25:28 +0100 Message-ID: <20251104112535.139450-4-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251104112535.139450-1-marco.crivellari@suse.com> References: <20251104112535.139450-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they=E2=80=99re needed= and reducing noise when CPUs are isolated. This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue= () to be per-cpu when WQ_UNBOUND has not been specified. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn=E2=80=99t explicitly specify WQ_UNB= OUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Cc: Justin Tee Cc: Naresh Gottumukkala CC: Paul Ely Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari Reviewed-by: Justin Tee --- drivers/nvme/target/fc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index 7d84527d5a43..ac730f2e6ea1 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -795,9 +795,9 @@ nvmet_fc_alloc_target_queue(struct nvmet_fc_tgt_assoc *= assoc, if (!queue) return NULL; =20 - queue->work_q =3D alloc_workqueue("ntfc%d.%d.%d", 0, 0, - assoc->tgtport->fc_target_port.port_num, - assoc->a_id, qid); + queue->work_q =3D alloc_workqueue("ntfc%d.%d.%d", WQ_PERCPU, 0, + assoc->tgtport->fc_target_port.port_num, + assoc->a_id, qid); if (!queue->work_q) goto out_free_queue; =20 --=20 2.51.1