From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB7A228488D; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=ImNmnJXgHHdAFIiiVLKuz7vpfHYEUMk1d5bloan6phXKdBWYAPTr0gGmy2i7OAiste0MWlpJ0teAPiAjw2AAANO+Mh9+w0efvCqevaMu5J082egnElDROuXjZolxPBIOZsyGyo8Ehs0Jge1ET+FTi2+j6hOR8wAu8YTaXmZEG3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=Rtx91GxuKaex+BdsMgDIfUh/ugamROd6AIG7Rf3SlNk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CSj1AqYDWPKxjCOLcng/vXGm3Pjm18B/Kpy1ZfMNEd6ctM+2y+BhjvltK0sxAcwTeKYW33sjmcuCH8LsvgvMxULNL0KIFjbKk+c651zSp8Kn6OeJ1I57um+U62k3S1Y6iiaqvH8amN9oHp/U8LdjbG5phHQFn3G/0D1Beh516Xo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EMSvnWnb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EMSvnWnb" Received: by smtp.kernel.org (Postfix) with ESMTPS id 87037C4CEF7; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=Rtx91GxuKaex+BdsMgDIfUh/ugamROd6AIG7Rf3SlNk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=EMSvnWnb+Z24IlIy01JpOG3Ay7SepVAPiDoEwLP4k0i7v5lAzpYLU9nrCk855JPri VqkF9nDTJnQ7J5y/CnVpgOhR1ji7qY1AM0Hi5GZ/oRxpwScpW/jbDa6UyqcZtS5cB/ 5OA/ePRUcAtDyGQuq4+ysH9Y4ryWRQ7MAgUpzWR/0VY4lzIAnQJqFm7BjIlyuUSmy4 5TGWAZ9Qc3LaLhIHOFh+AlSnudSmgehPo0zTCjZswQ1cxyYirg8pV3+UkmiRMHO+Kv MXXS49GQd3b93kbO+20O8etVpQBn5+PxWGll6GEqcO17+An2xefVwER4AtXSWCc4ze tmEVqh6XwpVzg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732DECCF9E3; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:09 +0100 Subject: [PATCH 01/12] dt-bindings: panel: Add Samsung SOFEF00 DDIC with panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-1-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4392; i=david@ixit.cz; h=from:subject:message-id; bh=PkSSGm3j9T2gwK/ORpLvNpYx1PQpZQW7tYqo+X+7emI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnsrpk1sBezguEBNXI5RcmUmxcf9kW4kVGM80 GeTQns4NgmJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7KwAKCRBgAj/E00kg cgsBD/4olfy+nJCIugvB9e4JIW/M/22idrW086QUJeCN/wHktveiLpk6DzBsCIEpFy3ebIgs0Cr jluDoX/7ImNMF8szroWlFfOkpQkVw7cJWxS/VfEpiHPsDUkHAnmQDQmWRxqjSCat8h9giYGACOg TMi1W+eHOKjN1hJKobR/KbUwBsS9vpRQ1gEyS3K11W1r03O7tvE223hoML/rfc3izQgD52HK0WG /24BSUEMeDxqV0sukGBId+1QfHZkuPLuSsyY4zhfU776H7csY76lbuYBS1iamcT59c9Ofb7bat2 Qs26MRZ0TCacV2MW37DcL5iBdFRqN0aLclEXMtSocrpfjRk6Frr0jZ+qGozqpqeKmvqlTkF/hK1 tiCUoa9d5Z8ZZBGl+zJ3eSY+MBVTPfH871wrFXc7bmm9iL9OzPnnomWfe6LW6+1l9sSwqwxMpIT wo5P+kDjMTJzHbi/t61Ssx6+jQ84g76m3uyc4dJk62BJLlQv3BH99uFC/v17VYemxsrvbNNGiMq L5HIfIXXFJx3jy5M3xpvcdq4F9hUOFcOBLUXz9pv8CDpk1stTqqz4D30cwhuYO4PWfvsUfHMJr7 ZOhB6BCANCrAH8j71Sr7btznPX6K8wHxPUIXRL2OOm1XB3/pjx8TkWNmb0c8vLX3/O73P61a74G HHpP24iTi8bhTcg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Basic description for S6E3FC2X01 DDIC with attached panels - Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio - Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio This panel has three supplies, while panel-simple-dsi is limited to one. There is no user of this compatible, nor the compatible make sense. Remove it from simple DSI panel definitions. Signed-off-by: David Heidelberg --- .../bindings/display/panel/panel-simple-dsi.yaml | 25 ++----- .../bindings/display/panel/samsung,sofef00.yaml | 83 ++++++++++++++++++= ++++ 2 files changed, 87 insertions(+), 21 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-d= si.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.= yaml index ac2db8cf5eb76..464d7c8a7665e 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml @@ -19,6 +19,9 @@ description: | =20 If the panel is more advanced a dedicated binding file is required. =20 +allOf: + - $ref: panel-common.yaml# + properties: =20 compatible: @@ -56,8 +59,6 @@ properties: - panasonic,vvx10f034n00 # Samsung s6e3fa7 1080x2220 based AMS559NK06 AMOLED panel - samsung,s6e3fa7-ams559nk06 - # Samsung sofef00 1080x2280 AMOLED panel - - samsung,sofef00 # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT L= CD panel - tdo,tl070wsh30 =20 @@ -70,30 +71,12 @@ properties: reset-gpios: true port: true power-supply: true - vddio-supply: true - -allOf: - - $ref: panel-common.yaml# - - if: - properties: - compatible: - enum: - - samsung,sofef00 - then: - properties: - power-supply: false - required: - - vddio-supply - else: - properties: - vddio-supply: false - required: - - power-supply =20 additionalProperties: false =20 required: - compatible + - power-supply - reg =20 examples: diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef0= 0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.ya= ml new file mode 100644 index 0000000000000..527a10e3b798e --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,sofef00.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SOFEF00 AMOLED DDIC + +description: The SOFEF00 is display driver IC with connected panel. + +maintainers: + - David Heidelberg + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + # Samsung 6.01 inch, 1080x2160 pixels, 18:9 ratio + - samsung,sofef00-ams601nt22 + # Samsung 6.28 inch, 1080x2280 pixels, 19:9 ratio + - samsung,sofef00-ams628nw01 + - const: samsung,sofef00 + + reg: + maxItems: 1 + + reset-gpios: true + + port: true + + vddio-supply: + description: VDD regulator + + vci-supply: + description: VCI regulator + + poc-supply: + description: POC regulator + +required: + - compatible + - reset-gpios + - vddio-supply + - vci-supply + - poc-supply + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + panel@0 { + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; + reg =3D <0>; + + vddio-supply =3D <&vreg_l14a_1p88>; + vci-supply =3D <&s2dos05_buck1>; + poc-supply =3D <&s2dos05_ldo1>; + + te-gpios =3D <&tlmm 10 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; + + pinctrl-0 =3D <&panel_active>; + pinctrl-1 =3D <&panel_suspend>; + pinctrl-names =3D "default", "sleep"; + + port { + panel_in: endpoint { + remote-endpoint =3D <&mdss_dsi0_out>; + }; + }; + }; + }; + +... --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ED9D2356BE; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=nB26rHTpQ8ZZvN8dSt6zfw51QED78jYxonShQnvYmxJwT3qCBNv+3ho9U4982dWCnlup6m/MEvC7MfGjwzRJSLo1TYoiDsStYYY77N69o0wwNFAG/6ifKpWf2+4lqrgy9mhQdSxk2GldvyhhQtMvwmPWvSo5iD5d17VxFIiD+Ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=Qi0+yC6UACKgnI2+CloHBOde0gf8t+GaLz9m6VZbpgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JLbQnfrGCrUv59vK1r8Xb4p4DVT/3H6ORY8lbg+V+fJl+sabPD9LN3VMNsK3CJXuPEt7Av4W32QBTV3xej/LpB/dEHZE8mvanl4PUjiv7GRx6PrQ31eBDNm2bLkHmEdM1BV7tHVs3yelCvjXWXrVvkrbqGjQKDe/t/dYtawxaRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NkLdYHXN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NkLdYHXN" Received: by smtp.kernel.org (Postfix) with ESMTPS id 95DA2C116D0; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=Qi0+yC6UACKgnI2+CloHBOde0gf8t+GaLz9m6VZbpgM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NkLdYHXN72sizE6eqF2ZjGwHgyPLqdA8LaijD+n2Mi575EGIGI2Vo/VM7Ayf8ykNd DgGyqpgjTAxhXmBRYrMyHZkbPVLiL72DyhyiNEaGy0PT9uYOstCRPDCTDFF4aCE92i EtKRgr25GbalUKqzBtIHxFPLAT8ytwwVgFvOOzcucw1sq5RFNkMoyymZfet+Xl1MW6 +r8XlcI8LnXDKQsaEVAcRNS8hOY39A9XjQ9M70AeNsFa3T75UUFjGLzOrx0qU4GtOY Gve6i0J0JhhdpaFk90AAyG61sQrP55U5vpSBQEUiBJAMtvoaYiSVffda0PjJ8LRM2B IPUwnIUWenO/Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85209CCFA0D; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:10 +0100 Subject: [PATCH 02/12] arch: arm64: qcom: sdm845-enchilada: Specify panel name within the compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-2-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=890; i=david@ixit.cz; h=from:subject:message-id; bh=gC1Y0XFWgXtqr21a8lQBohbuf2aAabfAVdPVUFhXq/o=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnsrefsVG8yAxscAoT5RPZOEbQJHkjvDDqUhp 4qXbq5I9QmJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7KwAKCRBgAj/E00kg cqtbEAC5gs+xlucpqIFCsdjxNByKIGfdOjoxZG0SHTZ16xG7TmDOwLvQdXOWphPKQl2a/GS++fC rWkI79nS8ZZTNCMqXBNiDA63gcdfAV71sOS9hgZVOOTYs9299wlSThIeQ7lib9UPzcGj6XeEIvX fLVYCABOblvN+Qr5xtE7UQ8yR0Ec2ftxb9egSX0DPop3fAW0Z99YZxZRbDthmP+lkD8wg+KHteV UusTrX2WXWk1ArdT9a83+RXnG6ebJEMp91ersFpyXaPHtYqleOZMzXSjpDQVCYVHualKvYI8qg6 ppxjDpCBc8ceJJfbSNAXFbJ1wajoInunlutixL1Wkf/GAgIVgpMRKOQSPoD9xQAe+Wg3p32+frI 37T0EuXDyIQjeZHB9qvAWFMZUXVKXZKBa5GVtqN2oAl3+qbSg6ecGhfZUDzbVDraxrcWtu1/RPN tK8SefyF6rGCwesQ6sQTwHV8zkOJPrh/NG0bBGkp8HUmOe/EA7zm0mutXvu51SGItE67so1ZtCW a5CPynaqjk6X/g/SrIHwcCvVMPejjZ8jHe6+AyslJb0Mz+24hZtY2yE1ZuN2atmTPtkDf3yIQ5Q K351c8f01gUScN4fy56kmQfBGUI7K0loSanWLxZJW6w/pXWkCtqxzYN8yoZwJoC0dnoixUcQTYk BLDJKoY/YcuCU2A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg sofef00 is name of the DDIC, it doesn't contain name of the panel used. The DDIC is also paired with other panels, so make clear which panel is used. cosmetic: sort the node. Signed-off-by: David Heidelberg --- arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/a= rm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts index a259eb9d45ae0..8aead6dc25e00 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts @@ -31,9 +31,9 @@ battery: battery { }; =20 &display_panel { - status =3D "okay"; + compatible =3D "samsung,sofef00-ams628nw01", "samsung,sofef00"; =20 - compatible =3D "samsung,sofef00"; + status =3D "okay"; }; =20 &bq27441_fg { --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE892D061F; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=JEJzTPnhH4xYFnNghZfhrnWtm50wN0SiSiKvNDHIcwwX3TrGxK7m2wOTgpiJ34glF7Lw7S7R09GHmkrByvdIVyBhDoUdag2SZ++uG0ZGzfeQrbyPw0DyUEb6DWRVHKwX+djRHoY7z9C/tH2Ar12PLZh2lB9yXl8vVAcNQmDZenY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=egR4AL+LaPLN6NG2HehYd+MOAw7qcr62Ps1E3HU1X1I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ImQbU5F7XmbW9J6oKfj218yFA2a7MP4J2ODnhewfqa673mHDHMclnO6synh/YXsuPsMXGdB3FfQm4UkWz1bZ+hKHEw0ApSPkMIqPAiwuhFhS0R5ksTdjYElgFH1x5gFU0LtTQ1BpU8MAFXHB6YR5rs9pHG/iaH/TnRpOydHdPXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nSK1kkFd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nSK1kkFd" Received: by smtp.kernel.org (Postfix) with ESMTPS id A5175C19421; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=egR4AL+LaPLN6NG2HehYd+MOAw7qcr62Ps1E3HU1X1I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nSK1kkFdff+t5sT7+H0wqN31UUVow06mN10SAn0tPxbs7RA4MvxQBCFQtJCjgxYpa K7jwZT/0Dri/09XknezVmXwv4/3Msd3ZH0LRyEJwzl11pb6fKrP4q8rkhaiypHNoMW F0CFAZKrsqPKJbcsJbLRLfgP0WboWBlJxiDLm5oaVrO9eBUk7pS2At8lSQa+pO1nCs 1oaykvCJlyAbTG9o4gOoOHuh7tyGx+6p63u96yRoPsra1Cy9B5OztFD8qe77MWjlhQ Jt5pHSEWMoqAkLd4j6GKun1oZeOv9/gnILOZXhqRatJrLw+jged/lsHKhQ6PM3QiRu EpkPL5sOgwnpw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1D6CCFA04; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:11 +0100 Subject: [PATCH 03/12] drm/panel: sofef00: Clean up panel description after s6e3fc2x01 removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-3-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2398; i=david@ixit.cz; h=from:subject:message-id; bh=Tdo9B853+u45bPiZrtcM4vLFZtgNYIKOGwI7Qd8WyHo=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnss6m/xMnOrr9iT10hP1+vEnzI5f4krDVh6A 4nEMofrszKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg cotfEACo8El5qi+C7R3YMofHslfSXPvSnfEJKGp73NLxFMXTr8cqx6L0hg2fNabEXu/fP7DjKnn tI8+WWlcGnpIg0jZh4twKuuzc7JtRzLrj+mv3rBE1OBacjpFBmInLHvWl11Oc+OAc+YCF1/y6y3 tTF9b8KaZS4HDr8s+U8+E2apACCxDd591/5ujFPiI8u/7g5y/25G93OlvHzb97tHc54TeJsX8mw mJLhpu2fYeBVk2d/JkyuU/TwXKVtPXFZo1K9swIA22MrS+jAmttCpSOIM/Fu1Ic9jizL94xPVMW ia55xNbZrv+TT41rSRBEmmPRsqfTv7UA6qjt2yH/gKAhaZTemJ65xQD/EmSrkSnn0qP281Cjwgj 0OgI2FcjHhwCubNa+5QSAvlAYlUUVdYRkgd1Nr1E4ljrh8P0AFuke/EXJdpAItynqzU9eZF2vGp PrqC0t7YuW23B96mkEF5dIzNufcw20untev+OrVZm0mxgGN5liSbka1JJxgXuwKZd6+n9sgfbGn yJg3bnSP+hircJcF7KBkQ/3lvaj211+AF/Cvh+ZC6aLQRLfNcwQBboC45auLfqESFqXLlHqm2H+ X7jocDWJZ9SoZRxYDejcKS5kgb4B2h8JiXgUSLR5u5lAMQWv4I3zHRhjXkAXbaOuOXdA3KZKWaD S8d8IAaVgfYV3Pw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Remove leftover from s6e3fc2x01 support drop and clarify supported panel. The Samsung SOFEF00 DDIC is used in multiple phones, so describe it properly and generalize. Fixes: e1eb7293ab41 ("drm/panel: samsung-sofef00: Drop s6e3fc2x01 support") Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/Kconfig | 7 ++++--- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 407c5f6a268b2..3442b1be6424c 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -868,16 +868,17 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01 DSI protocol with 4 lanes. =20 config DRM_PANEL_SAMSUNG_SOFEF00 - tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" + tristate "Samsung SOFEF00 DSI panel controller" depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE select VIDEOMODE_HELPERS help Say Y or M here if you want to enable support for the Samsung AMOLED - command mode panels found in the OnePlus 6/6T smartphones. + panel SOFEF00 DDIC and connected panel. + Currently supported panels: =20 - The panels are 2280x1080@60Hz and 2340x1080@60Hz respectively + Samsung AMS628NW01 (found in OnePlus 6, 1080x2280@60Hz) =20 config DRM_PANEL_SEIKO_43WVF1G tristate "Seiko 43WVF1G panel" diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 064258217d50a..c88574ea66e1c 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -252,7 +252,7 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { .probe =3D sofef00_panel_probe, .remove =3D sofef00_panel_remove, .driver =3D { - .name =3D "panel-oneplus6", + .name =3D "panel-samsung-sofef00", .of_match_table =3D sofef00_panel_of_match, }, }; @@ -260,5 +260,5 @@ static struct mipi_dsi_driver sofef00_panel_driver =3D { module_mipi_dsi_driver(sofef00_panel_driver); =20 MODULE_AUTHOR("Casey Connolly "); -MODULE_DESCRIPTION("DRM driver for Samsung AMOLED DSI panels found in OneP= lus 6/6T phones"); +MODULE_DESCRIPTION("DRM driver for Samsung SOFEF00 DDIC"); MODULE_LICENSE("GPL v2"); --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B6C2D2481; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=HfaUaVUSfC0kKRtYnkpbEUd9fBZiwK0GzNh++gOxFpJDj7Fxmk+aB8J26pr6Zw6hyiuM/INTsd6TrXKAJa5bFJ+7Y/WabAUaRTqLXz/5qzupo5i8mY4Kg/YuwtfpU6/QGatKKHJX7y+jukM3Vc2/zdjYTaBtIyOIYIbFt+8XTW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hWzzhsaCHisNupgMc0jRmRTLDriXjE+cw5eBHDClgIkfOggzJF+mIDPxGO4vAWL1iBSv6RSHlemEgjTqDbE7SKFCQWTuVHGd2y/Z8L4p2vn6FzKJjv7ZEr3S7fntHSooaBdHWaTBDfOfXQ56tU9KVcmZgUSGWwtyX5BYZgOiIXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UW5wGZVc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UW5wGZVc" Received: by smtp.kernel.org (Postfix) with ESMTPS id B5AD0C2BC86; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=W8AFvq4nPlynSNPii3uZ58RgvdVO7lLIvRxVluTsVZY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UW5wGZVckGK0GKF668EgLOhR40cPbdEtXAASH8clVwkw/O1jf1mi8AkXaT2aVVBDJ QinM/jZmkilQgaFaPoG4LP6Xk+xW24he/PXiAfQvLX/WdQtKRDnBpS6v2uijn/fmza j/pzPkrvmJ02PMmbzvjb8cfla1tUqrQUax8H/RqaH+pY3rVj01Qypqh9w+JdJfkLzi gwiqSNbHEDkDrlCfzHRL+48PranDsVgQL2NEB3KL38syyA3AcDhFCkpl2+C+UwQWlz CfS/GVhYXWKqquoV+AZT3lpoOU6amEwMacF4ngjCT/giiZBWPnrjQqYFkRmh1kJHLC Q3i7uGrCr4fUA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC6D4CCFA07; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:12 +0100 Subject: [PATCH 04/12] drm/panel: sofef00: Handle all regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-4-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2667; i=david@ixit.cz; h=from:subject:message-id; bh=mwo54CYnw7MO3Xycn85wubPyOShFMxI9iCM2JhaFHcY=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssiWzEUYXzfPzUG+DAUG0W0WdxEhSI7H1YW 2IlnexEXQmJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg ctB2D/90SCTjo1p9cHBtAqaK+mOEBhbtYlwQ4rtVT98t/Vjt5AGeRi378dC1fgJ6C3onmmFagh2 WbRWCFA1mH3fIqf3mBPo4/FB9rdSFtGvCsEiG5n7ek5ZwgGXeQQTtigWUfSGwb/zBSejVG8aYxJ qtijRxjHaN44V8YdY/ki2pONEIsn9krZkekeLxtrAq6XHyTCYNy8cqacXDyC6EmHhh5MRIHG67I sM6Sn+k2yq/I3Nci38H6GInWtqgCHvMibDbD5IQjo9hLoFpZ+IdQgeyQ3jvJo67csMsS6Gx3J3x PTtR2mPW2J+JT+E/pVBPEOE2mSmui1y/ltIAkSFfLAQDbRNIrRarYy/mDsErMLV1Khz1t6VThe1 vhvSJwpPMWIFdyJJ/YRv5WMb7Aez/bLM08NasIY5Zi04NkBIcgimj4mTNykq4T5z+tCBVCTFLaD DaBpq2zIwofhkDsfOcNNGFTQ+RzHdtbdkv2gZyo0qzGOyfRvwzUkrnK04j2Cyqs/eDMh0Bfd/nS y7Qsm8nYEwlm+oQULb+dMkJEpZZH4OoVCbU+R0lco4f9udlNurWVcgZGZf23dWnce7bZ807MIRd 7fX6IcOdKlxqmKbh8Z8AeE/z/16ZKY1t2+rfDWReQwZvfBCL/QSkHwHp/4PQnYSpCCMVwh97P/g Z7BuA5nEe7FahEA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Recently we documented, there is more than vddio regulator, adapt the driver to work with VCI and POC regulator. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 28 ++++++++++++++++-------= ---- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index c88574ea66e1c..3097040e6bfa0 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -20,10 +20,16 @@ struct sofef00_panel { struct drm_panel panel; struct mipi_dsi_device *dsi; - struct regulator *supply; + struct regulator_bulk_data *supplies; struct gpio_desc *reset_gpio; }; =20 +static const struct regulator_bulk_data sofef00_supplies[] =3D { + { .supply =3D "vddio" }, + { .supply =3D "vci" }, + { .supply =3D "poc" }, +}; + static inline struct sofef00_panel *to_sofef00_panel(struct drm_panel *panel) { @@ -86,20 +92,18 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) static int sofef00_panel_prepare(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); - struct device *dev =3D &ctx->dsi->dev; int ret; =20 - ret =3D regulator_enable(ctx->supply); - if (ret < 0) { - dev_err(dev, "Failed to enable regulator: %d\n", ret); + ret =3D regulator_bulk_enable(ARRAY_SIZE(sofef00_supplies), ctx->supplies= ); + if (ret < 0) return ret; - } =20 sofef00_panel_reset(ctx); =20 ret =3D sofef00_panel_on(ctx); if (ret < 0) { gpiod_set_value_cansleep(ctx->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); return ret; } =20 @@ -111,7 +115,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); - regulator_disable(ctx->supply); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; } @@ -197,10 +201,12 @@ static int sofef00_panel_probe(struct mipi_dsi_device= *dsi) if (IS_ERR(ctx)) return PTR_ERR(ctx); =20 - ctx->supply =3D devm_regulator_get(dev, "vddio"); - if (IS_ERR(ctx->supply)) - return dev_err_probe(dev, PTR_ERR(ctx->supply), - "Failed to get vddio regulator\n"); + ret =3D devm_regulator_bulk_get_const(dev, + ARRAY_SIZE(sofef00_supplies), + sofef00_supplies, + &ctx->supplies); + if (ret) + return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 ctx->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ctx->reset_gpio)) --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B0E2303CAF; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=ADFEUyIz1CH8aLz07zwxMyz4AkXTjuZ6QV1ZQTyxxGFz2SVmQotDj2Xp0AbsZD0/fYHFcFIHcdgtfbLzg67BNRPKc4cCrqGyCwF2zPnzHtR6ZX/NBImIno9ZvSTozKQVcGOrn2an15Eec7pEshE3sMmoFumFAHX/4NeWo+PFVUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gaZDtsRp4UAYx2n4OjRNp+LCGeFprLTuiFKKyLq0DoTROfexC/sMvfqEIiSE1mgSXT00BIgT/ntpbW58Zaxvn/VUyFnoVnvzLxb1La/Bl+yn4lBBFKHw1e6o2dO/BEtM9W59Mm4o4pNDab+9oddeMm9kYGNqWskKCxrKKCh0cLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a0aFKOZv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a0aFKOZv" Received: by smtp.kernel.org (Postfix) with ESMTPS id C47E0C2BCB2; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=h8mvhLF2NQpOEhwrwGAXO5y7raG5Pj5KKGwO1xu0Ls4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=a0aFKOZvkvhEDlTa5cMFRL9rusxny15Xlhj1RPtrxNGgST3jYqYo0AMKpNFaIBhFN Yr5pAzvC0wvBoMbbzLVfjqdIt8aQAFdcD8XYLQms8LJsDIEGw3+f77UrtJbatHfNPc a5TCKh/pOiVB1r6fQU6poGoNNCn7Ggw0VtIbE/ef8KKFLvb82PTLCIQxkNgj9bHQVs JGPXS5iODIpGbNMW1TXAzruk8dQ4QGMwOUh19x8do8nF8/NYlu40gNWLPtx5a8IKX1 LXkVQ5WUKyJk7gRDvaBEOFXG6LzNgr6nNfdFuXzonekOvyg+T5EOPw+MKmzDnwP5fE DaR4EJFZUYHhA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC52BCCF9E3; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:13 +0100 Subject: [PATCH 05/12] drm/panel: sofef00: Split sending commands to the enable/disable functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-5-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2045; i=david@ixit.cz; h=from:subject:message-id; bh=xfG4W9ai59WdRLt2V9HKjqKsc6sEspLbINOP0a9yxjE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssyU0Ni6Uz+R6/hYInvMj5WikMvIXDn67Vb yQm+YBjgL2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg coB1D/0cpWD2B+LMcgXVvUPQMqkVqVc06siMY4PtpSKd6OWRRvzz/OLtwJpn7+UlibB87rpFPJi EzT9BnqVPLOETuAJsqSRqP5Q/CF6vJ5kBE2OVFOHwQ2++nZcSF+Xl2+sBI/+83n9C500R0KY6Em 0aGGrzsbnssImazgCb+3Y7kjfkqQwexffvqzwNDb4al7Mc63zqu+lSv8/S/kuF0KC2v2g34LIwG LDlVDPCo83YCHnVgi8mLquAJePnyLUXFv2sQhYTh7ppjamCcns8/rgkOY1jX1zOQG2cNM4DAOVv hcJCwC5aoALX3kYdibRjbmaDNAlJrae2rxfHlEkScwlFuA7aNy1Z2O/nPYiBJLjFo6/Zv44A3oW MlD1gq5of1+NLTOPn5539JPeVWGG9OoJyUXWaVrMlyrYnpUtMTDFrnm9MrBfrfHztkFUx5rpaUl hIOZb9iDtaYCnvfWJaqouyfG5o9yYTQzZ8EMKCfQiih7hkN1869wCtky/rn7a8HSEWuQpXTRHtW 40lOWVHCrCJyHFtPzweLLJlZeqgHwiubY59h7UXNlgJZX5s6RUpxw8dhMU5EOQY/37AL2vSgdty tnTBuTYwvVozyPknK/snmdXxnQC08bgyjH1RTClMdJRBpoDl1CpSahYiuVA03SbM6NVZGU1vPEq zvWllsL4Y9wlKvQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg It's not possible to send DSI panel commands in the .unprepare. Move it to .disable and do similar for prepare, where we move the display on to the .enable. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 3097040e6bfa0..a3651f0060bde 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -68,6 +68,14 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 + return dsi_ctx.accum_err; +} + +static int sofef00_enable(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 return dsi_ctx.accum_err; @@ -110,11 +118,19 @@ static int sofef00_panel_prepare(struct drm_panel *pa= nel) return 0; } =20 -static int sofef00_panel_unprepare(struct drm_panel *panel) +static int sofef00_disable(struct drm_panel *panel) { struct sofef00_panel *ctx =3D to_sofef00_panel(panel); =20 sofef00_panel_off(ctx); + + return 0; +} + +static int sofef00_panel_unprepare(struct drm_panel *panel) +{ + struct sofef00_panel *ctx =3D to_sofef00_panel(panel); + regulator_bulk_disable(ARRAY_SIZE(sofef00_supplies), ctx->supplies); =20 return 0; @@ -154,6 +170,8 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { .prepare =3D sofef00_panel_prepare, + .enable =3D sofef00_enable, + .disable =3D sofef00_disable, .unprepare =3D sofef00_panel_unprepare, .get_modes =3D sofef00_panel_get_modes, }; --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6102730BB8C; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=U6IEMGQP1yN/DPySaljMgaiDTU2slgQySk8/VzEqhC4YK7Xxyd0XwYIhdBCbzt4O4TDVPjZsKA22KveCDVx/tT/26daNXwzcKialJthhfE0lv4athU+0Z0SfD05XB0PF5vdm6GhjZ6bGTmEua1N7Uiyvr0fl6AIz42maWvroFUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IbG+OseB0w1+QPi7Pb4v70Ojlus394LyhcYG3SR2whhbAXqY/QlOnkhJDx52/0jqr96wRI9FWgw3klJxuoRX4OQNYtdfvdtyINJUQV/5Ze2uGWoZZFw4FStnT8wPvr7oo+jS8GXvmcGV4LeuVuiUJfCZAewQkADIzjHqLs3GQiI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rp+4EEng; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rp+4EEng" Received: by smtp.kernel.org (Postfix) with ESMTPS id D5A8BC2BCB6; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=38ck5RCR0LO2rWCNSIq2uzpHXbhEGR1CpmwmHrfKicM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Rp+4EEng/p6YDPtSUCCc0N1DfXz61Wa8XvHZ315SneWGEJDSm0ZvQua0oOkUUoz3j Zlu0g1jVzigV7sxJcEE5ho4J9p4KUhfteTF10Q42OeDv/7MVEvJ3QE/cql66skR4NT vic1tXG5YbkcoNxb2gVUIz0SVvGDvRsRAzth2xW8XjDZTncncorYH2nnRMTRCGxScm yMXL+C68w3tnlIXgwrdKBW66D7Fw/20UIIg0qHi5iSM8KMD3fWSPm6hI4WesBE1Cqj uRVtvmkHNDMmwYN3Q8xxGlF51EBEICs8S9l9xCA8wdKSbHTTojoZ5Pt8XkwMfT4Eoo RmMtcrH14DPWQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB048CCFA0D; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:14 +0100 Subject: [PATCH 06/12] drm/panel: sofef00: Introduce page macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-6-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2024; i=david@ixit.cz; h=from:subject:message-id; bh=KFWwy/+TPv3o+Pr2om1zoaTzQ1nmZjY1fcOyZY+O5S8=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssKl2JvbVAIAyvYQM8vZGahsnkSpWb0WPDy bQmljI0h2mJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg cq75EACDoWk8cQdRNuWiIq4qRV4qTj5eVnUk0PlrGaMWjvlDvDF2A5RHr/DOSLn79g5posLE15Q AobRHXayu/Mdr+dk4z2BYsekvbPY9FIc1b2UoZuvZqeIgRnM71uJF0b1MHcxkA/Hu7a9Rqa8zkS Ej/96tBjjiDUnOfivFei4Wm5B648h7juKTT+S2qYzvWP/iJr7Tm665JD6Zjbfdgqzz8O0R7x9KQ FUG6T4Xm5ZIoeudOB1Pb3KuRnzgdc8JW9Ccr4BIKxgG66vdj+bjXXaAylml6rtZHAfsrJ10MAu2 lfPXUbkWvRAS+RLEYMrr4JJmTpAoBvept3BNSmtB2e5a2P4F+KPXTxaV6DWhdoF6dE0gUqXH9Jb qSFVmvHuIUlrrGrHVf1gsVp7AmxRKypKV/BzvRgXhpjVBV9o2pixpun8ACQq3tXQYwJ/7RaGR4f WHobmCOZnSly5ORn37GUGjNzMUwCh5wAJYfH5j4PC12RHkkCfh7F03/W9FnUI2E/PUC9oBSvyf7 CCi01iViD6zDbn+ADIvIRhS+P1uFGNwbth3D+TLVYE6llaVT0eVXDNtiBrJNoSwyOOUlwLU4pH9 sDTapc+kudSIRPhuowQW1NNfF4LLqvN4z92tGZUSb0YGpqfqB14XDJM5jubZMGGAmBfg+Q8UO7E /xpx+xeQ9NWv2XA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Introducing the macro make the code a bit clearer. Looking at other Samsung drivers, I assume it's lvl2, thou due to not available documentation it's only educated guess. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index a3651f0060bde..97122ec8872a1 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -36,6 +36,11 @@ struct sofef00_panel *to_sofef00_panel(struct drm_panel = *panel) return container_of(panel, struct sofef00_panel, panel); } =20 +#define sofef00_test_key_on_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a) +#define sofef00_test_key_off_lvl2(ctx) \ + mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5) + static void sofef00_panel_reset(struct sofef00_panel *ctx) { gpiod_set_value_cansleep(ctx->reset_gpio, 0); @@ -56,15 +61,15 @@ static int sofef00_panel_on(struct sofef00_panel *ctx) mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); - + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK); + sofef00_test_key_off_lvl2(&dsi_ctx); =20 - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); + sofef00_test_key_on_lvl2(&dsi_ctx); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0x07); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0x12); - mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); + sofef00_test_key_off_lvl2(&dsi_ctx); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 20); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D1A8307489; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=UlU/HYext6/mbfESbRld8xWA03GLyHTEg7Dev0WlFMxWwm6Et8PVUmMOXjbaPvV8wnFcUf2GbhajWy66JZdg4t5eb7vuR3JPjLVDODcuPa9CbvnCbzHzUVt24PfRtolrlvrwpKijeJF1PpXSf+xd/kKHKkfVmnP98QASqob+h7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iaaF/73tr518JNT3TdGvFxgTCiBDlL8NYX0vsUwCzKIc1NmFo1gqe+eGEC6W23SD5RXNI+AM6oRe4dd8ZxcEf0h5Eyj5OH5P57Wz+W5IIoClV8yvtUB1dlgWzPbgId9wJdqZeRdzWJAecoCrS9yGql1yg07JtMyuqSrb8JWHi6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OMGXr2iJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OMGXr2iJ" Received: by smtp.kernel.org (Postfix) with ESMTPS id E2C0DC2BCB3; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294574; bh=Bx37k0L1IbjcU9mqRIdk43KBpDeg4zmaNkPRXHOD9Wg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OMGXr2iJf/8rsWuWsRkQEUCt+QG848alhmv3H82egl+ikPpaD+geGALpMg533n1tR b5KshPhiU9pnog0sUP4pd2HD2Z9fVsksteHP1zLrX0ErslHeZIBdjbvQM8VFxq1R4j kSHUDwUV82/NcdO4f8CYrMqwpQWLCQC6A15cOlInEJrAV5uDJEqqTjA/ZnVP7UXh3d 6w+r0F5BnlhuN0jkAWYVtFZ9uDWEfhHeoxFeNW5XrlXg8ysDAiDM32WbHy5LMmOzik yHrxdsESXox1uNyvJg1D08VVy7MrRD8+yZvLXsqVoCyxBAWZeF9YwLQ+w3Tf8KvsZ6 ZDgVi4+VuIy6g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAABECCFA04; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:15 +0100 Subject: [PATCH 07/12] drm/panel: sofef00: Add prepare_prev_first flag to drm_panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-7-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=918; i=david@ixit.cz; h=from:subject:message-id; bh=4SM9hcft9HxR/OcdKpSF5Ee1W0Jyu8dLyBp//WZCcbk=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnss+C9hk8uD4rNM/1XSy6pPmwJAizKBdA2Tk +J08t4NnMOJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg ckpzD/sGiOdjJOm67e/IWCJRiB70hkmMzwyd7d2X1z27QAASZbQDVydTNZ6yBZPkWcYHqe+a7PG qE4V4j27CFp3Ks7KZKWcqBw+la5eWDawaBHsOrgxgEUoBFj2WOsOdLjGfSaotZMjwXVh6w9/qpY EboGao+eScyFL0p3wP/DNJ15mmbIJvRZ/D5jxNjNvrPoVmrTIb//y5Fi8nVZMU8P5Vc0UIbgpvo zniS3Vs8zxet5f++N/VEs8MeSG3kI2qSZ7c9/17NQmGizFjojUd0LqpBkJ89OPJNKPkLxbRoQpT gwBchZoh18w7tnfhVFEdhvM0gIQjdN2FMRxMJKAzNBDMEc16gQ1da34gEFfaA7J0zlJawO5Ok+7 SLGEySIfPvat/echxOdjop+X8H4Mjhnk4XPjI/xIVmXYbhbYHoE6pRKWm++sIAEDourhE06vr34 jdgDtjJe6g08+7dFznx4A6HxkPemJR8NqY0WYD9X7hH2zjVkIgdE7Lr5BTraQwPayCuSPPMrcFC jtf/6a2sUlStigVdz83Z1Yd7edf/gpKuyFwZ48aJVK/WHz1E2oMP2ZkmifyTU3YU3VgI+xk2qFW 6S0WcWoI2rnaH7YNLOmB3LGy/va8bKB71QsAr7l4nOg1TdsDnR0mXYloCgWqAzXWIg1A3EFvPnY tzxRrQfx8vbCrkQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly This corrects the host initialisation sequence so that we can send DSI/DCS commands in prepare(). Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 97122ec8872a1..0d3ae0689a19b 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -242,6 +242,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; =20 + ctx->panel.prepare_prev_first =3D true; + ctx->panel.backlight =3D sofef00_create_backlight(dsi); if (IS_ERR(ctx->panel.backlight)) return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E97C2DAFA9; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=oMl16ejjZZ6mcuOXGn/OsjaMPe0SuiTrGVdqOkhxGba3ZHjVdIjg02SwcCGW8GNALQCptjCyxpPmTHhfCrfsZ22VhFUyElbXm2itMx2WG2OyjqMoo9j4r5dwIh5bIusZajEziIH0GDOh474z/R/bekBD5RS5ERCluWOWbCfLlkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nH9AV1MRMZdn6C86U24kQIN6gZZtVNWcHmAgLmLlIleHpoC7XxeaqpUs08h+L7sdSOYb/HpqFBWRia63ZxAbl6ZCHWQydKbX8cdUs/E2O59+gE727+6465AHvIyXTMllrIN4XwjNJUlnMenBBTOlTEdmn20G3dwWGm4qFAFonr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=seNth5R3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="seNth5R3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 03B0BC2BC9E; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294575; bh=f6GfQjehkKWl/LGMGUh9JdpxtbOydSanZ93bKCsBU8c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=seNth5R3IyH7LK0QzOAyE2VCQjWoZVAFlDhYgYhsJyyTwSIpMNVjEzXBzBKtx8Obj ECT2N8L75b1BQpi5oiKkGQUCwEyL859dfUvuthDo4GwE6zBtPu8qsXWSKXaKx2yOZQ k+iTnqWK9InbT6ZBRpITkfbqm8hdBaoM+4osSYf43mFi6l+rgfHLXYpdee6au7zjJP qbqAlLFdf07UtJJu9gIS5M6ZdFV1hRylMVOAPjbQS3G3F0hGXfqKpfZD3bYmdB8eQo +T9FA+efGaOPaIY7sF75tlUYfraPFO87QQmFBkMxTDfocj98iqqRh3lYq/XCsazslK EGwSGxV0AWPzw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE929CCFA0D; Tue, 4 Nov 2025 22:16:14 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:16 +0100 Subject: [PATCH 08/12] drm/panel: sofef00: Initialise at 50% brightness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-8-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=858; i=david@ixit.cz; h=from:subject:message-id; bh=vjrHJH4EY6FJhDpprnzSkcksIGyeb+RoENa3mCki5mI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnss7ioIaB4Vn83ddXF7/bWJwnVZnrJ7v1T7z rUkYUUTU2uJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg cqbcEAC7O0ACBx2lh2Z/DMIYqPFPfs7X6TdoUa0MoUDHyWseBCo5JDa0JYVyUq51CJldk5EljHW dB1FrnKzy1E80sbj8eRvDPh5Ei+8KfJW/fGdNWNZRqG/765s+oO5R0o5d5tpv4KnuDYwaoi+TkT 9pMWFAHOO/9mKnt5TTfjFu1On4guFnprjl3LmwIavRekvC3hg7ymj1Zl+bJXQIIYy/imvb6WPbS o/YcjzCBedfldstrg1EzP7ChVY9ygQf0fIh3fUX14pO/JBctpH/RWjlENskK29aNDQOLkC9pqPl 2Ybzt7GFnyEHsccVTVCtNpUh1Mlng5eNNrz2YElGPFdI4HyZ/cIDFh6waXAtV3lPw/heyj6rM5P SledLJjM6B172MzWItLynytxNNXrUamWMwyyBv6pvQ6w57XaRrjEMZaLEYst9kiayA0wdcOsbDN A03l33lo+MrEOV2/BGe57U1SwH4eORWF+W5lwyY7KI0ZJwUNUwJCqU4xd/I4Ca6pzolIP2uSFA5 0bCVapWEajMQTxeDloNE/r18+KkjNrtFuh2vfWdWOgcJuQ+5XLnk3a8rESppmWao8x6cSyV6A+j AYhWSKKMMdCn/IyxQ4vTddOG+mGIj8Z11328vJxpLRmBCcHxIogcyHQc8gYek8e3GN+UgBGLeCY l0dtvu6UsiFoZpQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Casey Connolly Initialising at max brightness is not necessary. Half brightness is much more comfortable. Signed-off-by: Casey Connolly Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 0d3ae0689a19b..d1e5340d7e337 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -204,7 +204,7 @@ sofef00_create_backlight(struct mipi_dsi_device *dsi) struct device *dev =3D &dsi->dev; const struct backlight_properties props =3D { .type =3D BACKLIGHT_PLATFORM, - .brightness =3D 1023, + .brightness =3D 512, .max_brightness =3D 1023, }; =20 --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725BE311C1E; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=B8x8eMhExZQvOM8Z6D+vL7BQQO0DOfh2CJ1/05zrnz3D2wplVslpxF7VTJj60o/b20HphrO56G3e9CwD+5R/WfHkbeNLQTmq2J6FH4r+G723H44Kxz0Y3wMsJZQJydG2WWYRiaz6oOs+N+QQemCgEL/dqxBWhw33/lOK9HBN9xA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=tPw8QQtkgQ/ubzRfXEkVGYixKgB6MJOxqmk7tX3ogMw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U2PgKpKfLyjHPZI2yBF/dd7uerTzssZu9IAbRkH4shlLHVtRq7VLdRVbuBhUYUc8LbKvv6RygdcbkdbLekngeJgzFkG1pk+CC2oQhBzTxiAIrRwA4BSdWb5XHWGO+XNyL+nrpJX7swBMRH/dhgRwgT5F+sk+3nd49li/Qm7Qklk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DzHmzXed; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DzHmzXed" Received: by smtp.kernel.org (Postfix) with ESMTPS id 15A0CC116B1; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294575; bh=tPw8QQtkgQ/ubzRfXEkVGYixKgB6MJOxqmk7tX3ogMw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=DzHmzXedMuO81RjbAynWr2b6TupVquttktUSNQry65OsF0IC6aUuzLxVb8NTu26zS pUXhuX5kc8b3L7oGN/wJDLc2XCPlpnf0s3dg/8EMSUuyly0VqGJ5eSMB57rMouwFXJ DEnao42SljziSu0/NGCATHN1B8pkfYrm0NfL8wPz2/poajO25sTijUjJc7TPxtSFLT opp8lNYgiAJJS7xR3PlLe1BKSVyoW3HeaS92H+u0YRfQFl5KR6CKk5amwqQI0q4SMH 46wQdmFSctm4SA1GXczpxLYhjkdStbCMcOasW2A9dWU2f/9T6fVyZy2PMoKVf10xvr JENzKYbBaf9wg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDE7CCFA07; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:17 +0100 Subject: [PATCH 09/12] drm/panel: sofef00: Name of compatible should correspond to the panel used Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-9-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1576; i=david@ixit.cz; h=from:subject:message-id; bh=Q1+rieBGQ6VeDwGqVLQ0Szo7yx1/bCpLNjnwi01dWXI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssjt1R0WlC9R9CBT7rMfF1j9rawbA1vgPw5 uF09VOMmhWJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg ciIjEACdLKpaSOqpuNGJ6mcYFlJ/2DUTm7OCUG17xINWOVjF0L1sPhuNVtoA0DHr4P+0yAp56is kHxWCa6Mq3ggsm37Oz0NSg5U4M+7+PpUycKv4EMIBuThrGtKeTR+Pnq1UbcjPfQKuYFCQduC7Jq d8XeGsC+rb2FDqmhbF5CRzUZWbhs0XoAFh1wJb4TUNAzJ1pI1WAcbDyQnVUA0ISyV69ceVq6Yqd tqGRCj5UKf5RRUQh2HwIHDclrvH52UiWXYuRcSAEyPAGKpK+94wrWDDVX4WA7yTHWyGUBjveY+i Toy/fRW5vXowSJSYPE2gxDCWL3cLw4vIWorLpRqboJ6PIUHR7RRyRTUajRaETtJ8r6AyjIjxA55 CPXvbsPFbeWqiuam7PZTTPomDAw7e+xHSES4rkPOGE7oq/f7X3ot/gSKgvHCsDEfMUnK9dIzAqb dlupjSQ19/upqeygiGnbZ00TvaW4oiTF+NY51R5UPOuqxg7oYAWuWd3D1TngiGfKZQ2ogbubbOg xHVowEPtSQXM/JpBA5tEKDa32c9dA7fA7s9xet1eKixQLMxssoT1ukkh6zbXD1knL340Yw0DsQv rHEj7kkL+tiTVWEvzPZdtsQ3sESa3lZrZoWDQp51pWpYcD9OdfUbyFeVZ09YO3fwg9twNYrO8Rn cdiSK2g2Wcwn94g== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg At this moment we support only AMS628NW01 panel. Adapt also the internal driver structures to reflect the name. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index d1e5340d7e337..7947adf908772 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -141,7 +141,7 @@ static int sofef00_panel_unprepare(struct drm_panel *pa= nel) return 0; } =20 -static const struct drm_display_mode enchilada_panel_mode =3D { +static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, @@ -159,7 +159,7 @@ static int sofef00_panel_get_modes(struct drm_panel *pa= nel, struct drm_connector { struct drm_display_mode *mode; =20 - mode =3D drm_mode_duplicate(connector->dev, &enchilada_panel_mode); + mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); if (!mode) return -ENOMEM; =20 @@ -274,7 +274,9 @@ static void sofef00_panel_remove(struct mipi_dsi_device= *dsi) } =20 static const struct of_device_id sofef00_panel_of_match[] =3D { + /* legacy compatible */ { .compatible =3D "samsung,sofef00" }, + { .compatible =3D "samsung,sofef00-ams628nw01" }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, sofef00_panel_of_match); --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B8530CDB5; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=TAbU78QLq8uelfcKYn3Azbw7B38kJcXPsr4eh3jlmtI3UQ70QgIm5QJccdNQLv41JzYzbuiPnlk6SQoBPjXNKy+jxIOR+KzLXWj7VRCLkXer3GCR3bOKx/yHBlF5rr/GUBwfMOpHakg/d77jKfqoCeag7WTeELfJDLcGuDdQUEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=7kVUuFepyL1nqefy7/RVz/fzVOVxrSJ4iaI+ek8pJSU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=laFOwPVSWBNZzzsGygfWTMpLdSFfGpsT6WzRquvbk9E07uKcRtq71jnlSboTltGo7NuC8OMH1bf39+lbpG+S1CA4ZeYc9z/wue3RXGsvQqhkA9dHijbq+RhAD6SUXgPC9umCyscpoqD6cmBcfeLnnh9T99bKlVt/C6UXBKuyUOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FtOeuKsj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FtOeuKsj" Received: by smtp.kernel.org (Postfix) with ESMTPS id 254B6C4CEF7; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294575; bh=7kVUuFepyL1nqefy7/RVz/fzVOVxrSJ4iaI+ek8pJSU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FtOeuKsjrUfQ808ka0As0INPyczTyCWSDAgoX+Gyb/lbJfu0nfdcD5AHHtWtFIVIl K0c4S2KUQH8Q11G5vS0Q/REUwJQAiU1iqZARYyeNifWy+/ftvkhdfsaGntTpIzWi6H 2zzXkZWDr3bJDs0oihuHkr6CZvHKskiJq8Ro4g7YN6qvoRyZIYDTWmlKpwyk98iiCC HPAOnC2FGaTP5gmaklh+2+qwc1CiOZmI9NfEw9vLVsf43ED3JlChN3MDB5VZsftNGX yhiUWgRv8nFpCapqB5cs7wIv6QuD0yRV5o7L5ugvD+30rzqUKrXh5fJ/G7HIOFxo1O iDnHzIKY9IynA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6BECCF9E3; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:18 +0100 Subject: [PATCH 10/12] drm/panel: sofef00: Simplify get_modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-10-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1958; i=david@ixit.cz; h=from:subject:message-id; bh=8diXpj4flXvL6PBJCymDKTVmS7jlHjaf2gFdGCxh2WA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssTJrYITqvXoSfOpO1N/xmq6B/uzeG9TnlS DqYQuDIxfeJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg csOfD/92fqAeLGJR+XZi2fUT8DBSLFFuuY+d02H9N1VyZMdNS49uTPInJ2tXxfoaPXH6okErM6c jAhM9x4Jc12U+BA6h3RrWMseOYi4cdusav8PngmIbRCX1xHqrgmCVuFq08k71IFo5VWGsVw9nSz NSGLIFi+9JNr0uNXatGNHziS/31y4aiU+qDIWooJni1IHpYIILL+1dI32t41gqdAzT80rNi89kM E61JOFvwez//Cbu6a7i1rEFAp/sI2BTs6966n0i99mL2a5DdX5dW5g082+QgNJ5oP1r1k8uaHC9 4QVYgOwusiCgd7FnHg7KVVxkmfJ83AjcnjGPImLPeeTVx46iTkHAYieD9umEBPJ8he8wVw+Hz1D LPQTxG5Hm1tcoOUT59XHBboB5cF5u0JNFgX6lbCA87B/uGa75uzgplwH3lKMz7AbAcOXqyGntOc fKZwFXGAvZEsUxEAzdKR9Xe2BugFoO5uQWsgJ2+nJC1KYCDIAgYJPxNHPEgCfmqls0zGbqk4g18 3ugHyWRctJtD013BG82UTU2r6b9oNCSkViKwcoRAf2Wb0mdPHKBA8pC/HKXKrLZwPnCtUd85WVu otN8XtLJoiHtLRRr4d1Y48C0kB49ns1guGqlMuV5EcIFO7t8w+KBe3lKA+GsOb73Onbikb3q9MR 88oF6RPjtYEyjCQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Levearage drm_connector_helper_get_modes_fixed helper function. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 7947adf908772..e69a28628b656 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 struct sofef00_panel { struct drm_panel panel; @@ -143,34 +144,26 @@ static int sofef00_panel_unprepare(struct drm_panel *= panel) =20 static const struct drm_display_mode ams628nw01_panel_mode =3D { .clock =3D (1080 + 112 + 16 + 36) * (2280 + 36 + 8 + 12) * 60 / 1000, + .hdisplay =3D 1080, .hsync_start =3D 1080 + 112, .hsync_end =3D 1080 + 112 + 16, .htotal =3D 1080 + 112 + 16 + 36, + .vdisplay =3D 2280, .vsync_start =3D 2280 + 36, .vsync_end =3D 2280 + 36 + 8, .vtotal =3D 2280 + 36 + 8 + 12, + .width_mm =3D 68, .height_mm =3D 145, + + .type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, }; =20 static int sofef00_panel_get_modes(struct drm_panel *panel, struct drm_con= nector *connector) { - struct drm_display_mode *mode; - - mode =3D drm_mode_duplicate(connector->dev, &ams628nw01_panel_mode); - if (!mode) - return -ENOMEM; - - drm_mode_set_name(mode); - - mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; - connector->display_info.width_mm =3D mode->width_mm; - connector->display_info.height_mm =3D mode->height_mm; - drm_mode_probed_add(connector, mode); - - return 1; + return drm_connector_helper_get_modes_fixed(connector, &ams628nw01_panel_= mode); } =20 static const struct drm_panel_funcs sofef00_panel_panel_funcs =3D { --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 924993128D6; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=l/DNSWvkRm08YUYO4nG8vELLicItvEJAVYsfJVmWepZL6zDoL7rVSeFKjOHy6IqR9kWlp1NNDiBpX3xpkYEVNtbOAUHnA9UdJ8f7JaOW+bPbdwn8LGetfxdUF5LnN9g2nAU80gGpUGdqQSjdzmdL0pAPwKwdleQ/2XnuJjx4dP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=10XNWDQ1dULf+P9kZ2dHmDwf8V4xwRtNb2eTtETPwsg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uwh3Yqv5o4Nod7cp5MphvnyJoWyx7fQelaGbEloeRBkY5b1PGHUwliSjuPQDC96mQp5HDyPSlzAYIFJ3T3eX45Y4siF1cvu391VgAcxHszM58wIw33yVqvZIo5G5EkGWdngewWcHdt+bXii98Pje4vVDE2b7YtlaiJpf6iqCjxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tk1GSwmu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tk1GSwmu" Received: by smtp.kernel.org (Postfix) with ESMTPS id 36DCAC2BC87; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294575; bh=10XNWDQ1dULf+P9kZ2dHmDwf8V4xwRtNb2eTtETPwsg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=tk1GSwmu08uHO6W8kQkko4cOuYzNXpXlmEkiryf5TEksgQ/teM6geCbnwmjLvR0mc D5Qkdllt2GY44AVGc8DXZ8PMVtlAp0iLevi0Ueipg3Vj+IC2Cy7qDQR9yUihANhkvO 7DSPsauholZV+eb8oC/bTdO8foa2LeTiVlpjxiasOs/TkQJzUpYNkLw6SPuG0uy2KF C3VSLqjGWbPmp/Q8R3nRGCp0TzsZdmwTUhkyToh1D/e/WXPcL7FK4jZ976HWUTpNri txtkAe5dZ3p53F+mnrdJwkFi4s+ytaej4tFV8AcesgGy8c3FkDc5WnOkijzsdxegaL p4C/rx1UNwfdw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BEA7CCFA15; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:19 +0100 Subject: [PATCH 11/12] drm/panel: sofef00: Mark the LPM mode always-on Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-11-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1446; i=david@ixit.cz; h=from:subject:message-id; bh=dv4mgLKU6V9KA5Q8a78znnVTuWL2bX0IVKAwUPXHk8E=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnss5hUpSPsdjW0ukYNFOlQ+Ocni+pVvHaxBz bFmfbI4Y1aJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg ckWtD/4ygHvR0CvpB1cA8D2r355X7hHWLtpzCaCEo2h29/XoojxCI/rXsvGT8mZPfFIiaI8on1O OFVxVBeO3obIlKmJBZT50fPKsWH1HGIyt4R2ruN/nzuzjMu9NZmIXJJfJVd2tPDxq9kvZIxt9+M ZIH5vfyjU1v0qbEZjHPNj5/8kQg7P/ShsF+XOULB0sGfvLbwLxyIpyRthhqfAR5PTjoPtD26mon 5Pilf4fDZzzXy03+KxbxzdZEzIZgk3RgPGx2slG8ZOY9beymJlZggMysUjrXNpwluTIzUBlpZZu pW5KrK1M0iv3XqjCqFRriNP5D6czdOK4jehb0ZPZPESHDdnKMXyMLzfIgSuzl+dlgXH8fUXeUld wVlKofGQV4ef8mrBD4aIiIN9HrWyR5UpwLGYC7t8oJIVmnXi8yG58pT63Oc8V/mrOXJ6jPeshb/ hPxU2qpUHSnL5fq/ac8YPX8kam79jJrq2swoPdrhVwKZppvq6lAA0Po/FKc3luaOeicGJkWBN13 I3ANyxg3/1aORK0tgRyfEGvz5pi2wRCMstU0+kbMD4QL6pEGW7uAjmGzk605NGB1UW+sHeW2oNC i1g799xbgN3F3+CySS2WwQ+bT7bDzXB01LWu3bzG3TZOaOztYELiQWvNFqMaEsMxMaq5qvQdABF Pz2qlswvD7yvEEQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel operated in low-power mode, with exception of changing the brightness levels. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index e69a28628b656..8286cad385738 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -92,8 +92,6 @@ static int sofef00_panel_off(struct sofef00_panel *ctx) struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 - dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; - mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 40); =20 @@ -180,10 +178,14 @@ static int sofef00_panel_bl_update_status(struct back= light_device *bl) int err; u16 brightness =3D (u16)backlight_get_brightness(bl); =20 + dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; + err =3D mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); if (err < 0) return err; =20 + dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; + return 0; } =20 @@ -234,6 +236,7 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; + dsi->mode_flags =3D MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0 From nobody Fri Dec 19 11:06:34 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC8730CD94; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; cv=none; b=PcjBkSaqMqvdxCnXcPlTS/2j180urZycvUHxcTb/0SMsH3GmhO30RzyqYc2sR1bmHdmIkJ1tFJQsx7aJYoscZWSGRFjZa9M/7z4jdHPYPw06Yo/U0legCMNkdgNrcMt4ojbRJmJk/Mhba4jbs8iDbdTlMkggReUBM6BKHIbZVqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294575; c=relaxed/simple; bh=sx3FdITHyUsho2TuXz9tyb+nFy6gs9cRfJfgUm1fuoE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YElEgrMfsVOXGb6AdQrn+hXqdgu9f7VtOepiKsNCQdztKOubcSQYO0f+ifat/wRoLz5ftncROh98Fk2Xx0sywdO1679+Nm0oU6teTBxa0bliE6ZNng7ya7L1vCL0vr3vbtRFu+D7mp/VOZsMq+okxx/rzI1HSByMbW2Pupjfzhw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WgAnnyCz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WgAnnyCz" Received: by smtp.kernel.org (Postfix) with ESMTPS id 44B8BC19422; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762294575; bh=sx3FdITHyUsho2TuXz9tyb+nFy6gs9cRfJfgUm1fuoE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WgAnnyCznasY3yysDSgfV8OnW+n2hqaS++bEjWzRm9c13sWp3b/KTRdXNcF3fguXb sRZMwyNRoOggYDYNfsjcCxiMxZYgEkncETOFjDAACXOXEUTa17HYKdZ8EHZmHHf6b+ /yWdEth8y3mQHuq2rIy0N0Wd6ucBBZMRJrbkdOO2fZzeIvAansrH4Zed390m8gY9yD i9GxWklJph+NU/sl9Zwzbq8LQTcac2TKGrzCA28CtDtbpCvDxbx0bHNft/RINWCpi1 MyQTo8NxoDwnRT+OPWTBKBvZClS+tth49WzHk0bYdOduj7MB7qtSvx1q3uDqs/MM1s JUl7XUFggCKVQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB8CCCFA04; Tue, 4 Nov 2025 22:16:15 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Tue, 04 Nov 2025 23:16:20 +0100 Subject: [PATCH 12/12] drm/panel: sofef00: Non-continuous mode and video burst are supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-sofef00-rebuild-v1-12-dfcfa17eb176@ixit.cz> References: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> In-Reply-To: <20251104-sofef00-rebuild-v1-0-dfcfa17eb176@ixit.cz> To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Bjorn Andersson , Konrad Dybcio , Casey Connolly Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=802; i=david@ixit.cz; h=from:subject:message-id; bh=OE1UAGoiypb8yw70x3xMaGL61XZlHwmG/9vzbFRjYK8=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpCnssHwg8Lskik0Sixi0f0lMdo/NU6KJS+qhtl c+BcqyrhcGJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaQp7LAAKCRBgAj/E00kg coP3EACq2H5LzaMgEuOSQdBm5V1/Z0IrgpWiiHh00ZeFLGXhSzhNbJyT4zifpu9FOMDE2JKiHwK e7kvGVDLhKE+e2bKTOF4xgW2gx9HoQcqHbuZyu2uuKASiT58GD50SDuWQk6hUHVB8rQRFuOrnzC 8Y7xnppScEJhsgHbf4hM4qWwptHFsL9IJY32cusiD2Y4vqsLz4WAasilNxd1xYNUjzqq5WiHTOS 7k6JGFPmZkPHvuFWaPN2HVIak8OxcEL21w6/lFdwRjROjDl5yDn6EwISDjmVgauAaAMXxZbg0tY Eza2y0tCWO3K4WLQN0kL7TWF8lcFx7PWJ7n9NtivduDJgnKUCVRQ1wMMFnO22+bIwRjElM9VSkk Vzmjk8nNAjXg1HKnrGKNNae6pf0H7ZSb2NGQFGqXB9fN54KEBUx9SamPh7CQaT5WGih+SVMj7SG 0XlTY/jkpXkLmDWPIlatE+jOQxwRfwpY/m3eybnCjHYx6ONZqt82WbFrl0IdLwwyfo1yQIJh8Bt zn7A3VVUrnWbpvbRoxuTaFFb0j9jpsGkTkGiEDScYxR+4QSZo39WUIPkSIEtWc5jIkPYn7VhxP5 XAsBYLWaW0bMfx+GXH4eD7TEgF4PjUdWas3prmx0BeWDzSdunxvHegoiUtrhg0DvNj5GOqmGkUq yb5CdZWYqCESkXw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg The panel supports both modes. Signed-off-by: David Heidelberg --- drivers/gpu/drm/panel/panel-samsung-sofef00.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-sofef00.c b/drivers/gpu/dr= m/panel/panel-samsung-sofef00.c index 8286cad385738..b330c4a1ad19d 100644 --- a/drivers/gpu/drm/panel/panel-samsung-sofef00.c +++ b/drivers/gpu/drm/panel/panel-samsung-sofef00.c @@ -236,7 +236,8 @@ static int sofef00_panel_probe(struct mipi_dsi_device *= dsi) =20 dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; - dsi->mode_flags =3D MIPI_DSI_MODE_LPM; + dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; =20 ctx->panel.prepare_prev_first =3D true; =20 --=20 2.51.0