From nobody Sun Feb 8 08:53:02 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAEC129DB6C for ; Tue, 4 Nov 2025 05:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762233084; cv=none; b=R7mRoBbOMKN5WS9KoJVFOYtOR4AB+E34nWS0YQxGK52ia000AGOQ5mbZLtoV1DAstyMxu4P1NUoQkri6/cwv7uugNqVzD9s9CP8U9ZeC1x/jFNC5SRM3AlVApJCihk2daieC/cZPJljGllWuK3EFBLcxqe0HiZl4ltwIEiPN+Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762233084; c=relaxed/simple; bh=DHiyPiHeVEJN7mXSBeHumDva6DT3sbfHswWFct5wfyg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=nwb1w1WLmZexnlB+MzJ7ytFYcw4wA8GygiBpXuBoS9bixUBTNvju5KHZAekY58IkFYrxhzsSLbhVkVusg0tOldRnpxLh9qdUPDB2GrpqMK3oOj0O61v3Q2xfcTqD46NONfvYoGDRGYsu4pjIAlcfyFakZHKOFCV/uS/p1AC1Ic4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kqa+LrTJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jQ0ULAtH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kqa+LrTJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jQ0ULAtH" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A433KMp3693649 for ; Tue, 4 Nov 2025 05:11:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=HGxYgLpY/C/ADuyIkMkTEA xGBXm7vFVck05iQr1eLLI=; b=Kqa+LrTJna9ST24P4D6cPRQJR5/tpp0BWA/MOw 14nQzBhZ6LlogSO7x6ssgH7WvU+Xwp2jC268pqI9oZi2RsFUrl7f0FWYwCaEzYsA X+yu60ma22Ld/zNDgfUzhLJ/XYaePgu2pcRvkrlNXIOj9zeDsS3w2pL26voW5dsh 7hAD9cDUAtAM7nRy7wSzqdFazHrMWMFfckbnlAEcZ2hwKxQtEWdhdsp00iZU2U5A QjyltEiAYc9npkpVjZdbR8HUweMcyuLXC5VaXP+vXS5TLqXLXBoHZGmQIIIRcF+n kfSwP1Hi/cCXYSobQ8HX+ZdRo03RZWXj/SlTQYGpAxXt3hQw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a6u8b2nu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Nov 2025 05:11:20 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-78117fbda6eso4790363b3a.3 for ; Mon, 03 Nov 2025 21:11:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762233079; x=1762837879; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=HGxYgLpY/C/ADuyIkMkTEAxGBXm7vFVck05iQr1eLLI=; b=jQ0ULAtH/QfdPIlfiFixsm1IBj7njzc7I9y1SUGlwwplG2cWZgsgcC6HuQn4e96caQ 6/P37aORW4LB1j91d/GpsRiE973FTPMyNSS9c5kp/ppr2Zhxf+UfBoRof5mZTmatHkBT XL1W7aUv+oyYX2y8SfPBGbD2SX1nZzuDD5MTc+LnYYXjr9PMLdw/e6RZ3S3rxnlTTl6I h4CDE1N5UKtN1V7jkJIjDdEFvOx6h6tEjg3ihogZydxl6vgRj35A2HEQT/AiJ4//QNFS GkaZf9leFeuwg/5Aw8a7o5f5r6r4wa8hvf4HJWMMCr6S85P7tFVM8ZSkdtNvqhTXwC6g jjaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762233079; x=1762837879; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HGxYgLpY/C/ADuyIkMkTEAxGBXm7vFVck05iQr1eLLI=; b=FvITu4WTmaMw3P9U0kesoo+KuCzIHIII5mYgj8AzTSJ5pWI0JkDEHsv9vtzLGaqHX0 57yRSaS6ubRA0Cro5oQ0cev46YXbdz3UUlBCJ7hFryid1REJy3S/fxc1l4gZ35/H0yvH jQXVyNtsak+ENn2UHJOFce28Ot2hUVbf871H7SKAITMWbuoq9UR6w1vOrX8Wvumkc/B2 i2fr4X/dfenU52vESPNF2JfbGI+eO12wJUcbtcbK7ZqtmeQTNvOxVmejq9wip1t96bBJ HLgrlWJI05ZIAPgAPkLKHIveeJ93qZQ7lZH/YgjRij9u0GP+gWP6qle+KYndsnNwlnoz rpLQ== X-Forwarded-Encrypted: i=1; AJvYcCWLzboqHPmVWhR1/7/bEr/1iQ70dIG5ovS0DC6aai3oFKHPAvg4iE2WdRPncAIlBUGqNQ+5vWT+njOc9ig=@vger.kernel.org X-Gm-Message-State: AOJu0YzK0q26VZsMrXOooVnqcFvWWSbmHTdDh99gPfw/oZIvyZVnVJb/ 5fT4yS6ol1J3UGYOMUQjXWE2MoJZWu7oi/KyViYeTam2yA4h8CkRVRMCKRVOIFdjgksahFuy4sc Bxfa0+o2tS193oWPXlztVpOqHq/6ZF2qHkaRm3RgsgLO/KCk6nUASKuB3hC8uKu+1BIdCy6NUCr Q= X-Gm-Gg: ASbGncuzO6SM+aEQHnD2SVAasOwtItPxAZ1SYX/g+jUfhfMUmRv2hoBvCk9UkQ5LcTU 0pAGTuB3KBhg+lT/HIKZaAAw56eCwulQsE0GTp94x0MmoJL5/ebOGMHW81+VVjXqEbFO/0j8dG5 ePs7FSJXF7yPSgJj/ipztHqcME8m5uzzHJV7vCXNqkai15vUtX6XJNW/SnxZSxfM4ROWZRg5q8/ uEoyWyyhud+txcrlfTZWCSZvGGWRnAvPiqVIwAHXAsLrecAQOQRTmw3qb72jZrku9kWdKepS6lo U12/x3yEsdqpvbJf76uL97CgoCLaTPUk1gvY1gY0ssI01gzxRoP/XVq/HxzgOUy1fRMWW6a18ia BM4pHuW0r3jhCHKwfwwfddqHth5hKFYrmnpPt X-Received: by 2002:a05:6a20:1a99:b0:34e:d23:8627 with SMTP id adf61e73a8af0-34e0d238baemr2662029637.0.1762233078704; Mon, 03 Nov 2025 21:11:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkt+l50JG82nuKGRNdLks7Qm1cu0wwhEVaJxoOeDjsHJo1bUqvPBeRutVWpmU3HpqbaBIn9A== X-Received: by 2002:a05:6a20:1a99:b0:34e:d23:8627 with SMTP id adf61e73a8af0-34e0d238baemr2661993637.0.1762233078217; Mon, 03 Nov 2025 21:11:18 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7acd392022dsm1331626b3a.23.2025.11.03.21.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 21:11:17 -0800 (PST) From: Dikshita Agarwal Date: Tue, 04 Nov 2025 10:41:05 +0530 Subject: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251104-iris-seek-fix-v2-1-c9dace39b43d@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAOiKCWkC/3WMQQrCMBBFr1Jm7ZRmJAZceQ/pIrYTO2gbm9Gil Nzd2L2bD+/BfysoJ2GFY7VC4kVU4lSAdhV0g5+ujNIXBmrIGtPsUZIoKvMNg7zRebI+EAVvCcr nkbjorXduCw+iz5g+W34xP/uvtBg0eOgvNlg2zhGdomo9v/y9i+NYl4E25/wFOkXetbEAAAA= X-Change-ID: 20251103-iris-seek-fix-7a25af22fa52 To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Val Packett , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762233074; l=2800; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=DHiyPiHeVEJN7mXSBeHumDva6DT3sbfHswWFct5wfyg=; b=Z9TEr7hhuODzz3lKHMGCc9oSH1i9a8lzwSoCk8Crr3ESk21rKODCq7LNR8agdj5bnh4bDRoaP f7NP7MwEi8PDuHLkAypsMaACeWn2bU3NnNtx9WfwIjsKtVZbWHAEPaa X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA0MDAzOSBTYWx0ZWRfX2Y1/UVKpvrKU 8oHDtr8Cefso4yckKKb51zFmRHK05n92bdI4vrvLgu0FkX1CqRf4sHoCyDpZalaF6B3N2dxBrc8 SXSEcZX+a+BVFPCaLglpwJoPAqJPHqTPzPHJ7HOPmKoQE0hKeKUgDM9l9lEEcebqYA1/nkB3BCn q8sS0JdfLCgFypD9gJaLr9wPv8ncWRNDCGiIS2TUP4G26B8opnGRinn3XjyCKEYSN+CSSq+vEga jOUlErvWZy4VoRFdsUwO6UNOe24qG4gUek7ttLedu89SKU2G/N8WY5ddomHle3QK2aO7SyuZkQQ SJOGQznf1EIwPctyjVI8I0RMVmadQwgMcl/8gUmRwk7G8kt7B9e1iapA8i44xnJs8sn2BsufOva YJfse+fy/hFCRqfWfr4gCbsJrGY1Vw== X-Proofpoint-GUID: QfQbmU_j4aQLEfmbDKR8BBQMtHOUw5Ku X-Authority-Analysis: v=2.4 cv=Ha8ZjyE8 c=1 sm=1 tr=0 ts=69098af8 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=i3jFL_YYMMiQr-fRWD0A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-ORIG-GUID: QfQbmU_j4aQLEfmbDKR8BBQMtHOUw5Ku X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-03_06,2025-11-03_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511040039 Improve the condition used to determine when input internal buffers need to be reconfigured during streamon on the capture port. Previously, the check relied on the INPUT_PAUSE sub-state, which was also being set during seek operations. This led to input buffers being queued multiple times to the firmware, causing session errors due to duplicate buffer submissions. This change introduces a more accurate check using the FIRST_IPSC and DRC sub-states to ensure that input buffer reconfiguration is triggered only during resolution change scenarios, such as streamoff/on on the capture port. This avoids duplicate buffer queuing during seek operations. Fixes: c1f8b2cc72ec ("media: iris: handle streamoff/on from client in dynam= ic resolution change") Reported-by: Val Packett Closes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4700 Signed-off-by: Dikshita Agarwal Tested-by: Val Packett --- Changes in v2: - Removed spurious space and addressed other comments (Nicolas) - Remove the unnecessary initializations (Self)=20 - Link to v1: https://lore.kernel.org/r/20251103-iris-seek-fix-v1-1-6db5f5e= 17722@oss.qualcomm.com --- drivers/media/platform/qcom/iris/iris_common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_common.c b/drivers/media= /platform/qcom/iris/iris_common.c index 9fc663bdaf3fc989fe1273b4d4280a87f68de85d..ee377131c8419c434c85ec8e432= 1db39bbdecda0 100644 --- a/drivers/media/platform/qcom/iris/iris_common.c +++ b/drivers/media/platform/qcom/iris/iris_common.c @@ -91,12 +91,13 @@ int iris_process_streamon_input(struct iris_inst *inst) int iris_process_streamon_output(struct iris_inst *inst) { const struct iris_hfi_command_ops *hfi_ops =3D inst->core->hfi_ops; - bool drain_active =3D false, drc_active =3D false; enum iris_inst_sub_state clear_sub_state =3D 0; int ret =3D 0; =20 iris_scale_power(inst); =20 + first_ipsc =3D inst->sub_state & IRIS_INST_SUB_FIRST_IPSC; + drain_active =3D inst->sub_state & IRIS_INST_SUB_DRAIN && inst->sub_state & IRIS_INST_SUB_DRAIN_LAST; =20 @@ -108,7 +109,8 @@ int iris_process_streamon_output(struct iris_inst *inst) else if (drain_active) clear_sub_state =3D IRIS_INST_SUB_DRAIN | IRIS_INST_SUB_DRAIN_LAST; =20 - if (inst->domain =3D=3D DECODER && inst->sub_state & IRIS_INST_SUB_INPUT_= PAUSE) { + /* Input internal buffer reconfiguration required in case of resolution c= hange */ + if (first_ipsc || drc_active) { ret =3D iris_alloc_and_queue_input_int_bufs(inst); if (ret) return ret; --- base-commit: 163917839c0eea3bdfe3620f27f617a55fd76302 change-id: 20251103-iris-seek-fix-7a25af22fa52 Best regards, --=20 Dikshita Agarwal