From nobody Wed Dec 17 15:53:47 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D31A315D57 for ; Mon, 3 Nov 2025 15:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762183798; cv=none; b=KfKW9krGtLT00epc8aEfEoIHWv5RFxFOq5F2cJ9wjW/dl3F4/mUeOCbhLHwq4JMp0hXpC/BHPv8+i28xCoHDinmA9aKoOwHoiwC7XsfIFq5Gp0wMbaIX0bLP4++cdfszefmVbbQtCENuU4UPfl4JNTAgIWpoQqWlItrtFC4/6is= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762183798; c=relaxed/simple; bh=JdNpmgpvzDCtH5SZL/dNJAWTPkyCebG1SD4bGKhvhCY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UARscHtClWE6ddHzb69oO69mRbmd945MEUpbVAi7eJ7itmdUInjmOZoDtRdhCOYcmMmVpNU+FHAFuEJmdOH1M4joSL1yPRz0AZFt+SofdNnXjAkj/TkJBgeWjvAQecxlxX6UAQf5EsRWj9wXRdYUKSu4QoVDVEl+vfkyT/HtiiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W4p6p6ON; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fyoNUk8w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W4p6p6ON"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fyoNUk8w" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A3AS2FV2891119 for ; Mon, 3 Nov 2025 15:29:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Bq0Jp95HnB8 vIN8Lh3F/MO0AU8FS5qmwu14/WK/BGCE=; b=W4p6p6ON25RUmaYjgbID9g6Lutk fHInt32B9VwWiGxQ0u6kX1yQV+AkXz9viOj3GV0YJV6epGTpUAo/p8/gm0Hmc9OK TiD+3RCCWMVwMSA4q962WyONpNfA1DdSTA17z6Sf5f3XP8PbTVU+M7eKsRTPHtk+ amDr/5ySzMREd7A7SYA8uww6qZLbOdzmMLEhBstKrcb656O88jqKuyKsHvncHlxM YSWEQXLWYbj7leiUiJvZYHn75niqZSS0cqfntlvuCUjNirEX/SYlq+uGnh6hdaLa 0WKL7Y8RixKZLoHEyoBDJ8dKg8vXjbF6TvzYeC64/g0ylGWWDcT+cjtDLkg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a6tnrgrkj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Nov 2025 15:29:56 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-295b713530cso13205035ad.1 for ; Mon, 03 Nov 2025 07:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762183795; x=1762788595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bq0Jp95HnB8vIN8Lh3F/MO0AU8FS5qmwu14/WK/BGCE=; b=fyoNUk8wyzyqUdrzFJ8lu2UpvlaM5ZxLNu9RMg8NK/qshKzb5Jy6jjVKIGmBm1x2ed A8A6xqUNi88DGgh9XnmaOgyDY6ew+CKIFWFsSGylZ8b/vxPVwh8Y9PBMsGWfs787b0C/ F+6BZ5DlRDaDJwJ2ygUosFJGicq9D7AzbFepPZXroefPa8jheooxfEDblFznr7xZlDhu w2RzvzgCF+eoWPp+YfBZVTQkynajNUBHyiDLXr3eII26r3fm6yOvBNH9A4liWU4aV1j/ Xk63v/R27Vvgu4KxfWEb/gKfYSIfoR/7wRjtW+YcnpZzV8tBFbP+7GU9WfnDD/U8HL8J oKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762183795; x=1762788595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bq0Jp95HnB8vIN8Lh3F/MO0AU8FS5qmwu14/WK/BGCE=; b=jnIntNnHz+om9jH640wY+wytsnPTTezGSTAdon0nf/l8NKgDMRvse763YGxq4E7fBn 3/9iw5nEI2Tc5y+lY8CAGLz6YOyctHvB1uUcL6UDMWEdJifdr4FOY9zH585C2HD+e9Ux FUzniDTAN42cXmOTTivv6ju/VdI8+24o1qodGzyJUh4EY+GnFaeEvJ1YEE1ubUcGVyv+ 61BQ2vIEx3aySgNicea4VgQPqtBs4cHJtkKRYl3Sm6Rko80nsTU2o3irCBSMQwQ5SCrP 74hmfPsuQAoLYLVa6yeVk35kR/4HoPg2xhhrE7dZi+v81QKsFAu0fUObUTsJsIiacLNS kBOQ== X-Forwarded-Encrypted: i=1; AJvYcCWs3dF9XhWbTuHwZuTWMlUC/Nf03tZAIOfABNMxRulSgxPvA82tLB9hNncrThGVOnKg0U3m2ke6hKoox8I=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx6owKnuaJm7Y9YHD52TS6Xj/m5WkcJPs/OGSduWPyFFP6GQtK A9t9w3jJFL6AnJOEBsRVRXIMvEuP9qGerade1TXuqLvHLdSaHDNbU1sQS8g+9aQbVG/tt06a/KI GJtcRvsd/D+LPPt2jrXZxSRITQ3xNkgDriJPmAT4oBfAI22muGfjdQWoJmPbqrh15d+k= X-Gm-Gg: ASbGncujRGwk8OtEFNEHf/AZ6/GZR8C4gs1IUvtF3aIbiGWwoe3Bfe4TuHyWCJ9VauT 4CsFde8Xh0U1T872pPlvmPH1xty/SJZgQ8qPXH0epdbvFw3nkQxVb4/CMVYUmZWVe0Qapues+1z ZEPtE3B7ktKwlfc25jioS7g9QmR3aXq/AJQ8aiGa+y0Y1eioNAI4tnNTABZUBWgbIf4IkiU/xJa HfwGRJy4rcRwfU7kvV0Lvamwpl3twUXh3OH7hmatcJs7wEQ5EKXRvM/A+qZaTlr0KgdA90sf3Jt KxgWSpcl009E3c8tEfE4sApviVEL6nnUPnA3FYGiEd38hhXzUfixhLqsVejB6P43ZBYZ67MpQfz 2G98YmsaQ6Psl2hplBjBeDlveby7F X-Received: by 2002:a17:902:d501:b0:295:6d30:e268 with SMTP id d9443c01a7336-2956d30e6edmr106985115ad.59.1762183794885; Mon, 03 Nov 2025 07:29:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkDOLc8z/fx45Y/zAydvBiHcowZMRZLZACMJmr/cQIxvEunHau6mXtknVxHf/vU0taSS7eMw== X-Received: by 2002:a17:902:d501:b0:295:6d30:e268 with SMTP id d9443c01a7336-2956d30e6edmr106984445ad.59.1762183794199; Mon, 03 Nov 2025 07:29:54 -0800 (PST) Received: from hu-deesin-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2952699c9dbsm126087675ad.84.2025.11.03.07.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 07:29:53 -0800 (PST) From: Deepak Kumar Singh To: andersson@kernel.org, chris.lew@oss.qualcomm.com, konradybcio@kernel.org Cc: jingyi.wang@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Deepak Kumar Singh Subject: [PATCH V2 2/2] soc: qcom: smp2p: Add support for smp2p v2 Date: Mon, 3 Nov 2025 20:59:29 +0530 Message-Id: <20251103152929.2434911-3-deepak.singh@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251103152929.2434911-1-deepak.singh@oss.qualcomm.com> References: <20251103152929.2434911-1-deepak.singh@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTAzMDEzOSBTYWx0ZWRfX/6MGEMX0nur8 +PoIHHml5muxd2imqaLwqp82hys7V9x/K7WpWFF+1fVWJl+U71g2Km2pMCaFHMRe5YW4rwhI6CG DIatuSqo1emvSmAxu7YB8rB4rALgjVR5mjYRMOnoLkdVFm5QhzU3JiTkJkNp8KZawg7me4XKjG3 IBGN/AfB5dhwvicjIQCxheofQpFkq6VdxDrZg9Je3UNdPuplQYbcT4lFVY27QK0bSFzvVlJbHr8 WXPLLTx1I6vHwla9YtWPU3JfhDj/ioDlh9sBuPGv2i0TTrtQGq3GtPdU3cSXhjbak+XPqm9xFqG eRd3btAVUeWkjFcjkaeS4rjiV+l2sCkhMg0aDsnpTFi9/nJzgqvU2HeK/WB2jws+AC3u++dA0Dy POK0k4H/xVVHGtINPpg1dbM02mi49g== X-Proofpoint-GUID: vMmDsvbMFoJ4iqaxLf-9DYNfPKiwekCe X-Proofpoint-ORIG-GUID: vMmDsvbMFoJ4iqaxLf-9DYNfPKiwekCe X-Authority-Analysis: v=2.4 cv=BrSQAIX5 c=1 sm=1 tr=0 ts=6908ca74 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Xvny5BtixxlE2jsoVxoA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-03_02,2025-11-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511030139 Content-Type: text/plain; charset="utf-8" From: Chris Lew Some remoteproc need smp2p v2 support, mirror the version written by the remote if the remote supports v2. This is needed if the remote does not have backwards compatibility with v1. And reset entry last value on SSR for smp2p v2. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/smp2p.c | 41 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index 39628df36745..c35ca7535c14 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -36,6 +36,10 @@ * The driver uses the Linux GPIO and interrupt framework to expose a virt= ual * GPIO for each outbound entry and a virtual interrupt controller for each * inbound entry. + * + * Driver supports two versions: + * V1 - For processor that start after local host + * V2 - For processor that start in early boot sequence */ =20 #define SMP2P_MAX_ENTRY 16 @@ -50,11 +54,12 @@ =20 #define ONE 1 #define TWO 2 +#define MAX_VERSION TWO =20 /** * struct smp2p_smem_item - in memory communication structure * @magic: magic number - * @version: version - must be 1 + * @version: version * @features: features flag - currently unused * @local_pid: processor id of sending end * @remote_pid: processor id of receiving end @@ -183,14 +188,23 @@ static void qcom_smp2p_kick(struct qcom_smp2p *smp2p) static bool qcom_smp2p_check_ssr(struct qcom_smp2p *smp2p) { struct smp2p_smem_item *in =3D smp2p->in; + struct smp2p_entry *entry; bool restart; =20 if (!smp2p->ssr_ack_enabled) return false; =20 restart =3D in->flags & BIT(SMP2P_FLAGS_RESTART_DONE_BIT); + restart =3D restart !=3D smp2p->ssr_ack; + if (restart && in->version > ONE) { + list_for_each_entry(entry, &smp2p->inbound, node) { + if (!entry->value) + continue; + entry->last_value =3D 0; + } + } =20 - return restart !=3D smp2p->ssr_ack; + return restart; } =20 static void qcom_smp2p_do_ssr_ack(struct qcom_smp2p *smp2p) @@ -225,6 +239,20 @@ static void qcom_smp2p_negotiate(struct qcom_smp2p *sm= p2p) } } =20 +static int qcom_smp2p_in_version(struct qcom_smp2p *smp2p) +{ + unsigned int smem_id =3D smp2p->smem_items[SMP2P_INBOUND]; + unsigned int pid =3D smp2p->remote_pid; + struct smp2p_smem_item *in; + size_t size; + + in =3D qcom_smem_get(pid, smem_id, &size); + if (IS_ERR(in)) + return 0; + + return in->version; +} + static void qcom_smp2p_start_in(struct qcom_smp2p *smp2p) { unsigned int smem_id =3D smp2p->smem_items[SMP2P_INBOUND]; @@ -522,6 +550,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_s= mp2p *smp2p) struct smp2p_smem_item *out; unsigned smem_id =3D smp2p->smem_items[SMP2P_OUTBOUND]; unsigned pid =3D smp2p->remote_pid; + u8 in_version; int ret; =20 ret =3D qcom_smem_alloc(pid, smem_id, sizeof(*out)); @@ -543,12 +572,18 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom= _smp2p *smp2p) out->valid_entries =3D 0; out->features =3D SMP2P_ALL_FEATURES; =20 + in_version =3D qcom_smp2p_in_version(smp2p); + if (in_version > MAX_VERSION) { + dev_err(smp2p->dev, "Unsupported smp2p version\n"); + return -EINVAL; + } + /* * Make sure the rest of the header is written before we validate the * item by writing a valid version number. */ wmb(); - out->version =3D 1; + out->version =3D (in_version) ? in_version : 1; =20 qcom_smp2p_kick(smp2p); =20 --=20 2.34.1