From nobody Thu Dec 18 00:10:57 2025 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 171CB2FC866 for ; Sat, 1 Nov 2025 14:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762007031; cv=none; b=FAPyXUGSWhghwtUx/+Jy9xEo0tav02iSfllUMhKhzPEgw3gXmfOuXOFCwC7YSRtGa9x7Hr45wv9Bb4YTHjrS/QvY06OHEhQPe45j4gxN8WzBRrZmxRuXFW/3SojVj1EZ6mevcFNnDljAVtx581OyuQ/RymnUS8cJv5xITTYFpnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762007031; c=relaxed/simple; bh=Oqtj3JWIeCIubS0ImzITam9qN03yIsBoqb2XmRHV0gQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jbTjjBUKmjox95x86v/J6N5Xa/3El1Cbbrp/RiIGNhhZ5sXRIrvcu+14MzCPBzYu/ObHwqLSakg/G0BGV+CXkXP7F7puaJwXadBl3vXnywteDt+GvxBwsRasXwxiuWnTPm+hA8qSehmhvbWVCLnhAICzy4/1JnC+LaT79Hqfx4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=EfpmVhp6; arc=none smtp.client-ip=209.85.217.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="EfpmVhp6" Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-5dbd150efe8so16714137.0 for ; Sat, 01 Nov 2025 07:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1762007029; x=1762611829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Y89e1Xc3DS2D9wc25qIhLt1elzzrVrlmI1KWnbpgyDg=; b=EfpmVhp6JcEhxU01fAVXy3zpa5VJopT6YsxUmzHJ7HTQhogkzVqTZVNPzaZROChJcX NjdqnoHaJTval7JoQS+TMXg6UtWtIlpflZVjWpiz047RUgnR83QLHzYN3naKo4AR4uvT W3+XatYzNkj1xoXhh7wUoPtiDwljaAbwtzMZ6yRUQkXjCVrQpTpFr0ZfoKmu5ZY5Ycq6 zEqHvLuiZ6XA0I7TNz8vVsA3c66dkAjXJIRjMitPwH0KOJmVP9ERAuR/7HdyW2GHVDXz H1/l6OrNlbe63RpZoP6LcLzvf92w9NZ1QnwYjhohRSFObLvVYCSZZ6uxnNU3n8X4Rp/s j4uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762007029; x=1762611829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y89e1Xc3DS2D9wc25qIhLt1elzzrVrlmI1KWnbpgyDg=; b=WwXBw9P5EvcAx5xaLES37St2ws1PdGFDYqtvMmr4nzknFSPObeJ3j7xYq4YT8DzXuX 3m/oQdS9pctoc6IcSa5MXmK2jEHU25ciH5m5z9n9jRzvYNymctaQ+cWwitc105GigPdE uuSeWghGGPbgK6ZoofOXZyQKwNkJOyamFnfyax6a45TVJDcFCSNLNHGwCzYd/xtOTKVW bgI1SefvXwYqQoJOa73hTVkfOProMfAlekK4OiKUtpKfd8isGsbpnrNzBY6zzaa6CItP 5i1yjBbBEgTRbFreqwPWx7fWP2qusBFAPFMfr3lHzGQ5pfvSW6AeXRvBTbHPdcJEyrVo 2pnA== X-Forwarded-Encrypted: i=1; AJvYcCXKAhEQAooyTn2buVpC6QNFuEDWIlJAi3B591cRlh1qbjPBAwDFzsUYXY8N1SIh1pNOQc7jBjVR3EkfcxU=@vger.kernel.org X-Gm-Message-State: AOJu0YzDtTeRFGJffdbnfiSDbBsiwh5EqvL1Y4pm080CHAz15ENK0eHF kHd8YnQT57Xrby+9SF1HjpWuW2RECsm4SdcbNUDjaNSXYsAndfHxMf3jHYxP0bzvgk0= X-Gm-Gg: ASbGncth1MPTstOpqC19tWBwLH7KChu77t6Jgf6HdebXwKfT91KtV/L6nOztpw95cVY 4kq3JED7BeVwpfNBUUzi0sTiqK4N2/G3qd6F7QERq4famMUGwWC5CGrMh00mHpoDC8cXNOlZKJn Hd4PrTsiC0Ia2+/vuaz1cuc2oDAR4G0VaYln0LIt3APvo8O61qajMh8Bm0bIt0gmE4nag6s4PN4 M7QNGJQzzwsco0ydflE83hHB4MelXjMuUocwlbGDz0Z2Og7WY+S+m9gGBW7/Dlf81ck2lD82KM0 /ocU1bbXCJY39qIDNQxuEFVX6pIWFPYZiaDh268g3HpxiNvbHkhCrmIfjNjhFGRi46UhoJLHOSy 96awVcloZYNyVXeJtji50eUv0HrDXiyyX6SG1FwVvQ1FwHtYu8JtOuPgeekb4PV290HeDDKxS7+ 1CMn//rQmq7LVywcfBuSIVAhHBQ2hdaOGjA9kzHS4WwOB9N1VafUdG3oO0urs1 X-Google-Smtp-Source: AGHT+IGFDCScfqliWb9KcrLwkQzx/ze/7HdLlm3rrxqjpvvjEhbQ+nHt0IFtgECikftA3CUT6aFcGQ== X-Received: by 2002:a05:6102:441b:b0:5d6:5e9:9e0c with SMTP id ada2fe7eead31-5dbb11f02d1mr1796389137.4.1762007029092; Sat, 01 Nov 2025 07:23:49 -0700 (PDT) Received: from soleen.c.googlers.com.com (53.47.86.34.bc.googleusercontent.com. [34.86.47.53]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-559449647e0sm1776242e0c.3.2025.11.01.07.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Nov 2025 07:23:48 -0700 (PDT) From: Pasha Tatashin To: akpm@linux-foundation.org, brauner@kernel.org, corbet@lwn.net, graf@amazon.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, masahiroy@kernel.org, ojeda@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, rdunlap@infradead.org, rppt@kernel.org, tj@kernel.org, yanjun.zhu@linux.dev Subject: [PATCH v9 9/9] liveupdate: kho: Use %pe format specifier for error pointer printing Date: Sat, 1 Nov 2025 10:23:25 -0400 Message-ID: <20251101142325.1326536-10-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.51.1.930.gacf6e81ea2-goog In-Reply-To: <20251101142325.1326536-1-pasha.tatashin@soleen.com> References: <20251101142325.1326536-1-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zhu Yanjun Make pr_xxx() call to use the %pe format specifier instead of %d. The %pe specifier prints a symbolic error string (e.g., -ENOMEM, -EINVAL) when given an error pointer created with ERR_PTR(err). This change enhances the clarity and diagnostic value of the error message by showing a descriptive error name rather than a numeric error code. Note, that some err are still printed by value, as those errors might come from libfdt and not regular errnos. Signed-off-by: Zhu Yanjun Co-developed-by: Pasha Tatashin Signed-off-by: Pasha Tatashin Reviewed-by: Simon Horman Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Pratyush Yadav --- kernel/liveupdate/kexec_handover.c | 4 ++-- kernel/liveupdate/kexec_handover_debugfs.c | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_h= andover.c index be945c133a2f..167c761988d3 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -1448,8 +1448,8 @@ void __init kho_populate(phys_addr_t fdt_phys, u64 fd= t_len, memblock_add(area->addr, size); err =3D memblock_mark_kho_scratch(area->addr, size); if (WARN_ON(err)) { - pr_warn("failed to mark the scratch region 0x%pa+0x%pa: %d", - &area->addr, &size, err); + pr_warn("failed to mark the scratch region 0x%pa+0x%pa: %pe", + &area->addr, &size, ERR_PTR(err)); goto out; } pr_debug("Marked 0x%pa+0x%pa as scratch", &area->addr, &size); diff --git a/kernel/liveupdate/kexec_handover_debugfs.c b/kernel/liveupdate= /kexec_handover_debugfs.c index 46e9e6c0791f..ac739d25094d 100644 --- a/kernel/liveupdate/kexec_handover_debugfs.c +++ b/kernel/liveupdate/kexec_handover_debugfs.c @@ -150,8 +150,8 @@ __init void kho_in_debugfs_init(struct kho_debugfs *dbg= , const void *fdt) err =3D __kho_debugfs_fdt_add(&dbg->fdt_list, sub_fdt_dir, name, phys_to_virt(*fdt_phys)); if (err) { - pr_warn("failed to add fdt %s to debugfs: %d\n", name, - err); + pr_warn("failed to add fdt %s to debugfs: %pe\n", name, + ERR_PTR(err)); continue; } } @@ -168,8 +168,10 @@ __init void kho_in_debugfs_init(struct kho_debugfs *db= g, const void *fdt) * reviving state from KHO and setting up KHO for the next * kexec. */ - if (err) - pr_err("failed exposing handover FDT in debugfs: %d\n", err); + if (err) { + pr_err("failed exposing handover FDT in debugfs: %pe\n", + ERR_PTR(err)); + } } =20 __init int kho_out_debugfs_init(struct kho_debugfs *dbg) --=20 2.51.1.930.gacf6e81ea2-goog